1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
|
// Copyright (c) Microsoft Corporation. All rights reserved. See License.txt in the project root for license information.
using System.Net;
using System.Net.Http;
using System.Web.Http.Dispatcher;
using System.Web.Http.Properties;
using Newtonsoft.Json.Linq;
using Xunit;
using Xunit.Extensions;
namespace System.Web.Http
{
public class ExceptionHandlingTest
{
[Theory]
[InlineData("Unavailable")]
[InlineData("AsyncUnavailable")]
[InlineData("AsyncUnavailableDelegate")]
public void ThrowingHttpResponseException_FromAction_GetsReturnedToClient(string actionName)
{
string controllerName = "Exception";
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
ScenarioHelper.RunTest(
controllerName,
"/{action}",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.ServiceUnavailable, response.StatusCode);
}
);
}
[Theory]
[InlineData("ArgumentNull")]
[InlineData("AsyncArgumentNull")]
public void ThrowingArgumentNullException_FromAction_GetsReturnedToClient(string actionName)
{
string controllerName = "Exception";
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
ScenarioHelper.RunTest(
controllerName,
"/{action}",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
ExceptionSurrogate exception = response.Content.ReadAsAsync<ExceptionSurrogate>().Result;
Assert.Equal(typeof(ArgumentNullException).FullName, exception.ExceptionType.ToString());
}
);
}
[Theory]
[InlineData("ArgumentNull")]
[InlineData("AsyncArgumentNull")]
public void ThrowingArgumentNullException_FromAction_GetsReturnedToClientParsedAsJson(string actionName)
{
string controllerName = "Exception";
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
ScenarioHelper.RunTest(
controllerName,
"/{action}",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
dynamic json = JToken.Parse(response.Content.ReadAsStringAsync().Result);
string result = json.ExceptionType;
Assert.Equal(typeof(ArgumentNullException).FullName, result);
}
);
}
[Theory]
[InlineData("AuthorizationFilter")]
[InlineData("ActionFilter")]
[InlineData("ExceptionFilter")]
public void ThrowingArgumentException_FromFilter_GetsReturnedToClient(string actionName)
{
string controllerName = "Exception";
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
ScenarioHelper.RunTest(
controllerName,
"/{action}",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
ExceptionSurrogate exception = response.Content.ReadAsAsync<ExceptionSurrogate>().Result;
Assert.Equal(typeof(ArgumentException).FullName, exception.ExceptionType.ToString());
}
);
}
[Theory]
[InlineData("AuthorizationFilter", HttpStatusCode.Forbidden)]
[InlineData("ActionFilter", HttpStatusCode.NotAcceptable)]
[InlineData("ExceptionFilter", HttpStatusCode.NotImplemented)]
public void ThrowingHttpResponseException_FromFilter_GetsReturnedToClient(string actionName, HttpStatusCode responseExceptionStatusCode)
{
string controllerName = "Exception";
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
HttpRequestMessage request = new HttpRequestMessage(HttpMethod.Post, requestUrl);
request.Headers.Add(ExceptionController.ResponseExceptionHeaderKey, responseExceptionStatusCode.ToString());
ScenarioHelper.RunTest(
controllerName,
"/{action}",
request,
(response) =>
{
Assert.Equal(responseExceptionStatusCode, response.StatusCode);
Assert.Equal("HttpResponseExceptionMessage", response.Content.ReadAsAsync<string>().Result);
}
);
}
// TODO: add tests that throws from custom model binders
[Fact]
public void Service_ReturnsNotFound_WhenControllerNameDoesNotExist()
{
string controllerName = "randomControllerThatCannotBeFound";
string requestUrl = String.Format("{0}/{1}", ScenarioHelper.BaseAddress, controllerName);
ScenarioHelper.RunTest(
controllerName,
"",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
Assert.Equal(
String.Format(SRResources.DefaultControllerFactory_ControllerNameNotFound, controllerName),
response.Content.ReadAsAsync<string>().Result);
}
);
}
[Fact]
public void Service_ReturnsNotFound_WhenActionNameDoesNotExist()
{
string controllerName = "Exception";
string actionName = "actionNotFound";
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
ScenarioHelper.RunTest(
controllerName,
"/{action}",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
Assert.Equal(
String.Format(SRResources.ApiControllerActionSelector_ActionNameNotFound, controllerName, actionName),
response.Content.ReadAsAsync<string>().Result);
}
);
}
[Fact]
public void Service_ReturnsMethodNotAllowed_WhenActionsDoesNotSupportTheRequestHttpMethod()
{
string controllerName = "Exception";
string actionName = "GetString";
HttpMethod requestMethod = HttpMethod.Post;
string requestUrl = String.Format("{0}/{1}/{2}", ScenarioHelper.BaseAddress, controllerName, actionName);
ScenarioHelper.RunTest(
controllerName,
"/{action}",
new HttpRequestMessage(requestMethod, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.MethodNotAllowed, response.StatusCode);
Assert.Equal(
String.Format(SRResources.ApiControllerActionSelector_HttpMethodNotSupported, requestMethod.Method),
response.Content.ReadAsAsync<string>().Result);
}
);
}
[Fact]
public void Service_ReturnsInternalServerError_WhenMultipleActionsAreFound()
{
string controllerName = "Exception";
string requestUrl = String.Format("{0}/{1}", ScenarioHelper.BaseAddress, controllerName);
ScenarioHelper.RunTest(
controllerName,
"",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
Assert.Contains(
String.Format(SRResources.ApiControllerActionSelector_AmbiguousMatch, String.Empty),
response.Content.ReadAsAsync<string>().Result);
}
);
}
[Fact]
public void Service_ReturnsInternalServerError_WhenMultipleControllersAreFound()
{
string controllerName = "Duplicate";
string requestUrl = String.Format("{0}/{1}", ScenarioHelper.BaseAddress, controllerName);
ScenarioHelper.RunTest(
controllerName,
"",
new HttpRequestMessage(HttpMethod.Post, requestUrl),
(response) =>
{
Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
Assert.Contains(
String.Format(SRResources.DefaultControllerFactory_ControllerNameAmbiguous_WithRouteTemplate, controllerName, "{controller}", String.Empty),
response.Content.ReadAsAsync<string>().Result);
}
);
}
[Fact]
public void GenericMethod_Throws_InvalidOperationException()
{
HttpConfiguration config = new HttpConfiguration();
config.Routes.MapHttpRoute("Default", "Exception/{action}", new { controller = "Exception" });
HttpServer server = new HttpServer(config);
HttpClient client = new HttpClient(server);
// Ensure that the behavior is repeatable and other action is still callable after the error
for (int i = 0; i < 10; i++)
{
// Make sure other action can be called
HttpResponseMessage response = client.GetAsync("http://localhost/Exception/GetString").Result;
Assert.True(response.IsSuccessStatusCode,
String.Format("Successful status code was expected but got '{0}' instead. Error: {1}", response.StatusCode, response.Content.ReadAsStringAsync().Result));
// Make a request to generic method and verify the exception
response = client.PostAsync("http://localhost/Exception/GenericAction", null).Result;
Type controllerType = typeof(ExceptionController);
ExceptionSurrogate exception = response.Content.ReadAsAsync<ExceptionSurrogate>().Result;
Assert.Equal(typeof(InvalidOperationException).FullName, exception.ExceptionType);
Assert.Equal(
String.Format(
SRResources.ReflectedHttpActionDescriptor_CannotCallOpenGenericMethods,
controllerType.GetMethod("GenericAction"),
controllerType.FullName),
exception.Message);
}
}
}
}
|
