1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
|
// Copyright (c) Microsoft Corporation. All rights reserved. See License.txt in the project root for license information.
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using Moq;
using Xunit;
using Assert = Microsoft.TestCommon.AssertEx;
namespace System.Web.Mvc.Test
{
public class ReflectedActionDescriptorTest
{
private static readonly MethodInfo _int32EqualsIntMethod = typeof(int).GetMethod("Equals", new Type[] { typeof(int) });
[Fact]
public void ConstructorSetsActionNameProperty()
{
// Arrange
string name = "someName";
// Act
ReflectedActionDescriptor ad = new ReflectedActionDescriptor(new Mock<MethodInfo>().Object, "someName", new Mock<ControllerDescriptor>().Object, false /* validateMethod */);
// Assert
Assert.Equal(name, ad.ActionName);
}
[Fact]
public void ConstructorSetsControllerDescriptorProperty()
{
// Arrange
ControllerDescriptor cd = new Mock<ControllerDescriptor>().Object;
// Act
ReflectedActionDescriptor ad = new ReflectedActionDescriptor(new Mock<MethodInfo>().Object, "someName", cd, false /* validateMethod */);
// Assert
Assert.Same(cd, ad.ControllerDescriptor);
}
[Fact]
public void ConstructorSetsMethodInfoProperty()
{
// Arrange
MethodInfo methodInfo = new Mock<MethodInfo>().Object;
// Act
ReflectedActionDescriptor ad = new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object, false /* validateMethod */);
// Assert
Assert.Same(methodInfo, ad.MethodInfo);
}
[Fact]
public void ConstructorThrowsIfActionNameIsEmpty()
{
// Act & assert
Assert.ThrowsArgumentNullOrEmpty(
delegate { new ReflectedActionDescriptor(new Mock<MethodInfo>().Object, "", new Mock<ControllerDescriptor>().Object); }, "actionName");
}
[Fact]
public void ConstructorThrowsIfActionNameIsNull()
{
// Act & assert
Assert.ThrowsArgumentNullOrEmpty(
delegate { new ReflectedActionDescriptor(new Mock<MethodInfo>().Object, null, new Mock<ControllerDescriptor>().Object); }, "actionName");
}
[Fact]
public void ConstructorThrowsIfControllerDescriptorIsNull()
{
// Act & assert
Assert.ThrowsArgumentNull(
delegate { new ReflectedActionDescriptor(new Mock<MethodInfo>().Object, "someName", null); }, "controllerDescriptor");
}
[Fact]
public void ConstructorThrowsIfMethodInfoHasRefParameters()
{
// Arrange
MethodInfo methodInfo = typeof(MyController).GetMethod("MethodHasRefParameter");
// Act & assert
Assert.Throws<ArgumentException>(
delegate { new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object); },
@"Cannot call action method 'Void MethodHasRefParameter(Int32 ByRef)' on controller 'System.Web.Mvc.Test.ReflectedActionDescriptorTest+MyController' because the parameter 'Int32& i' is passed by reference.
Parameter name: methodInfo");
}
[Fact]
public void ConstructorThrowsIfMethodInfoHasOutParameters()
{
// Arrange
MethodInfo methodInfo = typeof(MyController).GetMethod("MethodHasOutParameter");
// Act & assert
Assert.Throws<ArgumentException>(
delegate { new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object); },
@"Cannot call action method 'Void MethodHasOutParameter(Int32 ByRef)' on controller 'System.Web.Mvc.Test.ReflectedActionDescriptorTest+MyController' because the parameter 'Int32& i' is passed by reference.
Parameter name: methodInfo");
}
[Fact]
public void ConstructorThrowsIfMethodInfoIsInstanceMethodOnNonControllerBaseType()
{
// Arrange
MethodInfo methodInfo = typeof(string).GetMethod("Clone");
// Act & assert
Assert.Throws<ArgumentException>(
delegate { new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object); },
@"Cannot create a descriptor for instance method 'System.Object Clone()' on type 'System.String' because the type does not derive from ControllerBase.
Parameter name: methodInfo");
}
[Fact]
public void ConstructorThrowsIfMethodIsStatic()
{
// Arrange
MethodInfo methodInfo = typeof(MyController).GetMethod("StaticMethod");
// Act & assert
Assert.Throws<ArgumentException>(
delegate { new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object); },
@"Cannot call action method 'Void StaticMethod()' on controller 'System.Web.Mvc.Test.ReflectedActionDescriptorTest+MyController' because the action method is a static method.
Parameter name: methodInfo");
}
[Fact]
public void ConstructorThrowsIfMethodInfoIsNull()
{
// Act & assert
Assert.ThrowsArgumentNull(
delegate { new ReflectedActionDescriptor(null, "someName", new Mock<ControllerDescriptor>().Object); }, "methodInfo");
}
[Fact]
public void ConstructorThrowsIfMethodInfoIsOpenGenericType()
{
// Arrange
MethodInfo methodInfo = typeof(MyController).GetMethod("OpenGenericMethod");
// Act & assert
Assert.Throws<ArgumentException>(
delegate { new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object); },
@"Cannot call action method 'Void OpenGenericMethod[T]()' on controller 'System.Web.Mvc.Test.ReflectedActionDescriptorTest+MyController' because the action method is a generic method.
Parameter name: methodInfo");
}
[Fact]
public void ExecuteCallsMethodInfoOnSuccess()
{
// Arrange
Mock<ControllerContext> mockControllerContext = new Mock<ControllerContext>();
mockControllerContext.Setup(c => c.Controller).Returns(new ConcatController());
Dictionary<string, object> parameters = new Dictionary<string, object>()
{
{ "a", "hello " },
{ "b", "world" }
};
ReflectedActionDescriptor ad = GetActionDescriptor(typeof(ConcatController).GetMethod("Concat"));
// Act
object result = ad.Execute(mockControllerContext.Object, parameters);
// Assert
Assert.Equal("hello world", result);
}
[Fact]
public void ExecuteThrowsIfControllerContextIsNull()
{
// Arrange
ReflectedActionDescriptor ad = GetActionDescriptor();
// Act & assert
Assert.ThrowsArgumentNull(
delegate { ad.Execute(null, new Dictionary<string, object>()); }, "controllerContext");
}
[Fact]
public void ExecuteThrowsIfParametersContainsNullForNonNullableParameter()
{
// Arrange
ReflectedActionDescriptor ad = GetActionDescriptor(_int32EqualsIntMethod);
Dictionary<string, object> parameters = new Dictionary<string, object>() { { "obj", null } };
// Act & assert
Assert.Throws<ArgumentException>(
delegate { ad.Execute(new Mock<ControllerContext>().Object, parameters); },
@"The parameters dictionary contains a null entry for parameter 'obj' of non-nullable type 'System.Int32' for method 'Boolean Equals(Int32)' in 'System.Int32'. An optional parameter must be a reference type, a nullable type, or be declared as an optional parameter.
Parameter name: parameters");
}
[Fact]
public void ExecuteThrowsIfParametersContainsValueOfWrongTypeForParameter()
{
// Arrange
ReflectedActionDescriptor ad = GetActionDescriptor(_int32EqualsIntMethod);
Dictionary<string, object> parameters = new Dictionary<string, object>() { { "obj", "notAnInteger" } };
// Act & assert
Assert.Throws<ArgumentException>(
delegate { ad.Execute(new Mock<ControllerContext>().Object, parameters); },
@"The parameters dictionary contains an invalid entry for parameter 'obj' for method 'Boolean Equals(Int32)' in 'System.Int32'. The dictionary contains a value of type 'System.String', but the parameter requires a value of type 'System.Int32'.
Parameter name: parameters");
}
[Fact]
public void ExecuteThrowsIfParametersIsMissingAValue()
{
// Arrange
ReflectedActionDescriptor ad = GetActionDescriptor(_int32EqualsIntMethod);
Dictionary<string, object> parameters = new Dictionary<string, object>();
// Act & assert
Assert.Throws<ArgumentException>(
delegate { ad.Execute(new Mock<ControllerContext>().Object, parameters); },
@"The parameters dictionary does not contain an entry for parameter 'obj' of type 'System.Int32' for method 'Boolean Equals(Int32)' in 'System.Int32'. The dictionary must contain an entry for each parameter, including parameters that have null values.
Parameter name: parameters");
}
[Fact]
public void ExecuteThrowsIfParametersIsNull()
{
// Arrange
ReflectedActionDescriptor ad = GetActionDescriptor();
// Act & assert
Assert.ThrowsArgumentNull(
delegate { ad.Execute(new Mock<ControllerContext>().Object, null); }, "parameters");
}
[Fact]
public void GetCustomAttributesCallsMethodInfoGetCustomAttributes()
{
// Arrange
object[] expected = new object[0];
Mock<MethodInfo> mockMethod = new Mock<MethodInfo>();
mockMethod.Setup(mi => mi.GetCustomAttributes(true)).Returns(expected);
ReflectedActionDescriptor ad = GetActionDescriptor(mockMethod.Object);
// Act
object[] returned = ad.GetCustomAttributes(true);
// Assert
Assert.Same(expected, returned);
}
[Fact]
public void GetCustomAttributesWithAttributeTypeCallsMethodInfoGetCustomAttributes()
{
// Arrange
object[] expected = new object[0];
Mock<MethodInfo> mockMethod = new Mock<MethodInfo>();
mockMethod.Setup(mi => mi.GetCustomAttributes(typeof(ObsoleteAttribute), true)).Returns(expected);
ReflectedActionDescriptor ad = GetActionDescriptor(mockMethod.Object);
// Act
object[] returned = ad.GetCustomAttributes(typeof(ObsoleteAttribute), true);
// Assert
Assert.Same(expected, returned);
}
[Fact]
public void GetParametersWrapsParameterInfos()
{
// Arrange
ParameterInfo pInfo0 = typeof(ConcatController).GetMethod("Concat").GetParameters()[0];
ParameterInfo pInfo1 = typeof(ConcatController).GetMethod("Concat").GetParameters()[1];
ReflectedActionDescriptor ad = GetActionDescriptor(typeof(ConcatController).GetMethod("Concat"));
// Act
ParameterDescriptor[] pDescsFirstCall = ad.GetParameters();
ParameterDescriptor[] pDescsSecondCall = ad.GetParameters();
// Assert
Assert.NotSame(pDescsFirstCall, pDescsSecondCall);
Assert.True(pDescsFirstCall.SequenceEqual(pDescsSecondCall));
Assert.Equal(2, pDescsFirstCall.Length);
ReflectedParameterDescriptor pDesc0 = pDescsFirstCall[0] as ReflectedParameterDescriptor;
ReflectedParameterDescriptor pDesc1 = pDescsFirstCall[1] as ReflectedParameterDescriptor;
Assert.NotNull(pDesc0);
Assert.Same(ad, pDesc0.ActionDescriptor);
Assert.Same(pInfo0, pDesc0.ParameterInfo);
Assert.NotNull(pDesc1);
Assert.Same(ad, pDesc1.ActionDescriptor);
Assert.Same(pInfo1, pDesc1.ParameterInfo);
}
[Fact]
public void GetSelectorsWrapsSelectorAttributes()
{
// Arrange
ControllerContext controllerContext = new Mock<ControllerContext>().Object;
Mock<MethodInfo> mockMethod = new Mock<MethodInfo>();
Mock<ActionMethodSelectorAttribute> mockAttr = new Mock<ActionMethodSelectorAttribute>();
mockAttr.Setup(attr => attr.IsValidForRequest(controllerContext, mockMethod.Object)).Returns(true).Verifiable();
mockMethod.Setup(m => m.GetCustomAttributes(typeof(ActionMethodSelectorAttribute), true)).Returns(new ActionMethodSelectorAttribute[] { mockAttr.Object });
ReflectedActionDescriptor ad = GetActionDescriptor(mockMethod.Object);
// Act
ICollection<ActionSelector> selectors = ad.GetSelectors();
bool executedSuccessfully = selectors.All(s => s(controllerContext));
// Assert
Assert.Single(selectors);
Assert.True(executedSuccessfully);
mockAttr.Verify();
}
[Fact]
public void IsDefinedCallsMethodInfoIsDefined()
{
// Arrange
Mock<MethodInfo> mockMethod = new Mock<MethodInfo>();
mockMethod.Setup(mi => mi.IsDefined(typeof(ObsoleteAttribute), true)).Returns(true);
ReflectedActionDescriptor ad = GetActionDescriptor(mockMethod.Object);
// Act
bool isDefined = ad.IsDefined(typeof(ObsoleteAttribute), true);
// Assert
Assert.True(isDefined);
}
[Fact]
public void TryCreateDescriptorReturnsDescriptorOnSuccess()
{
// Arrange
MethodInfo methodInfo = typeof(MyController).GetMethod("GoodActionMethod");
ControllerDescriptor cd = new Mock<ControllerDescriptor>().Object;
// Act
ReflectedActionDescriptor ad = ReflectedActionDescriptor.TryCreateDescriptor(methodInfo, "someName", cd);
// Assert
Assert.NotNull(ad);
Assert.Same(methodInfo, ad.MethodInfo);
Assert.Equal("someName", ad.ActionName);
Assert.Same(cd, ad.ControllerDescriptor);
}
[Fact]
public void TryCreateDescriptorReturnsNullOnFailure()
{
// Arrange
MethodInfo methodInfo = typeof(MyController).GetMethod("OpenGenericMethod");
ControllerDescriptor cd = new Mock<ControllerDescriptor>().Object;
// Act
ReflectedActionDescriptor ad = ReflectedActionDescriptor.TryCreateDescriptor(methodInfo, "someName", cd);
// Assert
Assert.Null(ad);
}
private static ReflectedActionDescriptor GetActionDescriptor()
{
return GetActionDescriptor(new Mock<MethodInfo>().Object);
}
private static ReflectedActionDescriptor GetActionDescriptor(MethodInfo methodInfo)
{
return new ReflectedActionDescriptor(methodInfo, "someName", new Mock<ControllerDescriptor>().Object, false /* validateMethod */)
{
DispatcherCache = new ActionMethodDispatcherCache()
};
}
private class ConcatController : Controller
{
public string Concat(string a, string b)
{
return a + b;
}
}
[OutputCache(VaryByParam = "Class")]
private class OverriddenAttributeController : Controller
{
[OutputCache(VaryByParam = "Method")]
public void SomeMethod()
{
}
}
[KeyedActionFilter(Key = "BaseClass", Order = 0)]
[KeyedAuthorizationFilter(Key = "BaseClass", Order = 0)]
[KeyedExceptionFilter(Key = "BaseClass", Order = 0)]
private class GetMemberChainController : Controller
{
[KeyedActionFilter(Key = "BaseMethod", Order = 0)]
[KeyedAuthorizationFilter(Key = "BaseMethod", Order = 0)]
public virtual void SomeVirtual()
{
}
}
[KeyedActionFilter(Key = "DerivedClass", Order = 1)]
private class GetMemberChainDerivedController : GetMemberChainController
{
}
[KeyedActionFilter(Key = "SubderivedClass", Order = 2)]
private class GetMemberChainSubderivedController : GetMemberChainDerivedController
{
[KeyedActionFilter(Key = "SubderivedMethod", Order = 2)]
public override void SomeVirtual()
{
}
}
private abstract class KeyedFilterAttribute : FilterAttribute
{
public string Key { get; set; }
}
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = true)]
private class KeyedAuthorizationFilterAttribute : KeyedFilterAttribute, IAuthorizationFilter
{
public void OnAuthorization(AuthorizationContext filterContext)
{
throw new NotImplementedException();
}
}
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = true)]
private class KeyedExceptionFilterAttribute : KeyedFilterAttribute, IExceptionFilter
{
public void OnException(ExceptionContext filterContext)
{
throw new NotImplementedException();
}
}
[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = true)]
private class KeyedActionFilterAttribute : KeyedFilterAttribute, IActionFilter, IResultFilter
{
public void OnActionExecuting(ActionExecutingContext filterContext)
{
throw new NotImplementedException();
}
public void OnActionExecuted(ActionExecutedContext filterContext)
{
throw new NotImplementedException();
}
public void OnResultExecuting(ResultExecutingContext filterContext)
{
throw new NotImplementedException();
}
public void OnResultExecuted(ResultExecutedContext filterContext)
{
throw new NotImplementedException();
}
}
private class MyController : Controller
{
public void GoodActionMethod()
{
}
public static void StaticMethod()
{
}
public void OpenGenericMethod<T>()
{
}
public void MethodHasOutParameter(out int i)
{
i = 0;
}
public void MethodHasRefParameter(ref int i)
{
}
}
}
}
|