1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
|
// Copyright (c) Microsoft Corporation. All rights reserved. See License.txt in the project root for license information.
using System;
using System.Linq.Expressions;
using System.Web.Mvc;
using System.Web.Routing;
using Xunit;
using Assert = Microsoft.TestCommon.AssertEx;
using ExpressionHelper = Microsoft.Web.Mvc.Internal.ExpressionHelper;
namespace Microsoft.Web.Mvc.Test
{
public class ExpressionHelperTest
{
[Fact]
public void BuildRouteValueDictionary_TargetsAsynchronousAsyncMethod_StripsSuffix()
{
// Arrange
Expression<Action<TestAsyncController>> expr = (c => c.AsynchronousAsync());
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(expr);
// Assert
Assert.Equal("Asynchronous", rvd["action"]);
Assert.Equal("TestAsync", rvd["controller"]);
Assert.False(rvd.ContainsKey("area"));
}
[Fact]
public void BuildRouteValueDictionary_TargetsAsynchronousCompletedMethod_Throws()
{
// Arrange
Expression<Action<TestAsyncController>> expr = (c => c.AsynchronousCompleted());
// Act & assert
Assert.Throws<InvalidOperationException>(
delegate { ExpressionHelper.GetRouteValuesFromExpression(expr); },
@"The method 'AsynchronousCompleted' is an asynchronous completion method and cannot be called directly.");
}
[Fact]
public void BuildRouteValueDictionary_TargetsControllerWithAreaAttribute_AddsAreaName()
{
// Arrange
Expression<Action<ControllerWithAreaController>> expr = c => c.Index();
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(expr);
// Assert
Assert.Equal("Index", rvd["action"]);
Assert.Equal("ControllerWithArea", rvd["controller"]);
Assert.Equal("the area name", rvd["area"]);
}
[Fact]
public void BuildRouteValueDictionary_TargetsNonActionMethod_Throws()
{
// Arrange
Expression<Action<TestController>> expr = (c => c.NotAnAction());
// Act & assert
Assert.Throws<InvalidOperationException>(
delegate { ExpressionHelper.GetRouteValuesFromExpression(expr); },
@"The method 'NotAnAction' is marked [NonAction] and cannot be called directly.");
}
[Fact]
public void BuildRouteValueDictionary_TargetsRenamedMethod_UsesNewName()
{
// Arrange
Expression<Action<TestController>> expr = (c => c.Renamed());
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(expr);
// Assert
Assert.Equal("NewName", rvd["action"]);
Assert.Equal("Test", rvd["controller"]);
Assert.False(rvd.ContainsKey("area"));
}
[Fact]
public void BuildRouteValueDictionary_TargetsSynchronousMethodOnAsyncController_ReturnsOriginalName()
{
// Arrange
Expression<Action<TestAsyncController>> expr = (c => c.Synchronous());
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(expr);
// Assert
Assert.Equal("Synchronous", rvd["action"]);
Assert.Equal("TestAsync", rvd["controller"]);
Assert.False(rvd.ContainsKey("area"));
}
[Fact]
public void BuildRouteValueDictionaryWithNullExpressionThrowsArgumentNullException()
{
Assert.ThrowsArgumentNull(
() => ExpressionHelper.GetRouteValuesFromExpression<TestController>(null),
"action");
}
[Fact]
public void BuildRouteValueDictionaryWithNonMethodExpressionThrowsInvalidOperationException()
{
// Arrange
Expression<Action<TestController>> expression = c => new TestController();
// Act & Assert
Assert.Throws<ArgumentException>(
() => ExpressionHelper.GetRouteValuesFromExpression(expression),
"Expression must be a method call." + Environment.NewLine + "Parameter name: action");
}
[Fact]
public void BuildRouteValueDictionaryWithoutControllerSuffixThrowsInvalidOperationException()
{
// Arrange
Expression<Action<TestControllerNot>> index = (c => c.Index(123));
// Act & Assert
Assert.Throws<ArgumentException>(
() => ExpressionHelper.GetRouteValuesFromExpression(index),
"Controller name must end in 'Controller'." + Environment.NewLine + "Parameter name: action");
}
[Fact]
public void BuildRouteValueDictionaryWithControllerBaseClassThrowsInvalidOperationException()
{
// Arrange
Expression<Action<Controller>> index = (c => c.Dispose());
// Act & Assert
Assert.Throws<ArgumentException>(
() => ExpressionHelper.GetRouteValuesFromExpression(index),
"Cannot route to class named 'Controller'." + Environment.NewLine + "Parameter name: action");
}
[Fact]
public void BuildRouteValueDictionaryAddsControllerNameToDictionary()
{
// Arrange
Expression<Action<TestController>> index = (c => c.Index(123));
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(index);
// Assert
Assert.Equal("Test", rvd["Controller"]);
}
[Fact]
public void BuildRouteValueDictionaryFromExpressionReturnsCorrectDictionary()
{
// Arrange
Expression<Action<TestController>> index = (c => c.Index(123));
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(index);
// Assert
Assert.Equal("Test", rvd["Controller"]);
Assert.Equal("Index", rvd["Action"]);
Assert.Equal(123, rvd["page"]);
}
[Fact]
public void BuildRouteValueDictionaryFromNonConstantExpressionReturnsCorrectDictionary()
{
// Arrange
Expression<Action<TestController>> index = (c => c.About(Foo));
// Act
RouteValueDictionary rvd = ExpressionHelper.GetRouteValuesFromExpression(index);
// Assert
Assert.Equal("Test", rvd["Controller"]);
Assert.Equal("About", rvd["Action"]);
Assert.Equal("FooValue", rvd["s"]);
}
[Fact]
public void GetInputNameFromPropertyExpressionReturnsPropertyName()
{
// Arrange
Expression<Func<TestModel, int>> expression = m => m.IntProperty;
// Act
string name = ExpressionHelper.GetInputName(expression);
// Assert
Assert.Equal("IntProperty", name);
}
[Fact]
public void GetInputNameFromPropertyWithMethodCallExpressionReturnsPropertyName()
{
// Arrange
Expression<Func<TestModel, string>> expression = m => m.IntProperty.ToString();
// Act
string name = ExpressionHelper.GetInputName(expression);
// Assert
Assert.Equal("IntProperty", name);
}
[Fact]
public void GetInputNameFromPropertyWithTwoMethodCallExpressionReturnsPropertyName()
{
// Arrange
Expression<Func<TestModel, string>> expression = m => m.IntProperty.ToString().ToUpper();
// Act
string name = ExpressionHelper.GetInputName(expression);
// Assert
Assert.Equal("IntProperty", name);
}
[Fact]
public void GetInputNameFromExpressionWithTwoPropertiesUsesWholeExpression()
{
// Arrange
Expression<Func<TestModel, int>> expression = m => m.StringProperty.Length;
// Act
string name = ExpressionHelper.GetInputName(expression);
// Assert
Assert.Equal("StringProperty.Length", name);
}
public class TestController : Controller
{
public ActionResult Index(int page)
{
return null;
}
public string About(string s)
{
return "The value is " + s;
}
[ActionName("NewName")]
public void Renamed()
{
}
[NonAction]
public void NotAnAction()
{
}
}
public class TestAsyncController : AsyncController
{
public void Synchronous()
{
}
public void AsynchronousAsync()
{
}
public void AsynchronousCompleted()
{
}
}
public string Foo
{
get { return "FooValue"; }
}
public class TestControllerNot : Controller
{
public ActionResult Index(int page)
{
return null;
}
}
[ActionLinkArea("the area name")]
public class ControllerWithAreaController : Controller
{
public ActionResult Index()
{
return null;
}
}
public class TestModel
{
public int IntProperty { get; set; }
public string StringProperty { get; set; }
}
}
}
|
