1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
|
//
// CompareFloatWithEqualityOperatorIssueTests.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
//
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using ICSharpCode.NRefactory.CSharp.Refactoring;
using NUnit.Framework;
namespace ICSharpCode.NRefactory.CSharp.CodeIssues
{
[TestFixture]
public class CompareFloatWithEqualityOperatorIssueTests : InspectionActionTestBase
{
public void Test (string inputOp, string outputOp)
{
var input = @"
class TestClass
{
void TestMethod ()
{
double x = 0.1;
bool test = x " + inputOp + @" 0.1;
}
}";
var output = @"
class TestClass
{
void TestMethod ()
{
double x = 0.1;
bool test = System.Math.Abs (x - 0.1) " + outputOp + @" EPSILON;
}
}";
Test<CompareFloatWithEqualityOperatorIssue> (input, 1, output);
}
[Test]
public void TestEquality ()
{
Test ("==", "<");
}
[Test]
public void TestInequality ()
{
Test ("!=", ">");
}
[Test]
public void TestNaN ()
{
var input = @"
class TestClass
{
void TestMethod (double x, float y)
{
bool test = x == System.Double.NaN;
bool test2 = x != double.NaN;
bool test3 = y == float.NaN;
bool test4 = x != float.NaN;
}
}";
var output = @"
class TestClass
{
void TestMethod (double x, float y)
{
bool test = double.IsNaN (x);
bool test2 = !double.IsNaN (x);
bool test3 = float.IsNaN (y);
bool test4 = !double.IsNaN (x);
}
}";
Test<CompareFloatWithEqualityOperatorIssue> (input, 4, output);
}
[Test]
public void TestPositiveInfinity ()
{
var input = @"
class TestClass
{
void TestMethod (double x, float y)
{
bool test = x == System.Double.PositiveInfinity;
bool test2 = x != double.PositiveInfinity;
bool test3 = y == float.PositiveInfinity;
bool test4 = x != float.PositiveInfinity;
}
}";
Test<CompareFloatWithEqualityOperatorIssue> (input, 0);
}
[Test]
public void TestNegativeInfinity ()
{
var input = @"
class TestClass
{
void TestMethod (double x, float y)
{
bool test = x == System.Double.NegativeInfinity;
bool test2 = x != double.NegativeInfinity;
bool test3 = y == float.NegativeInfinity;
bool test4 = x != float.NegativeInfinity;
}
}";
Test<CompareFloatWithEqualityOperatorIssue> (input, 0);
}
}
}
|
