1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
|
//
// FormatStringIssueTests.cs
//
// Author:
// Simon Lindgren <simon.n.lindgren@gmail.com>
//
// Copyright (c) 2012 Simon Lindgren
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using NUnit.Framework;
using ICSharpCode.NRefactory.CSharp.CodeActions;
using ICSharpCode.NRefactory.CSharp.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.CodeIssues
{
[TestFixture]
public class FormatStringTests : InspectionActionTestBase
{
[Test]
public void TooFewArguments()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""{0}"");
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (1, issues.Count);
}
[Test]
public void SupportsFixedArguments()
{
var input = @"
class TestClass
{
void Foo()
{
Bar(""{0}"", 1);
}
void Bar(string format, string arg0)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (0, issues.Count);
}
[Test]
public void IgnoresCallWithUnknownNumberOfArguments()
{
var input = @"
class TestClass
{
string Bar(params object[] args)
{
return string.Format(""{1}"", args);
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (0, issues.Count);
}
[Test]
public void FormatItemIndexOutOfRangeOfArguments()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""{1}"", 1);
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (1, issues.Count);
}
[Test]
public void FormatItemIndexOutOfRangeOfArguments_ExplicitArrayCreation()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""{1}"", new object[] { 1 });
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (1, issues.Count);
}
[Test]
public void FormatItemMissingEndBrace()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""Text text text {0 text text text"", 1);
}
}";
TestRefactoringContext context;
var issues = GetIssues(new FormatStringIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
}
[Test]
public void UnescapedLeftBrace()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""a { a"", 1);
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (1, issues.Count);
}
[Test]
public void IgnoresStringWithGoodArguments()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""{0}"", ""arg0"");
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (0, issues.Count);
}
[Test]
public void IgnoresStringWithGoodArguments_ExplicitArrayCreation()
{
var input = @"
class TestClass
{
void Foo()
{
string.Format(""{1}"", new object[] { ""arg0"", ""arg1"" });
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (0, issues.Count);
}
[Test]
public void IgnoresNonFormattingCall()
{
var input = @"
class TestClass
{
void Foo()
{
string lower = string.ToLower(""{0}"");
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (0, issues.Count);
}
[Test]
public void HandlesCallsWithExtraArguments()
{
var input = @"
class TestClass
{
void Foo()
{
Foo(1);
}
}";
TestRefactoringContext context;
var issues = GetIssues (new FormatStringIssue (), input, out context);
Assert.AreEqual (0, issues.Count);
}
}
}
|
