1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954
|
//
// ParameterCouldBeDeclaredWithBaseTypeTests.cs
//
// Author:
// Simon Lindgren <simon.n.lindgren@gmail.com>
//
// Copyright (c) 2012 Simon Lindgren
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System;
using NUnit.Framework;
using ICSharpCode.NRefactory.CSharp.CodeActions;
using ICSharpCode.NRefactory.CSharp.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.CodeIssues
{
[TestFixture]
public class ParameterCanBeDemotedTests : InspectionActionTestBase
{
[Test]
public void BasicTest()
{
var input = @"
class A
{
public virtual void Foo() {}
}
class B : A
{
public virtual void Bar() {}
}
class C
{
void F(B b)
{
b.Foo();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues [0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issues [0], @"
class A
{
public virtual void Foo() {}
}
class B : A
{
public virtual void Bar() {}
}
class C
{
void F(A b)
{
b.Foo();
}
}");
}
[Test]
public void IgnoresUnusedParameters()
{
var input = @"
class A
{
void F(A a1)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void IgnoresDirectionalParameters()
{
var input = @"
interface IA
{
}
class A : IA
{
void F(out A a1)
{
object.Equals(a1, null);
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void IgnoresOverrides()
{
var input = @"
interface IA
{
void Foo();
}
class B : IA
{
public virtual void Foo() {}
public virtual void Bar() {}
}
class TestBase
{
public void F(B b) {
b.Foo();
b.Bar();
}
}
class TestClass : TestBase
{
public override void F(B b)
{
b.Foo();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void IgnoresOverridables()
{
var input = @"
interface IA
{
void Foo();
}
class B : IA
{
public virtual void Foo() {}
public virtual void Bar() {}
}
class TestClass
{
public virtual void F(B b)
{
b.Foo();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void HandlesNeededProperties()
{
var input = @"
interface IA
{
void Foo(string s);
}
class B : IA
{
public virtual void Foo(string s) {}
public string Property { get; }
}
class TestClass
{
public void F(B b)
{
b.Foo(b.Property);
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void InterfaceTest()
{
var input = @"
interface IA
{
void Foo();
}
class B : IA
{
public virtual void Foo() {}
public virtual void Bar() {}
}
class C
{
void F(B b)
{
b.Foo();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues [0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issues [0], @"
interface IA
{
void Foo();
}
class B : IA
{
public virtual void Foo() {}
public virtual void Bar() {}
}
class C
{
void F(IA b)
{
b.Foo();
}
}");
}
[Test]
public void RespectsExpectedTypeInIfStatement()
{
var input = @"
class C
{
void F (bool b, bool c)
{
if (b && c)
return;
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void MultipleInterfaceTest()
{
var input = @"
interface IA1
{
void Foo();
}
interface IA2
{
void Bar();
}
class B : IA1, IA2
{
public virtual void Foo() {}
public virtual void Bar() {}
}
class C : B {}
class Test
{
void F(C c)
{
c.Foo();
c.Bar();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues [0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issues [0], @"
interface IA1
{
void Foo();
}
interface IA2
{
void Bar();
}
class B : IA1, IA2
{
public virtual void Foo() {}
public virtual void Bar() {}
}
class C : B {}
class Test
{
void F(B c)
{
c.Foo();
c.Bar();
}
}");
}
string baseInput = @"
interface IA
{
void Foo();
}
interface IB : IA
{
void Bar();
}
interface IC : IA
{
new void Foo();
void Baz();
}
class D : IB
{
public void Foo() {}
public void Bar() {}
}
class E : D, IC
{
public void Baz() {}
void IC.Foo() {}
}";
[Ignore]
[Test]
public void FindsTopInterface()
{
var input = baseInput + @"
class Test
{
void F(E e)
{
e.Foo();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues [0];
Assert.AreEqual(4, issue.Actions.Count);
CheckFix(context, issues [0], baseInput + @"
class Test
{
void F(IA e)
{
e.Foo();
}
}");
}
[Test]
public void DoesNotChangeOverload()
{
var input = baseInput + @"
class Test
{
void F(IB b)
{
Bar (b);
}
void Bar (IA a)
{
}
void Bar (IB b)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void AssignmentToExplicitlyTypedVariable()
{
var input = baseInput + @"
class Test
{
void F(IB b)
{
IB b2;
b2 = b;
object.Equals(b, b2);
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void GenericMethod()
{
var input = baseInput + @"
class Test
{
void F(IB b)
{
Generic (b);
}
void Generic<T> (T arg) where T : IA
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void VariableDeclarationWithTypeInference()
{
var input = baseInput + @"
class Test
{
void Foo (IB b)
{
var b2 = b;
Foo (b2);
}
void Foo (IA a)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void RespectsOutgoingCallsTypeRestrictions()
{
var input = baseInput + @"
class Test
{
void F(E e)
{
e.Foo();
DemandType(e);
}
void DemandType(D d)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues [0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issues [0], baseInput + @"
class Test
{
void F(D e)
{
e.Foo();
DemandType(e);
}
void DemandType(D d)
{
}
}");
}
[Test]
public void AccountsForNonInvocationMethodGroupUsageInMethodCall()
{
var input = @"
delegate void FooDelegate (string s);
interface IBase
{
void Bar();
}
interface IDerived : IBase
{
void Foo(string s);
}
class TestClass
{
public void Bar (IDerived derived)
{
derived.Bar();
Baz (derived.Foo);
}
void Baz (FooDelegate fd)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void AccountsForNonInvocationMethodGroupUsageInVariableDeclaration()
{
var input = @"
delegate void FooDelegate (string s);
interface IBase
{
void Bar();
}
interface IDerived : IBase
{
void Foo(string s);
}
class TestClass
{
public void Bar (IDerived derived)
{
derived.Bar();
FooDelegate d = derived.Foo;
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void AccountsForNonInvocationMethodGroupUsageInAssignmentExpression()
{
var input = @"
delegate void FooDelegate (string s);
interface IBase
{
void Bar();
}
interface IDerived : IBase
{
void Foo(string s);
}
class TestClass
{
public void Bar (IDerived derived)
{
derived.Bar();
FooDelegate d;
d = derived.Foo;
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Ignore]
[Test]
public void AccountsForIndexers()
{
var input = @"
class TestClass
{
void Write(string[] s)
{
object.Equals(s, s);
var element = s[1];
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues[0];
// Suggested types: IList<T> and IReadOnlyList<T>
Assert.AreEqual(2, issue.Actions.Count);
CheckFix(context, issues [0], @"
class TestClass
{
void Write(System.Collections.Generic.IList<string> s)
{
object.Equals(s, s);
var element = s[1];
}
}");
}
[Test]
public void AccountsForArrays()
{
var input = @"
class TestClass
{
void Write(string[] s)
{
var i = s.Length;
SetValue (out s[1]);
}
void SetValue (out string s)
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void LimitsParamsParametersToArrays()
{
var input = @"
class TestClass
{
void Write(params string[] s)
{
System.Console.WriteLine (s);
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void DoesNotSuggestProgramEntryPointChanges()
{
var input = @"
class TestClass
{
public static void Main (string[] args)
{
if (args.Length > 2) {
}
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void IgnoresImplicitInterfaceImplementations()
{
var input = @"
interface IHasFoo
{
void Foo (string s);
}
class TestClass : IHasFoo
{
public void Foo(string s)
{
object o = s;
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void IgnoresEnumParameters()
{
var input = @"
enum ApplicableValues
{
None,
Some
}
class TestClass
{
public void Foo(ApplicableValues av)
{
object o = av;
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void CallToOverriddenMember()
{
var input = @"
class TestBase
{
public virtual void Foo()
{
}
}
class Test : TestBase
{
void F (Test t)
{
t.Foo();
}
public override void Foo()
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues[0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issue, @"
class TestBase
{
public virtual void Foo()
{
}
}
class Test : TestBase
{
void F (TestBase t)
{
t.Foo();
}
public override void Foo()
{
}
}");
}
[Test]
public void CallToShadowingMember()
{
var input = @"
class TestBase
{
public virtual void Foo()
{
}
}
class Test : TestBase
{
void F (Test t)
{
t.Foo();
}
public new void Foo()
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(0, issues.Count);
}
[Test]
public void CallToShadowingMember2()
{
var input = @"
class TestBaseBase
{
public virtual void Foo()
{
}
}
class TestBase : TestBaseBase
{
protected virtual new void Foo()
{
}
}
class Test : TestBase
{
void F (Test t)
{
t.Foo();
}
public override void Foo()
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues[0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issue, @"
class TestBaseBase
{
public virtual void Foo()
{
}
}
class TestBase : TestBaseBase
{
protected virtual new void Foo()
{
}
}
class Test : TestBase
{
void F (TestBase t)
{
t.Foo();
}
public override void Foo()
{
}
}");
}
[Test]
public void CallToShadowingMemberWithBaseInterface()
{
var input = @"
interface IFoo
{
void Foo();
}
class TestBaseBase : IFoo
{
public virtual void Foo()
{
}
}
class TestBase : TestBaseBase
{
protected virtual new void Foo()
{
}
}
class Test : TestBase
{
void F (Test t)
{
t.Foo();
}
protected override void Foo()
{
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(false), input, out context);
Assert.AreEqual(1, issues.Count);
var issue = issues[0];
Assert.AreEqual(1, issue.Actions.Count);
CheckFix(context, issue, @"
interface IFoo
{
void Foo();
}
class TestBaseBase : IFoo
{
public virtual void Foo()
{
}
}
class TestBase : TestBaseBase
{
protected virtual new void Foo()
{
}
}
class Test : TestBase
{
void F (TestBase t)
{
t.Foo();
}
protected override void Foo()
{
}
}");
}
/// <summary>
/// Bug 9617 - Incorrect "parameter can be demoted to base class" warning for arrays
/// </summary>
[Test]
public void TestBug9617()
{
Test<ParameterCanBeDemotedIssue>(@"class Test
{
object Foo (object[] arr)
{
return arr [0];
}
}", 0);
}
[Test]
public void DoNotDemoteStringComparisonToReferenceComparison_WithinLambda()
{
Test<ParameterCanBeDemotedIssue>(@"using System; using System.Linq; using System.Collections.Generic;
class Test
{
IEnumerable<User> users;
User GetUser (String id)
{
return users.Where(u => u.Name == id).SingleOrDefault();
}
}
class User {
public string Name;
}
", 0);
}
[Test]
public void TestMicrosoftSuppressMessage()
{
var input = @"
class A
{
public virtual void Foo() {}
}
class B : A
{
public virtual void Bar() {}
}
class C
{
[System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA1011:ConsiderPassingBaseTypesAsParameters"")]
void F(B b)
{
b.Foo();
}
}";
TestRefactoringContext context;
var issues = GetIssues(new ParameterCanBeDemotedIssue(), input, out context);
Assert.AreEqual(0, issues.Count);
}
}
}
|