1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
|
/*
* Copyright 2013-2014 Canonical Ltd.
*
* This file is part of webbrowser-app.
*
* webbrowser-app is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 3.
*
* webbrowser-app is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
// Qt
#include <QtCore/QDir>
#include <QtCore/QTemporaryFile>
#include <QtTest/QSignalSpy>
#include <QtTest/QtTest>
// local
#include "bookmarks-model.h"
class BookmarksModelTests : public QObject
{
Q_OBJECT
private:
BookmarksModel* model;
private Q_SLOTS:
void init()
{
model = new BookmarksModel;
model->setDatabasePath(":memory:");
}
void cleanup()
{
delete model;
}
void shouldBeInitiallyEmpty()
{
QCOMPARE(model->rowCount(), 0);
}
void shouldExposeRoleNames()
{
QList<QByteArray> roleNames = model->roleNames().values();
QVERIFY(roleNames.contains("url"));
QVERIFY(roleNames.contains("title"));
QVERIFY(roleNames.contains("icon"));
QVERIFY(roleNames.contains("created"));
QVERIFY(roleNames.contains("folder"));
}
void shouldAddNewEntries()
{
QSignalSpy spy(model, SIGNAL(rowsInserted(QModelIndex, int, int)));
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
QCOMPARE(model->rowCount(), 1);
QCOMPARE(spy.count(), 1);
QVariantList args = spy.takeFirst();
QCOMPARE(args.at(1).toInt(), 0);
QCOMPARE(args.at(2).toInt(), 0);
model->add(QUrl("http://wikipedia.org/"), "Wikipedia", QUrl(), "");
QCOMPARE(model->rowCount(), 2);
QCOMPARE(spy.count(), 1);
args = spy.takeFirst();
QCOMPARE(args.at(1).toInt(), 0);
QCOMPARE(args.at(2).toInt(), 0);
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl(), "");
QCOMPARE(model->rowCount(), 3);
QCOMPARE(spy.count(), 1);
args = spy.takeFirst();
QCOMPARE(args.at(1).toInt(), 0);
QCOMPARE(args.at(2).toInt(), 0);
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
QCOMPARE(model->rowCount(), 3);
QVERIFY(spy.isEmpty());
}
void shouldRemoveEntries()
{
QSignalSpy spy(model, SIGNAL(rowsRemoved(QModelIndex, int, int)));
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
model->add(QUrl("http://wikipedia.org/"), "Wikipedia", QUrl(), "");
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl(), "");
QCOMPARE(model->rowCount(), 3);
QVERIFY(spy.isEmpty());
model->remove(QUrl("http://ubuntu.com/"));
QCOMPARE(model->rowCount(), 2);
QCOMPARE(spy.count(), 1);
QVariantList args = spy.takeFirst();
// Model is chronologically sorted so deleting the last entry added
// actually deletes the first item in the model
QCOMPARE(args.at(1).toInt(), 0);
QCOMPARE(args.at(2).toInt(), 0);
model->remove(QUrl("http://ubuntu.com/"));
QCOMPARE(model->rowCount(), 2);
QVERIFY(spy.isEmpty());
}
void shouldUpdateEntries()
{
QSignalSpy spy(model, SIGNAL(dataChanged(const QModelIndex&, const QModelIndex&, const QVector<int>&)));
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl(), "");
QCOMPARE(model->rowCount(), 2);
QVERIFY(spy.isEmpty());
model->update(QUrl("http://example.org/"), "New Domain Title", "SampleFolder");
QCOMPARE(model->rowCount(), 2);
QCOMPARE(spy.count(), 1);
QList<QVariant> args = spy.takeFirst();
QCOMPARE(args.at(0).toModelIndex().row(), 1);
QCOMPARE(args.at(1).toModelIndex().row(), 1);
QVector<int> roles = args.at(2).value<QVector<int> >();
QVERIFY(roles.size() >= 2);
QVERIFY(roles.contains(BookmarksModel::Title));
QVERIFY(roles.contains(BookmarksModel::Folder));
QCOMPARE(model->data(model->index(1, 0), BookmarksModel::Url).toUrl(), QUrl("http://example.org/"));
QCOMPARE(model->data(model->index(1, 0), BookmarksModel::Title).toString(), QString("New Domain Title"));
QCOMPARE(model->data(model->index(1, 0), BookmarksModel::Icon).toUrl(), QUrl(""));
QCOMPARE(model->data(model->index(1, 0), BookmarksModel::Folder).toString(), QString("SampleFolder"));
QCOMPARE(model->data(model->index(0, 0), BookmarksModel::Url).toUrl(), QUrl("http://ubuntu.com/"));
}
void shouldContainEntries()
{
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl(), "");
QVERIFY(model->contains(QUrl("http://ubuntu.com/")));
QVERIFY(!model->contains(QUrl("http://wikipedia.org/")));
}
void shouldKeepEntriesSortedChronologically()
{
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl(), "");
model->add(QUrl("http://wikipedia.org/"), "Wikipedia", QUrl(), "");
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
QCOMPARE(model->data(model->index(0, 0), BookmarksModel::Url).toUrl(), QUrl("http://example.org/"));
QCOMPARE(model->data(model->index(1, 0), BookmarksModel::Url).toUrl(), QUrl("http://wikipedia.org/"));
QCOMPARE(model->data(model->index(2, 0), BookmarksModel::Url).toUrl(), QUrl("http://ubuntu.com/"));
}
void shouldReturnData()
{
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl("image://webicon/123"), "SampleFolder");
QVERIFY(!model->data(QModelIndex(), BookmarksModel::Url).isValid());
QVERIFY(!model->data(model->index(-1, 0), BookmarksModel::Url).isValid());
QVERIFY(!model->data(model->index(3, 0), BookmarksModel::Url).isValid());
QCOMPARE(model->data(model->index(0, 0), BookmarksModel::Url).toUrl(), QUrl("http://ubuntu.com/"));
QCOMPARE(model->data(model->index(0, 0), BookmarksModel::Title).toString(), QString("Ubuntu"));
QCOMPARE(model->data(model->index(0, 0), BookmarksModel::Icon).toUrl(), QUrl("image://webicon/123"));
QVERIFY(model->data(model->index(0, 0), BookmarksModel::Created).toDateTime() <= QDateTime::currentDateTime());
QCOMPARE(model->data(model->index(0, 0), BookmarksModel::Folder).toString(), QString("SampleFolder"));
QVERIFY(!model->data(model->index(0, 0), BookmarksModel::Folder + 1).isValid());
}
void shouldReturnDatabasePath()
{
QCOMPARE(model->databasePath(), QString(":memory:"));
}
void shouldNotifyWhenSettingDatabasePath()
{
QSignalSpy spyPath(model, SIGNAL(databasePathChanged()));
QSignalSpy spyReset(model, SIGNAL(modelReset()));
model->setDatabasePath(":memory:");
QVERIFY(spyPath.isEmpty());
QVERIFY(spyReset.isEmpty());
model->setDatabasePath("");
QCOMPARE(spyPath.count(), 1);
QCOMPARE(spyReset.count(), 1);
QCOMPARE(model->databasePath(), QString(":memory:"));
}
void shouldSerializeOnDisk()
{
QSKIP("Broken on focal");
QTemporaryFile tempFile;
tempFile.open();
QString fileName = tempFile.fileName();
delete model;
model = new BookmarksModel;
model->setDatabasePath(fileName);
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
model->add(QUrl("http://ubuntu.com/"), "Ubuntu", QUrl(), "");
delete model;
model = new BookmarksModel;
model->setDatabasePath(fileName);
QCOMPARE(model->rowCount(), 2);
}
void shouldCountNumberOfEntries()
{
QSignalSpy spyCount(model, SIGNAL(rowCountChanged()));
QCOMPARE(model->property("count").toInt(), 0);
model->add(QUrl("http://example.org/"), "Example Domain", QUrl(), "");
QCOMPARE(model->property("count").toInt(), 1);
QCOMPARE(spyCount.count(), 1);
model->add(QUrl("http://example.com/"), "Example Domain", QUrl(), "");
QCOMPARE(model->property("count").toInt(), 2);
QCOMPARE(spyCount.count(), 2);
model->remove(QUrl("http://example.com/"));
QCOMPARE(model->property("count").toInt(), 1);
QCOMPARE(spyCount.count(), 3);
}
void shouldPopulateModelWithExistingFolders()
{
QTemporaryFile tempFile;
tempFile.open();
QString fileName = tempFile.fileName();
delete model;
model = new BookmarksModel;
QSignalSpy spy(model, SIGNAL(folderAdded(QString)));
model->setDatabasePath(fileName);
model->addFolder("SampleFolder");
model->addFolder("AnotherFolder");
// The empty folder is added by default
QCOMPARE(spy.count(), 3);
QCOMPARE(model->folders().count(), 3);
delete model;
model = new BookmarksModel;
QSignalSpy spyPopulate(model, SIGNAL(folderAdded(QString)));
model->setDatabasePath(fileName);
QCOMPARE(spyPopulate.count(), 3);
QCOMPARE(model->folders().count(), 3);
}
};
QTEST_MAIN(BookmarksModelTests)
#include "tst_BookmarksModelTests.moc"
|
