1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737
|
"""
Script to check for string in the codebase not using `trans`.
TODO:
* Find all logger calls and add to skips
* Find nested funcs inside if/else
Run manually with
$ pytest -Wignore tools/ --tb=short
To interactively be prompted whether new strings should be ignored or need translations.
You can pass a command to also have the option to open your editor.
Example here to stop in Vim at the right file and linenumber.
$ python tools/test_strings.py "vim {filename} +{linenumber}"
"""
import ast
import os
import subprocess
import sys
import termios
import tokenize
import tty
from contextlib import suppress
from pathlib import Path
from types import ModuleType
from typing import Optional
import pytest
from strings_list import (
SKIP_FILES,
SKIP_FOLDERS,
SKIP_WORDS,
SKIP_WORDS_GLOBAL,
)
REPO_ROOT = Path(__file__).resolve()
NAPARI_MODULE = (REPO_ROOT / 'napari').relative_to(REPO_ROOT)
# Types
StringIssuesDict = dict[str, list[tuple[int, str]]]
OutdatedStringsDict = dict[str, list[str]]
TranslationErrorsDict = dict[str, list[tuple[str, str]]]
class FindTransStrings(ast.NodeVisitor):
"""This node visitor finds translated strings."""
def __init__(self) -> None:
super().__init__()
self._found = set()
self._trans_errors = []
def _check_vars(self, method_name, args, kwargs):
"""Find interpolation variables inside a translation string.
This helps find any variables that need to be interpolated inside
a string so we can check against the `kwargs` for both singular
and plural strings (if present) inside `args`.
Parameters
----------
method_name : str
Translation method used. Options include "_", "_n", "_p" and
"_np".
args : list
List of arguments passed to translation method.
kwargs : kwargs
List of keyword arguments passed to translation method.
"""
singular_kwargs = set(kwargs) - set({'n'})
plural_kwargs = set(kwargs)
# If using trans methods with `context`, remove it since we are
# only interested in the singular and plural strings (if any)
if method_name in ['_p', '_np']:
args = args[1:]
# Iterate on strings passed to the trans method. Could be just a
# singular string or a singular and a plural. We use the index to
# determine which one is used.
for idx, arg in enumerate(args):
found_vars = set()
check_arg = arg[:]
check_kwargs = {}
while True:
try:
check_arg.format(**check_kwargs)
except KeyError as err:
key = err.args[0]
found_vars.add(key)
check_kwargs[key] = 0
continue
break
if idx == 0:
check_1 = singular_kwargs - found_vars
check_2 = found_vars - singular_kwargs
else:
check_1 = plural_kwargs - found_vars
check_2 = found_vars - plural_kwargs
if check_1 or check_2:
error = (arg, check_1.union(check_2))
self._trans_errors.append(error)
def visit_Call(self, node):
method_name, args, kwargs = '', [], []
with suppress(AttributeError):
if node.func.value.id == 'trans':
method_name = node.func.attr
# Args
for item in [arg.value for arg in node.args]:
args.append(item)
self._found.add(item)
# Kwargs
kwargs = [
kw.arg for kw in node.keywords if kw.arg != 'deferred'
]
if method_name:
self._check_vars(method_name, args, kwargs)
self.generic_visit(node)
def reset(self):
"""Reset variables storing found strings and translation errors."""
self._found = set()
self._trans_errors = []
show_trans_strings = FindTransStrings()
def _find_func_definitions(
node: ast.AST, defs: list[ast.FunctionDef] | None = None
) -> list[ast.FunctionDef]:
"""Find all functions definition recrusively.
This also find functions nested inside other functions.
Parameters
----------
node : ast.Node
The initial node of the ast.
defs : list of ast.FunctionDef
A list of function definitions to accumulate.
Returns
-------
list of ast.FunctionDef
Function definitions found in `node`.
"""
try:
body = node.body
except AttributeError:
body = []
if defs is None:
defs = []
for node in body:
_find_func_definitions(node, defs=defs)
if isinstance(node, ast.FunctionDef):
defs.append(node)
return defs
def find_files(
path: str,
skip_folders: tuple,
skip_files: tuple,
extensions: tuple = ('.py',),
) -> list[str]:
"""Find recursively all files in path.
Parameters
----------
path : str
Path to a folder to find files in.
skip_folders : tuple
Skip folders containing folder to skip
skip_files : tuple
Skip files.
extensions : tuple, optional
Extensions to filter by. Default is (".py", )
Returns
-------
list
Sorted list of found files.
"""
found_files = []
for root, _dirs, files in os.walk(path, topdown=False):
for filename in files:
fpath = os.path.join(root, filename)
if any(folder in fpath for folder in skip_folders):
continue
if fpath in skip_files:
continue
if filename.endswith(extensions):
found_files.append(fpath)
return sorted(found_files)
def find_docstrings(fpath: str) -> dict[str, str]:
"""Find all docstrings in file path.
Parameters
----------
fpath : str
File path.
Returns
-------
dict
Simplified string as keys and the value is the original docstring
found.
"""
with open(fpath) as fh:
data = fh.read()
module = ast.parse(data)
docstrings = []
function_definitions = _find_func_definitions(module)
docstrings.extend([ast.get_docstring(f) for f in function_definitions])
class_definitions = [
node for node in module.body if isinstance(node, ast.ClassDef)
]
docstrings.extend([ast.get_docstring(f) for f in class_definitions])
method_definitions = []
for class_def in class_definitions:
method_definitions.extend(
[
node
for node in class_def.body
if isinstance(node, ast.FunctionDef)
]
)
docstrings.extend([ast.get_docstring(f) for f in method_definitions])
docstrings.append(ast.get_docstring(module))
docstrings = [doc for doc in docstrings if doc]
results = {}
for doc in docstrings:
key = ' '.join([it for it in doc.split() if it != ''])
results[key] = doc
return results
def compress_str(gen):
"""
This function takes a stream of token and tries to join
consecutive strings.
This is usefull for long translation string to be broken across
many lines.
This should support both joined strings without backslashes:
trans._(
"this"
"will"
"work"
)
Those have NL in between each STING.
The following will work as well:
trans._(
"this"\
"as"\
"well"
)
Those are just a sequence of STRING
There _might_ be edge cases with quotes, but I'm unsure
"""
acc, acc_line = [], None
for toktype, tokstr, (lineno, _), _, _ in gen:
if toktype not in (tokenize.STRING, tokenize.NL):
if acc:
nt = repr(''.join(acc))
yield tokenize.STRING, nt, acc_line
acc, acc_line = [], None
yield toktype, tokstr, lineno
elif toktype == tokenize.STRING:
if tokstr.startswith(("'", '"')):
acc.append(eval(tokstr))
else:
# b"", f"" ... are Strings
# the prefix can be more than one letter,
# like rf, rb...
trailing_quote = tokstr[-1]
start_quote_index = tokstr.find(trailing_quote)
prefix = tokstr[:start_quote_index]
suffix = tokstr[start_quote_index:]
assert suffix[0] == suffix[-1]
assert suffix[0] in ('"', "'")
if 'b' in prefix:
print(
'not translating bytestring', tokstr, file=sys.stderr
)
continue
# we remove the f as we do not want to evaluate the string
# if it contains variable. IT will crash as it evaluate in
# the context of this function.
safe_tokstr = prefix.replace('f', '') + suffix
acc.append(eval(safe_tokstr))
if not acc_line:
acc_line = lineno
else:
yield toktype, tokstr, lineno
if acc:
nt = repr(''.join(acc))
yield tokenize.STRING, nt, acc_line
def find_strings(fpath: str) -> dict[tuple[int, str], tuple[int, str]]:
"""Find all strings (and f-strings) for the given file.
Parameters
----------
fpath : str
File path.
Returns
-------
dict
A dict with a tuple for key and a tuple for value. The tuple contains
the line number and the stripped string. The value containes the line
number and the original string.
"""
strings = {}
with open(fpath) as f:
for toktype, tokstr, lineno in compress_str(
tokenize.generate_tokens(f.readline)
):
if toktype == tokenize.STRING:
try:
string = eval(tokstr)
except Exception: # noqa BLE001
string = eval(tokstr[1:])
if isinstance(string, str):
key = ' '.join([it for it in string.split() if it != ''])
strings[(lineno, key)] = (lineno, string)
return strings
def find_trans_strings(
fpath: str,
) -> tuple[dict[str, str], list[tuple[str, set[str]]]]:
"""Find all translation strings for the given file.
Parameters
----------
fpath : str
File path.
Returns
-------
tuple
The first item is a dict with a stripped string as key and the
orginal string for value. The second item is a list of tuples that
includes errors in translations.
"""
with open(fpath) as fh:
data = fh.read()
module = ast.parse(data)
trans_strings = {}
show_trans_strings.visit(module)
for string in show_trans_strings._found:
key = ' '.join(list(string.split()))
trans_strings[key] = string
errors = list(show_trans_strings._trans_errors)
show_trans_strings.reset()
return trans_strings, errors
def import_module_by_path(fpath: str) -> ModuleType | None:
"""Import a module given py a path.
Parameters
----------
fpath : str
The path to the file to import as module.
Returns
-------
ModuleType or None
The imported module or `None`.
"""
import importlib.util
fpath = fpath.replace('\\', '/')
module_name = fpath.replace('.py', '').replace('/', '.')
try:
module = importlib.import_module(module_name)
except ModuleNotFoundError:
module = None
return module
def find_issues(
paths: list[str], skip_words: list[str]
) -> tuple[StringIssuesDict, OutdatedStringsDict, TranslationErrorsDict]:
"""Find strings that have not been translated, and errors in translations.
This will not raise errors but return a list with found issues wo they
can be fixed at once.
Parameters
----------
paths : list of str
List of paths to files to check.
skip_words : list of str
List of words that should be skipped inside the given file.
Returns
-------
tuple
The first item is a dictionary of the list of issues found per path.
Each issue is a tuple with line number and the untranslated string.
The second item is a dictionary of files that contain outdated
skipped strings. The third item is a dictionary of the translation
errors found per path. Translation errors referes to missing
interpolation variables, or spelling errors of the `deferred` keyword.
"""
issues = {}
outdated_strings = {}
trans_errors = {}
for fpath in paths:
issues[fpath] = []
strings = find_strings(fpath)
trans_strings, errors = find_trans_strings(fpath)
doc_strings = find_docstrings(fpath)
skip_words_for_file = skip_words.get(fpath, [])
skip_words_for_file_check = skip_words_for_file[:]
module = import_module_by_path(fpath)
if module is None:
raise RuntimeError(f'Error loading {fpath}')
try:
__all__strings = module.__all__
if __all__strings is None:
__all__strings = []
except AttributeError:
__all__strings = []
for key in strings:
_lineno, string = key
_lineno, value = strings[key]
if (
string not in doc_strings
and string not in trans_strings
and value not in skip_words_for_file
and value not in __all__strings
and string != ''
and string.strip() != ''
and value not in SKIP_WORDS_GLOBAL
):
issues[fpath].append((_lineno, value))
elif value in skip_words_for_file_check:
skip_words_for_file_check.remove(value)
if skip_words_for_file_check:
outdated_strings[fpath] = skip_words_for_file_check
if errors:
trans_errors[fpath] = errors
if not issues[fpath]:
issues.pop(fpath)
return issues, outdated_strings, trans_errors
# --- Fixture
# ----------------------------------------------------------------------------
def _checks():
paths = find_files(NAPARI_MODULE, SKIP_FOLDERS, SKIP_FILES)
issues, outdated_strings, trans_errors = find_issues(paths, SKIP_WORDS)
return issues, outdated_strings, trans_errors
@pytest.fixture(scope='module')
def checks():
return _checks()
# --- Tests
# ----------------------------------------------------------------------------
def test_missing_translations(checks):
issues, _, _ = checks
print(
'\nSome strings on the following files might need to be translated '
'or added to the skip list.\nSkip list is located at '
'`tools/strings_list.py` file.\n\n'
)
for fpath, values in issues.items():
print(f'{fpath}\n{"*" * len(fpath)}')
unique_values = set()
for line, value in values:
unique_values.add(value)
print(f'{line}:\t{value!r}')
print('\n')
if fpath in SKIP_WORDS:
print(
f"List below can be copied directly to `tools/strings_list.py` file inside the '{fpath}' key:\n"
)
for value in sorted(unique_values):
print(f' {value!r},')
else:
print(
'List below can be copied directly to `tools/strings_list.py` file:\n'
)
print(f' {fpath!r}: [')
for value in sorted(unique_values):
print(f' {value!r},')
print(' ],')
print('\n')
no_issues = not issues
assert no_issues
def test_outdated_string_skips(checks):
_, outdated_strings, _ = checks
print(
'\nSome strings on the skip list on the `tools/strings_list.py` are '
'outdated.\nPlease remove them from the skip list.\n\n'
)
for fpath, values in outdated_strings.items():
print(f'{fpath}\n{"*" * len(fpath)}')
print(', '.join(repr(value) for value in values))
print('')
no_outdated_strings = not outdated_strings
assert no_outdated_strings
def test_translation_errors(checks):
_, _, trans_errors = checks
print(
'\nThe following translation strings do not provide some '
'interpolation variables:\n\n'
)
for fpath, errors in trans_errors.items():
print(f'{fpath}\n{"*" * len(fpath)}')
for string, variables in errors:
print(f'String:\t\t{string!r}')
print(
f'Variables:\t{", ".join(repr(value) for value in variables)}'
)
print('')
print('')
no_trans_errors = not trans_errors
assert no_trans_errors
def getch():
fd = sys.stdin.fileno()
old_settings = termios.tcgetattr(fd)
try:
tty.setraw(sys.stdin.fileno())
ch = sys.stdin.read(1)
finally:
termios.tcsetattr(fd, termios.TCSADRAIN, old_settings)
return ch
GREEN = '\x1b[1;32m'
RED = '\x1b[1;31m'
NORMAL = '\x1b[1;0m'
def print_colored_diff(old, new):
lines = list(difflib.unified_diff(old.splitlines(), new.splitlines()))
for line in lines[2:]:
if line.startswith('-'):
print(f'{RED}{line}{NORMAL}')
elif line.startswith('+'):
print(f'{GREEN}{line}{NORMAL}')
else:
print(line)
def clear_screen():
print(chr(27) + '[2J')
def _compute_autosugg(raw_code, text):
raw_code[:]
start = raw_code.find(f"'{text}'")
if start == -1:
start = raw_code.find(f'"{text}"')
if start == -1:
return None, False
stop = start + len(text) + 2
rawt = raw_code[start:stop]
sugg = raw_code[:start] + 'trans._(' + rawt + ')' + raw_code[stop:]
if sugg[start - 1] == 'f':
return None, False
return sugg, True
if __name__ == '__main__':
issues, outdated_strings, trans_errors = _checks()
import difflib
import json
import pathlib
edit_cmd = sys.argv[1] if len(sys.argv) > 1 else None
pth = pathlib.Path(__file__).parent / 'string_list.json'
data = json.loads(pth.read_text())
for file, items in outdated_strings.items():
for to_remove in set(items):
# we don't use set logic to keep the order the same as in the target
# files.
data['SKIP_WORDS'][file].remove(to_remove)
break_ = False
n_issues = sum([len(m) for m in issues.values()])
for file, missing in issues.items():
raw_code = Path(file).read_text()
code = raw_code.splitlines()
if break_:
break
for line, text in missing:
# skip current item if it has been added to current list
# this happens when a new strings is often added many time
# in the same file.
if text in data['SKIP_WORDS'].get(file, []):
continue
sugg, autosugg = _compute_autosugg(raw_code, text)
clear_screen()
print(
f'{RED}=== About {n_issues} items in {len(issues)} files to review ==={NORMAL}'
)
print()
print(f'{RED}{file}:{line}{NORMAL}', GREEN, repr(text), NORMAL)
if autosugg:
print_colored_diff(raw_code, sugg)
else:
print(f'{RED}f-string nedds manual intervention{NORMAL}')
for lt in code[line - 3 : line - 1]:
print(' ', lt)
print('>', code[line - 1].replace(text, GREEN + text + NORMAL))
for lt in code[line : line + 3]:
print(' ', lt)
print()
print()
print(
f'{RED}i{NORMAL} : ignore - add to ignored localised strings'
)
print(f'{RED}c{NORMAL} : continue - go to next')
if autosugg:
print(f'{RED}a{NORMAL} : Apply Auto suggestion')
else:
print('- : Auto suggestion not available here')
if edit_cmd:
print(f'{RED}e{NORMAL} : EDIT - using {edit_cmd!r}')
else:
print(
"- : Edit not available, call with python tools/validate_strings.py '$COMMAND {filename} {linenumber} '"
)
print(f'{RED}s{NORMAL} : save and quit')
print('> ', end='')
sys.stdout.flush()
val = getch()
if val == 'a' and autosugg:
content = Path(file).read_text()
new_content, _ = _compute_autosugg(content, text)
Path(file).write_text(new_content)
if val == 'e' and edit_cmd:
subprocess.run(
edit_cmd.format(filename=file, linenumber=line).split(' ')
)
if val == 'c':
continue
if val == 'i':
data['SKIP_WORDS'].setdefault(file, []).append(text)
elif val == 'q':
import sys
sys.exit(0)
elif val == 's':
break_ = True
break
pth.write_text(json.dumps(data, indent=4, sort_keys=True))
# test_outdated_string_skips(issues, outdated_strings, trans_errors)
|