1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633
|
#include "rss/parser.h"
#include <cstdint>
#include "3rd-party/catch.hpp"
#include "curlhandle.h"
#include "rss/exception.h"
#include "strprintf.h"
#include "test_helpers/exceptionwithmsg.h"
#include "test_helpers/httptestserver.h"
#include "test_helpers/misc.h"
#include "utils.h"
TEST_CASE("Throws exception if file doesn't exist", "[rsspp::Parser]")
{
using test_helpers::ExceptionWithMsg;
rsspp::Parser p;
REQUIRE_THROWS_MATCHES(p.parse_file("data/non-existent.xml"),
rsspp::Exception,
ExceptionWithMsg<rsspp::Exception>("could not parse file"));
}
TEST_CASE("Throws exception if file can't be parsed", "[rsspp::Parser]")
{
using test_helpers::ExceptionWithMsg;
rsspp::Parser p;
REQUIRE_THROWS_MATCHES(p.parse_file("data/empty.xml"),
rsspp::Exception,
ExceptionWithMsg<rsspp::Exception>("could not parse file"));
}
TEST_CASE("Extracts data from RSS 0.91", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/rss091_1.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_91);
REQUIRE(f.title == "Example Channel");
REQUIRE(f.description == "an example feed");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.language == "en");
REQUIRE(f.items.size() == 1u);
REQUIRE(f.items[0].title == "1 < 2");
REQUIRE(f.items[0].link == "http://example.com/1_less_than_2.html");
REQUIRE(f.items[0].description ==
"1 < 2, 3 < 4.\nIn HTML, <b> starts a bold phrase\nand you "
"start a link with <a href=\n");
REQUIRE(f.items[0].author == "");
REQUIRE(f.items[0].guid == "");
}
TEST_CASE("Doesn't crash or garble data if an item in RSS 0.9x contains "
"an empty author tag",
"[rsspp::Parser][issue542]")
{
rsspp::Parser p;
rsspp::Feed f;
const auto check = [&]() {
REQUIRE(f.title == "A Channel with Unnamed Authors");
REQUIRE(f.description == "an example feed");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.language == "en");
REQUIRE(f.items.size() == 2u);
REQUIRE(f.items[0].title == "This one has en empty author tag");
REQUIRE(f.items[0].link == "http://example.com/test_1.html");
REQUIRE(f.items[0].description == "It doesn't matter.");
REQUIRE(f.items[0].author == "");
REQUIRE(f.items[0].guid == "");
REQUIRE(f.items[1].title == "This one has en empty author tag as well");
REQUIRE(f.items[1].link == "http://example.com/test_2.html");
REQUIRE(f.items[1].description == "Non-empty description though.");
REQUIRE(f.items[1].author == "");
REQUIRE(f.items[1].guid == "");
};
SECTION("RSS 0.91") {
REQUIRE_NOTHROW(f = p.parse_file("data/rss_091_with_empty_author.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_91);
check();
}
SECTION("RSS 0.92") {
REQUIRE_NOTHROW(f = p.parse_file("data/rss_092_with_empty_author.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_92);
check();
}
SECTION("RSS 0.94") {
REQUIRE_NOTHROW(f = p.parse_file("data/rss_094_with_empty_author.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_94);
check();
}
}
TEST_CASE("Doesn't crash or garble data if an item in RSS 0.9x contains "
"an author tag which ends with a bracket",
"[rsspp::Parser][issue2834]")
{
rsspp::Parser p;
rsspp::Feed f;
const auto check = [&]() {
REQUIRE(f.title == "A Channel with Authors With Names Containing Brackets");
REQUIRE(f.description == "an example feed");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.language == "en");
REQUIRE(f.items.size() == 3u);
REQUIRE(f.items[0].title == "This one has an author name ending with a closing bracket");
REQUIRE(f.items[0].link == "http://example.com/test_1.html");
REQUIRE(f.items[0].description == "Non-empty description.");
REQUIRE(f.items[0].author == "Author name)");
REQUIRE(f.items[0].guid == "");
REQUIRE(f.items[1].title == "This one has an author name with an email in brackets");
REQUIRE(f.items[1].link == "http://example.com/test_2.html");
REQUIRE(f.items[1].description == "This is empty description (no).");
REQUIRE(f.items[1].author == "Author");
REQUIRE(f.items[1].guid == "");
REQUIRE(f.items[2].title ==
"This one has an author name with a non-email next in brackets");
REQUIRE(f.items[2].link == "http://example.com/test_3.html");
REQUIRE(f.items[2].description == "This is empty description (yes (no)).");
REQUIRE(f.items[2].author == "name");
REQUIRE(f.items[2].guid == "");
};
SECTION("RSS 0.91") {
REQUIRE_NOTHROW(f = p.parse_file("data/rss_091_with_bracket_author.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_91);
check();
}
SECTION("RSS 0.92") {
REQUIRE_NOTHROW(f = p.parse_file("data/rss_092_with_bracket_author.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_92);
check();
}
SECTION("RSS 0.94") {
REQUIRE_NOTHROW(f = p.parse_file("data/rss_094_with_bracket_author.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_94);
check();
}
}
TEST_CASE("Extracts data from RSS 0.92", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/rss092_1.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_0_92);
REQUIRE(f.title == "Example Channel");
REQUIRE(f.description == "an example feed");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.language == "en");
REQUIRE(f.items.size() == 3u);
REQUIRE(f.items[0].title == "1 < 2");
REQUIRE(f.items[0].link == "http://example.com/1_less_than_2.html");
REQUIRE(f.items[0].base == "http://example.com/feed/rss_testing.html");
REQUIRE(f.items[1].title == "A second item");
REQUIRE(f.items[1].link == "http://example.com/a_second_item.html");
REQUIRE(f.items[1].description == "no description");
REQUIRE(f.items[1].author == "");
REQUIRE(f.items[1].guid == "");
REQUIRE(f.items[1].base == "http://example.com/item/rss_testing.html");
REQUIRE(f.items[2].title == "A third item");
REQUIRE(f.items[2].link == "http://example.com/a_third_item.html");
REQUIRE(f.items[2].description == "no description");
REQUIRE(f.items[2].base == "http://example.com/desc/rss_testing.html");
}
TEST_CASE("Extracts data fro RSS 2.0", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/rss20_1.xml"));
REQUIRE(f.title == "my weblog");
REQUIRE(f.link == "http://example.com/blog/");
REQUIRE(f.description == "my description");
REQUIRE(f.items.size() == 1u);
REQUIRE(f.items[0].title == "this is an item");
REQUIRE(f.items[0].link ==
"http://example.com/blog/this_is_an_item.html");
REQUIRE(f.items[0].author == "Andreas Krennmair");
REQUIRE(f.items[0].author_email == "blog@synflood.at");
REQUIRE(f.items[0].content_encoded == "oh well, this is the content.");
REQUIRE(f.items[0].pubDate == "Fri, 12 Dec 2008 02:36:10 +0100");
REQUIRE(f.items[0].guid ==
"http://example.com/blog/this_is_an_item.html");
REQUIRE_FALSE(f.items[0].guid_isPermaLink);
}
TEST_CASE("Extracts data from RSS 1.0", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/rss10_1.xml"));
REQUIRE(f.rss_version == rsspp::Feed::RSS_1_0);
REQUIRE(f.title == "Example Dot Org");
REQUIRE(f.link == "http://www.example.org");
REQUIRE(f.description == "the Example Organization web site");
REQUIRE(f.items.size() == 1u);
REQUIRE(f.items[0].title == "New Status Updates");
REQUIRE(f.items[0].link == "http://www.example.org/status/foo");
REQUIRE(f.items[0].guid == "http://www.example.org/status/");
REQUIRE(f.items[0].description == "News about the Example project");
REQUIRE(f.items[0].pubDate == "Tue, 30 Dec 2008 07:20:00 +0000");
}
TEST_CASE("Extracts data from Atom 1.0", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/atom10_1.xml"));
REQUIRE(f.rss_version == rsspp::Feed::ATOM_1_0);
REQUIRE(f.title == "test atom");
REQUIRE(f.title_type == "text");
REQUIRE(f.description == "atom description!");
REQUIRE(f.pubDate == "Tue, 30 Dec 2008 18:26:15 +0000");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.items.size() == 3u);
REQUIRE(f.items[0].title == "A gentle introduction to Atom testing");
REQUIRE(f.items[0].title_type == "html");
REQUIRE(f.items[0].link == "http://example.com/atom_testing.html");
REQUIRE(f.items[0].guid == "tag:example.com,2008-12-30:/atom_testing");
REQUIRE(f.items[0].description == "some content");
REQUIRE(f.items[0].base == "http://example.com/feed/atom_testing.html");
REQUIRE(f.items[0].author == "A Person");
REQUIRE(f.items[1].title == "A missing rel attribute");
REQUIRE(f.items[1].title_type == "html");
REQUIRE(f.items[1].link == "http://example.com/atom_testing.html");
REQUIRE(f.items[1].guid == "tag:example.com,2008-12-30:/atom_testing1");
REQUIRE(f.items[1].description == "some content");
REQUIRE(f.items[1].base ==
"http://example.com/entry/atom_testing.html");
REQUIRE(f.items[1].author == "A different Person");
REQUIRE(f.items[2].title == "alternate link isn't first");
REQUIRE(f.items[2].title_type == "html");
REQUIRE(f.items[2].link == "http://example.com/atom_testing.html");
REQUIRE(f.items[2].guid == "tag:example.com,2008-12-30:/atom_testing2");
REQUIRE(f.items[2].description == "some content");
REQUIRE(f.items[2].base ==
"http://example.com/content/atom_testing.html");
REQUIRE(f.items[2].author == "Person A, Person B");
}
TEST_CASE("Extracts data from media:... tags in atom feed", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/atom10_2.xml"));
REQUIRE(f.rss_version == rsspp::Feed::ATOM_1_0);
REQUIRE(f.title == "Media test feed");
REQUIRE(f.title_type == "text");
REQUIRE(f.pubDate == "Tue, 30 Dec 2008 18:26:15 +0000");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.items.size() == 6u);
REQUIRE(f.items[0].title == "using regular content");
REQUIRE(f.items[0].description == "regular html content");
REQUIRE(f.items[0].description_mime_type == "text/html");
REQUIRE(f.items[0].author == "A Person");
REQUIRE(f.items[1].title == "using media:description");
REQUIRE(f.items[1].description == "media plaintext content");
REQUIRE(f.items[1].description_mime_type == "text/plain");
REQUIRE(f.items[1].author == "John Doe");
REQUIRE(f.items[2].title == "using multiple media tags");
REQUIRE(f.items[2].description == "media html content");
REQUIRE(f.items[2].description_mime_type == "text/html");
REQUIRE(f.items[2].link == "http://example.com/player.html");
REQUIRE(f.items[2].author == "John Doe");
REQUIRE(f.items[3].title ==
"using multiple media tags nested in group/content");
REQUIRE(f.items[3].description == "nested media html content");
REQUIRE(f.items[3].description_mime_type == "text/html");
REQUIRE(f.items[3].link == "http://example.com/player.html");
REQUIRE(f.items[3].author == "John Doe");
REQUIRE(f.items[3].enclosures.size() == 1);
REQUIRE(f.items[3].enclosures[0].description == "nested media html content");
REQUIRE(f.items[3].enclosures[0].description_mime_type == "text/html");
SECTION("media:{title,description,player} does not overwrite regular title, description, and link if they exist") {
REQUIRE(f.items[4].title == "regular title");
REQUIRE(f.items[4].description == "regular content");
REQUIRE(f.items[4].description_mime_type == "text/html");
REQUIRE(f.items[4].link == "http://example.com/regular-link");
REQUIRE(f.items[4].author == "John Doe");
}
REQUIRE(f.items[5].title == "using media:content");
REQUIRE(f.items[5].description == "regular content");
REQUIRE(f.items[5].description_mime_type == "text/html");
REQUIRE(f.items[5].link == "http://example.com/4.html");
REQUIRE(f.items[5].enclosures.size() == 2);
REQUIRE(f.items[5].enclosures[0].url == "http://example.com/media-test.png");
REQUIRE(f.items[5].enclosures[0].type == "image/png");
REQUIRE(f.items[5].enclosures[1].url == "http://example.com/movie.mov");
REQUIRE(f.items[5].enclosures[1].type == "video/quicktime");
}
TEST_CASE("Extracts data from media:... tags in RSS 2.0 feeds",
"[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/rss20_2.xml"));
REQUIRE(f.title == "my weblog");
REQUIRE(f.link == "http://example.com/blog/");
REQUIRE(f.description == "my description");
REQUIRE(f.items.size() == 3u);
REQUIRE(f.items[0].title == "using multiple media tags");
REQUIRE(f.items[0].description == "media html content");
REQUIRE(f.items[0].description_mime_type == "text/html");
REQUIRE(f.items[0].link == "http://example.com/player.html");
REQUIRE(f.items[1].title ==
"using multiple media tags nested in group/content");
REQUIRE(f.items[1].description == "nested media html content");
REQUIRE(f.items[1].description_mime_type == "text/html");
REQUIRE(f.items[1].link == "http://example.com/player.html");
REQUIRE(f.items[1].enclosures.size() == 1);
REQUIRE(f.items[1].enclosures[0].description == "nested media html content");
REQUIRE(f.items[1].enclosures[0].description_mime_type == "text/html");
REQUIRE(f.items[2].enclosures.size() == 2);
REQUIRE(f.items[2].enclosures[0].url == "http://example.com/media-test.png");
REQUIRE(f.items[2].enclosures[0].type == "image/png");
REQUIRE(f.items[2].enclosures[1].url == "http://example.com/movie.mov");
REQUIRE(f.items[2].enclosures[1].type == "video/quicktime");
}
TEST_CASE("Multiple links in item", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/multiple_item_links.atom"));
REQUIRE(f.items.size() == 1u);
REQUIRE(f.items[0].title == "Multiple links");
REQUIRE(f.items[0].link == "http://www.test.org/tests");
}
TEST_CASE("Feed authors and source authors in atom feed", "[rsspp::Parser]")
{
rsspp::Parser p;
rsspp::Feed f;
REQUIRE_NOTHROW(f = p.parse_file("data/atom10_feed_authors.xml"));
REQUIRE(f.rss_version == rsspp::Feed::ATOM_1_0);
REQUIRE(f.title == "Author Test Feed");
REQUIRE(f.title_type == "text");
REQUIRE(f.pubDate == "Mon, 28 Nov 2022 13:01:25 +0000");
REQUIRE(f.link == "http://example.com/");
REQUIRE(f.items.size() == 9u);
REQUIRE(f.items[0].title == "Entry Without Author");
REQUIRE(f.items[0].description == "Feed authors should be used.");
REQUIRE(f.items[0].author == "First Feed Author, Second Feed Author");
REQUIRE(f.items[1].title == "Entry With Single Author");
REQUIRE(f.items[1].description == "Entry author should be used.");
REQUIRE(f.items[1].author == "Entry Author");
REQUIRE(f.items[2].title == "Entry With Multiple Authors");
REQUIRE(f.items[2].description == "Both entry authors should be used.");
REQUIRE(f.items[2].author == "Entry Author 1, Entry Author 2");
REQUIRE(f.items[3].title == "Entry With Empty Author Names");
REQUIRE(f.items[3].description == "Both feed authors should be used.");
REQUIRE(f.items[3].author == "First Feed Author, Second Feed Author");
REQUIRE(f.items[4].title == "Entry With Single Source Author");
REQUIRE(f.items[4].description == "Entry source author should be used.");
REQUIRE(f.items[4].author == "Entry Source Author");
REQUIRE(f.items[5].title == "Entry With Multiple Source Authors");
REQUIRE(f.items[5].description == "All entry source authors should be used.");
REQUIRE(f.items[5].author ==
"Entry Source Author 1, Entry Source Author 2, Entry Source Author 3");
REQUIRE(f.items[6].title == "Entry With Empty Source Author Names");
REQUIRE(f.items[6].description == "Both feed authors should be used.");
REQUIRE(f.items[6].author == "First Feed Author, Second Feed Author");
REQUIRE(f.items[7].title == "Entry With Single Author And Source Author");
REQUIRE(f.items[7].description == "Entry author should be used.");
REQUIRE(f.items[7].author == "Entry Author");
REQUIRE(f.items[8].title == "Entry With Multiple Author And Source Authors");
REQUIRE(f.items[8].description == "Both entry authors should be used.");
REQUIRE(f.items[8].author == "Entry Author 1, Entry Author 2");
}
TEST_CASE("parse_url() extracts etag and lastmodified data", "[rsspp::Parser]")
{
using namespace newsboat;
auto feed_xml = test_helpers::read_binary_file("data/atom10_1.xml");
auto& test_server = test_helpers::HttpTestServer::get_instance();
auto mock_registration = test_server.add_endpoint("/feed", {}, 200, {
{"content-type", "text/xml"},
{"ETag", "returned-etag"},
{"Last-Modified", "Wed, 21 Oct 2015 07:28:00 GMT"},
}, feed_xml);
const auto address = test_server.get_address();
const auto url = strprintf::fmt("http://%s/feed", address);
rsspp::Parser parser;
CurlHandle easyhandle;
parser.parse_url(url, easyhandle);
REQUIRE(parser.get_etag() == "returned-etag");
REQUIRE(parser.get_last_modified() == 1445412480);
}
// Placeholders:
// %s: encoding
// %s: feed title
constexpr auto atom_feed_with_encoding =
R"(<?xml version="1.0" encoding="%s"?>)"
R"(<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en">)"
R"(<id>tag:example.com</id>)"
R"(<title type="text">%s</title>)"
R"(<updated>2008-12-30T18:26:15Z</updated>)"
R"(<entry>)"
R"(<id>tag:example.com,2008-12-30:/atom_testing</id>)"
R"(<title>regular title</title>)"
R"(<updated>2008-12-30T20:04:15Z</updated>)"
R"(</entry>)"
R"(</feed>)";
TEST_CASE("parse_url() converts data if specified in xml encoding attribute",
"[rsspp::Parser]")
{
using namespace newsboat;
constexpr auto title_utf8 = u8"タイトル"; // Japanese for "title"
auto feed_xml_utf8 = strprintf::fmt(atom_feed_with_encoding, "utf-16", title_utf8);
auto feed_xml_utf16 = utils::convert_text(feed_xml_utf8, "utf-16", "utf-8");
auto feed_xml = std::vector<std::uint8_t>(feed_xml_utf16.begin(), feed_xml_utf16.end());
auto& test_server = test_helpers::HttpTestServer::get_instance();
auto mock_registration = test_server.add_endpoint("/feed", {}, 200, {
{"content-type", "text/xml"},
}, feed_xml);
const auto address = test_server.get_address();
const auto url = strprintf::fmt("http://%s/feed", address);
rsspp::Parser parser;
CurlHandle easyhandle;
auto parsed_feed = parser.parse_url(url, easyhandle);
REQUIRE(parsed_feed.items.size() == 1);
REQUIRE(parsed_feed.title == title_utf8);
}
TEST_CASE("parse_url() only converts once even when encoding specified twice (xml encoding and http header)",
"[rsspp::Parser]")
{
using namespace newsboat;
constexpr auto title_utf8 = u8"Prøve"; // Danish for "test"
auto feed_xml_utf8 = strprintf::fmt(atom_feed_with_encoding, "iso-8859-1", title_utf8);
auto feed_xml_iso8859_1 = utils::convert_text(feed_xml_utf8, "iso-8859-1", "utf-8");
auto feed_xml = std::vector<std::uint8_t>(feed_xml_iso8859_1.begin(),
feed_xml_iso8859_1.end());
auto& test_server = test_helpers::HttpTestServer::get_instance();
auto mock_registration = test_server.add_endpoint("/feed", {}, 200, {
{"content-type", "text/xml; charset=iso-8859-1"},
}, feed_xml);
const auto address = test_server.get_address();
const auto url = strprintf::fmt("http://%s/feed", address);
rsspp::Parser parser;
CurlHandle easyhandle;
auto parsed_feed = parser.parse_url(url, easyhandle);
REQUIRE(parsed_feed.items.size() == 1);
REQUIRE(parsed_feed.title == title_utf8);
}
TEST_CASE("parse_url() uses xml encoding if specified encodings conflict (xml encoding vs http header)",
"[rsspp::Parser]")
{
using namespace newsboat;
constexpr auto title_utf8 = u8"Prøve"; // Danish for "test"
auto feed_xml_utf8 = strprintf::fmt(atom_feed_with_encoding, "iso-8859-1", title_utf8);
auto feed_xml_iso8859_1 = utils::convert_text(feed_xml_utf8, "iso-8859-1", "utf-8");
auto feed_xml = std::vector<std::uint8_t>(feed_xml_iso8859_1.begin(),
feed_xml_iso8859_1.end());
auto& test_server = test_helpers::HttpTestServer::get_instance();
auto mock_registration = test_server.add_endpoint("/feed", {}, 200, {
{"content-type", "text/xml; charset=utf-16"}, // Expected to be ignored
}, feed_xml);
const auto address = test_server.get_address();
const auto url = strprintf::fmt("http://%s/feed", address);
rsspp::Parser parser;
CurlHandle easyhandle;
auto parsed_feed = parser.parse_url(url, easyhandle);
REQUIRE(parsed_feed.items.size() == 1);
REQUIRE(parsed_feed.title == title_utf8);
}
// Placeholders:
// %s: feed title
constexpr auto atom_feed_without_encoding =
R"(<?xml version="1.0"?>)"
R"(<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en">)"
R"(<id>tag:example.com</id>)"
R"(<title type="text">%s</title>)"
R"(<updated>2008-12-30T18:26:15Z</updated>)"
R"(<entry>)"
R"(<id>tag:example.com,2008-12-30:/atom_testing</id>)"
R"(<title>regular title</title>)"
R"(<updated>2008-12-30T20:04:15Z</updated>)"
R"(</entry>)"
R"(</feed>)";
TEST_CASE("parse_url() applies encoding specified in http header if no xml encoding specified",
"[rsspp::Parser]")
{
using namespace newsboat;
constexpr auto title_utf8 = u8"Prøve"; // Danish for "test"
auto feed_xml_utf8 = strprintf::fmt(atom_feed_without_encoding, title_utf8);
auto feed_xml_iso8859_1 = utils::convert_text(feed_xml_utf8, "iso-8859-1", "utf-8");
auto feed_xml = std::vector<std::uint8_t>(feed_xml_iso8859_1.begin(),
feed_xml_iso8859_1.end());
auto& test_server = test_helpers::HttpTestServer::get_instance();
auto mock_registration = test_server.add_endpoint("/feed", {}, 200, {
{"content-type", "text/xml; charset=iso-8859-1"},
}, feed_xml);
const auto address = test_server.get_address();
const auto url = strprintf::fmt("http://%s/feed", address);
rsspp::Parser parser;
CurlHandle easyhandle;
auto parsed_feed = parser.parse_url(url, easyhandle);
REQUIRE(parsed_feed.items.size() == 1);
REQUIRE(parsed_feed.title == title_utf8);
}
TEST_CASE("parse_url() assumes utf-8 if no encoding specified and replaces invalid code units",
"[rsspp::Parser]")
{
using namespace newsboat;
constexpr auto title_utf8 = u8"Prøve"; // Danish for "test"
constexpr auto expected_title = u8"Pr�ve";
auto feed_xml_utf8 = strprintf::fmt(atom_feed_without_encoding, title_utf8);
auto feed_xml_iso8859_1 = utils::convert_text(feed_xml_utf8, "iso-8859-1", "utf-8");
auto feed_xml = std::vector<std::uint8_t>(feed_xml_iso8859_1.begin(),
feed_xml_iso8859_1.end());
auto& test_server = test_helpers::HttpTestServer::get_instance();
auto mock_registration = test_server.add_endpoint("/feed", {}, 200, {}, feed_xml);
const auto address = test_server.get_address();
const auto url = strprintf::fmt("http://%s/feed", address);
rsspp::Parser parser;
CurlHandle easyhandle;
auto parsed_feed = parser.parse_url(url, easyhandle);
REQUIRE(parsed_feed.items.size() == 1);
REQUIRE(parsed_feed.title == expected_title);
}
|