1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871 4872 4873 4874 4875 4876 4877 4878 4879 4880 4881 4882 4883 4884 4885 4886 4887 4888 4889 4890 4891 4892 4893 4894 4895 4896 4897 4898 4899 4900 4901 4902 4903 4904 4905 4906 4907 4908 4909 4910 4911 4912 4913 4914 4915 4916 4917 4918 4919 4920 4921 4922 4923 4924 4925 4926 4927 4928 4929 4930 4931 4932 4933 4934 4935 4936 4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989 4990 4991 4992 4993 4994 4995 4996 4997 4998 4999 5000 5001 5002 5003 5004 5005 5006 5007 5008 5009 5010 5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024 5025 5026 5027 5028 5029 5030 5031 5032 5033 5034 5035 5036 5037 5038 5039 5040 5041 5042 5043 5044 5045 5046 5047 5048 5049 5050 5051 5052 5053 5054 5055 5056 5057 5058 5059 5060 5061 5062 5063 5064 5065 5066 5067 5068 5069 5070 5071 5072 5073 5074 5075 5076 5077 5078 5079 5080 5081 5082 5083 5084 5085 5086 5087 5088 5089 5090 5091 5092 5093 5094 5095 5096 5097 5098 5099 5100 5101 5102 5103 5104 5105 5106 5107 5108 5109 5110 5111 5112 5113 5114 5115 5116 5117 5118 5119 5120 5121 5122 5123 5124 5125 5126 5127 5128 5129 5130 5131 5132 5133 5134 5135 5136 5137 5138 5139 5140 5141 5142 5143 5144 5145 5146 5147 5148 5149 5150 5151 5152 5153 5154 5155 5156 5157 5158 5159 5160 5161 5162 5163 5164 5165 5166 5167 5168 5169 5170 5171 5172 5173 5174 5175 5176 5177 5178 5179 5180 5181 5182 5183 5184 5185 5186 5187 5188 5189 5190 5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204 5205 5206 5207 5208 5209 5210 5211 5212 5213 5214 5215 5216 5217 5218 5219 5220 5221 5222 5223 5224 5225 5226 5227 5228 5229 5230 5231 5232 5233 5234 5235 5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269 5270 5271 5272 5273 5274 5275 5276 5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289 5290 5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312 5313 5314 5315 5316 5317 5318 5319 5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396 5397 5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411 5412 5413 5414 5415 5416 5417 5418 5419 5420 5421 5422 5423 5424 5425 5426 5427 5428 5429 5430 5431 5432 5433 5434 5435 5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774 5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786 5787 5788 5789 5790 5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821 5822 5823 5824 5825 5826 5827 5828 5829 5830 5831 5832 5833 5834 5835 5836 5837 5838 5839 5840 5841 5842 5843 5844 5845 5846 5847 5848 5849 5850 5851 5852 5853 5854 5855 5856 5857 5858 5859 5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877 5878 5879 5880 5881 5882 5883 5884 5885 5886 5887 5888 5889 5890 5891 5892 5893 5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910 5911 5912 5913 5914 5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948 5949 5950 5951 5952 5953 5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971 5972 5973 5974 5975 5976 5977 5978 5979 5980 5981 5982 5983 5984 5985 5986 5987 5988 5989 5990 5991 5992 5993 5994 5995 5996 5997 5998 5999 6000 6001 6002 6003 6004 6005 6006 6007 6008 6009 6010 6011 6012 6013 6014 6015 6016 6017 6018 6019 6020 6021 6022 6023 6024 6025 6026 6027 6028 6029 6030 6031 6032 6033 6034 6035 6036 6037 6038 6039 6040 6041 6042 6043 6044 6045 6046 6047 6048 6049 6050 6051 6052 6053 6054 6055 6056 6057 6058 6059 6060 6061 6062 6063 6064 6065 6066 6067 6068 6069 6070 6071 6072 6073 6074 6075 6076 6077 6078 6079 6080 6081 6082 6083 6084 6085 6086 6087 6088 6089 6090 6091 6092 6093 6094 6095 6096 6097 6098 6099 6100 6101 6102 6103 6104 6105 6106 6107 6108 6109 6110 6111 6112 6113 6114 6115 6116 6117 6118 6119 6120 6121 6122 6123 6124 6125 6126 6127 6128 6129 6130 6131 6132 6133 6134 6135 6136 6137 6138 6139 6140 6141 6142 6143 6144 6145 6146 6147 6148 6149 6150 6151 6152 6153 6154 6155 6156 6157 6158 6159 6160 6161 6162 6163 6164 6165 6166 6167 6168 6169 6170 6171 6172 6173 6174 6175 6176 6177 6178 6179 6180 6181 6182 6183 6184 6185 6186 6187 6188 6189 6190 6191 6192 6193 6194 6195 6196 6197 6198 6199 6200 6201 6202 6203 6204 6205 6206 6207 6208 6209 6210 6211 6212 6213 6214 6215 6216 6217 6218 6219 6220 6221 6222 6223 6224 6225 6226 6227 6228 6229 6230 6231 6232 6233 6234 6235 6236 6237 6238 6239 6240 6241 6242 6243 6244 6245 6246 6247 6248 6249 6250 6251 6252 6253 6254 6255 6256 6257 6258 6259 6260 6261 6262 6263 6264 6265 6266 6267 6268 6269 6270 6271 6272 6273 6274 6275 6276 6277 6278 6279 6280 6281 6282 6283 6284 6285 6286 6287 6288 6289 6290 6291 6292 6293 6294 6295 6296 6297 6298 6299 6300 6301 6302 6303 6304 6305 6306 6307 6308 6309 6310 6311 6312 6313 6314 6315 6316 6317 6318 6319 6320 6321 6322 6323 6324 6325 6326 6327 6328 6329 6330 6331 6332 6333 6334 6335 6336 6337 6338 6339 6340 6341 6342 6343 6344 6345 6346 6347 6348 6349 6350 6351 6352 6353 6354 6355 6356 6357 6358 6359 6360 6361 6362 6363 6364 6365 6366 6367 6368 6369 6370 6371 6372 6373 6374 6375 6376 6377 6378 6379 6380 6381 6382 6383 6384 6385 6386 6387 6388 6389 6390 6391 6392 6393 6394 6395 6396 6397 6398 6399 6400 6401 6402 6403 6404 6405 6406 6407 6408 6409 6410 6411 6412 6413 6414 6415 6416 6417 6418 6419 6420 6421 6422 6423 6424 6425 6426 6427 6428 6429 6430 6431 6432 6433 6434 6435 6436 6437 6438 6439 6440 6441 6442 6443 6444 6445 6446 6447 6448 6449 6450 6451 6452 6453 6454 6455 6456 6457 6458 6459 6460 6461 6462 6463 6464 6465 6466 6467 6468 6469 6470 6471 6472 6473 6474 6475 6476 6477 6478 6479 6480 6481 6482 6483 6484 6485 6486 6487 6488 6489 6490 6491 6492 6493 6494 6495 6496 6497 6498 6499 6500 6501 6502 6503 6504 6505 6506 6507 6508 6509 6510 6511 6512 6513 6514 6515 6516 6517 6518 6519 6520 6521 6522 6523 6524 6525 6526 6527 6528 6529 6530 6531 6532 6533 6534 6535 6536 6537 6538 6539 6540 6541 6542 6543 6544 6545 6546 6547 6548 6549 6550 6551 6552 6553 6554 6555 6556 6557 6558 6559 6560 6561 6562 6563 6564 6565 6566 6567 6568 6569 6570 6571 6572 6573 6574 6575 6576 6577 6578 6579 6580 6581 6582 6583 6584 6585 6586 6587 6588 6589 6590 6591 6592 6593 6594 6595 6596 6597 6598 6599 6600 6601 6602 6603 6604 6605 6606 6607 6608 6609 6610 6611 6612 6613 6614 6615 6616 6617 6618 6619 6620 6621 6622 6623 6624 6625 6626 6627 6628 6629 6630 6631 6632 6633 6634 6635 6636 6637 6638 6639 6640 6641 6642 6643 6644 6645 6646 6647 6648 6649 6650 6651 6652 6653 6654 6655 6656 6657 6658 6659 6660 6661 6662 6663 6664 6665 6666 6667 6668 6669 6670 6671 6672 6673 6674 6675 6676 6677 6678 6679 6680 6681 6682 6683 6684 6685 6686 6687 6688 6689 6690 6691 6692 6693 6694 6695 6696 6697 6698 6699 6700 6701 6702 6703 6704 6705 6706 6707 6708 6709 6710 6711 6712 6713 6714 6715 6716 6717 6718 6719 6720 6721 6722 6723 6724 6725 6726 6727 6728 6729 6730 6731 6732 6733 6734 6735 6736 6737 6738 6739 6740 6741 6742 6743 6744 6745 6746 6747 6748 6749 6750 6751 6752 6753 6754 6755 6756 6757 6758 6759 6760 6761 6762 6763 6764 6765 6766 6767 6768 6769 6770 6771 6772 6773 6774 6775 6776 6777 6778 6779 6780 6781 6782 6783 6784 6785 6786 6787 6788 6789 6790 6791 6792 6793 6794 6795 6796 6797 6798 6799 6800 6801 6802 6803 6804 6805 6806 6807 6808 6809 6810 6811 6812 6813 6814 6815 6816 6817 6818 6819 6820 6821 6822 6823 6824 6825 6826 6827 6828 6829 6830 6831 6832 6833 6834 6835 6836 6837 6838 6839 6840 6841 6842 6843 6844 6845 6846 6847 6848 6849 6850 6851 6852 6853 6854 6855 6856 6857 6858 6859 6860 6861 6862 6863 6864 6865 6866 6867 6868 6869 6870 6871 6872 6873 6874 6875 6876 6877 6878 6879 6880 6881 6882 6883 6884 6885 6886 6887 6888 6889 6890 6891 6892 6893 6894 6895 6896 6897 6898 6899 6900 6901 6902 6903 6904 6905 6906 6907 6908 6909 6910 6911 6912 6913 6914 6915 6916 6917 6918 6919 6920 6921 6922 6923 6924 6925 6926 6927 6928 6929 6930 6931 6932 6933 6934 6935 6936 6937 6938 6939 6940 6941 6942 6943 6944 6945 6946 6947 6948 6949 6950 6951 6952 6953 6954 6955 6956 6957 6958 6959 6960 6961 6962 6963 6964 6965 6966 6967 6968 6969 6970 6971 6972 6973 6974 6975 6976 6977 6978 6979 6980 6981 6982 6983 6984 6985 6986 6987 6988 6989 6990 6991 6992 6993 6994 6995 6996 6997 6998 6999 7000 7001 7002 7003 7004 7005 7006 7007 7008 7009 7010 7011 7012 7013 7014 7015 7016 7017 7018 7019 7020 7021 7022 7023 7024 7025 7026 7027 7028 7029 7030 7031 7032 7033 7034 7035 7036 7037 7038 7039 7040 7041 7042 7043 7044 7045 7046 7047 7048 7049 7050 7051 7052 7053 7054 7055 7056 7057 7058 7059 7060 7061 7062 7063 7064 7065 7066 7067 7068 7069 7070 7071 7072 7073 7074 7075 7076 7077 7078 7079 7080 7081 7082 7083 7084 7085 7086 7087 7088 7089 7090 7091 7092 7093 7094 7095 7096 7097 7098 7099 7100 7101 7102 7103 7104 7105 7106 7107 7108 7109 7110 7111 7112 7113 7114 7115 7116 7117 7118 7119 7120 7121 7122 7123 7124 7125 7126 7127 7128 7129 7130 7131 7132 7133 7134 7135 7136 7137 7138 7139 7140 7141 7142 7143 7144 7145 7146 7147 7148 7149 7150 7151 7152 7153 7154 7155 7156 7157 7158 7159 7160 7161 7162 7163 7164 7165 7166 7167 7168 7169 7170 7171 7172 7173 7174 7175 7176 7177 7178 7179 7180 7181 7182 7183 7184 7185 7186 7187 7188 7189 7190 7191 7192 7193 7194 7195 7196 7197 7198 7199 7200 7201 7202 7203 7204 7205 7206 7207 7208 7209 7210 7211 7212 7213 7214 7215 7216 7217 7218 7219 7220 7221 7222 7223 7224 7225 7226 7227 7228 7229 7230 7231 7232 7233 7234 7235 7236 7237 7238 7239 7240 7241 7242 7243 7244 7245 7246 7247 7248 7249 7250 7251 7252 7253 7254 7255 7256 7257 7258 7259 7260 7261 7262 7263 7264 7265 7266 7267 7268 7269 7270 7271 7272 7273 7274 7275 7276 7277 7278 7279 7280 7281 7282 7283 7284 7285 7286 7287 7288 7289 7290 7291 7292 7293 7294 7295 7296 7297 7298 7299 7300 7301 7302 7303 7304 7305 7306 7307 7308 7309 7310 7311 7312 7313 7314 7315 7316 7317 7318 7319 7320 7321 7322 7323 7324 7325 7326 7327 7328 7329 7330 7331 7332 7333 7334 7335 7336 7337 7338 7339 7340 7341 7342 7343 7344 7345 7346 7347 7348 7349 7350 7351 7352 7353 7354 7355 7356 7357 7358 7359 7360 7361 7362 7363 7364 7365 7366 7367 7368 7369 7370 7371 7372 7373 7374 7375 7376 7377 7378 7379 7380 7381 7382 7383 7384 7385 7386 7387 7388 7389 7390 7391 7392 7393 7394 7395 7396 7397 7398 7399 7400 7401 7402 7403 7404 7405 7406 7407 7408 7409 7410 7411 7412 7413 7414 7415 7416 7417 7418 7419 7420 7421 7422 7423 7424 7425 7426 7427 7428 7429 7430 7431 7432 7433 7434 7435 7436 7437 7438 7439 7440 7441 7442 7443 7444 7445 7446 7447 7448 7449 7450 7451 7452 7453 7454 7455 7456 7457 7458 7459 7460 7461 7462 7463 7464 7465 7466 7467 7468 7469 7470 7471 7472 7473 7474 7475 7476 7477 7478 7479 7480 7481 7482 7483 7484 7485 7486 7487 7488 7489 7490 7491 7492 7493 7494 7495 7496 7497 7498 7499 7500 7501 7502 7503 7504 7505 7506 7507 7508 7509 7510 7511 7512 7513 7514 7515 7516 7517 7518 7519 7520 7521 7522 7523 7524 7525 7526 7527 7528 7529 7530 7531 7532 7533 7534 7535 7536 7537 7538 7539 7540 7541 7542 7543 7544 7545 7546 7547 7548 7549 7550 7551 7552 7553 7554 7555 7556 7557 7558 7559 7560 7561 7562 7563 7564 7565 7566 7567 7568 7569 7570 7571 7572 7573 7574 7575 7576 7577 7578 7579 7580 7581 7582 7583 7584 7585 7586 7587 7588 7589 7590 7591 7592 7593 7594 7595 7596 7597 7598 7599 7600 7601 7602 7603 7604 7605 7606 7607 7608 7609 7610 7611 7612 7613 7614 7615 7616 7617 7618 7619 7620 7621 7622 7623 7624 7625 7626 7627 7628 7629 7630 7631 7632 7633 7634 7635 7636 7637 7638 7639 7640 7641 7642 7643 7644 7645 7646 7647 7648 7649 7650 7651 7652 7653 7654 7655 7656 7657 7658 7659 7660 7661 7662 7663 7664 7665 7666 7667 7668 7669 7670 7671 7672 7673 7674 7675 7676 7677 7678 7679 7680 7681 7682 7683 7684 7685 7686 7687 7688 7689 7690 7691 7692 7693 7694 7695 7696 7697 7698 7699 7700 7701 7702 7703 7704 7705 7706 7707 7708 7709 7710 7711 7712 7713 7714 7715 7716 7717 7718 7719 7720 7721 7722 7723 7724 7725 7726 7727 7728 7729 7730 7731 7732 7733 7734 7735 7736 7737 7738 7739 7740 7741 7742 7743 7744 7745 7746 7747 7748 7749 7750 7751 7752 7753 7754 7755 7756 7757 7758 7759 7760 7761 7762 7763 7764 7765 7766 7767 7768 7769 7770 7771 7772 7773 7774 7775 7776 7777 7778 7779 7780 7781 7782 7783 7784 7785 7786 7787 7788 7789 7790 7791 7792 7793 7794 7795 7796 7797 7798 7799 7800 7801 7802 7803 7804 7805 7806 7807 7808 7809 7810 7811 7812 7813 7814 7815 7816 7817 7818 7819 7820 7821 7822 7823 7824 7825 7826 7827 7828 7829 7830 7831 7832 7833 7834 7835 7836 7837 7838 7839 7840 7841 7842 7843 7844 7845 7846 7847 7848 7849 7850 7851 7852 7853 7854 7855 7856 7857 7858 7859 7860 7861 7862 7863 7864 7865 7866 7867 7868 7869 7870 7871 7872 7873 7874 7875 7876 7877 7878 7879 7880 7881 7882 7883 7884 7885 7886 7887 7888 7889 7890 7891 7892 7893 7894 7895 7896 7897 7898 7899 7900 7901 7902 7903 7904 7905 7906 7907 7908 7909 7910 7911 7912 7913 7914 7915 7916 7917 7918 7919 7920 7921 7922 7923 7924 7925 7926 7927 7928 7929 7930 7931 7932 7933 7934 7935 7936 7937 7938 7939 7940 7941 7942 7943 7944 7945 7946 7947 7948 7949 7950 7951 7952 7953 7954 7955 7956 7957 7958 7959 7960 7961 7962 7963 7964 7965 7966 7967 7968 7969 7970 7971 7972 7973 7974 7975 7976 7977 7978 7979 7980 7981 7982 7983 7984 7985 7986 7987 7988 7989 7990 7991 7992 7993 7994 7995 7996 7997 7998 7999 8000 8001 8002 8003 8004 8005 8006 8007 8008 8009 8010 8011 8012 8013 8014 8015 8016 8017 8018 8019 8020 8021 8022 8023 8024 8025 8026 8027 8028 8029 8030 8031 8032 8033 8034 8035 8036 8037 8038 8039 8040 8041 8042 8043 8044 8045 8046 8047 8048 8049 8050 8051 8052 8053 8054 8055 8056 8057 8058 8059 8060 8061 8062 8063 8064 8065 8066 8067 8068 8069 8070 8071 8072 8073 8074 8075 8076 8077 8078 8079 8080 8081 8082 8083 8084 8085 8086 8087 8088 8089 8090 8091 8092 8093 8094 8095 8096 8097 8098 8099 8100 8101 8102 8103 8104 8105 8106 8107 8108 8109 8110 8111 8112 8113 8114 8115 8116 8117 8118 8119 8120 8121 8122 8123 8124 8125 8126 8127 8128 8129 8130 8131 8132 8133 8134 8135 8136 8137 8138 8139 8140 8141 8142 8143 8144 8145 8146 8147 8148 8149 8150 8151 8152 8153 8154 8155 8156 8157 8158 8159 8160 8161 8162 8163 8164 8165 8166 8167 8168 8169 8170 8171 8172 8173 8174 8175 8176 8177 8178 8179 8180 8181 8182 8183 8184 8185 8186 8187 8188 8189 8190 8191 8192 8193 8194 8195 8196 8197 8198 8199 8200 8201 8202 8203 8204 8205 8206 8207 8208 8209 8210 8211 8212 8213 8214 8215 8216 8217 8218 8219 8220 8221 8222 8223 8224 8225 8226 8227 8228 8229 8230 8231 8232 8233 8234 8235 8236 8237 8238 8239 8240 8241 8242 8243 8244 8245 8246 8247 8248 8249 8250 8251 8252 8253 8254 8255 8256 8257 8258 8259 8260 8261 8262 8263 8264 8265 8266 8267 8268 8269 8270 8271 8272 8273 8274 8275 8276 8277 8278 8279 8280 8281 8282 8283 8284 8285 8286 8287 8288 8289 8290 8291 8292 8293 8294 8295 8296 8297 8298 8299 8300 8301 8302 8303 8304 8305 8306 8307 8308 8309 8310 8311 8312 8313 8314 8315 8316 8317 8318 8319 8320 8321 8322 8323 8324 8325 8326 8327 8328 8329 8330 8331 8332 8333 8334 8335 8336 8337 8338 8339 8340 8341 8342 8343 8344 8345 8346 8347 8348 8349 8350 8351 8352 8353 8354 8355 8356 8357 8358 8359 8360 8361 8362 8363 8364 8365 8366 8367 8368 8369 8370 8371 8372 8373 8374 8375 8376 8377 8378 8379 8380 8381 8382 8383 8384 8385 8386 8387 8388 8389 8390 8391 8392 8393 8394 8395 8396 8397 8398 8399 8400 8401 8402 8403 8404 8405 8406 8407 8408 8409 8410 8411 8412 8413 8414 8415 8416 8417 8418 8419 8420 8421 8422 8423 8424 8425 8426 8427 8428 8429 8430 8431 8432 8433 8434 8435 8436 8437 8438 8439 8440 8441 8442 8443 8444 8445 8446 8447 8448 8449 8450 8451 8452 8453 8454 8455 8456 8457 8458 8459 8460 8461 8462 8463 8464 8465 8466 8467 8468 8469 8470 8471 8472 8473 8474 8475 8476 8477 8478 8479 8480 8481 8482 8483 8484 8485 8486 8487 8488 8489 8490 8491 8492 8493 8494 8495 8496 8497 8498 8499 8500 8501 8502 8503 8504 8505 8506 8507 8508 8509 8510 8511 8512 8513 8514 8515 8516 8517 8518 8519 8520 8521 8522 8523 8524 8525 8526 8527 8528 8529 8530 8531 8532 8533 8534 8535 8536 8537 8538 8539 8540 8541 8542 8543 8544 8545 8546 8547 8548 8549 8550 8551 8552 8553 8554 8555 8556 8557 8558 8559 8560 8561 8562 8563 8564 8565 8566 8567 8568 8569 8570 8571 8572 8573 8574 8575 8576 8577 8578 8579 8580 8581 8582 8583 8584 8585 8586 8587 8588 8589 8590 8591 8592 8593 8594 8595 8596 8597 8598 8599 8600 8601 8602 8603 8604 8605 8606 8607 8608 8609 8610 8611 8612 8613 8614 8615 8616 8617 8618 8619 8620 8621 8622 8623 8624 8625 8626 8627 8628 8629 8630 8631 8632 8633 8634 8635 8636 8637 8638 8639 8640 8641 8642 8643 8644 8645 8646 8647 8648 8649 8650 8651 8652 8653 8654 8655 8656 8657 8658 8659 8660 8661 8662 8663 8664 8665 8666 8667 8668 8669 8670 8671 8672 8673 8674 8675 8676 8677 8678 8679 8680 8681 8682 8683 8684 8685 8686 8687 8688 8689 8690 8691 8692 8693 8694 8695 8696 8697 8698 8699 8700 8701 8702 8703 8704 8705 8706 8707 8708 8709 8710 8711 8712 8713 8714 8715 8716 8717 8718 8719 8720 8721 8722 8723 8724 8725 8726 8727 8728 8729 8730 8731 8732 8733 8734 8735 8736 8737 8738 8739 8740 8741 8742 8743 8744 8745 8746 8747 8748 8749 8750 8751 8752 8753 8754 8755 8756 8757 8758 8759 8760 8761 8762 8763 8764 8765 8766 8767 8768 8769 8770 8771 8772 8773 8774 8775 8776 8777 8778 8779 8780 8781 8782 8783 8784 8785 8786 8787 8788 8789 8790 8791 8792 8793 8794 8795 8796 8797 8798 8799 8800 8801 8802 8803 8804 8805 8806 8807 8808 8809 8810 8811 8812 8813 8814 8815 8816 8817 8818 8819 8820 8821 8822 8823 8824 8825 8826 8827 8828 8829 8830 8831 8832 8833 8834 8835 8836 8837 8838 8839 8840 8841 8842 8843 8844 8845 8846 8847 8848 8849 8850 8851 8852 8853 8854 8855 8856 8857 8858 8859 8860 8861 8862 8863 8864 8865 8866 8867 8868 8869 8870 8871 8872 8873 8874 8875 8876 8877 8878 8879 8880 8881 8882 8883 8884 8885 8886 8887 8888 8889 8890 8891 8892 8893 8894 8895 8896 8897 8898 8899 8900 8901 8902 8903 8904 8905 8906 8907 8908 8909 8910 8911 8912 8913 8914 8915 8916 8917 8918 8919 8920 8921 8922 8923 8924 8925 8926 8927 8928 8929 8930 8931 8932 8933 8934 8935 8936 8937 8938 8939 8940 8941 8942 8943 8944 8945 8946 8947 8948 8949 8950 8951 8952 8953 8954 8955 8956 8957 8958 8959 8960 8961 8962 8963 8964 8965 8966 8967 8968 8969 8970 8971 8972 8973 8974 8975 8976 8977 8978 8979 8980 8981 8982 8983 8984 8985 8986 8987 8988 8989 8990 8991 8992 8993 8994 8995 8996 8997 8998 8999 9000 9001 9002 9003 9004 9005 9006 9007 9008 9009 9010 9011 9012 9013 9014 9015 9016 9017 9018 9019 9020 9021 9022 9023 9024 9025 9026 9027 9028 9029 9030 9031 9032 9033 9034 9035 9036 9037 9038 9039 9040 9041 9042 9043 9044 9045 9046 9047 9048 9049 9050 9051 9052 9053 9054 9055 9056 9057 9058 9059 9060 9061 9062 9063 9064 9065 9066 9067 9068 9069 9070 9071 9072 9073 9074 9075 9076 9077 9078 9079 9080 9081 9082 9083 9084 9085 9086 9087 9088 9089 9090 9091 9092 9093 9094 9095 9096 9097 9098 9099 9100 9101 9102 9103 9104 9105 9106 9107 9108 9109 9110 9111 9112 9113 9114 9115 9116 9117 9118 9119 9120 9121 9122 9123 9124 9125 9126 9127 9128 9129 9130 9131 9132 9133 9134 9135 9136 9137 9138 9139 9140 9141 9142 9143 9144 9145 9146 9147 9148 9149 9150 9151 9152 9153 9154 9155 9156 9157 9158 9159 9160 9161 9162 9163 9164 9165 9166 9167 9168 9169 9170 9171 9172 9173 9174 9175 9176 9177 9178 9179 9180 9181 9182 9183 9184 9185 9186 9187 9188 9189 9190 9191 9192 9193 9194 9195 9196 9197 9198 9199 9200 9201 9202 9203 9204 9205 9206 9207 9208 9209 9210 9211 9212 9213 9214 9215 9216 9217 9218 9219 9220 9221 9222 9223 9224 9225 9226 9227 9228 9229 9230 9231 9232 9233 9234 9235 9236 9237 9238 9239 9240 9241 9242 9243 9244 9245 9246 9247 9248 9249 9250 9251 9252 9253 9254 9255 9256 9257 9258 9259 9260 9261 9262 9263 9264 9265 9266 9267 9268 9269 9270 9271 9272 9273 9274 9275 9276 9277 9278 9279 9280 9281 9282 9283 9284 9285 9286 9287 9288 9289 9290 9291 9292 9293 9294 9295 9296 9297 9298 9299 9300 9301 9302 9303 9304 9305 9306 9307 9308 9309 9310 9311 9312 9313 9314 9315 9316 9317 9318 9319 9320 9321 9322 9323 9324 9325 9326 9327 9328 9329 9330 9331 9332 9333 9334 9335 9336 9337 9338 9339 9340 9341 9342 9343 9344 9345 9346 9347 9348 9349 9350 9351 9352 9353 9354 9355 9356 9357 9358 9359 9360 9361 9362 9363 9364 9365 9366 9367 9368 9369 9370 9371 9372 9373 9374 9375 9376 9377 9378 9379 9380 9381 9382 9383 9384 9385 9386 9387 9388 9389 9390 9391 9392 9393 9394 9395 9396 9397 9398 9399 9400 9401 9402 9403 9404 9405 9406 9407 9408 9409 9410 9411 9412 9413 9414 9415 9416 9417 9418 9419 9420 9421 9422 9423 9424 9425 9426 9427 9428 9429 9430 9431 9432 9433 9434 9435 9436 9437 9438 9439 9440 9441 9442 9443 9444 9445 9446 9447 9448 9449 9450 9451 9452 9453 9454 9455 9456 9457 9458 9459 9460 9461 9462 9463 9464 9465 9466 9467 9468 9469 9470 9471 9472 9473 9474 9475 9476 9477 9478 9479 9480 9481 9482 9483 9484 9485 9486 9487 9488 9489 9490 9491 9492 9493 9494 9495 9496 9497 9498 9499 9500 9501 9502 9503 9504 9505 9506 9507 9508 9509 9510 9511 9512 9513 9514 9515 9516 9517 9518 9519 9520 9521 9522 9523 9524 9525 9526 9527 9528 9529 9530 9531 9532 9533 9534 9535 9536 9537 9538 9539 9540 9541 9542 9543 9544 9545 9546 9547 9548 9549 9550 9551 9552 9553 9554 9555 9556 9557 9558 9559 9560 9561 9562 9563 9564 9565 9566 9567 9568 9569 9570 9571 9572 9573 9574 9575 9576 9577 9578 9579 9580 9581 9582 9583 9584 9585 9586 9587 9588 9589 9590 9591 9592 9593 9594 9595 9596 9597 9598 9599 9600 9601 9602 9603 9604 9605 9606 9607 9608 9609 9610 9611 9612 9613 9614 9615 9616 9617 9618 9619 9620 9621 9622 9623 9624 9625 9626 9627 9628 9629 9630 9631 9632 9633 9634 9635 9636 9637 9638 9639 9640 9641 9642 9643 9644 9645 9646 9647 9648 9649 9650 9651 9652 9653 9654 9655 9656 9657 9658 9659 9660 9661 9662 9663 9664 9665 9666 9667 9668 9669 9670 9671 9672 9673 9674 9675 9676 9677 9678 9679 9680 9681 9682 9683 9684 9685 9686 9687 9688 9689 9690 9691 9692 9693 9694 9695 9696 9697 9698 9699 9700 9701 9702 9703 9704 9705 9706 9707 9708 9709 9710 9711 9712 9713 9714 9715 9716 9717 9718 9719 9720 9721 9722 9723 9724 9725 9726 9727 9728 9729 9730 9731 9732 9733 9734 9735 9736 9737 9738 9739 9740 9741 9742 9743 9744 9745 9746 9747 9748 9749 9750 9751 9752 9753 9754 9755 9756 9757 9758 9759 9760 9761 9762 9763 9764 9765 9766 9767 9768 9769 9770 9771 9772 9773 9774 9775 9776 9777 9778 9779 9780 9781 9782 9783 9784 9785 9786 9787 9788 9789 9790 9791 9792 9793 9794 9795 9796 9797 9798 9799 9800 9801 9802 9803 9804 9805 9806 9807 9808 9809 9810 9811 9812 9813 9814 9815 9816 9817 9818 9819 9820 9821 9822 9823 9824 9825 9826 9827 9828 9829 9830 9831 9832 9833 9834 9835 9836 9837 9838 9839 9840 9841 9842 9843 9844 9845 9846 9847 9848 9849 9850 9851 9852 9853 9854 9855 9856 9857 9858 9859 9860 9861 9862 9863 9864 9865 9866 9867 9868 9869 9870 9871 9872 9873 9874 9875 9876 9877 9878 9879 9880 9881 9882 9883 9884 9885 9886 9887 9888 9889 9890 9891 9892 9893 9894 9895 9896 9897 9898 9899 9900 9901 9902 9903 9904 9905 9906 9907 9908 9909 9910 9911 9912 9913 9914 9915 9916 9917 9918 9919 9920 9921 9922 9923 9924 9925 9926 9927 9928 9929 9930 9931 9932 9933 9934 9935 9936 9937 9938 9939 9940 9941 9942 9943 9944 9945 9946 9947 9948 9949 9950 9951 9952 9953 9954 9955 9956 9957 9958 9959 9960 9961 9962 9963 9964 9965 9966 9967 9968 9969 9970 9971 9972 9973 9974 9975 9976 9977 9978 9979 9980 9981 9982 9983 9984 9985 9986 9987 9988 9989 9990 9991 9992 9993 9994 9995 9996 9997 9998 9999 10000 10001 10002 10003 10004 10005 10006 10007 10008 10009 10010 10011 10012 10013 10014 10015 10016 10017 10018 10019 10020 10021 10022 10023 10024 10025 10026 10027 10028 10029 10030 10031 10032 10033 10034 10035 10036 10037 10038 10039 10040 10041 10042 10043 10044 10045 10046 10047 10048 10049 10050 10051 10052 10053 10054 10055 10056 10057 10058 10059 10060 10061 10062 10063 10064 10065 10066 10067 10068 10069 10070 10071 10072 10073 10074 10075 10076 10077 10078 10079 10080 10081 10082 10083 10084 10085 10086 10087 10088 10089 10090 10091 10092 10093 10094 10095 10096 10097 10098 10099 10100 10101 10102 10103 10104 10105 10106 10107 10108 10109 10110 10111 10112 10113 10114 10115 10116 10117 10118 10119 10120 10121 10122 10123 10124 10125 10126 10127 10128 10129 10130 10131 10132 10133 10134 10135 10136 10137 10138 10139 10140 10141 10142 10143 10144 10145 10146 10147 10148 10149 10150 10151 10152 10153 10154 10155 10156 10157 10158 10159 10160 10161 10162 10163 10164 10165 10166 10167 10168 10169 10170 10171 10172 10173 10174 10175 10176 10177 10178 10179 10180 10181 10182 10183 10184 10185 10186 10187 10188 10189 10190 10191 10192 10193 10194 10195 10196 10197 10198 10199 10200 10201 10202 10203 10204 10205 10206 10207 10208 10209 10210 10211 10212 10213 10214 10215 10216 10217 10218 10219 10220 10221 10222 10223 10224 10225 10226 10227 10228 10229 10230 10231 10232 10233 10234 10235 10236 10237 10238 10239 10240 10241 10242 10243 10244 10245 10246 10247 10248 10249 10250 10251 10252 10253 10254 10255 10256 10257 10258 10259 10260 10261 10262 10263 10264 10265 10266 10267 10268 10269 10270 10271 10272 10273 10274 10275 10276 10277 10278 10279 10280 10281 10282 10283 10284 10285 10286 10287 10288 10289 10290 10291 10292 10293 10294 10295 10296 10297 10298 10299 10300 10301 10302 10303 10304 10305 10306 10307 10308 10309 10310 10311 10312 10313 10314 10315 10316 10317 10318 10319 10320 10321 10322 10323 10324 10325 10326 10327 10328 10329 10330 10331 10332 10333 10334 10335 10336 10337 10338 10339 10340 10341 10342 10343 10344 10345 10346 10347 10348 10349 10350 10351 10352 10353 10354 10355 10356 10357 10358 10359 10360 10361 10362 10363 10364 10365 10366 10367 10368 10369 10370 10371 10372 10373 10374 10375 10376 10377 10378 10379 10380 10381 10382 10383 10384 10385 10386 10387 10388 10389 10390 10391 10392 10393 10394 10395 10396 10397 10398 10399 10400 10401 10402 10403 10404 10405 10406 10407 10408 10409 10410 10411 10412 10413 10414 10415 10416 10417 10418 10419 10420 10421 10422 10423 10424 10425 10426 10427 10428 10429 10430 10431 10432 10433 10434 10435 10436 10437 10438 10439 10440 10441 10442 10443 10444 10445 10446 10447 10448 10449 10450 10451 10452 10453 10454 10455 10456 10457 10458 10459 10460 10461 10462 10463 10464 10465 10466 10467 10468 10469 10470 10471 10472 10473 10474 10475 10476 10477 10478 10479 10480 10481 10482 10483 10484 10485 10486 10487 10488 10489 10490 10491 10492 10493 10494 10495 10496 10497 10498 10499 10500 10501 10502 10503 10504 10505 10506 10507 10508 10509 10510 10511 10512 10513 10514 10515 10516 10517 10518 10519 10520 10521 10522 10523 10524 10525 10526 10527 10528 10529 10530 10531 10532 10533 10534 10535 10536 10537 10538 10539 10540 10541 10542 10543 10544 10545 10546 10547 10548 10549 10550 10551 10552 10553 10554 10555 10556 10557 10558 10559 10560 10561 10562 10563 10564 10565 10566 10567 10568 10569 10570 10571 10572 10573 10574 10575 10576 10577 10578 10579 10580 10581 10582 10583 10584 10585 10586 10587 10588 10589 10590 10591 10592 10593 10594 10595 10596 10597 10598 10599 10600 10601 10602 10603 10604 10605 10606 10607 10608 10609 10610 10611 10612 10613 10614 10615 10616 10617 10618 10619 10620 10621 10622 10623 10624 10625 10626 10627 10628 10629 10630 10631 10632 10633 10634 10635 10636 10637 10638 10639 10640 10641 10642 10643 10644 10645 10646 10647 10648 10649 10650 10651 10652 10653 10654 10655 10656 10657 10658 10659 10660 10661 10662 10663 10664 10665 10666 10667 10668 10669 10670 10671 10672 10673 10674 10675 10676 10677 10678 10679 10680 10681 10682 10683 10684 10685 10686 10687 10688 10689 10690 10691 10692 10693 10694 10695 10696 10697 10698 10699 10700 10701 10702 10703 10704 10705 10706 10707 10708 10709 10710 10711 10712 10713 10714 10715 10716 10717 10718 10719 10720 10721 10722 10723 10724 10725 10726 10727 10728 10729 10730 10731 10732 10733 10734 10735 10736 10737 10738 10739 10740 10741 10742 10743 10744 10745 10746 10747 10748 10749 10750 10751 10752 10753 10754 10755 10756 10757 10758 10759 10760 10761 10762 10763 10764 10765 10766 10767 10768 10769 10770 10771 10772 10773 10774 10775 10776 10777 10778 10779 10780 10781 10782 10783 10784 10785 10786 10787 10788 10789 10790 10791 10792 10793 10794 10795 10796 10797 10798 10799 10800 10801 10802 10803 10804 10805 10806 10807 10808 10809 10810 10811 10812 10813 10814 10815 10816 10817 10818 10819 10820 10821 10822 10823 10824 10825 10826 10827 10828 10829 10830 10831 10832 10833 10834 10835 10836 10837 10838 10839 10840 10841 10842 10843 10844 10845 10846 10847 10848 10849 10850 10851 10852 10853 10854 10855 10856 10857 10858 10859 10860 10861 10862 10863 10864 10865 10866 10867 10868 10869 10870 10871 10872 10873 10874 10875 10876 10877 10878 10879 10880 10881 10882 10883 10884 10885 10886 10887 10888 10889 10890 10891 10892 10893 10894 10895 10896 10897 10898 10899 10900 10901 10902 10903 10904 10905 10906 10907 10908 10909 10910 10911 10912 10913 10914 10915 10916 10917 10918 10919 10920 10921 10922 10923 10924 10925 10926 10927 10928 10929 10930 10931 10932 10933 10934 10935 10936 10937 10938 10939 10940 10941 10942 10943 10944 10945 10946 10947 10948 10949 10950 10951 10952 10953 10954 10955 10956 10957 10958 10959 10960 10961 10962 10963 10964 10965 10966 10967 10968 10969 10970 10971 10972 10973 10974 10975 10976 10977 10978 10979 10980 10981 10982 10983 10984 10985 10986 10987 10988 10989 10990 10991 10992 10993 10994 10995 10996 10997 10998 10999 11000 11001 11002 11003 11004 11005 11006 11007 11008 11009 11010 11011 11012 11013 11014 11015 11016 11017 11018 11019 11020 11021 11022 11023 11024 11025 11026 11027 11028 11029 11030 11031 11032 11033 11034 11035 11036 11037 11038 11039 11040 11041 11042 11043 11044 11045 11046 11047 11048 11049 11050 11051 11052 11053 11054 11055 11056 11057 11058 11059 11060 11061 11062 11063 11064 11065 11066 11067 11068 11069 11070 11071 11072 11073 11074 11075 11076 11077 11078 11079 11080 11081 11082 11083 11084 11085 11086 11087 11088 11089 11090 11091 11092 11093 11094 11095 11096 11097 11098 11099 11100 11101 11102 11103 11104 11105 11106 11107 11108 11109 11110 11111 11112 11113 11114 11115 11116 11117 11118 11119 11120 11121 11122 11123 11124 11125 11126 11127 11128 11129 11130 11131 11132 11133 11134 11135 11136 11137 11138 11139 11140 11141 11142 11143 11144 11145 11146 11147 11148 11149 11150 11151 11152 11153 11154 11155 11156 11157 11158 11159 11160 11161 11162 11163 11164 11165 11166 11167 11168 11169 11170 11171 11172 11173 11174 11175 11176 11177 11178 11179 11180 11181 11182 11183 11184 11185 11186 11187 11188 11189 11190 11191 11192 11193 11194 11195 11196 11197 11198 11199 11200 11201 11202 11203 11204 11205 11206 11207 11208 11209 11210 11211 11212 11213 11214 11215 11216 11217 11218 11219 11220 11221 11222 11223 11224 11225 11226 11227 11228 11229 11230 11231 11232 11233 11234 11235 11236 11237 11238 11239 11240 11241 11242 11243 11244 11245 11246 11247 11248 11249 11250 11251 11252 11253 11254 11255 11256 11257 11258 11259 11260 11261 11262 11263 11264 11265 11266 11267 11268 11269 11270 11271 11272 11273 11274 11275 11276 11277 11278 11279 11280 11281 11282 11283 11284 11285 11286 11287 11288 11289 11290 11291 11292 11293 11294 11295 11296 11297 11298 11299 11300 11301 11302 11303 11304 11305 11306 11307 11308 11309 11310 11311 11312 11313 11314 11315 11316 11317 11318 11319 11320 11321 11322 11323 11324 11325 11326 11327 11328 11329 11330 11331 11332 11333 11334 11335 11336 11337 11338 11339 11340 11341 11342 11343 11344 11345 11346 11347 11348 11349 11350 11351 11352 11353 11354 11355 11356 11357 11358 11359 11360 11361 11362 11363 11364 11365 11366 11367 11368 11369 11370 11371 11372 11373 11374 11375 11376 11377 11378 11379 11380 11381 11382 11383 11384 11385 11386 11387 11388 11389 11390 11391 11392 11393 11394 11395 11396 11397 11398 11399 11400 11401 11402 11403 11404 11405 11406 11407 11408 11409 11410 11411 11412 11413 11414 11415 11416 11417 11418 11419 11420 11421 11422 11423 11424 11425 11426 11427 11428 11429 11430 11431 11432 11433 11434 11435 11436 11437 11438 11439 11440 11441 11442 11443 11444 11445 11446 11447 11448 11449 11450 11451 11452 11453 11454 11455 11456 11457 11458 11459 11460 11461 11462 11463 11464 11465 11466 11467 11468 11469 11470 11471 11472 11473 11474 11475 11476 11477 11478 11479 11480 11481 11482 11483 11484 11485 11486 11487 11488 11489 11490 11491 11492 11493 11494 11495 11496 11497 11498 11499 11500 11501 11502 11503 11504 11505 11506 11507 11508 11509 11510 11511 11512 11513 11514 11515 11516 11517 11518 11519 11520 11521 11522 11523 11524 11525 11526 11527 11528 11529 11530 11531 11532 11533 11534 11535 11536 11537 11538 11539 11540 11541 11542 11543 11544 11545 11546 11547 11548 11549 11550 11551 11552 11553 11554 11555 11556 11557 11558 11559 11560 11561 11562 11563 11564 11565 11566 11567 11568 11569 11570 11571 11572 11573 11574 11575 11576 11577 11578 11579 11580 11581 11582 11583 11584 11585 11586 11587 11588 11589 11590 11591 11592 11593 11594 11595 11596 11597 11598 11599 11600 11601 11602 11603 11604 11605 11606 11607 11608 11609 11610 11611 11612 11613 11614 11615 11616 11617 11618 11619 11620 11621 11622 11623 11624 11625 11626 11627 11628 11629 11630 11631 11632 11633 11634 11635 11636 11637 11638 11639 11640 11641 11642 11643 11644 11645 11646 11647 11648 11649 11650 11651 11652 11653 11654 11655 11656 11657 11658 11659 11660 11661 11662 11663 11664 11665 11666 11667 11668 11669 11670 11671 11672 11673 11674 11675 11676 11677 11678 11679 11680 11681 11682 11683 11684 11685 11686 11687 11688 11689 11690 11691 11692 11693 11694 11695 11696 11697 11698 11699 11700 11701 11702 11703 11704 11705 11706 11707 11708 11709 11710 11711 11712 11713 11714 11715 11716 11717 11718 11719 11720 11721 11722 11723 11724 11725 11726 11727 11728 11729 11730 11731 11732 11733 11734 11735 11736 11737 11738 11739 11740 11741 11742 11743 11744 11745 11746 11747 11748 11749 11750 11751 11752 11753 11754 11755 11756 11757 11758 11759 11760 11761 11762 11763 11764 11765 11766 11767 11768 11769 11770 11771 11772 11773 11774 11775 11776 11777 11778 11779 11780 11781 11782 11783 11784 11785 11786 11787 11788 11789 11790 11791 11792 11793 11794 11795 11796 11797 11798 11799 11800 11801 11802 11803 11804 11805 11806 11807 11808 11809 11810 11811 11812 11813 11814 11815 11816 11817 11818 11819 11820 11821 11822 11823 11824 11825 11826 11827 11828 11829 11830 11831 11832 11833 11834 11835 11836 11837 11838 11839 11840 11841 11842 11843 11844 11845 11846 11847 11848 11849 11850 11851 11852 11853 11854 11855 11856 11857 11858 11859 11860 11861 11862 11863 11864 11865 11866 11867 11868 11869 11870 11871 11872 11873 11874 11875 11876 11877 11878 11879 11880 11881 11882 11883 11884 11885 11886 11887 11888 11889 11890 11891 11892 11893 11894 11895 11896 11897 11898 11899 11900 11901 11902 11903 11904 11905 11906 11907 11908 11909 11910 11911 11912 11913 11914 11915 11916 11917 11918 11919 11920 11921 11922 11923 11924 11925 11926 11927 11928 11929 11930 11931 11932 11933 11934 11935 11936 11937 11938 11939 11940 11941 11942 11943 11944 11945 11946 11947 11948 11949 11950 11951 11952 11953 11954 11955 11956 11957 11958 11959 11960 11961 11962 11963 11964 11965 11966 11967 11968 11969 11970 11971 11972 11973 11974 11975 11976 11977 11978 11979 11980 11981 11982 11983 11984 11985 11986 11987 11988 11989 11990 11991 11992 11993 11994 11995 11996 11997 11998 11999 12000 12001 12002 12003 12004 12005 12006 12007 12008 12009 12010 12011 12012 12013 12014 12015 12016 12017 12018 12019 12020 12021 12022 12023 12024 12025 12026 12027 12028 12029 12030 12031 12032 12033 12034 12035 12036 12037 12038 12039 12040 12041 12042 12043 12044 12045 12046 12047 12048 12049 12050 12051 12052 12053 12054 12055 12056 12057 12058 12059 12060 12061 12062 12063 12064 12065 12066 12067 12068 12069 12070 12071 12072 12073 12074 12075 12076 12077 12078 12079 12080 12081 12082 12083 12084 12085 12086 12087 12088 12089 12090 12091 12092 12093 12094 12095 12096 12097 12098 12099 12100 12101 12102 12103 12104 12105 12106 12107 12108 12109 12110 12111 12112 12113 12114 12115 12116 12117 12118 12119 12120 12121 12122 12123 12124 12125 12126 12127 12128 12129 12130 12131 12132 12133 12134 12135 12136 12137 12138 12139 12140 12141 12142 12143 12144 12145 12146 12147 12148 12149 12150 12151 12152 12153 12154 12155 12156 12157 12158 12159 12160 12161 12162 12163 12164 12165 12166 12167 12168 12169 12170 12171 12172 12173 12174 12175 12176 12177 12178 12179 12180 12181 12182 12183 12184 12185 12186 12187 12188 12189 12190 12191 12192 12193 12194 12195 12196 12197 12198 12199 12200 12201 12202 12203 12204 12205 12206 12207 12208 12209 12210 12211 12212 12213 12214 12215 12216 12217 12218 12219 12220 12221 12222 12223 12224 12225 12226 12227 12228 12229 12230 12231 12232 12233 12234 12235 12236 12237 12238 12239 12240 12241 12242 12243 12244 12245 12246 12247 12248 12249 12250 12251 12252 12253 12254 12255 12256 12257 12258 12259 12260 12261 12262 12263 12264 12265 12266 12267 12268 12269 12270 12271 12272 12273 12274 12275 12276 12277 12278 12279 12280 12281 12282 12283 12284 12285 12286 12287 12288 12289 12290 12291 12292 12293 12294 12295 12296 12297 12298 12299 12300 12301 12302 12303 12304 12305 12306 12307 12308 12309 12310 12311 12312 12313 12314 12315 12316 12317 12318 12319 12320 12321 12322 12323 12324 12325 12326 12327 12328 12329 12330 12331 12332 12333 12334 12335 12336 12337 12338 12339 12340 12341 12342 12343 12344 12345 12346 12347 12348 12349 12350 12351 12352 12353 12354 12355 12356 12357 12358 12359 12360 12361 12362 12363 12364 12365 12366 12367 12368 12369 12370 12371 12372 12373 12374 12375 12376 12377 12378 12379 12380 12381 12382 12383 12384 12385 12386 12387 12388 12389 12390 12391 12392 12393 12394 12395 12396 12397 12398 12399 12400 12401 12402 12403 12404 12405 12406 12407 12408 12409 12410 12411 12412 12413 12414 12415 12416 12417 12418 12419 12420 12421 12422 12423 12424 12425 12426 12427 12428 12429 12430 12431 12432 12433 12434 12435 12436 12437 12438 12439 12440 12441 12442 12443 12444 12445 12446 12447 12448 12449 12450 12451 12452 12453 12454 12455 12456 12457 12458 12459 12460 12461 12462 12463 12464 12465 12466 12467 12468 12469 12470 12471 12472 12473 12474 12475 12476 12477 12478 12479 12480 12481 12482 12483 12484 12485 12486 12487 12488 12489 12490 12491 12492 12493 12494 12495 12496 12497 12498 12499 12500 12501 12502 12503 12504 12505 12506 12507 12508 12509 12510 12511 12512 12513 12514 12515 12516 12517 12518 12519 12520 12521 12522 12523 12524 12525 12526 12527 12528 12529 12530 12531 12532 12533 12534 12535 12536 12537 12538 12539 12540 12541 12542 12543 12544 12545 12546 12547 12548 12549 12550 12551 12552 12553 12554 12555 12556 12557 12558 12559 12560 12561 12562 12563 12564 12565 12566 12567 12568 12569 12570 12571 12572 12573 12574 12575 12576 12577 12578 12579 12580 12581 12582 12583 12584 12585 12586 12587 12588 12589 12590 12591 12592 12593 12594 12595 12596 12597 12598 12599 12600 12601 12602 12603 12604 12605 12606 12607 12608 12609 12610 12611 12612 12613 12614 12615 12616 12617 12618 12619 12620 12621 12622 12623 12624 12625 12626 12627 12628 12629 12630 12631 12632 12633 12634 12635 12636 12637 12638 12639 12640 12641 12642 12643 12644 12645 12646 12647 12648 12649 12650 12651 12652 12653 12654 12655 12656 12657 12658 12659 12660 12661 12662 12663 12664 12665 12666 12667 12668 12669 12670 12671 12672 12673 12674 12675 12676 12677 12678 12679 12680 12681 12682 12683 12684 12685 12686 12687 12688 12689 12690 12691 12692 12693 12694 12695 12696 12697 12698 12699 12700 12701 12702 12703 12704 12705 12706 12707 12708 12709 12710 12711 12712 12713 12714 12715 12716 12717 12718 12719 12720 12721 12722 12723 12724 12725 12726 12727 12728 12729 12730 12731 12732 12733 12734 12735 12736 12737 12738 12739 12740 12741 12742 12743 12744 12745 12746 12747 12748 12749 12750 12751 12752 12753 12754 12755 12756 12757 12758 12759 12760 12761 12762 12763 12764 12765 12766 12767 12768 12769 12770 12771 12772 12773 12774 12775 12776 12777 12778 12779 12780 12781 12782 12783 12784 12785 12786 12787 12788 12789 12790 12791 12792 12793 12794 12795 12796 12797 12798 12799 12800 12801 12802 12803 12804 12805 12806 12807 12808 12809 12810 12811 12812 12813 12814 12815 12816 12817 12818 12819 12820 12821 12822 12823 12824 12825 12826 12827 12828 12829 12830 12831 12832 12833 12834 12835 12836 12837 12838 12839 12840 12841 12842 12843 12844 12845 12846 12847 12848 12849 12850 12851 12852 12853 12854 12855 12856 12857 12858 12859 12860 12861 12862 12863 12864 12865 12866 12867 12868 12869 12870 12871 12872 12873 12874 12875 12876 12877 12878 12879 12880 12881 12882 12883 12884 12885 12886 12887 12888 12889 12890 12891 12892 12893 12894 12895 12896 12897 12898 12899 12900 12901 12902 12903 12904 12905 12906 12907 12908 12909 12910 12911 12912 12913 12914 12915 12916 12917 12918 12919 12920 12921 12922 12923 12924 12925 12926 12927 12928 12929 12930 12931 12932 12933 12934 12935 12936 12937 12938 12939 12940 12941 12942 12943 12944 12945 12946 12947 12948 12949 12950 12951 12952 12953 12954 12955 12956 12957 12958 12959 12960 12961 12962 12963 12964 12965 12966 12967 12968 12969 12970 12971 12972 12973 12974 12975 12976 12977 12978 12979 12980 12981 12982 12983 12984 12985 12986 12987 12988 12989 12990 12991 12992 12993 12994 12995 12996 12997 12998 12999 13000 13001 13002 13003 13004 13005 13006 13007 13008 13009 13010 13011 13012 13013 13014 13015 13016 13017 13018 13019 13020 13021 13022 13023 13024 13025 13026 13027 13028 13029 13030 13031 13032 13033 13034 13035 13036 13037 13038 13039 13040 13041 13042 13043 13044 13045 13046 13047 13048 13049 13050 13051 13052 13053 13054 13055 13056 13057 13058 13059 13060 13061 13062 13063 13064 13065 13066 13067 13068 13069 13070 13071 13072 13073 13074 13075 13076 13077 13078 13079 13080 13081 13082 13083 13084 13085 13086 13087 13088 13089 13090 13091 13092 13093 13094 13095 13096 13097 13098 13099 13100 13101 13102 13103 13104 13105 13106 13107 13108 13109 13110 13111 13112 13113 13114 13115 13116 13117 13118 13119 13120 13121 13122 13123 13124 13125 13126 13127 13128 13129 13130 13131 13132 13133 13134 13135 13136 13137 13138 13139 13140 13141 13142 13143 13144 13145 13146 13147 13148 13149 13150 13151 13152 13153 13154 13155 13156 13157 13158 13159 13160 13161 13162 13163 13164 13165 13166 13167 13168 13169 13170 13171 13172 13173 13174 13175 13176 13177 13178 13179 13180 13181 13182 13183 13184 13185 13186 13187 13188 13189 13190 13191 13192 13193 13194 13195 13196 13197 13198 13199 13200 13201 13202 13203 13204 13205 13206 13207 13208 13209 13210 13211 13212 13213 13214 13215 13216 13217 13218 13219 13220 13221 13222 13223 13224 13225 13226 13227 13228 13229 13230 13231 13232 13233 13234 13235 13236 13237 13238 13239 13240 13241 13242 13243 13244 13245 13246 13247 13248 13249 13250 13251 13252 13253 13254 13255 13256 13257 13258 13259 13260 13261 13262 13263 13264 13265 13266 13267 13268 13269 13270 13271 13272 13273 13274 13275 13276 13277 13278 13279 13280 13281 13282 13283 13284 13285 13286 13287 13288 13289 13290 13291 13292 13293 13294 13295 13296 13297 13298 13299 13300 13301 13302 13303 13304 13305 13306 13307 13308 13309 13310 13311 13312 13313 13314 13315 13316 13317 13318 13319 13320 13321 13322 13323 13324 13325 13326 13327 13328 13329 13330 13331 13332 13333 13334 13335 13336 13337 13338 13339 13340 13341 13342 13343 13344 13345 13346 13347 13348 13349 13350 13351 13352 13353 13354 13355 13356 13357 13358 13359 13360 13361 13362 13363 13364 13365 13366 13367 13368 13369 13370 13371 13372 13373 13374 13375 13376 13377 13378 13379 13380 13381 13382 13383 13384 13385 13386 13387 13388 13389 13390 13391 13392 13393 13394 13395 13396 13397 13398 13399 13400 13401 13402 13403 13404 13405 13406 13407 13408 13409 13410 13411 13412 13413 13414 13415 13416 13417 13418 13419 13420 13421 13422 13423 13424 13425 13426 13427 13428 13429 13430 13431 13432 13433 13434 13435 13436 13437 13438 13439 13440 13441 13442 13443 13444 13445 13446 13447 13448 13449 13450 13451 13452 13453 13454 13455 13456 13457 13458 13459 13460 13461 13462 13463 13464 13465 13466 13467 13468 13469 13470 13471 13472 13473 13474 13475 13476 13477 13478 13479 13480 13481 13482 13483 13484 13485 13486 13487 13488 13489 13490 13491 13492 13493 13494 13495 13496 13497 13498 13499 13500 13501 13502 13503 13504 13505 13506 13507 13508 13509 13510 13511 13512 13513 13514 13515 13516 13517 13518 13519 13520 13521 13522 13523 13524 13525 13526 13527 13528 13529 13530 13531 13532 13533 13534 13535 13536 13537 13538 13539 13540 13541 13542 13543 13544 13545 13546 13547 13548 13549 13550 13551 13552 13553 13554 13555 13556 13557 13558 13559 13560 13561 13562 13563 13564 13565 13566 13567 13568 13569 13570 13571 13572 13573 13574 13575 13576 13577 13578 13579 13580 13581 13582 13583 13584 13585 13586 13587 13588 13589 13590 13591 13592 13593 13594 13595 13596 13597 13598 13599 13600 13601 13602 13603 13604 13605 13606 13607 13608 13609 13610 13611 13612 13613 13614 13615 13616 13617 13618 13619 13620 13621 13622 13623 13624 13625 13626 13627 13628 13629 13630 13631 13632 13633 13634 13635 13636 13637 13638 13639 13640 13641 13642 13643 13644 13645 13646 13647 13648 13649 13650 13651 13652 13653 13654 13655 13656 13657 13658 13659 13660 13661 13662 13663 13664 13665 13666 13667 13668 13669 13670 13671 13672 13673 13674 13675 13676 13677 13678 13679 13680 13681 13682 13683 13684 13685 13686 13687 13688 13689 13690 13691 13692 13693 13694 13695 13696 13697 13698 13699 13700 13701 13702 13703 13704 13705 13706 13707 13708 13709 13710 13711 13712 13713 13714 13715 13716 13717 13718 13719 13720 13721 13722 13723 13724 13725 13726 13727 13728 13729 13730 13731 13732 13733 13734 13735 13736 13737 13738 13739 13740 13741 13742 13743 13744 13745 13746 13747 13748 13749 13750 13751 13752 13753 13754 13755 13756 13757 13758 13759 13760 13761 13762 13763 13764 13765 13766 13767 13768 13769 13770 13771 13772 13773 13774 13775 13776 13777 13778 13779 13780 13781 13782 13783 13784 13785 13786 13787 13788 13789 13790 13791 13792 13793 13794 13795 13796 13797 13798 13799 13800 13801 13802 13803 13804 13805 13806 13807 13808 13809 13810 13811 13812 13813 13814 13815 13816 13817 13818 13819 13820 13821 13822 13823 13824 13825 13826 13827 13828 13829 13830 13831 13832 13833 13834 13835 13836 13837 13838 13839 13840 13841 13842 13843 13844 13845 13846 13847 13848 13849 13850 13851 13852 13853 13854 13855 13856 13857 13858 13859 13860 13861 13862 13863 13864 13865 13866 13867 13868 13869 13870 13871 13872 13873 13874 13875 13876 13877 13878 13879 13880 13881 13882 13883 13884 13885 13886 13887 13888 13889 13890 13891 13892 13893 13894 13895 13896 13897 13898 13899 13900 13901 13902 13903 13904 13905 13906 13907 13908 13909 13910 13911 13912 13913 13914 13915 13916 13917 13918 13919 13920 13921 13922 13923 13924 13925 13926 13927 13928 13929 13930 13931 13932 13933 13934 13935 13936 13937 13938 13939 13940 13941 13942 13943 13944 13945 13946 13947 13948 13949 13950 13951 13952 13953 13954 13955 13956 13957 13958 13959 13960 13961 13962 13963 13964 13965 13966 13967 13968 13969 13970 13971 13972 13973 13974 13975 13976 13977 13978 13979 13980 13981 13982 13983 13984 13985 13986 13987 13988 13989 13990 13991 13992 13993 13994 13995 13996 13997 13998 13999 14000 14001 14002 14003 14004 14005 14006 14007 14008 14009 14010 14011 14012 14013 14014 14015 14016 14017 14018 14019 14020 14021 14022 14023 14024 14025 14026 14027 14028 14029 14030 14031 14032 14033 14034 14035 14036 14037 14038 14039 14040 14041 14042 14043 14044 14045 14046 14047 14048 14049 14050 14051 14052 14053 14054 14055 14056 14057 14058 14059 14060 14061 14062 14063 14064 14065 14066 14067 14068 14069 14070 14071 14072 14073 14074 14075 14076 14077 14078 14079 14080 14081 14082 14083 14084 14085 14086 14087 14088 14089 14090 14091 14092 14093 14094 14095 14096 14097 14098 14099 14100 14101 14102 14103 14104 14105 14106 14107 14108 14109 14110 14111 14112 14113 14114 14115 14116 14117 14118 14119 14120 14121 14122 14123 14124 14125 14126 14127 14128 14129 14130 14131 14132 14133 14134 14135 14136 14137 14138 14139 14140 14141 14142 14143 14144 14145 14146 14147 14148 14149 14150 14151 14152 14153 14154 14155 14156 14157 14158 14159 14160 14161 14162 14163 14164 14165 14166 14167 14168 14169 14170 14171 14172 14173 14174 14175 14176 14177 14178 14179 14180 14181 14182 14183 14184 14185 14186 14187 14188 14189 14190 14191 14192 14193 14194 14195 14196 14197 14198 14199 14200 14201 14202 14203 14204 14205 14206 14207 14208 14209 14210 14211 14212 14213 14214 14215 14216 14217 14218 14219 14220 14221 14222 14223 14224 14225 14226 14227 14228 14229 14230 14231 14232 14233 14234 14235 14236 14237 14238 14239 14240 14241 14242 14243 14244 14245 14246 14247 14248 14249 14250 14251 14252 14253 14254 14255 14256 14257 14258 14259 14260 14261 14262 14263 14264 14265 14266 14267 14268 14269 14270 14271 14272 14273 14274 14275 14276 14277 14278 14279 14280 14281 14282 14283 14284 14285 14286 14287 14288 14289 14290 14291 14292 14293 14294 14295 14296 14297 14298 14299 14300 14301 14302 14303 14304 14305 14306 14307 14308 14309 14310 14311 14312 14313 14314 14315 14316 14317 14318 14319 14320 14321 14322 14323 14324 14325 14326 14327 14328 14329 14330 14331 14332 14333 14334 14335 14336 14337 14338 14339 14340 14341 14342 14343 14344 14345 14346 14347 14348 14349 14350 14351 14352 14353 14354 14355 14356 14357 14358 14359 14360 14361 14362 14363 14364 14365 14366 14367 14368 14369 14370 14371 14372 14373 14374 14375 14376 14377 14378 14379 14380 14381 14382 14383 14384 14385 14386 14387 14388 14389 14390 14391 14392 14393 14394 14395 14396 14397 14398 14399 14400 14401 14402 14403 14404 14405 14406 14407 14408 14409 14410 14411 14412 14413 14414 14415 14416 14417 14418 14419 14420 14421 14422 14423 14424 14425 14426 14427 14428 14429 14430 14431 14432 14433 14434 14435 14436 14437 14438 14439 14440 14441 14442 14443 14444 14445 14446 14447 14448 14449 14450 14451 14452 14453 14454 14455 14456 14457 14458 14459 14460 14461 14462 14463 14464 14465 14466 14467 14468 14469 14470 14471 14472 14473 14474 14475 14476 14477 14478 14479 14480 14481 14482 14483 14484 14485 14486 14487 14488 14489 14490 14491 14492 14493 14494 14495 14496 14497 14498 14499 14500 14501 14502 14503 14504 14505 14506 14507 14508 14509 14510 14511 14512 14513 14514 14515 14516 14517 14518 14519 14520 14521 14522 14523 14524 14525 14526 14527 14528 14529 14530 14531 14532 14533 14534 14535 14536 14537 14538 14539 14540 14541 14542 14543 14544 14545 14546 14547 14548 14549 14550 14551 14552 14553 14554 14555 14556 14557 14558 14559 14560 14561 14562 14563 14564 14565 14566 14567 14568 14569 14570 14571 14572 14573 14574 14575 14576 14577 14578 14579 14580 14581 14582 14583 14584 14585 14586 14587 14588 14589 14590 14591 14592 14593 14594 14595 14596 14597 14598 14599 14600 14601 14602 14603 14604 14605 14606 14607 14608 14609 14610 14611 14612 14613 14614 14615 14616 14617 14618 14619 14620 14621 14622 14623 14624 14625 14626 14627 14628 14629 14630 14631 14632 14633 14634 14635 14636 14637 14638 14639 14640 14641 14642 14643 14644 14645 14646 14647 14648 14649 14650 14651 14652 14653 14654 14655 14656 14657 14658 14659 14660 14661 14662 14663 14664 14665 14666 14667 14668 14669 14670 14671 14672 14673 14674 14675 14676 14677 14678 14679 14680 14681 14682 14683 14684 14685 14686 14687 14688 14689 14690 14691 14692 14693 14694 14695 14696 14697 14698 14699 14700 14701 14702 14703 14704 14705 14706 14707 14708 14709 14710 14711 14712 14713 14714 14715 14716 14717 14718 14719 14720 14721 14722 14723 14724 14725 14726 14727 14728 14729 14730 14731 14732 14733 14734 14735 14736 14737 14738 14739 14740 14741 14742 14743 14744 14745 14746 14747 14748 14749 14750 14751 14752 14753 14754 14755 14756 14757 14758 14759 14760 14761 14762 14763 14764 14765 14766 14767 14768 14769 14770 14771 14772 14773 14774 14775 14776 14777 14778 14779 14780 14781 14782 14783 14784 14785 14786 14787 14788 14789 14790 14791 14792 14793 14794 14795 14796 14797 14798 14799 14800 14801 14802 14803 14804 14805 14806 14807 14808 14809 14810 14811 14812 14813 14814 14815 14816 14817 14818 14819 14820 14821 14822 14823 14824 14825 14826 14827 14828 14829 14830 14831 14832 14833 14834 14835 14836 14837 14838 14839 14840 14841 14842 14843 14844 14845 14846 14847 14848 14849 14850 14851 14852 14853 14854 14855 14856 14857 14858 14859 14860 14861 14862 14863 14864 14865 14866 14867 14868 14869 14870 14871 14872 14873 14874 14875 14876 14877 14878 14879 14880 14881 14882 14883 14884 14885 14886 14887 14888 14889 14890 14891 14892 14893 14894 14895 14896 14897 14898 14899 14900 14901 14902 14903 14904 14905 14906 14907 14908 14909 14910 14911 14912 14913 14914 14915 14916 14917 14918 14919 14920 14921 14922 14923 14924 14925 14926 14927 14928 14929 14930 14931 14932 14933 14934 14935 14936 14937 14938 14939 14940 14941 14942 14943 14944 14945 14946 14947 14948 14949 14950 14951 14952 14953 14954 14955 14956 14957 14958 14959 14960 14961 14962 14963 14964 14965 14966 14967 14968 14969 14970 14971 14972 14973 14974 14975 14976 14977 14978 14979 14980 14981 14982 14983 14984 14985 14986 14987 14988 14989 14990 14991 14992 14993 14994 14995 14996 14997 14998 14999 15000 15001 15002 15003 15004 15005 15006 15007 15008 15009 15010 15011 15012 15013 15014 15015 15016 15017 15018 15019 15020 15021 15022 15023 15024 15025 15026 15027 15028 15029 15030 15031 15032 15033 15034 15035 15036 15037 15038 15039 15040 15041 15042 15043 15044 15045 15046 15047 15048 15049 15050 15051 15052 15053 15054 15055 15056 15057 15058 15059 15060 15061 15062 15063 15064 15065 15066 15067 15068 15069 15070 15071 15072 15073 15074 15075 15076 15077 15078 15079 15080 15081 15082 15083 15084 15085 15086 15087 15088 15089 15090 15091 15092 15093 15094 15095 15096 15097 15098 15099 15100 15101 15102 15103 15104 15105 15106 15107 15108 15109 15110 15111 15112 15113 15114 15115 15116 15117 15118 15119 15120 15121 15122 15123 15124 15125 15126 15127 15128 15129 15130 15131 15132 15133 15134 15135 15136 15137 15138 15139 15140 15141 15142 15143 15144 15145 15146 15147 15148 15149 15150 15151 15152 15153 15154 15155 15156 15157 15158 15159 15160 15161 15162 15163 15164 15165 15166 15167 15168 15169 15170 15171 15172 15173 15174 15175 15176 15177 15178 15179 15180 15181 15182 15183 15184 15185 15186 15187 15188 15189 15190 15191 15192 15193 15194 15195 15196 15197 15198 15199 15200 15201 15202 15203 15204 15205 15206 15207 15208 15209 15210 15211 15212 15213 15214 15215 15216 15217 15218 15219 15220 15221 15222 15223 15224 15225 15226 15227 15228 15229 15230 15231 15232 15233 15234 15235 15236 15237 15238 15239 15240 15241 15242 15243 15244 15245 15246 15247 15248 15249 15250 15251 15252 15253 15254 15255 15256 15257 15258 15259 15260 15261 15262 15263 15264 15265 15266 15267 15268 15269 15270 15271 15272 15273 15274 15275 15276 15277 15278 15279 15280 15281 15282 15283 15284 15285 15286 15287 15288 15289 15290 15291 15292 15293 15294 15295 15296 15297 15298 15299 15300 15301 15302 15303 15304 15305 15306 15307 15308 15309 15310 15311 15312 15313 15314 15315 15316 15317 15318 15319 15320 15321 15322 15323 15324 15325 15326 15327 15328 15329 15330 15331 15332 15333 15334 15335 15336 15337 15338 15339 15340 15341 15342 15343 15344 15345 15346 15347 15348 15349 15350 15351 15352 15353 15354 15355 15356 15357 15358 15359 15360 15361 15362 15363 15364 15365 15366 15367 15368 15369 15370 15371 15372 15373 15374 15375 15376 15377 15378 15379 15380 15381 15382 15383 15384 15385 15386 15387 15388 15389 15390 15391 15392 15393 15394 15395 15396 15397 15398 15399 15400 15401 15402 15403 15404 15405 15406 15407 15408 15409 15410 15411 15412 15413 15414 15415 15416 15417 15418 15419 15420 15421 15422 15423 15424 15425 15426 15427 15428 15429 15430 15431 15432 15433 15434 15435 15436 15437 15438 15439 15440 15441 15442 15443 15444 15445 15446 15447 15448 15449 15450 15451 15452 15453 15454 15455 15456 15457 15458 15459 15460 15461 15462 15463 15464 15465 15466 15467 15468 15469 15470 15471 15472 15473 15474 15475 15476 15477 15478 15479 15480 15481 15482 15483 15484 15485 15486 15487 15488 15489 15490 15491 15492 15493 15494 15495 15496 15497 15498 15499 15500 15501 15502 15503 15504 15505 15506 15507 15508 15509 15510 15511 15512 15513 15514 15515 15516 15517 15518 15519 15520 15521 15522 15523 15524 15525 15526 15527 15528 15529 15530 15531 15532 15533 15534 15535 15536 15537 15538 15539 15540 15541 15542 15543 15544 15545 15546 15547 15548 15549 15550 15551 15552 15553 15554 15555 15556 15557 15558 15559 15560 15561 15562 15563 15564 15565 15566 15567 15568 15569 15570 15571 15572 15573 15574 15575 15576 15577 15578 15579 15580 15581 15582 15583 15584 15585 15586 15587 15588 15589 15590 15591 15592 15593 15594 15595 15596 15597 15598 15599 15600 15601 15602 15603 15604 15605 15606 15607 15608 15609 15610 15611 15612 15613 15614 15615 15616 15617 15618 15619 15620 15621 15622 15623 15624 15625 15626 15627 15628 15629 15630 15631 15632 15633 15634 15635 15636 15637 15638 15639 15640 15641 15642 15643 15644 15645 15646 15647 15648 15649 15650 15651 15652 15653 15654 15655 15656 15657 15658 15659 15660 15661 15662 15663 15664 15665 15666 15667 15668 15669 15670 15671 15672 15673 15674 15675 15676 15677 15678 15679 15680 15681 15682 15683 15684 15685 15686 15687 15688 15689 15690 15691 15692 15693 15694 15695 15696 15697 15698 15699 15700 15701 15702 15703 15704 15705 15706 15707 15708 15709 15710 15711 15712 15713 15714 15715 15716 15717 15718 15719 15720 15721 15722 15723 15724 15725 15726 15727 15728 15729 15730 15731 15732 15733 15734 15735 15736 15737 15738 15739 15740 15741 15742 15743 15744 15745 15746 15747 15748 15749 15750 15751 15752 15753 15754 15755 15756 15757 15758 15759 15760 15761 15762 15763 15764 15765 15766 15767 15768 15769 15770 15771 15772 15773 15774 15775 15776 15777 15778 15779 15780 15781 15782 15783 15784 15785 15786 15787 15788 15789 15790 15791 15792 15793 15794 15795 15796 15797 15798 15799 15800 15801 15802 15803 15804 15805 15806 15807 15808 15809 15810 15811 15812 15813 15814 15815 15816 15817 15818 15819 15820 15821 15822 15823 15824 15825 15826 15827 15828 15829 15830 15831 15832 15833 15834 15835 15836 15837 15838 15839 15840 15841 15842 15843 15844 15845 15846 15847 15848 15849 15850 15851 15852 15853 15854 15855 15856 15857 15858 15859 15860 15861 15862 15863 15864 15865 15866 15867 15868 15869 15870 15871 15872 15873 15874 15875 15876 15877 15878 15879 15880 15881 15882 15883 15884 15885 15886 15887 15888 15889 15890 15891 15892 15893 15894 15895 15896 15897 15898 15899 15900 15901 15902 15903 15904 15905 15906 15907 15908 15909 15910 15911 15912 15913 15914 15915 15916 15917 15918 15919 15920 15921 15922 15923 15924 15925 15926 15927 15928 15929 15930 15931 15932 15933 15934 15935 15936 15937 15938 15939 15940 15941 15942 15943 15944 15945 15946 15947 15948 15949 15950 15951 15952 15953 15954 15955 15956 15957 15958 15959 15960 15961 15962 15963 15964 15965 15966 15967 15968 15969 15970 15971 15972 15973 15974 15975 15976 15977 15978 15979 15980 15981 15982 15983 15984 15985 15986 15987 15988 15989 15990 15991 15992 15993 15994 15995 15996 15997 15998 15999 16000 16001 16002 16003 16004 16005 16006 16007 16008 16009 16010 16011 16012 16013 16014 16015 16016 16017 16018 16019 16020 16021 16022 16023 16024 16025 16026 16027 16028 16029 16030 16031 16032 16033 16034 16035 16036 16037 16038 16039 16040 16041 16042 16043 16044 16045 16046 16047 16048 16049 16050 16051 16052 16053 16054 16055 16056 16057 16058 16059 16060 16061 16062 16063 16064 16065 16066 16067 16068 16069 16070 16071 16072 16073 16074 16075 16076 16077 16078 16079 16080 16081 16082 16083 16084 16085 16086 16087 16088 16089 16090 16091 16092 16093 16094 16095 16096 16097 16098 16099 16100 16101 16102 16103 16104 16105 16106 16107 16108 16109 16110 16111 16112 16113 16114 16115 16116 16117 16118 16119 16120 16121 16122 16123 16124 16125 16126 16127 16128 16129 16130 16131 16132 16133 16134 16135 16136 16137 16138 16139 16140 16141 16142 16143 16144 16145 16146 16147 16148 16149 16150 16151 16152 16153 16154 16155 16156 16157 16158 16159 16160 16161 16162 16163 16164 16165 16166 16167 16168 16169 16170 16171 16172 16173 16174 16175 16176 16177 16178 16179 16180 16181 16182 16183 16184 16185 16186 16187 16188 16189 16190 16191 16192 16193 16194 16195 16196 16197 16198 16199 16200 16201 16202 16203 16204 16205 16206 16207 16208 16209 16210 16211 16212 16213 16214 16215 16216 16217 16218 16219 16220 16221 16222 16223 16224 16225 16226 16227 16228 16229 16230 16231 16232 16233 16234 16235 16236 16237 16238 16239 16240 16241 16242 16243 16244 16245 16246 16247 16248 16249 16250 16251 16252 16253 16254 16255 16256 16257 16258 16259 16260 16261 16262 16263 16264 16265 16266 16267 16268 16269 16270 16271 16272 16273 16274 16275 16276 16277 16278 16279 16280 16281 16282 16283 16284 16285 16286 16287 16288 16289 16290 16291 16292 16293 16294 16295 16296 16297 16298 16299 16300 16301 16302 16303 16304 16305 16306 16307 16308 16309 16310 16311 16312 16313 16314 16315 16316 16317 16318 16319 16320 16321 16322 16323 16324 16325 16326 16327 16328 16329 16330 16331 16332 16333 16334 16335 16336 16337 16338 16339 16340 16341 16342 16343 16344 16345 16346 16347 16348 16349 16350 16351 16352 16353 16354 16355 16356 16357 16358 16359 16360 16361 16362 16363 16364 16365 16366 16367 16368 16369 16370 16371 16372 16373 16374 16375 16376 16377 16378 16379 16380 16381 16382 16383 16384 16385 16386 16387 16388 16389 16390 16391 16392 16393 16394 16395 16396 16397 16398 16399 16400 16401 16402 16403 16404 16405 16406 16407 16408 16409 16410 16411 16412 16413 16414 16415 16416 16417 16418 16419 16420 16421 16422 16423 16424 16425 16426 16427 16428 16429 16430 16431 16432 16433 16434 16435 16436 16437 16438 16439 16440 16441 16442 16443 16444 16445 16446 16447 16448 16449 16450 16451 16452 16453 16454 16455 16456 16457 16458 16459 16460 16461 16462 16463 16464 16465 16466 16467 16468 16469 16470 16471 16472 16473 16474 16475 16476 16477 16478 16479 16480 16481 16482 16483 16484 16485 16486 16487 16488 16489 16490 16491 16492 16493 16494 16495 16496 16497 16498 16499 16500 16501 16502 16503 16504 16505 16506 16507 16508 16509 16510 16511 16512 16513 16514 16515 16516 16517 16518 16519 16520 16521 16522 16523 16524 16525 16526 16527 16528 16529 16530 16531 16532 16533 16534 16535 16536 16537 16538 16539 16540 16541 16542 16543 16544 16545 16546 16547 16548 16549 16550 16551 16552 16553 16554 16555 16556 16557 16558 16559 16560 16561 16562 16563 16564 16565 16566 16567 16568 16569 16570 16571 16572 16573 16574 16575 16576 16577 16578 16579 16580 16581 16582 16583 16584 16585 16586 16587 16588 16589 16590 16591 16592 16593 16594 16595 16596 16597 16598 16599 16600 16601 16602 16603 16604 16605 16606 16607 16608 16609 16610 16611 16612 16613 16614 16615 16616 16617 16618 16619 16620 16621 16622 16623 16624 16625 16626 16627 16628 16629 16630 16631 16632 16633 16634 16635 16636 16637 16638 16639 16640 16641 16642 16643 16644 16645 16646 16647 16648 16649 16650 16651 16652 16653 16654 16655 16656 16657 16658 16659 16660 16661 16662 16663 16664 16665 16666 16667 16668 16669 16670 16671 16672 16673 16674 16675 16676 16677 16678 16679 16680 16681 16682 16683 16684 16685 16686 16687 16688 16689 16690 16691 16692 16693 16694 16695 16696 16697 16698 16699 16700 16701 16702 16703 16704 16705 16706 16707 16708 16709 16710 16711 16712 16713 16714 16715 16716 16717 16718 16719 16720 16721 16722 16723 16724 16725 16726 16727 16728 16729 16730 16731 16732 16733 16734 16735 16736 16737 16738 16739 16740 16741 16742 16743 16744 16745 16746 16747 16748 16749 16750 16751 16752 16753 16754 16755 16756 16757 16758 16759 16760 16761 16762 16763 16764 16765 16766 16767 16768 16769 16770 16771 16772 16773 16774 16775 16776 16777 16778 16779 16780 16781 16782 16783 16784 16785 16786 16787 16788 16789 16790 16791 16792 16793 16794 16795 16796 16797 16798 16799 16800 16801 16802 16803 16804 16805 16806 16807 16808 16809 16810 16811 16812 16813 16814 16815 16816 16817 16818 16819 16820 16821 16822 16823 16824 16825 16826 16827 16828 16829 16830 16831 16832 16833 16834 16835 16836 16837 16838 16839 16840 16841 16842 16843 16844 16845 16846 16847 16848 16849 16850 16851 16852 16853 16854 16855 16856 16857 16858 16859 16860 16861 16862 16863 16864 16865 16866 16867 16868 16869 16870 16871 16872 16873 16874 16875 16876 16877 16878 16879 16880 16881 16882 16883 16884 16885 16886 16887 16888 16889 16890 16891 16892 16893 16894 16895 16896 16897 16898 16899 16900 16901 16902 16903 16904 16905 16906 16907 16908 16909 16910 16911 16912 16913 16914 16915 16916 16917 16918 16919 16920 16921 16922 16923 16924 16925 16926 16927 16928 16929 16930 16931 16932 16933 16934 16935 16936 16937 16938 16939 16940 16941 16942 16943 16944 16945 16946 16947 16948 16949 16950 16951 16952 16953 16954 16955 16956 16957 16958 16959 16960 16961 16962 16963 16964 16965 16966 16967 16968 16969 16970 16971 16972 16973 16974 16975 16976 16977 16978 16979 16980 16981 16982 16983 16984 16985 16986 16987 16988 16989 16990 16991 16992 16993 16994 16995 16996 16997 16998 16999 17000 17001 17002 17003 17004 17005 17006 17007 17008 17009 17010 17011 17012 17013 17014 17015 17016 17017 17018 17019 17020 17021 17022 17023 17024 17025 17026 17027 17028 17029 17030 17031 17032 17033 17034 17035 17036 17037 17038 17039 17040 17041 17042 17043 17044 17045 17046 17047 17048 17049 17050 17051 17052 17053 17054 17055 17056 17057 17058 17059 17060 17061 17062 17063 17064 17065 17066 17067 17068 17069 17070 17071 17072 17073 17074 17075 17076 17077 17078 17079 17080 17081 17082 17083 17084 17085 17086 17087 17088 17089 17090 17091 17092 17093 17094 17095 17096 17097 17098 17099 17100 17101 17102 17103 17104 17105 17106 17107 17108 17109 17110 17111 17112 17113 17114 17115 17116 17117 17118 17119 17120 17121 17122 17123 17124 17125 17126 17127 17128 17129 17130 17131 17132 17133 17134 17135 17136 17137 17138 17139 17140 17141 17142 17143 17144 17145 17146 17147 17148 17149 17150 17151 17152 17153 17154 17155 17156 17157 17158 17159 17160 17161 17162 17163 17164 17165 17166 17167 17168 17169 17170 17171 17172 17173 17174 17175 17176 17177 17178 17179 17180 17181 17182 17183 17184 17185 17186 17187 17188 17189 17190 17191 17192 17193 17194 17195 17196 17197 17198 17199 17200 17201 17202 17203 17204 17205 17206 17207 17208 17209 17210 17211 17212 17213 17214 17215 17216 17217 17218 17219 17220 17221 17222 17223 17224 17225 17226 17227 17228 17229 17230 17231 17232 17233 17234 17235 17236 17237 17238 17239 17240 17241 17242 17243 17244 17245 17246 17247 17248 17249 17250 17251 17252 17253 17254 17255 17256 17257 17258 17259 17260 17261 17262 17263 17264 17265 17266 17267 17268 17269 17270 17271 17272 17273 17274 17275 17276 17277 17278 17279 17280 17281 17282 17283 17284 17285 17286 17287 17288 17289 17290 17291 17292 17293 17294 17295 17296 17297 17298 17299 17300 17301 17302 17303 17304 17305 17306 17307 17308 17309 17310 17311 17312 17313 17314 17315 17316 17317 17318 17319 17320 17321 17322 17323 17324 17325 17326 17327 17328 17329 17330 17331 17332 17333 17334 17335 17336 17337 17338 17339 17340 17341 17342 17343 17344 17345 17346 17347 17348 17349 17350 17351 17352 17353 17354 17355 17356 17357 17358 17359 17360 17361 17362 17363 17364 17365 17366 17367 17368 17369 17370 17371 17372 17373 17374 17375 17376 17377 17378 17379 17380 17381 17382 17383 17384 17385 17386 17387 17388 17389 17390 17391 17392 17393 17394 17395 17396 17397 17398 17399 17400 17401 17402 17403 17404 17405 17406 17407 17408 17409 17410 17411 17412 17413 17414 17415 17416 17417 17418 17419 17420 17421 17422 17423 17424 17425 17426 17427 17428 17429 17430 17431 17432 17433 17434 17435 17436 17437 17438 17439 17440 17441 17442 17443 17444 17445 17446 17447 17448 17449 17450 17451 17452 17453 17454 17455 17456 17457 17458 17459 17460 17461 17462 17463 17464 17465 17466 17467 17468 17469 17470 17471 17472 17473 17474 17475 17476 17477 17478 17479 17480 17481 17482 17483 17484 17485 17486 17487 17488 17489 17490 17491 17492 17493 17494 17495 17496 17497 17498 17499 17500 17501 17502 17503 17504 17505 17506 17507 17508 17509 17510 17511 17512 17513 17514 17515 17516 17517 17518 17519 17520 17521 17522 17523 17524 17525 17526 17527 17528 17529 17530 17531 17532 17533 17534 17535 17536 17537 17538 17539 17540 17541 17542 17543 17544 17545 17546 17547 17548 17549 17550 17551 17552 17553 17554 17555 17556 17557 17558 17559 17560 17561 17562 17563 17564 17565 17566 17567 17568 17569 17570 17571 17572 17573 17574 17575 17576 17577 17578 17579 17580 17581 17582 17583 17584 17585 17586 17587 17588 17589 17590 17591 17592 17593 17594 17595 17596 17597 17598 17599 17600 17601 17602 17603 17604 17605 17606 17607 17608 17609 17610 17611 17612 17613 17614 17615 17616 17617 17618 17619 17620 17621 17622 17623 17624 17625 17626 17627 17628 17629 17630 17631 17632 17633 17634 17635 17636 17637 17638 17639 17640 17641 17642 17643 17644 17645 17646 17647 17648 17649 17650 17651 17652 17653 17654 17655 17656 17657 17658 17659 17660 17661 17662 17663 17664 17665 17666 17667 17668 17669 17670 17671 17672 17673 17674 17675 17676 17677 17678 17679 17680 17681 17682 17683 17684 17685 17686 17687 17688 17689 17690 17691 17692 17693 17694 17695 17696 17697 17698 17699 17700 17701 17702 17703 17704 17705 17706 17707 17708 17709 17710 17711 17712 17713 17714 17715 17716 17717 17718 17719 17720 17721 17722 17723 17724 17725 17726 17727 17728 17729 17730 17731 17732 17733 17734 17735 17736 17737 17738 17739 17740 17741 17742 17743 17744 17745 17746 17747 17748 17749 17750 17751 17752 17753 17754 17755 17756 17757 17758 17759 17760 17761 17762 17763 17764 17765 17766 17767 17768 17769 17770 17771 17772 17773 17774 17775 17776 17777 17778 17779 17780 17781 17782 17783 17784 17785 17786 17787 17788 17789 17790 17791 17792 17793 17794 17795 17796 17797 17798 17799 17800 17801 17802 17803 17804 17805 17806 17807 17808 17809 17810 17811 17812 17813 17814 17815 17816 17817 17818 17819 17820 17821 17822 17823 17824 17825 17826 17827 17828 17829 17830 17831 17832 17833 17834 17835 17836 17837 17838 17839 17840 17841 17842 17843 17844 17845 17846 17847 17848 17849 17850 17851 17852 17853 17854 17855 17856 17857 17858 17859 17860 17861 17862 17863 17864 17865 17866 17867 17868 17869 17870 17871 17872 17873 17874 17875 17876 17877 17878 17879 17880 17881 17882 17883 17884 17885 17886 17887 17888 17889 17890 17891 17892 17893 17894 17895 17896 17897 17898 17899 17900 17901 17902 17903 17904 17905 17906 17907 17908 17909 17910 17911 17912 17913 17914 17915 17916 17917 17918 17919 17920 17921 17922 17923 17924 17925 17926 17927 17928 17929 17930 17931 17932 17933 17934 17935 17936 17937 17938 17939 17940 17941 17942 17943 17944 17945 17946 17947 17948 17949 17950 17951 17952 17953 17954 17955 17956 17957 17958 17959 17960 17961 17962 17963 17964 17965 17966 17967 17968 17969 17970 17971 17972 17973 17974 17975 17976 17977 17978 17979 17980 17981 17982 17983 17984 17985 17986 17987 17988 17989 17990 17991 17992 17993 17994 17995 17996 17997 17998 17999 18000 18001 18002 18003 18004 18005 18006 18007 18008 18009 18010 18011 18012 18013 18014 18015 18016 18017 18018 18019 18020 18021 18022 18023 18024 18025 18026 18027 18028 18029 18030 18031 18032 18033 18034 18035 18036 18037 18038 18039 18040 18041 18042 18043 18044 18045 18046 18047 18048 18049 18050 18051 18052 18053 18054 18055 18056 18057 18058 18059 18060 18061 18062 18063 18064 18065 18066 18067 18068 18069 18070 18071 18072 18073 18074 18075 18076 18077 18078 18079 18080 18081 18082 18083 18084 18085 18086 18087 18088 18089 18090 18091 18092 18093 18094 18095 18096 18097 18098 18099 18100 18101 18102 18103 18104 18105 18106 18107 18108 18109 18110 18111 18112 18113 18114 18115 18116 18117 18118 18119 18120 18121 18122 18123 18124 18125 18126 18127 18128 18129 18130 18131 18132 18133 18134 18135 18136 18137 18138 18139 18140 18141 18142 18143 18144 18145 18146 18147 18148 18149 18150 18151 18152 18153 18154 18155 18156 18157 18158 18159 18160 18161 18162 18163 18164 18165 18166 18167 18168 18169 18170 18171 18172 18173 18174 18175 18176 18177 18178 18179 18180 18181 18182 18183 18184 18185 18186 18187 18188 18189 18190 18191 18192 18193 18194 18195 18196 18197 18198 18199 18200 18201 18202 18203 18204 18205 18206 18207 18208 18209 18210 18211 18212 18213 18214 18215 18216 18217 18218 18219 18220 18221 18222 18223 18224 18225 18226 18227 18228 18229 18230 18231 18232 18233 18234 18235 18236 18237 18238 18239 18240 18241 18242 18243 18244 18245 18246 18247 18248 18249 18250 18251 18252 18253 18254 18255 18256 18257 18258 18259 18260 18261 18262 18263 18264 18265 18266 18267 18268 18269 18270 18271 18272 18273 18274 18275 18276 18277 18278 18279 18280 18281 18282 18283 18284 18285 18286 18287 18288 18289 18290 18291 18292 18293 18294 18295 18296 18297 18298 18299 18300 18301 18302 18303 18304 18305 18306 18307 18308 18309 18310 18311 18312 18313 18314 18315 18316 18317 18318 18319 18320 18321 18322 18323 18324 18325 18326 18327 18328 18329 18330 18331 18332 18333 18334 18335 18336 18337 18338 18339 18340 18341 18342 18343 18344 18345 18346 18347 18348 18349 18350 18351 18352 18353 18354 18355 18356 18357 18358 18359 18360 18361 18362 18363 18364 18365 18366 18367 18368 18369 18370 18371 18372 18373 18374 18375 18376 18377 18378 18379 18380 18381 18382 18383 18384 18385 18386 18387 18388 18389 18390 18391 18392 18393 18394 18395 18396 18397 18398 18399 18400 18401 18402 18403 18404 18405 18406 18407 18408 18409 18410 18411 18412 18413 18414 18415 18416 18417 18418 18419 18420 18421 18422 18423 18424 18425 18426 18427 18428 18429 18430 18431 18432 18433 18434 18435 18436 18437 18438 18439 18440 18441 18442 18443 18444 18445 18446 18447 18448 18449 18450 18451 18452 18453 18454 18455 18456 18457 18458 18459 18460 18461 18462 18463 18464 18465 18466 18467 18468 18469 18470 18471 18472 18473 18474 18475 18476 18477 18478 18479 18480 18481 18482 18483 18484 18485 18486 18487 18488 18489 18490 18491 18492 18493 18494 18495 18496 18497 18498 18499 18500 18501 18502 18503 18504 18505 18506 18507 18508 18509 18510 18511 18512 18513 18514 18515 18516 18517 18518 18519 18520 18521 18522 18523 18524 18525 18526 18527 18528 18529 18530 18531 18532 18533 18534 18535 18536 18537 18538 18539 18540 18541 18542 18543 18544 18545 18546 18547 18548 18549 18550 18551 18552 18553 18554 18555 18556 18557 18558 18559 18560 18561 18562 18563 18564 18565 18566 18567 18568 18569 18570 18571 18572 18573 18574 18575 18576 18577 18578 18579 18580 18581 18582 18583 18584 18585 18586 18587 18588 18589 18590 18591 18592 18593 18594 18595 18596 18597 18598 18599 18600 18601 18602 18603 18604 18605 18606 18607 18608 18609 18610 18611 18612 18613 18614 18615 18616 18617 18618 18619 18620 18621 18622 18623 18624 18625 18626 18627 18628 18629 18630 18631 18632 18633 18634 18635 18636 18637 18638 18639 18640 18641 18642 18643 18644 18645 18646 18647 18648 18649 18650 18651 18652 18653 18654 18655 18656 18657 18658 18659 18660 18661 18662 18663 18664 18665 18666 18667 18668 18669 18670 18671 18672 18673 18674 18675 18676 18677 18678 18679 18680 18681 18682 18683 18684 18685 18686 18687 18688 18689 18690 18691 18692 18693 18694 18695 18696 18697 18698 18699 18700 18701 18702 18703 18704 18705 18706 18707 18708 18709 18710 18711 18712 18713 18714 18715 18716 18717 18718 18719 18720 18721 18722 18723 18724 18725 18726 18727 18728 18729 18730 18731 18732 18733 18734 18735 18736 18737 18738 18739 18740 18741 18742 18743 18744 18745 18746 18747 18748 18749 18750 18751 18752 18753 18754 18755 18756 18757 18758 18759 18760 18761 18762 18763 18764 18765 18766 18767 18768 18769 18770 18771 18772 18773 18774 18775 18776 18777 18778 18779 18780 18781 18782 18783 18784 18785 18786 18787 18788 18789 18790 18791 18792 18793 18794 18795 18796 18797 18798 18799 18800 18801 18802 18803 18804 18805 18806 18807 18808 18809 18810 18811 18812 18813 18814 18815 18816 18817 18818 18819 18820 18821 18822 18823 18824 18825 18826 18827 18828 18829 18830 18831 18832 18833 18834 18835 18836 18837 18838 18839 18840 18841 18842 18843 18844 18845 18846 18847 18848 18849 18850 18851 18852 18853 18854 18855 18856 18857 18858 18859 18860 18861 18862 18863 18864 18865 18866 18867 18868 18869 18870 18871 18872 18873 18874 18875 18876 18877 18878 18879 18880 18881 18882 18883 18884 18885 18886 18887 18888 18889 18890 18891 18892 18893 18894 18895 18896 18897 18898 18899 18900 18901 18902 18903 18904 18905 18906 18907 18908 18909 18910 18911 18912 18913 18914 18915 18916 18917 18918 18919 18920 18921 18922 18923 18924 18925 18926 18927 18928 18929 18930 18931 18932 18933 18934 18935 18936 18937 18938 18939 18940 18941 18942 18943 18944 18945 18946 18947 18948 18949 18950 18951 18952 18953 18954 18955 18956 18957 18958 18959 18960 18961 18962 18963 18964 18965 18966 18967 18968 18969 18970 18971 18972 18973 18974 18975 18976 18977 18978 18979 18980 18981 18982 18983 18984 18985 18986 18987 18988 18989 18990 18991 18992 18993 18994 18995 18996 18997 18998 18999 19000 19001 19002 19003 19004 19005 19006 19007 19008 19009 19010 19011 19012 19013 19014 19015 19016 19017 19018 19019 19020 19021 19022 19023 19024 19025 19026 19027 19028 19029 19030 19031 19032 19033 19034 19035 19036 19037 19038 19039 19040 19041 19042 19043 19044 19045 19046 19047 19048 19049 19050 19051 19052 19053 19054 19055 19056 19057 19058 19059 19060 19061 19062 19063 19064 19065 19066 19067 19068 19069 19070 19071 19072 19073 19074 19075 19076 19077 19078 19079 19080 19081 19082 19083 19084 19085 19086 19087 19088 19089 19090 19091 19092 19093 19094 19095 19096 19097 19098 19099 19100 19101 19102 19103 19104 19105 19106 19107 19108 19109 19110 19111 19112 19113 19114 19115 19116 19117 19118 19119 19120 19121 19122 19123 19124 19125 19126 19127 19128 19129 19130 19131 19132 19133 19134 19135 19136 19137 19138 19139 19140 19141 19142 19143 19144 19145 19146 19147 19148 19149 19150 19151 19152 19153 19154 19155 19156 19157 19158 19159 19160 19161 19162 19163 19164 19165 19166 19167 19168 19169 19170 19171 19172 19173 19174 19175 19176 19177 19178 19179 19180 19181 19182 19183 19184 19185 19186 19187 19188 19189 19190 19191 19192 19193 19194 19195 19196 19197 19198 19199 19200 19201 19202 19203 19204 19205 19206 19207 19208 19209 19210 19211 19212 19213 19214 19215 19216 19217 19218 19219 19220 19221 19222 19223 19224 19225 19226 19227 19228 19229 19230 19231 19232 19233 19234 19235 19236 19237 19238 19239 19240 19241 19242 19243 19244 19245 19246 19247 19248 19249 19250 19251 19252 19253 19254 19255 19256 19257 19258 19259 19260 19261 19262 19263 19264 19265 19266 19267 19268 19269 19270 19271 19272 19273 19274 19275 19276 19277 19278 19279 19280 19281 19282 19283 19284 19285 19286 19287 19288 19289 19290 19291 19292 19293 19294 19295 19296 19297 19298 19299 19300 19301 19302 19303 19304 19305 19306 19307 19308 19309 19310 19311 19312 19313 19314 19315 19316 19317 19318 19319 19320 19321 19322 19323 19324 19325 19326 19327 19328 19329 19330 19331 19332 19333 19334 19335 19336 19337 19338 19339 19340 19341 19342 19343 19344 19345 19346 19347 19348 19349 19350 19351 19352 19353 19354 19355 19356 19357 19358 19359 19360 19361 19362 19363 19364 19365 19366 19367 19368 19369 19370 19371 19372 19373 19374 19375 19376 19377 19378 19379 19380 19381 19382 19383 19384 19385 19386 19387 19388 19389 19390 19391 19392 19393 19394 19395 19396 19397 19398 19399 19400 19401 19402 19403 19404 19405 19406 19407 19408 19409 19410 19411 19412 19413 19414 19415 19416 19417 19418 19419 19420 19421 19422 19423 19424 19425 19426 19427 19428 19429 19430 19431 19432 19433 19434 19435 19436 19437 19438 19439 19440 19441 19442 19443 19444 19445 19446 19447 19448 19449 19450 19451 19452 19453 19454 19455 19456 19457 19458 19459 19460 19461 19462 19463 19464 19465 19466 19467 19468 19469 19470 19471 19472 19473 19474 19475 19476 19477 19478 19479 19480 19481 19482 19483 19484 19485 19486 19487 19488 19489 19490 19491 19492 19493 19494 19495 19496 19497 19498 19499 19500 19501 19502 19503 19504 19505 19506 19507 19508 19509 19510 19511 19512 19513 19514 19515 19516 19517 19518 19519 19520 19521 19522 19523 19524 19525 19526 19527 19528 19529 19530 19531 19532 19533 19534 19535 19536 19537 19538 19539 19540 19541 19542 19543 19544 19545 19546 19547 19548 19549 19550 19551 19552 19553 19554 19555 19556 19557 19558 19559 19560 19561 19562 19563 19564 19565 19566 19567 19568 19569 19570 19571 19572 19573 19574 19575 19576 19577 19578 19579 19580 19581 19582 19583 19584 19585 19586 19587 19588 19589 19590 19591 19592 19593 19594 19595 19596 19597 19598 19599 19600 19601 19602 19603 19604 19605 19606 19607 19608 19609 19610 19611 19612 19613 19614 19615 19616 19617 19618 19619 19620 19621 19622 19623 19624 19625 19626 19627 19628 19629 19630 19631 19632 19633 19634 19635 19636 19637 19638 19639 19640 19641 19642 19643 19644 19645 19646 19647 19648 19649 19650 19651 19652 19653 19654 19655 19656 19657 19658 19659 19660 19661 19662 19663 19664 19665 19666 19667 19668 19669 19670 19671 19672 19673 19674 19675 19676 19677 19678 19679 19680 19681 19682 19683 19684 19685 19686 19687 19688 19689 19690 19691 19692 19693 19694 19695 19696 19697 19698 19699 19700 19701 19702 19703 19704 19705 19706 19707 19708 19709 19710 19711 19712 19713 19714 19715 19716 19717 19718 19719 19720 19721 19722 19723 19724 19725 19726 19727 19728 19729 19730 19731 19732 19733 19734 19735 19736 19737 19738 19739 19740 19741 19742 19743 19744 19745 19746 19747 19748 19749 19750 19751 19752 19753 19754 19755 19756 19757 19758 19759 19760 19761 19762 19763 19764 19765 19766 19767 19768 19769 19770 19771 19772 19773 19774 19775 19776 19777 19778 19779 19780 19781 19782 19783 19784 19785 19786 19787 19788 19789 19790 19791 19792 19793 19794 19795 19796 19797 19798 19799 19800 19801 19802 19803 19804 19805 19806 19807 19808 19809 19810 19811 19812 19813 19814 19815 19816 19817 19818 19819 19820 19821 19822 19823 19824 19825 19826 19827 19828 19829 19830 19831 19832 19833 19834 19835 19836 19837 19838 19839 19840 19841 19842 19843 19844 19845 19846 19847 19848 19849 19850 19851 19852 19853 19854 19855 19856 19857 19858 19859 19860 19861 19862 19863 19864 19865 19866 19867 19868 19869 19870 19871 19872 19873 19874 19875 19876 19877 19878 19879 19880 19881 19882 19883 19884 19885 19886 19887 19888 19889 19890 19891 19892 19893 19894 19895 19896 19897 19898 19899 19900 19901 19902 19903 19904 19905 19906 19907 19908 19909 19910 19911 19912 19913 19914 19915 19916 19917 19918 19919 19920 19921 19922 19923 19924 19925 19926 19927 19928 19929 19930 19931 19932 19933 19934 19935 19936 19937 19938 19939 19940 19941 19942 19943 19944 19945 19946 19947 19948 19949 19950 19951 19952 19953 19954 19955 19956 19957 19958 19959 19960 19961 19962 19963 19964 19965 19966 19967 19968 19969 19970 19971 19972 19973 19974 19975 19976 19977 19978 19979 19980 19981 19982 19983 19984 19985 19986 19987 19988 19989 19990 19991 19992 19993 19994 19995 19996 19997 19998 19999 20000 20001 20002 20003 20004 20005 20006 20007 20008 20009 20010 20011 20012 20013 20014 20015 20016 20017 20018 20019 20020 20021 20022 20023 20024 20025 20026 20027 20028 20029 20030 20031 20032 20033 20034 20035 20036 20037 20038 20039 20040 20041 20042 20043 20044 20045 20046 20047 20048 20049 20050 20051 20052 20053 20054 20055 20056 20057 20058 20059 20060 20061 20062 20063 20064 20065 20066 20067 20068 20069 20070 20071 20072 20073 20074 20075 20076 20077 20078 20079 20080 20081 20082 20083 20084 20085 20086 20087 20088 20089 20090 20091 20092 20093 20094 20095 20096 20097 20098 20099 20100 20101 20102 20103 20104 20105 20106 20107 20108 20109 20110 20111 20112 20113 20114 20115 20116 20117 20118 20119 20120 20121 20122 20123 20124 20125 20126 20127 20128 20129 20130 20131 20132 20133 20134 20135 20136 20137 20138 20139 20140 20141 20142 20143 20144 20145 20146 20147 20148 20149 20150 20151 20152 20153 20154 20155 20156 20157 20158 20159 20160 20161 20162 20163 20164 20165 20166 20167 20168 20169 20170 20171 20172 20173 20174 20175 20176 20177 20178 20179 20180 20181 20182 20183 20184 20185 20186 20187 20188 20189 20190 20191 20192 20193 20194 20195 20196 20197 20198 20199 20200 20201 20202 20203 20204 20205 20206 20207 20208 20209 20210 20211 20212 20213 20214 20215 20216 20217 20218 20219 20220 20221 20222 20223 20224 20225 20226 20227 20228 20229 20230 20231 20232 20233 20234 20235 20236 20237 20238 20239 20240 20241 20242 20243 20244 20245 20246 20247 20248 20249 20250 20251 20252 20253 20254 20255 20256 20257 20258 20259 20260 20261 20262 20263 20264 20265 20266 20267 20268 20269 20270 20271 20272 20273 20274 20275 20276 20277 20278 20279 20280 20281 20282 20283 20284 20285 20286 20287 20288 20289 20290 20291 20292 20293 20294 20295 20296 20297 20298 20299 20300 20301 20302 20303 20304 20305 20306 20307 20308 20309 20310 20311 20312 20313 20314 20315 20316 20317 20318 20319 20320 20321 20322 20323 20324 20325 20326 20327 20328 20329 20330 20331 20332 20333 20334 20335 20336 20337 20338 20339 20340 20341 20342 20343 20344 20345 20346 20347 20348 20349 20350 20351 20352 20353 20354 20355 20356 20357 20358 20359 20360 20361 20362 20363 20364 20365 20366 20367 20368 20369 20370 20371 20372 20373 20374 20375 20376 20377 20378 20379 20380 20381 20382 20383 20384 20385 20386 20387 20388 20389 20390 20391 20392 20393 20394 20395 20396 20397 20398 20399 20400 20401 20402 20403 20404 20405 20406 20407 20408 20409 20410 20411 20412 20413 20414 20415 20416 20417 20418 20419 20420 20421 20422 20423 20424 20425 20426 20427 20428 20429 20430 20431 20432 20433 20434 20435 20436 20437 20438 20439 20440 20441 20442 20443 20444 20445 20446 20447 20448 20449 20450 20451 20452 20453 20454 20455 20456 20457 20458 20459 20460 20461 20462 20463 20464 20465 20466 20467 20468 20469 20470 20471 20472 20473 20474 20475 20476 20477 20478 20479 20480 20481 20482 20483 20484 20485 20486 20487 20488 20489 20490 20491 20492 20493 20494 20495 20496 20497 20498 20499 20500 20501 20502 20503 20504 20505 20506 20507 20508 20509 20510 20511 20512 20513 20514 20515 20516 20517 20518 20519 20520 20521 20522 20523 20524 20525 20526 20527 20528 20529 20530 20531 20532 20533 20534 20535 20536 20537 20538 20539 20540 20541 20542 20543 20544 20545 20546 20547 20548 20549 20550 20551 20552 20553 20554 20555 20556 20557 20558 20559 20560 20561 20562 20563 20564 20565 20566 20567 20568 20569 20570 20571 20572 20573 20574 20575 20576 20577 20578 20579 20580 20581 20582 20583 20584 20585 20586 20587 20588 20589 20590 20591 20592 20593 20594 20595 20596 20597 20598 20599 20600 20601 20602 20603 20604 20605 20606 20607 20608 20609 20610 20611 20612 20613 20614 20615 20616 20617 20618 20619 20620 20621 20622 20623 20624 20625 20626 20627 20628 20629 20630 20631 20632 20633 20634 20635 20636 20637 20638 20639 20640 20641 20642 20643 20644 20645 20646 20647 20648 20649 20650 20651 20652 20653 20654 20655 20656 20657 20658 20659 20660 20661 20662 20663 20664 20665 20666 20667 20668 20669 20670 20671 20672 20673 20674 20675 20676 20677 20678 20679 20680 20681 20682 20683 20684 20685 20686 20687 20688 20689 20690 20691 20692 20693 20694 20695 20696 20697 20698 20699 20700 20701 20702 20703 20704 20705 20706 20707 20708 20709 20710 20711 20712 20713 20714 20715 20716 20717 20718 20719 20720 20721 20722 20723 20724 20725 20726 20727 20728 20729 20730 20731 20732 20733 20734 20735 20736 20737 20738 20739 20740 20741 20742 20743 20744 20745 20746 20747 20748 20749 20750 20751 20752 20753 20754 20755 20756 20757 20758 20759 20760 20761 20762 20763 20764 20765 20766 20767 20768 20769 20770 20771 20772 20773 20774 20775 20776 20777 20778 20779 20780 20781 20782 20783 20784 20785 20786 20787 20788 20789 20790 20791 20792 20793 20794 20795 20796 20797 20798 20799 20800 20801 20802 20803 20804 20805 20806 20807 20808 20809 20810 20811 20812 20813 20814 20815 20816 20817 20818 20819 20820 20821 20822 20823 20824 20825 20826 20827 20828 20829 20830 20831 20832 20833 20834 20835 20836 20837 20838 20839 20840 20841 20842 20843 20844 20845 20846 20847 20848 20849 20850 20851 20852 20853 20854 20855 20856 20857 20858 20859 20860 20861 20862 20863 20864 20865 20866 20867 20868 20869 20870 20871 20872 20873 20874 20875 20876 20877 20878 20879 20880 20881 20882 20883 20884 20885 20886 20887 20888 20889 20890 20891 20892 20893 20894 20895 20896 20897 20898 20899 20900 20901 20902 20903 20904 20905 20906 20907 20908 20909 20910 20911 20912 20913 20914 20915 20916 20917 20918 20919 20920 20921 20922 20923 20924 20925 20926 20927 20928 20929 20930 20931 20932 20933 20934 20935 20936 20937 20938 20939 20940 20941 20942 20943 20944 20945 20946 20947 20948 20949 20950 20951 20952 20953 20954 20955 20956 20957 20958 20959 20960 20961 20962 20963 20964 20965 20966 20967 20968 20969 20970 20971 20972 20973 20974 20975 20976 20977 20978 20979 20980 20981 20982 20983 20984 20985 20986 20987 20988 20989 20990 20991 20992 20993 20994 20995 20996 20997 20998 20999 21000 21001 21002 21003 21004 21005 21006 21007 21008 21009 21010 21011 21012 21013 21014 21015 21016 21017 21018 21019 21020 21021 21022 21023 21024 21025 21026 21027 21028 21029 21030 21031 21032 21033 21034 21035 21036 21037 21038 21039 21040 21041 21042 21043 21044 21045 21046 21047 21048 21049 21050 21051 21052 21053 21054 21055 21056 21057 21058 21059 21060 21061 21062 21063 21064 21065 21066 21067 21068 21069 21070 21071 21072 21073 21074 21075 21076 21077 21078 21079 21080 21081 21082 21083 21084 21085 21086 21087 21088 21089 21090 21091 21092 21093 21094 21095 21096 21097 21098 21099 21100 21101 21102 21103 21104 21105 21106 21107 21108 21109 21110 21111 21112 21113 21114 21115 21116 21117 21118 21119 21120 21121 21122 21123 21124 21125 21126 21127 21128 21129 21130 21131 21132 21133 21134 21135 21136 21137 21138 21139 21140 21141 21142 21143 21144 21145 21146 21147 21148 21149 21150 21151 21152 21153 21154 21155 21156 21157 21158 21159 21160 21161 21162 21163 21164 21165 21166 21167 21168 21169 21170 21171 21172 21173 21174 21175 21176 21177 21178 21179 21180 21181 21182 21183 21184 21185 21186 21187 21188 21189 21190 21191 21192 21193 21194 21195 21196 21197 21198 21199 21200 21201 21202 21203 21204 21205 21206 21207 21208 21209 21210 21211 21212 21213 21214 21215 21216 21217 21218 21219 21220 21221 21222 21223 21224 21225 21226 21227 21228 21229 21230 21231 21232 21233 21234 21235 21236 21237 21238 21239 21240 21241 21242 21243 21244 21245 21246 21247 21248 21249 21250 21251 21252 21253 21254 21255 21256 21257 21258 21259 21260 21261 21262 21263 21264 21265 21266 21267 21268 21269 21270 21271 21272 21273 21274 21275 21276 21277 21278 21279 21280 21281 21282 21283 21284 21285 21286 21287 21288 21289 21290 21291 21292 21293 21294 21295 21296 21297 21298 21299 21300 21301 21302 21303 21304 21305 21306 21307 21308 21309 21310 21311 21312 21313 21314 21315 21316 21317 21318 21319 21320 21321 21322 21323 21324 21325 21326 21327 21328 21329 21330 21331 21332 21333 21334 21335 21336 21337 21338 21339 21340 21341 21342 21343 21344 21345 21346 21347 21348 21349 21350 21351 21352 21353 21354 21355 21356 21357 21358 21359 21360 21361 21362 21363 21364 21365 21366 21367 21368 21369 21370 21371 21372 21373 21374 21375 21376 21377 21378 21379 21380 21381 21382 21383 21384 21385 21386 21387 21388 21389 21390 21391 21392 21393 21394 21395 21396 21397 21398 21399 21400 21401 21402 21403 21404 21405 21406 21407 21408 21409 21410 21411 21412 21413 21414 21415 21416 21417 21418 21419 21420 21421 21422 21423 21424 21425 21426 21427 21428 21429 21430 21431 21432 21433 21434 21435 21436 21437 21438 21439 21440 21441 21442 21443 21444 21445 21446 21447 21448 21449 21450 21451 21452 21453 21454 21455 21456 21457 21458 21459 21460 21461 21462 21463 21464 21465 21466 21467 21468 21469 21470 21471 21472 21473 21474 21475 21476 21477 21478 21479 21480 21481 21482 21483 21484 21485 21486 21487 21488 21489 21490 21491 21492 21493 21494 21495 21496 21497 21498 21499 21500 21501 21502 21503 21504 21505 21506 21507 21508 21509 21510 21511 21512 21513 21514 21515 21516 21517 21518 21519 21520 21521 21522 21523 21524 21525 21526 21527 21528 21529 21530 21531 21532 21533 21534 21535 21536 21537 21538 21539 21540 21541 21542 21543 21544 21545 21546 21547 21548 21549 21550 21551 21552 21553 21554 21555 21556 21557 21558 21559 21560 21561 21562 21563 21564 21565 21566 21567 21568 21569 21570 21571 21572 21573 21574 21575 21576 21577 21578 21579 21580 21581 21582 21583 21584 21585 21586 21587 21588 21589 21590 21591 21592 21593 21594 21595 21596 21597 21598 21599 21600 21601 21602 21603 21604 21605 21606 21607 21608 21609 21610 21611 21612 21613 21614 21615 21616 21617 21618 21619 21620 21621 21622 21623 21624 21625 21626 21627 21628 21629 21630 21631 21632 21633 21634 21635 21636 21637 21638 21639 21640 21641 21642 21643 21644 21645 21646 21647 21648 21649 21650 21651 21652 21653 21654 21655 21656 21657 21658 21659 21660 21661 21662 21663 21664 21665 21666 21667 21668 21669 21670 21671 21672 21673 21674 21675 21676 21677 21678 21679 21680 21681 21682 21683 21684 21685 21686 21687 21688 21689 21690 21691 21692 21693 21694 21695 21696 21697 21698 21699 21700 21701 21702 21703 21704 21705 21706 21707 21708 21709 21710 21711 21712 21713 21714 21715 21716 21717 21718 21719 21720 21721 21722 21723 21724 21725 21726 21727 21728 21729 21730 21731 21732 21733 21734 21735 21736 21737 21738 21739 21740 21741 21742 21743 21744 21745 21746 21747 21748 21749 21750 21751 21752 21753 21754 21755 21756 21757 21758 21759 21760 21761 21762 21763 21764 21765 21766 21767 21768 21769 21770 21771 21772 21773 21774 21775 21776 21777 21778 21779 21780 21781 21782 21783 21784 21785 21786 21787 21788 21789 21790 21791 21792 21793 21794 21795 21796 21797 21798 21799 21800 21801 21802 21803 21804 21805 21806 21807 21808 21809 21810 21811 21812 21813 21814 21815 21816 21817 21818 21819 21820 21821 21822 21823 21824 21825 21826 21827 21828 21829 21830 21831 21832 21833 21834 21835 21836 21837 21838 21839 21840 21841 21842 21843 21844 21845 21846 21847 21848 21849 21850 21851 21852 21853 21854 21855 21856 21857 21858 21859 21860 21861 21862 21863 21864 21865 21866 21867 21868 21869 21870 21871 21872 21873 21874 21875 21876 21877 21878 21879 21880 21881 21882 21883 21884 21885 21886 21887 21888 21889 21890 21891 21892 21893 21894 21895 21896 21897 21898 21899 21900 21901 21902 21903 21904 21905 21906 21907 21908 21909 21910 21911 21912 21913 21914 21915 21916 21917 21918 21919 21920 21921 21922 21923 21924 21925 21926 21927 21928 21929 21930 21931 21932 21933 21934 21935 21936 21937 21938 21939 21940 21941 21942 21943 21944 21945 21946 21947 21948 21949 21950 21951 21952 21953 21954 21955 21956 21957 21958 21959 21960 21961 21962 21963 21964 21965 21966 21967 21968 21969 21970 21971 21972 21973 21974 21975 21976 21977 21978 21979 21980 21981 21982 21983 21984 21985 21986 21987 21988 21989 21990 21991 21992 21993 21994 21995 21996 21997 21998 21999 22000 22001 22002 22003 22004 22005 22006 22007 22008 22009 22010 22011 22012 22013 22014 22015 22016 22017 22018 22019 22020 22021 22022 22023 22024 22025 22026 22027 22028 22029 22030 22031 22032 22033 22034 22035 22036 22037 22038 22039 22040 22041 22042 22043 22044 22045 22046 22047 22048 22049 22050 22051 22052 22053 22054 22055 22056 22057 22058 22059 22060 22061 22062 22063 22064 22065 22066 22067 22068 22069 22070 22071 22072 22073 22074 22075 22076 22077 22078 22079 22080 22081 22082 22083 22084 22085 22086 22087 22088 22089 22090 22091 22092 22093 22094 22095 22096 22097 22098 22099 22100 22101 22102 22103 22104 22105 22106 22107 22108 22109 22110 22111 22112 22113 22114 22115 22116 22117 22118 22119 22120 22121 22122 22123 22124 22125 22126 22127 22128 22129 22130 22131 22132 22133 22134 22135 22136 22137 22138 22139 22140 22141 22142 22143 22144 22145 22146 22147 22148 22149 22150 22151 22152 22153 22154 22155 22156 22157 22158 22159 22160 22161 22162 22163 22164 22165 22166 22167 22168 22169 22170 22171 22172 22173 22174 22175 22176 22177 22178 22179 22180 22181 22182 22183 22184 22185 22186 22187 22188 22189 22190 22191 22192 22193 22194 22195 22196 22197 22198 22199 22200 22201 22202 22203 22204 22205 22206 22207 22208 22209 22210 22211 22212 22213 22214 22215 22216 22217 22218 22219 22220 22221 22222 22223 22224 22225 22226 22227 22228 22229 22230 22231 22232 22233 22234 22235 22236 22237 22238 22239 22240 22241 22242 22243 22244 22245 22246 22247 22248 22249 22250 22251 22252 22253 22254 22255 22256 22257 22258 22259 22260 22261 22262 22263 22264 22265 22266 22267 22268 22269 22270 22271 22272 22273 22274 22275 22276 22277 22278 22279 22280 22281 22282 22283 22284 22285 22286 22287 22288 22289 22290 22291 22292 22293 22294 22295 22296 22297 22298 22299 22300 22301 22302 22303 22304 22305 22306 22307 22308 22309 22310 22311 22312 22313 22314 22315 22316 22317 22318 22319 22320 22321 22322 22323 22324 22325 22326 22327 22328 22329 22330 22331 22332 22333 22334 22335 22336 22337 22338 22339 22340 22341 22342 22343 22344 22345 22346 22347 22348 22349 22350 22351 22352 22353 22354 22355 22356 22357 22358 22359 22360 22361 22362 22363 22364 22365 22366 22367 22368 22369 22370 22371 22372 22373 22374 22375 22376 22377 22378 22379 22380 22381 22382 22383 22384 22385 22386 22387 22388 22389 22390 22391 22392 22393 22394 22395 22396 22397 22398 22399 22400 22401 22402 22403 22404 22405 22406 22407 22408 22409 22410 22411 22412 22413 22414 22415 22416 22417 22418 22419 22420 22421 22422 22423 22424 22425 22426 22427 22428 22429 22430 22431 22432 22433 22434 22435 22436 22437 22438 22439 22440 22441 22442 22443 22444 22445 22446 22447 22448 22449 22450 22451 22452 22453 22454 22455 22456 22457 22458 22459 22460 22461 22462 22463 22464 22465 22466 22467 22468 22469 22470 22471 22472 22473 22474 22475 22476 22477 22478 22479 22480 22481 22482 22483 22484 22485 22486 22487 22488 22489 22490 22491 22492 22493 22494 22495 22496 22497 22498 22499 22500 22501 22502 22503 22504 22505 22506 22507 22508 22509 22510 22511 22512 22513 22514 22515 22516 22517 22518 22519 22520 22521 22522 22523 22524 22525 22526 22527 22528 22529 22530 22531 22532 22533 22534 22535 22536 22537 22538 22539 22540 22541 22542 22543 22544 22545 22546 22547 22548 22549 22550 22551 22552 22553 22554 22555 22556 22557 22558 22559 22560 22561 22562 22563 22564 22565 22566 22567 22568 22569 22570 22571 22572 22573 22574 22575 22576 22577 22578 22579 22580 22581 22582 22583 22584 22585 22586 22587 22588 22589 22590 22591 22592 22593 22594 22595 22596 22597 22598 22599 22600 22601 22602 22603 22604 22605 22606 22607 22608 22609 22610 22611 22612 22613 22614 22615 22616 22617 22618 22619 22620 22621 22622 22623 22624 22625 22626 22627 22628 22629 22630 22631 22632 22633 22634 22635 22636 22637 22638 22639 22640 22641 22642 22643 22644 22645 22646 22647 22648 22649 22650 22651 22652 22653 22654 22655 22656 22657 22658 22659 22660 22661 22662 22663 22664 22665 22666 22667 22668 22669 22670 22671 22672 22673 22674 22675 22676 22677 22678 22679 22680 22681 22682 22683 22684 22685 22686 22687 22688 22689 22690 22691 22692 22693 22694 22695 22696 22697 22698 22699 22700 22701 22702 22703 22704 22705 22706 22707 22708 22709 22710 22711 22712 22713 22714 22715 22716 22717 22718 22719 22720 22721 22722 22723 22724 22725 22726 22727 22728 22729 22730 22731 22732 22733 22734 22735 22736 22737 22738 22739 22740 22741 22742 22743 22744 22745 22746 22747 22748 22749 22750 22751 22752 22753 22754 22755 22756 22757 22758 22759 22760 22761 22762 22763 22764 22765 22766 22767 22768 22769 22770 22771 22772 22773 22774 22775 22776 22777 22778 22779 22780 22781 22782 22783 22784 22785 22786 22787 22788 22789 22790 22791 22792 22793 22794 22795 22796 22797 22798 22799 22800 22801 22802 22803 22804 22805 22806 22807 22808 22809 22810 22811 22812 22813 22814 22815 22816 22817 22818 22819 22820 22821 22822 22823 22824 22825 22826 22827 22828 22829 22830 22831 22832 22833 22834 22835 22836 22837 22838 22839 22840 22841 22842 22843 22844 22845 22846 22847 22848 22849 22850 22851 22852 22853 22854 22855 22856 22857 22858 22859 22860 22861 22862 22863 22864 22865 22866 22867 22868 22869 22870 22871 22872 22873 22874 22875 22876 22877 22878 22879 22880 22881 22882 22883 22884 22885 22886 22887 22888 22889 22890 22891 22892 22893 22894 22895 22896 22897 22898 22899 22900 22901 22902 22903 22904 22905 22906 22907 22908 22909 22910 22911 22912 22913 22914 22915 22916 22917 22918 22919 22920 22921 22922 22923 22924 22925 22926 22927 22928 22929 22930 22931 22932 22933 22934 22935 22936 22937 22938 22939 22940 22941 22942 22943 22944 22945 22946 22947 22948 22949 22950 22951 22952 22953 22954 22955 22956 22957 22958 22959 22960 22961 22962 22963 22964 22965 22966 22967 22968 22969 22970 22971 22972 22973 22974 22975 22976 22977 22978 22979 22980 22981 22982 22983 22984 22985 22986 22987 22988 22989 22990 22991 22992 22993 22994 22995 22996 22997 22998 22999 23000 23001 23002 23003 23004 23005 23006 23007 23008 23009 23010 23011 23012 23013 23014 23015 23016 23017 23018 23019 23020 23021 23022 23023 23024 23025 23026 23027 23028 23029 23030 23031 23032 23033 23034 23035 23036 23037 23038 23039 23040 23041 23042 23043 23044 23045 23046 23047 23048 23049 23050 23051 23052 23053 23054 23055 23056 23057 23058 23059 23060 23061 23062 23063 23064 23065 23066 23067 23068 23069 23070 23071 23072 23073 23074 23075 23076 23077 23078 23079 23080 23081 23082 23083 23084 23085 23086 23087 23088 23089 23090 23091 23092 23093 23094 23095 23096 23097 23098 23099 23100 23101 23102 23103 23104 23105 23106 23107 23108 23109 23110 23111 23112 23113 23114 23115 23116 23117 23118 23119 23120 23121 23122 23123 23124 23125 23126 23127 23128 23129 23130 23131 23132 23133 23134 23135 23136 23137 23138 23139 23140 23141 23142 23143 23144 23145 23146 23147 23148 23149 23150 23151 23152 23153 23154 23155 23156 23157 23158 23159 23160 23161 23162 23163 23164 23165 23166 23167 23168 23169 23170 23171 23172 23173 23174 23175 23176 23177 23178 23179 23180 23181 23182 23183 23184 23185 23186 23187 23188 23189 23190 23191 23192 23193 23194 23195 23196 23197 23198 23199 23200 23201 23202 23203 23204 23205 23206 23207 23208 23209 23210 23211 23212 23213 23214 23215 23216 23217 23218 23219 23220 23221 23222 23223 23224 23225 23226 23227 23228 23229 23230 23231 23232 23233 23234 23235 23236 23237 23238 23239 23240 23241 23242 23243 23244 23245 23246 23247 23248 23249 23250 23251 23252 23253 23254 23255 23256 23257 23258 23259 23260 23261 23262 23263 23264 23265 23266 23267 23268 23269 23270 23271 23272 23273 23274 23275 23276 23277 23278 23279 23280 23281 23282 23283 23284 23285 23286 23287 23288 23289 23290 23291 23292 23293 23294 23295 23296 23297 23298 23299 23300 23301 23302 23303 23304 23305 23306 23307 23308 23309 23310 23311 23312 23313 23314 23315 23316 23317 23318 23319 23320 23321 23322 23323 23324 23325 23326 23327 23328 23329 23330 23331 23332 23333 23334 23335 23336 23337 23338 23339 23340 23341 23342 23343 23344 23345 23346 23347 23348 23349 23350 23351 23352 23353 23354 23355 23356 23357 23358 23359 23360 23361 23362 23363 23364 23365 23366 23367 23368 23369 23370 23371 23372 23373 23374 23375 23376 23377 23378 23379 23380 23381 23382 23383 23384 23385 23386 23387 23388 23389 23390 23391 23392 23393 23394 23395 23396 23397 23398 23399 23400 23401 23402 23403 23404 23405 23406 23407 23408 23409 23410 23411 23412 23413 23414 23415 23416 23417 23418 23419 23420 23421 23422 23423 23424 23425 23426 23427 23428 23429 23430 23431 23432 23433 23434 23435 23436 23437 23438 23439 23440 23441 23442 23443 23444 23445 23446 23447 23448 23449 23450 23451 23452 23453 23454 23455 23456 23457 23458 23459 23460 23461 23462 23463 23464 23465 23466 23467 23468 23469 23470 23471 23472 23473 23474 23475 23476 23477 23478 23479 23480 23481 23482 23483 23484 23485 23486 23487 23488 23489 23490 23491 23492 23493 23494 23495 23496 23497 23498 23499 23500 23501 23502 23503 23504 23505 23506 23507 23508 23509 23510 23511 23512 23513 23514 23515 23516 23517 23518 23519 23520 23521 23522 23523 23524 23525 23526 23527 23528 23529 23530 23531 23532 23533 23534 23535 23536 23537 23538 23539 23540 23541 23542 23543 23544 23545 23546 23547 23548 23549 23550 23551 23552 23553 23554 23555 23556 23557 23558 23559 23560 23561 23562 23563 23564 23565 23566 23567 23568 23569 23570 23571 23572 23573 23574 23575 23576 23577 23578 23579 23580 23581 23582 23583 23584 23585 23586 23587 23588 23589 23590 23591 23592 23593 23594 23595 23596 23597 23598 23599 23600 23601 23602 23603 23604 23605 23606 23607 23608 23609 23610 23611 23612 23613 23614 23615 23616 23617 23618 23619 23620 23621 23622 23623 23624 23625 23626 23627 23628 23629 23630 23631 23632 23633 23634 23635 23636 23637 23638 23639 23640 23641 23642 23643 23644 23645 23646 23647 23648 23649 23650 23651 23652 23653 23654 23655 23656 23657 23658 23659 23660 23661 23662 23663 23664 23665 23666 23667 23668 23669 23670 23671 23672 23673 23674 23675 23676 23677 23678 23679 23680 23681 23682 23683 23684 23685 23686 23687 23688 23689 23690 23691 23692 23693 23694 23695 23696 23697 23698 23699 23700 23701 23702 23703 23704 23705 23706 23707 23708 23709 23710 23711 23712 23713 23714 23715 23716 23717 23718 23719 23720 23721 23722 23723 23724 23725 23726 23727 23728 23729 23730 23731 23732 23733 23734 23735 23736 23737 23738 23739 23740 23741 23742 23743 23744 23745 23746 23747 23748 23749 23750 23751 23752 23753 23754 23755 23756 23757 23758 23759 23760 23761 23762 23763 23764 23765 23766 23767 23768 23769 23770 23771 23772 23773 23774 23775 23776 23777 23778 23779 23780 23781 23782 23783 23784 23785 23786 23787 23788 23789 23790 23791 23792 23793 23794 23795 23796 23797 23798 23799 23800 23801 23802 23803 23804 23805 23806 23807 23808 23809 23810 23811 23812 23813 23814 23815 23816 23817 23818 23819 23820 23821 23822 23823 23824 23825 23826 23827 23828 23829 23830 23831 23832 23833 23834 23835 23836 23837 23838 23839 23840 23841 23842 23843 23844 23845 23846 23847 23848 23849 23850 23851 23852 23853 23854 23855 23856 23857 23858 23859 23860 23861 23862 23863 23864 23865 23866 23867 23868 23869 23870 23871 23872 23873 23874 23875 23876 23877 23878 23879 23880 23881 23882 23883 23884 23885 23886 23887 23888 23889 23890 23891 23892 23893 23894 23895 23896 23897 23898 23899 23900 23901 23902 23903 23904 23905 23906 23907 23908 23909 23910 23911 23912 23913 23914 23915 23916 23917 23918 23919 23920 23921 23922 23923 23924 23925 23926 23927 23928 23929 23930 23931 23932 23933 23934 23935 23936 23937 23938 23939 23940 23941 23942 23943 23944 23945 23946 23947 23948 23949 23950 23951 23952 23953 23954 23955 23956 23957 23958 23959 23960 23961 23962 23963 23964 23965 23966 23967 23968 23969 23970 23971 23972 23973 23974 23975 23976 23977 23978 23979 23980 23981 23982 23983 23984 23985 23986 23987 23988 23989 23990 23991 23992 23993 23994 23995 23996 23997 23998 23999 24000 24001 24002 24003 24004 24005 24006 24007 24008 24009 24010 24011 24012 24013 24014 24015 24016 24017 24018 24019 24020 24021 24022 24023 24024 24025 24026 24027 24028 24029 24030 24031 24032 24033 24034 24035 24036 24037 24038 24039 24040 24041 24042 24043 24044 24045 24046 24047 24048 24049 24050 24051 24052 24053 24054 24055 24056 24057 24058 24059 24060 24061 24062 24063 24064 24065 24066 24067 24068 24069 24070 24071 24072 24073 24074 24075 24076 24077 24078 24079 24080 24081 24082 24083 24084 24085 24086 24087 24088 24089 24090 24091 24092 24093 24094 24095 24096 24097 24098 24099 24100 24101 24102 24103 24104 24105 24106 24107 24108 24109 24110 24111 24112 24113 24114 24115 24116 24117 24118 24119 24120 24121 24122 24123 24124 24125 24126 24127 24128 24129 24130 24131 24132 24133 24134 24135 24136 24137 24138 24139 24140 24141 24142 24143 24144 24145 24146 24147 24148 24149 24150 24151 24152 24153 24154 24155 24156 24157 24158 24159 24160 24161 24162 24163 24164 24165 24166 24167 24168 24169 24170 24171 24172 24173 24174 24175 24176 24177 24178 24179 24180 24181 24182 24183 24184 24185 24186 24187 24188 24189 24190 24191 24192 24193 24194 24195 24196 24197 24198 24199 24200 24201 24202 24203 24204 24205 24206 24207 24208 24209 24210 24211 24212 24213 24214 24215 24216 24217 24218 24219 24220 24221 24222 24223 24224 24225 24226 24227 24228 24229 24230 24231 24232 24233 24234 24235 24236 24237 24238 24239 24240 24241 24242 24243 24244 24245 24246 24247 24248 24249 24250 24251 24252 24253 24254 24255 24256 24257 24258 24259 24260 24261 24262 24263 24264 24265 24266 24267 24268 24269 24270 24271 24272 24273 24274 24275 24276 24277 24278 24279 24280 24281 24282 24283 24284 24285 24286 24287 24288 24289 24290 24291 24292 24293 24294 24295 24296 24297 24298 24299 24300 24301 24302 24303 24304 24305 24306 24307 24308 24309 24310 24311 24312 24313 24314 24315 24316 24317 24318 24319 24320 24321 24322 24323 24324 24325 24326 24327 24328 24329 24330 24331 24332 24333 24334 24335 24336 24337 24338 24339 24340 24341 24342 24343 24344 24345 24346 24347 24348 24349 24350 24351 24352 24353 24354 24355 24356 24357 24358 24359 24360 24361 24362 24363 24364 24365 24366 24367 24368 24369 24370 24371 24372 24373 24374 24375 24376 24377 24378 24379 24380 24381 24382 24383 24384 24385 24386 24387 24388 24389 24390 24391 24392 24393 24394 24395 24396 24397 24398 24399 24400 24401 24402 24403 24404 24405 24406 24407 24408 24409 24410 24411 24412 24413 24414 24415 24416 24417 24418 24419 24420 24421 24422 24423 24424 24425 24426 24427 24428 24429 24430 24431 24432 24433 24434 24435 24436 24437 24438 24439 24440 24441 24442 24443 24444 24445 24446 24447 24448 24449 24450 24451 24452 24453 24454 24455 24456 24457 24458 24459 24460 24461 24462 24463 24464 24465 24466 24467 24468 24469 24470 24471 24472 24473 24474 24475 24476 24477 24478 24479 24480 24481 24482 24483 24484 24485 24486 24487 24488 24489 24490 24491 24492 24493 24494 24495 24496 24497 24498 24499 24500 24501 24502 24503 24504 24505 24506 24507 24508 24509 24510 24511 24512 24513 24514 24515 24516 24517 24518 24519 24520 24521 24522 24523 24524 24525 24526 24527 24528 24529 24530 24531 24532 24533 24534 24535 24536 24537 24538 24539 24540 24541 24542 24543 24544 24545 24546 24547 24548 24549 24550 24551 24552 24553 24554 24555 24556 24557 24558 24559 24560 24561 24562 24563 24564 24565 24566 24567 24568 24569 24570 24571 24572 24573 24574 24575 24576 24577 24578 24579 24580 24581 24582 24583 24584 24585 24586 24587 24588 24589 24590 24591 24592 24593 24594 24595 24596 24597 24598 24599 24600 24601 24602 24603 24604 24605 24606 24607 24608 24609 24610 24611 24612 24613 24614 24615 24616 24617 24618 24619 24620 24621 24622 24623 24624 24625 24626 24627 24628 24629 24630 24631 24632 24633 24634 24635 24636 24637 24638 24639 24640 24641 24642 24643 24644 24645 24646 24647 24648 24649 24650 24651 24652 24653 24654 24655 24656 24657 24658 24659 24660 24661 24662 24663 24664 24665 24666 24667 24668 24669 24670 24671 24672 24673 24674 24675 24676 24677 24678 24679 24680 24681 24682 24683 24684 24685 24686 24687 24688 24689 24690 24691 24692 24693 24694 24695 24696 24697 24698 24699 24700 24701 24702 24703 24704 24705 24706 24707 24708 24709 24710 24711 24712 24713 24714 24715 24716 24717 24718 24719 24720 24721 24722 24723 24724 24725 24726 24727 24728 24729 24730 24731 24732 24733 24734 24735 24736 24737 24738 24739 24740 24741 24742 24743 24744 24745 24746 24747 24748 24749 24750 24751 24752 24753 24754 24755 24756 24757 24758 24759 24760 24761 24762 24763 24764 24765 24766 24767 24768 24769 24770 24771 24772 24773 24774 24775 24776 24777 24778 24779 24780 24781 24782 24783 24784 24785 24786 24787 24788 24789 24790 24791 24792 24793 24794 24795 24796 24797 24798 24799 24800 24801 24802 24803 24804 24805 24806 24807 24808 24809 24810 24811 24812 24813 24814 24815 24816 24817 24818 24819 24820 24821 24822 24823 24824 24825 24826 24827 24828 24829 24830 24831 24832 24833 24834 24835 24836 24837 24838 24839 24840 24841 24842 24843 24844 24845 24846 24847 24848 24849 24850 24851 24852 24853 24854 24855 24856 24857 24858 24859 24860 24861 24862 24863 24864 24865 24866 24867 24868 24869 24870 24871 24872 24873 24874 24875 24876 24877 24878 24879 24880 24881 24882 24883 24884 24885 24886 24887 24888 24889 24890 24891 24892 24893 24894 24895 24896 24897 24898 24899 24900 24901 24902 24903 24904 24905 24906 24907 24908 24909 24910 24911 24912 24913 24914 24915 24916 24917 24918 24919 24920 24921 24922 24923 24924 24925 24926 24927 24928 24929 24930 24931 24932 24933 24934 24935 24936 24937 24938 24939 24940 24941 24942 24943 24944 24945 24946 24947 24948 24949 24950 24951 24952 24953 24954 24955 24956 24957 24958 24959 24960 24961 24962 24963 24964 24965 24966 24967 24968 24969 24970 24971 24972 24973 24974 24975 24976 24977 24978 24979 24980 24981 24982 24983 24984 24985 24986 24987 24988 24989 24990 24991 24992 24993 24994 24995 24996 24997 24998 24999 25000 25001 25002 25003 25004 25005 25006 25007 25008 25009 25010 25011 25012 25013 25014 25015 25016 25017 25018 25019 25020 25021 25022 25023 25024 25025 25026 25027 25028 25029 25030 25031 25032 25033 25034 25035 25036 25037 25038 25039 25040 25041 25042 25043 25044 25045 25046 25047 25048 25049 25050 25051 25052 25053 25054 25055 25056 25057 25058 25059 25060 25061 25062 25063 25064 25065 25066 25067 25068 25069 25070 25071 25072 25073 25074 25075 25076 25077 25078 25079 25080 25081 25082 25083 25084 25085 25086 25087 25088 25089 25090 25091 25092 25093 25094 25095 25096 25097 25098 25099 25100 25101 25102 25103 25104 25105 25106 25107 25108 25109 25110 25111 25112 25113 25114 25115 25116 25117 25118 25119 25120 25121 25122 25123 25124 25125 25126 25127 25128 25129 25130 25131 25132 25133 25134 25135 25136 25137 25138 25139 25140 25141 25142 25143 25144 25145 25146 25147 25148 25149 25150 25151 25152 25153 25154 25155 25156 25157 25158 25159 25160 25161 25162 25163 25164 25165 25166 25167 25168 25169 25170 25171 25172 25173 25174 25175 25176 25177 25178 25179 25180 25181 25182 25183 25184 25185 25186 25187 25188 25189 25190 25191 25192 25193 25194 25195 25196 25197 25198 25199 25200 25201 25202 25203 25204 25205 25206 25207 25208 25209 25210 25211 25212 25213 25214 25215 25216 25217 25218 25219 25220 25221 25222 25223 25224 25225 25226 25227 25228 25229 25230 25231 25232 25233 25234 25235 25236 25237 25238 25239 25240 25241 25242 25243 25244 25245 25246 25247 25248 25249 25250 25251 25252 25253 25254 25255 25256 25257 25258 25259 25260 25261 25262 25263 25264 25265 25266 25267 25268 25269 25270 25271 25272 25273 25274 25275 25276 25277 25278 25279 25280 25281 25282 25283 25284 25285 25286 25287 25288 25289 25290 25291 25292 25293 25294 25295 25296 25297 25298 25299 25300 25301 25302 25303 25304 25305 25306 25307 25308 25309 25310 25311 25312 25313 25314 25315 25316 25317 25318 25319 25320 25321 25322 25323 25324 25325 25326 25327 25328 25329 25330 25331 25332 25333 25334 25335 25336 25337 25338 25339 25340 25341 25342 25343 25344 25345 25346 25347 25348 25349 25350 25351 25352 25353 25354 25355 25356 25357 25358 25359 25360 25361 25362 25363 25364 25365 25366 25367 25368 25369 25370 25371 25372 25373 25374 25375 25376 25377 25378 25379 25380 25381 25382 25383 25384 25385 25386 25387 25388 25389 25390 25391 25392 25393 25394 25395 25396 25397 25398 25399 25400 25401 25402 25403 25404 25405 25406 25407 25408 25409 25410 25411 25412 25413 25414 25415 25416 25417 25418 25419 25420 25421 25422 25423 25424 25425 25426 25427 25428 25429 25430 25431 25432 25433 25434 25435 25436 25437 25438 25439 25440 25441 25442 25443 25444 25445 25446 25447 25448 25449 25450 25451 25452 25453 25454 25455 25456 25457 25458 25459 25460 25461 25462 25463 25464 25465 25466 25467 25468 25469 25470 25471 25472 25473 25474 25475 25476 25477 25478 25479 25480 25481 25482 25483 25484 25485 25486 25487 25488 25489 25490 25491 25492 25493 25494 25495 25496 25497 25498 25499 25500 25501 25502 25503 25504 25505 25506 25507 25508 25509 25510 25511 25512 25513 25514 25515 25516 25517 25518 25519 25520 25521 25522 25523 25524 25525 25526 25527 25528 25529 25530 25531 25532 25533 25534 25535 25536 25537 25538 25539 25540 25541 25542 25543 25544 25545 25546 25547 25548 25549 25550 25551 25552 25553 25554 25555 25556 25557 25558 25559 25560 25561 25562 25563 25564 25565 25566 25567 25568 25569 25570 25571 25572 25573 25574 25575 25576 25577 25578 25579 25580 25581 25582 25583 25584 25585 25586 25587 25588 25589 25590 25591 25592 25593 25594 25595 25596 25597 25598 25599 25600 25601 25602 25603 25604 25605 25606 25607 25608 25609 25610 25611 25612 25613 25614 25615 25616 25617 25618 25619 25620 25621 25622 25623 25624 25625 25626 25627 25628 25629 25630 25631 25632 25633 25634 25635 25636 25637 25638 25639 25640 25641 25642 25643 25644 25645 25646 25647 25648 25649 25650 25651 25652 25653 25654 25655 25656 25657 25658 25659 25660 25661 25662 25663 25664 25665 25666 25667 25668 25669 25670 25671 25672 25673 25674 25675 25676 25677 25678 25679 25680 25681 25682 25683 25684 25685 25686 25687 25688 25689 25690 25691 25692 25693 25694 25695 25696 25697 25698 25699 25700 25701 25702 25703 25704 25705 25706 25707 25708 25709 25710 25711 25712 25713 25714 25715 25716 25717 25718 25719 25720 25721 25722 25723 25724 25725 25726 25727 25728 25729 25730 25731 25732 25733 25734 25735 25736 25737 25738 25739 25740 25741 25742 25743 25744 25745 25746 25747 25748 25749 25750 25751 25752 25753 25754 25755 25756 25757 25758 25759 25760 25761 25762 25763 25764 25765 25766 25767 25768 25769 25770 25771 25772 25773 25774 25775 25776 25777 25778 25779 25780 25781 25782 25783 25784 25785 25786 25787 25788 25789 25790 25791 25792 25793 25794 25795 25796 25797 25798 25799 25800 25801 25802 25803 25804 25805 25806 25807 25808 25809 25810 25811 25812 25813 25814 25815 25816 25817 25818 25819 25820 25821 25822 25823 25824 25825 25826 25827 25828 25829 25830 25831 25832 25833 25834 25835 25836 25837 25838 25839 25840 25841 25842 25843 25844 25845 25846 25847 25848 25849 25850 25851 25852 25853 25854 25855 25856 25857 25858 25859 25860 25861 25862 25863 25864 25865 25866 25867 25868 25869 25870 25871 25872 25873 25874 25875 25876 25877 25878 25879 25880 25881 25882 25883 25884 25885 25886 25887 25888 25889 25890 25891 25892 25893 25894 25895 25896 25897 25898 25899 25900 25901 25902 25903 25904 25905 25906 25907 25908 25909 25910 25911 25912 25913 25914 25915 25916 25917 25918 25919 25920 25921 25922 25923 25924 25925 25926 25927 25928 25929 25930 25931 25932 25933 25934 25935 25936 25937 25938 25939 25940 25941 25942 25943 25944 25945 25946 25947 25948 25949 25950 25951 25952 25953 25954 25955 25956 25957 25958 25959 25960 25961 25962 25963 25964 25965 25966 25967 25968 25969 25970 25971 25972 25973 25974 25975 25976 25977 25978 25979 25980 25981 25982 25983 25984 25985 25986 25987 25988 25989 25990 25991 25992 25993 25994 25995 25996 25997 25998 25999 26000 26001 26002 26003 26004 26005 26006 26007 26008 26009 26010 26011 26012 26013 26014 26015 26016 26017 26018 26019 26020 26021 26022 26023 26024 26025 26026 26027 26028 26029 26030 26031 26032 26033 26034 26035 26036 26037 26038 26039 26040 26041 26042 26043 26044 26045 26046 26047 26048 26049 26050 26051 26052 26053 26054 26055 26056 26057 26058 26059 26060 26061 26062 26063 26064 26065 26066 26067 26068 26069 26070 26071 26072 26073 26074 26075 26076 26077 26078 26079 26080 26081 26082 26083 26084 26085 26086 26087 26088 26089 26090 26091 26092 26093 26094 26095 26096 26097 26098 26099 26100 26101 26102 26103 26104 26105 26106 26107 26108 26109 26110 26111 26112 26113 26114 26115 26116 26117 26118 26119 26120 26121 26122 26123 26124 26125 26126 26127 26128 26129 26130 26131 26132 26133 26134 26135 26136 26137 26138 26139 26140 26141 26142 26143 26144 26145 26146 26147 26148 26149 26150 26151 26152 26153 26154 26155 26156 26157 26158 26159 26160 26161 26162 26163 26164 26165 26166 26167 26168 26169 26170 26171 26172 26173 26174 26175 26176 26177 26178 26179 26180 26181 26182 26183 26184 26185 26186 26187 26188 26189 26190 26191 26192 26193 26194 26195 26196 26197 26198 26199 26200 26201 26202 26203 26204 26205 26206 26207 26208 26209 26210 26211 26212 26213 26214 26215 26216 26217 26218 26219 26220 26221 26222 26223 26224 26225 26226 26227 26228 26229 26230 26231 26232 26233 26234 26235 26236 26237 26238 26239 26240 26241 26242 26243 26244 26245 26246 26247 26248 26249 26250 26251 26252 26253 26254 26255 26256 26257 26258 26259 26260 26261 26262 26263 26264 26265 26266 26267 26268 26269 26270 26271 26272 26273 26274 26275 26276 26277 26278 26279 26280 26281 26282 26283 26284 26285 26286 26287 26288 26289 26290 26291 26292 26293 26294 26295 26296 26297 26298 26299 26300 26301 26302 26303 26304 26305 26306 26307 26308 26309 26310 26311 26312 26313 26314 26315 26316 26317 26318 26319 26320 26321 26322 26323 26324 26325 26326 26327 26328 26329 26330 26331 26332 26333 26334 26335 26336 26337 26338 26339 26340 26341 26342 26343 26344 26345 26346 26347 26348 26349 26350 26351 26352 26353 26354 26355 26356 26357 26358 26359 26360 26361 26362 26363 26364 26365 26366 26367 26368 26369 26370 26371 26372 26373 26374 26375 26376 26377 26378 26379 26380 26381 26382 26383 26384 26385 26386 26387 26388 26389 26390 26391 26392 26393 26394 26395 26396 26397 26398 26399 26400 26401 26402 26403 26404 26405 26406 26407 26408 26409 26410 26411 26412 26413 26414 26415 26416 26417 26418 26419 26420 26421 26422 26423 26424 26425 26426 26427 26428 26429 26430 26431 26432 26433 26434 26435 26436 26437 26438 26439 26440 26441 26442 26443 26444 26445 26446 26447 26448 26449 26450 26451 26452 26453 26454 26455 26456 26457 26458 26459 26460 26461 26462 26463 26464 26465 26466 26467 26468 26469 26470 26471 26472 26473 26474 26475 26476 26477 26478 26479 26480 26481 26482 26483 26484 26485 26486 26487 26488 26489 26490 26491 26492 26493 26494 26495 26496 26497 26498 26499 26500 26501 26502 26503 26504 26505 26506 26507 26508 26509 26510 26511 26512 26513 26514 26515 26516 26517 26518 26519 26520 26521 26522 26523 26524 26525 26526 26527 26528 26529 26530 26531 26532 26533 26534 26535 26536 26537 26538 26539 26540 26541 26542 26543 26544 26545 26546 26547 26548 26549 26550 26551 26552 26553 26554 26555 26556 26557 26558 26559 26560 26561 26562 26563 26564 26565 26566 26567 26568 26569 26570 26571 26572 26573 26574 26575 26576 26577 26578 26579 26580 26581 26582 26583 26584 26585 26586 26587 26588 26589 26590 26591 26592 26593 26594 26595 26596 26597 26598 26599 26600 26601 26602 26603 26604 26605 26606 26607 26608 26609 26610 26611 26612 26613 26614 26615 26616 26617 26618 26619 26620 26621 26622 26623 26624 26625 26626 26627 26628 26629 26630 26631 26632 26633 26634 26635 26636 26637 26638 26639 26640 26641 26642 26643 26644 26645 26646 26647 26648 26649 26650 26651 26652 26653 26654 26655 26656 26657 26658 26659 26660 26661 26662 26663 26664 26665 26666 26667 26668 26669 26670 26671 26672 26673 26674 26675 26676 26677 26678 26679 26680 26681 26682 26683 26684 26685 26686 26687 26688 26689 26690 26691 26692 26693 26694 26695 26696 26697 26698 26699 26700 26701 26702 26703 26704 26705 26706 26707 26708 26709 26710 26711 26712 26713 26714 26715 26716 26717 26718 26719 26720 26721 26722 26723 26724 26725 26726 26727 26728 26729 26730 26731 26732 26733 26734 26735 26736 26737 26738 26739 26740 26741 26742 26743 26744 26745 26746 26747 26748 26749 26750 26751 26752 26753 26754 26755 26756 26757 26758 26759 26760 26761 26762 26763 26764 26765 26766 26767 26768 26769 26770 26771 26772 26773 26774 26775 26776 26777 26778 26779 26780 26781 26782 26783 26784 26785 26786 26787 26788 26789 26790 26791 26792 26793 26794 26795 26796 26797 26798 26799 26800 26801 26802 26803 26804 26805 26806 26807 26808 26809 26810 26811 26812 26813 26814 26815 26816 26817 26818 26819 26820 26821 26822 26823 26824 26825 26826 26827 26828 26829 26830 26831 26832 26833 26834 26835 26836 26837 26838 26839 26840 26841 26842 26843 26844 26845 26846 26847 26848 26849 26850 26851 26852 26853 26854 26855 26856 26857 26858 26859 26860 26861 26862 26863 26864 26865 26866 26867 26868 26869 26870 26871 26872 26873 26874 26875 26876 26877 26878 26879 26880 26881 26882 26883 26884 26885 26886 26887 26888 26889 26890 26891 26892 26893 26894 26895 26896 26897 26898 26899 26900 26901 26902 26903 26904 26905 26906 26907 26908 26909 26910 26911 26912 26913 26914 26915 26916 26917 26918 26919 26920 26921 26922 26923 26924 26925 26926 26927 26928 26929 26930 26931 26932 26933 26934 26935 26936 26937 26938 26939 26940 26941 26942 26943 26944 26945 26946 26947 26948 26949 26950 26951 26952 26953 26954 26955 26956 26957 26958 26959 26960 26961 26962 26963 26964 26965 26966 26967 26968 26969 26970 26971 26972 26973 26974 26975 26976 26977 26978 26979 26980 26981 26982 26983 26984 26985 26986 26987 26988 26989 26990 26991 26992 26993 26994 26995 26996 26997 26998 26999 27000 27001 27002 27003 27004 27005 27006 27007 27008 27009 27010 27011 27012 27013 27014 27015 27016 27017 27018 27019 27020 27021 27022 27023 27024 27025 27026 27027 27028 27029 27030 27031 27032 27033 27034 27035 27036 27037 27038 27039 27040 27041 27042 27043 27044 27045 27046 27047 27048 27049 27050 27051 27052 27053 27054 27055 27056 27057 27058 27059 27060 27061 27062 27063 27064 27065 27066 27067 27068 27069 27070 27071 27072 27073 27074 27075 27076 27077 27078 27079 27080 27081 27082 27083 27084 27085 27086 27087 27088 27089 27090 27091 27092 27093 27094 27095 27096 27097 27098 27099 27100 27101 27102 27103 27104 27105 27106 27107 27108 27109 27110 27111 27112 27113 27114 27115 27116 27117 27118 27119 27120 27121 27122 27123 27124 27125 27126 27127 27128 27129 27130 27131 27132 27133 27134 27135 27136 27137 27138 27139 27140 27141 27142 27143 27144 27145 27146 27147 27148 27149 27150 27151 27152 27153 27154 27155 27156 27157 27158 27159 27160 27161 27162 27163 27164 27165 27166 27167 27168 27169 27170 27171 27172 27173 27174 27175 27176 27177 27178 27179 27180 27181 27182 27183 27184 27185 27186 27187 27188 27189 27190 27191 27192 27193 27194 27195 27196 27197 27198 27199 27200 27201 27202 27203 27204 27205 27206 27207 27208 27209 27210 27211 27212 27213 27214 27215 27216 27217 27218 27219 27220 27221 27222 27223 27224 27225 27226 27227 27228 27229 27230 27231 27232 27233 27234 27235 27236 27237 27238 27239 27240 27241 27242 27243 27244 27245 27246 27247 27248 27249 27250 27251 27252 27253 27254 27255 27256 27257 27258 27259 27260 27261 27262 27263 27264 27265 27266 27267 27268 27269 27270 27271 27272 27273 27274 27275 27276 27277 27278 27279 27280 27281 27282 27283 27284 27285 27286 27287 27288 27289 27290 27291 27292 27293 27294 27295 27296 27297 27298 27299 27300 27301 27302 27303 27304 27305 27306 27307 27308 27309 27310 27311 27312 27313 27314 27315 27316 27317 27318 27319 27320 27321 27322 27323 27324 27325 27326 27327 27328 27329 27330 27331 27332 27333 27334 27335 27336 27337 27338 27339 27340 27341 27342 27343 27344 27345 27346 27347 27348 27349 27350 27351 27352 27353 27354 27355 27356 27357 27358 27359 27360 27361 27362 27363 27364 27365 27366 27367 27368 27369 27370 27371 27372 27373 27374 27375 27376 27377 27378 27379 27380 27381 27382 27383 27384 27385 27386 27387 27388 27389 27390 27391 27392 27393 27394 27395 27396 27397 27398 27399 27400 27401 27402 27403 27404 27405 27406 27407 27408 27409 27410 27411 27412 27413 27414 27415 27416 27417 27418 27419 27420 27421 27422 27423 27424 27425 27426 27427 27428 27429 27430 27431 27432 27433 27434 27435 27436 27437 27438 27439 27440 27441 27442 27443 27444 27445 27446 27447 27448 27449 27450 27451 27452 27453 27454 27455 27456 27457 27458 27459 27460 27461 27462 27463 27464 27465 27466 27467 27468 27469 27470 27471 27472 27473 27474 27475 27476 27477 27478 27479 27480 27481 27482 27483 27484 27485 27486 27487 27488 27489 27490 27491 27492 27493 27494 27495 27496 27497 27498 27499 27500 27501 27502 27503 27504 27505 27506 27507 27508 27509 27510 27511 27512 27513 27514 27515 27516 27517 27518 27519 27520 27521 27522 27523 27524 27525 27526 27527 27528 27529 27530 27531 27532 27533 27534 27535 27536 27537 27538 27539 27540 27541 27542 27543 27544 27545 27546 27547 27548 27549 27550 27551 27552 27553 27554 27555 27556 27557 27558 27559 27560 27561 27562 27563 27564 27565 27566 27567 27568 27569 27570 27571 27572 27573 27574 27575 27576 27577 27578 27579 27580 27581 27582 27583 27584 27585 27586 27587 27588 27589 27590 27591 27592 27593 27594 27595 27596 27597 27598 27599 27600 27601 27602 27603 27604 27605 27606 27607 27608 27609 27610 27611 27612 27613 27614 27615 27616 27617 27618 27619 27620 27621 27622 27623 27624 27625 27626 27627 27628 27629 27630 27631 27632 27633 27634 27635 27636 27637 27638 27639 27640 27641 27642 27643 27644 27645 27646 27647 27648 27649 27650 27651 27652 27653 27654 27655 27656 27657 27658 27659 27660 27661 27662 27663 27664 27665 27666 27667 27668 27669 27670 27671 27672 27673 27674 27675 27676 27677 27678 27679 27680 27681 27682 27683 27684 27685 27686 27687 27688 27689 27690 27691 27692 27693 27694 27695 27696 27697 27698 27699 27700 27701 27702 27703 27704 27705 27706 27707 27708 27709 27710 27711 27712 27713 27714 27715 27716 27717 27718 27719 27720 27721 27722 27723 27724 27725 27726 27727 27728 27729 27730 27731 27732 27733 27734 27735 27736 27737 27738 27739 27740 27741 27742 27743 27744 27745 27746 27747 27748 27749 27750 27751 27752 27753 27754 27755 27756 27757 27758 27759 27760 27761 27762 27763 27764 27765 27766 27767 27768 27769 27770 27771 27772 27773 27774 27775 27776 27777 27778 27779 27780 27781 27782 27783 27784 27785 27786 27787 27788 27789 27790 27791 27792 27793 27794 27795 27796 27797 27798 27799 27800 27801 27802 27803 27804 27805 27806 27807 27808 27809 27810 27811 27812 27813 27814 27815 27816 27817 27818 27819 27820 27821 27822 27823 27824 27825 27826 27827 27828 27829 27830 27831 27832 27833 27834 27835 27836 27837 27838 27839 27840 27841 27842 27843 27844 27845 27846 27847 27848 27849 27850 27851 27852 27853 27854 27855 27856 27857 27858 27859 27860 27861 27862 27863 27864 27865 27866 27867 27868 27869 27870 27871 27872 27873 27874 27875 27876 27877 27878 27879 27880 27881 27882 27883 27884 27885 27886 27887 27888 27889 27890 27891 27892 27893 27894 27895 27896 27897 27898 27899 27900 27901 27902 27903 27904 27905 27906 27907 27908 27909 27910 27911 27912 27913 27914 27915 27916 27917 27918 27919 27920 27921 27922 27923 27924 27925 27926 27927 27928 27929 27930 27931 27932 27933 27934 27935 27936 27937 27938 27939 27940 27941 27942 27943 27944 27945 27946 27947 27948 27949 27950 27951 27952 27953 27954 27955 27956 27957 27958 27959 27960 27961 27962 27963 27964 27965 27966 27967 27968 27969 27970 27971 27972 27973 27974 27975 27976 27977 27978 27979 27980 27981 27982 27983 27984 27985 27986 27987 27988 27989 27990 27991 27992 27993 27994 27995 27996 27997 27998 27999 28000 28001 28002 28003 28004 28005 28006 28007 28008 28009 28010 28011 28012 28013 28014 28015 28016 28017 28018 28019 28020 28021 28022 28023 28024 28025 28026 28027 28028 28029 28030 28031 28032 28033 28034 28035 28036 28037 28038 28039 28040 28041 28042 28043 28044 28045 28046 28047 28048 28049 28050 28051 28052 28053 28054 28055 28056 28057 28058 28059 28060 28061 28062 28063 28064 28065 28066 28067 28068 28069 28070 28071 28072 28073 28074 28075 28076 28077 28078 28079 28080 28081 28082 28083 28084 28085 28086 28087 28088 28089 28090 28091 28092 28093 28094 28095 28096 28097 28098 28099 28100 28101 28102 28103 28104 28105 28106 28107 28108 28109 28110 28111 28112 28113 28114 28115 28116 28117 28118 28119 28120 28121 28122 28123 28124 28125 28126 28127 28128 28129 28130 28131 28132 28133 28134 28135 28136 28137 28138 28139 28140 28141 28142 28143 28144 28145 28146 28147 28148 28149 28150 28151 28152 28153 28154 28155 28156 28157 28158 28159 28160 28161 28162 28163 28164 28165 28166 28167 28168 28169 28170 28171 28172 28173 28174 28175 28176 28177 28178 28179 28180 28181 28182 28183 28184 28185 28186 28187 28188 28189 28190 28191 28192 28193 28194 28195 28196 28197 28198 28199 28200 28201 28202 28203 28204 28205 28206 28207 28208 28209 28210 28211 28212 28213 28214 28215 28216 28217 28218 28219 28220 28221 28222 28223 28224 28225 28226 28227 28228 28229 28230 28231 28232 28233 28234 28235 28236 28237 28238 28239 28240 28241 28242 28243 28244 28245 28246 28247 28248 28249 28250 28251 28252 28253 28254 28255 28256 28257 28258 28259 28260 28261 28262 28263 28264 28265 28266 28267 28268 28269 28270 28271 28272 28273 28274 28275 28276 28277 28278 28279 28280 28281 28282 28283 28284 28285 28286 28287 28288 28289 28290 28291 28292 28293 28294 28295 28296 28297 28298 28299 28300 28301 28302 28303 28304 28305 28306 28307 28308 28309 28310 28311 28312 28313 28314 28315 28316 28317 28318 28319 28320 28321 28322 28323 28324 28325 28326 28327 28328 28329 28330 28331 28332 28333 28334 28335 28336 28337 28338 28339 28340 28341 28342 28343 28344 28345 28346 28347 28348 28349 28350 28351 28352 28353 28354 28355 28356 28357 28358 28359 28360 28361 28362 28363 28364 28365 28366 28367 28368 28369 28370 28371 28372 28373 28374 28375 28376 28377 28378 28379 28380 28381 28382 28383 28384 28385 28386 28387 28388 28389 28390 28391 28392 28393 28394 28395 28396 28397 28398 28399 28400 28401 28402 28403 28404 28405 28406 28407 28408 28409 28410 28411 28412 28413 28414 28415 28416 28417 28418 28419 28420 28421 28422 28423 28424 28425 28426 28427 28428 28429 28430 28431 28432 28433 28434 28435 28436 28437 28438 28439 28440 28441 28442 28443 28444 28445 28446 28447 28448 28449 28450 28451 28452 28453 28454 28455 28456 28457 28458 28459 28460 28461 28462 28463 28464 28465 28466 28467 28468 28469 28470 28471 28472 28473 28474 28475 28476 28477 28478 28479 28480 28481 28482 28483 28484 28485 28486 28487 28488 28489 28490 28491 28492 28493 28494 28495 28496 28497 28498 28499 28500 28501 28502 28503 28504 28505 28506 28507 28508 28509 28510 28511 28512 28513 28514 28515 28516 28517 28518 28519 28520 28521 28522 28523 28524 28525 28526 28527 28528 28529 28530 28531 28532 28533 28534 28535 28536 28537 28538 28539 28540 28541 28542 28543 28544 28545 28546 28547 28548 28549 28550 28551 28552 28553 28554 28555 28556 28557 28558 28559 28560 28561 28562 28563 28564 28565 28566 28567 28568 28569 28570 28571 28572 28573 28574 28575 28576 28577 28578 28579 28580 28581 28582 28583 28584 28585 28586 28587 28588 28589 28590 28591 28592 28593 28594 28595 28596 28597 28598 28599 28600 28601 28602 28603 28604 28605 28606 28607 28608 28609 28610 28611 28612 28613 28614 28615 28616 28617 28618 28619 28620 28621 28622 28623 28624 28625 28626 28627 28628 28629 28630 28631 28632 28633 28634 28635 28636 28637 28638 28639 28640 28641 28642 28643 28644 28645 28646 28647 28648 28649 28650 28651 28652 28653 28654 28655 28656 28657 28658 28659 28660 28661 28662 28663 28664 28665 28666 28667 28668 28669 28670 28671 28672 28673 28674 28675 28676 28677 28678 28679 28680 28681 28682 28683 28684 28685 28686 28687 28688 28689 28690 28691 28692 28693 28694 28695 28696 28697 28698 28699 28700 28701 28702 28703 28704 28705 28706 28707 28708 28709 28710 28711 28712 28713 28714 28715 28716 28717 28718 28719 28720 28721 28722 28723 28724 28725 28726 28727 28728 28729 28730 28731 28732 28733 28734 28735 28736 28737 28738 28739 28740 28741 28742 28743 28744 28745 28746 28747 28748 28749 28750 28751 28752 28753 28754 28755 28756 28757 28758 28759 28760 28761 28762 28763 28764 28765 28766 28767 28768 28769 28770 28771 28772 28773 28774 28775 28776 28777 28778 28779 28780 28781 28782 28783 28784 28785 28786 28787 28788 28789 28790 28791 28792 28793 28794 28795 28796 28797 28798 28799 28800 28801 28802 28803 28804 28805 28806 28807 28808 28809 28810 28811 28812 28813 28814 28815 28816 28817 28818 28819 28820 28821 28822 28823 28824 28825 28826 28827 28828 28829 28830 28831 28832 28833 28834 28835 28836 28837 28838 28839 28840 28841 28842 28843 28844 28845 28846 28847 28848 28849 28850 28851 28852 28853 28854 28855 28856 28857 28858 28859 28860 28861 28862 28863 28864 28865 28866 28867 28868 28869 28870 28871 28872 28873 28874 28875 28876 28877 28878 28879 28880 28881 28882 28883 28884 28885 28886 28887 28888 28889 28890 28891 28892 28893 28894 28895 28896 28897 28898 28899 28900 28901 28902 28903 28904 28905 28906 28907 28908 28909 28910 28911 28912 28913 28914 28915 28916 28917 28918 28919 28920 28921 28922 28923 28924 28925 28926 28927 28928 28929 28930 28931 28932 28933 28934 28935 28936 28937 28938 28939 28940 28941 28942 28943 28944 28945 28946 28947 28948 28949 28950 28951 28952 28953 28954 28955 28956 28957 28958 28959 28960 28961 28962 28963 28964 28965 28966 28967 28968 28969 28970 28971 28972 28973 28974 28975 28976 28977 28978 28979 28980 28981 28982 28983 28984 28985 28986 28987 28988 28989 28990 28991 28992 28993 28994 28995 28996 28997 28998 28999 29000 29001 29002 29003 29004 29005 29006 29007 29008 29009 29010 29011 29012 29013 29014 29015 29016 29017 29018 29019 29020 29021 29022 29023 29024 29025 29026 29027 29028 29029 29030 29031 29032 29033 29034 29035 29036 29037 29038 29039 29040 29041 29042 29043 29044 29045 29046 29047 29048 29049 29050 29051 29052 29053 29054 29055 29056 29057 29058 29059 29060 29061 29062 29063 29064 29065 29066 29067 29068 29069 29070 29071 29072 29073 29074 29075 29076 29077 29078 29079 29080 29081 29082 29083 29084 29085 29086 29087 29088 29089 29090 29091 29092 29093 29094 29095 29096 29097 29098 29099 29100 29101 29102 29103 29104 29105 29106 29107 29108 29109 29110 29111 29112 29113 29114 29115 29116 29117 29118 29119 29120 29121 29122 29123 29124 29125 29126 29127 29128 29129 29130 29131 29132 29133 29134 29135 29136 29137 29138 29139 29140 29141 29142 29143 29144 29145 29146 29147 29148 29149 29150 29151 29152 29153 29154 29155 29156 29157 29158 29159 29160 29161 29162 29163 29164 29165 29166 29167 29168 29169 29170 29171 29172 29173 29174 29175 29176 29177 29178 29179 29180 29181 29182 29183 29184 29185 29186 29187 29188 29189 29190 29191 29192 29193 29194 29195 29196 29197 29198 29199 29200 29201 29202 29203 29204 29205 29206 29207 29208 29209 29210 29211 29212 29213 29214 29215 29216 29217 29218 29219 29220 29221 29222 29223 29224 29225 29226 29227 29228 29229 29230 29231 29232 29233 29234 29235 29236 29237 29238 29239 29240 29241 29242 29243 29244 29245 29246 29247 29248 29249 29250 29251 29252 29253 29254 29255 29256 29257 29258 29259 29260 29261 29262 29263 29264 29265 29266 29267 29268 29269 29270 29271 29272 29273 29274 29275 29276 29277 29278 29279 29280 29281 29282 29283 29284 29285 29286 29287 29288 29289 29290 29291 29292 29293 29294 29295 29296 29297 29298 29299 29300 29301 29302 29303 29304 29305 29306 29307 29308 29309 29310 29311 29312 29313 29314 29315 29316 29317 29318 29319 29320 29321 29322 29323 29324 29325 29326 29327 29328 29329 29330 29331 29332 29333 29334 29335 29336 29337 29338 29339 29340 29341 29342 29343 29344 29345 29346 29347 29348 29349 29350 29351 29352 29353 29354 29355 29356 29357 29358 29359 29360 29361 29362 29363 29364 29365 29366 29367 29368 29369 29370 29371 29372 29373 29374 29375 29376 29377 29378 29379 29380 29381 29382 29383 29384 29385 29386 29387 29388 29389 29390 29391 29392 29393 29394 29395 29396 29397 29398 29399 29400 29401 29402 29403 29404 29405 29406 29407 29408 29409 29410 29411 29412 29413 29414 29415 29416 29417 29418 29419 29420 29421 29422 29423 29424 29425 29426 29427 29428 29429 29430 29431 29432 29433 29434 29435 29436 29437 29438 29439 29440 29441 29442 29443 29444 29445 29446 29447 29448 29449 29450 29451 29452 29453 29454 29455 29456 29457 29458 29459 29460 29461 29462 29463 29464 29465 29466 29467 29468 29469 29470 29471 29472 29473 29474 29475 29476 29477 29478 29479 29480 29481 29482 29483 29484 29485 29486 29487 29488 29489 29490 29491 29492 29493 29494 29495 29496 29497 29498 29499 29500 29501 29502 29503 29504 29505 29506 29507 29508 29509 29510 29511 29512 29513 29514 29515 29516 29517 29518 29519 29520 29521 29522 29523 29524 29525 29526 29527 29528 29529 29530 29531 29532 29533 29534 29535 29536 29537 29538 29539 29540 29541 29542 29543 29544 29545 29546 29547 29548 29549 29550 29551 29552 29553 29554 29555 29556 29557 29558 29559 29560 29561 29562 29563 29564 29565 29566 29567 29568 29569 29570 29571 29572 29573 29574 29575 29576 29577 29578 29579 29580 29581 29582 29583 29584 29585 29586 29587 29588 29589 29590 29591 29592 29593 29594 29595 29596 29597 29598 29599 29600 29601 29602 29603 29604 29605 29606 29607 29608 29609 29610 29611 29612 29613 29614 29615 29616 29617 29618 29619 29620 29621 29622 29623 29624 29625 29626 29627 29628 29629 29630 29631 29632 29633 29634 29635 29636 29637 29638 29639 29640 29641 29642 29643 29644 29645 29646 29647 29648 29649 29650 29651 29652 29653 29654 29655 29656 29657 29658 29659 29660 29661 29662 29663 29664 29665 29666 29667 29668 29669 29670 29671 29672 29673 29674 29675 29676 29677 29678 29679 29680 29681 29682 29683 29684 29685 29686 29687 29688 29689 29690 29691 29692 29693 29694 29695 29696 29697 29698 29699 29700 29701 29702 29703 29704 29705 29706 29707 29708 29709 29710 29711 29712 29713 29714 29715 29716 29717 29718 29719 29720 29721 29722 29723 29724 29725 29726 29727 29728 29729 29730 29731 29732 29733 29734 29735 29736 29737 29738 29739 29740 29741 29742 29743 29744 29745 29746 29747 29748 29749 29750 29751 29752 29753 29754 29755 29756 29757 29758 29759 29760 29761 29762 29763 29764 29765 29766 29767 29768 29769 29770 29771 29772 29773 29774 29775 29776 29777 29778 29779 29780 29781 29782 29783 29784 29785 29786 29787 29788 29789 29790 29791 29792 29793 29794 29795 29796 29797 29798 29799 29800 29801 29802 29803 29804 29805 29806 29807 29808 29809 29810 29811 29812 29813 29814 29815 29816 29817 29818 29819 29820 29821 29822 29823 29824 29825 29826 29827 29828 29829 29830 29831 29832 29833 29834 29835 29836 29837 29838 29839 29840 29841 29842 29843 29844 29845 29846 29847 29848 29849 29850 29851 29852 29853 29854 29855 29856 29857 29858 29859 29860 29861 29862 29863 29864 29865 29866 29867 29868 29869 29870 29871 29872 29873 29874 29875 29876 29877 29878 29879 29880 29881 29882 29883 29884 29885 29886 29887 29888 29889 29890 29891 29892 29893 29894 29895 29896 29897 29898 29899 29900 29901 29902 29903 29904 29905 29906 29907 29908 29909 29910 29911 29912 29913 29914 29915 29916 29917 29918 29919 29920 29921 29922 29923 29924 29925 29926 29927 29928 29929 29930 29931 29932 29933 29934 29935 29936 29937 29938 29939 29940 29941 29942 29943 29944 29945 29946 29947 29948 29949 29950 29951 29952 29953 29954 29955 29956 29957 29958 29959 29960 29961 29962 29963 29964 29965 29966 29967 29968 29969 29970 29971 29972 29973 29974 29975 29976 29977 29978 29979 29980 29981 29982 29983 29984 29985 29986 29987 29988 29989 29990 29991 29992 29993 29994 29995 29996 29997 29998 29999 30000 30001 30002 30003 30004 30005 30006 30007 30008 30009 30010 30011 30012 30013 30014 30015 30016 30017 30018 30019 30020 30021 30022 30023 30024 30025 30026 30027 30028 30029 30030 30031 30032 30033 30034 30035 30036 30037 30038 30039 30040 30041 30042 30043 30044 30045 30046 30047 30048 30049 30050 30051 30052 30053 30054 30055 30056 30057 30058 30059 30060 30061 30062 30063 30064 30065 30066 30067 30068 30069 30070 30071 30072 30073 30074 30075 30076 30077 30078 30079 30080 30081 30082 30083 30084 30085 30086 30087 30088 30089 30090 30091 30092 30093 30094 30095 30096 30097 30098 30099 30100 30101 30102 30103 30104 30105 30106 30107 30108 30109 30110 30111 30112 30113 30114 30115 30116 30117 30118 30119 30120 30121 30122 30123 30124 30125 30126 30127 30128 30129 30130 30131 30132 30133 30134 30135 30136 30137 30138 30139 30140 30141 30142 30143 30144 30145 30146 30147 30148 30149 30150 30151 30152 30153 30154 30155 30156 30157 30158 30159 30160 30161 30162 30163 30164 30165 30166 30167 30168 30169 30170 30171 30172 30173 30174 30175 30176 30177 30178 30179 30180 30181 30182 30183 30184 30185 30186 30187 30188 30189 30190 30191 30192 30193 30194 30195 30196 30197 30198 30199 30200 30201 30202 30203 30204 30205 30206 30207 30208 30209 30210 30211 30212 30213 30214 30215 30216 30217 30218 30219 30220 30221 30222 30223 30224 30225 30226 30227 30228 30229 30230 30231 30232 30233 30234 30235 30236 30237 30238 30239 30240 30241 30242 30243 30244 30245 30246 30247 30248 30249 30250 30251 30252 30253 30254 30255 30256 30257 30258 30259 30260 30261 30262 30263 30264 30265 30266 30267 30268 30269 30270 30271 30272 30273 30274 30275 30276 30277 30278 30279 30280 30281 30282 30283 30284 30285 30286 30287 30288 30289 30290 30291 30292 30293 30294 30295 30296 30297 30298 30299 30300 30301 30302 30303 30304 30305 30306 30307 30308 30309 30310 30311 30312 30313 30314 30315 30316 30317 30318 30319 30320 30321 30322 30323 30324 30325 30326 30327 30328 30329 30330 30331 30332 30333 30334 30335 30336 30337 30338 30339 30340 30341 30342 30343 30344 30345 30346 30347 30348 30349 30350 30351 30352 30353 30354 30355 30356 30357 30358 30359 30360 30361 30362 30363 30364 30365 30366 30367 30368 30369 30370 30371 30372 30373 30374 30375 30376 30377 30378 30379 30380 30381 30382 30383 30384 30385 30386 30387 30388 30389 30390 30391 30392 30393 30394 30395 30396 30397 30398 30399 30400 30401 30402 30403 30404 30405 30406 30407 30408 30409 30410 30411 30412 30413 30414 30415 30416 30417 30418 30419 30420 30421 30422 30423 30424 30425 30426 30427 30428 30429 30430 30431 30432 30433 30434 30435 30436 30437 30438 30439 30440 30441 30442 30443 30444 30445 30446 30447 30448 30449 30450 30451 30452 30453 30454 30455 30456 30457 30458 30459 30460 30461 30462 30463 30464 30465 30466 30467 30468 30469 30470 30471 30472 30473 30474 30475 30476 30477 30478 30479 30480 30481 30482 30483 30484 30485 30486 30487 30488 30489 30490 30491 30492 30493 30494 30495 30496 30497 30498 30499 30500 30501 30502 30503 30504 30505 30506 30507 30508 30509 30510 30511 30512 30513 30514 30515 30516 30517 30518 30519 30520 30521 30522 30523 30524 30525 30526 30527 30528 30529 30530 30531 30532 30533 30534 30535 30536 30537 30538 30539 30540 30541 30542 30543 30544 30545 30546 30547 30548 30549 30550 30551 30552 30553 30554 30555 30556 30557 30558 30559 30560 30561 30562 30563 30564 30565 30566 30567 30568 30569 30570 30571 30572 30573 30574 30575 30576 30577 30578 30579 30580 30581 30582 30583 30584 30585 30586 30587 30588 30589 30590 30591 30592 30593 30594 30595 30596 30597 30598 30599 30600 30601 30602 30603 30604 30605 30606 30607 30608 30609 30610 30611 30612 30613 30614 30615 30616 30617 30618 30619 30620 30621 30622 30623 30624 30625 30626 30627 30628 30629 30630 30631 30632 30633 30634 30635 30636 30637 30638 30639 30640 30641 30642 30643 30644 30645 30646 30647 30648 30649 30650 30651 30652 30653 30654 30655 30656 30657 30658 30659 30660 30661 30662 30663 30664 30665 30666 30667 30668 30669 30670 30671 30672 30673 30674 30675 30676 30677 30678 30679 30680 30681 30682 30683 30684 30685 30686 30687 30688 30689 30690 30691 30692 30693 30694 30695 30696 30697 30698 30699 30700 30701 30702 30703 30704 30705 30706 30707 30708 30709 30710 30711 30712 30713 30714 30715 30716 30717 30718 30719 30720 30721 30722 30723 30724 30725 30726 30727 30728 30729 30730 30731 30732 30733 30734 30735 30736 30737 30738 30739 30740 30741 30742 30743 30744 30745 30746 30747 30748 30749 30750 30751 30752 30753 30754 30755 30756 30757 30758 30759 30760 30761 30762 30763 30764 30765 30766 30767 30768 30769 30770 30771 30772 30773 30774 30775 30776 30777 30778 30779 30780 30781 30782 30783 30784 30785 30786 30787 30788 30789 30790 30791 30792 30793 30794 30795 30796 30797 30798 30799 30800 30801 30802 30803 30804 30805 30806 30807 30808 30809 30810 30811 30812 30813 30814 30815 30816 30817 30818 30819 30820 30821 30822 30823 30824 30825 30826 30827 30828 30829 30830 30831 30832 30833 30834 30835 30836 30837 30838 30839 30840 30841 30842 30843 30844 30845 30846 30847 30848 30849 30850 30851 30852 30853 30854 30855 30856 30857 30858 30859 30860 30861 30862 30863 30864 30865 30866 30867 30868 30869 30870 30871 30872 30873 30874 30875 30876 30877 30878 30879 30880 30881 30882 30883 30884 30885 30886 30887 30888 30889 30890 30891 30892 30893 30894 30895 30896 30897 30898 30899 30900 30901 30902 30903 30904 30905 30906 30907 30908 30909 30910 30911 30912 30913 30914 30915 30916 30917 30918 30919 30920 30921 30922 30923 30924 30925 30926 30927 30928 30929 30930 30931 30932 30933 30934 30935 30936 30937 30938 30939 30940 30941 30942 30943 30944 30945 30946 30947 30948 30949 30950 30951 30952 30953 30954 30955 30956 30957 30958 30959 30960 30961 30962 30963 30964 30965 30966 30967 30968 30969 30970 30971 30972 30973 30974 30975 30976 30977 30978 30979 30980 30981 30982 30983 30984 30985 30986 30987 30988 30989 30990 30991 30992 30993 30994 30995 30996 30997 30998 30999 31000 31001 31002 31003 31004 31005 31006 31007 31008 31009 31010 31011 31012 31013 31014 31015 31016 31017 31018 31019 31020 31021 31022 31023 31024 31025 31026 31027 31028 31029 31030 31031 31032 31033 31034 31035 31036 31037 31038 31039 31040 31041 31042 31043 31044 31045 31046 31047 31048 31049 31050 31051 31052 31053 31054 31055 31056 31057 31058 31059 31060 31061 31062 31063 31064 31065 31066 31067 31068 31069 31070 31071 31072 31073 31074 31075 31076 31077 31078 31079 31080 31081 31082 31083 31084 31085 31086 31087 31088 31089 31090 31091 31092 31093 31094 31095 31096 31097 31098 31099 31100 31101 31102 31103 31104 31105 31106 31107 31108 31109 31110 31111 31112 31113 31114 31115 31116 31117 31118 31119 31120 31121 31122 31123 31124 31125 31126 31127 31128 31129 31130 31131 31132 31133 31134 31135 31136 31137 31138 31139 31140 31141 31142 31143 31144 31145 31146 31147 31148 31149 31150 31151 31152 31153 31154 31155 31156 31157 31158 31159 31160 31161 31162 31163 31164 31165 31166 31167 31168 31169 31170 31171 31172 31173 31174 31175 31176 31177 31178 31179 31180 31181 31182 31183 31184 31185 31186 31187 31188 31189 31190 31191 31192 31193 31194 31195 31196 31197 31198 31199 31200 31201 31202 31203 31204 31205 31206 31207 31208 31209 31210 31211 31212 31213 31214 31215 31216 31217 31218 31219 31220 31221 31222 31223 31224 31225 31226 31227 31228 31229 31230 31231 31232 31233 31234 31235 31236 31237 31238 31239 31240 31241 31242 31243 31244 31245 31246 31247 31248 31249 31250 31251 31252 31253 31254 31255 31256 31257 31258 31259 31260 31261 31262 31263 31264 31265 31266 31267 31268 31269 31270 31271 31272 31273 31274 31275 31276 31277 31278 31279 31280 31281 31282 31283 31284 31285 31286 31287 31288 31289 31290 31291 31292 31293 31294 31295 31296 31297 31298 31299 31300 31301 31302 31303 31304 31305 31306 31307 31308 31309 31310 31311 31312 31313 31314 31315 31316 31317 31318 31319 31320 31321 31322 31323 31324 31325 31326 31327 31328 31329 31330 31331 31332 31333 31334 31335 31336 31337 31338 31339 31340 31341 31342 31343 31344 31345 31346 31347 31348 31349 31350 31351 31352 31353 31354 31355 31356 31357 31358 31359 31360 31361 31362 31363 31364 31365 31366 31367 31368 31369 31370 31371 31372 31373 31374 31375 31376 31377 31378 31379 31380 31381 31382 31383 31384 31385 31386 31387 31388 31389 31390 31391 31392 31393 31394 31395 31396 31397 31398 31399 31400 31401 31402 31403 31404 31405 31406 31407 31408 31409 31410 31411 31412 31413 31414 31415 31416 31417 31418 31419 31420 31421 31422 31423 31424 31425 31426 31427 31428
|
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 08:43:41 2023 -0500
Updates for 1.8 release.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 8 21:09:55 2023 -0500
Added note to NEWS about removal of paragraph formatters from mhn.defaults.
Thanks to Dave Fellow for pointing out this deficiency.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 7 19:55:55 2023 -0500
Updated date in mhbuild.man.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 7 19:39:23 2023 -0500
Removed mention of par and fmt from documentation.
They had been used in mhn.defaults to support repl with convertargs,
but dropped in favor of properly encoding the message content.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 5 19:37:50 2023 -0500
Updates for 1.8-RC3 release.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 5 19:32:22 2023 -0500
Changed set_mypath() to treat empty HOME the same way as unset HOME.
Also noted in mh-profile.man that a relative Path starts from the
user's home directory.
Thanks to Stephen Gildea and Alex Alexander Zangerl for motivating
this change and providing a patch.
Update to commit d8ca46fab.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 21 09:12:40 2023 -0500
Corrected version identifier to 1.8-RC2.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 21 09:02:16 2023 -0500
Updates for 1.8RC2 release.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 19 22:34:15 2023 -0500
Replaced egrep with grep.
To avoid build warning about obsolescent use of egrep.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 19 22:32:31 2023 -0500
Added etc/mh-chart.man dependency to etc/bash_completion_nmh.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 19 22:31:34 2023 -0500
Use .BR instead of .B to boldface the deprecation note in the Synopsis.
.B fooled etc/bash_completion_nmh-gen.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 16 12:36:42 2023 -0500
Added mention of removed features that had been deprecated in nmh 1.7.
And fixed a typo. Thanks to Mike Kupfer for pointing these out.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 15 13:32:11 2023 -0500
Initialize a few local variables to avoid compiler warnings.
gcc used for RedHat 7, 8, and 9 warned about these.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Jan 3 09:23:36 2023 +0000
docs/README.about: axe thanks to apache.org for snprintf().
Commit 3f05764b removed Apache's version, instead relying on the
platform to provide it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Jan 2 12:34:54 2023 +0000
man/burst.man: re-word to avoid ‘digestifying’, etc.
Otherwise they show up when spell-checking.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Jan 2 12:24:41 2023 +0000
man/scan.man: fix spelling of ‘separator’.
Spotted by Debian's Lintian. Fixes b852bee57.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Jan 2 12:36:05 2023 +0000
man/ali.man: lessen hanging indent so long paths have more room.
‘.TP 20’, a tagged paragraph with twenty ens for the tag, seems to be
commonplace but it is a lot of room for short tags which leaves less
room for a long path like ‘%nmhetcdir%/MailAliases’. Switch instead to
using the width of one of the longest tags plus two spaces.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Jan 2 11:10:20 2023 +0000
test-manpages: lower the ‘-Wbreak’ threshold from 32 to 31.
The available line length is 78, less an indent of 12 where mhbuild.man
refers to ‘replaliases’ and 34 for the prefix-less reference and one for
the full stop which leaves 31 for the prefix. Without this change,
ali.man and mhbuild.man failed the test when the prefix was 32 long.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jan 1 16:04:47 2023 +0000
man/*.man: fix options which didn't escape their hyphen.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jan 1 16:27:05 2023 +0000
NEWS: fix spelling of ‘MIME’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jan 1 16:26:31 2023 +0000
NEWS: add a link to Norm's Wikipedia page.
It shows he was more than just MH.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jan 1 16:13:02 2023 +0000
.gitignore: move ‘/configure~’ entry to correct section.
For whatever reason, .gitignore has a section for each cleaning Makefile
target but ‘superclean’ does not remove ‘/configure~’ so move it out of
that section.
Fixes bee25da0.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 1 11:15:21 2023 -0500
Updates for 1.8 release.
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Sat Dec 31 23:09:00 2022 -0500
Ignore configure tilde file
I guess you can sometimes have a configure~ file.
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Sat Dec 31 23:06:49 2022 -0500
Explicitly mark mhical.c as living in $(srcdir)
Because there is an explicit dependency for mhical.c, make sure
to reference it back to $(srcdir). This will ensure it works fine
when doing an object build (checked by "make distcheck").
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 17:18:09 2022 +0000
uip/mhlistsbr.c: switch some printf(3) for puts(3), and similar.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 16:39:56 2022 +0000
test/valgrind.supp: suppress memmove(3)-overlaps warning.
memmove()'s raison d’être is to handle an overlapping source and
destination.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 15:58:20 2022 +0000
uip/mhlistsbr.c: ditch ‘LSTFMT*’ macros.
Each macro defined a printf(3) format-string and was used only once.
Although this gathered the formats together, the reader saw ‘LSTFMT2b’
passed to printf() instead of a format string so it wasn't obvious what
formatting was occurring. This may be why mhlist(1) fails to document
all the effects of ‘-verbose’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 15:24:09 2022 +0000
test/valgrind.supp: suppress valgrind(1) on Manjaro's iconv_open(3).
The parameters passed to iconv_open() seem to be C strings so assume
it's a glibc problem.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 12:56:21 2022 +0000
uip/slocal.c: stop formatting NULL with ‘%s’ in debug.
glob() had a conditional debug print of a vars[] p_value but that can
still be NULL, e.g. for a name of ‘reply-to’, so explicitly test for
NULL and produce nice output.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 12:37:12 2022 +0000
uip/mhlsbr.c: replace strncpy() with strcpy(), silencing warnings.
The strncpy()s could leave the destination unterminated.
The source and destination char[] are the same size so strcpy() can't
cause problems.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 11:32:29 2022 +0000
uip/mhlsbr.c: fix overflow of char[] in parse().
The code still silently truncates the token but at least it doesn't
overflow the char[] by one when it does so.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 09:51:47 2022 +0000
test/*: replace egrep(1) with grep(1); regexp unchanged.
The Basic Regular Expression ‘^DTSTAMP:’ can be processed by grep.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Dec 30 09:49:30 2022 +0000
SPECS/nmh.spec: replace egrep(1) with ‘grep -E’.
Some egreps have started to spew brain-damage on stderr.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Dec 29 17:31:55 2022 +0000
uip/*.c: delete -check and -nocheck Content-MD5 field options.
Fixes 43d9833b which documented them as deprecated even though the
functionality had been removed, not marked for removal. The options
were retained but did nothing, misleading the user. Remove the options
so the user learns of the change.
Also remove ‘-nocheck’ from the DEFAULTS section of man pages; it had
already been removed from the SYNOPSIS. And a reference to RFC 1864
from mhbuild(1).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Dec 29 15:16:57 2022 +0000
uip/dropsbr.c: detect string truncation in mbx_copy().
Also avoids a memory allocation for the temporary string.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Dec 29 15:15:02 2022 +0000
sbr/dtime.c: use new ‘DCTIME_SIZEOF’ macro for string's size.
It also allows callers to avoid hard-coding ‘26’ too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Dec 28 13:21:34 2022 +0000
uip/popsbr.c: rework multiline() to have one string-copying line.
The incoming line needs copying to the destination, but without a
possible prefix of ‘.’. Instead of having two methods of copying, track
the first byte to copy and have a single overflow-checking abortcpy().
Also, restore the larger buffer size so the destination is the limit on
the line length.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Dec 28 12:59:03 2022 +0000
mts/smtp/smtp.h: fix misleading S_STARTTLS, ... TLS-flags.
The S_STARTTLS, etc., macros are bit masks but the definitions ran
1,2,3,4 rather than 1,2,4 because 3 was a mask of convenience for 1|2
except it wasn't defined using S_STARTTLS and S_INITTLS. The run of
1,2,3,4 suggested they were exclusive values where the next should be 5
rather than 8. Instead, re-order to 1,2,4,3 with the last being defined
in terms of the first two.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Dec 28 12:54:46 2022 +0000
mts/smtp/smtp.h: remove partial client() prototype in comment.
It's unclear if it's a commented-out early prototype or commentary which
continues in the next comment but if the latter it seems incorrect.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Dec 28 12:49:19 2022 +0000
sbr/datetime.c: have parse_datetime() return bool for success.
It was returning OK or NOTOK but this meant ‘if (parse_datetime())’
indicated an error whereas now that's ‘if (!parse_datetime())’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Dec 28 12:47:57 2022 +0000
uip/aliasbr.c: comment some of the data and functions.
The behaviour doesn't match the documentation and is surprising.
The comments were a first step in uncovering the oddness. More are
required.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Dec 28 12:37:47 2022 +0000
sbr/utils.c: rework scan_input() to return 0/-1 and bool.
Move commentary away from an ‘8-bit byte’ to ‘top-bit-set byte’ as
non-ASCII is what's meant. Change the pointer-argument from an int to a
bool.
The old code returned -1 or OK; the latter presumably isn't -1.
Instead, return -1 or 0 as is familiar for syscall-like functions.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 25 09:32:12 2022 -0500
Updated date in man pages that have recent significant changes.
Fix to commits ff3a66bb and 070d3ebc.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 22 19:50:42 2022 -0500
install-mh(1) now enables the mh-draft(5) draft folder facility.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 22 19:47:04 2022 -0500
Fixed `drafts` folder in mh-draft man page example.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 22 19:44:07 2022 -0500
Removed Draft-Folder profile component from send(1) man page.
Ralph pointed out that send doesn't use that component. Also,
changed description of Draft-Folder profile component to better
describe how it's used.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 19:47:39 2022 -0500
Marked Gmail OAuth2/XOAUTH support as being unsupported.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 16:53:07 2022 -0500
Increased _FORTIFY_SOURCE from 2 to 3 with gcc.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 16:51:08 2022 -0500
Replaced strncpy() with concat() to avoid gcc -Wstringop-truncation warning.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 16:48:35 2022 -0500
Replaced strncpy() with snprintf() to avoid gcc -Wstringop-truncation warning.
Also reduced size of buffer by 1 to avoid truncation warning.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 13:16:14 2022 +0000
sbr/strindex.[ch]: rename to ‘stringdex’ to match the function name.
The filenames had a consistent typo since their creation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 13:01:39 2022 +0000
sbr/ssequal.c: delete, altering calls to has_prefix() instead.
ssequal() had a large comment before it warning it didn't test if one
string was contained within the other, as claimed, but if one started
the other and that all callers needed checking to see if that was what
they wanted. Presumably, that is what they want after all this time.
Since has_prefix() does the same test and is better named, use that
instead. The differences are its parameters must not be NULL and
they are in the other order. Inspection of the parameters passed to
ssequal() shows none of them were ever NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 12:36:35 2022 +0000
sbr/globals.c: alter ‘ctxflags’ bit-set to ‘context_dirty’ bool.
There was only a single ‘CTXMOD’ bit used which indicated the in-memory
context had been modified. Also means the ‘DBITS "\020\01CTXMOD"’ to
format it can be removed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 11:51:42 2022 +0000
h/mh.h: remove ‘ALL’ macro used only by a few print_sw() calls.
Instead, document print_sw()'s parameters and behaviour.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 11:02:58 2022 +0000
all *.c: alter ‘== NOTOK’ to ‘== -1’ when testing syscall.
If the system call is defined to return -1 on error then test its return
value is equal to -1 rather than use ‘NOTOK’. This is idiomatic and
causes the reader no delay whereas ‘NOTOK’ has to be thought about.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 10:26:30 2022 +0000
all *.c: alter ‘!= NOTOK’ to ‘!= -1’ when testing syscall.
If the system call is defined to return -1 on error then test its return
value is not equal to -1 rather than use ‘NOTOK’. This is idiomatic and
causes the reader no delay whereas ‘NOTOK’ has to be thought about and
the double-negation of ‘not equal to not okay’ also hinders.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 13:49:41 2022 +0000
man/mark.man: explain how to ensure a sequence no longer exists.
Deleting a sequence which may not exist is a little obscure.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 11:54:27 2022 +0000
h/nmh.h: #include <strings.h> if HAVE_STRINGS_H for strcasecmp().
POSIX puts the prototypes for strcasecmp(3) and friends in <strings.h>
so #include it. Some C libraries also pollute <string.h> with them
which explains why the problem hasn't been noticed until now.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 10:58:21 2022 +0000
rcvtty.c, slocal.c: remove condition on #include-ing globals.h.
sbr/globals.h was only #include'd if HAVE_GETUTXENT was defined.
The #include was added in the wrong place due to using the last existing
wasn't noticed until Andy Bradford spotted it.
Fixes 472d87ae.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 4 21:05:36 2022 -0400
Added -fno-omit-frame-pointer to CFLAGS.
In anticipation of it being added in Fedora 37. Only used if CFLAGS
isn't already set.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 4 20:30:58 2022 -0400
Remove autom4te.cache before running autogen.sh.
Author: David Levine <levinedl@acm.org>
Date: Tue May 24 07:07:46 2022 -0400
Changed pseudoheader field value from "stage_1" to "unencoded".
This is for Nmh-check-text-encoding. It's more descriptive.
Author: David Levine <levinedl@acm.org>
Date: Mon May 23 19:01:45 2022 -0400
Removed db4-devel from Linux build-time package requirements.
Thanks to Ralph for pointing out that there is no db4-devel package.
Author: David Levine <levinedl@acm.org>
Date: Mon May 23 18:47:55 2022 -0400
Changed cppflags test to not always evaluate as false.
gcc 12 on Fedora 36 tripped over that and failed to add -D_GNU_SOURCE.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 30 08:49:54 2022 -0400
Added -O - to wget to put its output on stdout.
Fix to commit 1678e510cbc8c1eb0fd0b8e42bff75d5ba61b562.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 30 08:33:52 2022 -0400
Removed -O option from curl when output is fed to sh.
Fix to commit 1678e510cbc8c1eb0fd0b8e42bff75d5ba61b562.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 30 08:17:16 2022 -0400
Enable build_nmh -v and -y when run without a terminal.
This allows the script to be downloaded and fed to /bin/sh to easily
download nmh from the git repo, configure, build, and run the test suite.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 30 07:32:12 2022 -0400
Pass configure options, supplied after build_nmh options, to configure.
Also removed queries of whether to enable SASL and TLS. The logic
didn't properly handle negative replies. configure will enable
them if possible, so the queries weren't useful.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 27 22:26:03 2022 -0400
Cleaned up test summary display with build_nmh -v.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 23 15:39:09 2022 -0400
Added "quick build and test" section.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 23 15:36:53 2022 -0400
With -v, display test results summary.
For Ralph. And me, it's helpful when trying different configurations.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 22 08:19:46 2022 -0400
Fixed to build and test cleanly when configured without iconv(3).
Thanks to Andy Bradford for reporting on OpenBSD 6.9 amd64.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 22 07:17:48 2022 -0400
Changed timezone from +0000 to +0100.
To avoid result that could be either +0000 or -0000, as reported by Simon
on NetBSD 9.99.92.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 20 18:46:26 2022 -0400
Skip another test-mhfixmsg text if configured without a text browser.
The test is "use correct encoding for new text/plain part". Thanks
to Eric for reporting this.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 20 18:36:37 2022 -0400
Fixed test-mhical by setting TZ.
Merge: c62148ea f188de90
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Apr 20 11:42:20 2022 -0500
Merge commit 'f188de902b613110d5943210f212adb680a2b44a'
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Apr 20 17:25:12 2022 +0100
test/mhbuild/test-utf8-body: replace ‘en_US.UTF-8’ with found locale.
Assume the English locale found by require_locale() is good enough for
the test.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Apr 20 17:13:52 2022 +0100
test/*: pass en_GB as well as en_US locales to require_locale().
Define a shell variable ‘en_locales’ to hold a list of common English
locales and use that in the test scripts in place of a duplicated list
of US-only locales.
A placeholder change as a temporary fix; require_locale()'s logic may be
changing following nmh-workers discussion.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jun 12 14:45:24 2021 +0100
sbr/fmt_new.c: report search-result path used in new_fs() errors.
etcpath() is used to find a file in one of several places and the file
is then processed. Errors should use the path used for the file
operations, not the original search term as that can be ambiguous.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jun 12 14:39:38 2021 +0100
sbr/error.c: only print errno in advertise() if it's non-zero.
The strerror(3) for an errno of zero is often confusing in an error
message.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Jun 10 11:32:27 2021 +0100
sbr/addrsbr.c: change ‘eai’ from int to bool.
Also affects getadrx()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 22:55:49 2021 +0100
uip/flist.c: hoist num_digit() calls out of double-nested loop.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 21:15:03 2022 -0400
Documented build instructions for Solaris 11.4 with gcc.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 21:14:33 2022 -0400
Use paste(1) instead of tr(1) to remove trailing newlines.
sed(1) on Solaris doesn't like being fed input that doesn't end
with a newline.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 21:14:00 2022 -0400
Map pidstatus of 255 to 1 in test-exec.
That status is 255 on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 21:12:46 2022 -0400
Rearranged code so that environment doesn't have to be overridden.
This allows the test to pass on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 21:11:23 2022 -0400
Remove any existing packed message file so it doesn't interfere with test.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 20:52:03 2022 -0400
Wait for annotiations to be applied.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 17 20:51:06 2022 -0400
In mhfixmsg-format-text/html, with lynx, remove last line if blank.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 18:04:06 2022 -0400
Made some comparisons in test-mhfixmsg less strict.
They depended on how decoding was done.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 18:02:03 2022 -0400
Fixed C-T-E of new added text/plain parts.
Also wrapped charset with "" if not already wrapped.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 18:01:02 2022 -0400
Replaced LEN()+1 with sizeof so that mktemp.c can be compiled outside nmh.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 17:58:28 2022 -0400
Cast a dpt to char * because it might be a void *.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 17:57:18 2022 -0400
Added an NMH_USED for unused argument without MIMEENCODINGPROC.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 9 15:25:40 2022 -0400
Don't use -fstack-clash-protection on Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 9 15:10:13 2022 -0400
Changed encoded HTML text in test.
w3m(1) on Cygwin translated é to e'.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 9 10:37:28 2022 -0400
Added a few bytes to test/mhbuild/tiny.jpg.
Without them, Cygwin file(1) didn't properly detect the file type.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 9 10:35:46 2022 -0400
Replace deprecated autoconf parameters. Clean now with autoconf 2.71.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 9 10:33:50 2022 -0400
Copy if hard link by refile(1) or send(1) fails with EACCES [Bug #56575].
The bug was for refile(1) but send(1) can also try to hard link.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 6 19:00:13 2022 -0400
Detect other files regardless of backup prefix [Bug #49476].
Files starting with comma are no longer ignored regardless of BACKUP_PREFIX.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 3 18:36:40 2022 -0400
Decode RFC 2047-encoded subject when replying.
Thanks to M. Levinson for the replsbr.c patch.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 27 17:41:19 2022 -0400
Allow editing of draft with repl -convertargs prior to encoding text.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 27 17:24:43 2022 -0400
Reworked remove_header() to properly handle removal of first header.
Fix to commit 5c70c34e95312077e7af2e321b143562191ffaa6.
Thanks to Ralph for reporting the deficiency with this new function.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 13 20:57:41 2022 -0400
Added remove_header() function.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 13 20:53:54 2022 -0400
Removed note about possibly changing slocal +folder in the future.
Thanks to Thomas Dupond for pointing out the note.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 6 08:45:07 2022 -0500
Fend against strdup of NULL addr.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 6 08:42:30 2022 -0500
Treat return value of checkmimeheader() as bool consistently.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 6 08:41:04 2022 -0500
Fixed date on mhfixmsg man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 27 10:54:05 2022 -0500
Changed interpretation of argument to mhfixmsg -decodeheaderfieldbodies.
The switch argument now specifies the character set of the decoded field
bodies.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 26 13:38:01 2022 -0500
Fixed mhfixmsg(1) -decodeheader to support mixed encoded/undecoded.
Reported by Steven Winikoff.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 21 11:25:48 2022 -0500
Added note about setting dcoument.codepage.assume with elinks.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 20 17:20:51 2022 -0500
Enhanced mhfixmsg -decodeheaders to decode any charset.
1. Attempt to decode the body, given any encoding.
2. If unable to decode or if any NUL octets in the decoded text,
leave the body encoded. If unable to decode, that's allowed by
RFC 2047 § 6.2. If any NULs, that seems to be in the same spirit.
A second planned enhancement is to allow decoding to any character
set. Currently, it decodes to the charset of the user's locale.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 14 06:50:34 2022 -0500
Use grep instead of fgrep.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 13 13:43:45 2022 -0500
Don't use par 1.52-i18n in mhn.defaults. Attempt to use fmt instead.
par 1.52-i18n has caused insidious problems with some character
encodings. It uses a patch that was not written by par's author.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 13 13:26:51 2022 -0500
Removed special case for programs in /usr/local/bin.
Full paths in mhn.defaults help avoid surprises when a user's PATH is
different from that used when nmh was installed, and when a program is
moved or removed.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 13 11:28:17 2022 -0500
Replaced use of touch -d with touch -t.
touch(1) on Mac (Catalina 10.15.7) doesn't support -d.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 12 11:49:16 2022 -0500
Added --really-quiet to mpv in mhn.defaults.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 12 08:08:31 2022 -0500
Use full paths for par, fmt, and iconv in mhn.defaults.sh.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 9 07:16:16 2022 -0500
Added start_test lines.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 6 11:37:22 2022 -0500
Fixed charset determination code.
Fix to commit 41ce4490ac5d5c6a25240c4101cacefa16d885eb.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 6 10:47:11 2022 -0500
Fixed mhfixmsg charset determination of content added with -reformat.
Reported by Steven Winikoff on message with ISO-8859-1 content that
was erroneously converted to UTF-8 twice.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 6 10:41:10 2022 -0500
Added encoding() function.
By exposing the code that was already in sbr/mime_types.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 6 10:39:12 2022 -0500
Added -display_charset utf-8 to lynx in mhn.defaults.
Only for mhfixmsg-format-text/html.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 5 09:35:37 2022 -0500
Suppress verbose message reporting conversion to same charset.
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Fri Feb 4 21:24:24 2022 -0500
Change the header file location so object builds work
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Fri Feb 4 21:21:34 2022 -0500
Perform better matching for EHLO keywords
Previously we would look for EHLO keywords based on matching the
prefix, but this caused to to match "AUTH=" when looking for "AUTH".
Tighten up the match algorithm so we only match on a full keyword.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 30 09:26:44 2022 -0500
Updated mhshow(1) helper applications from Old to New as shown below.
[app1, app2, ... appN] shows the order that mhn.defaults.sh uses
when looking for the helper for the specified content type and
optional subtype.
Support for audio content is only added if /dev/audioIU or /dev/audio
exists.
Old helper appplications
========================
[acroread, okular, evince, xpdf, gv]: application/pdf
[okular, evince, gv]: application/postscript
[ivs_replay]: application/x-ivs
[soffice]: application/msword
[splayer, raw2audio, cat >/dev/audio]: audio/basic
[adpcm_dec, play]: audio/x-next
[xv, netpbm + djpeg + xwud]: image
[w3m, lynx, elinks]: text/html
[richtext, rt2raw]: text/richtext
[mpeg_play]: video/mpeg
Changes:
1. replaced use of netpbm with mpv --keep-open, preferring mpv over xv
2. replaced mpeg_play with [mpv, mplayer] for video (not just video/mpeg)
3. moved acroread to end of application/pdf list
4. removed application/x-ivs support
5. removed text/richtext support
6. added mhshow-suffix-video.mp4 to mhn.defaults
New helper appplications
========================
[okular, evince, xpdf, gv, acroread]: application/pdf
[okular, evince, gv]: application/postscript
[soffice]: application/msword
[splayer, raw2audio, cat >/dev/audio]: audio/basic
[adpcm_dec, play]: audio/x-next
[mpv --keep-open, xv]: image
[w3m, lynx, elinks]: text/html
[mpv, mplayer]: video
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Jan 8 15:48:30 2022 -0600
Fix time-zone-based variance in tests.
The test added to test-mhical in commit 1d0eeee73 only passed in time
zones where 2015-01-05 is 5 hours behind UTC (e.g. America/New_York).
* test/common.sh.in: Override TZ to UTC+0.
* test/mhical/test-mhical: Adapt to UTC.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Jan 8 15:36:22 2022 -0600
Always include headers in sbr using root-relative path.
Just two files had just 3 exceptions, where a sbr header was included without
the 'sbr/' prefix.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Jan 8 15:35:00 2022 -0600
Stop implicit conversion from int to float.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Jan 8 15:34:30 2022 -0600
Include <signal.h> for sigset_t and friends.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 15 19:42:12 2021 -0500
Fixed allowable MIME message encodings to get closer to RFC 2046.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 15 19:37:03 2021 -0500
Changed a test name to be unique.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 15 19:23:19 2021 -0500
Added -a option to build_nmh to analyze with Clang static analyzer.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 15 19:21:57 2021 -0500
Removed all traces of FT_LITF format type.
There was no format specifier to make use of it.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 22:05:08 2021 -0500
Removed dead nested assignments reported by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 21:56:45 2021 -0500
Removed unused fdopen() of temporary file fd.
Resolves dead nested assignment reported by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 21:45:52 2021 -0500
Removed unused open() of message file.
Resolves dead nested assignment reported by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 12:30:32 2021 -0500
Removed binary files that shouldn't have been committed.
Fix to commit 3b920ec86.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 10:17:36 2021 -0500
Removed unused assignment of local variable c.
Resolves dead nested assignment reported by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 10:04:08 2021 -0500
Check result of send_imap_command() call and return NOTOK on failure.
Resolves dead assignment reported by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 10:00:58 2021 -0500
Removed final assignment to local startoffset.
Resolves dead assignment reported by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 09:57:35 2021 -0500
Removed two assignments to local rc.
Resolves dead assignment and dead nested assignment reported by
Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 09:47:58 2021 -0500
Replaced redundant string literal and removed unused local variable.
Resolves dead initialization and dead nested assignment reported by
Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 09:40:36 2021 -0500
Moved *.plist from CLEANFILES and MAINTAINERCLEANFILES to clean-local.
*.plist are directories so they need to be removed with rm -r.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 09:33:36 2021 -0500
Updated thirdparty/jsmn to its commit 25647e692.
jsmn is now entirely within a header file, so removed jsmn.o from libmh.a.
jsmn_parse() return type was changed from jsmnerr_t to int.
jsmn repo was moved from mercurial to git.
Added thirdparty/README-jsmn.txt to track git version.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 11 08:09:34 2021 -0500
Move local buffer to static storage.
This resolves bug found by Clang Static Analyzer of stack address
stored into global variable.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 9 21:17:03 2021 -0500
Added assert()'s that specific pointers are non-NULL.
That suppresses report of possible null pointer dereference by Clang
Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 9 21:14:57 2021 -0500
Added NORETURN to compile_error() declaration.
That suppresses report of possible null pointer dereference by Clang
Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 9 21:13:14 2021 -0500
Avoid possible dereference of null pointer by checking for null.
Found by Clang Static Analyzer.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 8 21:46:40 2021 -0500
Removed free(3) call on memory that is used later.
Resolves use-after-free bug found by Clang Static Analyzer. The
memory is used in a die() call so the leak is benign.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 8 21:41:07 2021 -0500
Protect against passing null to argument with 'nonnull' attribute.
Resolves potential bugs found by Clang Static Analyzer. The one in
slocal.c is a false positive; adding an assert() got rid of that.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 8 21:27:31 2021 -0500
Ensure that getpwnam(3) is called with non-null argument.
Fix to commit cd2c6750f. Ralph discovered that a null argument
would cause a seg fault. Clang Static Analyzer detected it, too.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Jul 29 09:46:16 2021 -0400
Better warning about using locking in rcvstore.man
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 20 18:22:38 2021 -0400
Fixed display of iCalendar object with multiple VEVENTS using a VTIMEZONE.
Thanks to Ralph for reporting the bug, with a very detailed analysis.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon May 31 12:51:37 2021 -0400
Correct typo in sortm.man, which affected formatting
Author: David Levine <levinedl@acm.org>
Date: Tue May 25 21:33:10 2021 -0400
More rework of etcpath() and its test.
Fix to commit 20702cc3. Thanks to Ralph for pointing out
deficiencies in that commit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:39:16 2021 +0100
uip/popsbr.c: replace TRUNCCPY() with ABORTCPY() in multiline().
If the full line from the server can't be returned because the buffer is
too small then abort. It shouldn't be possible with the current sizes
of the two buffers involved.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:36:53 2021 +0100
uip/popsbr.c: replace trunccpy() with abortcpy() for SASL mechanisms.
Don't continue if the SASL capability mechanisms can't be fully copied
for later parsing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:33:17 2021 +0100
uip/mhstoresbr.c: replace trunccpy() with abortcpy() for ‘%f’ expansion.
When expanding a storage string, a truncated filename shouldn't proceed
through the system.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:31:49 2021 +0100
uip/mhshowsbr.c: replace trunccpy() with abortcpy() for ‘%f’ expansion.
When expanding a display string, a truncated filename shouldn't proceed
through the system.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:27:08 2021 +0100
uip/mhbuildsbr.c: replace trunccpy() with abortcpy() for ‘%f’ expansion.
When expanding a composition string, a truncated filename shouldn't
proceed through the system.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:04:28 2021 +0100
sbr/seq_list.c: replace trunccpy() with abortcpy() in seq_list().
For truncation to occur, MAXBUFFER must be too small to hold the current
message.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 11:07:02 2021 +0100
uip/popsbr.c: replace trunccpy() in pop_init() with TRUNCCPY().
Fixes 7f565b90.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 10:55:51 2021 +0100
sbr/path.c: replace will-never-truncate TRUNCCPY() with memcpy().
No truncation can occur because the source's length is obtained with
strlen() before the TRUNCCPY() and explicitly checked against the
destination's size in order to give an explicit stderr warning. As the
source length is known and it will fit, just memcpy the bytes rather
than use TRUNCCPY() which will duplicate finding the string's length.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 10:59:35 2021 +0100
uip/imaptest.c: replace mh_xmalloc() and trunccpy() with xmemtostr().
parse_capability() takes a pointer to a run of char and their length; they
may not be NUL-terminated. The code was and still does copy them into
newly malloc'd memory and appends a NUL. The copy was using trunccpy()
knowing it would copy all the needed source bytes before stopping as no
source NUL was found and putting its own NUL at the end, but that's a bit
obscure and duplicates effort as the number of bytes to copy is known.
Instead, use the new xmemtostr() to replace both calls. It also has
the advantage of spotting an overflow of the length, say when pointer
arithmetic produces -1 AKA SIZE_MAX without which the bytes would be
copied to mh_xmalloc(0).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 10:16:11 2021 +0100
sbr/utils.c: add xmemtostr() to malloc string from run of bytes.
Copies the source bytes into a new destination sized for them plus a
terminating NUL which it appends.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 13:53:56 2021 +0100
sbr/escape_addresses.c: replace literal tab in string with ‘\t’.
Makes it easier to observe and removes the risk of erroneous switch to
one or more spaces.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 13:56:34 2021 +0100
uip/flist.c: replace literal tab in string with three spaces.
A string of spaces was being printed in lieu of ‘ (private)’ to maintain
columnar output. This was changed, probably by a faulty editor
configuration, to replace the initial spaces with a tab character.
The source code's layout didn't change, but the tab isn't sufficient to
keep the columns aligned in flist's output.
Fixes e491542d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 14:23:11 2021 +0100
sbr/seq_print.c: delete preprocessed-out code; no longer used.
Commit 31441ee8 commented it out but it still remains in git-grep(1)'s
output, etc., and also hides that seq_printall() and seq_print() were
removed in the commit's diff.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 10:26:38 2021 +0100
uip/folder.c: don't copy folder name just to tack a ‘+’ on the end.
Instead, print the ‘+’ or ‘ ’ as part of the format string in one of
two printf()s. Avoids a TRUNCCPY() or snprintf() to a fixed-size buffer.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 25 11:50:39 2021 +0100
uip/flist.c: fix left-alignment of current folder ‘+’.
The padding with spaces of the folder name to make it left-justified
in a column was between the folder name and the ‘+’ to mark the
current folder.
Fixes 2df6d337.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 23 14:32:39 2021 +0100
sbr/utils.c: add abortcpy() which prefers to abort than to overflow.
This is the partner to trunccpy(). If truncation is valid, e.g. passing
on the first part of a long string in an error message, then trunccpy()
should be used instead of strncpy(3). Else abortcpy() should be used
as it will abort(3) rather than overflow the destination or leave the
destination not terminated.
(strncpy() is rarely wanted as its NUL-padding is only useful to pad
fixed-width fields, e.g. an old 14-byte filename which sits alongside
the 16-bit inode number in a directory entry.)
The creation of abortcpy() and its environment-variable workaround was
discussed on nmh-workers around 2016-10-29, in particular message-ID
<20161029214059.1046247BE8@pb-smtp2.pobox.com> at 21:40:58 UTC.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 23 12:27:32 2021 +0100
uip/flist.c: hush compiler by using int for precision specifier.
size_ts were used for tracking the length of strings and the maximum
seen, but printf(3)'s ‘*’ precision-specifier requires an int.
Instead of adding a cast, assign strlen(3)'s size_t return value to an
int as it's unlikely a folder or sequence name will ever exceed INT_MAX.
Also, using ‘i = strnlen(s, INT_MAX)’ in addition would just confuse.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 23 12:16:24 2021 +0100
uip/flist.c: don't copy folder name just to tack a ‘+’ on the end.
Instead, print the ‘+’ or ‘ ’ as a separate ‘%c’ format specifier.
Avoids a TRUNCCPY() or snprintf() to a fixed-size buffer.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 23 11:55:26 2021 +0100
uip/mhfixmsg.c: hush compiler by enlarging snprintf() destination.
Alter the destination array's definition to use sizeof on a string
constant which shows the maximum which could be produced. Don't use
stdint.h's SIZE_MAX in the string as that comes with extra noise like
a trailing ‘UL’ and parenthesis.
A size_t is being printed so use ‘%zu’ rather than cast to unsigned.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 23 11:26:44 2021 +0100
sbr/netsec.c: hush compiler by replacing fprintf() with fwrite().
A printf(3) precision-specifier of ‘*’ takes an int but an unsigned was
being passed. Given the intent of ‘"%.*s\n", outlen, snoopoutbuf’ was
to write outlen bytes of snoopoutbuf and a linefeed, replace it with an
fwrite() and putc(). Examining the code shows no NUL is expected in
snoopoutbuf within its first outlen bytes so using ‘%s’ is a bit
misleading in isolation to the reader and makes more work for stdio.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 21 22:46:50 2021 +0100
uip/mkstemp.c: if advise() is available then use it.
Also, return ASAP on error so the main body of the function isn't
conditional.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 21 22:38:51 2021 +0100
all *.c: hush compiler by passing unsigned for ‘%x’ and similar.
The printf(3) family expect an unsigned integer for ‘%x’ so ensure they
get it to stop the compiler warning that a signed is being passed. Each
case was considered rather than just mechanically adding a cast to
‘unsigned’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 18 14:34:42 2021 +0100
uip/mkstemp.c: use memcpy(3) instead of strncpy(3) to hush compiler.
strncpy() was being used to copy the source string apart from its
terminating NUL, and sometimes the source string could be empty so the
destination wouldn't be written at all; gcc noticed.
The length to copy is known, there is no risk of stopping early on an
unexpected NUL, so use memcpy() to clarify intent.
Also, avoid copying the NUL of prefix[].
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 17 16:00:01 2021 +0100
uip/popsbr.c: replace a strncpy(s, …, sizeof s) with TRUNCCPY().
It silences a compiler warning and it's likely the buffer is expected to
be NUL terminated based on nearby code.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 17 15:58:50 2021 +0100
test/runpty.c: add function attributes to die() to silence warnings.
Added attributes ‘__noreturn__’ and ‘format(printf)’ if gcc is recent
enough to support them. Copies h/mh.h's logic.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 17 14:03:05 2021 +0100
all *.c: join lines ‘}’ and ‘else’ into one: ‘} else’.
That seems to be the predominant style and there were only a few left
which put the ‘else’ under and aligned with the ‘}’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 17 13:45:30 2021 +0100
uip/mhlsbr.c: fix indentation in putcomp().
Faulty since RCS revision 1.1 of
docs/historical/mh-6.8.5/uip/RCS/mhlsbr.c,v.
Author: David Levine <levinedl@acm.org>
Date: Mon May 17 20:48:23 2021 -0400
Reworked etcpath() to not modify its argument at all.
Added mhparam/test-etcpath. Update to commit 56a0febb.
Author: David Levine <levinedl@acm.org>
Date: Sun May 16 23:01:49 2021 -0400
Fixed etcpath(~/file) case.
Update to commit 9fc12a25.
Author: David Levine <levinedl@acm.org>
Date: Sun May 16 22:16:16 2021 -0400
sbr/path.c: reworked etcpath() of paths that start with ~.
The initial motivation was to clean up a couple of warnings with
-Wstringop-overflow from gcc 11 with optimization enabled. For
an input of ~user/file when that user does not exist, the old code
would restore the first '/' after having removed it earlier, to
isolate ~user. Changed the code to not remove it if that user
doesn't exist.
Added test that exercises that code to test/mhical/test-mhical.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 18:11:48 2021 +0100
uip/popsbr.c: use trunccpy() instead of strncpy() when copying errstr.
Silences compiler warning, and saves padding response with many NULs.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 17:50:04 2021 +0100
test/server.h: hold list of externs matching test/server.c.
Remove those externs from test/fake*.c. Silences compiler warning on
test/server.c when added to its #includes.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 17:43:23 2021 +0100
h/mh.h: move DBITS macro to uip/mark.c which is the only user.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 17:34:38 2021 +0100
config/version.h: hold list of externs matching config/version.c.
Remove those externs from h/mh.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 17:21:55 2021 +0100
sbr/globals.h: hold list of externs matching sbr/globals.c.
Remove those externs from h/mh.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 16:36:46 2021 +0100
sbr/globals.c: remove unneeded #include statements.
Also correct first-line comment after rename from config.c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 16:21:16 2021 +0100
config/config.c: rename to sbr/globals.c.
It only contains definitions of global variables and its existing name
blocks an ‘extern’ version of it because config.h is created by the
configure script. The externs are mainly in h/mh.h with a few missing
ones scattered amongst the C files which use them.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 16:18:31 2021 +0100
sbr/dtimep.l: add missing prototype for dtimep_yyunput().
The function is never called; it just exists to be a caller for
yyunput() thereby silencing the compiler. But now the compiler is
complaining about dtimep_yyunput() so place a prototype immediately
before the definition. Fixes 4dd01e6c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 16:12:45 2021 +0100
sbr/readconfig.c: correct prototype for checkconfig().
It was missing a list of parameters and should have stated ‘void’.
Fixes 1c03fa9d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 16 16:14:20 2021 +0100
sbr/dtime.c: fix potential buffer overflow in dasctime().
tzbuffer[DTZ_BUFFER_SIZE] was one too small because the first element
holds a space character before the main data starts. Fixes 6c8263b2.
Author: David Levine <levinedl@acm.org>
Date: Sun May 16 09:37:26 2021 -0400
uip/popsbr.c: replaced strncpy() with trunccpy().
To avoid warning from gcc 11 with optimization about truncation.
Author: David Levine <levinedl@acm.org>
Date: Sun May 16 08:52:30 2021 -0400
Added -snoop to post(8) man page synopsis.
It was already covered in the description.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:58:45 2021 +0100
uip/mhbuild.c: make global ‘listsw’ a build_mime() parameter.
Removes a global variable and the need for an extern in the other file
which uses it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:43:30 2021 +0100
uip/sendsbr.h: add extern for ‘pushsw’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:39:37 2021 +0100
uip/sendsbr.h: add extern for ‘unique’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:37:34 2021 +0100
uip/sendsbr.h: add extern for ‘inplace’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:32:35 2021 +0100
uip/sendsbr.h: add extern for ‘forwsw’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:30:50 2021 +0100
uip/sendsbr.h: add extern for ‘verbsw’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 15:16:44 2021 +0100
uip/mhbuild.c: make global ‘contentidsw’ a build_mime() parameter.
Removes a global variable and the need for an extern in the other file
which uses it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 14:52:03 2021 +0100
uip/mhbuild.c: make global ‘rfc934sw’ an extra build_mime() parameter.
Removes a global variable and the need for an extern in the other file
which uses it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 14:35:45 2021 +0100
uip/viamail.c: make switch statement a ternary operator.
If sendsbr()'s return values aren't being checked against all the
possible values then only a return of ‘OK’ matters for determing the
process's exit status of 0 or 1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 14:05:51 2021 +0100
sbr/fmt_scan.h: add extern for ‘fmt_mnull’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 14:00:57 2021 +0100
uip/sendsbr.h: add extern for ‘distfile’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:56:58 2021 +0100
uip/sendsbr.h: add extern for ‘annotext’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:55:40 2021 +0100
uip/sendsbr.h: add extern for ‘altmsg’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:51:27 2021 +0100
uip/popsbr.h: add extern for ‘response’ to replace ones in C files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:48:44 2021 +0100
uip/ali.c: move extern for ‘akahead’ to uip/aliasbr.h.
An extern in a C file is a bad smell as it may not match the
declaration in a separate C file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:48:18 2021 +0100
uip/mhparam.c: remove unused extern for ‘spoollocking’.
Author: David Levine <levinedl@acm.org>
Date: Sat May 15 09:24:42 2021 -0400
charstring.c: trailing NUL, not NULL.
Author: David Levine <levinedl@acm.org>
Date: Sat May 15 09:14:19 2021 -0400
sbr/oauth_prof.c: Removed redundant NUL termination.
Commit d4e8eb57 replaced preceding snprintf() with trunncpy(),
which ensures NUL termination.
Author: David Levine <levinedl@acm.org>
Date: Sat May 15 09:07:39 2021 -0400
Use curl_free() instead of free() on output of curl_easy_escape().
Author: David Levine <levinedl@acm.org>
Date: Sat May 15 08:57:16 2021 -0400
uip/viamail.c: Added default case to prevent uninitialized 'status'.
Update to commit d99ed382.
Author: David Levine <levinedl@acm.org>
Date: Sat May 15 08:36:13 2021 -0400
Initialized local variable 'host' to silence clobber warning.
The warning occurred with gcc 11 and optimization enabled.
Author: David Levine <levinedl@acm.org>
Date: Sat May 15 08:34:53 2021 -0400
Fixed comment to say trailing NULL instead of newline.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:03:56 2021 +0100
docs/README.developers: after a release, repology.org may be useful.
It gives an overview of who is shipping what.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 13:01:40 2021 +0100
docs/README.developers: remove declaration the topics are alphabetical.
They weren't, and it didn't make much sense to re-order them.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 11:54:26 2021 +0100
docs/README.developers: add warning about exit(3)ing above 125.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 11:49:30 2021 +0100
docs/README.developers: change ‘Notify nmh-users’ to nmh-workers.
Not sure what nmh-users is, but the main place for conversation is the
nmh-workers mailing list.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 11:48:51 2021 +0100
docs/README.developers: make check-list unnumbered, reducing diff noise.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 12:48:54 2021 +0100
man/whatnow.man: review the list of whatnow's commands.
- Make formatting consistent.
- Use sentences to clarify the border between command and description.
- Avoid the recursive definition of ‘ls’ by stating ls(1) is used.
- Be explicit that ‘cd’ doesn't change a future ‘edit’s directory.
- Spell out the effects of ‘alist’s options.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 12:17:08 2021 +0100
man/whatnow.man: remove large indent from ‘.TP’.
It's abnormal in a man page and the indent wasn't large enough to make
two distinct columns as ‘detach’ overflowed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 10:42:20 2021 +0100
all *.[ch]: turn ‘debugsw’ from int to bool to match its values.
Some library routines expect a global ‘debugsw’ to exist thus many
programs have to define it. They all agreed on using int but it was
only ever tested for truthness and its value ignored. Switch it to
being a bool for clarity. This removes the possibility of having a
higher level of debug but if that's needed then the whole area needs
reworking anyway, as an existing comment or two says.
The parameter to a few list_...() functions changes too as ‘debugsw’ is
passed to them and then used by them as a Boolean.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 10:32:59 2021 +0100
uip/mh*.c: remove unneeded ‘extern int debugsw’; not used.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 10:14:48 2021 +0100
uip/whatnowsbr.c: turn ‘pushsw’ and ‘pushed’ from int to bool.
They are only used as Booleans.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 09:47:04 2021 +0100
uip/repl*.[ch]: turn ‘querysw’ from int to bool to match its values.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 15 09:45:23 2021 +0100
uip/mh*.c: turn ‘nomore’ from int to bool to match its values.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 14 22:41:57 2021 +0100
uip/viamail.c: make the exit(3) status more clearly 0 or 1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 13 16:17:42 2021 +0100
.gitignore: add ‘/config.cache’, cleaned by Makefile's ‘distclean’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 13 13:54:41 2021 +0100
sbr/fmt_rfc2047.c: change decode_rfc2047() to return bool not int.
It was already returning 0 or 1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 13 13:46:20 2021 +0100
sbr/path.c: add set_mypath() to factor out repeated code.
set_mypath() sets the existing global ‘mypath’ which really holds
the home-directory's path. As getenv(3) and getpwuid(3)'s result
can be invalidated by further library calls, a value they return is
mh_xstrdup()'d; not all the old bits of code replaced by a call to
set_mypath() were doing this.
Also add more explicit error messages if set_mypath() has trouble
finding the home directory's path.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 13 13:01:59 2021 +0100
sbr/error.c: improve comments as the glut of routines still confuses.
In particularly, the subtlety that an non-NULL but empty ‘what’
parameter to advertise(), or one of the many routines which calls it,
triggers the printing of errno(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 13 12:39:14 2021 +0100
man: use matching sexy pairs of single quotes for ‘’ output, not ’’.
Author: David Levine <levinedl@acm.org>
Date: Wed May 12 21:10:31 2021 -0400
Document that mhn.defaults is fallback if MIMETYPEPROC fails.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 12 13:34:49 2021 +0100
Makefile.am: remove commit hashes from ChangeLog and fix non-UTF-8.
Add ‘--no-color’ to git-log(1) to ensure the user's preference doesn't
introduce escape codes into the output. Use sed in the C locale to
delete the commit hashes and fix the ISO-8859-1 ‘ü’ in uip/slocal.c's
log.
Partially reverts 9fd3638e and restores behaviour targeted by 44ca45ed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 12 16:38:33 2021 +0100
all *.c: replace snprintf(a, alen, "%s", s) with trunccpy(a, s, alen).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 12 13:25:40 2021 +0100
all *.c: replace snprintf(a, sizeof a, "%s", s) with TRUNCCPY(a, s);
The end result is the same given trunccpy()'s behaviour, and the macro
means there's no need to check sizeof's operand is the destination
array. Similarly change snprintf(a, sizeof a, "constant"), with the
bonus of not searching through a string for a %-format specifier.
Author: David Levine <levinedl@acm.org>
Date: Tue May 11 20:05:03 2021 -0400
Leave commit hashes in ChangeLog.
With newer git, the yellow commit hashes slipped by the grep anyway.
And grep tripped over an ISO8859 ü in the slocal.c log.
Author: David Levine <levinedl@acm.org>
Date: Tue May 11 20:04:44 2021 -0400
Added curly braces to conditional in ADDCHR2 macro.
This silences the gcc 11 -Wdangling-else warning. In this case,
the warning was overly aggressive, but the braces don't hurt.
Author: David Levine <levinedl@acm.org>
Date: Tue May 11 19:48:15 2021 -0400
Don't free the result of an etcpath() call.
Instead, changed etcpath() to always return its static storage
rather than sometimes returning dynamically allocated memory.
Fix to commit 85aebdf30. Thanks to Valdis for tripping over it,
investigating it, and providing a detailed report.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 10 15:54:06 2021 +0100
sbr/fmt_rfc2047.c: avoid buffer overflow when iconv(3) not used.
If iconv(3) is available then when the available space in the caller's
output buffer reached zero, measured by ‘dstlen’, decode_rfc2047()'s
ADDCHR2() macro would jump to the ‘iconvbuffull’ label which would do
nothing if iconv() wasn't needed for the character set allow the loop to
continue past the end of the buffer.
The fix is to spot iconv isn't being used and jump to the normal
‘buffull’ label.
This was causing mhl(1) to SIGSEGV on an email with lots of Subject
fields where the total field values needed more than the 8Â KiB buffer to
display them all as one Subject field.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 10 15:19:43 2021 +0100
sbr/fmt_rfc2047.c: fix buffer overflow due to ADDCHR2() not being used.
The existing ADDCHR2() macro appends a byte to the buffer at ‘q’ and
then detects that byte filling the buffer's last free element by a
parallel count of the space remaining reaching zero. But the value of a
quoted-printable byte, e.g. ‘=42’ for ‘B’, was being stored with ‘*q++’,
without decrementing the space remaining and bypassing the check for
exhaustion. This meant further writes continued pass the end of the
buffer until ADDCHR2() was used which wrote one overflowing byte of its
own, decremented the space-remaining count from one to zero, and treated
the buffer as full. Overall, memory corruption of what followed the
caller's buffer results.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 9 14:15:35 2021 +0100
sbr/context_find.c: simplify context_find_by_type()'s logic.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 9 10:32:30 2021 +0100
uip/mhparse.c: fix SIGSEGV when ‘<#’ content-type has missing slash.
If the content-type line being parsed by get_ctinfo() was a ‘#<’
directive and didn't have a slash after the content-type's type then no
subtype had to be supplied and ci_subtype was left unaltered.
user_content() initialises ci_subtype to zero bytes which is typically
a NULL pointer before calling get_ctinfo() and, later, build_headers()
calls strlen(ci_subtype) without checking if it may be NULL first,
causing the SIGSEGV.
get_ctinfo() is given a string to parse with the leading directive
stripped off, e.g. ‘begin’ instead of ‘#begin’. It complained
of a missing type on ‘’ and a missing subtype on ‘foo/’ because
the slash indicated a subtype should follow, but ‘foo’ was returned
as the type with a NULL subtype to allow for ‘begin’, etc. Instead,
explicitly test for the three directives which don't require a slash,
i.e. ‘forw’, ‘begin’, and ‘end’, and otherwise report a
missing-slash error.
This area has changed before. If the slash was missing then mh-6.8.5's
uip/mhn.c 1.1 complained, assuming no ‘magic’ mode. In 1.2, it
changed to setting subtype to an empty string if not in magic mode and
always skipping attempting to parse any subtype; the old error message
had been preprocessed out. The final change was in 2.0 where the error
message was removed and the existing logic tidied.
Add some initial tests of ‘#<’ parsing by mhbuild, including the
slash being missing. Much more is required.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 9 10:29:56 2021 +0100
uip/mhparse.c: fix indentation in get_comment()'s case statement.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 8 13:52:09 2021 +0100
uip/mhbuildsbr.c: rename do_direct() to directive_honour().
Because ‘direct’ is a word which means ‘direct’ to me; not ‘directive’.
mhbuild(1) uses ‘honour’. Also, rename directive_onoff() to
directive_push() to mirror directive_pop().
And generally tidy the ‘#’-directive functions:
- They were already static so move them below the non-static functions,
adding prototypes, as they're not the first thing to see when reading
the file.
- Reorder to have initialisation function first.
- Only a Boolean is tracked by the stack so change its type to ‘bool’.
- Use inform() instead of fprintf().
- Alter directive_pop()'s structure to marry directive_push()'s: check
for error and return followed by normal processing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 6 14:16:19 2021 +0100
uip/mhbuildsbr.c: alter init_decoded_content() to return void.
It was always returning ‘OK’ and no caller was checking it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 6 13:17:51 2021 +0100
sbr/folder_read.c: don't check for new maxima if it's a new minima.
It can't be both which is what the existing code suggested.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 6 13:13:07 2021 +0100
sbr/vector.c: rename bvector_resize()'s parameter from ‘newsize’ to ‘n’.
It's not the new size but the bit index which needs to have storage
which may be the same value as the existing size in maxsize given
storage is for bits [0, maxsize). ‘n’ is the value typically used by
the other routines for the zero-based bit-index.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 6 13:11:59 2021 +0100
sbr/vector.h: add comments describing struct bvector's members.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 6 10:36:34 2021 +0100
test/sequences/test-mark: test ‘mark’ not ‘uip/mark’.
The wrong executable was being tested; it should be found in the PATH.
Fixes 31441ee8.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 4 10:23:56 2021 +0100
guide: delete the list of commands to edit and execute in Acme.
If any other Acme users found it useful then pipe up.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 3 22:21:07 2021 +0100
all: replace some strdup() with mh_xstrdup().
Some strdup() remain, either because the caller checks for error and
does not die if it occurs, or it's not trivial to see mh_xstrdup() is a
suitable replacement.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 3 17:34:04 2021 +0100
uip/sendsbr.c: replace ‘adios(NULL, ...)’ with ‘die(...)’.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 3 17:30:06 2021 +0100
sbr/mts.c: remove comment for deleted variable ‘mtsconf’.
Fixes 1c03fa9d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 3 12:26:39 2021 +0100
test/send/test-sendfrom: fix spelling in test data.
Fixes c723593d. No functional change.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Jan 10 22:57:19 2018 +0000
oauth.h: Move function-prototypes' comments to definitions.
Puts the documentation alongside the implementation for easy comparison.
`static' functions that have similar comments are then not the odd ones
out.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Jan 10 22:42:55 2018 +0000
oauth.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Nov 27 19:06:49 2017 +0000
prototypes.h: Delete empty file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 26 23:17:45 2017 +0000
config.c: Move etcpath() to path.c.
It was the only function in config.c, and path.c is almost a suitable
home for it. Its prototype was in prototypes.h, and a new config.h
would clash with autoconf's configuration header's conventional name.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 26 22:59:54 2017 +0000
Delete macros that aren't needed with constant-string catenation.
`#define foo(s) FOO #s' used as `foo(bar)' is pointless as
`FOO "bar"' is equivalent and cuts one level of indirection.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 26 14:58:21 2017 +0000
prototypes.h: Delete `struct msgs_array'; it's defined in utils.h.
Since the definition is already public, there's no data hiding achieved
by the declaration so delete it. Re-order #includes so utils.h comes
before arglist.h as the later uses the struct. (Arguably, struct
msgs_array and its functions should move from utils to arglist, but
that's another sweep of refactoring.)
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 26 14:49:54 2017 +0000
utils.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 26 00:35:53 2017 +0000
utils.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 21:51:41 2017 +0000
seq_getnum.c: #include seq_getnum.h to ensure they agree.
Fixes 932e0640.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 21:50:39 2017 +0000
seq_del.c: #include seq_del.h to ensure they agree.
Fixes 9f1e781a.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 21:48:09 2017 +0000
context_foil.c: #include context_foil.h to ensure they agree.
Fixes 8e88279d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 21:43:41 2017 +0000
base64.c: #include base64.h to ensure they agree.
Fixes 55a31c2e.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 22:31:29 2017 +0000
fmt_compile.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 19:38:42 2017 +0000
fmt_compile.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 15:36:17 2017 +0000
fmt_scan.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Move structs comp and format, and many prototypes, to existing
fmt_compile.h because the functions are in fmt_compile.c. Change
cpnumber() and cptrimmed() to be static as they've no callers outside
fmt_scan.c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 24 23:10:20 2017 +0000
fmt_scan.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 24 00:31:07 2017 +0000
addrsbr.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 24 00:18:51 2017 +0000
addrsbr.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 19 14:43:33 2017 +0000
mf.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 19 14:38:20 2017 +0000
mf.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 19 00:12:31 2017 +0000
aliasbr.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 18 23:58:19 2017 +0000
aliasbr.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 18 00:43:03 2017 +0000
dropsbr.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 18 00:33:43 2017 +0000
dropsbr.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 18 00:26:38 2017 +0000
done.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 18 00:16:23 2017 +0000
done.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 23:30:15 2017 +0000
signals.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 23:14:42 2017 +0000
signals.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 23:08:45 2017 +0000
mts.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 22:52:12 2017 +0000
mts.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 22:02:58 2017 +0000
pidwait.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 18:58:07 2017 +0000
mhbuildsbr.c: Add `static' to function definitions to match prototypes.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 18:56:36 2017 +0000
oauth_prof.c: Make mh_oauth_*_for_svc() static; no external callers.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 18:52:20 2017 +0000
oauth_prof.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 18:30:07 2017 +0000
charstring.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 16:03:55 2017 +0000
mhbuildsbr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 15:19:17 2017 +0000
mhlistsbr.c: Move interface to own file.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon May 3 07:53:41 2021 -0400
Mention the 'seq=n' form of message reference in mark.man
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun May 2 10:41:35 2021 -0400
Add -range/-norange to mark(1), to control compression of message sequences
The code was present in the previous commit, but disabled. This
provides the switches to control it, and updates the tests and man
page.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat May 1 07:33:29 2021 -0400
mark(1) can now report sequence memberships for particular messages
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 15:14:24 2017 +0000
mhstoresbr.c: Move interface to own file.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 15 21:01:46 2021 -0400
Removed extra space added before header field bodies by dist(1) to $mhdraft.
It was inconsistent with other usage of header fields read
with m_getfld(), such as in mhfixmsg.c, mhlistsbr.c, mhoutsbr.c,
mhparse.c, and prompter.c. It had been that way since at least
Feburary 1990.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Mar 24 08:11:17 2021 -0400
auto-generate the SEE ALSO section of mh-chart(7)
With this change, all of the nmh man pages, in all sections, are
mentioned in mh-chart.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Mar 24 08:03:31 2021 -0400
remove extra '\' from man page name
The escaped hyphen in mh\-mime was unnecessary, and it was confusing
the revised mh-chart-gen.sh script.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Mar 24 08:01:10 2021 -0400
added mh_profile to the mh-profile man page name
mh-profile(5) and mh_profile(5) are two names for the same man page,
but only one appeared in the actual text, previously.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Mar 24 07:58:45 2021 -0400
add "overview of" to man page name
Added to make nmh(1)'s role in mh-chart(7) more clear.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 21 09:43:42 2021 -0400
Thanks to Ken for suggesting the alias expansion approach.
Update to commit c723593d2af190d9c86062d2a265fceec25fb777.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 21 09:31:21 2021 -0400
Added alias expansion to From: address for use by sendfrom.
Thanks to Tom Rodman <nmh@trodman.com> for reporting this deficiency.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 21 09:28:03 2021 -0400
Removed test output file.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 21 09:25:34 2021 -0400
Plugged memory leak resulting from etcpath() call.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 21 09:23:50 2021 -0400
Added --num-callers=500 to valgrind invocation.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 21 09:21:49 2021 -0400
Added suppression for invalid memory access in iconv_open().
On Fedora 33.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 13 10:24:21 2021 -0500
Allow mhparse to handle files that don't end with a newline.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 20 09:18:16 2021 -0500
post(8), not send(1), uses fileproc to file copies to Fcc folders.
Author: Stephen Gildea <stepheng+nmh@gildea.com>
Date: Fri Feb 19 21:01:42 2021 -0800
patch: test that scanning file "-" reads from stdin
The enclosed patch improves the test coverage of "scan",
enhancing the test I wrote last year.
Signed-off-by: David Levine <levinedl@acm.org>
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Sep 20 17:51:36 2020 -0500
Update XOAUTH2 documentation.
Google publicly documents XOAUTH2 for POP3 now, so we no longer need the
link to the blog post from 2014.
Replace dangling references to numbered links that are no
longer numbered.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Sep 20 17:47:39 2020 -0500
Tell make that uip/mhical.c depends on sbr/icalparse.h
Makes parallel builds work again.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 20 11:48:40 2020 -0400
Expanded allowed text in mhical parse error message.
Thanks to Eric for reporting that BSD yacc produced a different
error message than bison.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 20 11:20:36 2020 -0400
Fixed mhical(1) exit status to reflect return status of icalparse().
Also, removed parser_status as a global: just use the return status
of icalparse(). And had to change test-mhical to reflect new exit
status from mhical with empty input.
Thanks to Ralph for pointing out that test-mhical previously had an
unnecessary test of the mhical exit status.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Sep 19 17:44:31 2020 -0500
Replace GNUism with standard touch flag in test-scan-file.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Sep 19 17:03:44 2020 -0500
Document the -port flag. Text copied from inc.man .
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 10 20:55:26 2020 -0400
Fixed memory corruption in post(1) and inc(1) when using XOAUTH2.
An internal table for the oauth entries was initially sized at 4,
and then reallocated if the user had more than 4. However, the
reallocation didn't account for the size of the allocated
structure.
Also, increased the initial size to 16, trading off slightly
increased memory usage for performance.
Fix to commit 29ff4f879.
Author: David Levine <levinedl@acm.org>
Date: Mon May 25 14:19:35 2020 -0400
Added start_test/finish_test to a bunch of tests.
Author: David Levine <levinedl@acm.org>
Date: Sun May 10 11:20:04 2020 -0400
Replaced use of snprintf() with memcpy()/memmove().
gcc 10 noticed overlap of source and destination in snprintf() args.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 15 19:11:53 2020 -0400
Added many flags to CFLAGS with gcc, if supported.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 15 17:35:55 2020 -0400
Added check for passing null argument to printf(3) %s directive.
This fixed "directive argument is null" warnings found by gcc
-Wformat-overflow.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 15 17:18:58 2020 -0400
Refined number of bytes copied to buffer in several places.
This fixed "output may be truncated writing up to [m] bytes
into a region of size [n]" warnings found by gcc -Wformat-truncation.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 15 17:14:36 2020 -0400
Subtracted 1 from size argument in some calls to strncpy(3).
This fixed "specified bound [n] equals destination size" warnings
found by gcc -Wstringop-truncation.
Also, fixed harmless copy-and-paste error (sizeof(tmpfil) instead
of sizeof(drft) in uip/rcvdist.c) introduced in commit 2f689a1cb.
Author: Stephen Gildea <stepheng+nmh@gildea.com>
Date: Mon Feb 17 11:02:49 2020 -0800
patch: Maildir support for "scan -file"
I have extended the "scan -file" command line so that the "file" can
also be a Maildir directory.
This feature complements the Maildir support added to the inc command
in 1.4. Just as you may want to inc your mail from Maildir, you might
want to see what awaits you with a scan first.
Signed-off-by: David Levine <levinedl@acm.org>
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 20 13:53:35 2020 -0500
Removed unused fail label.
Also, moved new tests to end of file. Update to commit b7416e7959.
Author: Conrad Hughes <biz_nmh_workers@xrad.org>
Date: Tue Jan 14 10:01:46 2020 +0000
Patch for mhical to support "BYDAY=-1SU"-type RRULEs.
Notes:
- Added dmlastday() function to dtime.c, to obtain last day of month.
Minor modifications to other parts here to reuse code.
- Modified rrule_clock() in datetime.c to handle negative BYDAY
correctly.
- Added a couple of tests.
- Mainly this is to scratch an itch since UK timezone history makes
heavy use of BYDAY=-1SU-type RRULEs, and the resultant complaints
are annoying. I had a brief look at "properly" extending
icalparse.y, but I kindof think any serious extension of mhical
should really instead adopt libical?
Author: Conrad Hughes <biz_nmh_workers@xrad.org>
Date: Thu Dec 26 17:29:59 2019 -0500
Fixed file descriptor leak in mhfixmsg when run on multiple input files.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 25 18:15:06 2019 -0500
Fixed source charset in mhfixmsg textcharset verbose output.
Thanks to Conrad Hughes for reporting this bug.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 7 11:16:52 2019 -0500
Removed obsolete spec for default password with -sasl for POP.
It was obsoleted by commit 90edb255effd0d2.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 7 21:49:30 2019 -0500
Include proper header without READLINE_SUPPORT.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 19:08:46 2019 -0400
Restored file execute permissions.
Fix to commit 62b9266aa31b2baced3252987b256b4e43ec9573.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 19:06:19 2019 -0400
Removed --depth 1 from git clone invocation.
That caused git describe in config/version.sh to fail.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 20 11:14:46 2019 -0400
Updated documentation and comments about sendmail/pipe.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 16 21:37:19 2019 -0400
Improve POP SASL error handling
Handle the case where we get an -ERR message during the SASL exchange.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 8 19:04:36 2019 -0400
Pass command line arguments first from rtm() to rt() to support its args.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 2 11:39:21 2019 -0400
Remove X.400 address parsing
Remove the X.400 address parsing used by the %(friendly) format escape.
Because ... you know, it's 2019 and X.400.
Author: Michael Richardson <mcr@sandelman.ca>
Date: Mon Sep 30 11:06:16 2019 -0400
add documentation on friendly function
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 30 18:23:51 2019 -0400
Change the default for noverify
The default for 'noverify' should be 'false'. The certificate chain
SHOULD be verified by default.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 25 09:08:25 2019 -0400
Added warning if the profile contains a post entry.
Added warning from all programs that read the profile if the profile
contains a post entry, which is ignored, but does not contain a
postproc entry. In other words, if you get this warning and want
to suppress it, your options include:
1) Remove your post profile entry.
2) Make your post profile entry a comment by prepending it with the #:
comment indicator.
3) Add a postproc entry that points to the post that you use. That can
be viewed with "mhparam postproc".
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 25 08:56:04 2019 -0400
Moved run_without_input() from test-version-check to common.sh.in.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 25 08:49:53 2019 -0400
Removed unnecessary warning about missing semicolon.
The warning was for Content-Type and Content-Disposition, and was
incorrect. Thanks to Tom for providing output with it. Also
removed multiple trailing newlines from warning output, thanks to
Ralph for tracking those down.
Author: David Levine <levinedl@acm.org>
Date: Sat Aug 10 18:50:39 2019 -0400
Added test of encoded Resent-To: and Resent-cc:.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 4 18:25:50 2019 -0400
No longer need trailing space after CFLAGS variable assignment.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jul 27 21:22:12 2019 -0400
Reorder configure options to be before variables
Reorder the configure options generated by build_nmh so they
will be before the variables, otherwise they end up IN things like
CFLAGS. Fixes bug #56680.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 15 14:25:53 2019 -0400
Fix handling of fullname
Make it that if a Local-Mailbox profile entry was NOT specified
that the fullname would be generated BEFORE the local mailbox was
generated, so the user's name ended up in the email address properly.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 14 09:29:21 2019 -0400
show and mhl now decode more addresses in header fields.
Added decoding of To:, Cc:, Resent-To:, Resent-Cc:, and
Resent-From: addresses to mhl.format and mhl.headers. Thanks to
Conrad Hughes for suggesting it for the first two components and
to Ralph for suggesting it for the Resent- components.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 8 11:37:15 2019 -0400
Handle teen ordinal suffixes correctly.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 8 09:59:15 2019 -0400
Create new mh-format function %(ordinal)
Implement a new mh-format function %(ordinal). This will output
the appropriate ordinal prefix (st, nd, rd, st) based on the value
of the "num" register.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jun 29 14:17:16 2019 -0400
Support the TLS SNI extension
Add support for sending the TLS Server Name Indicator extension
during TLS connection negotiation.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jun 24 12:42:05 2019 -0400
Print port number in the connection error message
If a connection to a host fails, print the port number in the brief error
message. This will hopefully eliminate problems when nmh is using a default
port number that users are not expecting.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Sun Jun 9 11:40:38 2019 -0400
- Fixed bcc to work with sendmail/pipe [Bug 55700].
And better documented that dcc doesn't work with sendmail/pipe.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 9 11:02:45 2019 -0400
Commit ddf3a8574f65 is a fix to commit af586ebe59b7.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 9 10:58:11 2019 -0400
Fixed inc(1) and %(me) to not obey Local-Mailbox profile component.
Thanks to Martin McCormick for reporting and Ken for diagnosing.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 9 10:57:07 2019 -0400
Added missing ')'.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat May 18 10:17:15 2019 -0400
Clean up more whitespace errors
Get rid of more whitespace errors; hopefully I got them all.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat May 18 09:21:21 2019 -0400
Remove the #ifdef UK for the default scan format
Remove the #ifdef UK that lets you select an alternate default
scan format; this is left over from old mhconfig program.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri May 17 23:50:16 2019 -0400
Fix whitespace errors
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri May 17 14:27:28 2019 -0400
Remove final traces of TMA support
TMA (the TTI Trusted Mail Agent) was an early implementation of
encrypted mail and is long gone. There were a few vestigial bits
of this support left in nmh, and this is finally removing them.
This includes the check for the "Encrypted" header field in various
scan formats and some code to return the code SCNENC from scan()
function where it would have special handling by programs like inc(1).
Author: David Levine <levinedl@acm.org>
Date: Wed May 15 19:38:43 2019 -0400
Added links to David Malone's MH 6.x archives.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun May 12 20:07:56 2019 -0400
Cleanup MIME header handling in mhbuild
Per discussion on nmh-workers, cleanup the handling of MIME headers
in mhbuild. The following logic should now apply.
If mhbuild is run with -auto AND a MIME-Version header is detected, then
exit silently with no error (and leave the draft untouched). Otherwise,
if a MIME-Version header or ANY Content-* header is found, exit with an
error. Note that this means if mhbuild is run with -auto then an error
will be returned if any Content-* headers are seen.
Previously, mhbuild would silently eat any Content-Type headers seen
in an existing draft; this behavior was brought forward from MH 6 and
no one could explain the reason for this behavior. This behavior has
been removed.
Author: David Levine <levinedl@acm.org>
Date: Sun May 12 11:03:14 2019 -0400
Added several historical source archives from the early days of MH.
SRI-NOSC, 2.9BSD, mh-jun-1982, and mh-nov-1983 predate those under
RCS/CVS source code control.
Thanks to M. Levinson, David Malone, Chad, Noel Chiappa, and Ralph
for advising of their discoveries of the various archive locations.
Removed docs/historical/mh-6.8.5/miscellany/mem/a.out because SPARC
executables shouldn't be archived.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat May 4 22:46:45 2019 -0400
Improve fmttest output
Improve the fmttest output; make it so more arguments to format
instructions are printed and clean up some of the argument handling.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat May 4 19:36:38 2019 -0400
Clarify %(profile) escape
Note that %(profile) can also pull entries from the context as well
as the profile
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri May 3 23:50:34 2019 -0400
Remove support for message/partial
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu May 2 13:26:56 2019 -0400
Improve SASL snoop output
Generate more information in the netsec layer when -snoop is enabled.
Specifically, enumerate the supported SASL mechanisms by the client and
server and explain which layer is using encryption.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 28 21:07:24 2019 -0400
Permit the matching of canonical MIME multipart boundaries
Allow the matching of MIME multipart boundaries if the message is
in canonical form (\r\n line endings).
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 24 20:42:28 2019 -0400
Updated name of generated file in comment of generation script.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 24 19:22:22 2019 -0400
Removed test that hasn't been added to repo.
Fix to commit 3f845b1b0.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 24 19:10:02 2019 -0400
Commented out full output device test in test-scan.
Reverts commit d9b33232b. It would pass on platforms that don't
have /dev/full, but was expected to fail.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 24 18:46:51 2019 -0400
Removed redundant initialization of local variable tls.
Fix to commit ec173fd2c. gcc noticed that it, in effect, it
was declared as an int but initialized the second time with
a bool value.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 24 13:05:30 2019 -0400
Remove MIME content caching code
Remove all of the MIME content caching code. Besides being of dubious
value and having a number of 'interesting' security implications,
it apparently only would cache content if you ran it using mhn
(the necessary entry point was not copied over when mhn was split
apart) and it would only work on the top-level MIME content of a
message.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 24 10:25:18 2019 -0400
Removal of Content-MD5 support
The generation and verification of Content-MD5 headers is no longer
done. FINALLY.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Apr 23 12:40:44 2019 -0400
Fix file descriptor leak in ruserpass()
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Apr 23 12:30:36 2019 -0400
Mention inc(1)/msgchk(1) changes
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 21:42:14 2019 -0400
Set the close-on-exec flag for sockets
Since we no longer use closefds(), start cleaning up stray descriptors.
Start by making sure that any network sockets we create have the
close-on-exec flag set on them.
Merge: 2184c881 9ffc9180
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 20:43:47 2019 -0400
Merge branch 'pop-stls'
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 20:42:57 2019 -0400
Loosen up valgrind suppression
Change the valgrind suppression rules so they exclude more things
on MacOS X.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 20:36:14 2019 -0400
Garbage collect closefds()
Remove the closefds() function; it was used sporadically and was
causing problems on High Sierra. In the future look at opening
more descriptors with FD_CLOEXEC.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 20:30:24 2019 -0400
Final cleanup of POP STLS support
Perform final cleanup for support for the STLS command in POP. Add
necessary switches to msgchk and add information to man pages.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 19:51:52 2019 -0400
Output the header name for the PUTADDR instruction
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 22 19:46:17 2019 -0400
Add basic support for the STLS command in POP
Add support for the STLS command in POP (sometimes called STARTTLS).
Functionality not yet complete.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 7 13:17:23 2019 -0400
Added -checkbase switch to mhfixmsg(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 7 13:14:59 2019 -0400
Renamed build_multipart_alt() to build_multipart().
And some other minor code cleanup.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 22 11:59:04 2019 -0400
Add support for %(trimr) format function
Add support for a %(trimr) format function, which behaves exactly
like %(trim) but also returns a string. Turns out this is literally
a one-line change that does not require a new format instruction.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 13 16:53:20 2018 -0500
Replaced use of hard-coded sizes with sizeof the char arrays.
Fix to commit 23024ffad75d997bf2a85b3a65fbfdfd35f8150c.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 10 12:38:01 2018 -0500
Added CONTEXT section to fmttest man page.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 10 12:35:31 2018 -0500
Added -attendee switch to mhical(1).
This allows the user to select which of their attendee addresses they are
responding about, when they have more than one in the invitation.
Added corresponding -a switch to calaccept, etc., functions in replaliases.
Updated mhical to retain DESCRIPTION lines. Gmail puts a link to the event
DESCRIPTION line along with a message to no edit that section, though it
seems to accept responses if the DESCRIPTION line was removed.
Incremented mhical version number to 0.5.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 3 15:03:17 2018 -0400
Reduced quantities of data that could be written to a few buffers.
gcc 8 noticed that snprintfs could have overrun the buffers.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 1 19:44:32 2018 -0400
Increased sizes of a couple of buffers.
gcc 8 noticed that snprintf could have overrun them. It might be
better to reduce the sizes of buffers used for display names, etc.
Or ever better, use dynamically sized buffers.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 31 19:09:33 2018 -0400
Resized buffer, and moved it to the only block where it's used.
gcc 8 noticed that snprintf could have overrun it.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 31 18:51:23 2018 -0400
Resized buffer and provided timezone its own buffer.
gcc 8 noticed that snprintfs could have overrun them.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 30 22:01:05 2018 -0400
Added full output test to test-scan.
From commit f54674f1b5d07148d9655fc3b337ad5f725272a7. The test
fails now, so added to XFAIL_TESTS.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 29 21:54:08 2018 -0400
Revert "scan(1) now checks for full output device [Bug #50925]."
This reverts commit f54674f1b5d07148d9655fc3b337ad5f725272a7.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 28 14:27:39 2018 -0400
scan(1) now checks for full output device [Bug #50925].
Added fflush(3) after every output line: may slow down scan on
output with large number of lines.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 28 10:47:40 2018 -0400
Added PROFILE COMPONENTS section and corrected CONTEXT.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 28 10:45:08 2018 -0400
Corrected comment: whom(1) does not use context_foil().
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 22 09:50:44 2018 -0400
Increased sizes of a couple of buffers.
gcc 8 noticed that snprintfs could have overrun them.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 22 09:12:51 2018 -0400
Check for /etc/centos-release, on CentOS.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jul 1 09:49:28 2018 +0100
ruserpass.c: Return the password typed by the user.
Darren Provine reported that entering the password didn't work. This
was due to ruserpass() failing to set the password. Fixes 1d4977af.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jul 1 09:43:05 2018 +0100
mhlsbr.c: Use variable for strncpy(3)'s size, not sizeof.
Silences gcc 8.1.1's warning that the size of the source was being used,
not the destination. The destination has just been allocated to be the
size of the source so no overflow can occur. Move existing variable
that later holds the buffer size to before the allocation and strncpy so
it can be used for those too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jul 1 09:36:25 2018 +0100
post.c: Remove `pure' attribute from void-returning chkadr().
Spoted by gcc 8.1.1. Fixes 93a18dd7.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Jul 1 09:32:28 2018 +0100
rcvtty.c: Use struct utmpx's ut_line[], not a copy.
Silences gcc 8.1.1's warning that strncpy(3)'s length is the sizeof of
the source, not the destination, by removing the strncpy and passing the
source to alert() where it's only read, not written.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 31 13:35:19 2018 +0100
man: Use `.B' instead of `.BR' when only one argument.
Author: David Levine <levinedl@acm.org>
Date: Wed May 30 21:20:22 2018 -0400
The sendmail config component/switch can be used with sendmail/smtp mts.
As well as with sendmail/pipe.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 17 22:34:14 2018 -0400
Change the default editor from 'vi' to 'prompter'.
Absent any profile environment variable setting, the default editor
for commands like 'comp', 'forw', and others is now the nmh program
'prompter'.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 19 21:30:17 2018 -0500
Fixed mhshow/test-charset to work on all tested platforms.
Restores the functionality of commit f81046da6. Also, skips the
last two tests if iconv isn't enabled. And removes the test
files if the last test, without iconv_elides_question_marks, behaves
as expected. Finally, some comments have been updated.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 12 16:01:08 2018 -0500
Avoid free() in format engine for now.
This free() call messes up the buffer handling in scansbr.c:scan();
for now we're going to live with the leak and fix this properly when
we normalize the format engine's memory handling.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Feb 11 13:02:24 2018 +0000
cpstripped(): Replace malloc()s with statics based on MB_LEN_MAX.
MB_CUR_MAX from stdlib.h isn't a compile-time constant so can't be used
for the size of a couple of static char arrays so malloc() was used at
run time, with the tiny claims never being freed. valgrind(1) noticed
and David suggested MB_LEN_MAX from limits.h instead; that header's
contents are suitable for #if expressions and thus compile-time
constants.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Feb 9 18:51:59 2018 +0000
Remove extra semicolons at end of C statements.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Feb 7 23:24:11 2018 +0000
trunccpy(): Fix typo in comment describing function.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Jan 23 18:20:16 2018 +0000
mhshowsbr.c: Delete single-use global int `nolist'.
Was only used in one place for its value that was always zero.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 10 01:29:46 2018 -0500
Add a few more MacOS X valgrind suppressions
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 9 23:15:32 2018 -0500
Clean up memory leaks by callers of scan().
Make sure we reuse the "scanl" argument to the scan() function, as that's
the signal to have scan() reuse it's buffers. Otherwise repeated calls
to scan will leak a TON of memory. Reported by Ralph Corderoy.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 8 19:43:56 2018 -0500
Compile the header format for each message.
Per Ken's suggestion, compile_header() and compile_marker() are now
called for each message. That's done with reset_comptable disabled.
So, per Ralph's suggestion, fmt_free(NULL, 1) is called after all
messages are shown to free up memory held by the component table.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 8 19:21:55 2018 -0500
Generalized gdbm 1.13 Memcheck:Param suppression a bit.
gdbm 1.13-3 (Fedora 27) doesn't show the __write_nocancel call.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 7 20:43:59 2018 -0500
Fixed mhshow part markers when displaying multiple messages.
Added test/mhshow/test-markers, it reveals the problem.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 3 13:49:24 2018 -0500
Suppress unused parameter warning in builds without Cyrus SASL support.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 3 13:48:10 2018 -0500
Support building without Cyrus SASL or TLS.
If the user doesn't specify -y, and specifies n for either Cyrus
SASL or TLS when asked.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 3 08:03:24 2018 -0500
Removed unused hf_encoding from struct hfield.
I could not find any evidence of it ever being used.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 3 08:00:36 2018 -0500
Removed comment about testing noiconv portion of get_param_value().
I'm not sure if it ever did, but it doesn't seem to now.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Feb 3 10:49:40 2018 +0000
test-charset: Fix test when HAVE_ICONV is false.
When the Content-Type's charset parameter's encoding is `invalid', it
makes no difference whether HAVE_ICONV is defined or not as the
parameter's value can't be decoded.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Feb 3 10:46:23 2018 +0000
decode_rfc2047(): Stop unused-variable warning if HAVE_ICONV false.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Jan 25 00:28:45 2018 +0000
seq_nameok(): Distinguish three identical error messages.
Otherwise `illegal sequence name' doesn't say what's wrong.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Jan 25 00:16:15 2018 +0000
test-charset: Divulge mhshow output if iconv_open(3) doesn't gripe.
Andy Bradford was finding the grep failed, but was left with no
explanation that's what happened, or what the file that didn't match
contained.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Jan 24 00:27:01 2018 +0000
%(divide): Avoid SIGFPE on integer divide of INT_MIN by -1.
Dividing by zero isn't the only cause of SIGFPE.
fmttest -raw -format '%(num -2147483648) %(divide -1)' foo
Also, add FIXME comment suggesting the user should be told of overflow
rather than silently using zero as the result.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Jan 24 00:12:59 2018 +0000
Use trim_suffix_c() to remove optional trailing character.
I'm unsure if one of the cases can know the string's length is long
enough to read the char before the NUL. Using trim_suffix_c()
simplifies and removes the possibility.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Jan 24 13:49:06 2018 +0000
mhfixmsg.man: Replace UTF-8 `§' with `\(sc' troff escape.
man page source is ASCII. GNU groff's troff's source is ISO 8859-1.
The `§' in UTF-8 looks like `§' in ISO 8859-1. If those two bytes make
it to a UTF-8 terminal then it appears as `§', but target something
else, e.g. PDF, and the flaw shows.
Also adjust test-manpages to grep for bytes other than HT, and SPACE to
tilde, in the built man pages. A test of the source could be also be
done for the Makefile's `all' target, but this one should remain to spot
the build process breaking things, e.g. non-ASCII in $prefix.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 23 20:10:27 2018 -0500
Fixed RFC reference in mhfixmsg man page.
RFC 5322 has line length limits.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Jan 23 16:37:01 2018 +0000
fmt_scan(): Avoid undefined behaviour from overlapping strncpy(3).
M. Levinson pointed out in private email that pcc(1) tickles a bug that
causes undefined behaviour due to part of `buffer[]', accessed by `str',
being strncpy(3) back to its start. Fix by using memmove(3) to slide
`str' back to `buffer's beginning whenever it may have wandered off.
Fixes e8635a8a that added `%(unquote)', but using `%(trim)' twice was
also faulty in the same way and pre-dates git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Jan 23 09:18:34 2018 +0000
mhshow: Avoid SEGV when user's command has two or fewer words.
After argsplit() returned a NULL-terminated vector, the existing NULL
was overwritten with another and the vector index then incremented.
This made the test for whether vec[2] was available out by one resulting
in NULL being used and printed.
This plucking of the third word is a faulty assumption as argsplit()
doesn't always return ["sh", "-c", ...], but add a new test script for
it to avoid regression and so that the script can be expanded with more
related tests.
Fixes 7559e1ebf.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 20 11:48:30 2018 +0000
test-whom: Send whom's stderr down pipe; don't discard.
Fixes 2a02eef3.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 20 11:45:32 2018 +0000
test-msgchk: Send msgchk's stderr down pipe; don't discard.
Present since original 26ac907a.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 20 11:38:24 2018 +0000
test: Send command's stderr down pipe; don't discard.
Fixes 880ff2a4 that turned `foo >$actual 2>&1' into
`foo | sed ... >$actual 2>&1'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 20 08:57:40 2018 +0000
test/common.sh.in: Unset libcurl(3)'s proxy environment variables.
Debian's packager, Alexander Zanger, reported test/oauth/test-* problems
due to environment variables for the system's network proxies. David
Levine suggested the unsetting of them. The tests only make HTTP
connections so just the variables affecting those are unset.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 20 07:33:36 2018 +0000
test-subpart: Send mhshow's stderr down pipe; don't discard.
Fixes 2f1e191a.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 20 07:28:29 2018 +0000
test-textcharset: Send mhshow's stderr down pipe; don't discard.
Fixes 67bb0fc0.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 18 21:46:13 2018 -0500
Removed quotes around "%{charset}" in mhbuild-convert-text.
They broke test/repl/test-convert on Cygwin. It looks like parameter
quoting differs between mhbuild and mhshow.
Fix to commit 47629e9e87a324531be881cebfca38dd38f8afaa.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 18 20:21:40 2018 -0500
Removed quotes from charset argument to iconv.
Fix to commit 47629e9e87a324531be881cebfca38dd38f8afaa. Ken
noticed that it broke test/repl/test-convert on MacOS X.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 18 19:03:52 2018 -0500
Filter test output to remove added whitespace.
Ralph noticed that lynx added whitespace to the (empty) converted
html document, breaking the test.
Fix to commit 47629e9e87a324531be881cebfca38dd38f8afaa.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 17 19:36:12 2018 -0500
Wrapped uses of %{charset} in mhn.defaults with double quotes.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Jan 15 16:25:35 2018 +0000
Add test-fmttest for cpstripped(), cptrimmed(), and cpnumber().
Many more tests could be done, and some, like those below, would produce
known erroneous results, but this is a start and helps spot regressions.
create mode 100755 test/format/test-fmttest
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jan 13 13:54:15 2018 +0000
fmttest: Allow `-outsize 0' to mean no output, not default size.
`0' might be arrived at by a script tracking remaining space.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 29 17:28:50 2017 +0000
Add Arch Linux to the often-built-and-tested distro list.
And correct a `Mac OS' to have an `X', and `HPUX' to be `HP-UX'.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 15 17:30:49 2018 -0500
Also trap ambiguous post switch.
Fix to commit d321a6ee82fce5d187f4342199c090909a72e9b8.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 15 14:01:09 2018 -0500
Fixed rcvdist to pass switch arguments to post(1).
Looks like this has always been broken. Found by Steven Winikoff
when he tried to pass a -port switch, to override the default
submission port.
This is intended to be a temporary fix. The post switches should
be factored out into one place.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 14 15:04:53 2018 -0500
Removed escape before newline.
It was causing a *roff font selection code to appear in the
formatted man page.
Fix to commit 95e0df2af. That commit removed a space after the
escape, which used to cause a double space in the formatted output.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 14 13:54:19 2018 -0500
Added mhfixmsg -[no]decodeheaderfieldbodies switches.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 14 08:37:33 2018 -0500
Note that mhshow-suffix/mhshow- matching is case-insenstive.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun Jan 7 13:12:02 2018 -0500
implement the long-neglected 'folder -noprint'
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 17 20:41:34 2017 -0500
Removed sysconfdir overrides from SPECS examples.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Dec 10 00:36:21 2017 -0500
Add support for setting nmh directories.
Add new precious variables (nmhlibexecdir and nmhetcdir) that will
permit the user to specify these directories exactly. They default to
$(libexecdir)/nmh and $(sysconfdir)/nmh, respectively.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 2 15:43:16 2017 -0500
Removed version number from OpenBSD, it's in the "recent" section.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 2 09:44:19 2017 -0500
Moved OpenBSD back to "routinely built and tested" category.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 27 20:56:30 2017 -0500
Updated platform lists in MACHINES.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 27 20:11:30 2017 -0500
Removed sbr/dtimep.c from CLEANFILES.
automake puts it in maintainer-clean-generic, which is where it belongs.
Reversal of commit 1353a95720e4049e5f8357cd009b76c0450ec39f.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 27 19:38:37 2017 -0500
Added note to commit checklist to start message with one-line synopsis.
Also, removed obsolete reference to Lyndon's buildbot.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Nov 27 15:20:44 2017 +0000
test-mhfixmsg: pwd(1)'s `-P' needed to avoid failure with symlinks.
Steven Winikoff reported to nmh-workers that one of this file's tests
failed in 1.7. It attempts to manipulate the output of mhpath(1)
assuming it starts with the result of `pwd', but symlinks in the latter
may cause this to fail. Use POSIX's `-P' option to ensure no symlinks,
as done in some other tests.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 26 17:27:48 2017 -0500
Use ISO-2022-KR instead of EBCDIC-US in test-charset, because
Robert Elz reported that it is installed on his NetBSD host.
Also, don't run that check without iconv.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 26 12:09:22 2017 +0000
Fix tests that assume the backup prefix is a comma.
Steven Winikoff reported to nmh-workers that some tests failed in 1.7
configured with --with-hash-backup because they assume the backup prefix
is comma rather than hash. Alter those tests to use `mhparam sbackup',
as other tests already do. PATH is already set to use the mhparam being
tested.
test-mhfixmsg used find(1) to check for leftover files that globbed
`mhfix*' or `,mhfix*'. Changed to just `*mhfix*' as I think any file
containing that would be unwanted, and it will also spot mhfixmsg
hard-coding the comma prefix.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 17 12:04:01 2017 +0000
NEWS: Encourage nmh-announce subscription. Capitalise `Gmail'.
Cherry-picked to 1.7-RC3-6-g3d2c68e3.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 25 15:42:09 2017 +0000
mhshow/test-charset: Protect question mark from shell globbing.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 24 18:41:23 2017 -0500
Reworked parameter value tests to reflect Ralph's (re-?) discovery
that GNU iconv elides the ? from charset names. nmh uses it as a
replacement character when decoding fails.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 23 23:11:58 2017 +0000
Makefile.am: Remove `-I./sbr' from sbr_libmh_a_CPPFLAGS.
Doesn't seem to be useful. Present since the switch to automake, so
possibly a leftover from experimentation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 22 15:12:11 2017 +0000
fmttest.c: Clear output buffer after each write.
Otherwise each write outputs the whole buffer again, including what's
already appeared. Instead of the three lines 1, 2, 3, one sees 1, 1, 2,
1, 2, 3.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 22 13:44:01 2017 +0000
Rewrite cpnumber() to fix `%2(msg)' with 123 overflowing to `?23'.
Reported in 1.7 by Ken on nmh-workers yesterday.
`It seems this was introduced in commit 92128dacf'.
We now use the C library to format the number, and then manipulate the
result. A temporary charstring_t is no longer used.
Also adds left justification using negative width.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Nov 19 19:08:48 2017 -0500
Normalize some #include paths.
Include the subdirectory so these files will compile from an object build.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 18 10:35:19 2017 -0500
Move etc/rmmproc.messageid to fix its install permissions.
And removed duplicate docs/contrib/replaliases to fix its install permissions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 00:14:35 2017 +0000
fmt_new.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 16 00:02:00 2017 +0000
fmt_addr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 15 23:52:08 2017 +0000
datetime.c: Make rrule_clock() static; no external callers.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 15 23:36:42 2017 +0000
datetime.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 15 23:29:04 2017 +0000
crawl_folders.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 15 23:25:29 2017 +0000
crawl_folders.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 15 23:16:13 2017 +0000
oauth.c: Alter permissions from 0755 to 0644.
Possibly introduced by 380046d2.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 14 23:56:16 2017 +0000
h/rcvmail.h: Delete. Contained just a couple of pointless macros.
RCV_MOK was 0, RCV_MBX was 1. They were used for exit(3) and done().
`exit(0)' is clearer than another layer of abstraction, and the commands
that used them didn't seem to document the exit statuses anyway. The
included by other means, at least on one platform.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 14 23:41:18 2017 +0000
popsbr.h: Base header on implementation.
Normally done as part of extracting the new header file from a larger
one, but this file already existed so it had to be moved as one commit
and altered in the next, otherwise git would break its history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 14 23:38:41 2017 +0000
popsbr.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Nov 13 00:06:30 2017 +0000
popsbr.h: Remove pop_fd() and pop_set() prototypes.
Function definitions removed in 4ea2f92f.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 23:58:29 2017 +0000
popsbr.c: Add `static' to function definitions to match prototypes.
parse_proxy(), command(), and multiline() all have prototypes claiming
they're static in popsbr.c, but their later definitions lack that
qualifier.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 18:50:32 2017 +0000
picksbr.h: Rename to be alongside implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 18:40:21 2017 +0000
dtime.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:50:58 2017 +0000
h/prototypes.h: Remove mhlsbr() prototype; no such function.
Function deleted in c808c5d5.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:49:07 2017 +0000
whatnowsbr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:46:37 2017 +0000
whatnowproc.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:44:34 2017 +0000
sendsbr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:42:01 2017 +0000
distsbr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:38:49 2017 +0000
mhlsbr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:35:49 2017 +0000
annosbr.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:24:05 2017 +0000
scansbr.c: Move interface to own file.
Merging in content of existing h/scansbr.h, though that only contained
one of the three prototypes. The other two were in h/prototypes.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:08:02 2017 +0000
m_name.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 13:02:28 2017 +0000
m_gmprot.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 12:57:35 2017 +0000
m_getfld.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 12:31:05 2017 +0000
getarguments.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:33:55 2017 +0000
read_switch_multi*_readline.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:31:18 2017 +0000
read_switch_multiword.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:28:46 2017 +0000
read_yes_or_no_if_tty.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:26:11 2017 +0000
read_switch.c: Move interface declaration to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:23:44 2017 +0000
concat.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:20:19 2017 +0000
seq_setunseen.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:18:03 2017 +0000
seq_setprev.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:15:47 2017 +0000
seq_setcur.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:13:35 2017 +0000
seq_save.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:10:48 2017 +0000
seq_read.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 12 00:05:54 2017 +0000
showfile.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:59:22 2017 +0000
smatch.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:53:00 2017 +0000
getpass.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:47:07 2017 +0000
r1bindex.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:44:44 2017 +0000
refile.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:42:31 2017 +0000
ruserpass.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:39:01 2017 +0000
remdir.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:34:59 2017 +0000
snprintb.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:31:23 2017 +0000
strindex.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 23:28:30 2017 +0000
ssequal.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:45:25 2017 +0000
credentials.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:38:47 2017 +0000
encode_rfc2047.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:33:36 2017 +0000
fmt_rfc2047.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:30:37 2017 +0000
client.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:28:18 2017 +0000
closefds.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:25:55 2017 +0000
copyip.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:23:45 2017 +0000
cpydata.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:21:17 2017 +0000
cpydgst.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:19:06 2017 +0000
discard.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 17:15:05 2017 +0000
trimcpy.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 16:22:30 2017 +0000
uprf.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 16:18:15 2017 +0000
vfgets.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 16:16:14 2017 +0000
check_charset.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 16:12:02 2017 +0000
getcpy.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:49:08 2017 +0000
m_draft.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:46:28 2017 +0000
m_convert.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:43:38 2017 +0000
m_backup.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:40:50 2017 +0000
m_atoi.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:35:55 2017 +0000
getfolder.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:30:21 2017 +0000
geteditor.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:28:05 2017 +0000
escape_addresses.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:25:37 2017 +0000
ext_hook.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:22:24 2017 +0000
fdcompare.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 14:20:01 2017 +0000
folder_read.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 13:42:45 2017 +0000
folder_realloc.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 00:18:51 2017 +0000
folder_pack.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 00:15:30 2017 +0000
folder_free.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 11 00:05:31 2017 +0000
folder_delmsgs.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 23:36:23 2017 +0000
folder_addmsg.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 23:13:42 2017 +0000
context_foil.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 23:05:42 2017 +0000
context_save.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 22:58:11 2017 +0000
context_replace.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 22:50:36 2017 +0000
context_read.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 18:06:35 2017 +0000
context_del.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 10 18:01:08 2017 +0000
context_find.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 7 00:28:47 2017 +0000
readconfig.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 7 00:17:50 2017 +0000
brkstring.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 7 00:10:06 2017 +0000
atooi.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Nov 6 23:59:41 2017 +0000
ambigsw.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 5 13:10:17 2017 +0000
vector.c: Move interface to own file.
Don't #include it in all its users yet as it's too tangled with mh.h's
other content, so just #include it in mh.h instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 3 00:28:26 2017 +0000
pidstatus.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 3 00:14:20 2017 +0000
push.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 3 00:07:21 2017 +0000
path.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 23:28:08 2017 +0000
print_version.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 23:16:21 2017 +0000
print_sw.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 23:08:38 2017 +0000
print_help.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 22:56:32 2017 +0000
seq_nameok.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 22:47:58 2017 +0000
seq_list.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 22:37:16 2017 +0000
seq_bits.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 21:50:33 2017 +0000
seq_getnum.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 21:40:11 2017 +0000
seq_del.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 18:19:59 2017 +0000
seq_print.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 18:09:43 2017 +0000
seq_add.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 17:59:04 2017 +0000
arglist.c: Move interface to own file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 17:36:33 2017 +0000
Strip directory from #include when it's not needed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 14:09:26 2017 +0000
Remove symbols-wanted comments after #include.
They're unlikely to be up to date, and they are few.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 13:57:23 2017 +0000
Use #include with `""' for including nmh's source.
Compilers vary on how they handle #includes with `""' and `<>', but
consistency on using `""' for nmh's files, and `<>' for the system's,
means it's easy to tell which is which at a glance.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 13:44:24 2017 +0000
error.c: Move interface to own file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 8 22:32:57 2017 -0500
Support a -timeout switch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Nov 4 09:59:18 2017 -0400
Use va_copy() to get a copy of va_list, instead of using original.
netsec_vprintf() can call vsnprintf() twice if the outgoing buffer is
full (but it happens rarely in practice, given the way the current
code uses it). But if this DOES happen, vsnprintf() will use the
same va_list argument twice, and the second time around either it will
grab a random bit of memory off of the stack OR it will segfault.
So we always use va_copy() to get our own copy of the passed-in va_list
and work on that.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Nov 4 09:58:16 2017 -0400
Add support for batch mode.
Add a new switch, -batch, which will run a sequence of commands out
of a batch file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 3 14:58:06 2017 -0400
Various IMAP protocol improvements
Make the CAPABAILITY parser work correctly (and not include CAPABILITY
as a capability).
Support reading an untagged CAPABILITY response during an authentication
exchange.
Removing some debugging statements.
Make LITERAL+ and LITERAL- work correctly.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 2 23:21:36 2017 -0400
Make APPEND work; still needs some changes, though.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 1 23:46:17 2017 -0400
Start of making APPEND functional; not quite there yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 1 15:01:23 2017 -0400
Support sending multiple commands at once.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 1 14:00:18 2017 -0400
Report on the TLS negotation time
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 02:21:55 2017 +0000
prototypes.h: Delete duplicate prototypes.
Those that already appear in other header files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 02:20:12 2017 +0000
prototypes.h: Delete default_done() prototype.
Function doesn't exist; removed in 38615191.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 01:58:09 2017 +0000
forwsbr.c: Move interface declaration to own forwsbr.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 01:46:26 2017 +0000
md5.c, md5.h: Reformat and delete needless portability.
The algorithm is not going to change, bugs are unlikely to appear in the
upstream RSA version, so reformat the source to be more readable, and
delete portability code now we have function prototypes with parameters,
void pointer, etc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 01:21:56 2017 +0000
Split function definition prototypes so identifier starts a line.
Nearly all were already split like this. The consistency helps ad hoc
scripting.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 01:12:17 2017 +0000
Don't have `static' of a function definition on its own line.
Join it to the next line that species the return type.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 01:09:32 2017 +0000
Move the opening brace of a C function to its own line.
If the brace doesn't start a line of its own then vi(1)'s
function-related commands don't spot the function.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 00:50:51 2017 +0000
repl.c: Add `static' to function definitions to match declarations.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 2 00:34:18 2017 +0000
repl.c, replsbr.c: Move shared data into header file.
repl.c declared global variables, and replsbr.c had extern statements
that hopefully matched them. But they're really inputs into replsbr.c's
code, so move the declarations into a new header file that both then
include, and define them in replsbr.c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 1 17:21:23 2017 +0000
uip: Replace some ints that are only ever 0 or 1 with bool.
Knowing the domain of the variable is Boolean aids comprehension of the
variable's name and purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 1 11:39:37 2017 +0000
send.c, whatnowsbr.c: Delete option variables set but never read.
Some options are passed on without the code parsing the options having
to act upon their value. These don't need to store the option's Boolean
value in a local variable that's never read.
Merge: 0ae4a073 ee49b2c5
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 31 20:48:40 2017 -0400
Merge branch 'master' of git.sv.gnu.org:/srv/git/nmh
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 31 20:48:31 2017 -0400
Clean up things a bit
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 1 00:09:32 2017 +0000
uip: Replace some ints that are only ever 0 or 1 with bool.
Knowing the domain of the variable is Boolean aids comprehension of the
variable's name and purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 31 23:46:14 2017 +0000
mhbuild.c, mhbuildsbr.c: Replace three global ints with bools.
Knowing the domain of the variable is Boolean aids comprehension of the
variable's name and purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 31 23:33:34 2017 +0000
Replace some ints that are only ever 0 or 1 with bool.
Knowing the domain of the variable is Boolean aids comprehension of the
variable's name and purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 31 21:37:24 2017 +0000
dtimep.l: Delete unused macros SKIPSP and SKIPTOSP.
Silences gcc's warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 31 14:44:04 2017 -0400
Display the command when reporting timing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 23:32:58 2017 +0000
uip: Change global int userrs to bool.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 23:29:32 2017 +0000
uip: Replace some ints that are only ever 0 or 1 with bool.
Knowing the domain of the variable is Boolean aids comprehension of the
variable's name and purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 22:13:02 2017 +0000
sbr: Replace some ints that are only ever 0 or 1 with bool.
Knowing the domain of the variable is Boolean aids comprehension of the
variable's name and purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 22:11:15 2017 +0000
mts/smtp/smtp.c: Replace int with bool.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 20:58:46 2017 +0000
nmh_init(): Replace integer parameter with two bools.
Removes the 0, 1, or 2 passed by callers. If the options get more
complex then an enum of possible actions might be a better fit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 20:29:29 2017 +0000
Replace adios(NULL, ...) with die(...).
It's the common case, and saves having to skip over the NULL when
reading, and avoids the risk of the format string being passed as the
first parameter by mistake.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 19:55:14 2017 +0000
Replace printf(3) with fputs(3) where possible.
The format string has no format specifiers, and doesn't end with `\n',
so fputs() to stdout is sufficient.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 30 19:52:11 2017 +0000
mhbuild.man: Avoid using format-free printf(3) in example.
It pops up in searches for printf()s that could be fputs(),
and as printf() it doesn't output the trailing `\n' to end the line.
Replace with puts(). Lowercase Kernighan's message, as he wrote it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 28 23:04:54 2017 +0100
msgchk.c: Rewrite checkmail(), removing need for macros.
NONEOK, MMDFOLD, etc., were only used to track simple Boolean
conditions. Rewriting the function removes the need for them, and gives
shorter, more clear, code. The macros pre-date git's history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 28 14:09:06 2017 +0100
SPECS: Use `command-line interface' in one-line summary.
Requested by David on nmh-workers. `shell' is still mentioned in the
description for searches.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 28 13:57:00 2017 +0100
whatnow: Remove undocumented printf-formatting of -prompt string.
whatnow(1)'s -prompt option would use the value as a printf(3) format
string, supplying `invo_name' as the sole value to be formatted. This
was undocumented, and upset gcc's checking of format strings. As no
requests to keep the ability appeared on nmh-workers in reply to
2017-08-09's email, treat -prompt's value as a simple string.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 28 12:38:05 2017 +0100
SPECS: Alter description to not require a GUI interface.
xmh or exmh are optional, not required to use nmh. Mention them both,
but remove the dependency on whether either is available as a package.
Add possible search terms, e.g. `MIME' and `shell'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 27 12:28:28 2017 +0100
configure.ac: Test for libtinfo to resolve setupterm(3).
ncurses 6.0+20170902-2 on Arch Linux doesn't provide setupterm(); it
did in earlier versions. This stops ./configure finding a suitable
library. Add tinfo to the search list, as that's the lower-level
library that contains setupterm() now, and place it before curses and
ncurses so the search stops if it's sufficient instead of the larger
libraries.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 26 21:14:06 2017 +0100
msgchk.c: Remove UUCP tests; unused since `#ifdef MF'.
The values UUCPOLD et al are never set so don't bother testing for them.
They haven't be possible in git's history. They were guarded in the
past by `#ifdef MF'; that stood for `mail filter'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 26 14:32:08 2017 +0100
Replace getcpy(f()) calls with mh_xstrdup() when f() can't be NULL.
And comment a few functions as never returning NULL along the way.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 25 17:43:04 2017 +0100
Delete "blank" lines at start of files to bring content into view.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 25 11:36:36 2017 +0100
utils.c: Improve comment describing add(). Suggest mh_xstrdup().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 27 16:36:57 2017 +0100
imaptest.c: Don't use error message as adios()'s format.
Add a `"%s"' format string. Stops gcc complaining.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 27 13:44:26 2017 +0100
imaptest.c: Don't test possibly uninitialised local variable.
get_imap_response() doesn't necessarily set the content of a non-NULL
`char **status'. Do this before calling, and check if it's been set to
non-NULL before using upon return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 27 13:00:13 2017 +0100
imaptest.c: Don't free brkstring()'s value; it's re-used.
Subsequent calls to brkstring() write to free'd memory, corrupting
malloc()'s internal data.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 27 12:31:54 2017 +0100
imaptest.c: Add `format(printf, ...)' attribute to functions.
Stops warnings from gcc for send_imap_command() and add_msg().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 26 21:53:58 2017 -0400
Fix invalid pointer arithmetic.
Reported by David Levine.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 26 13:47:12 2017 -0400
Support command issuance and timestamps.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 26 00:30:49 2017 -0400
Still more fiddling.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 25 23:18:02 2017 -0400
Add netsec_get_sasl_ssf().
Add the function netsec_get_sasl_ssf(), which retrieves the SSF
(strength security factor) negotiated as part of the SASL exchange.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 25 16:00:09 2017 -0400
A little closer to being somewhat useful.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 25 13:16:31 2017 -0400
Make snoop work like it used to for SMTP.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 25 13:16:04 2017 -0400
Fix up some const and unsigned char warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 25 00:01:56 2017 -0400
Improved, a bit. Slightly more useful.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 24 23:56:16 2017 -0400
Rework snoop support slightly for the new world order.
Make sure we do base64 snoop decoding at flush time. Still need to
fix SMTP support.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 24 23:16:31 2017 -0400
Rototill snoop support so it works at flush time.
Before on writes, the output snoop support would only work when it was
doing netsec_vprintf(). Do it at flush time, so it should work for
any type of write.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 24 15:32:54 2017 -0400
It does just what it says on the tin.
You should not use this unless you're the sort of person who regularly
reads the commit log. Still incomplete for now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 24 14:47:19 2017 -0400
Add context information to SASL callback.
Provide an extra context argument for the SASL negotiation callback
that application code can use to pass down information that the
callback might need.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 24 14:44:53 2017 -0400
Switch to the use of to_upper() instead of custom code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Oct 21 21:24:47 2017 -0400
Improve this documentation a bit.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 26 11:36:22 2017 -0400
Remove mmdf_magic and empty_line temp files on success.
Fixes commit b46d49ba.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 16:22:15 2017 +0100
picksbr.c: fprintf(3) function pointer using `%p' and union.
Using `%#llx' and cast to `unsigned long long' caused Cygwin woes.
Fixes 07916b2ff.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 16:06:16 2017 +0100
slocal.c: Use C99's `%td' to printf(3) ptrdiff_t values.
Using `%ld' caused Cygwin woes. Fixes 6015bb1f7.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 15:45:25 2017 +0100
inc/test-eom-align: Cut down on the flicker by re-ordering tests.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 15:41:58 2017 +0100
inc/test-eom-align: Replace case on $MBOX_TYPE with interpolation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 15:04:05 2017 +0100
inc/test-eom-align: rm(1) unwanted +inbox emails, not rmm(1).
Using rmm(1) is using the software under test. And about 50 times
slower.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 14:26:02 2017 +0100
inc/test-eom-align: Create test mboxes in less steps.
Use a couple of temporary files created at the beginning to allow runs
of alternating cat(1) and echo(1) to be a single cat. Knocks 15% off
the `make check' time for that single test in a simple trial here.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 14:10:18 2017 +0100
inc/test-eom-align: Fix MMDF-mbox `B' size calculation.
Also, have the email body end in what appears to be the MMDF magic
string for the first few bytes; otherwise, the test mbox is just a
boring single email compared to the `A', From_, version. Fixes
8699f1cc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 13:49:32 2017 +0100
inc/test-eom-align: Fix MMDF-mbox `A' size calculation.
The `...LINESZ' variables are number of bytes, not number of lines, so
MMDF's is now 5 rather than 1. And the MMDF magic string tops and tails
each email so needs to be subtracted twice, not once like From_'s.
Fixes 8699f1cc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 13:12:46 2017 +0100
test/common.sh.in: Only rm(1) if the cd(1) succeeds.
The rm specified the full path anyway, but if the cd fails for some odd
reason then it's best not to continue.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 12:56:26 2017 +0100
annosbr.c: free(3) takes void pointer; don't cast non-const pointer.
(const pointers are another whole can of worms, and their const
poisoning causes much noise for little benefit.)
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 12:31:35 2017 +0100
void-pointer parameters don't need casting to char pointer.
E.g. `memcmp((char *)digest...' doesn't need the cast if it's already a
pointer.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 12:21:48 2017 +0100
Replace `sizeof (char)' with 1, then remove if a multiplier.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 24 12:20:26 2017 +0100
Don't cast void pointer return value of malloc() et al.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 23 22:27:46 2017 +0100
Stop failed m_mktemp2() that give directory reporting get_temp_dir().
The first parameter of m_mktemp2(), if not NULL, is a path and the
basename is used as the directory to hold the new temporary file, but
the error message on failing to create that used get_temp_dir() and
that's often somewhere else, e.g. `mhbuild /dev/null' attempts /dev/...
Don't attempt to state the failed path in the error message as at least
that's not misleading. Perhaps the function needs some other indication
of success so it can pass back the attempted filename that failed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 23 18:16:26 2017 +0100
mhbuild.c: Don't use set_done() to unlink temporary files.
Because they're created with m_mktemp2(), the temporary files are
already in a list to be unlink(2)'d at exit(3), thanks to atexit(3), so
don't set_done() to attempt that twice. Updates 6bc64765f.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 23 14:29:38 2017 +0100
mhshow/test-charset: Test iconv(1)'s result, not just its exit status.
Problems with generating the input to iconv(1) were hidden as long as it
could be converted from EBCDIC-US to UTF-8 because only the exit status
was tested. Check the output is as expected too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 23 14:14:12 2017 +0100
mhshow/test-charset: printf(1)'s octal doesn't need a leading zero.
The `\0344' was being interpreted as `\034' and `4'. This can still be
converted from EBCDIC-US to UTF-8 by iconv(1) so the test worked, but it
was misleading. Remove the leading zero as printf's octal escape is
`\nnn' where nnn is one to three octal digits. It's echo(1) that
insists on a leading zero. Fixes 6fd1d18f.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 23 11:43:12 2017 +0100
inc/test-eom-align: Use octal, not hex, in printf(1) format string.
POSIX's printf(1), and dash(1)'s, does not support hex. Fixes 8699f1cc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 23 11:40:39 2017 +0100
mhshow/test-charset: Use octal, not hex, in printf(1) format string.
POSIX's printf(1), and dash(1)'s, does not support hex. Fixes 792d7e1e.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 22 19:05:49 2017 -0400
Added tests of MMDF mailbox format to test-eom-align.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 22 13:04:12 2017 +0100
runpty.c: Move child slave code into new run_command().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 22 12:49:47 2017 +0100
runpty.c: Handle fork(2) failure first, rather than child.
Gets the error handling out of the way so it can be forgotten.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 22 12:47:02 2017 +0100
runpty.c: Factor duplicate code into new open_master_pty().
Only called twice, but it shows the same actions are done both times.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 22 12:36:05 2017 +0100
runpty.c: Replace fprintf()+exit() pairs with new die().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 21 16:59:15 2017 +0100
Detect function-pointer `done' being set twice in a row.
Make `done' a function that uses a file-static function pointer, and add
set_done() to alter it. That wants either the old or new value to be
exit(3). If it's not, it still alters the stored pointer, to maintain
the existing behaviour, but emits a warning on stderr. mhbuild(1)
triggers that warning, making this hunch worthwhile.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 21 14:21:38 2017 +0100
man: Replace csh `%' prompt in examples with sh's `$'.
Youngsters these days probably wouldn't recognise csh. None of the
commands needed changing due to syntax differences.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 21 14:12:00 2017 +0100
mh-draft.man: Use ASCII double-quote for itself in example output.
Not the TeX doubling of backquote and single-quote.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 21 14:05:05 2017 +0100
man: Add backslash before backquote so it appears as sh backtick.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 19 23:16:36 2017 +0100
man: Fix backquote used in error for single quote.
A repeated bit of prose had the typo `foo` instead of `foo'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 19 11:43:30 2017 +0100
mhlsbr.c: Delete file-static function pointer mhl_action.
Never set, so always NULL due to BSS. It used to be set by c808c5d5.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 19 11:38:52 2017 +0100
mhlsbr.c: Delete `jmp_buf mhlenv', never setjmp(3)'d.
Only ever conditionally longjmp(3)'d. The setjmp() was removed by
c808c5d5.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 19 00:00:08 2017 +0100
Strip parenthesis from `return (state = OK);' and similar.
There are sufficient cases without the parenthesis that various
compilers must be happy without.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 23:38:27 2017 +0100
pop_init(): After proxy's execve(2) failure, exit(1), not exit(10).
The value 10 seems undocumented, and I can't find anything that tests
for that specific value.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 23:29:24 2017 +0100
sendfiles: Always die with exit status of 1 rather than -1.
The sh function die() took the exit status as an optional parameter,
with a default of -1, but this was never used so remove the option and
always use an exit status of 1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 15:28:26 2017 +0100
Remove preprocessor conditionals on `lint'.
Treat all tests for `lint' being defined as false. Don't know when
anyone had a lint(1) that could be run on the source, but none of the
areas had been touched in git's history, and at least one would have
been a compile error had it been defined.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 15:04:07 2017 +0100
Replace `_exit(-1)' with `_exit(1)'.
In line with other changes to limit a process's exit value to small
non-negative integers distinguishable with sh's `$?'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 12:43:28 2017 +0100
whom.c: Don't call rename(2) with source that's uninitialised.
The intent is that two rename(2)s take place: to move a file to a
backup and then return it. The first test controlled the generation of
the destination in the char array `backup' and calling the first
rename(). The second test used that same array for the restoring
rename(), but used a different test and so could run when the first
rename hadn't, and with an uninitialised array for the source filename.
The initialisation of `backup' and the first rename needed both
environment variables `mhdist' and `mhaltmsg' to be non-empty, and the
former to have a non-zero atoi(3) value. The second rename ignored
`mhaltmsg'. Bug pre-dates git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 12:31:58 2017 +0100
whom.c: Re-work fork/exec logic to clarify interaction with distsw.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 12:12:58 2017 +0100
If fork(2) fails then die; don't fall through to execve(2).
It's already been agreed that failure to fork() is so rare these days
that multiple attempts aren't required. Nor should the code persevere
by calling execve() as if the fork had succeeded, else why bother to
fork? Instead, die.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 11:59:37 2017 +0100
whom.c: Don't increment atoi(3)'s return value as it's already true.
atoi(3) has returned non-zero and distsw holds that value. Only the
truthness of distsw matters. Don't increment distsw, as if to show it's
been set, because that would turn the true -1 to false 0. Bug pre-dates
git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 18 11:56:26 2017 +0100
whom.c: Don't store atoi(getenv("mhdist")) when value only tested.
It's the non-zero value of atoi(3) that's important in the if-condition;
the value is never used again.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 17 13:19:40 2017 +0100
mhlsbr.c: Don't strchr(3) non-string NUL-less buffer.
Up to 8 KiB was read into a buffer and then strchr() used to test for a
linefeed. There was no guarantee the linefeed would be present, else
why test for it, nor that the buffer would contain a NUL to terminate
the search, either from the read bytes, or the bytes not trampled by
read(). Replace the two similar lumps of code with a new
linefeed_typed(). Bug pre-dates git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 16 22:58:11 2017 +0100
mhlsbr.c: Don't read(2) from fileno(3) of stdout.
Remove the assumption that file descriptor 1 is readable. It can be if
it, or where it was dup(2)'d from, was opened read/write, e.g. on
/dev/tty. But it can easily be arranged with shell re-direction that it
isn't, and then the read(2) fails. Pass 0, standard input's file
descriptor, instead. Don't use fileno(stdin) as I can't think of a need
to support that being non-zero, but its use makes the reader think it
might. Bug pre-dates git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 15 22:58:59 2017 +0100
Invert ternary condition to remove one negative.
Replaces `i != NOTOK ? OK : NOTOK' with `i == NOTOK ? NOTOK : OK'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 15 13:03:20 2017 +0100
mime_type.c: Fix regexp in comment that describes following code.
Fixes e35fb433.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 23:31:25 2017 +0100
addrsbr.c: Alter ismymbox() to return bool, not int.
It was returning 0 or 1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 23:29:12 2017 +0100
smtp.c: Have function returning char pointer return NULL, not 0.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 23:16:50 2017 +0100
ext_hook(): Flip if-statement condition so then-block simply returns.
No need for rest of function to be in an else-block.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 23:15:50 2017 +0100
new.c: Order two return statements to match comment.
No change in behaviour.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 23:08:00 2017 +0100
Edit out a few more tautological `the foo(5) man page'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 11:31:29 2017 +0100
nmh_completion(): Simplify, removing local variable.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 11:09:42 2017 +0100
Remove casts of NULL to a data pointer.
With a function prototype in place stating a parameter is a foo pointer,
where foo is data, not a function, then `NULL' suffices so the cast to
foo pointer is redundant. If the function parameter is retrieved with
va_arg(3) then the pointer passed must be the retrieved type, e.g.
concat()'s arguments are fetched as char pointer and so it should be
called as `concat("foo", (char *)0)'. Using NULL is incorrect, though
NULL could be used instead of 0 but still needs casting. However, the
source doesn't bother getting this right and just passes NULL in most
cases so make the few match. Most of those changed were passing NULL
cast to a void pointer.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Sep 13 00:14:43 2017 +0100
Remove more outer wrapping parenthesis from return statements.
For example, `return(foo(a, b));' becomes `return foo(a, b);'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 15:49:30 2017 +0100
dmktime(): Break assignments so `*=' and `+=' can be used.
Add comments tracking the units of `result' from days to seconds.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 15:34:31 2017 +0100
Replace `return (0)' and similar with `return 0'.
Just outer parenthesis removed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 15:02:41 2017 +0100
Hoick FENDNULL(key) out of the search loop.
`key' is a loop-invariant so can be tested for NULL once before the
loop. In one case, this also avoid passing NULL to printf(3) for "%s",
and means getcpy()s can be replaced with mh_xstrdup()s.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 14:55:16 2017 +0100
mh_oauth_cred_fn()'s return value no longer needs duplicating.
It now returns a fresh allocation so that can be used directly rather
than obtaining another copy.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 14:32:33 2017 +0100
mh_oauth_cred_fn(): Always freshly allocate result.
If a `credential-file' context was found, and started with a `/', then
the m_defs's n_field was returned, otherwise a newly allocated string.
The caller couldn't tell whether to free the result or not so memory was
leaked. Alter it to always freshly allocate the result. Fixes
803f25412.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 13:26:22 2017 +0100
exmaildir(): Don't leak memory allocated by path().
Bug pre-dates git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 13:20:56 2017 +0100
mime_type(): Don't leak memory allocated by get_file_info().
Fixes b4f2851d4.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 12:40:49 2017 +0100
lock_file.c: close(2) file descriptor on failure, avoiding leak.
Fixes d6e398f9c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 00:07:50 2017 +0100
mhfixmsg.c: Fix memory leak of temporary filename if write fails.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 12 00:06:35 2017 +0100
mhfixmsg.c: Fix memory leaks of boundary string on early returns.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 11 18:56:50 2017 +0100
Delete mh_xfree(), changing callers to call free(3) instead.
A free(3) that didn't handle NULL is now long past.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 11 18:37:38 2017 +0100
rmf.c: free(3) return value from m_mailpath() calls.
And add comment to m_mailpath() that its return value needs freeing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 11 18:28:10 2017 +0100
path.c: Add comments declaring return values must be free(3)'d.
Saves working it out afresh each visit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 11 18:25:20 2017 +0100
path.c: Remove path()'s test for expath() returning NULL.
All paths out of expath() have it calling mh_xstrdup().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 11 18:23:33 2017 +0100
path.c: Re-format path() to make it more clear what's happening.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 18:12:38 2017 +0100
slocal.c: Alter trim() to return static array, not malloc(3).
The callers are immediately passing the return value to printf(3) for
"%s". There's only one call per printf(). None of the callers are
bothering to free(3) the existing return value. Return the address of
trim()'s char array, now static, instead. Leave trim() returning NULL
when passed NULL, even though that gives NULL to print(3) for "%s". It,
and slocal's other bugs, remain.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 17:19:56 2017 +0100
Remove test for `\0' in `*s && isfoo(*s)' for ctype.h calls.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 15:11:18 2017 +0100
find_cache(): Remove test that's always false.
The if-statement's condition is a conjunctive that tests `!writing' and
then, only if that's true, calls find_cache_aux() and tests `writing' in
determining the first argument; that must be false. Bug pre-dates git
history.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 15:03:09 2017 +0100
readline(3) wrapper: Move free(3) of line to where it's reachable.
Every line returned by readline() has to be freed. The call to free()
was unreachable because all paths heading towards it veered off,
resulting in a memory leak. Move the free() to just after where the
line has been used for the last time. Fixes 3a85e0bc9.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 14:53:32 2017 +0100
fmt_compile.c: Alter FINDCOMP(): the caller must supply the semicolon.
The macro expands to a for-loop, including the semicolon body. The
caller typically supplies their own semicolon. This results in two on
one line that looks odd. Alter the macro to have the for-loop inside a
do-while loop that doesn't have a semicolon, ensuring the caller must
supply it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 14:44:15 2017 +0100
argsplit(): Incorrect type used in sizeof calculation for array.
Switched to referring to the variable being assigned the resulting
memory rather than duplicating its type information. Fixes 78211e93.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 14:22:29 2017 +0100
get_file_info(): Flip logic throughout, reducing nesting.
Now a series of small paragraphs, each of which might return on error.
Also, the Cygwin oddity described in the comment needs no special
handling given the recent bug fixes so it can be deleted.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 13:38:18 2017 +0100
get_file_info(): Don't return filename from quote onwards on error.
If `file_name' contained a quote then `cp' points to it, and remains
pointing to it if any of concat(), popen(3), or fgets(3) fail to give
the expected result. On returning, cp is not NULL and so strdup(cp) is
returned. Also, if fgets() fails on Cygwin in the way the comment
describes then cp is wrongly free(3)'d. (One of the problems with
generic variable names is their overloaded semantics cause faulty
re-use.) Fixes b4f2851d and 0c50c669.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 13:29:46 2017 +0100
get_file_info(): Don't dereference out of scope char array.
A pointer to `char buf[...]' is taken, the array being declared in a
block scope inside the function. The pointer is passed to strdup(3) as
the function returned, but the array is by then out of scope. Move the
array to the function's scope. Fixes 0c50c669.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 12:28:51 2017 +0100
Replace parallel MIME-preference arrays with struct array.
New array of struct has `type' and `subtype' members, replacing the old
preferred_types[] and preferred_subtypes[] arrays.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 12:14:20 2017 +0100
pidstatus(): Rewrite to print stopped and continued statuses too.
Delete own versions of WTERMSIG and WCOREDUMP macros now we're assuming
POSIX.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 11:35:20 2017 +0100
pidstatus(): Delete commented-out code testing for exit(255).
Pre-dating git, a test of wait(2)'s status having its top eight bits all
set was commented out an "I've no idea what this does" explanation. The
top eight bits hold either exit(3)'s parameter or the signal that caused
the child to stop. Either way, there are macros for pulling apart that
value and they're being used. Perhaps they were broken on a much older
system. Delete the comment, including its code.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 10 11:21:42 2017 +0100
Replace printf("%s\n", foo) and similar with puts(foo).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 23:27:00 2017 +0100
datetime.c: Flip if-conditions so returns move from else block.
Then there's no need for else-blocks after return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 22:56:45 2017 +0100
icalendar.l: Refer to base64.h relative to root of source.
Ken reported a missing-include-file problem when building so the product
ends up outside the source tree, e.g. running configure from elsewhere.
It must also depend on his environment, e.g. OS or compiler, because the
problem isn't reproducible with Arch Linux and gcc, and be specific to C
source built from other source files, e.g. lex(1). However, given that
the existing sibling icalparse.h is referred to as sbr/..., duplicate
that so it builds for Ken too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 22:45:54 2017 +0100
test/getcanon.c: exit(3) with 0 or 1, not -1 or symbolic error code.
gethostname(3) returns -1 on failure and that was being returned from
main; use 1 instead. getaddrinfo(3) returns EAI_ADDRFAMILY et al on
failure, but here they're defined as small negative integers, unsuitable
for main()'s return value; again, use 1 instead. Along the way, flip
the logic so the end is nigh when possible, avoiding the cognitive
overhead of tracking state when continuing to read through the source.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 22:08:43 2017 +0100
test/getfullname.c: Move return case first in if-else chain.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 21:56:42 2017 +0100
Refer to #include files from the root of nmh's source.
One of the -I options given to the C compiler is the root of the nmh
source. This means uip/foo.c's #include of the relative ../sbr/bar.h
can also be written more tidily as sbr/bar.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 21:30:39 2017 +0100
icalparse.y: Remove else-block that returns by merging if-conditions.
The code tested two values to see if they were present, and if they
were, and were equal, then it returned this node. If either were
missing then this node was still returned because it matched the more
limited criteria that had already been tested. So the test for
returning this node can more simply be if either value to compare is
missing, or they're (both present and) equal.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 18:29:58 2017 +0100
seq_setprev.c: Flip if-condition so return moves from else block.
Then no need for else block after return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 18:28:31 2017 +0100
folder_pack.c: Flip if-condition so return moves from else block.
Then no need for else block after return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 18:27:42 2017 +0100
seq_setunseen.c: Flip if-condition so return moves from else block.
Then no need for else block after return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 18:26:45 2017 +0100
mhstoresbr.c: Flip if-condition so return moves from else block.
Then no need for else block after return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 18:20:09 2017 +0100
read_switch_multiword.c: Flip if-condition so return moves from else block.
Then no need for else block after return.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 12:26:40 2017 +0100
datetime.c: Don't atoi("0") if zone is NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 12:05:22 2017 +0100
datetime.c: Fix parse-failure's error-message's daylight indication.
`in_standard' was being used to decide between `standard' and `daylight'
in the error message, but it would always be false by that point.
`in_daylight' is what's passed to the parsing function so use that to
determine the string instead. Bug present since the initial
implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 11:57:15 2017 +0100
datetime.c: Replace some int with bool.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 11:32:01 2017 +0100
Only call fork(2) once, not up to five times on failure.
The existing loop that slept five seconds between each attempt was
copy-pasted widely. Those days are gone. Just call it once.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 9 11:13:11 2017 +0100
content_error(): Add missing va_end(3).
A va_start(3) without a matching va_end() is undefined behaviour.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 8 13:46:08 2017 -0400
Send a QUIT instead of RSET at session end when doing 'whom'.
When running 'whom -check' (which really invokes post(8)), at the
end of the SMTP session we would send a RSET instead of a QUIT. This was
technically a RFC violation (RFC 5321 says a QUIT has to be the last
thing you send), and this would cause some SMTP servers to complain.
So make sure if we're being invoked by whom to send a QUIT at the end
of the session. Reported by Ralph Corderoy.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 8 12:08:41 2017 -0400
Add a -credentials argument when we call post.
If we are using -check, post(8) will need to talk to a remote SMTP server,
and it might need to perform authentication when doing so. So include a
-credentials option if there is the appropriate line in the user's profile.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 8 14:49:21 2017 +0100
popsbr.c: Remove impossible case from switch statement.
Actually, just convert the overkill switch statement into a couple of
if-statements as it's a lot less lines.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 8 14:30:31 2017 +0100
mhbuildsbr.c: Attempt fork(2) multiple times, as intended.
The loop attempting fork() intends to try five times but the comparison
operator was wrong so would only try once. Bug present since pre-git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 8 14:12:51 2017 +0100
base64.c: Don't out-of-bounds printf("%s", &encoded[-1]).
`cp' is walking through encoded[] when an error occurs and is stepped
back up to 20 elements to provide some lead-in context for the error
message. If might be stepped back to encoded-1, but it attempts to cope
with that by `cp ? cp : encoded'. cp is always non-NULL so true and cp
is printed. Presumably, `cp > encoded' was meant. But it's all a bit
of a rigmarole so just use min() instead to ensure cp stays within
encoded and print cp. Fixes bfc6b93af.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Sep 8 13:48:29 2017 +0100
content_error(): Don't strlen(invo_name) that might be NULL.
Earlier in content_error(), it checks invo_name isn't NULL before using
it. Later, it passes it to strlen(3) without the check. Either the
former is redundant or the latter wrong. Rather than work out which,
delete the strlen(invo_name) because it was only used for a
variable-width indent on a second diagnostic line. Instead, indent by a
fixed four spaces, which will look better when invo_name is stupidly
long anyway. Bug present since pre-git.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 7 10:36:56 2017 +0100
replsbr.c: In parent, free child's argv[] built before fork().
Fixes ccafa1944.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 7 10:16:36 2017 +0100
getpass.c: Don't fileno(NULL) when fopen("/dev/tty") fails.
If stdin is a TTY, but opening it for writing fails, then stdin and
stderr are used as defaults and the TTY doesn't have echo disabled. The
later test to restore echo just checks if stdin is a TTY and not that it
was opened successfully causing a NULL FILE pointer to be fileno(3)'d.
Fixes da6af9633. This function's logic remains a bit contorted; I went
for the minimal fix.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 7 10:03:25 2017 +0100
mhbuildsbr.c: Don't free(3) string then print it; do reverse.
Fixes c87ca5cca.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Sep 7 09:57:11 2017 +0100
smtp.c: Use read-end of pipe, not random integer.
Instead of `pdi[0]' the array of two elements was being indexed by `i'.
That is typically zero so everything works, but can be up to five
depending how many times fork(2) failed before succeeding. Fixes
e65127948.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 5 10:51:00 2017 -0400
Revised expected output with -prefer in test/mhlist/test-mhlist.
Update to commit 5dce1b38ace6cf61398df3ee4ca5aee0e1dedb5d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Sep 5 14:11:56 2017 +0100
man: Fix some of the font-changing macros' parameters.
Various recurring problems on two themes. `.BR foo,' lacks the space in
`.BR foo ,'. `.IR foo' doesn't need to alternate and can be just `.I
foo'. Other similar changes made, e.g. `.B foo' becoming `foo'.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Sep 2 11:24:01 2017 -0400
Add -noprefer switch to mhshow, mhstore, and mhlist
Allow profile-specified -prefer switches to be cancelled from the
command line.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Sep 2 09:13:44 2017 -0400
Change the priority ordering for multiple -prefer switches
Interpreting multiple -prefer switches in ascending priority
order allows the command line to override the user's profile.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 4 12:01:35 2017 +0100
man: Use `.IR' for `foo(1)', not the few `.BR'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 4 11:59:48 2017 +0100
man: Change the tautological `the foo(1) man page' to `foo(1)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 4 10:42:17 2017 +0100
oauth: Replace `if...return false; return true' with `return ...'.
In functions returning bool, these are equivalent.
Before: After:
if (!foo()) return foo();
return false;
return true;
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 4 10:29:21 2017 +0100
oauth.c: Remove unused assignments of function return value.
`if ((status = foo()) != OK) return false;' doesn't need to set local
variable status.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 4 10:07:35 2017 +0100
Replace FALSE and TRUE with C99's false and true.
Remove the duplicate definitions of FALSE and TRUE. Change a few
variables from int to bool at the same time. The semantics of bool are
different to int because `bool b = 42' maps 42 to 1, but if the code was
relying on that then it needs shaking out anyway.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Sep 4 10:03:36 2017 +0100
print_intro(): Change parameter brief from int to bool.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 23:37:52 2017 +0100
flist.c: Use bool instead of int for some of the flags.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 23:29:36 2017 +0100
Replace boolean with bool everywhere.
boolean's comment said it existed to ensure storage was a char and not
an int so it could be packed in a struct, but the only struct using it
doesn't care about the space taken.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 15:41:04 2017 +0100
mh.h: Always define NMH_UNUSED as a cast to void.
The not-gcc-or-earlier-than-gcc-2 version was the identity function
seems unnecessary as what C99 compiler would complain about a cast to
void?
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 15:38:44 2017 +0100
mh.h: Move the gcc-4.3-conditional macro definitions.
Having them outside of the gcc-2 ones makes the logic easier to follow
as there's no nesting.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 13:35:34 2017 +0100
dropsbr.c: Remove unused ntohl() macro, and its NTOHLSWAP test.
Not used since e6c91771 removed support for ./.foo.map index for ./foo
mailbox.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 13:32:24 2017 +0100
fakehttp.c: Remove unused LINESIZE macro; never used.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 13:30:34 2017 +0100
config.c: Remove unused nmhdocdir() macro.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 12:23:14 2017 +0100
ap.c, dp.c: exit(3) with 0 or 1, not [0, MAX_EXIT].
Don't attempt to indicate the number of failures through the exit status
as that's too constrained. Just stick to zero for none, and 1 for some.
Delete, the now unused, MAX_EXIT.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 12:18:59 2017 +0100
DEFAULT_PAGER: Move from nmh.h to mh.h. Former is "config.h".
The macro isn't related to platform independence, unlike the rest of
nmh.h, that starts by including config.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Sep 3 00:22:18 2017 +0100
geteditor.c: Hard-code the default, "vi".
It was the only use of the DEFAULT_EDITOR macro, so that can be deleted.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 2 18:49:11 2017 +0100
Move base64.c's prototypes from prototypes.h to new base64.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 2 17:38:33 2017 +0100
mhbuild.man: Fix grammar indentation by expanding tabs.
The grammar is pre-formatted using spaces for indentation.
A few lines had switched to tabs in 9b706433f.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Sep 2 13:55:29 2017 +0100
decodeBase64(): Limit length of error message on invalid input.
Screenfuls of email were appearing on stderr.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 28 21:03:21 2017 -0400
Restrict use of alloc_size function attribute to gcc >= 4.3.0.
It's not supported by gcc 4.2.4. CHECK_PRINTF doesn't work
perfectly with gcc 4.2.1, so disable that with gcc < 4.3.0 as
well. Fix to commit c066b395274021182a5f0530ccfeb1bcd167d860.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 19:57:16 2017 +0100
Move read_line.c's prototypes from prototypes.h to new read_line.h.
Add copyright comment to start of read_line.c whilst there.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 19:47:23 2017 +0100
Add ENDNULL macro for gcc's `sentinel' function attribute.
Annotate a few prototypes with it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 19:33:53 2017 +0100
Move terminal.c's prototypes from prototypes.h to new terminal.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 18:13:17 2017 +0100
Fix spelling in comment.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 18:09:59 2017 +0100
read_switch_multiword.c: siglongjmp(3) removes need for `else'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 18:08:31 2017 +0100
mhlsbr.c: Don't need to `else' after longjmp() at end of then-block.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 18:05:41 2017 +0100
Remove comment asking if siglongjmp(3) should be used; it is.
77a8a873b switched from longjmp(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 18:00:11 2017 +0100
Don't need to `else' after mhladios() at end of then-block.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 17:57:04 2017 +0100
Give mhldone() and mhladios() the NORETURN function attribute.
And remove `FALLTHRU' comments after their calls.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 17:53:15 2017 +0100
Don't cast zero to pid_t for setpgid(2)'s first argument.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 17:52:12 2017 +0100
Don't cast zero to char for storing at pointer to char.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 17:49:29 2017 +0100
Don't cast zero to a non-function pointer; use NULL instead.
Better still, omit it when BSS does the job, or C's treatment of
non-zero as true is sufficient.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 14:45:16 2017 +0100
mhparse: Change mhfixmsg flags from int to bool.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 14:35:15 2017 +0100
mhparse.h: Add externs for skip_mp_cte_check, etc.
Delete the local copies from the other user.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 14:34:44 2017 +0100
Delete declaration already available from included header file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 14:25:11 2017 +0100
mhparse.h: Add externs for preferred_types[], etc.
Delete the local copies from other users.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 14:16:51 2017 +0100
Delete declarations already available from included header files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 13:52:48 2017 +0100
mhbuildsbr.c: Include mhcachesbr.h. Delete copy of prototype.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 13:50:41 2017 +0100
mhfixmsg.c: Make mhfixmsgsbr() static.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 13:37:24 2017 +0100
Move NPARTS and NTYPES from mhparse.h to mhmisc.h.
It's mhmisc.c that has the global arrays that use them.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 13:32:38 2017 +0100
mhmisc.h: Add mhmisc.c's global variables as externs.
Delete the local copies from other users.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 13:25:53 2017 +0100
Create mhmisc.h with mhmisc.c's global-function prototypes.
Delete the many local copies from each caller.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 13:08:34 2017 +0100
Make functions with no external callers by name static.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 12:47:38 2017 +0100
rcvtty.c: Remove duplicate prototype. Other in mts.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 28 12:45:32 2017 +0100
aliasbr.c: Remove duplicate prototypes. Others in aliasbr.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 20:04:42 2017 +0100
mhparam: exit(3) zero if all components found, else one.
The exit status used to be a count of the number missing, clipped to
120. That doesn't seem useful, and is overhead to document, read, and
test. Use the normal Unix 0 or 1 instead.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 27 09:25:21 2017 -0400
Ensure that mhfixmsg exit status is either 0 or 1.
Ralph noticed where exit status values were being accumulated, and those
values could include -1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 14:08:22 2017 +0100
Add gcc's pure function attribute.
Mark quite a few function prototypes with it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 13:52:46 2017 +0100
inc.c: Make maildir_srt() static.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 12:13:39 2017 +0100
Replace add(foo, NULL) with mh_xstrdup(foo).
add()'s arguments are back to front so add(foo, bar) produces bar+foo in
the normal case. Thus add(foo, NULL) is read as the jarring NULL+foo.
Removing the NULL with mh_xstrdup() avoids this. FENDNULL is used when
it isn't obvious foo can't be NULL as add() treats it as "" in that
case.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 11:53:26 2017 +0100
Replace strlen("foo") with LEN("foo").
The existing LEN() uses sizeof.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 11:47:02 2017 +0100
context_find.c: Hoist strlen(3) out of search loop.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 11:34:50 2017 +0100
Add die(fmt, ...). Equivalent to adios(NULL, fmt, ...).
Avoids the noise of the `NULL' first parameter that's used in over 70%
of adios() calls. Removes the possibility of it being omitted and `fmt'
being used instead. `die' is already in use in nmh's shell scripts.
Had to rename post.c's existing die() to avoid it clashing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 10:49:10 2017 +0100
mhparam: Remove `libdir', deprecated in 1.7.
Use existing `libexecdir' instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 10:39:11 2017 +0100
pick: Remove support for MHPDEBUG environment variable.
It was deprecated in 1.7, and the -debug option gives the same
behaviour.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 27 10:16:11 2017 +0100
Add MAX_EXIT, value 120, to limit some more exit(3) values.
mhparam(1) altered to use new macro. ap(1) and dp(1) now limit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 22:40:40 2017 +0100
mh_xmalloc() et al: Use C99's `%zu' to print size_t.
Author: David Levine <levinedl@acm.org>
Date: Sat Aug 26 16:06:52 2017 -0400
Treat %(myhost) failure to match canonical hostname as information.
Not an error from test-myhost.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 19:24:05 2017 +0100
Replace printf("foo\n") with puts("foo").
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 19:19:16 2017 +0100
Add gcc's nonnull function attribute.
Apply it to some prototypes to get started.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 18:41:42 2017 +0100
Use C99's variable-argument preprocessor macros for ALLOC_SIZE.
ALLOC_SIZE2() can be deleted.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 18:15:21 2017 +0100
Add gcc's malloc function attribute.
Mark wrappers for malloc(3), strdup(3), etc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 18:02:59 2017 +0100
fmt_rfc2047.c: Tables hexindex[] and index_64[] can be const.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 17:36:31 2017 +0100
Add gcc's const function attribute.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 17:29:08 2017 +0100
Add gcc's alloc_size function attribute.
Used for malloc-wrapper, etc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 15:01:35 2017 +0100
Add more NORETURN and CHECK_PRINTF function attributes.
And fix the errors that the compiler then detects.
Author: David Levine <levinedl@acm.org>
Date: Sat Aug 26 07:30:30 2017 -0400
Changed failure exit status of mkstemp(1) from 255 to 1.
For consistency, on Ralph's suggestion.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 26 11:51:06 2017 +0100
forw.man, mh-mime.man: Add missing commas in `SEE ALSO' list.
Inspired by 6db45651.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 25 22:43:46 2017 +0100
picksbr.c: Specify parameters of nexus's n_action function pointer.
Omitting them is obsolescent by modern C standards.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 25 22:36:01 2017 +0100
Print pointers in debug with C99's `%p' rather than `0x%x'.
The `%x' needed a double cast, the `%p' needs just a single to void
pointer. The output can differ, e.g. `0x0' v. perhaps
implementation-defined `(nil)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 25 22:20:17 2017 +0100
picksbr.c: fprintf function pointer with unsigned-long-long cast.
It was previously a double cast, to unsigned long, and then to unsigned
int, and formatted with `0x%x'. Now we're C99, at least, we can use
unsigned long long and `%#llx'. Though the fprintf() in question should
be a BUG() that abort(3)s.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 25 19:35:55 2017 -0400
Fixed extra and missing trailing commas in SEE ALSO sections of man pages.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 25 09:45:00 2017 +0100
build_nmh: Stop -d enabling assert(3)s.
c347c3bb enabled asserts by default so alter -d's description to not say
it enables them as this may make users thing that have to disable
optimisation, -d's other action, to get them. Don't add
`--enable-assert' to configure's options.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 24 20:09:00 2017 +0100
Format with `%#x' instead of `0x%x' if difference matters not.
Zero formats as `0' rather than `0x0', but that doesn't matter in debug
output, or an error message about a byte's value to the user.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 24 16:03:44 2017 +0100
mhlist -verbose: Don't duplicate message/external-body's parameters.
The test of eb_flags remains, and since the old code used to insist
eb_access, `access-type', was set, the new code adds a note if it's
missing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 24 15:56:06 2017 +0100
mhparse.c: Correct comment; si_val is the `anonymous' Boolean.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 24 13:18:01 2017 +0100
mhlist -debug: Print FILE pointers with `%p', not `%#x'.
Removes the double casting.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 23:38:50 2017 +0100
mhbuildsbr.c: Ensure temporary FILE closed regardless of success.
If the fopen() succeeded, but the fwrite() failed, then the FILE wasn't
fclose()'d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 22:50:33 2017 +0100
mhbuildsbr.c: Flip logic, moving goto to then-block; no need for else.
Also makes more clear a FILE pointer that's probably not fclose()'d.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 22:16:32 2017 +0100
Flip logic, moving goto from else- to then-block.
Thus removing the need for the `else'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 22:11:49 2017 +0100
Don't need to `else' after done() at end of then-block.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 22:04:42 2017 +0100
Don't need to `else' after adios() at end of then-block.
Only true of simple if-else rather than a chain.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 21:39:59 2017 +0100
sh scripts: Remove `else' after exit at end of then-block.
Only for simple if-then-else-fi with no elif.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 21:38:55 2017 +0100
uip/rcvtty.c: Flip logic, moving `return' to then-block.
There's then no need for an `else' around the old then-block.
Before After
if (foo) if (!foo)
bar(); xyzzy();
else return;
xyzzy(); bar();
return;
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 21:25:52 2017 +0100
Remove the `else' after a simple if-then block ending in `break'.
Before After
if (foo) if (foo)
break; break;
else bar();
bar();
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 21:20:25 2017 +0100
mhlistsbr.c: Replace list_application() with body at call site.
list_application()'s comment said the function didn't need to exist.
It's correct, so delete it. The sole caller now calls list_content(),
as list_application() used to do. That's actually the same as other
cases in the switch so merge them. There is a slight difference:
list_application() used to call list_content() and then return OK
regardless, now it returns list_content()'s value, but that's always OK
too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 00:22:58 2017 +0100
mhmail: Turn sh's else-if into elif.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 23 00:17:22 2017 +0100
Join the lines of another couple of `else if'.
It's misleading to have them on separate lines, especially when there's
a blank line in between.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Aug 23 12:08:24 2017 -0400
Make sure we return the descriptor from the file handle. Noted by
Ralph Corderoy.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 21 15:02:51 2017 +0100
Reformat else-if that are split over two or more lines into one.
No functional change intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 21 14:44:19 2017 +0100
Convert some Boolean variables to the bool type.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 21 12:06:40 2017 +0100
Convert some Boolean variables to the bool type.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 21 11:09:02 2017 +0100
Add ZERO(p) for the typical memset(p, 0, sizeof *p) dance.
Also seen as memset(&foo->bar_xyzzy, 0, sizeof foo->bar_xyzzy). I find
it tedious to keep checking the parameters are in agreement when reading
the code.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 21 16:44:07 2017 -0400
Removed conditional addition of -D_FORTIFY_SOURCE=2 from CPPFLAGS.
And added to CFLAGS in build_nmh.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 14:59:26 2017 +0100
man: Vet the NAME sections, especially mhfixmsg's.
Don't limit mhfixmsg to fixing "nmh MIME" emails.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 14:16:09 2017 +0100
cppflags.m4: Don't trample CFLAGS and CPPFLAGS.
They were always being restored, but not necessarily saved first. There
might still be some odd behaviour in this area. I'm seeing -D...
preprocessor symbols disappear on subsequent runs causing compilation
problems, e.g. strcasecmp(3) not prototyped.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 20 09:20:49 2017 -0400
Add -D_FORTIFY_SOURCE=2 to CPPFLAGS instead of AM_CPPFLAGS.
To make it easier for packagers to override.
Fix to commit 35d2b4dc00d705e6816bcb0ccab491aabda688dc.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 20 08:50:17 2017 -0400
Restored old NAME in mhical(1) man page.
mhical only operates on iCalendar event requests, not messages.
Fix to commit 0e7daaa2daf6c668c8c6feb9da3c9a6639fa4e7e.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 12:33:38 2017 +0100
scan.man: Note that %{body} does not decode MIME.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 12:20:45 2017 +0100
sbr/mf.c: Simplify logic, ditching endless for-loops and switch.
Some of the control flow follows the pattern of the larger sections: an
endless for-loop with a switch, and then cases that continue or break,
and another break out of the for loop. For the simpler cases, it's much
easier to read a simple while-loop that achieves the same in fewer
lines. No functional change intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 11:56:55 2017 +0100
sbr/mf.c: Remove QUOTE macro, use its '\\' definition instead.
The name suggests a quote character, not the backslash as an escape
character that quotes what comes after it. It's easier to read '\\' and
instantly know what's meant.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 11:38:04 2017 +0100
contains8bit(): Don't fetch a byte when start >= end.
The test for a NUL byte was before the test for start being before end.
Whilst here, hoist the test of end out of the per-byte loop, alter the
function to return bool, and merge the two, different, comments
explaining the function's behaviour.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 10:34:01 2017 +0100
NEWS: Add bug fix: EPIPE when writing error no longer recurses.
Also move an existing item into the Bug Fixes section.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 20 09:31:18 2017 +0100
NEWS: Consistent punctuation. Mention SI and IEC quantities.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 19 15:58:49 2017 +0100
test-sendfiles: Feed `lzma -cd' stdin rather than a filename.
HÃ¥kon Alstadheim reported that Debian's lzma-9.22-2 would complain at
`lzma -cd foo.tar' with `unknown suffix -- unchanged' even though it was
not being asked to alter the file, or produce a new one based on its
filename. This appears to be https://bugs.debian.org/700681. The lzma
from Arch Linux's xz 5.2.3-1 does no have this fault. Work around it by
feeding the file to decompress on standard input for all the compression
programs being tested; none of the others should mind.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 18 23:18:15 2017 -0400
Protect fileno() call against NULL argument.
Fix to commit 337b4e616e8f53ba06285b1645e1df9918ed5c16. Thanks to
Norm for reporting and Ken for diagnosing the bug.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 18 14:29:59 2017 +0100
lock_file.c: Compiler warns of unused isnewlock if HAVE_LIBLOCKFILE.
Author: David Levine <levinedl@acm.org>
Date: Thu Aug 17 19:45:20 2017 -0400
Default CFLAGS to -std=c99 instead of -ansi.
gcc -ansi -pedantic issued a few warnings about C90 not supporting the
"ll" printf length modifier. Ralph pointed out that
http://www.unix.org/version4/overview.html says:
The following source code portability standards lie at the core of
the Single UNIX Specification:
POSIX.1-2008
(This is technically identical to the Base Specifications, Issue 7;
they are one and the same document.)
The ISO/IEC 9899:1999 standard
So perhaps we're wrong to expect modern POSIX code to compile as C90.
Author: Leonardo Taccari <iamleot@gmail.com>
Date: Thu Aug 17 19:42:48 2017 -0400
mhical expected an ics file as input and after just pressing
^D I've found that mhical wasn't happy about an empty input.
A trivial patch that should fix this issue.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 17 12:42:57 2017 +0100
Both f_typestr(): Remove parenthesis from long list of returns.
It's not a function call, they're just noise.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 17 12:36:50 2017 +0100
Both f_typestr(): Rebuild switch from FT_* to string from scratch.
Adds missing cases, e.g. FT_LS_CFIND. Removes inconsistent "FT_" prefix
from some strings, e.g. FT_LS_DECODE. Re-orders cases to match
definitions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 17 12:20:16 2017 +0100
fmtdump.c, fmttest.c: Remove tests for FT_LIT_FORCE.
It isn't defined, and git-grep(1) suggests it was a local Lawrence
Berkeley Laboratory modification that output a literal without consuming
any of the width budget.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 17 12:09:43 2017 +0100
Makefile.am: Remove `test -d' guarding `mkdir -p'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 17 11:59:38 2017 +0100
Makefile.am: Remove multiple `mkdir -p' for etc; use ./configure.
A `mkdir -p' was used in each rule that created a file in etc to ensure
the directory already existed. Ken pointed out existing ./configure
code to do that for the man directory, just once. Use that for etc too.
Remove the `test -d' because `mkdir -p' does that itself.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 17 11:35:51 2017 +0100
cpnumber(): Cast desired width to size_t to silence gcc's warning.
Add a comment on `wid = -wid' that it's OK because wid's value was
originally a short so won't remain the same value.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Aug 17 01:24:08 2017 -0400
Fix bug in cpnumber().
The cpnumber() function (which handles the NUMF instruction, among others)
would hang if a 0 width was given to it. Make sure that (and negative
widths) are handled correctly. Note that normally NUMF did not handle
left padding which is indicated by a negative width; that may change
in the future.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Aug 17 01:12:22 2017 -0400
Improve installation documentation
Fix up the various installation information so it matches reality.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Aug 16 23:55:23 2017 -0400
Make sure the %(kilo) and %(kibi) instructions are in fmttest(1).
Man, we should really merge fmttest and fmtdump at some point.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 16 13:44:32 2017 +0100
INSTALL: Update c89(1) mention to c99(1), that exists today.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 16 00:49:02 2017 +0100
getcwidth.c: Use WCHAR_MAX, not __WCHAR_MAX__.
Former is clearly part of POSIX.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Aug 14 00:52:57 2017 +0100
inc.c: Use closure for pop_retr()'s action callback.
Allows file-static variables to become local to a function. In fact,
two of them no longer need to exist: one of them becomes the closure's
struct's member, and the other is always 0 and probably just present due
to copy and paste.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 18:07:33 2017 +0100
inc.c: Alter pop_action() to check I/O, perhaps returning NOTOK.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 17:54:59 2017 +0100
popsbr.c: Alter traverse() to check action callback's result.
The action callback returned zero, with a 1999 comment asking if it was
checked. traverse() didn't check it. Change it so it does, wanting
`OK' if all's well, else returning the non-OK value to traverse's
caller; though that only checks for NOTOK. No functional change
intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 17:13:34 2017 +0100
pop_retr(): Add a `void *closure' to be passed to action callback.
Only caller passes in NULL for the moment, and doesn't use it in the
callback, but it will allow fewer scopes by name of the variables the
action callback uses.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 16:58:14 2017 +0100
inc.c: Narrow scope of inc_type. Chain mutually-exclusive ifs.
Joining the separate if-statements with `else' tells the reader it's not
expected that more than one branch can be taken. Useful when each is
many lines long. No functional change intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 16:33:06 2017 +0100
scan(): Don't ioctl(2) for TTY's width every call.
Saves a system call per message scanned. Does mean it won't adjust
should the terminal width change mid scan, but that seems fine; after
all, the retrieved width could be out of date by the time a message's
output is written anyway.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 15:20:14 2017 +0100
m_getfld() et al: Replace with m_getfld2(), etc., in many places.
The difference is the FILE pointer isn't passed in on each call.
Instead, it's stored in the m_getfld_state_t once, on
m_getfld_state_init(). No functional change intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 13 15:04:58 2017 +0100
post.man: Detail -port's default value: submission, 587.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 11 16:54:31 2017 +0100
mhmisc.c: Indent with "%*s" rather than "%*.*s".
No functional change intended, but it does silence one of gcc's warnings
given severe enough options.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Aug 11 15:34:41 2017 +0100
mhparse.c: Cast ptrdiff_t from subtraction to long.
Cygwin's 32-bit doesn't like `%ld' for the `p - q' difference between
two pointers as the value is an int, not a long. printf(3)'s `t' length
modifier, for ptrdiff_t, can't be used as that's C99, and we're C90.
Cast the difference to a long explicitly instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 10 15:44:20 2017 +0100
m_getfld() et al: Add wrapper without FILE *iob parameter.
m_getfld(), m_getfld_track_filepos(), and m_unknown() all take a FILE
*iob that's used to update *m_getfld_state_t, even though it's probably,
hopefully, the same as the previous calls. Create wrapper functions for
these with an arbitrary `2' suffix that don't have this parameter.
After checking the m_getfld_state_t is initialised, they pass in its
existing FILE *iob. This allows callers to transition to the wrappers
in the cases where it's obviously the same FILE *iob being passed in.
It isn't always obvious, in part because of the convention for calling
this variable `in', even when it's a file-level static, a word that also
occurs in comments.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 10 15:30:54 2017 +0100
m_getfld.c: Make m_getfld_state_init() public.
This allows callers to use it if they wish to pass in its FILE *iob.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 10 00:08:55 2017 +0100
m_getfld.c: Alter Peek() to call Getc() and Ungetc().
Functionally equivalent, not called too often, and it gets rid of
another copy of the logic to decide if we've enough, should read some
more, etc.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 23:56:27 2017 +0100
m_getfld.c: Alter Peek() to match Getc()'s structure.
Their logic was equivalent, but written differently, which didn't help
the reader easily see they were the same apart from whether the returned
character was consumed. Now they're visually similar too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 19:46:26 2017 +0100
m_getfld.c: Use intmax_t and PRIdMAX to printf off_t values.
Compiling for ISO C90 prohibits casting to long long and printing with
"%lld", and printing as "%ld" is wrong on Mac OS where David reports
off_t is long long.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 17:03:24 2017 +0100
leave_getfld(): Don't follow fseeko(SEEK_SET) with ftello().
If fseeko(3) didn't error then we know the stream's position and the
ftello(3) is not needed. Set last_caller_pos to total_bytes_read
instead. This small change is a commit to help future bisecting.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 16:28:26 2017 +0100
test/getcwidth.c: Allow for 8-bit and 16-bit wchar_t.
David found Cygwin has a 16-bit wchar_t, and gcc's -fshort-wchar will
allow it to be altered on platforms where it would normally be 32 bit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 16:00:17 2017 +0100
fmtdump.c: Add string for FT_LS_UNQUOTE case.
It was missing since e8635a8a1 and the default case that attempted to
format it as a number was faulty, fixed in 39ecf70bb. That fix broke
test/format/test-fmtdump as it expected the broken "blank line" to be
output instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 15:42:48 2017 +0100
Silence more gcc format-string warnings.
By enabling more checks, gcc has found some real bugs, e.g. `printf(buf,
"%d", i)'. Other changes required duplicating the formatting call with
a constant format string; a local macro was used to avoid repeating all
the many arguments.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 15:06:01 2017 +0100
mhparse.c: Use constant indent for second line of messages.
It was using knowledge of inform()'s workings to indent by the varying
width of global invo_name plus two for the following ": ". This also
cluttered every call's parameters with a strlen(), cast to an int for
printf's width specifier, and an empty string. All noise for little
gain.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 14:49:53 2017 +0100
m_getfld.c: Alter Ungetc() to die if it can't rewind.
It used to return EOF to the caller in this case, but none of the three
callers bothered checking. And the other return value of a `peek' of
the character that would next be read was also unused.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 14:43:21 2017 +0100
m_getfld.c: Remove Ungetc()'s `c' parameter.
It's never used to unget a different character than what was just read,
making the function more of a `rewind'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 14:32:29 2017 +0100
Teach gcc(1) that adios() and friends take printf formats.
It then checks their arguments. Correct the resulting warnings, e.g.
C89 doesn't have `%zu', but does say size_t shouldn't be wider than
long. Perhaps an autoconf test can detect if the `format' __attribute__
is supported.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 13:50:31 2017 +0100
m_getfld.c: Check ftello(3) and fseeko(3) for errors.
They were being ignored. Exit on failure; harsh, but we don't know the
circumstances where they might occur and thus what recovery would be
apt.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 13:33:09 2017 +0100
struct m_getfld_state: Re-order members in more top-down order.
Makes understanding its content easier.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Aug 9 13:20:32 2017 +0100
m_getfld() and friends: Add commentary.
Possibly incorrect commentary, as all comments tend towards over time,
but better than nothing at the moment. No functional change intended.
Author: David Levine <levinedl@acm.org>
Date: Tue Aug 8 20:10:49 2017 -0400
Fixed scan to handle empty files without violating an assert [Bug #51693].
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Aug 6 18:15:41 2017 +0100
cpstripped(): Rewrite multi-byte version.
Removes the assert(3) failure reported on the list for 1.7-RC1 when a
non-space, non-cntrl, rune has a wcwidth(3) of -1; output L'?' in its
place. The old code also didn't reset mbtowc(3)'s state before trying
to parse "?"; that's handled differently now so isn't an issue. Pad
with the multi-byte encoding of L" ", having ensured the wcwidth(1) of
L' ' is one, rather than with a non-wchar_t ' '. Point out padding only
occurs in one particular case, and not the other two; quite odd.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 5 18:20:07 2017 +0100
cpstripped(), single-byte: Simplify logic.
Now that it doesn't have to fit in with the multi-byte version's logic,
it can be re-structured to be simpler. No functional change intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 5 17:57:48 2017 +0100
cpstripped: Split into two versions, each with a single #ifdef.
Got fed up trying to read C logic when the preprocessor's logic didn't
nest neatly with the function's. No intentional change to either
version.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 5 17:16:39 2017 +0100
test/getcwidth: Add --ctype to dump locale's iswprint(), etc.
Didn't bother trying to `start - end' range the output.
Most of the time I want to slice and dice the output, or grep for a
particular value. If I want ranges then I can post-process.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Aug 5 16:23:10 2017 +0100
test/getcwidth: Expand --dump beyond Unicode's BMP.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 3 12:22:07 2017 +0100
NEWS: Move "new features" that might bite a user to the top.
(cherry picked from commit 42455309a086a9ebbf55198dca5bab52e96ace84)
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Aug 3 12:17:30 2017 +0100
NEWS: Re-order 1.7's sections, as discussed on nmh-workers.
(cherry picked from commit bd39db60858810e0a268ddb5f18ed8879817790b)
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Aug 2 22:22:22 2017 -0400
Cleared pending-release-notes for the next release.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Aug 2 22:20:46 2017 -0400
Updates for 1.7 release.
(cherry picked from commit 5f39a8e67f4652752dd1b51726fe3a19dc4d5743)
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Aug 2 00:01:39 2017 -0400
Update for new branch
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Aug 1 23:53:05 2017 -0400
Use correct error code for SSL context retrieval.
Make sure we use the correct error code if we are unable to retrieve
the SSL context from the context from the BIO.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Aug 1 13:28:04 2017 -0400
Document bug fix
Merge: 8f460dd0 a2d70b22
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Aug 1 13:22:36 2017 -0400
Merge branch 'fix-post-bcc'
This branch fixes bug #51098; the lack of alias expansion on a From line
when doing a Bcc. Admittedly, this is rather an obscure bug, and AFAICT
it never worked in any version of MH or nmh, but it is fixed now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Aug 1 13:21:21 2017 -0400
Implemented test for this patch.
This patch tests the code that does alias expansion in a From line when
doing bcc. Which is, now that I think about it, one heck of a corner case.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Aug 1 14:41:20 2017 +0100
Move m_getfld's MS_* mbox-type macros to the only user.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 31 22:00:39 2017 -0400
Restricted application of the adjustment in m_Eom().
Per Ralph's suggestion. Update to commit 29db9a64a. Also,
consolidated print statments in test-eom-align.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 30 20:24:34 2017 -0400
Hacked m_Eom() to fix test-eom-align.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 29 17:55:25 2017 -0400
Restored local variable to m_Eom(), to not truncate EOF.
Reversion of significant part of commit d3e11c5e9. Thanks to Ralph
for noticing that it wasn't a good change.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 29 17:07:06 2017 -0400
Removed a local variable from m_Eom().
Minor code simplification in preparation for upcoming fix.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 29 12:42:35 2017 -0400
Simplified m_strn() per Ralph's suggestions.
Update to commit 4a56a28ac.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 29 10:47:16 2017 -0400
Use m_strn() to allow restoration of buffer size to 26 bytes.
Fix to commit a3724ed39.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jul 29 15:06:11 2017 +0100
dtimezone(): Explain abs(3) is undefined on INT_MIN.
That's why a negative int is flipped over into unsigned by assuming
two's complement.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 29 10:02:28 2017 -0400
Added m_str() and m_strn() functions to convert int to string.
Allows better fix to uip/forw.c than commit d711510305.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jul 29 14:29:15 2017 +0100
Simplify dtimezone()'s logic by working with unsigned int.
Character buffer is resized down from arbitrary 64 to suit 32-bit int,
a change to the recent a3724ed3.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jul 25 15:40:28 2017 -0400
Finished implementation, but tests need to be written.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 23 11:39:24 2017 -0400
Added some specific tests to test-eom-align.
These were found by scanning a much larger range of buffer sizes,
over nmh versions from cvs, 1.4, 1.5, 1.6, and current HEAD.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Jul 17 12:58:38 2017 +0100
Bump up size of two static char[] so gcc knows they won't overflow.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 16 20:06:01 2017 -0400
Increase size of buffer to avoid warning from gcc -Wformat-truncation.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 16 17:25:51 2017 -0400
Replaced snprintf() to convert an int with m_name().
At Ralph's suggestion. The goal was to get rid of a warning from
gcc -Wformat-truncation, but the code ends up being cleaner as well.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 16 09:02:08 2017 -0400
Enhanced mhical syntax error message to provide some context.
Specifically for the case of improperly folded lines.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 15 09:37:26 2017 -0400
Fixed flex fixups to not break LFLAGS.
Addresses comment added in commit 4ac978448.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 15 09:16:47 2017 -0400
Added flex fixup for Fedora 26's flex 2.6.1.
The fix is compatible with unpatched flex 2.6.1.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jun 23 11:53:28 2017 -0400
Start of work to fix lack of address rewriting for bcc
This is the start of work to fix the problems described in #51098. Is
not finished yet.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 17 13:42:59 2017 -0400
Rearranged statements to eliminate memory allocation.
Update to commit a5bf16c0928cb4044b082f9cf6f44f9bb3998824.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 17 11:01:32 2017 -0400
Show display program name and arguments in error message if it fails.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 17 09:32:00 2017 -0400
Don't bypass scan_content() when expanding pseudoheaders.
expand_pseudoheader() would avoid the call to scan_content() in order
to inhibit use of quoted-printable for text content. Removed that;
the user still has control over the use of quoted-printable via
-maxunencoded. Though now, lines over 998 bytes long will always
be encoded.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Jun 10 18:32:08 2017 +0100
sbr/netsec.c: Report popped TLS error code, don't pop again.
ERR_get_error() pops an error code so having tested that value it should
also be the one that's reported in an error message, not another popped
error code by calling ERR_get_error() again as this misleads as to the
error's cause.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 30 23:00:10 2017 +0100
uip/inc.c: Don't increment variable of type bool.
gcc 7.1.1 is warning against incrementing `bool' variables.
Assign true instead.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 1 19:54:21 2017 -0400
Fixed double fclose().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jun 1 12:26:23 2017 -0400
Remove ancient SENDMAILBUG code.
Old SMTP code used to treat a code 451 the same as code 250 (success). It's
not clear if this was ever a real bug in sendmail, but regardless this code
is long obsolete.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jun 1 12:25:15 2017 -0400
Comment cleanup; removed ancient reference to 4.2BSD systems.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 31 14:39:48 2017 -0400
Normalize connection shutdown handling.
I originally tried to make things work so that the netsec client code gave
the client the option of closing the file descriptors if it wanted to, but
I was running into a problem where if TLS negotiation failed part of the
negotiation would be interpreted as connection data. The code has been
changed to have the sockets close when the SSL BIO is released and to
have netsec_shutdown unconditionally close the file descriptors.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 31 11:53:47 2017 -0400
Use original error code from OpenSSL.
Reuse the error code we already retrieved from OpenSSL, otherwise the
error might be cleared the next time we call ERR_get_error().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 29 13:20:00 2017 +0100
sbr/brkstring.c: Use strchr(3) in brkany(), not own loop.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 29 12:56:10 2017 +0100
sizeof char is always 1, so don't bother to divide by it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 29 12:53:24 2017 +0100
Use DIM(a) macro a few more times; array's dimension using sizeof.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 29 12:23:38 2017 +0100
uip/scansbr.c: Add PUTC() macro, similar to FPUTS().
FPUTS() exists, but all the putc(3) checks for error were written
alongside in longhand. May as well have a PUTC() to match, though
perhaps just the existing check of the FILE's sticky error state with
ferror(3) is sufficient and neither macro is required.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 29 11:49:29 2017 +0100
uip/scansbr.c: Stop `scan -file' copying mailbox to /dev/null.
scan() was copying the mailbox to /dev/null when called for `scan -file
foo.mbox' because it used outnum being non-zero as the test of whether
to write instead of FILE pointer scnout being non-NULL. By switching,
we can avoid the opening of /dev/null that was just to give scnout a
valid value for the needless fputs(3), etc.
Add comment explaining scan()'s outnum input parameter's three
functions: -1, 0, and positive.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 28 13:07:25 2017 +0100
h/mts.h: Replace char pointer mmdlm1 with macro MMDF_DELIM.
mmdlm1 only ever pointed to its initial string constant.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 28 12:32:28 2017 +0100
sbr/mts.c: Delete mmdlm2; use same-valued mmdlm1 instead.
mmdlm1 and mmdlm2 had the same compile-time value. Both could be
changed at run-time by mts.conf(5), but d205d39a stopped that. Use
mmdlm1 instead of mmdlm2 and delete mmdlm2.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 28 12:21:12 2017 +0100
sbr/mts.c: Make MMDF's delimeters fixed at compile time.
mts.conf(5) allowed `mmdelim1' and `mmdelim2' to alter the default MMDF
begin and end markers of four ASCII SOHs and an LF. There doesn't seem
to be a modern use for this, and nmh wouldn't have handled longer
markers correctly so remove the capability.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 27 17:04:48 2017 +0100
uip/forw.c, uip/repl.c: Remove -file's "msh" comment.
The comment claims -file is "interface from msh", but msh(1) was removed
in e6917522. The options remain as discussion on the list prompted
David to say he uses them occasionally.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 26 23:34:10 2017 +0100
uip/mhparse.c: Fix body starting a byte too soon when no blank line.
m_getfld() returns BODY when the headers run into a line without a colon
instead of being separated from the body by a blank line. The file's
position and the returned `bufsz' differ from the normal case of a blank
line and then the start of the body, causing confusion. get_content()
was aware of the difference, documented it, and attempted to correct for
it, but got it wrong and included the `\n' that terminates the last real
header at the start of the "body". This affected a struct Content's
c_begin.
Use the correct file position for c_begin, adding a comment that
explains the theory for both cases. Add a test-mhlist case that checks
mhlist(1) states the body size is the same whether it is separated from
the headers by a blank line or not. Correct existing
test/bad-input/test-header test that expected the extra blank line to be
counted and to appear in the output.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 26 12:36:32 2017 +0100
Remove mention of msh in comments and to-do list.
msh(1) was removed in e6917522.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 26 11:56:37 2017 +0100
Makefile.am: Add test/inc/test-eom-align to XFAIL_TESTS.
Since 5f34de43, it's expected the test will fail.
Add it to XFAIL_TESTS so it's still run, but its failure doesn't cause
the `check' target to fail.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 18:12:55 2017 +0100
Don't cast lseek(2)'s offset to off_t when it's 0.
`lseek(fd, (off_t)0, SEEK_SET)' does not need the cast when a prototype
is in scope, and <unistd.h> is #include'd.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 17:23:10 2017 +0100
uip/slocal.c: Tidy `verbose' logic in usr_file().
Boolean was being tested three times instead of once after recent
dead-code deletions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 16:29:33 2017 +0100
uip/popsbr.c: Delete unused pop_list(), etc.
Those deleted: pop_list(), pop_noop(), pop_rset(), and pop_top().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 16:23:00 2017 +0100
sbr/utils.c: Delete dead-code open_form(); not called.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 14:36:59 2017 +0100
uip/comp.c: Delete single-use NULLMP macro.
It just cast 0 to a pointer to struct msgs and was used once, as a
function's parameter. Replace that with NULL since a prototype for the
function is visible.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 14:36:33 2017 +0100
sbr/fmt_compile.c: Delete single-use NEWFMT macro.
Its simple content was to increment a variable; doing that in situ is
more clear.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 13:53:27 2017 +0100
Remove support for ./.foo.map index for ./foo mailbox.
An MH-only index of a mailbox, mbox or MMDF format, called a map file,
could be built and maintained by packf(1), rcvpack(1), and slocal(1),
but since msh(1) was removed in e6917522, there hasn't been a user of
the index file so stop producing it and delete all the supporting code
in uip/dropsbr.c.
mbx_copy() loses its `mapping' and `noisy' parameters; noisy was only
used when mapping. Delete mbx_read() and mbx_size() as they have no
callers without maps.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 13:03:53 2017 +0100
test/runpty.c: Add more detail to "timed out" message.
test/install-mh/test-version-check was skipped due to timeout, but it
took a lot less than the thirty-second timeout to run. Add start time
and the time now to the diagnostic, and select(2)'s return value.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 11:24:54 2017 +0100
uip/prompter.c: Make getln() static; only called locally.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 11:21:40 2017 +0100
uip/prompter.c: Delete obfuscating ERASE, etc., macros.
Their few uses are clearer as `t_io.c_cc[VERASE]' as otherwise the
storage, t_io, isn't mentioned, and c_cc and VERASE match termios.h's
man page.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu May 25 11:18:11 2017 +0100
uip/prompter.c: Delete unused macros CKILL and CERASE.
They haven't been used in git's history. Their definitions of `@' and
`#' might surprise younger users if put into use. :-)
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 24 19:22:02 2017 +0100
uip/inc.c: Delete POP3's -pack option for msh users.
inc(1)'s -pack option, only available with POP3 access, stored the
emails in a spool file instead of a folder. The man page says this was
intended for msh(1) users, but msh was deleted in e6917522. The spool
file was always in packf(1)'s MMDF format, no option of -mbox, and was a
rare producer of `map' files that indexed the spool file, again intended
for msh. Removing -pack makes deletion of map files elsewhere in the
code easier.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 24 13:50:25 2017 +0100
uip/dropsbr.c: Delete unused mbx_write() and map_read().
Most recently used by msh(1), removed by e6917522.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 23 12:56:00 2017 +0100
Replace some "FALLTHRU" comments with control flow.
Instead of a case statement falling through, with a "FALLTHRU" comment,
to the follow case that just does a break, continue, goto, etc.,
control-flow statement, duplicate the statement in place of the comment.
Fall-through should be the exception, and saving a break statement
doesn't offset the cognitive cost when reading the source.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 23 12:53:32 2017 +0100
config/config.c: Fix indentation of "FALLTHRU" comment.
It's not part of the preceding if-statement, but unconditional.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 21 12:45:54 2017 +0100
sbr/m_getfld.c: Fix and improve `delim' comment.
fdelimlen is one higher than was described in 86c5ebc87.
Describe pointer positions pictorially.
Author: David Levine <levinedl@acm.org>
Date: Mon May 22 20:17:48 2017 -0400
Fixed a couple of typos.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 20 12:46:04 2017 +0100
test/inc/test-eom-align: Show size of test email as progress.
Don't bother over-printing; Perhaps when it's working again and lots of
output is being produced.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 20 12:38:22 2017 +0100
test/inc/test-eom-align: Fix tests; they've never worked.
Instead of cycling through lots of mbox sizes, $STDIO_BUFSZ was always
used as the desired size resulting in tests A and B being duplicated 221
times each. Slowly, if using valgrind. The tests fail now they're
fixed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 20 12:09:13 2017 +0100
test/common.sh.in: test_skip(): Remove unused variable.
`$Test' was being interpolated into the output, but has never existed.
Rephrase the output given a /^SKIP: / line follows from the test harness
due to the `exit 77'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 20 11:53:55 2017 +0100
test/runpty.c: Add missing exit(3) after child fails to execvp(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 20 11:48:10 2017 +0100
uip/aliasbr.c: Remove dead code used for Unix groups.
Main functionality removed in afaab789.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu May 18 14:03:09 2017 -0400
Remove support for aliases based on Unix groups.
Remove support for expanding aliases based on group membership (=) and
all users who have a particular primary group (+). This was the result
of a discussion on nmh-workers; these features were of dubious value, likely
not used, and interfered with RFC-2047 encoded names in alias files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 17:56:00 2017 +0100
uip/mhshowsbr.c: Increase buffer size for showing-content command.
Experimenting with small BUFSIZ to try and trigger programs caused one
test to fail because the code detected BUFSIZ was too small a string to
hold the command to execute. Use NMH_BUFSIZ instead.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 17 23:28:02 2017 -0400
After further reflection, I decided I didn't like that previous
implementation. Instead, allocate two ptys and connect one to standard
input and the other to standard output and standard error of the child
process. After the first data is received from the slave, close the
master connected to standard input; that will generate an EOF on input
to the child process. This ends up being much cleaner than looping and
waiting to send the EOF character to the child process.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 17 21:40:57 2017 -0400
Apparently on Linux if a slave pty is closed, instead of the master
getting an EOF they get an EIO, which strikes me as unfriendly. So
make sure we exit the main read loop without complaint on an EOF or
error.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 17 21:00:47 2017 -0400
Switch from using script(1) to a new custom utility, runpty. It turns out
on some systems script(1) has a bug that results in hangs that is simply
too difficult to test for, and this custom utility is simpler.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 15:15:18 2017 +0100
uip/mhbuildsbr.c: Fix long-line truncation when BUFSIZ is 1024.
a23477eb changed one char array from BUFSIZ to NMH_BUFSIZ elements, but
the long line read into it was passed to user_content() that
strncpy(3)'d it, silently truncating, to another char array, still
BUFSIZ long. This show up on platforms where BUFSIZ is 1024 versus
NMH_BUFSIZ's minimum of 8192.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 13:06:40 2017 +0100
test/common.sh.in: Clarify it's the first failure by a *named* test.
Unnamed tests may have failed earlier.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 12:58:15 2017 +0100
test/mhbuild/test-cte: Move run_prog() to just before check().
Prepare the input and output files, then run the program and check the
result. Makes it easier to see every run is being checked if a,
sometimes large, expected-output file isn't being produced in between.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 12:47:07 2017 +0100
test/mhbuild/test-cte: Add missing check() for earlier run_prog().
be6c3984 added a new run_prog and swiped the earlier check.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 12:45:26 2017 +0100
test/common.sh.in: Clarify test name in failure message.
Some test names don't stand out as that when suffixed with `failed'
amidst all the other output. Change `foo failed' to `first test
failure: foo' instead. Also makes clear there's possibly other tests
that failed later.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue May 16 21:30:10 2017 -0400
Make sure we are in the correct directory when we do "git describe".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 17 00:27:54 2017 +0100
sbr/check_charset.c: Fix warning on unspecified struct initialisers.
A different C compiler disliked `{NULL}' as the initialiser for a
two-member struct so specify NULL for the other member too.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 12:57:25 2017 +0100
Rewrite norm_charmap(), moving code into data.
Also removes return of static char array, and is more precise, e.g.
`CP1242' doesn't become `WINDOWS-1242' as it's not a known code page.
Merge: 684716b8 3d0e5b6a
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 11:44:18 2017 +0100
Merge commit '3d0e5b6a4383a5228732edd6cb1532375b771262'
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 11:35:49 2017 +0100
Merge sbr/norm_charmap.c into sbr/check_charset.c.
Alter norm_charmap() to be static now its only caller is in the same
file. I've checked the upstream cam.ac.uk source and it's still the
same and hasn't changed in years, so I don't think there's much benefit
from having it standalone to ease checking.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 11:29:17 2017 +0100
Part 1 of merging sbr/norm_charmap.c into sbr/check_charset.c.
This commit won't compile, but I'm attempting to get the rename into git
so the history after the next, merge, commit will continue through both
parents.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 11:21:50 2017 +0100
sbr/unquote.c: Move prototype from h/prototypes.h to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 10:59:07 2017 +0100
sbr/mime_type.c: Move prototype from h/prototypes.h to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 10:53:17 2017 +0100
sbr/message_id.c: Move duplicate prototypes to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 10:41:35 2017 +0100
sbr/makedir.c: Move prototype from h/prototypes.h to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 10:36:02 2017 +0100
sbr/m_popen.c: Move prototypes from h/prototypes.h to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 00:30:59 2017 +0100
sbr/m_maildir.c: Move prototypes from h/prototypes.h to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 16 00:02:30 2017 +0100
sbr/m_rand.c: Move prototype from h/prototypes.h to new header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 23:54:05 2017 +0100
h/prototypes.h: Give sbr/lock_file.c's prototypes their own header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 18:58:19 2017 +0100
sbr/utils.c: Delete unused upcase() function.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 18:52:32 2017 +0100
h/utils.h: Move in PLURALS() macro from h/mh.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 18:47:46 2017 +0100
h/prototypes.h: Remove duplicate prototype for pwd().
It is already in h/utils.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 18:39:45 2017 +0100
h/utils.h: Move in nmh_init() prototype from h/prototypes.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 18:06:19 2017 +0100
uip/mhshowsbr.h: Move in declarations from h/mhparse.h.
Delete non-existent markerform parameter from show_all_messages()'s
comment. Alter show_all_messages()'s definition's concatsw parameter to
match comment and prototype.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 17:14:01 2017 +0100
uip/mhshowsbr.c: Create header file with exports' declarations.
Create a single set of externs for mhshowsbr.c's global variables. Have
the other users of those use the new include file instead of their own
declarations.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 16:09:28 2017 +0100
uip/mhcachesbr.c: Move exported symbols to existing h/mhcachesbr.h.
Remove the user's copies of the declarations.
A static struct swit caches[] was declared everywhere that included
h/mhcachesbr.h. The larger number of includers causes `variable not
used' for `caches'. Move that declaration to uip/mhcachesbr.c and have
an exported `cache_policy' symbol that points to it for the existing
users.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 15:14:44 2017 +0100
uip/mhoutsbr.c: Move exported prototype to new header file.
Alter the callers to include the new header file instead of having their
own copy of the prototype.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 15:07:10 2017 +0100
sbr/m_mktemp.h: Move remaining prototypes from h/prototypes.h.
Gives the normal one header file showing interface exported by one C
file.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 14:40:52 2017 +0100
sbr/m_mktemp.h: Create with missing prototypes.
Some of sbr/m_mktemp.c's functions didn't have prototypes in a header
file so callers were declaring prototypes themselves. Have them include
the new header file instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 14:31:36 2017 +0100
sbr/utils.c: Use h/signals.h for setup_signal_handlers prototype.
Deleted its own prototype for setup_signal_handlers() and added it to
the existing h/signals.h as it's defined in h/signals.c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 14:23:53 2017 +0100
uip/picksbr.c: Use function prototypes for `nexus' functions.
Prototypes for ORaction(), etc., now state the parameters they expect.
Removed the args() macro, instead explicitly listing the arguments being
passed to functions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 14:12:21 2017 +0100
Specify function parameters in prototypes, mainly void.
These prototypes are all in *.[cl] source compared with the *.h of the
earlier commit. All but one had void added, that one's parameter was a
char pointer.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 13:45:39 2017 +0100
h/prototypes.h: Remove scan_reset_m_getfld_state() prototype.
Function removed back in 2014 by 58eaf2c2.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 13:39:08 2017 +0100
Use `void' in prototypes for functions with no parameters.
The old-style `int foo()' still lived on in a few places.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 13:29:28 2017 +0100
h/mhparse.h: Move mhfree.c's free_content prototype to new header.
It was the only thing of mhfree.c's in h/mhparse.h.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 13:25:23 2017 +0100
Match `NORETURN' function prototypes by adding it to definition.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 13:13:45 2017 +0100
Create and use header file for uip/mhfree.c's exports.
Remove all the duplicate inconsistent prototypes from mhfree.c's users.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 13:10:30 2017 +0100
test/mhical/test-mhical: Force UTC timezone for mhical.
Commit c3238c0e added a test but mhical's output depends on its
timezone; force it to UTC for consistent results.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 12:52:23 2017 +0100
uip/mhfree.c: Make free_header() static.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 15 12:38:26 2017 +0100
uip/flist.c: Make locally defined and used functions static.
Author: David Levine <levinedl@acm.org>
Date: Sun May 14 17:27:23 2017 -0400
Support iCalendar event request files that don't end with a newline.
Such files do not conform to RFC 5545 § 3.1, which requires that each
contentline end with a CRLF. But be liberal in what we accept.
Author: David Levine <levinedl@acm.org>
Date: Sun May 14 13:08:03 2017 -0400
Added explicit dependency to build sbr/icalparse.h before running LEX.
"Fix" to commit 665dfc96. The build had been relying upon the listed
order of files.
Author: David Levine <levinedl@acm.org>
Date: Sun May 14 12:18:35 2017 -0400
Have post(1) report name of fileproc if it fails.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 14 23:17:36 2017 +0100
Replace calls to unputenv() with unsetenv(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 14 22:56:52 2017 +0100
Replace calls to m_putenv() with setenv(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 14 19:35:13 2017 +0100
sbr/dtimep.l: Remove redundant wrapping parenthesis in definitions.
It's been decades since a lex(1) didn't follow POSIX and treat `{foo}'
as parenthesis surrounding foo's definition. Other nmh lex files work
without the extra wrapping.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 14 12:53:33 2017 +0100
uip/mhstoresbr.c: Fix single-character nmh-storage bug.
If the profile component nmh-storage was a single character, e.g. the
relative directory `d', then it would be dropped from the output path so
instead of `d/foo' being written, `/foo' would probably fail. I think
this was due to a faulty check for nmh-storage being `/'. Add a test
for a non-/ single-character nmh-storage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 14 12:08:06 2017 +0100
sbr/fmt_rfc2047.c: Simplify test for /^=\?./.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 14 11:23:33 2017 +0100
Use new PLURALS(n) macro instead of variety of tests.
Whether to output a plural noun in a message was decided by ternary
operators that tested n==1, n!=1, n>1, etc. Make them all consistent by
using PLURALS(n).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 13 23:40:50 2017 +0100
uip/folder.c: Use `%s' for plural, not `%c'.
Instead of a ternary operator with 's' and ' ' as the outcomes, switch
the format specifier from `%c' to `%s' and use strings "s" and " ".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 13 18:39:06 2017 +0100
uip/folder.c: Rewrite plural test to common form.
The common form is a choice between "" and "s". This one occurrence was
using " " and "s" so either output was a fixed width. Alter the
printf(3) format string from `%s' to `%1s' to provide that instead.
Allows the new code to be altered by an upcoming `plural' change.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 13 18:35:15 2017 +0100
Makefile.am: Alter long lists to be sorted, one entry per line.
It was hard to see what files were included in some variables when
searching for the best place for new content. Some variables had
definitions that were almost sorted, by weren't. Switch to a
one-entry-per-line list, in `LC_ALL=C sort' order, documented at the
start of the file. Makes it easy to run through the lists and see the
patterns.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 13 13:24:03 2017 +0100
Use FENDNULL() instead of duplicate, locally defined, empty().
Three files had an empty() that was defined using FENDNULL(); use the
latter directly.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 13 13:13:18 2017 +0100
Add FENDNULL(s): fends off NULL by giving an empty string instead.
Use it in place of all the `foo->bar_xyzzy ? foo->bar_xyzzy : ""'.
Avoids the reader having to check first two of the ternary operands are
the same.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat May 13 12:56:58 2017 +0100
sbr/mf.c: Rename path to routepath to avoid h/mh.h clash.
Adding #include of h/mh.h brings two path global symbols together;
path() and char *path. Rename the latter. h/mh.h is needed by a future
commit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 12 23:29:31 2017 +0100
Replace `a == b ? 1 : 0' and similar with `a == b'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 12 23:14:43 2017 +0100
Replace `e ? 0 : 1' with `!e'.
Needs less thought to read.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 12 22:45:34 2017 +0100
sbr/icalparse.y: Replace max(BUFSIZ, 8192) with NMH_BUFSIZ.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 12 22:42:35 2017 +0100
Use existing macros min() and max() more.
Author: David Levine <levinedl@acm.org>
Date: Thu May 11 22:41:02 2017 -0400
Clarified the phrasing added by commit 44ce2010.
Author: David Levine <levinedl@acm.org>
Date: Thu May 11 20:20:16 2017 -0400
Added warning about when post(1) can't refile(1) a draft.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed May 10 12:13:28 2017 +0100
sbr/fmt_scan.c: Fix `foo%-42{bar}' right-justification bug.
The space padding was added at the start of the output buffer, not the
start of the component being formatted. Caused by 92128dac's move to
dynamic allocation for fmt_scan()'s output. Only shows if the component
isn't at the start of the buffer. Expand existing
test/format/test-rightjustify to cover this.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 9 23:10:06 2017 +0100
config/version.sh: Rewrite. Use uname(1), git-describe(1), and UTC.
Not sure why it searched through PATH manually for uname(1) and
hostname(1). uname and its -n option are POSIX so just use those. It
was the preference over hostname anyway.
Use git-describe(1), not just git-branch(1), as it gives more detail,
including --dirty to show the built source differs from the commit.
Specify the format for the build date, and its timezone; +0000.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue May 9 22:48:11 2017 +0100
sbr/mf.c: Simplify isat(); it's /^ at /i.
This one's for all those RFC 733 emails out there.
You know who you are.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 23:30:46 2017 +0100
uip/inc.c: Use bool, not int, for some of the options.
Makes clear there's no special meaning to repeating these options more
than once.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 22:43:19 2017 +0100
sbr/netsec.c: Remove extraneous semicolon.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 22:35:41 2017 +0100
Split some comma-operator terms into separate statements.
Some uses of the comma operator weren't the idiomatic `p++, len--'.
Split its terms into two statements instead, e.g. `close(fd); fd = -1'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 18:02:03 2017 +0100
uip/picksbr.c: Increase line-buffer size for "grep" action.
Alter LBSIZE from 1024 to NMH_BUFSIZ, e.g. 8192. This dominates the
size of the char array used to hold a single unfolded header line when
evaluating a "grep" action, e.g. `-to foo' becomes `^to[ ^I]*:.*foo'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 14:01:48 2017 +0100
uip/scansbr.c: Replace uses of SBUFSIZ with NMH_BUFSIZ.
Now that the former is defined as the latter, the uses of SBUFSIZ were
all in the same expression and it simplifies from a ternary expression
to NMH_BUFSIZ.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 13:57:39 2017 +0100
uip/rcvdist.c: Replace SBUFSIZ with NMH_BUFSIZ.
The former was defined as the latter and had only one proper use: to
size a char array. The other uses should have been the sizeof operator
on that array, and now are.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 13:56:40 2017 +0100
uip/replsbr.c: Replace single use of SBUFSIZ with NMH_BUFSIZ.
The former was defined as the latter; not a lot of point having it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun May 7 13:03:01 2017 +0100
Make many m_getfld() buffer parameters NMH_BUFSIZ big.
char arrays were often stdio.h's BUFSIZ large, and that's 8192 with here
with glibc 2.25-1 on Linux x86_64, so using NMH_BUFSIZ is no different
as that's max(BUFSIZ, 8192). But some were 256 or 512 with a local
SBUFSIZ macro and they caused scan(1) to truncate a field, or pick(1) to
not spot text because the field was truncated.
Delete bad-input/test-header's test for m_getfld()'s detection for a
header without a colon that's under the header-length NAMESZ limit, but
longer than the passed in buffer. This no longer happens in scan as the
buffer is larger than the longest allowed header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri May 5 13:11:15 2017 +0100
configure.ac: Enable assert(3) by default.
Revert 167e542b that disabled assert(3) by default after private email
discussion with David Levine. I suggested it being enabled by default
in git so those running nmh from git were testing them for us, with it
being disabled as part of the release process so packagers continue with
it disabled. David pointed out that would make the release
intentionally different from what had been long tested so the default is
now enabled assertions everywhere unless disabled by a packager.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 23:02:06 2017 +0100
mhstoresbr.c: Flip logic to simplify. Remove else after continue.
Former in store_partial(), latter in parse_format_string().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 22:57:44 2017 +0100
mhlsbr.c: Flip parse()'s logic. Remove oneline()'s else after break.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 22:56:30 2017 +0100
dropsbr.c: Flip mbx_open()'s logic to simplify.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 22:47:38 2017 +0100
base64.c: Remove some else after break. Flip logic to simplify.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 22:46:38 2017 +0100
mhfixmsg.c: Flip logic to simplify. Remove else after break.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 22:36:30 2017 +0100
path.c: Simplify compath()'s flow; return, don't break twice.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 21:49:38 2017 +0100
mhshowsbr.c: Remove else after break in iconv_start().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 21:46:20 2017 +0100
mhparse.c: Remove a couple of else after continue.
In openQuoted() and parse_header_attrs().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 21:43:36 2017 +0100
m_getfld.c: Remove else after break in m_unknown() and m_Eom().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 21:42:59 2017 +0100
picksbr.c: Remove some else after break in plist().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 18:42:07 2017 +0100
fmt_rfc2047.c: Remove else after decode_rfc2047()'s break.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon May 1 18:33:15 2017 +0100
sortm.c: Flip get_fields()'s logic to simplify.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 30 15:25:20 2017 +0100
README.developers: Add pointers to Debian's Lintian's complaints.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 30 15:14:46 2017 +0100
README.developers: Add blank lines for consistent headers.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 29 00:01:58 2017 +0100
Fix spelling in C comments.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 22:42:46 2017 +0100
bvector_copy: Use bvector's tiny storage if big enough.
Otherwise a source bvector that's using tiny storage has its bits
duplicated into a malloc'd area when the destination's tiny storage was
sufficient.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 22:08:26 2017 +0100
sbr/oauth.c: Remove const to avoid curl's debug_callback warning.
The curl_debug_callback typedef doesn't use const for any of the
function's parameters. On one of the compilation platforms here,
oauth.c's debug_callback having const specifiers for some parameters
causes compilation warnings, and -Werror stops the compilation. Remove
them.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 17:12:31 2017 +0100
sbr/folder_read.c: Don't malloc() once per message.
Instead of struct msgs having a pointer to a malloc'd array of pointers,
each to a malloc'd struct bvector, 1+N, it now has a pointer to a
malloc'd array of struct bvector; one malloc for all of them. This
avoids the large number of calls to malloc() and free() that's linear
with the size of the folder.
But there are some downsides. In order to step through an array of
struct bvector, code outside of sbr/vector.c needs to know the struct's
size. The simplest way to do this is to make the struct's definition
public, with a comment that access should be through vector.c.
New functions are needed to initialise the content of an already
allocated bvector, and to finish with its content prior to deallocation.
bvector_create() and bvector_free() now also use these new functions.
Before, it was the array of pointers to bvector that would be realloc'd.
That doesn't work for the array of bvectors as they may contain pointers
to within themselves. The solution is to malloc a new array and
bvector_copy() the ones to keep across, as folder_realloc() now does.
The other half of its logic that coped with growth at the end of the
array, has been deleted. Also deleted, is the code to clear the
bvectors before and after the old ones as they start in that state.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 17:00:54 2017 +0100
valgrind: Add suppression for dbm_open(3)'s write(2).
It writes bytes from an area it mallocs, but doesn't set all of those
bytes first. See with gdbm 1.13-1 on Arch Linux.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 12:45:26 2017 +0100
sbr/vector.c: Only allocate bvector storage for set bits.
Now that a pointer to all the bit storage doesn't escape vector.c,
there's no need to allocate storage, that's initialised to 0, just to
then clear a bit in it. Only extend the bits's storage for set bits.
Remove the unused initial size parameter from bvector_create() as it
simplifies the implementation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 12:27:44 2017 +0100
sbr/vector.c: Add bvector comments, tidy identifiers.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 12:16:01 2017 +0100
sbr/vector.c: Rewrite BVEC_BYTES(n) macro to remove branch.
Use the idiom of integer truncation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 28 12:12:15 2017 +0100
sbr/vector.c: Use new BVEC_BITS_BITS macro.
Factors out a common expression from a few other places.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Apr 27 00:14:28 2017 +0100
sbr/vector.c: Zero the growth with memset(3), not loop.
When the resize functions grow the vectors, as they always do, zero the
new slots with memset(3) rather than a for loop. Particularly of note
for the bit vector where it was bvector_clear()ing one bit at a time.
Although a NULL pointer needn't have a representation of all-zero bits,
the code was already assuming that, e.g. on the initial allocation, so
we're no worse off.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Apr 26 13:41:27 2017 +0100
sbr/vector.c: Change bvector_bits() to return first word.
Rename it to bvector_first_bits() to represent its new behaviour. It
has only one caller that uses it to produce debug. Tighten the API so
other callers don't get access to the location of the bvector's bits.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 25 23:21:21 2017 +0100
sbr/vector.c: Embed initial vector storage in header struct.
Instead of a malloc(3)'d struct bvector having a pointer to a separately
malloc'd area for the bits in the normal case of the default initial
size, have non-malloc'd storage in the struct itself, and set the
pointer to that. It's two unsigned longs, which is less than the
previous default of 256 bits for struct bvector, but still double the
pre-bvector norm of one word on 32 and 64-bit architectures.
This halves the mallocs needed to create a struct bvector in the common
case, but does mean that embedded memory is wasted should it not be
enough. That's probably an unusual case. It also means derefencing the
pointer to the bits probably hits the same cache line.
Have separate initial sizes for string and int vectors.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 25 00:20:08 2017 +0100
sbr/vector.c: Remove `vec' argument from BVEC_OFFSET(), etc.
A few macros took a struct bvector pointer as their first argument just
to get the sizeof one of its fields. This can be done with a NULL
pointer so remove that argument from all of them.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 24 23:47:46 2017 +0100
sbr/vector.c: Delete unused bvector_maxsize() and ivector_size().
May as well keep the proffered interface as small as possible so the
implementation can make greater assumptions knowing some internal
details aren't available.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 24 22:58:56 2017 +0100
sbr/vector.c: Move assert(3)s into bvector_create().
Rather than asserting on every bit-related operation, assert just when
creating the vector. Whether the assertion is true is decided at
compile time, so it only needs checking once; once for every vector is
an easy compromise.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 24 22:08:09 2017 +0100
sbr/vector.c: Replace Nbby with <limits.h>'s CHAR_BIT.
POSIX mandates CHAR_BIT is 8; see stdint.h(0p).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 24 21:19:56 2017 +0100
sbr/vector.c: calloc(3) rather than malloc(3) and memset(3).
calloc(3) tells libc upfront that the memory needs to be zeroed rather
than giving it the news later with memset. Perhaps this allows it to
allocate from a CoW page of zero bytes, or it benefits from some other
way in memset not having to clear each bit, but it knocks about 15% off
the wall-clock time and the number of library calls under ltrace(1).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 24 21:13:52 2017 +0100
sbr/folder_read.c: Don't clear newly created bvectors.
The newly created bvectors are already clear; don't loop clearing each
again with memset(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Apr 26 00:14:26 2017 +0100
sbr/fmt_scan.c: Only wcwidth(3) a valid mbtowc(3) result.
The assert(3) added by 80a9e99f7078199500d2d53c8d77d1b92af06fbc is
failing, but not reproducibly. It's probable that mbtowc() is returning
a negative, and not altering wide_char, leaving it as random stack
content. Taking its wcwidth() then sometimes also returns negative,
causing the assert() failure. Initialising wide_char before the call
isn't a solution as it isn't documented if it's modified to an invalid
value on an error return.
Instead, delay calculating the wcwidth() until after the possible
substitution of "?". Leave the assert() in place.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 16:17:09 2017 +0100
Remove return statements at end of void functions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 16:10:59 2017 +0100
tws.h: Remove ADJUST_NUMERIC_ONLY_TZ_OFFSETS_WRT_DST.
Code that's conditional on its definition has been kept; just the tests
removed. The comment explaining its purpose has been kept, just without
the "If defined...".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 15:48:53 2017 +0100
Use C's `++', `+=', etc., not the longhand.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 15:19:33 2017 +0100
Remove unneeded incomplete, member-less `struct tag;'.
The forward declaration isn't needed to typedef based on the struct.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 14:47:20 2017 +0100
mh.h: Compact the reserved sequence bit-masks.
Removes the gap created by axing DELETED.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 14:36:57 2017 +0100
mh.h: Remove unused MODIFIED and DELETED macros.
MODIFIED was a folder attribute used by msh(1), and DELETED a message
attribute that may have last been used in the 1980s.
Adjust corresponding FBITS and MBITS definitions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 14:36:47 2017 +0100
md5.h: Remove unused UINT2 typedef for unsigned short.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 13:50:02 2017 +0100
ap.man, dp.man: Add fmttest(1) to SEE ALSO section.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 13:33:57 2017 +0100
tws.h: Remove zero-valued TW_SNIL macro, used once.
Macro TW_SNIL was the zero value for a two-bit field. It was only used
once, and that is better ordered to check for bits set with none set
being the last, else, case, rather than in the middle. Kept the
behaviour of undefined value 3 being treated as TW_SIMP, 2.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 13:18:20 2017 +0100
tws.h: Remove redundant TW_SZONE and TW_SZNIL bit-masks.
TW_SZONE is a mask of one bit that can either be 0, TW_SZNIL, or set,
TW_SZEXP. Rather than three macros for the single bit, have one,
TW_SZEXP. Simplifies the test too when the mask is known to be one-bit
wide.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 11:01:18 2017 +0100
mh-format.man: Fix `Return' column heading alignment.
Two of the column headings were separated by spaces rather than a tab.
The other two similar tables used `Return' instead of `Result', so
switch to that at the same time.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 09:48:13 2017 +0100
sbr/dtime.c: Remove struct-assigning twscopy().
Historically, twscopy() assigned all the struct's members individually,
but that was `#if 0'd as far back as the repository goes. The one
caller now uses assignment, making clear the direction of data flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 09:28:24 2017 +0100
uip/sortm.c: Remove unused variable and dlocaltimenow() call.
read_hdrs() has a auto `struct tws tb'. It's only use is as the
destination for dlocaltimenow()'s result. Remove the variable. Also
remove the dlocaltimenow() call; this I'm unsure about as it has a side
effect of calling tzset(3). However, tests pass. Repository history
sheds no light.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 09:19:13 2017 +0100
sbr/dtimep.l: Remove always false `europeandate' flag.
Switched from reverse-podium MM/DD/YY interpretation to DD/MM/YY.
Never set so conditional code unused.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 00:47:32 2017 +0100
Append descriptions to C source files with first-line filenames.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 00:29:02 2017 +0100
Add first-line comment describing C source's purpose.
I had a stab at them after a bit of a skim; they're better than
nothing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 23 00:02:41 2017 +0100
Ensure a space after `#!'.
The majority of the `#!' scripts have a space before the `/';
add one to the three deviants.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 23:36:19 2017 +0100
Correct first-line comments where filename is wrong.
Having jiggled the start-of-file comment about, it's apparent that a few
files either don't know their own name, or the format the rest of the
gang follow. To wit, "basename(filename) -- ...".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 23:19:39 2017 +0100
Replace "/*\n * " with "/* " at the start of a file.
Pulls the meat of the comment onto the file's first line, now that the
blank line at the start of the file has been deleted. Allows `sed -ns
1p ...' or similar to give a summary of lots of files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 19:05:32 2017 +0100
Remove leading and trailing blank lines from code.
Many of the main source file start with a blank line, and many end with
one or more too. They seem to serve little purpose so delete them.
This makes all the files consistent in not having them and ideally the
first line of a C source file will say something about its content in
time instead of just "/*". Avoided editing format files, etc,. where
the line could be significant, and historical files.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 18:37:15 2017 +0100
mts/smtp/smtp.h: Remove one-use rp_isbad() macro.
It just cast its argument to signed char, and the sole user can do that
itself a few lines later.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 18:32:55 2017 +0100
mts/smtp/smtp.h: Remove unused `MMDF' macros.
The header file has a specification of a historical interface and
removing the unused parts leaves it incomplete, but it's unlikely those
parts will be needed and what remains seems more understandable; partly
due to it being less to grok, and also because it relates more to modern
use.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 18:21:01 2017 +0100
mts/smtp/smtp.c: Remove unused SM_... timeout macros.
SM_TEXT, SM_CLOS, and SM_AUTH are unused.
Alter the comment for the block of macros to state they're timeouts in
seconds.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 17:28:18 2017 +0100
h/mf.h: Remove many unused macros; some UUCP related.
MF... were "Codes returned by uucp2mmdf(), mmdf2uucp()".
A spot check of the others shows they've not been used in this git
repository.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 17:16:54 2017 +0100
sbr/mf.c: Remove unused functions: isfrom, lequal, mfgets.
isfrom(s) checked for /^>?From /.
lequal(a, b) was another case-insensitive strcmp(3).
mfgets(fp, line) fetched a header at a time from fp, indicating when the
end of headers was reached.
Investigating their historical usage was, ironically, made too tedious
to complete by the pollution of mass commits of historical MH.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 16:51:02 2017 +0100
uip/mhbuildsbr.c: Remove unusused MAXURLTOKEN macro.
"Maximum size of URL token in message/external-body".
Uses deleted in 95ad91ca30e1cda09efe454d12ed790a60661f56.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 16:48:13 2017 +0100
sbr/dtime.c: Remove unused `struct zone' definition.
The uses went in 6a68057d8ef48bef3ee752741a53a629a2840e68.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 16:46:33 2017 +0100
uip/post.c: Don't bother naming `struct oauth_profile'.
It's never used, and one more identifier to track when reading.
If there's no name, that's a signal it's not used elsewhere.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 16:42:51 2017 +0100
h/nmh.h: Remove unused NLENGTH(dirent) macro.
It just does a strlen(3) of its argument's d_name; that's not even done
longhand anyway. And its name is very generic for such a narrow task.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 16:41:00 2017 +0100
h/mts.h: Remove unused isdlm{1,2}() macros.
They just do a strcmp(3) of their argument against mmdlm{1,2} and test
it's "equal". That's more clearly written longhand than have yet
another small-scope, specialised, macro to recall; as practice bears
out.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 16:39:29 2017 +0100
h/mh.h: Remove unused set_deleted() macro.
Its comment says "for msh only".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 14:31:10 2017 +0100
h/tws.h: Remove TW_YES and TW_NO; TW_SUCC good enough.
TW_SUCC is a macro for the bit-mask 0x0040. TW_YES, a vague name, was
the same value. TW_NO was 0, and unused by the code. Ditch both those
as TW_SUCC is sufficient for setting and testing. Alter its comment to
make clear it means parsing was successful.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 14:10:41 2017 +0100
docs/FAQ: Replace suggestion of NOMHNPROC with -nocheckmime.
Environment variable NOMHNPROC was removed in 1.6, as stated in NEWS.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 01:00:29 2017 +0100
sbr/discard.c: Simplify by inverting initial test.
The function used to return early, but these days that's just avoiding a
single statement, so execute that conditionally instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 22 00:48:47 2017 +0100
sbr/lock_file.c: Move static variables into their functions.
A couple of file-scoped statc ints were the typical "if this function is
being called for the first time" flags. Move each into their respective
functions. Make them bools. Name them so the initial value is zero,
thus placing them in BSS.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 21 14:01:21 2017 +0100
send and whatnow: Remove deprecated -attach... switches.
They were changed to do nothing but warn on stderr that they were
deprecated in 521674623 and 035c5db34, both before 1.6's release, and so
can be removed ready for 1.7's release.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Apr 20 14:27:46 2017 +0100
uip/dropsbr.c: Fix buffer overrun in mbx_copy().
The overrun occurs frequently, but typically zeroes a byte of a
character pointer on the stack that's not yet been used.
Caused by 28610ff9a604a75ae0c383be03aa19415ddb1965 appending a NUL after
the bytes stored by read(2).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 18 15:37:54 2017 +0100
h/mime.h: Delete unused isatom(c) macro.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 18 12:54:28 2017 +0100
man/*.man: Fix some multi-word .B invocations.
Some needed to be .B for the first word, but .I for the second, or just
plain text for the rest of the words that should be on their own line.
Others were just plain wrong and became .IR for a man-page reference.
Then the .TP macro uses an input trap so only a single following line of
source is used and this prevents a two-line `.B .I', so use embedded
font escapes instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 18 01:14:57 2017 +0100
man/*.man: Use italic for emphasis, not bold or SHOUTING.
When reading a body of text, italic is sufficient to add emphasis to
what's already being read. Bold draws the eye to the word on the page
and is more useful for keywords, concepts, etc. Some `.B' remain that
should probably be `.I', but they looked to have other problems so I
left them out of this pass.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 18 00:27:35 2017 +0100
README.manpages: `user ID', not `user-id'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Apr 18 00:24:07 2017 +0100
man/*.man: Replace minus sign with hyphen: `\-' with `-'.
Conservatively changed many of the troff minus-signs, `\-', with a troff
hyphen, `-'. Where it wasn't quickly obviously, I left it unchanged.
There were also cases that shouldn't be either minus sign or hyphen.
Those were changed to hyphen and still need to be fixed properly.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 23:36:28 2017 +0100
README.manpages: It's a `From header', not a `From: header'.
Author: David Levine <levinedl@acm.org>
Date: Mon Apr 17 18:06:05 2017 -0400
Use stat(3) instead of lstat(3), to dereference symbolic links.
Fix to commit 4318012376e06229307c0ed4f62a00faae9edc63.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 14:53:28 2017 +0100
Don't ignore bit 5 of a char when comparing alias names.
It's a crude method of ignoring case, but makes `^' equal to `~'.
Use tolower(3) instead.
http://lists.nongnu.org/archive/html/nmh-workers/2017-03/msg00050.html
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 14:34:14 2017 +0100
man/mh-profile.man: Note MHTMPDIR is deprecated.
In future, only TMPDIR and /tmp will be used, e.g. not `mhpath +'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 14:06:36 2017 +0100
README.manpages: Add `Common errors and subjective conventions'.
Based partly on recent mailing-list posts about Larry's patches.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 13:32:47 2017 +0100
README.manpages: Add question to guide update of .TH's date.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 13:29:38 2017 +0100
README.manpages: Clarify that man-page source is ASCII.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 12:10:35 2017 +0100
Fix post's die() to save errno before unlink(2)ing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 11:50:39 2017 +0100
Allow advertise() to assume strerror(3) won't fail.
The code already assumes that elsewhere when it calls strerror().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 11:42:39 2017 +0100
Change admonish(NULL, "foo") to inform("foo, continuing...").
Removes more uses of the ad... functions with unneeded parameters.
Puts the "continuing" at the call site rather than the reader having to
remember it's being magically appended. (Some calls were passing
"foo\n" that would result in "foo\n, continuing...\n" appearing.)
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 11:13:36 2017 +0100
Don't store getname()'s return value during flushing.
`cp' after the loop is overwritten before being read.
Not storing the return value makes it clear it's not used.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 11:06:12 2017 +0100
Improve function comments for the ad... diagnostic functions.
Give the resulting layout of parameters that appears on stderr.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 10:57:54 2017 +0100
Fix bug in advertise("", "", "foo", ap).
A non-NULL but empty `what' would result in "fooerrno\n" without
separation. Improve the function's comment to try and make it obvious
how its out of order parameters appear.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 10:42:09 2017 +0100
Replace advise(NULL, fmt, ...) with inform(fmt, ...).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Apr 17 10:16:51 2017 +0100
Add inform() to provide an equivalent to advise(NULL, ...).
A small step in clearing up the confusing ad... names of the diagnostic
routines. `inform' isn't great, but err(3) nabs `warn' already.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 16 23:49:00 2017 +0100
Replace add(nonnull, NULL) with mh_xstrdup(nonnull).
Only a few cases where it's obvious that the first parameter will not be
NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 16 23:36:07 2017 +0100
uip/aliasbr.c: Add FIXME to prove test of add()'s return value.
add() always returns true so perhaps some other test is intended
instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 16 23:25:32 2017 +0100
man/*.man: Replace \(ru with an underscore, e.g. .mh_profile.
The character is an underscore, and that's what's wanted.
\(ru gives a "rule", which draws as a thick baseline in PDFs;
not a character at all.
Other devices map \(ru onto underscore, e.g. ASCII,
but an underscore should be used in the first place.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 16 14:01:42 2017 +0100
Replace some strdup() with mh_xstrdup().
(This is an old patch I had stashed.)
Some surrounding `if...adios()' are removed too, but most of the
strdup() calls weren't being checked for success, thus their
replacement.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 16 00:35:11 2017 +0100
Remove unneeded `\&' from man pages.
The zero-width character is used before a command character that is
intended to be literal but may end up at the start of a line.
Similarly, it's used after an end-of-sentence character when it may end
up at the end of the line but isn't the end of a sentence.
Remove the other cases because they're noise that confuses the issue of
when `\&' should be used.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Apr 16 00:34:01 2017 +0100
Alter mh-chart(7)'s NAME to be lowercase.
And mention the commands' options.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 20:14:42 2017 +0100
man/*.man: No need for empty comment to be comments.
A line that's just a `.' suffices.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 20:11:33 2017 +0100
Ensure .TH is the first line of a man page.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 19:17:31 2017 +0100
Fix errors in man-page NAME sections.
man/fmttest.man didn't have a NAME section, but a FMTTEST one.
And it broke lexgrog(1) by splitting the section over multiple lines and
using `.IR'. Re-write to use inline escapes.
man/rcvtty.man had two spaces before the `\-'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 15:29:02 2017 +0100
Switch date to yyyy-mm-dd in generated mh-chart.man.
It's still today's date, but improving on that seems non-trivial.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 14:48:02 2017 +0100
Specify yyyy-mm-dd date format for a man page's .TH date.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 14:36:51 2017 +0100
Use `Unix', not `UNIX', in man pages.
"...in deference to dmr's wishes."
— http://catb.org/jargon/html/U/Unix.html
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 14:25:12 2017 +0100
Fix forward-reference and `news.*' in mh-alias(5)'s example.
Spotted by Bob Carragher.
The example's forward reference was made a backward one, and `news.*'
explanation removed, in ff3060cefb460cce2174058eefff38b6e11ee2f1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 11:31:22 2017 +0100
Set man-page date to last significant change, UTC.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 13:26:42 2017 +0100
Wind man-page date back to last significant change, UTC.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 14 18:34:43 2017 +0100
Wind man-page date back to the earliest git revision, UTC.
No significant changes since then, and I can't find an earlier reference
date.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Apr 15 13:21:07 2017 +0100
Convert, already correct, man-page date to UTC.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 14 23:49:21 2017 +0100
Convert, already correct, man-page date to yyyy-mm-dd format.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 14 15:55:47 2017 +0100
Remove trailing spaces from lines in man pages.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Apr 14 15:51:58 2017 +0100
Escape literal leading full stop in man/new.man.
Error made in 5e32ede8e40251bf02f35b864e32a86e91599b3f.
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 23:20:07 2017 +0000
Editing of man/rmm.man.
- formatting, mostly
- don't make NOT bold
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 23:09:32 2017 +0000
Editing of man/rmf.man.
- delete trailing whitespace
- remove some \- things
- some formatting
- sort SEE ALSO
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 23:02:00 2017 +0000
Editing of man/repl.com.
- unashamedly add nmh to .SH NAME
- replace the delightfully baroque 'may be used to produce a reply
to an existing message' with 'may be used to reply to a message'.
- remove some \- objects
- deflower 'repl uses a reply template to guide its actions'
- remove multiple instances of 'replied\-to', with 'replied to'
- change 'tab\-stop' to 'tab stop'
- some formatting
- replace .B mhbuild with .IR mhbuild (1)
- replace whatnow with .B whatnow
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 19:05:21 2017 +0000
Editing of man/refile.man.
- some formatting
- change .B mh\-sequence (5) to .IR mh\-sequence (5)
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 18:54:52 2017 +0000
Editing of man/rcvstore.man.
- delete some \- things
- some formatting
- change protection to mode, in line with inc.man
- Uncapitalize .SS Locking and \-unseen
- sort SEE ALSO
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 18:21:58 2017 +0000
Editing of man/prompter.man.
- remove some \- items; quite a few, actually
- put .B prompter on a line by itself, a number of times
- some formatting
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 17:54:58 2017 +0000
Editing of man/prev.man.
- Delete trailing whitespace
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 17:52:22 2017 +0000
Editing of man/post.man.
- Delete trailing whitespace
- Change inline mh-profile(5) refs to .IR mh-profile (5)
- Some formatting
- Change take to read
- Say 'all message drafts' instead of 'all message draft'
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 17:35:37 2017 +0000
Editing of man/pick.man.
- Some formatting
- Delete trailing whitespace
- Change complimentary to complementary, because English
- delete some \- things
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 17:21:19 2017 +0000
Editing of man/packf.man.
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 17:08:00 2017 +0000
Editing of man/next.man.
- Delete trailing whitespace
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 01:19:47 2017 +0000
Editing of man/rcvtty.man.
- Add missing 'command'
- Some formatting
- Remove a \-, the mark that dare not speak its name
- Use 'switches' instead of 'options'
- Sort SEE ALSO programs
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 24 00:54:05 2017 +0000
Editing of man/mhfixmsg.man.
- 8bit -> 8-bit, nbit -> n-bit, except in flags and error msgs
- Add nmh to .SH NAME
- Formatting
- use .B for -outfile
- use .IR for mh-profile (5)
- sort SEE ALSO programs
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 22:52:46 2017 +0000
Editing of man/mhstore.man.
- store -> stored
- some formatting
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 22:08:44 2017 +0000
Editing of man/mhshow.man.
- Add some stray s's
- Some formatting
- Remove an \- object (I now pronounce \- as uh-unh; it's easier this way)
- Use alternative instead of alternate
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 21:07:49 2017 +0000
Editing of man/mhpath.man.
- Add some commas
- Some formatting
- Delete empty .PP
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 20:24:19 2017 +0000
Editing of man/mhparam.man.
- Add some commas
- Some formatting
- Delete 'just'
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 20:11:10 2017 +0000
Editing of man/mhmail.man.
- Add reference to nmh in .SH NAME
- Delete empty .PP
- Remove a few 'various'es
- Some formatting
- SEE ALSO in alphabetical order
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 18:12:46 2017 +0000
Editing of man/mhlist.man.
- Make clear that -headers is the default
- Some formatting
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 17:31:12 2017 +0000
Editing of man/mhl.man.
- Refer to environment variables (in text) without preceding $
- Don't put environment variables in bold (as per most other pages)
- Some better formatting
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 17:05:26 2017 +0000
Editing of man/mhical.man.
- Don't use capitalised .SH, when uncapitalised .SS will do
- Remove some early .SH/.SS to improve narrative
- Delete superfluous .fi
It could be argued that each of the (now) .SSs, which have been
demoted from .SHs, are unnecessary or, at least, not in line with
the other man pages . Demotion may suffice, for now.
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 14:15:46 2017 +0000
Editing of man/mhbuild.man.
- EDTIOR -> EDITOR
- remove some \- things
- formatting
- use 8-bit, like 7-bit
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 01:49:06 2017 +0000
Editing of man/mh-tailor.man.
- Straighten up some formatting
- Don't escape hyphens unecessarily
- Pluralise message (so that outgoing messages...)
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 01:29:20 2017 +0000
Editing of man/mh-sequence.man.
- Don't escape hyphens unecessarily
- Remove duplicate 'when' (when when)
- Straighten up some formatting
- Bring RFC reference into line (don't hyphenate)
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Mar 23 00:46:53 2017 +0000
Editing of man/mh-profile.man.
- Clean up some formatting
- Replace an .sp with a .PP
- Remove a couple of empty .PPs and .REs
- Make the good English, yes please
Author: Larry Hynes <larry@larryhynes.com>
Date: Wed Mar 22 22:57:13 2017 +0000
Editing of man/mh-mime.man.
- Clean up .SH NAME to one line without .IR nmh (7) on it
- Don't use escaped hyphens when not necessary
- Clean up some formatting
- Use 'Attach:' consistently (instead of 'Attach')
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Mar 21 22:56:39 2017 +0000
Editing of man/mh-mail.man.
I think we can rise above ourselves, and delete 'antiquated'.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Mar 21 22:35:50 2017 +0000
Editing of man/mh-folders.man.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Mar 21 19:54:56 2017 +0000
Editing of man/mh-draft.man.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Mar 21 01:48:34 2017 +0000
Editing of man/new.man.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Mar 21 01:31:52 2017 +0000
Mention `nmh' in man-page NAME section for apropos(1).
Author: Larry Hynes <larry@larryhynes.com>
Date: Sun Mar 19 23:40:59 2017 +0000
Replace `maildrop' with `mail drop' in man pages.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sun Mar 19 14:51:30 2017 +0000
Review inc.man.
First cut at a cleanup of inc.man, including: maildrop -> mail drop;
Ralph's mode/octal suggestion, with a change (by me) to refer to
chmod(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 2 09:26:17 2017 -0400
Attempt to fix test-ap on fbsd-10 build host.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 1 18:53:26 2017 -0400
Check for sufficient room for multi-column character.
Fix to commit 92128dacf8d5db02379e8f872dc50d31c6aaa55f. The sympton,
reported by Valdis, was overrun of scan -width.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 25 07:47:53 2017 -0400
Escaped repl, in case the user has it as a shell alias.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 25 07:46:45 2017 -0400
Added etc/rmmproc.messageid.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Mar 22 14:47:18 2017 +0000
Fix free(3) of unmalloc()'d string in whatnow's refile.
`ref +foo' at comp(1)'s whatnow prompt was trying to free "+foo".
Take a copy of the string so the later free works.
Tom Rodman reported the problem to nmh-workers.
Bug introduced in 3b6be5607a251a3a793e97382e251ce66ea2bca0.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Mar 22 10:51:34 2017 +0000
Work around flex 2.6.3 bug by conditionally #undef yywrap.
There's no sign on https://github.com/westes/flex/issues/162 that they
will release a new flex with the fix soon.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Mar 21 12:49:12 2017 -0400
Cleanup of .SH NAME sections.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sat Mar 18 13:49:06 2017 +0000
Fixed forw.man to pass test-manpages.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 18 16:53:15 2017 -0400
Added test case for commit 4318012376e06229307c0ed4f62a00faae9edc63.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 18 09:49:31 2017 -0400
Don't let parse_mime() try to parse a directory.
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Mar 17 12:36:06 2017 -0400
Cleanup to forw(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 22:50:42 2017 -0500
Added /* FALLTHRU */ comments where gcc 7 noticed their need.
And replaced similar comments to be consistent. Used that comment
because it satisfies gcc -Wimplicit-fallthrough=4.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 14:07:38 2017 -0500
Separate out backquote expression to please Heirloom shell.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 13:41:34 2017 -0500
Tweaked to work with Heirloom shell.
Shell parameter expansion ending in space needs it to be quoted.
Author: David Levine <dlevine@akamai.com>
Date: Tue Feb 21 10:31:57 2017 -0500
Echo CFLAGS in configure line, and only include if set.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 19 17:05:12 2017 -0500
Change "servers" mts.conf entry to only support a single SMTP server.
As part of this change, fix SMTP code so the chosen SMTP server is
configured correctly for the netsec code.
Author: David Levine <dlevine@akamai.com>
Date: Sun Feb 19 14:05:25 2017 -0500
Reworked handling of multiple, space separated, smtp servers.
Author: David Levine <dlevine@akamai.com>
Date: Sun Feb 19 14:00:04 2017 -0500
Suppress getcanon exit status check.
To allow tests to run when the local hostname doesn't resolve.
Author: David Levine <dlevine@akamai.com>
Date: Sun Feb 19 13:58:20 2017 -0500
Support mhparam -debug along with -all.
Fix to commit 234c9cc4829d86589a079ace49cfa5bc251ef62c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Feb 18 14:47:56 2017 +0000
Limit mhparam's exit status to 120 missing components.
Otherwise, 126 and 127 would clash with bash and zsh's use.
Higher than 127 would look like signals. And 256 would wrap
to a falsely succesful zero.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Jan 17 12:54:02 2017 +0000
mhfixmsg: Use folder name to open second message of a sequence.
`mhfixmsg foo' where foo was sequence of more than one message would
sucessfully process the lowest numbered message of the sequence, but
fail to open(2) the second one as the folder was missing from the path.
For example, /home/ralph/mail/inbox/1 was used to open the first, but
/home/ralph/mail/2 was attempted for the second. I guess this was
because a static array was being trampled during the first's processing,
though didn't try too hard to find where. Making a copy of it fixed the
problem.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 10:57:09 2017 -0500
Remove unused test file.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 10:51:40 2017 -0500
Added delay for output file to be closed.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 10:16:22 2017 -0500
Fixed references to --with-cyrus-sasl, and --without-, in comments.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 11 21:37:52 2017 -0500
Make sure we always generate a Content-ID header for message/external-body
entities, as required by RFC 2045.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 21:32:20 2017 -0500
Fixed permissions on test script.
Fix to commit 77fff244ad1bb1e746c78bedc87659400e2c6535.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 20:53:41 2017 -0500
Rearranged check for whether to skip param value checks so
that no files are left over.
Update of commit 2cf4ff9dd2fba77c7f98bbd706b00d2e79a11a3b.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 20:49:12 2017 -0500
Added valgrind suppressions for system libs on MacOS El Capitan.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 18:54:40 2017 -0500
Fixed commit 60052b95778a065760a437859ee9b8a1cc4e39a9, wrong sense.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 18:00:05 2017 -0500
Removed if ! bash-ism.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 17:38:27 2017 -0500
Fixed a couple of tests to not fail when there is no text browser.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 17:37:52 2017 -0500
Added missing AC_SUBST of AM_LDFLAGS.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 23:55:50 2016 +0000
crawl_context: Remove unused struct member `total'.
It was maintained inconsistently, and checking what problems that caused
showed it wasn't used.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sun Jan 1 23:15:56 2017 +0000
Changes to folder.man
Kill a couple of empty .PPs, resurrect a lost .SS, a little bit
of slash and burn, stray whitespace, the usual.
As far as I know, which is not far, the \- construct is only
required for \-args, not, e.g., sub\-folder.
I've changed instances of 'subfolder' to sub-folder.
I've changed the 'the' in
These folders are all preceded by the read-only...
to 'any'.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sat Dec 31 17:57:13 2016 +0000
Changes to install-mh.man
Some more simple wordsmithing...
Change instances of 'Install-mh' to 'install-mh', in line with
other pages, switch to single `' around 'Mail', in line with
other pages, option -> switch, clean up a little.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sat Dec 31 15:57:42 2016 +0000
A cleanup, and possibly some controversy: I've replaced
Rather than standard message skeleton
with
User message skeleton
My thinking here is that a) we can do away with the kinda weird
'Rather than', b) I find the distinction between 'default' and
'standard' to be vague and c) it only appears in a few pages
and is easily remedied. It turns up in comp(1) as "An alternative
to the standard skeleton.", where 'standard' is used in the same
way as 'default' is used in rcvdist(1), so I think it's worth
settling on something 'better' and applying it consistently.
My proposal is 'Default foo', for the foo in %nmhetcdir% and
'User foo' for the foo in the user's <mh-dir>.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sat Dec 31 15:54:55 2016 +0000
Fix skeletons in comp(1), forw(1) and dist(1)
While I was here, I removed two 'empty' paragraphs (.PP) in forw(1).
They may have been intended as line breaks, but I think they are
unnecessary; feel free to overrule me!
Aside: I would not be unhappy if, some day, 'skeleton' was replaced by
something utilitarian like 'template'.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 31 09:30:07 2016 -0500
Remove .w3m from test directory.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 31 09:22:19 2016 -0500
Reverted commit 316068ee3b7105ea802c63b732ee4cfb584a2600.
It was a repeat of commit 30a9c9b62fa92df289079080eb5ee57d2fda3951.
Also, wrapped a few $MH_TEST_DIR with quotes.
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Dec 29 21:47:21 2016 -0500
Clean up, and change .SS case to Title Case, from UPPER,
in line with other pages.
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Dec 23 16:29:36 2016 +0000
Changes to rcvpack.man
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 21 15:38:11 2016 -0500
Make the -fcc switch to repl actually work properly, and make sure that
any Fcc header in a replied-to message is not carried over to the draft.
Author: Larry Hynes <larry@larryhynes.com>
Date: Wed Dec 21 16:58:51 2016 +0000
Changes to fmtdump.man
Add a reference to fmttest(1), delete a superfluous 'the',
delete the '...is simply...' line.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 20 11:49:20 2016 -0500
Added check of -fcc with no fcc in components.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 20 11:48:27 2016 -0500
Protect repl -file against dereference of null mp.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 19 11:20:54 2016 -0500
Removed #ifdef FT_PAUSE protection.
FT_PAUSE is unconditionally defined in h/fmt_compile.h.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 19 11:18:38 2016 -0500
Removed unused references to FT_ADDTOSEQ.
They were #ifdef LBL relics.
Author: Larry Hynes <larry@larryhynes.com>
Date: Mon Dec 19 01:17:10 2016 +0000
Changes to mh-format.man
This is a beast, and we may not tame it at the first attempt.
Mostly language simplification, some grammar and formatting, trailing
whitespace, that sort of thing. There are one or two instances where
I've taken (small) liberties with language, in favour of 'comprehension
at first glance'.
There are some commented lines hanging around in this. I've left
them in, but I think they should go at the first opportunity.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 19 11:11:27 2016 -0500
Removed obsolete comment about use of getcpy().
Author: Larry Hynes <larry@larryhynes.com>
Date: Sat Dec 17 19:28:30 2016 +0000
Changes to dist.man
Switch 'in place' for inplace, remove 'in truth of fact'.
Author: Larry Hynes <larry@larryhynes.com>
Date: Sat Dec 17 19:28:31 2016 +0000
Changes to flist.man
Replace 'option' with 'switch' in a couple of places, correct
(hopefully) a few sentences, restore '.SS "Multiple Folders" to its
rightful place.
Author: Larry Hynes <larry@larryhynes.com>
Date: Fri Dec 16 22:55:39 2016 +0000
Changes to comp.man
Remove the slightly legalistic 'in truth of fact', and bring the
mention of man whatnow into the preceding sentence.
The line 'If the draft already exists, comp will ask you as to the
disposition of the draft.' makes no sense to me, and I'm struggling
to make it make sense. If we put to one side the fact that I think
it's a broken sentence, I still haven't managed to get comp to
accept - or prompt me for - a 'replace' option when 'the draft
already exists', so I'm afraid I have to admit defeat here and seek
the wisdom of the elders.
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Dec 15 21:57:35 2016 +0000
Changes to burst.man
I'm not sure how relevant burst(1) is these days, but here goes...
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 15 17:44:56 2016 -0500
Added clarifications to abbreviations.
1) N must be a positive number.
2) The + can be omitted.
3) As many of the N messages that exist.
4) Can also use - (or +) with first, prev, next, and last.
Author: Larry Hynes <larry@larryhynes.com>
Date: Thu Dec 15 18:33:15 2016 +0000
Changes to nmh.man
This adds a reference to the 'COMMANDS' section, corrects - and
hopefully simplifies - a couple of things, and tries to untangle
the line beginning 'show displays...' in the seventh paragraph.
The line 'The first, previous, next or last messages, if they exist.'
doesn't seem to accurately cover the accompanying 'foo:N' listing
in the following, or am I missing something?
first:N
prev:N
next:N
last:N The first, previous, next or last messages, if they exist.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Dec 13 20:14:11 2016 +0000
Changes to ali.man
The following is the beginning of an attempt to clean up the manual
pages somewhat.
grep tells me that 'switch' is used 193 times, whereas 'option' is
only used 51 times, so I've tried to standardise on 'switch'.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 13 16:06:38 2016 -0500
Fixed description of anno -list switch.
As noted in commit 98c2e7d95bda262ef23e8f0838e5b86d08ed4e4f.
If -text is used with -list, its argument is required but
ignored.
Author: Larry Hynes <larry@larryhynes.com>
Date: Tue Dec 13 20:14:11 2016 +0000
Changes to anno.man.
(Also noted that description of -list needs to be fixed, will
do in next commit.)
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:51:06 2016 +0000
showbuildenv: Add comment describing exit-status convention.
It helps explain why some commands are `... || true' despite no `set -e'
being in effect.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:48:19 2016 +0000
Revert "Test if the buildbots care about tools/showbuildenv's exit status."
This reverts commit c92a4119fca5d677055dc616255a7d1efec9d750.
They do care, showing "environment failed".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:46:04 2016 +0000
Rename recently added ToUpper() to to_upper().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:45:00 2016 +0000
Rename recently added ToLower() to to_lower().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:43:59 2016 +0000
Rename recently added TrimSuffixC() to trim_suffix_c().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:42:47 2016 +0000
Rename recently added HasSuffixC() to has_suffix_c().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:39:21 2016 +0000
Rename recently added HasSuffix() to has_suffix().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:36:43 2016 +0000
Rename recently added HasPrefix() to has_prefix().
Sticking with local convention, as Ken requested.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:24:27 2016 +0000
Test if the buildbots care about tools/showbuildenv's exit status.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:19:43 2016 +0000
Document that adios() does not return. abort() ensures it won't.
Discussion with David confirmed that adios()'s de facto contract with
the caller is that it won't return. Document that, and add an abort(3)
to ensure it won't occur. Better that than return and blunder on until
a SEGV or corruption later.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Dec 10 14:11:13 2016 +0000
mhlsbr.c: Don't hide mhladios and mhldone behind macros.
Locally defined mhladios() and mhldone() were called as adios() and
done() thanks to #defines that hid the widely-used functions with those
names. Don't bother as it confuses the reader. Just call the local
variations directly to make clear it's not the standard implementation.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 9 09:34:59 2016 -0500
Generalized condition for support of parameter value tests.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 21:04:52 2016 -0500
One last fix to test-charset.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 20:53:36 2016 -0500
Fixed condition to enable skipping parameter value tests.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 20:45:57 2016 -0500
And skip the other parameter value test on the FreeBSD10 buildbot.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 20:18:14 2016 -0500
That didnt work, so skip Encoded parameter value test on that buildbot.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 20:03:28 2016 -0500
Use locale that the FreeBSD10 buildbot has.
It has EBCDIC-UK but not EBCDIC-US.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 19:51:25 2016 -0500
Added temporary debug code.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 19:37:40 2016 -0500
Try to fix Encoded parameter value test on FreeBSD10 buildbot.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 8 16:27:40 2016 -0500
Replaced !iscntrl() with isprint().
To address Ralph's FIXME comment. One example where a byte would
have been printed with !iscntrl() is 0x24 is ISO 646 BASIC (Inv),
which is undefined. Also, added test cases to cover most of
get_param_value(). Also, replaced a couple of other FIXME's with
code comments.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 5 11:50:40 2016 -0500
Fixed and restored commit 9a4b4a3d3b27fe4a7ff6d0b8724ce1c06b5917eb.
Using AC_CHECK_MEMBERS instead of AC_CHECK_MEMBER. I don't know why
the former works but the latter doesn't.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 4 17:13:09 2016 -0500
Reverted commit 9a4b4a3d3b27fe4a7ff6d0b8724ce1c06b5917eb.
It broke the build on the FreeBSD 10 buildbot, not sure why.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 4 17:02:13 2016 -0500
Enabled detection of tm_gmtoff on _GNU_SOURCE platforms, e.g., Linux.
By temporarily adding $AM_CPPFLAGS to CPPFLAGS.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 3 12:03:53 2016 -0500
Added filename completion to bash_completion_nmh.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 25 09:02:08 2016 -0500
Close temp file.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 23 10:05:38 2016 -0500
Added flex 2.6.0 (with Fedora 25) output fixup.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 20 14:25:11 2016 -0500
Open infile before fixing each message.
Though the input file won't need to be opened if everything goes
well, do it early just in case there's a failure, and that failure
is running out of file descriptors.
Author: Larry Hynes <larry@larryhines.com>
Date: Sun Nov 20 10:32:40 2016 -0500
Fix nmh man page so it shows correct name of profile.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Nov 14 00:14:31 2016 +0000
mhstoresbr.c: Factor MIME-parameter-can-be-used-for-filename test.
It was several lines repeated each time, and it saves having to check
they're all identical. The original test pressed on if the MIME
parameter's value was an empty string; preserve that as it's spotted
later on.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 23:05:37 2016 +0000
Split a few more if-then statements into two lines to help gcov.
It's interesting to see how often some of them have the then-branch
taken.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 19 10:37:06 2016 -0500
Open outfile before parsing message(s).
So that we don't have to risk opening it after running out of fds.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 19 10:28:08 2016 -0500
Added application/ics entries, and "file was generated" comment.
application/ics is odd but does appear in the wild, and sometimes
without a corresponding text/calendar part.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 19 10:24:43 2016 -0500
Added mhshow-suffix-text entry.
I don't know why it wasn't there already, it's in the mhshow
man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 13 19:40:53 2016 -0500
Tweaked to work with Heirloom shell.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 13 17:56:44 2016 -0500
Removed bash-ism "function" declaration.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 13 14:50:08 2016 -0500
Replaced docs/COMPLETION-BASH with etc/bash_completions_nmh.
It's generated from man/mh-chart.man, which in turn is generated.
Automake doesn't like generated files in docs, hence the move to
etc. And the new filename better fits usage, I think.
Did not provide support for completing message numbers. It can
be fooled by programs that take multiple switches with +
arguments.
COMPLETION-BASH was broken with current bash, anyway.
Also, removed sbr/sigmsg.h from CLEANFILES in Makefile.am. It
was a leftover from commit 5776f9b783afe8e6bdbe430adb5d5b9435d25b19.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 13 09:39:01 2016 -0500
Added copyright noticed.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 13 09:38:24 2016 -0500
Removed unused declaration of output_message().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Nov 13 01:05:09 2016 +0000
Replace many add(s, NULL) with mh_xstrdup(s).
Where s is known to be non-NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 18:48:20 2016 +0000
Replace some add(FIELD, NULL) with mh_xstrdup(FIELD).
The various FIELD are macros for string constants so can not be NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 18:40:46 2016 +0000
m_getfld: Shuffle `delim' assignments slightly.
Document end state of the four pointers to parts of the delimiter.
fdelimlen can be, wrongly, one less without causing problems because a
second check uses edelimlen. The only side effect is an extra iteration
through m_getfld().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 15:35:35 2016 +0000
Revert "m_getfld: Shorten fdelimlen by one; it was too long."
This reverts commit 36a12f6a1a5a57799e48b23fd5ae47fe2351be68.
I think it was right after all, but currently trying to get a test to
fail with the faulty change.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 00:55:17 2016 +0000
Replace copy(s, d) with POSIX-1.2008's stpcpy(d, s).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 00:39:23 2016 +0000
m_getfld: Replace matchc() with memmem(3).
libc is more likely to find one lump of memory inside another quicker
than a home-grown quadratic emulation of the VAX's MATCHC instruction.
memmem() isn't POSIX, but exists on Linux and FreeBSD. This will see if
the buildbot is happy.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Nov 12 00:31:36 2016 +0000
m_getfld: Remove never-true test in matchc().
Now the fdelimlen doesn't include the NUL it is never true. I didn't
understand how it could ever be true but gcov on the test suite was
showing 22e6 tests had three positives; that's what put me on to
fdelimlen's overshoot.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 11 23:23:11 2016 +0000
m_getfld: Shorten fdelimlen by one; it was too long.
The fdelimlen bytes starting at fdelim included a NUL at the end, e.g. 7
for "\nFrom \0". Other code seems not to expect this and has
conditional bits to work around it, perhaps without understanding why.
All the tests still pass, including with valgrind.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 11 21:25:39 2016 +0000
configure.ac: Add FIXME regarding _BSD_SOURCE for tm.tm_gmtoff test.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Nov 11 00:38:29 2016 +0000
dlocaltime(): Only call tzset(3) once.
This avoids the stat(2) of /etc/localtime per message scan if TZ isn't
set in the environment; that's the default case on this Linux system.
I can't see a way the TZ environment variable is likely to change
between messages, or that it's intended an invocation of scan(1), say,
copes with the timezone shifting underneath it by /etc/localtime being
changed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 10 22:44:59 2016 +0000
uip/scansbr.c: Use fputs(3) instead of mh_fputs().
I can't see any reason a local one exists. It loops, calling putc(3).
The stdlib has the opportunity to be more efficient.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 10 21:39:40 2016 +0000
Add test-forw-coverage to improve uip/forw.c's coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 9 04:50:01 2016 +0000
test-mhl-flags: Improve coverage of uip/mhlsbr.c.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 9 03:02:02 2016 +0000
test-fmtdump: Increase uip/fmtdump.c coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 8 23:55:13 2016 +0000
test-flist: Increase coverage on argv[] processing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 8 23:32:23 2016 +0000
Add test/format/test-ap to get 100% uip/ap.c coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 3 10:23:31 2016 +0000
uip/dp.c: Increase coverage to 100%.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 8 08:25:50 2016 -0500
Replaced add(s, NULL) with mh_xstrdup(s).
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 8 08:16:24 2016 -0500
Removed unused global from MIME parser.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 7 21:01:31 2016 -0500
Initialize mhparse global for each message.
Globals are evil. It's tricky to test, so no test was added.
Just cleaned up test-mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 7 16:43:01 2016 -0500
Forgot to commit test-mhbuild. And thank Tom Lane for reporting bug.
Update to commit 6c359ae82651d117af71c55ce1e56f3c5db18bfe.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 7 16:28:14 2016 -0500
Don't parse parse # lines with mhbuild -nodirectives.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 6 17:41:01 2016 -0500
Plugged remaining mhfixmsg(1) memory leaks.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 6 17:39:13 2016 -0500
Made static char strings const.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 6 16:48:40 2016 -0500
Plug memory leak with parameter continuations.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 6 16:46:42 2016 -0500
Free c_ctparams for all content types, not just text.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 3 10:41:50 2016 +0000
uip/ap, uip/dp: Remove unneeded char **arguments.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 2 23:25:14 2016 +0000
dp: Fix write past end of dates[] array.
Not spotted by valgrind because that doesn't check heap or stack arrays.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 3 10:36:30 2016 +0000
ap: Fix write past end of addrs[] array.
Not spotted by valgrind because that doesn't check heap or stack arrays.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 5 09:49:59 2016 -0400
Just show relevant portion of invalid encoded string.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 5 09:46:17 2016 -0400
Replaced use of freects_done() with free_content() for each message.
Thereby not holding on to open file descriptors until termination.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 3 15:50:40 2016 -0400
Pass through message even if from relative folder.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 3 08:52:53 2016 -0400
Use result, because (void) didn't prevent warning on FreeBSD 10.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Nov 3 11:14:55 2016 +0000
test-rfc6532: Export LC_CTYPE after setting it.
Updates commit 2c4ac164edefd18861595ec7624e5ad344b10198.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 2 20:33:52 2016 -0400
Changed type of flags from signed to unsigned long.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 2 20:24:32 2016 -0400
Replace non-ASCII characters in headers with ?'s with non-UTF8 locale.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 2 20:08:27 2016 -0400
Fixed display of header field values with multibyte characters.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 2 11:36:07 2016 -0400
Removed NMH_UNUSED(hostname) because it no longer exists.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 2 10:45:16 2016 -0400
Add some Autoconf support for older OpenSSL libraries that don't support
hostname verification.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Nov 2 12:08:04 2016 +0000
State netsec_set_tls()'s noverify is unused if no TLS.
Stops compiler warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Nov 1 23:30:34 2016 -0400
Update docs a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Nov 1 23:13:04 2016 -0400
Add support for certificate verification when using TLS.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Oct 30 21:20:36 2016 -0400
Print out more TLS information if -snoop is turned on.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 17:49:08 2016 +0000
test/folder: Add test-coverage; lots of check_exit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 17:03:14 2016 +0000
Split one-line condition+body to get gcov results.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 12:37:48 2016 +0000
uip/dist.c: Increase coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 12:23:12 2016 +0000
uip/send: -saslmech lacking argument indexed outside array.
Similar to problem in commit 171ad462ce7582196f91f93f91f99fc60a21189e.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 11:51:26 2016 +0000
man: Fix spelling mistakes.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 11:49:43 2016 +0000
Fix spelling mistake in comment.
Only done because the same typo appears in the man pages.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 11:49:11 2016 +0000
Fix spelling mistakes in UI text.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 11:11:11 2016 +0000
test: Remove the " # gcov" comment from check_exit calls.
Now the command is passed to check_exit, that is sufficient to indicate
it's for coverage uses only, and a candidate to be fleshed out into a
test that checks the output.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 00:41:58 2016 +0000
uip/comp.c: Increase coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 00:17:47 2016 +0000
uip/burst.c: Increase coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 00:08:02 2016 +0000
uip/anno.c: Increase coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Nov 1 00:05:42 2016 +0000
anno: Stop segmentation violation on `-number 0'.
If atoi(3) returned zero, either because `0' was given or the number
could not be parsed, then the error message dereferenced an invalid
pointer. Found when trying to increase coverage with check_exit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 23:13:02 2016 +0000
uip/ali.c: Increase coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 18:36:19 2016 +0000
ali: Fix a memory leak spotted by valgrind.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 18:18:07 2016 +0000
mhbuild's fgetstr(): simplify source, logic untouched.
The tests aren't getting 100% coverage and the nested assignments make
it harder to see what's happening, and what needs to happen to gain
coverage. Hoist invariants so it's clear they're such to the reader and
not just the compiler.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 31 19:01:36 2016 -0400
Remove test files that aren't removed by check().
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 31 15:17:55 2016 -0400
Replaced BUFSIZ with NMH_BUFSIZ in a few places.
This allows the test suite to succeed with BUFSIZ of 256. We should
consider using different constants for different purposes.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 31 15:03:07 2016 -0400
Don't set CT type if reformat failed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 17:56:13 2016 +0000
Uncapitalise a few more mentions of commands in man pages.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 17:47:22 2016 +0000
mh-mkstemp.man: Detail exit status as 255 rather than -1.
Since that's what the outside kernel and outside world sees.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 17:44:24 2016 +0000
Use new check_exit in `# gcov' tests.
It showed up fmtdump wasn't being found because $? was 127, not 1.
And mkstemp exits 255 on error, unusually amongst MH commands.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 31 17:18:11 2016 +0000
test/common.sh.in: Add test_exit() for $? checking.
The stdout and stderr of the command being tested are saved but ignored,
only regurgitated if the test fails. The test is stated as a fragment
of a test(1) condition, e.g. '-eq 1'. This is mainly intended for the
quick one-liners to increase gcov coverage and thus valgrind's scope.
Over time, better tests that check more of the command's behaviour can
replace these, keeping the coverage level.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 31 11:39:11 2016 -0400
Replaced use of ! with || true, for ultimate Bourne shell compatiblity.
Update to commit c3ba36f92bcbf44e071961f3d0bb5e6ddab317d6.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 21:45:22 2016 +0000
test-nocreate: Don't use run_test and run_prog together.
valgrind tries to run run_prog and can't find the command.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 21:06:06 2016 +0000
fgets() reserves space for the NUL itself.
No need to knock one off the buffer size when calling it as that
suggests something special is going on.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 20:51:07 2016 +0000
Gain coverage with `mhparam localmbox'.
Now 100% for uip/mhparam.c
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 20:48:25 2016 +0000
Remove mhparam's p_find()'s ability to take NULL argument.
It can't be passed NULL and couldn't get coverage.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 20:41:29 2016 +0000
Get coverage of quite a few of the `ambiguous switch' case.
Typically by adding a `foo -', discarding stdout and stderr, and
expecting it to exit non-zero. A `# gcov' comment states its purpose,
and makes it easier to see if they can be deleted in time as other
coverage tests improve.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 20:18:28 2016 +0000
Split gcov target into multiple sub-targets.
Allows them to be run individually.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 15:55:30 2016 +0000
Clarify trunccpy()'s src and dest must not overlap.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 15:25:44 2016 +0000
Replace printf("%s", foo) with fputs(foo, stdout).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 15:09:55 2016 +0000
Replace strlen(foo) > 0 with *foo.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 15:07:41 2016 +0000
Add outputs from Makefile.am's gcov target.
*.gcda, *.gcno, and *.gcov.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 15:04:38 2016 +0000
Remove sbr/peekc.c containing unused peekc().
gcov showed it wasn't getting any; we've all been there.
It didn't check for EOF, nor that the ungetc(3) succeeded.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 14:46:01 2016 +0000
Replace fprintf(fp, "%s", foo) with fputs(foo, fp).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 14:44:07 2016 +0000
Replace printf("%s", foo) with fputs(foo, stdout).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 14:05:16 2016 +0000
Replace printf("%s\n", foo) with puts(foo).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 13:45:40 2016 +0000
Add trunccpy(), and the convenience TRUNCCPY().
truncpy copies at most size - 1 chars from non-NULL src to non-NULL
dst, and ensures dst is NUL terminated. If size is zero then it
aborts as dst cannot be NUL terminated.
It's to be used when truncation is intended and correct, e.g.
reporting a possibly very long external string back to the user. One
of its advantages over strncpy(3) is it doesn't pad in the common
case of no truncation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 30 00:03:34 2016 +0100
Fix test-header-parsing test script.
It was using sh's backticks that chomped the last linefeed!
Add comment referencing the commit that fixed the code this is testing.
Have fewer test cases, sticking to just one or two character headers
with empty or one-character bodies. Avoids slowing the tests too much
and the fixed bug was to do with hashing one-character headers.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 29 23:11:52 2016 +0100
Simplify folder_exists() to just testing stat(2)'s return value.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 28 23:51:41 2016 +0100
Replace printf("...\n") with puts("...").
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 28 23:10:55 2016 +0100
Replace v?fprintf(stdout, ...) with v?printf(...).
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 29 22:24:25 2016 -0400
Added (y|n) domain to a couple of build_nmh config prompts.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 29 22:12:37 2016 -0400
Set first character of name[] buffer in BODY state.
Fix to 47313b9bc395470311e383b57eb184c830662c4a to prevent
uninitialized read, revealed by test/burst/test-burst-mime
with NMH_VALGRIND=1.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 26 19:08:53 2016 -0400
Removed configure options now that it determines them automatically.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 26 11:38:45 2016 -0400
Moved build_nmh to top level directory.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 26 11:31:49 2016 -0400
Reworked output handling.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 25 12:10:51 2016 -0400
Reworked default SASL support to enable if header and lib are found.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 25 11:35:20 2016 -0400
Added -r to gcov invocation.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 25 11:10:01 2016 -0400
Add -O0 instead of -O2 to CFLAGS with build_nmh -d option.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 25 11:05:54 2016 -0400
Don't add -D_FORTIFY_SOURCE to AM_CPPFLAGS with -O0.
Merge: 7b27ac3d 9cca3d06
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 25 00:23:49 2016 +0100
Merge branch 'master' of git.sv.gnu.org:/srv/git/nmh
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 25 00:04:12 2016 +0100
Replace fputc() with putchar().
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 24 19:01:14 2016 -0400
Changed build_nmh sasl and tls defaults to be configure's.
Merge: e00c6017 1e7b41c1
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 23:49:11 2016 +0100
Merge branch 'master' of git.sv.gnu.org:/srv/git/nmh
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 23:37:50 2016 +0100
Replace putc() with putchar().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 23:37:34 2016 +0100
Replace putc() with putchar().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 23:36:52 2016 +0100
Replace putc() with putchar().
Others already existed. Not being a macro probably won't hurt.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 24 18:31:27 2016 -0400
Removed unnecessary definition of tls_support.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 23:22:06 2016 +0100
Replace puts() with putchar().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 23:21:57 2016 +0100
Replace puts() with putchar().
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 24 18:07:48 2016 -0400
Reworked default TLS support to enable if header and libs are found.
Also, fixed AC_CHECK_LIB for libssl. The crypto lib
needs to be the fifth, not fourth, argument.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 24 14:33:23 2016 -0400
Removed OAUTH support detection from because configure does it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 19:11:07 2016 +0100
sbr/netsec.c: Add NMH_UNUSED(nsc) twice for if !TLS_SUPPORT.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 18:59:30 2016 +0100
netsec_set_tls(): Return a value in the !TLS_SUPPORT && !tls case.
Silences clang.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 24 12:58:04 2016 -0400
More enhancements to build_nmh.
1) Display failure messages that were hidden.
2) Display location of log file at end, if not in current directory,
the build failed, or verbose was enabled.
3) Replaced use of showbuildenv with less invasive platform info.
4) Don't colorize tests summary if TERM is unset or dumb.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 16:34:17 2016 +0100
nmh.h: Add getline() prototype, conditional on HAVE_GETLINE.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 12:12:29 2016 +0100
Fix flex 2.6.1's output regarding signed/unsigned comparisons.
Add comment referencing flex bug.
Note this workaround breaks $(LFLAGS).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 12:12:09 2016 +0100
mhical.c: display(): Replace memcpy() with struct assignment.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:18:18 2016 +0100
fix_filename_param(): Remove redundant strlen().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:15:33 2016 +0100
fix_filename_param(): Replace strncmp() with HasSuffix().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:11:42 2016 +0100
sbr/utils.c: Add HasSuffix(s, suffix).
HasSuffix returns true if non-NULL s ends with non-NULL suffix.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:03:48 2016 +0100
Use LEN() to save having to consider the -1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:03:12 2016 +0100
Use LEN() to save having to consider the -1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:02:33 2016 +0100
Use LEN() to save having to consider the -1.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 00:01:54 2016 +0100
Remove unused NCWD and NPWD #defines.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:45:34 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:44:58 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:44:38 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:43:41 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:43:19 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:20:58 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:20:45 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:20:31 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:02:49 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 23:02:01 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 22:59:57 2016 +0100
nmh_command_generator(): Fix indentation.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 22:51:24 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 22:49:25 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 22:48:49 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 22:47:08 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 22:36:26 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 18:56:58 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 18:56:33 2016 +0100
Use HasPrefix() instead of strncmp().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 12:08:31 2016 +0100
Alter HasSuffixC()'s char * to be const.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 12:02:55 2016 +0100
utils.c: Add HasPrefix(s, prefix).
HasPrefix returns true if non-NULL s starts with non-NULL prefix.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 01:18:49 2016 +0100
Rename EndsWithC() to HasSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 01:13:57 2016 +0100
mh-folders.man: Remove empty `.I' immediately followed by `.IR'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 09:59:44 2016 +0100
build_nmh: If cloning with git, make a shallow clone.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 09:46:52 2016 +0100
showbuildenv: Drop lsb_release(1); /etc/lsb_release tested earlier.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 09:33:56 2016 +0100
build_nmh: Use `gzip -d' rather than assume tar has -z.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 24 09:31:00 2016 +0100
build_nmh: Have a silent curl still show errors.
Arguably, -sS should be curl's defaults!
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 23 17:16:31 2016 -0400
Fixed output of commit hash by git log command.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 23 17:12:04 2016 -0400
Check for existence of tools/showbuildenv.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 23 16:25:00 2016 -0400
Redirect verbose build_nmh messages so they're visible while running.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 23 16:03:11 2016 -0400
Enhanced build_nmh to support standalone use.
1) If not in nmh directory, download the nmh sources from savannah
using git clone, wget, or curl.
2) Added -b branch option, for use when downloading.
3) Support -l -.
4) Capture build environment with tools/showbuildenv.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 01:10:58 2016 +0100
man: Use lowercase for command name at start of sentence.
`Inc' is a different command to `inc'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 23 00:08:17 2016 +0100
uprf(): Rewrite, using types rather than masking ints.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 23:37:19 2016 +0100
Add comment describing uprf().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 19:56:52 2016 +0100
Use ToLower() instead of loop.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 19:53:01 2016 +0100
Use ToUpper() instead of loop.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 19:52:42 2016 +0100
Use ToUpper() instead of loop.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 19:43:12 2016 +0100
Add ToLower(s) and ToUpper(s).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 19:33:24 2016 +0100
putcomp(): Use local to avoid repeating tautological ternary.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 19:18:15 2016 +0100
Alter netrc permissions error message to match code. Add test.
The code wants `go=', but the error message, and FAQ, said to clear read
permission from group and other. Add test to inc/test-pop as that is
the existing netrc test location, but it might be better in its own test
file as other tests for netrc parsing could be added.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 18:09:02 2016 +0100
Fix netrc's token()'s bug if backslash escapes EOF.
Discard the whole token so the user hopefully investigates.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 18:01:16 2016 +0100
Fix netrc's token() bug of first character being backslash.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 17:47:06 2016 +0100
Merge .netrc's token() file-reading loops; quoted and not.
Check for ferror(3) as well as feof(3) on entry.
Comment on lack of definition of quoted-string syntax, e.g. «"foo""bar"»
is two tokens without needing a separator.
Add comments on bugs for first non-quote character of a token being
backslash, and if a backslash escapes EOF.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 16:17:42 2016 +0100
Have ruserpass() return TOK_EOF and put "" in the token table.
Gives 0 a name and removes a little logic.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 16:04:58 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 15:53:51 2016 +0100
Check advertise()'s iob[] isn't too short with assert(3).
Using DIM(a) added to h/mh.h
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 15:36:40 2016 +0100
Use macros in advertise() to simplify source.
Happens to remove strlen() of literals at the same time.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 14:43:11 2016 +0100
Document advise(), adios(), admonish(), and advertise().
It doesn't make their design any better. Their "ad" prefix goes against
common advice of having distinguishable identifiers to avoid mix-ups,
and seems to be a theme that got out of hand. The out-of-order
parameters to advertise seem due to lack of strerror(3) that's no longer
a problem.
Before:
advertise("open", "continuing...", "couldn't read profile: %s",
path);
Could be:
error("couldn't read profile: %s: open: %s, continuing...\n",
path, strerror(errno));
And the "open" is typically dropped as superfluous so there's a
repetitive leading NULL passed a lot.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:58:43 2016 +0100
POSIX, 2016 Ed, removes bcopy(3). Stop referring to it.
Even though it's in a comment, it shows up in searches.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:45:35 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:45:24 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:45:22 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:45:19 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:45:16 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:45:11 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:44:47 2016 +0100
Don't need to cast to `char *' for free(3) these days.
But still need a cast to discard the const.
Use `void *' as it saves needing to check the original type.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:42:52 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:42:47 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:42:45 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:42:43 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 13:42:39 2016 +0100
Don't need to cast to `char *' for free(3) these days.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:45:09 2016 +0100
Move smtp_init's last-ditch attempt for client inside first test.
Didn't realise there was a second lot of similar code before the last
commit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:41:44 2016 +0100
Move smtp_init's last-ditch attempt for client inside first test.
No point checking it twice in a row if it was false the first time.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:40:30 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:58 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:54 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:51 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:48 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:42 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:29 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:22 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:27:16 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:26:57 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:26:54 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:26:35 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:26:02 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:25:53 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:21:16 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:20:55 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:20:49 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:20:46 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:18:54 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:18:50 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:18:43 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:18:39 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:18:32 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:18:26 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 22 00:09:10 2016 +0100
Don't test boundary in output_content() for NULL; it never is.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:21:30 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:20:41 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:20:06 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:17:48 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:16:11 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:15:53 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:15:47 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 23:15:32 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 22:01:54 2016 +0100
Replace `if (p) free(p)' with `mh_xfree(p)'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 21:18:38 2016 +0100
Add FIXME raising if iscntrl(3) test should be based on isprint(3)
!iscntrl blocks characters that could be isspace or isblank whereas
isprint would let them through unharmed.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 21:18:16 2016 +0100
Assume POSIX ctype.h; don't vet toupper()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 21:14:24 2016 +0100
Explain isascii() test more in netsec_set_sasl_params().
It stops non-ASCII lower in the SASL mechanism being uppered, just in
case there is some.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 21:10:42 2016 +0100
Assume POSIX ctype.h; don't vet toupper()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 20:39:11 2016 +0100
Assume POSIX ctype.h; don't vet tolower()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 20:37:32 2016 +0100
Assume POSIX ctype.h; don't vet tolower()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 20:23:55 2016 +0100
Oops, stop showbuildenv reading from stdin when run from a TTY.
David spotted the problem I introduced with 8374c3c. Alter offset to
process any arguments, falling back to stdin if none.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 14:42:35 2016 +0100
Assume POSIX ctype.h; don't vet tolower()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 14:41:17 2016 +0100
Assume POSIX ctype.h; don't vet tolower()'s parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 14:35:47 2016 +0100
Assume POSIX ctype.h; don't vet tolower()'s parameter.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 21 13:26:43 2016 -0400
Fixed MIME parser so it can read binary content.
Second of two-part fix. Replaced use of strlen().
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 21 13:22:22 2016 -0400
Have m_getfld() pass back indication of missing blank line.
This is part one of a two part fix to the MIME parser to
read binary content. It should have no effect.
Also added start/finish test calls to test-header.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 09:53:45 2016 +0100
Fix warnings caused by recent edits; don't mix declarations and code.
Quite right too, I prefer all the declarations, codeless, up front. The
standard -Wall didn't pick this up. David pointed it out, probably due
to his defaults of `-pedantic -ansi'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 00:06:11 2016 +0100
Don't `else' after goto. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 00:06:07 2016 +0100
Don't `else' after goto. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 00:05:50 2016 +0100
Don't `else' after goto. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Fri Oct 21 00:05:46 2016 +0100
Don't `else' after goto. Simplify control flow.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 20 19:38:01 2016 -0400
Added test/mhshow/test-binary. The MIME parser doesn't
properly handle null bytes because it uses getline().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:57:56 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:57:09 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:30:39 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:30:07 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:30:02 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:29:56 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:29:49 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:29:46 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:29:35 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:29:19 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:27:42 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:27:37 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:27:21 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:27:08 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:27:05 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:23:46 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:23:41 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:23:38 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:23:35 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:23:28 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:23:00 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:22:21 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:22:15 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:22:11 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:22:04 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:22:00 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:21:45 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:21:34 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:21:05 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:20:25 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:20:20 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:20:17 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:20:07 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:19:59 2016 +0100
Don't `else' after return or goto. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:19:28 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:18:47 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:16:32 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:16:21 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 23:15:53 2016 +0100
Don't `else' after return. Simplify control flow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:43:52 2016 +0100
Hoist test of search string for NULL out of loop.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 20 13:37:29 2016 -0400
Rototill credentials code so that we only prompt for the username and
password when it is necessary.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 19 19:53:42 2016 -0400
Added locale profile component, value is passed to nmh_init().
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 19 15:00:56 2016 -0400
Pass CFLAGS to make distcheck via DISTCHECK_CONFIGURE_FLAGS.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:32:37 2016 +0100
Replace sizeof string constant - 1 with LEN().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:32:30 2016 +0100
Replace sizeof string constant - 1 with LEN().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:24:20 2016 +0100
Replace strlen(), malloc(), and sprintf() with concat().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:09:47 2016 +0100
Use LEN() on string constants instead of strlen().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:09:47 2016 +0100
Use LEN() on string constants instead of strlen().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:09:47 2016 +0100
Use LEN() on string constants instead of strlen().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:08:50 2016 +0100
Add LEN(s) definition.
LEN gives the strlen() of string constant s, excluding the
terminating NUL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Thu Oct 20 00:02:14 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:38:04 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:38:04 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:38:04 2016 +0100
Put, rather than print, single characters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:13 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:13 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:13 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:13 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:13 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 23:27:12 2016 +0100
Replace `(char *)0' et al with `NULL'.
None of them are vararg parameters.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 19:18:48 2016 +0100
Replace strlen(), malloc(), and sprintf() with concat().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:47:30 2016 +0100
Replace sprintf() with strcpy(); it's no worse.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:47:04 2016 +0100
Replace sprintf() with strcpy(); it's no worse.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:44:58 2016 +0100
Add comment describing concat().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:30:41 2016 +0100
Use the imperfect snprintf(3) instead of sprintf(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:29:56 2016 +0100
Use the imperfect snprintf(3) instead of sprintf(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:29:43 2016 +0100
Use the imperfect snprintf(3) instead of sprintf(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:29:18 2016 +0100
Use the imperfect snprintf(3) instead of sprintf(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 18:13:10 2016 +0100
Add EndsWithC(char *s, int c) and call it in some initial places.
EndsWithC returns true if non-NULL string s ends with a c before the
terminating NUL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 17:52:44 2016 +0100
Add stdbool.h plus fallback to h/nmh.h.
Change h/mh.h's FALSE and TRUE to use stdbool.h's. In time, everything
can switch over and FALSE and TRUE can go. Delete some local
re-definitions of FALSE and TRUE.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 16:34:05 2016 +0100
Fix ruserpass() to not assume `\n' present before trimming.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 19 12:09:37 2016 -0400
Removed remaining relics of generated ctypoe-checked.[hc].
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 15:43:12 2016 +0100
Alter ctype-checked to handle EOF and be hand-written.
Along the way, replace the code generation with code that punts the work
onto the stdlib's C functions, needing only a single `identity' array
for all the macros. A mkdir needed to be added in Makefile.am because
otherwise etc didn't exist in a distcheck and attempting to redirect
stdout to a file in etc failed. I'm not happy that's the best automake
way to achieve this, i.e. what if another rule attempts to create in etc
first?
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 14:39:53 2016 +0100
Remove ./configure's --enable-debug support; it did nothing.
David on nmh-workers said "that looks like a relic that can be removed".
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 13:04:12 2016 +0100
Don't recurse in advertise() on writev(2) error, just write(2).
Some errors, e.g. EPIPE, cause the advise()'s call to another
advertise() to fail again, ad segvinitum when stack busts. Instead,
snprintf(3) and write(2) that single string, ignoring any error.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 12:22:47 2016 +0100
Add check-programs target to Makefile.am to add to `make all'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 11:30:55 2016 +0100
Ignore etags ugly TAGS output file.
Makefile prefers etags over ctags.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 10:09:47 2016 +0100
Replace strchr() condition with TrimSuffixC(), fixing assumptions.
A couple of the existing strchr()-based trims assumed fgets() returned a
string containing `\n' if it didn't return NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 10:06:44 2016 +0100
Replace strchr() condition with TrimSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 10:06:24 2016 +0100
Replace strchr() condition with TrimSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 10:04:59 2016 +0100
Replace strchr() condition with TrimSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 10:04:12 2016 +0100
Replace strchr() condition with TrimSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 10:03:31 2016 +0100
Replace strchr() condition with TrimSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Wed Oct 19 00:50:28 2016 +0100
Replace strchr() condition with TrimSuffixC().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 17:05:24 2016 +0100
Add TrimSuffixC(char *s, int c).
TrimSuffixC deletes c from the end of non-NULL string s if it's present,
shortening s by 1. Only one instance of c is removed.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 18 19:55:49 2016 -0400
With EAI (mhbuild -headerencoding utf-8), force message header to
show 8-bit UTF-8, even if the message body is ASCII.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 18 16:45:30 2016 -0400
Output an error message from post(8) when user specifies
mhbuild -headerencoding utf-8 but the SMTP server doesn't
support SMTPUTF8.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 16:33:12 2016 +0100
Rewrite r1bindex() using strrchr(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 16:23:44 2016 +0100
Use concat() in m_putenv. Add FIXME about memory leaks.
POSIX defines setenv(3) and unsetenv(3). They seem like a good route,
just need to preserve the existing functions' behaviour.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 16:22:41 2016 +0100
Shrink the static char[] for "%d" from 8KiB to just right.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:26 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 14:52:25 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:15 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:15 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:37:14 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 13:09:27 2016 +0100
Replace getcpy() with mh_xstrdup() where the string isn't NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 01:27:27 2016 +0100
Fix unlikely bug in oauth's make_query_url() of base_url overflow.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 18 01:18:24 2016 +0100
Replace a few calculations of string lengths with concat().
Saves the reader have to keep checking all the +1 are correct.
Passed the oauth tests; they weren't skipped.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 23:52:00 2016 +0100
Close FILE pointer in anno for -append as well as -delete.
https://savannah.nongnu.org/bugs/?23465 has Peter Maydell pointing out
the assymetric open and close of a FILE pointer. He's right on that
AFAICS so change the test to be for a non-NULL pointer rather than the
more wordy and prone to error flag-testing.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 21:46:47 2016 +0100
Oops, should have offset file in showbuildenv rather than cat.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 21:16:38 2016 +0100
Look for a platform-specific /etc/*-release or similar.
/etc/os-release is becoming standard due to systemd.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 20:51:09 2016 +0100
Protect showbuildenv's headers from glob expansion.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 20:35:51 2016 +0100
A-ha! automake has support for tests expected to fail; use that.
Backing out my recent addition of an `expectedfail` parameter to the
`check' function.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 20:14:33 2016 +0100
Remove use of C's register keyword.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 17 09:42:32 2016 -0400
Added reference to mh-profile(5) man page for more information on
postproc. And note that "Nmh-" header lines are filtered out.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 11:55:12 2016 +0100
Add FIXME for more documentation to showbuildenv.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 11:51:32 2016 +0100
Have showbuildenv only indent non-blank lines.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 11:50:22 2016 +0100
Run lsb_release(1) if uname is Linux.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 11:30:24 2016 +0100
Oops, fc31cece had a syntax error that gcc ignored, clang doesn't.
Two logical-or operators in a row don't upset gcc. Who said parsing was
a solved problem?
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:41:32 2016 +0100
Replace NEW() then memset() of 0 with NEW0().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:36:35 2016 +0100
Don't call strlen() twice; save result.
The second instance was attempting to write strlen(mmdlm2) bytes
and checking the return value against strlen(mmdlm1). I assumed
that was an error without digging.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:35:15 2016 +0100
Don't call strlen() twice; save result.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:34:18 2016 +0100
Deference char pointer to test for empty string instead of strlen(3).
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:28:53 2016 +0100
Replace getcpy() with mh_xstrdup().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:28:13 2016 +0100
Replace mh_xmalloc() with mh_xstrdup().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 01:26:53 2016 +0100
Replace mh_xmalloc() with mh_xstrdup().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 00:32:46 2016 +0100
Delete client_getcpy(); don't know why it exists.
Replace with calls to getcpy() or mh_xstrdup().
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 00:22:23 2016 +0100
Use mh_xstrdup() instead of getcpy() for a string constant.
It cannot be NULL.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 00:08:26 2016 +0100
Rewrite getcpy() using mh_x*() allocation functions.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Mon Oct 17 00:07:24 2016 +0100
Add const specifier to mh_xstrdup()'s src parameter.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 23:35:35 2016 +0100
Rename fmt_compile.c's NEW macro to NEW_FP to avoid redefine.
It grabs and fills in a pointer called `fp' so a more specific name
seems OK.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 23:16:26 2016 +0100
Rename local enum to avoid clashing with NEW() macro.
Even if it doesn't in practice due to the lack of parenthesis, it makes
things more clean if all the enumerates have a common abbreviation
prefix.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 22:53:23 2016 +0100
Add mh_xstrdup() that exits on allocation failure.
Call it from a few simple places.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 19:38:36 2016 +0100
Add NEW(p) that sets p to mh_xmalloc'd memory sized by *p.
Use it for the simple cases. Again, saves having to check the same
identifier is given, possibly far apart after a superfluous cast.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 18:49:32 2016 +0100
Add macro NEW0(p) that callocs, and use it in simple calls.
p is a pointer, the size of the contents of the pointer is allocated
with calloc via mh_xcalloc. It saves having to check every calloc to
ensure the space requested matches the pointer to which it is assigned.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 18:24:51 2016 +0100
Put parameter names in h/utils.h memory function prototypes.
It can be a problem if there is a system creeps in a clashing macro,
e.g. `size', but that's unlikely and I think the documentation benefits.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 18:21:15 2016 +0100
Add mh_xfree(), guarding free(3) from NULLs.
Perhaps all nmh's platforms cope with free(3) these days, but it gives
symmetry with the other mh_x* memory functions and if there is code
testing the pointer before calling free then it can use this instead.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 18:17:31 2016 +0100
Tweak mh_xcalloc(); print size on error, follow POSIX.
Using `%zu' for the size_t value. That might be a problem on older
platforms, but we'll see. If asked for zero bytes then allocate one to
get a unique pointer.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 18:08:29 2016 +0100
Tweak mh_xrealloc(); print size on error, follow POSIX.
Using `%zu' for the size_t value. That might be a problem on older
platforms, but we'll see. If asked for zero bytes then free an existing
pointer, only passing it to free(3) if it's non-NULL, and then allocate
a byte so a unique pointer is returned.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 17:43:56 2016 +0100
Tweak mh_xmalloc(); print size in error, allocate zero bytes.
Using `%zu' for the size_t value. That might be a problem on older
platforms, but we'll see. If asked for zero bytes then allocate one
rather than exit; it's sometimes useful to allocate zero, but some
older platforms might not like it.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 17:36:03 2016 +0100
Don't check mh_xcalloc() and friends for a NULL return.
They never return NULL. That's their prime purpose.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 15:50:12 2016 +0100
Expand the test of scan's -forma; fails on first attempt.
For an email that's just `a:\nb:\nc:\n', a scan with `%{a}\n%{b}\n%{c}'
is one blank line short. If the `%{c}' has anything added then its line
prints. Break out of the loop so all the other tests are skipped.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 15:25:37 2016 +0100
Don't test -reverse's boolean on every message number.
Test just once before the loop and define start, end, and increment.
Keep going whilst start is not end. Happy for underflow or overflow in
calculating end because msgnum will make the same transition. It can't
affect whether the loop runs at all since 0 is not a valid message
number.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 14:28:38 2016 +0100
Update pending-release-notes with a couple of my recent fixes.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 14:19:56 2016 +0100
Fix bug where single-character headers were sometimes missed.
The hash function used to check if a header was of interest always used
its first three characters. For a single-character header that third
byte wasn't particularly set and so it was pot luck if the two hashes
matched, swayed by what was previously in the format string and in the
email's headers. Alter it to cope, including with an empty string.
Comment that it never gives 127 so leaves the last element of the
hash-table array unused. Alter test-header-parsing to stop declaring it
expects to fail.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 12:44:32 2016 +0100
Change all Getc() callers to use EOF, not comparisons with 0.
Makes the logic that bit easier when you don't have to convert to EOF
mentally. No functional change intended.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 12:23:57 2016 +0100
Don't increment bytes_read if returning EOF.
Don't know if this was actually causing a problem, or if it was wrong,
but bytes_read was always being incremented even if the later test
showed readpos was to be left unincremented and EOF returned instead.
All tests still pass so any breakage must be subtle!
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 12:13:59 2016 +0100
Fix spelling in comment. Alter case to match identifier.
vim will search matching case on `*', for example, so if searching for
`\<fdelim\>' the comment shouldn't use `Fdelim'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 11:43:45 2016 +0100
Add failing test case for single-character header parsing.
`scan -format '%{x}'' fails to find single-character header `x' in some
cases, depending on the position of the header in the file. Add a
simple test case, scan/test-header-parsing, for this that fails. Alter
the test harness to allow a test to indicate it expects to fail. When
it does, that's ignored. If it passes, that's then an error instead.
Did this because I don't know if or when it will be fixed and didn't
want it to be forgotten in the meantime. When it is fixed, the test can
be enhanced to cover many more possibilities. First noticed it with ad
hoc testing of my fewer-lseek change, but it is present in the released
1.6.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 10:52:39 2016 +0100
Fix spelling in warning message; s/conext/context/.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 10:13:46 2016 +0100
Simply enter_getfld()'s structure, no functional change.
Return ASAP to avoid having to mentally track those states as the code
indents further.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 09:58:34 2016 +0100
Explicitly state a postproc's last argument will be the draft.
Update the sample postproc script to make clear it's the -whom detection
that sucks.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 09:35:03 2016 +0100
Document fmttest(1)'s existing -help and -version options.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 09:17:51 2016 +0100
Move -help and -version to the front of the man page options.
The man pages had -verbose and -help listed at the end of the synopsis.
This put them after mandatory arguments in some cases, e.g. post(8).
Put then at the front, swapping the order so -help is first, as novices
will want to know -help exists early on, and others can simply skip over
them rather than encounter them at the end when they're trying to track
the combinations of what they've read so far.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 08:52:10 2016 +0100
Fix end of sentence spacing in man pages, and related problems.
troff(1) input that ends a sentence at the end of the line gets the
proper inter-sentence spacing when formatted. If the sentence ends
midline then two spaces must follow to get the same result, otherwise
the spacing looks odd. Similarly, if a full stop is not the end of a
sentence then it should have the zero-width escape appended so if
re-formatting the source happens to place it at the end of the line then
no large gap follows it: e.g. `e.g.\&'.
Replace `et. al.' with `et al'.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 08:34:35 2016 +0100
Reference the buildbot in docs/README.developers.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 16 08:23:51 2016 +0100
Stop one lseek(2) per header fetched by m_getfld.c in common case.
Only call ftello(3) in enter_getfld() when track_filepos has been
requested; not often.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sat Oct 15 23:40:00 2016 +0100
Fix error message when attempting to xmh_realloc() 0 bytes.
Though really, I'd expect it to perform a free(3) then, as the real
realloc(3) does.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 15 14:21:13 2016 -0400
Plugged memory leak in convert_content_charset().
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 15 11:53:24 2016 -0400
Fixed mhshow warn message when it can't convert character set,
"from" instead of "to", as reported by Ralph.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 15 11:33:34 2016 -0400
Changed "existant" to "existent". Found by misspell_fixer.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 15 09:58:24 2016 -0400
Added to convertargs documentation.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 14 16:53:27 2016 -0400
Try running script(1) for SHELL test in subshell.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 14 16:40:16 2016 -0400
Check that script(1) supports SHELL in test-version-check.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 14 14:36:21 2016 -0400
Added check to test-version-check to ensure that script(1) makes
the program look like it's connected to a terminal.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 14 13:40:14 2016 -0400
Didn't work on buildbot hosts. Added debug statements.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 14 13:27:32 2016 -0400
Instead of feeding stdin to script(1) in test-version-check,
create a simple shell script with the command to be run and feed
it to script via the SHELL environment variable or -S option.
Thanks to Ralph for suggesting this approach. We'll see if it
works on all of the buildbot hosts.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 14 09:54:59 2016 -0400
Tweaked formatting of welcome message.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 13 19:12:59 2016 -0400
Disable test-version-check, again, when not connected to terminal.
I can't otherwise explain why it fails on the ubuntu buildbot.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 13 18:54:16 2016 -0400
Added debug printouts to test-version-check.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 13 18:45:06 2016 -0400
Use "script file" in test-version-check for maximum portability.
Feed its stdin, which might be problematic.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 12 21:48:11 2016 -0400
Added check that replied-to text is not quoted-printable encoded.
It's up to the external converter to generate RFC 5322-legal text.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 12 21:47:16 2016 -0400
Split ${charset:+-I "$charset"} and another similar case into two
separate options, because Solaris didn't like the space between them.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Oct 11 10:20:52 2016 -0400
For the autoconf/automake stuff to replace getline, the following
patch seems to work.
The final change on configure.ac is to cope with cc -V output having
slightly changed in the most recent version of the compiler.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Tue Oct 11 10:14:14 2016 -0400
I've written a getline(3) from scratch based on
https://manned.org/getdelim.3p and am happy for it to have whatever
licence nmh needs.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 11 09:31:42 2016 -0400
Removed test-local-mailbox that was mistakenly committed.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 11 08:55:12 2016 -0400
Only set CFLAGS with gcc.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 11 08:53:32 2016 -0400
Moved gcc warning options from AM_CFLAGS back to CFLAGS, to
make it easier for packagers to override. This is a partial
rollback of commit f7eb978bd395752d3d9037ea4436b8e2db41f135.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 11 08:41:10 2016 -0400
Added LANG to procmail example in mhfixmsg man page.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 10 16:43:56 2016 -0400
Corrected date in forw man page.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 10 16:42:57 2016 -0400
Tweaked OAuth documentation in mhlogin and send man pages.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 10 16:42:20 2016 -0400
Removed reference to nmh User's Manual because there is no such
thing. There was an MH User's Manual, but that is not distributed
with nmh.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 10 09:54:51 2016 -0400
Changed test suite's require_locale() to set the locale that it
finds, and added upper case versions of locale names to each test.
This should allow the tests to succeed on old Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 9 13:59:11 2016 -0400
Added -sasl to -saslmech xoauth examples in man pages.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 7 22:21:02 2016 -0400
Replace `id -u` with $$ so that tests have a chance of working
on old Solaris hosts.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 7 11:07:03 2016 -0400
Added comments about sidestepping check for checks to determine
whether replied-to text needs to be encoded in mhbuildsbr.c.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 7 09:40:23 2016 -0400
Added example of decoding RFC-2047 filename to mhstore man page.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 18:01:50 2016 -0400
A better fix than e87f37c27828723317a71291e31b34f39ec09098, because
c_reqencoding should be set for text content in replies if we don't
want it to be encoded. Scan the text content to see if it is 7- or
8-bit, and set c_reqencoding accordingly.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 17:53:00 2016 -0400
Moved scan_input() from uip/post.c to sbr/utils.c.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 13:10:19 2016 -0400
Updated test-version-check test_skip message.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 13:07:20 2016 -0400
Fixed test negations in test-version-check to work with make distcheck.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 12:57:45 2016 -0400
OK, don't run test-version-check if not connected to terminal.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 12:47:52 2016 -0400
More debugging test-version-check.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 12:45:52 2016 -0400
Replaced strtod() with strtof().
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 12:16:53 2016 -0400
More debugging.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 11:59:24 2016 -0400
More test-version-check debugging, on Linux buildbot hosts.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 11:47:26 2016 -0400
1) Use script(1) -t 0 instead of -f on FreeBSD.
2) Added another debug printout.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 11:30:19 2016 -0400
Accommodate FreeBSD script(1), and add debugging statement to diagnose
failure on ubuntu buildbot host.
Merge: 641e461b 84eab768
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 09:39:27 2016 -0400
Merge branch 'welcome'
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 6 09:11:45 2016 -0400
Enable SMTP 8BITMIME for messages with 8-bit content:
1) In post, look for a Content-Transfer-Encoding header. It has to
be the header for the message, not any MIME parts. If found,
post trusts that it's correct. If there isn't one, post scans
the entire message body for any 8-bit bytes.
2) If the message body is 8-bit:
If the server supports 8BITMIME, enable it.
If the server doesn't support 8BITMIME, fail with a message to
user that they need to encode the message for 7-bit transport.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 5 16:04:11 2016 -0400
Call c_ceclosefnx in mhfixmsg set_ce(). It doesn't seem to help
reduce file descriptor leaks, but can't hurt.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 5 16:02:47 2016 -0400
Don't set c_reqencoding in repl, let mhbuild set it based on
the content.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 4 22:00:12 2016 -0400
Improve these comments a bit.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 4 21:24:10 2016 -0400
Enabled check for 8-bit content in all text parts, not just those
with no specified character set, so that a Content-Transfer-Encoding
header will be added if needed.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 4 19:08:42 2016 -0400
Have mhfixmsg add a C-T-E at the message level, based on the least
restrictive C-T-E of its parts.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 3 21:30:14 2016 -0400
Base Content-Transfer-Encoding on decoded and new text parts on
content rather than the user's charset.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 3 17:59:51 2016 -0400
Fixed typo.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 3 17:50:35 2016 -0400
Fix C-T-E of message, as well as multipart, types to be 7bit, 8bit,
or binary.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 2 09:53:56 2016 -0400
Added test of SMTP server that doesn't support SMTPUTF8.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Oct 2 02:05:44 2016 -0400
Fix some typos in the comments.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Oct 2 01:47:15 2016 -0400
Move the read buffer shuffling to BEFORE where we call the network
read routines; otherwise we can end up calling the lower layers with
a length of zero, which messes everything up.
Also make sure we reshuffle our pointers around if that happens.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 1 14:37:27 2016 -0400
mhfixmsg now replaces RFC 2047 encoding with RFC 2231 encoding of
name and filename parameters in Content-Type and Content-Disposition
headers, respectively.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 1 12:49:12 2016 -0400
Cleaned up a bit, mostly in comments for each function.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Oct 1 01:02:34 2016 -0400
Sigh, the return value from SSL_get_error() isn't suitable to give
to ERR_get_error(), so use a different function to get the error.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 30 21:24:43 2016 -0400
Print even more errors.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 30 15:15:08 2016 -0400
Add -initialtls/-notls flags to msgchk.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 30 15:07:03 2016 -0400
Make sure we retry if possible upon a TLS read, and give a more meaningful
error if we can't.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 30 10:35:06 2016 -0400
Added --sysconfdir to nmh.cygport.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 30 09:18:27 2016 -0400
Replaced some hard-coded strings with variables in nmh.cygport.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Fri Sep 30 00:55:55 2016 -0700
Fix typos and drop declaractions of 2 undefined functions.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 29 15:18:02 2016 -0400
Updated comments in h/prototypes.h.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 29 15:13:05 2016 -0400
Welcome message enhancements:
1) Disable if Welcome: disable component is in profile.
2) If MHCONTEXT is set, only print the message if the context file
already has a Version: reference where the version is old.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 29 11:40:10 2016 -0400
Instead of relying on invo_name to decide whether to call
nmh_version_changed(), use a read_context setting of 1.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 29 09:58:27 2016 -0400
Make sure stderr is directed to terminal, as well as stdin and
stdout, when deciding whether to check for nmh version update.
Author: David Levine <levinedl@acm.org>
Date: Wed Sep 28 18:48:16 2016 -0400
Wait for user to ack new version message.
Author: David Levine <levinedl@acm.org>
Date: Wed Sep 28 15:01:43 2016 -0400
Added welcome message when nmh detects that its version changed.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Sep 28 09:58:54 2016 +0200
back out use of RFC 2047 decoding on the filename
The RFCs clearly state that an encoded word should not be used in
the MIME parameters and the scheme from RFC2231 should be used
instead. nmh supports that. Unfortunately, other mail clients,
in particular gmail and IBM/Lotus Notes, produce messages with
the invalid encoding.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 27 08:29:05 2016 -0400
Added start_test/finish_test.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 27 08:28:47 2016 -0400
Updated start_test() and finish_test() to not update the test name
if there was a test failure. run_test disables exit on non-zero
status, but does increment failed.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Sep 27 01:42:55 2016 +0200
Do RFC 2047 decoding on filename for mhstore
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 26 16:50:38 2016 -0400
Replaced use of GNU sed extension.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 26 15:41:22 2016 -0400
Added debug statements to test-mhparam.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 26 14:33:55 2016 -0400
Fixed typo in -help message.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 26 12:07:50 2016 -0400
Reworked BUGS section of nmh(7) man page, and added excerpt
to end of each -help message and to end of install-mh output.
Merge: aaf014c7 60048afd
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 26 08:58:55 2016 -0400
Merge remote-tracking branch 'origin' into smtputf8
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 25 12:58:05 2016 -0400
Added MH(7) man page, as an alias of nmh(7).
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 25 12:18:42 2016 -0400
Added mention of replaliases to mh-mime(7) man page.
Merge: 2c00d448 38e17e1b
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 25 09:28:05 2016 -0400
Merge remote-tracking branch 'origin' into smtputf8
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 17:08:01 2016 -0400
Replace profile-based hack to allow getname() to handle 8-bit
addresses with a global data-based hack. At least the global
data is hidden in addrsbr.c.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 17:01:32 2016 -0400
Removed send and post -eai switches. Instead, post now enables
SMTPUTF8 if it finds any 8-bit characters in header field bodies.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 12:21:40 2016 -0400
Disabled incompatible locale check because the output varies too
much between platforms.
(cherry picked from commit 38e17e1b8ba306ed6137b174f2f196d09d02816f)
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 12:21:40 2016 -0400
Disabled incompatible locale check because the output varies too
much between platforms.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 12:10:28 2016 -0400
Wrapped some variables and arguments to prevent compile warnings
when configured without SASL and OAUTH support.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 10:42:58 2016 -0400
Added incompatible locale test to test/mhl/test-rfc6532. It's
a placeholder to show that 8-bit header field values aren't
properly handled if the locale is incompatible.
(cherry picked from commit 2cfa2ea56602d3bb0465a46c0b144017b497b558)
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 10:42:58 2016 -0400
Added incompatible locale test to test/mhl/test-rfc6532. It's
a placeholder to show that 8-bit header field values aren't
properly handled if the locale is incompatible.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 24 09:44:39 2016 -0400
Added descriptive/usage information to top of replaliases.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Sep 24 02:01:05 2016 -0400
Change from an autoconf test for SSL_library_init to SSL_new,
for compatibility with OpenSSL 1.1.0.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 23:12:58 2016 -0400
Improve and update comments a bit, and also improve the error messages
when we don't have Cyrus-SASL support compiled in.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 23 22:13:04 2016 -0400
Specify that mhbuild -autoheaderencoding picks either base64 or q-p,
but not utf-8.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 22:04:44 2016 -0400
Add our sample localpostprox, and also pick up replaliases while we're
at it.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 23 21:54:26 2016 -0400
Renamed mhbuild -headerencoding 8bit to utf-8.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 19:52:09 2016 -0400
Make it so we always return the chosen mechanism, even if we aren't
using the Cyrus SASL library; this makes XOAUTH2 work without
Cyrus-SASL.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 19:51:36 2016 -0400
Missed removing SASLminc() from authservice switch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 19:30:21 2016 -0400
Switch to AM_DISTCHECK_CONFIGURE_FLAGS.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 15:08:25 2016 -0400
Make the SASL flags work even without support for Cyrus-SASL.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 15:07:51 2016 -0400
Move things around so you can still initialize netsec with SASL
parameters even if you don't have Cyrus-SASL enabled.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 14:48:50 2016 -0400
Move some of the SASL variables outside of the ifdef, so OAUTH
can make use of them. Also, clean up some warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 14:22:29 2016 -0400
Update documentation a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 14:21:23 2016 -0400
Whoops, a typo from the last merge; when the one variable got
reformatted continuation escapes weren't included.
Merge: f3cd885b 2ebd1268
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 14:14:26 2016 -0400
Merge branch 'pop-tls'
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 14:13:23 2016 -0400
Don't output snoop information when doing RETR or TOP.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 14:00:59 2016 -0400
Switch decodeBase64() second argument to an unsigned char **.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 23 13:59:52 2016 -0400
Don't always output a decoded SASL token; if it's a large binary blob, just
stick with the base64 output.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 23 11:55:20 2016 -0400
Added SMTPUTF8 (RFC 6531) support:
1) Allow 8-bit characters in addresses.
2) Disable RFC 2047 encoding of (all) header field bodies, via
mhbuild -headerencoding 8bit.
3) Have post enable it in the SMTP transaction.
4) If enabled, add the commands to the SMTP transaction
(MAIL FROM: <address> BODY=8BITMIME SMTPUTF8).
Some things may changed, such as the 8bit encoding algorithm name.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 23 08:21:57 2016 -0400
Rearranged statements to avoid compile warning about mixed
declarations and code.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 23 08:20:27 2016 -0400
Fixed typo (NOTLSSW).
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 23:27:36 2016 -0400
Garbage collect the saslmaxssf flag, and update documentation for
new -initialtls flag and -notls flags for inc.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 23:10:59 2016 -0400
Forgot to reset the snoop callback one time.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 21:26:39 2016 -0400
Fix some typos and warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 20:01:34 2016 -0400
Switched to "server" instead of "client" for SASL remote hostname.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:31:57 2016 -0400
Garbage collect unused code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:24:50 2016 -0400
Whoops, turns out I originally ran this test with XOAUTH set. Fix the
output and make sure the common script unsets XOAUTH so this doesn't
happen again.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:12:36 2016 -0400
Change the tests to make them work with the new program output
and slight change in the interface.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:12:12 2016 -0400
Add error reporting for one case, and move around the return code
in the SASL callback a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:11:32 2016 -0400
Add the SASL callback; things work now!
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:10:23 2016 -0400
Disable the original call to BIO_flush() now that we're doing our
own buffering.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 19:05:39 2016 -0400
I had forgotten that nesec_set_tls() has to be called AFTER the
descriptors are set.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 22 14:08:10 2016 -0400
Fixed test-mhfixmsg by using octal instead of hex bytes with
printf(1).
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 22 13:54:50 2016 -0400
Removed temporary debuggin printout.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 22 13:39:55 2016 -0400
Added start_test/finish_test.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 22 13:39:42 2016 -0400
Added temporary diagnostic printout.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 22 13:07:32 2016 -0400
Allow -decodetext binary, though 8bit is still the default because
binary can produce messages that are not RFC 2045 compliant.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 22 08:24:49 2016 -0400
Specify full path to mhl in test because it might not be on PATH.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 00:05:13 2016 -0400
Alright, things compile now, but don't link yet; need to write the
SMTP sasl callback.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 22 00:04:43 2016 -0400
Okay, fixed a few more things. Almost there?
Merge: 64a5aa13 cff807ba
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Sep 21 23:33:29 2016 -0400
Merge branch 'pop-tls' of git.sv.gnu.org:/srv/git/nmh into pop-tls
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Sep 21 23:32:11 2016 -0400
Change things so we can take two file descriptors, one for input
and one for output.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Sep 21 16:51:21 2016 -0400
Okay! Squashed a few bugs, now have POP OAuth tests working.
Author: David Levine <levinedl@acm.org>
Date: Wed Sep 21 13:49:21 2016 -0400
Fixed test-rfc6532: MIME-Version isn't ignored by mhl.headers.
Maybe it should be?
Author: David Levine <levinedl@acm.org>
Date: Wed Sep 21 11:54:49 2016 -0400
Added test/mhl/test-rfc6532.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Sep 21 00:06:52 2016 -0400
Add support for a base64-decoding snoop callback.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Sep 20 23:30:51 2016 -0400
Garbage-collect all of this unused code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Sep 20 22:11:25 2016 -0400
We have OAauth working! But the tests don't work yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Sep 20 20:09:37 2016 -0400
Shuffle some stuff around, change some prototypes, and modify the
oauth code a bit to fit our new structure.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 20 12:23:04 2016 -0400
Plugged memory leak in openBase64().
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 19 23:29:39 2016 -0400
Maybe ... it works? Sort of! Needs more testing, and for me to finish
OAuth support.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 19 19:59:40 2016 -0400
More work, but not there just yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 18 22:03:18 2016 -0400
Okay, we're finally getting to implementation stage! Hopefully we'll be
able to make it all work with POP first, then SMTP.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 18 12:22:10 2016 -0400
Moved LDFLAGS to AM_LDFLAGS.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 18 10:29:17 2016 -0400
Moved CFLAGS additions to AM_CFLAGS.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 18 09:57:06 2016 -0400
Moved restore of CFLAGS outside of AC_CHECK_HEADER, so that it's done
unconditionally.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 18 01:15:20 2016 -0400
I think I've written all of these functions; now we just need to
have everyone else use them.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 17 17:11:23 2016 -0400
Added AM_CPPFLAGS to CFLAGS that are used for curl checks, because
they're needed on Cygwin. (Without _GNU_SOURCE, sys/types.h doesn't
include sys/select.h.) Also added AM_CFLAGS, which we don't currently
use but might in the future.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 17 10:15:11 2016 -0400
Updated Makefile.am to correspond to file replacement in commit
4a007bacfa67e69923b15500e2b2c3a6bcde541a.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 17 10:08:22 2016 -0400
Updated cygport script in preparation for nmh 1.7 release.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 17 10:06:56 2016 -0400
Replaced cygwin build script with cygport script.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 17 10:05:35 2016 -0400
Added libcurl to Cygwin package requirements, if configured
with --with-oauth.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 16 17:47:31 2016 -0400
Added oauth to mhparam examples.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 16 15:59:27 2016 -0400
Still closer, but not quite there yet.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 16 12:08:55 2016 -0400
Moved LFLAGS additions to AM_LFLAGS.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 16 11:56:42 2016 -0400
Use CPPFLAGS instead of AM_CPPFLAGS for FreeBSD additions.
Otherwise, it will miss -liconv. I think.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 16 11:15:45 2016 -0400
Cleaned up cppflags.m4 a bit and fixed its mode.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 16 08:28:18 2016 -0400
Moved CPPFLAGS additions to AM_CPPFLAGS.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 15 22:36:17 2016 -0400
Okay, a bit closer.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 15 20:00:02 2016 -0400
Added 2 second timeout to curl command in post() in oauth.c, for
localhost requests only, because the default timeout on Cygwin is 5
minutes.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 15 18:58:14 2016 -0400
Added NMH_ADDL_CPPFLAGS macro in new m4/cppflags.m4, to remove
explicit OS dependencies when deciding whether -DGNU_SOURCE is
needed. (Cygwin now needs it.)
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 15 16:00:07 2016 -0400
Fleshed out some more, but we're not there just yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Sep 14 00:00:48 2016 -0400
A bit more code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Sep 13 16:00:46 2016 -0400
Save this for now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 12 21:37:06 2016 -0400
More functions documented.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 12 19:07:29 2016 -0400
Beginnings of a new library API.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 11 11:49:44 2016 -0400
Exposed a bunch of switches that are now documented.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 11 11:30:42 2016 -0400
Added Examples section to mhlogin man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 11 00:41:18 2016 -0400
Add a "file-nopermcheck" credential entry.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 11 00:05:25 2016 -0400
Change this so the MTS_SMTP is the default, to match the value
of mts_method and the original code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 11 00:01:28 2016 -0400
Remove the unused argument from mts_init() (as far as I can tell,
it has never been used, for anything).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 9 15:49:26 2016 -0400
Closer, but not there yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 8 15:40:04 2016 -0400
Started ... not quite working yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Sep 8 13:13:57 2016 -0400
Only get a write lock on the sequences file if we're performing a pack
operation.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 6 18:02:46 2016 -0400
Added some NMH_UNUSED's to prevent compile warnings without
OAUTH_SUPPORT.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 6 17:49:59 2016 -0400
Protected call of mh_oauth_do_xoauth() with #ifdef OAUTH_SUPPORT to
allow post(1) to link when configured without it.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 6 17:36:16 2016 -0400
Protected use of setup_oauth_params() with #ifdef OAUTH_SUPPORT.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Sep 6 15:32:28 2016 -0400
Under some circumstances, some version of MacOS X can return EPROTOTYPE
if you try to write to a connection that is being torn down. Handle
that case.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 6 09:16:15 2016 -0400
Removed incorrect increment of read position pointer, which caused
first character of some very short (less than 4 characters) message
bodies to be dropped. It seems that the message needed to start
with a "From " line to reveal the problem.
Merge: 5776f9b7 da91c152
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 5 20:32:03 2016 -0400
Merge branch 'xoauth'
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 5 20:21:55 2016 -0400
Change things so if -authservice wasn't given, throw an error.
At the same time, improve the code so -authservice doesn't
have to be given before the other oauth flags.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 4 22:20:40 2016 -0400
Switch from our horrible awk script that parses the signal header file
to the POSIX function strsignal().
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Sep 4 20:42:21 2016 -0400
Fix up a few minor nits to make OAuth2 (finally!) work right in post(8).
Change the tests to support the new error output.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Sep 3 23:46:45 2016 -0400
Add new signal include file location for El Capitan. I am not sure
this is in general the right approach.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 29 09:26:38 2016 -0400
Added warning message on stderr if folder -nocreate is provided
a non-existant folder.
(cherry picked from commit d51964a51fdc08d92dab9825a8357c9adba34aa7)
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 29 09:26:38 2016 -0400
Added warning message on stderr if folder -nocreate is provided
a non-existant folder.
Author: David Levine <david.levine@gonift.com>
Date: Sun Aug 21 13:04:59 2016 -0400
Removed jsmn license from COPYRIGHT. In keeping what appears to
be standard practice, the COPYRIGHT file just contains the nmh
copyright. We retain the jsmn license in thirdparty/jsmn/LICENSE.
Author: David Levine <david.levine@gonift.com>
Date: Sun Aug 21 12:22:42 2016 -0400
Check result of setup_oauth_params() for != OK instead of non-zero.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Aug 21 00:39:36 2016 -0400
Very close, but it doesn't passes the tests just yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Aug 20 01:18:13 2016 -0400
Retrieve appropriate profile entries and pass them to post(8).
Not quite working yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Aug 16 23:35:09 2016 -0400
Start of adding arguments for transmitting OAuth parameters to
post.
(cherry picked from commit 68246559a5087f3a3c13ef2a6240a7c18dd9c155)
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Aug 16 23:35:09 2016 -0400
Start of adding arguments for transmitting OAuth parameters to
post.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Aug 15 14:39:04 2016 -0400
Add $(ICONVLIB) to programs that need it.
(cherry picked from commit 8c9441dc98bb4ce98ae70528d5415d9f5507713e)
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Aug 15 14:39:04 2016 -0400
Add $(ICONVLIB) to programs that need it.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 15 10:58:33 2016 -0400
Create $MH_OBJ_DIR/test/testdir if it doesn't already exist. This
allows a test to be run standalone, now that said directory must
exist before defining $MH_TEST_DIR.
(cherry picked from commit 0f53d91688c0fab28b900ad27a1610a755dea526)
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 15 10:58:33 2016 -0400
Create $MH_OBJ_DIR/test/testdir if it doesn't already exist. This
allows a test to be run standalone, now that said directory must
exist before defining $MH_TEST_DIR.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 15 10:31:43 2016 -0400
Plug a couple of (harmless) memory leaks in mhfixmsg.
(cherry picked from commit 58d22c00deb7bc9c771c5293079f6f89bc28274a)
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 15 10:31:43 2016 -0400
Plug a couple of (harmless) memory leaks in mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 14 20:45:43 2016 -0400
Handle base64 decoding decoding of initial response for all AUTH
mechanisms the same way, based on RFC 4954 spec. Also, don't try
to decode = or * response.
(cherry picked from commit b3ebdfc56e7a0199a60d80f54872e86969d96933)
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 14 20:45:43 2016 -0400
Handle base64 decoding decoding of initial response for all AUTH
mechanisms the same way, based on RFC 4954 spec. Also, don't try
to decode = or * response.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Aug 14 13:26:59 2016 -0400
Newer versions of Automake want to include the test-driver script,
so make sure we ignore it.
(cherry picked from commit bd6f799b1d98c11b50a4121c9ac763bcf1b1b3fe)
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Aug 14 13:25:51 2016 -0400
Use isascii() with isprint(), since using isprint() on
bytes > 127 is undefined.
(cherry picked from commit 7054379384884f0975c687ce9b2cd8c20e3f2c12)
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Aug 14 13:26:59 2016 -0400
Newer versions of Automake want to include the test-driver script,
so make sure we ignore it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Aug 14 13:25:51 2016 -0400
Use isascii() with isprint(), since using isprint() on
bytes > 127 is undefined.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 14 13:11:50 2016 -0400
Set HOME in tests if unset, to avoid warning from w3m about not being
about to create config directory.
(cherry picked from commit 30a9c9b62fa92df289079080eb5ee57d2fda3951)
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 14 13:11:50 2016 -0400
Set HOME in tests if unset, to avoid warning from w3m about not being
about to create config directory.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 14 11:04:07 2016 -0400
Fixed typo in man page.
Author: David Levine <david.levine@gonift.com>
Date: Sun Aug 14 11:02:50 2016 -0400
Fixed a couple of typos in man pages.
Author: David Levine <david.levine@gonift.com>
Date: Sun Aug 14 10:59:13 2016 -0400
Attempt to decode base64-encoded strings in -snoop traffic.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 14 10:57:51 2016 -0400
Attempt to decode base64-encoded strings in -snoop traffic.
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:58:45 2016 -0400
Canonicalize MH_TEST_DIR in TESTS_ENVIRONMENT.
(cherry picked from commit 28c31eb83bf6113dd72182bb5f13c4da99372d9e)
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:47:36 2016 -0400
Use pwd -P to canonicalize MH_TEST_DIR.
(cherry picked from commit 6f94c7d978b034d34319236e8a868a5b225605c0)
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:41:01 2016 -0400
Added debug printouts.
(cherry picked from commit 5d8bc1288d5bd672bfb81b347e4c7742fbe644d1)
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:19:00 2016 -0400
Canonicalized MH_TEST_DIR, and replaced use of `pwd` with it, to
try to prevent test failures on fbsd10 test host.
(cherry picked from commit 1846c42228ff68f328cb046027bc7a03ec3ba596)
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:58:45 2016 -0400
Canonicalize MH_TEST_DIR in TESTS_ENVIRONMENT.
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:47:36 2016 -0400
Use pwd -P to canonicalize MH_TEST_DIR.
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:41:01 2016 -0400
Added debug printouts.
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 10 11:19:00 2016 -0400
Canonicalized MH_TEST_DIR, and replaced use of `pwd` with it, to
try to prevent test failures on fbsd10 test host.
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 22 10:08:24 2016 -0400
Fixed comments describing decodeBase64().
(cherry picked from commit 06b87ce464beb93a7929541c355edf580ccec023)
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 22 10:08:24 2016 -0400
Fixed comments describing decodeBase64().
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 20 21:25:01 2016 -0400
Factored out base64 decoding code into decodeBase64().
(cherry picked from commit 522c66eae1a144e0631dfaa61f1632e341ea7ce6)
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 20 21:14:25 2016 -0400
Moved md5.c from uip to sbr.
(cherry picked from commit 98c792e2effa2656e4fce979d6f6eec44d64131c)
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 20 21:25:01 2016 -0400
Factored out base64 decoding code into decodeBase64().
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 20 21:14:25 2016 -0400
Moved md5.c from uip to sbr.
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 8 11:01:07 2016 -0400
Updated send(1) man page to note that sendfrom looks in
Envelope-From and Sender headers as well as the From header.
(cherry picked from commit b347135ed8e4c15c6562d7b3d7924bd9ef7f1589)
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 8 11:01:07 2016 -0400
Updated send(1) man page to note that sendfrom looks in
Envelope-From and Sender headers as well as the From header.
Merge: ae54f991 75ac4006
Author: David Levine <david.levine@gonift.com>
Date: Fri Jul 8 10:48:59 2016 -0400
Merge remote-tracking branch 'origin' into xoauth
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 8 10:35:52 2016 -0400
Added Envelope-From and Sender support to sendfrom.
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 8 10:28:20 2016 -0400
Changed addresses to use example.com.
Author: David Levine <levinedl@acm.org>
Date: Fri Jul 8 09:59:58 2016 -0400
export MH_TEST_DIR so that test/dist/test-dist can be run standalone.
Author: David Levine <david.levine@gonift.com>
Date: Tue Jul 5 12:10:05 2016 -0400
Moved sendfrom code from contrib into send(1).
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 5 12:02:59 2016 -0400
Moved sendfrom code from contrib into send(1).
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 5 09:57:07 2016 -0400
Added context_find_prefix().
Author: David Levine <david.levine@gonift.com>
Date: Mon Jul 4 18:25:53 2016 -0400
Added context_find_prefix().
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 25 21:22:37 2016 -0400
Wrapped code block of conditional statement with {}, so that the
second statement is now included in the conditional. Found by
gcc 6 -Wmisleading-indentation.
(cherry picked from commit 9626eb33ed5ff7c59776081e1a58a20a1eed96be)
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 25 21:19:37 2016 -0400
Moved free(cp) to right after last (and only) use of cp. The statement
was flagged by gcc 6 -Wmisleading-indentation. In its original location,
it would not always have been called, resulting in leaked memory.
(cherry picked from commit 79f012b76eba04d50a36a4a37c57458a8d521434)
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 25 21:17:05 2016 -0400
Fixed indentation to prevent warning from gcc 6 -Wmisleading-indentation.
(cherry picked from commit a814c930041c1e238f1826b1ac9c46b67e4cfb70)
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 25 21:22:37 2016 -0400
Wrapped code block of conditional statement with {}, so that the
second statement is now included in the conditional. Found by
gcc 6 -Wmisleading-indentation.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 25 21:19:37 2016 -0400
Moved free(cp) to right after last (and only) use of cp. The statement
was flagged by gcc 6 -Wmisleading-indentation. In its original location,
it would not always have been called, resulting in leaked memory.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 25 21:17:05 2016 -0400
Fixed indentation to prevent warning from gcc 6 -Wmisleading-indentation.
Merge: c546ef90 235b62a4
Author: David Levine <david.levine@gonift.com>
Date: Sat Jun 25 21:16:36 2016 -0400
Merge remote-tracking branch 'origin' into xoauth
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:38:19 2016 -0400
Added const to filename args of cpydata(). Then added const to some
args in mhfixmsg.c.
(cherry picked from commit 9f7d48c36f01ba29974834cbcdc24e4c2e1f07d9)
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:36:43 2016 -0400
Added const to arg of m_backup().
(cherry picked from commit d42ab414c8bce17b6b437ef9ebfd194a8ac4111c)
Author: David Levine <david.levine@gonift.com>
Date: Sun Jun 12 11:34:59 2016 -0400
Synched common.sh.in from master to nmh-oauth.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 11:33:27 2016 -0400
No longer need const cast in sendfrom.c.
Author: David Levine <david.levine@gonift.com>
Date: Sun Jun 12 11:27:21 2016 -0400
Added consts to adios(), advise(), and advertise() to sync master
and nmh-oauth branch.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 11:26:37 2016 -0400
Added consts to adios(), advise(), and advertise() to sync master
and nmh-oauth branch.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:38:19 2016 -0400
Added const to filename args of cpydata(). Then added const to some
args in mhfixmsg.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:36:43 2016 -0400
Added const to arg of m_backup().
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:35:47 2016 -0400
Added const to first arg of adios().
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:05:16 2016 -0400
If parse_mime() fails and the -file switch was used, pass the input
message to it unchanged so that pipelines won't break.
(cherry picked from commit 564b5b785c7cc709f92a83afb547267ed7418f18)
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 12 10:05:16 2016 -0400
If parse_mime() fails and the -file switch was used, pass the input
message to it unchanged so that pipelines won't break.
Author: David Levine <david.levine@gonift.com>
Date: Mon May 30 11:49:20 2016 -0400
Plugged leak in mh_oauth_cred_load().
Author: David Levine <david.levine@gonift.com>
Date: Mon May 30 11:48:46 2016 -0400
Added free_fs() call to plug leak from fmt_compile().
Author: David Levine <levinedl@acm.org>
Date: Mon May 30 11:48:28 2016 -0400
Added free_fs() call to plug leak from fmt_compile().
Author: klemens <ka7@github.com>
Date: Sun May 29 14:39:05 2016 +0200
spelling-fixes ( code-comments in .c, .h. .y ... )
(cherry picked from commit 942561da2455ee50a1eb82c8c4f2bdb5e25133d1)
Author: klemens <ka7@github.com>
Date: Sun May 29 14:37:11 2016 +0200
spelling-fixes ( docs, man, readme )
(cherry picked from commit fa92642a21119eda8bfc961f8d5a8d3e9ee7d494)
Author: klemens <ka7@github.com>
Date: Sun May 29 14:39:05 2016 +0200
spelling-fixes ( code-comments in .c, .h. .y ... )
Author: klemens <ka7@github.com>
Date: Sun May 29 14:37:11 2016 +0200
spelling-fixes ( docs, man, readme )
Author: David Levine <david.levine@gonift.com>
Date: Sun May 29 09:40:12 2016 -0400
Added sendfrom to docs/contrib.
Author: David Levine <levinedl@acm.org>
Date: Sun May 29 09:39:36 2016 -0400
Added sendfrom to docs/contrib.
Author: David Levine <levinedl@acm.org>
Date: Sat May 21 09:15:56 2016 -0400
Added docdir to mhparam.
(cherry picked from commit 89d69fbd2ae1f9c8c989850ec7057814c655a727)
Author: David Levine <levinedl@acm.org>
Date: Sat May 21 08:06:36 2016 -0400
Removed unnecessary memset on fmt_mnull: it gets initialized to
all 0's.
(cherry picked from commit 56c4ac49d7b8ad674c0a66e9999186bcb98bd048)
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 18 12:44:21 2016 -0400
Check to see if cross-directory links are supported; if they are not,
then don't run the refile -link test.
(cherry picked from commit 35fce21b692a6259138fc81caf13f4d07bb58da0)
Author: David Levine <levinedl@acm.org>
Date: Sat May 21 09:15:56 2016 -0400
Added docdir to mhparam.
Author: David Levine <levinedl@acm.org>
Date: Sat May 21 08:06:36 2016 -0400
Removed unnecessary memset on fmt_mnull: it gets initialized to
all 0's.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed May 18 12:44:21 2016 -0400
Check to see if cross-directory links are supported; if they are not,
then don't run the refile -link test.
Author: David Levine <levinedl@acm.org>
Date: Mon May 2 12:55:31 2016 -0400
For slocal, changed default user, if -user switch isn't used, to be
the user part of the Local-Mailbox profile entry, if present, or the
current user. addr uses the same default. This allows addr
to contain a '.', which slocal did not allow before.
Author: David Levine <david.levine@gonift.com>
Date: Mon Apr 25 22:20:39 2016 -0400
Added test of negative return code from jsmn_parse() to test-send.
Author: David Levine <david.levine@gonift.com>
Date: Mon Apr 25 22:19:37 2016 -0400
Added test of empty authorization code to test-mhlogin.
Author: David Levine <david.levine@gonift.com>
Date: Mon Apr 25 21:58:10 2016 -0400
Added explicit OATH_SUPPORT=1 to configure.ac when oauth support is
enabled, otherwise it didn't get set to 1.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Mon Apr 25 03:33:15 2016 +0000
Fix tests with oauth disabled.
Author: David Levine <david.levine@gonift.com>
Date: Sun Apr 24 22:09:39 2016 -0400
Check for empty code.
Author: David Levine <david.levine@gonift.com>
Date: Sun Apr 24 21:42:20 2016 -0400
Return false from parse_json() if jmsn_parse() returns a negative
(or zero, as it did before) value.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Mon Apr 25 01:23:04 2016 +0000
Improve oauth autoconf support.
- By default, enable OAuth if curl is found.
- If OAuth requested (--with-oauth), error if curl not found.
- If OAuth disabled (--without-oauth), don't enable it even if found.
- Sanity-check curl-config --version output so we don't send anything crazy in
our HTTP requests if curl-config changes.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Apr 13 16:58:45 2016 +0000
Rename files to match renamed functions
Follow-up to commit 840b3f0e45a43b8378e88c66f004b2f186662e35
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 10 18:46:52 2016 +0000
Fix mhlogin(1) title.
Author: David Levine <david.levine@gonift.com>
Date: Sun Apr 10 11:42:29 2016 -0400
Added -user to mhlogin man page.
Author: David Levine <david.levine@gonift.com>
Date: Sat Mar 26 18:59:31 2016 -0400
Added start_test() and finish_test() functions to test/common.sh.in.
See usage information in the (new) cleanup() function in that file.
This allow us to isolate test failures based on naming of individual
tests within a single test file. As part of this, added set -e to
setup_test(). This required minor updates to test/new/basic and
test/pick/test-stderr to conform. So, migrated test/new/test-basic
to start_test()/finish_test().
(cherry picked from commit cd6133dd23422f92534328f768a322f63a5c6dfe)
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 11:16:55 2016 -0400
Fix to commit 84932d0a96c79bfb2f0384ebab806dc51a35f600 to
insert blank line between header and content for non-text
content.
(cherry picked from commit fe36a7ee2f4304fd3797443d4f2f950d6dc2475d)
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 11:16:55 2016 -0400
Fix to commit 84932d0a96c79bfb2f0384ebab806dc51a35f600 to
insert blank line between header and content for non-text
content.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 11:15:42 2016 -0400
Quoted variables in trap so that distcheck doesn't trip over them if
not set.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 10 11:14:54 2016 -0400
Moved "const" to after "register" to silence compile warning fron gcc.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 10 06:19:19 2016 +0000
check curl_ctx->res_len > 0 not res_body != NULL
res_body is not a pointer and is never NULL
(Thanks clang!)
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 10 06:17:35 2016 +0000
oops, pass int to m_getfld not size_t
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Apr 9 23:09:12 2016 -0700
support multiple oauth users; mhlogin now requires -user
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 10 05:03:14 2016 +0000
plug some memory leaks, in success cases only
(staying clean at least on non-adios paths is not hard)
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 10 04:53:34 2016 +0000
fix mhlogin -browser test
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 3 08:23:11 2016 +0000
Rename and document functions that read from stdin.
- gans becomes read_switch
- getans becomes read_switch_multiword
- getans_via_readline becomes read_switch_multiword_via_readline
- getanswer becomes read_yes_or_no_if_tty
- install-mh.c geta becomes read_line
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Apr 3 01:32:23 2016 +0000
test mhlogin -browser
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 27 12:00:16 2016 -0400
Don't call sm_auth_sasl() for XAUTH2 with -sasl. Instead,
call only sm_auth_xoauth2().
Author: David Levine <david.levine@gonift.com>
Date: Sat Mar 26 19:09:50 2016 -0400
Added start_test()/finish_test() to README.developers.
Author: David Levine <david.levine@gonift.com>
Date: Sat Mar 26 19:05:10 2016 -0400
Migrated the oauth tests to start_test()/finish_test() so that
they don't have any output on success, but do report the particular
test on failure.
Author: David Levine <david.levine@gonift.com>
Date: Sat Mar 26 18:59:31 2016 -0400
Added start_test() and finish_test() functions to test/common.sh.in.
See usage information in the (new) cleanup() function in that file.
This allow us to isolate test failures based on naming of individual
tests within a single test file. As part of this, added set -e to
setup_test(). This required minor updates to test/new/basic and
test/pick/test-stderr to conform. So, migrated test/new/test-basic
to start_test()/finish_test().
Author: David Levine <david.levine@gonift.com>
Date: Thu Mar 24 21:25:19 2016 -0400
Added -browser switch to mhlogin(1).
Merge: 630af73c 961d5bf9
Author: David Levine <david.levine@gonift.com>
Date: Thu Mar 24 20:24:15 2016 -0400
Merge remote-tracking branch 'origin' into xoauth
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 24 19:57:15 2016 -0400
Changed minchars swit values for -[no]concat switches to show(1)
from negative to 0, so that they can be abbreviated and so that they
appear with -help. Added them to the man page, and fixed text that
was copied from mhshow(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 24 19:55:58 2016 -0400
Use WIFXEXITED to check return status of system(), because
comparison with NOTOK wasn't valid.
Author: David Levine <david.levine@gonift.com>
Date: Wed Mar 23 21:40:31 2016 -0400
Changed sign of minchars for the SASL-related switches from
negative to positive so the won't be hidden from help messages.
I think.
Merge: 626b5109 f1920d78
Author: David Levine <david.levine@gonift.com>
Date: Wed Mar 23 20:41:46 2016 -0400
Merge remote-tracking branch 'origin' into xoauth
merge is necessary,
Author: David Levine <david.levine@gonift.com>
Date: Wed Mar 23 20:25:32 2016 -0400
Replaced -oauth service switch with -saslmech xoauth2
-authservice service, because OAUTH2 is a SASL mechanism.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Mar 20 17:28:27 2016 -0700
Another pass at cleaning up (some of) the manpages.
This continues work I started a couple of years ago, but then got
derailed on. There are two main goals behind these updates:
1) replace some low-level troff constructs with more modern
man(7) facilities, and
2) adopt a more consistent visual style to the layout and
formatting of the manpages, particularly in reference to
typeset pages.
This time around I have updated README.manpages to describe the new
guidelines. They are mostly non-intrusive, and serve to clean up
a lot of visual clutter that has crept in over the years.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 19 10:15:43 2016 -0400
Added check of return value of write() to quash compiler warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 19 00:06:24 2016 -0400
Recover properly if the character conversion fails.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 19 00:04:56 2016 -0400
Fix substitution code so it uses the right pointer for the utf-8 test.
Merge: c2a69f6b 2885665e
Author: David Levine <david.levine@gonift.com>
Date: Fri Mar 18 08:30:21 2016 -0400
Merge remote-tracking branch 'origin' into xoauth
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 17 22:05:54 2016 -0400
Have fix_boundary() return NOTOK if it couldn't fix a boundary,
so that mhfixmsg won't modify the message.
Author: David Levine <david.levine@gonift.com>
Date: Wed Mar 16 21:32:48 2016 -0400
Added oauth support to whatnow.
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 13 15:40:23 2016 -0400
Added oauth switch to whatnow.
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 13 13:11:21 2016 -0400
Added use of local variable user to prevent compiler warning
when built without OAuth2 support.
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 13 12:58:25 2016 -0400
Sort JSON output from oauth tests so that comparisons don't
depend on it being in a specific order. Also, clean up test
tmp files.
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 13 12:57:18 2016 -0400
Set MH_VERSION, OAUTH_SUPPORT, and CURL_USER_AGENT in tests/common.sh.in
so that oauth tests can be run individually (not just via make check).
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 13 11:00:05 2016 -0400
Added OAuth2 support to build_nmh.
Merge: b7f1c786 ddb9e8ca
Author: David Levine <david.levine@gonift.com>
Date: Sun Mar 13 10:42:39 2016 -0400
Merge branch 'master' into xoauth
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 12 13:25:36 2016 -0500
Have -nocrlflinebreaks apply to the message parts that -decodetypes
designates.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 12 10:41:03 2016 -0500
Added EXAMPLES and BUGS sections.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Mar 12 00:15:46 2016 -0500
Implement the -reverse option to pick(1) to change the search order.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 27 11:44:51 2016 -0500
Updated date on mh-folders(5) man page.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 27 11:33:39 2016 -0500
Added application/ics to default list if types to decode.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Feb 25 11:33:14 2016 -0500
mh-folders.man: note that folders should not be named numerically
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 24 20:32:10 2016 -0500
Added -[no]crlflinebreaks switches to mhfixmsg(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 21 11:59:41 2016 -0500
Added check for successful decode of a different part with
attempted -decodetext of binary text to test-mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 21 11:22:53 2016 -0500
Don't consider failure to build a text/plain part to be an error.
This allows mhfixmsg to succeed even if there isn't a suitable
mhfixmsg-format-text/subtype profile entry for every text part in
the message.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 20 13:41:52 2016 -0500
Added -decodetypes switch to mhfixmsg(1).
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 28 21:16:43 2016 -0500
Add missing -infile switch name to mhfixmsg-format-text/calendar
rule in mhn.defaults.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 23 15:14:33 2016 -0500
mhical enhancement: If a datetime is missing the time, assume
midnight. If there is no end datetime (DTEND) and the DTSTART
doesn't contain a time, assume that the event is for the entire day.
Author: Richard M Kreuter <kreuter@progn.net>
Date: Tue Jan 19 21:39:11 2016 -0500
Set MH to the resolved, absolute pathname inside context_read() so
that exec'd children can find it.
Author: Richard M Kreuter <kreuter@progn.net>
Date: Tue Jan 19 21:19:16 2016 -0500
Added all of mhshow's documented switches to show's handling, on the
notion that nmh's pieces should know about each other.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 19 21:03:30 2016 -0500
Added mention of mhfixmsg -fixcte to error message for improper C-T-E in
multipart message. Thanks to Conrad Hughes for suggesting this.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 29 22:21:11 2015 -0500
Moved addition of -ansi -pedantic to CFLAGS with gcc from
configure.ac to docs/contrib/build_nmh, so that they're not
included by default with builds by users.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 19 15:27:49 2015 -0500
Allow a RRULE in an iCalendar request to not have an INTERVAL on its
yearly FREQ, because INTERVAL defaults to 1.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 18 18:35:59 2015 -0500
Remove any enclosing quotes from a timezone identifier in an
iCalendar event request. See comment added to format_datetime()
that says that I don't believe that RFC 5545 allows them to be
quoted. But Oliver Kiddle found them in the wild.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 18 18:02:43 2015 -0500
If format_datetime() returns null, store a copy of node->value on c->c_text
to prevent a double free().
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Aug 22 22:16:22 2015 -0400
If str == buffer, then do NOT do a strncpy(buffer, str). Many systems
this works, but on some systems it causes a SIGABRT. POSIX says the
behavior on overlapping copies with str*cpy() is officially undefined.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Aug 22 22:14:41 2015 -0400
Add support for setting the environment variable MH_TEST_NOCLEANUP to
prevent a test from cleaning up the test working directory.
Author: Leonardo Taccari <iamleot@gmail.com>
Date: Fri Aug 21 13:26:53 2015 -0400
Add support for the -sendmail flag to send/post, to support changing the
sendmail executable.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 13 22:32:36 2015 -0400
Unquoted addresses in mhshow and scan output. Suggested by
Anthony Bentley.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 20 12:09:54 2015 -0400
Change the reference to the valgrind suppression file from $MH_OBJ_DIR to
$srcdir so "make distcheck" works.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 20 12:02:14 2015 -0400
Include a new valgrind warning suppression for MacOS X.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Fri Mar 20 10:26:02 2015 -0400
Make sure the valgrind suppression file is honored, and add some extra
suppressions needed when running under the Debian fakeroot environment.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 17 11:02:38 2015 -0400
Fix error message to correctly report the program that failed to execute
when doing HTML conversion.
Also, remove perl function prototypes as they are not considered best
practice.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 6 22:58:58 2015 -0500
Rearrange all callers of post(8) so that the filename is always last.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Mar 4 13:10:38 2015 -0500
mhparse.c: verify all MIME-Version: headers encountered
in addition to verifying, silently ignore duplicate version headers.
Merge: f9eb71e0 3f609815
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 22 21:21:40 2015 -0600
Merge remote-tracking branch 'origin/convertargs'
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Feb 14 11:36:24 2015 -0500
use %l uniformly on all the text-mode browser display strings
otherwise behavior changes depending on which browser was present
when nmh is configured/installed.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 13 23:30:03 2015 -0600
Filter converted text/html to remove blank lines and leading space
that lynx inserts. Also, changed ISO-8859-1 to US-ASCII because it
is, so it doesn't need to be converted.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 13 22:22:21 2015 -0600
Removed m_chkids(), per suggestion of Marcin Cieslak.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 13 21:31:48 2015 -0600
Removed unnecessary #include of h/signals.h.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 13 21:30:41 2015 -0600
Removed #include of signal.h because it's in h/signals.h.
Author: Marcin Cieslak <saper@saper.info>
Date: Fri Feb 13 21:01:09 2015 -0600
Reset done in inc_done() to prevent endless loop when setegid()
fails (in which case adios() is called, which calls done()).
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 12 21:33:05 2015 -0600
That didn't work, so removed offset.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 12 21:27:45 2015 -0600
Use +0000 isntead of -0000 offset because FreeBSD displays it that way.
Author: Marcin Cieslak <saper@saper.info>
Date: Thu Feb 12 21:09:26 2015 -0600
Replaced setgid() calls with setegid() so that it works with dot
locking on FreeBSD. setegid() should be supported on modern POSIX
systems.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 12 20:22:32 2015 -0600
Added showmimeproc to test/common.sh.in so that test-show will test
it in the workspace, not the user's installation. Also added all of
the other procs defined in config/config.c that are currently unused,
just in case they some day are.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 12 20:03:11 2015 -0600
Removed a few more msh (MS_MSH and mshproc) and vmh (vmhproc) relics.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 11 21:38:51 2015 -0600
Replaced individual assignment of array elements, one of which was
out of range, with array initialization.
Author: Marcin Cieslak <saper@saper.info>
Date: Tue Feb 10 14:18:05 2015 +0000
Fixed the error message in lockit() when it fails to create tmp file.
Author: Marcin Cieslak <saper@saper.info>
Date: Tue Feb 10 14:18:05 2015 +0000
Fixed "inc" to be installed setgid mail with dot locking. MAILGROUP=1
was not set in the config.h because we no longer use "LOCKTYPE"
configure variable.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun Feb 8 15:13:31 2015 -0500
update tests for new message separator header from mhshow
also added test names to tests, in any file i touched
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun Feb 8 16:06:44 2015 -0500
update man pages for new mhshow message separator header
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun Feb 8 15:22:07 2015 -0500
add new message separator header to mhshow
new switches to mhshow (-headerform and -[no]header) control whether
and what is displayed before the display of every message's content.
the default separator looks like "[ Message folder:msg ]". the
implementation parallels the -markform feature.
since mhshow is often started by show, show now passes the -[no]header
options through to mhshow. (also, show no longer attempts to pass
such options through to cat (in the case of -noshowproc)).
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Feb 6 13:03:36 2015 -0500
fix typo in mh-format.man
Author: Eric Gillespie <epg@google.com>
Date: Thu Feb 5 12:46:28 2015 -0800
Test that show always shows message numbers.
show shows message numbers in two different formats when showing one
non-MIME, multiple non-MIME messages, or one MIME message.
show does not show any message numbers when showing multiple messages
any of which is MIME.
This is not a new bug, just one that has bothered me since I started
using mhshow with 1.6.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Feb 6 11:57:58 2015 -0500
test/common.sh: allow giving individual tests a name
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Feb 6 11:32:44 2015 -0500
man pages -- clarify what -part and -type do when used together
Merge: 991ae1d9 afea511a
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 8 09:23:34 2015 -0600
Merge remote-tracking branch 'origin' into convertargs
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 8 09:21:13 2015 -0600
Added support to mhfixmsg -reformat for multipart/related. If it has
only a single part that is not text/plain and can be converted to
text/plain, a text/plain part is added and the type of the part is
changed to multipart/alternative. If the multipart/related has more
than one part but does not have a text/plain part, try to add one.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 4 19:19:54 2015 -0600
Fixed test-convert to work on Cygwin and other platforms that
default to UTF-8 locale.
Merge: 397195e7 ff6c0df3
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 4 19:18:33 2015 -0600
Merge remote-tracking branch 'origin' into convertargs
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 4 19:05:16 2015 -0600
Removed unused local variable from move_preferred_part().
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Feb 4 18:52:53 2015 -0500
pending-release-notes: add mhshow's "-prefer", and mh-format's %(kibi/kilo)
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Feb 4 14:44:36 2015 -0500
test-subpart: add mhlist and mhshow tests for -type/-part/-prefer
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Feb 4 12:07:27 2015 -0500
update mhshow, mhlist, and mhstore man pages for -prefer switch
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Feb 3 21:55:41 2015 -0500
implement -prefer, for multipart/alternative preferences
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Feb 3 23:03:46 2015 -0500
mhshow.man: more detail on use of -part and -type switches
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Feb 3 12:39:53 2015 -0500
mhshow: ensure that -part always shows every part requested
previously, "mhshow -part 1 -part 1.3" would show 1.1 but not 1.3.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Jan 30 19:52:24 2015 -0500
mhshow: fix display of alternatives after certain nested multiparts
adjust return codes so that we now have a clear indication of whether
there was a hard error (NOTOK), a failure to display due to type
mismatch (DONE), or complete success (OK). use those codes in
show_multi_internal() to decide whether we're finished with this
multipart or not.
prior to this change, it was impossible to show part 1.2 of a
message constructed like the following, because the disinction
between (the new, as described above) DONE and OK states was
lost while processing multipart/related part 1.1.
msg part type/subtype size description
28 multipart/mixed 1040
1 multipart/alternative 623
1.1 multipart/related 275
1.1.1 text/html 105
1.2 text/plain 33
2 text/plain 83
this fix is related to 9cc2510 and c9794733. hopefully it's right
this time.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Jan 30 20:14:59 2015 -0500
mhshow: simplify code -- the DONE status was adding no value
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Jan 30 19:41:37 2015 -0500
drop the second argument to part_ok(), since it is always 1
the second argument hasn't been used since "historical" times.
also add some commentary to part_ok().
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Jan 27 15:17:20 2015 -0800
Add a note about new bindir option to mhparam.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Jan 27 15:07:19 2015 -0800
'mhparam bindir' now prints NMH's idea of $(bindir).
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 20 19:10:56 2015 -0600
Added a line break to mhbuild man page because the
%docdir%/contrib/replaliases line caused format complaints from groff.
Merge: 4857a9e8 a70006bb
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 18 21:31:20 2015 -0600
Merge remote-tracking branch 'origin' into convertargs
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 11 19:10:23 2015 -0600
Fixed check of return value of show_content_aux().
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 11 19:05:11 2015 -0600
Have show_content_aux2(), and therefore show_content_aux(), return
the status of the process used to show, instead of (usually) OK.
(cherry picked from commit a70006bbdf676639961877b02a19e9e1f1d0ec78)
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 11 19:05:11 2015 -0600
Have show_content_aux2(), and therefore show_content_aux(), return
the status of the process used to show, instead of (usually) OK.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 10 17:23:54 2015 -0600
Fixed typo in mh-format.man page, which I wouldn't have noticed
if I didn't go back in to update its date.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 10 17:12:49 2015 -0600
Added multiply format function, requested by Norm.
Merge: ebd52474 0706d36a
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 7 20:32:20 2015 -0600
Merge remote-tracking branch 'origin' into convertargs
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 7 20:15:06 2015 -0600
Pass along arguments to calaccept(), etc., functions in replaliases.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 7 20:13:41 2015 -0600
Fix to commit 6b073f7b67a0afd64012ff7d00818ec1bd07b5f2 to properly
detect a Content-Type header in output from converted content.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 6 21:39:42 2015 -0600
Another fix to convertarg handling of multipart/related. Two,
actually. One is a simple bug fix, the other restricts concatenation
to text/plain, not just text, parts.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 5 22:32:00 2015 -0600
Specifically look for Content-Type header in converted content.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 5 19:10:33 2015 -0600
Fixed convertarg handling of text part in multipart/related.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 4 11:22:18 2015 -0600
Forgot to commit test-mhical.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 4 10:52:28 2015 -0600
Added mhical(1), to display, reply to, and cancel iCalendar (RFC 5545)
event requests.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 4 09:57:23 2015 -0600
Added yacc/bison support to configure.ac.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 29 07:44:38 2014 -0600
Added rtm alias.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 29 06:06:59 2014 -0600
More cleanup of the cp in tests/common.sh.in.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 22:15:04 2014 -0600
Added -h and -p options to replaliases. The -p argument can be useful
with improperly structured messages, such as those that use
multipart/related when they should have used multipart/alternative.
Alos, removed -editor mhbuild because it precludes use of WhatNow
attach.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 21:12:06 2014 -0600
Replaced explicit list of files to be copied in test/common.sh.in
with *. It wasn't trivial, per the comments in the file about
portability to posh, but close.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 15:51:36 2014 -0600
OK, this fixes the problem referenced in the last commit. It
removes the copy of the etc files only during make distcheck.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 13:42:35 2014 -0600
Reverted commit a2b00e7053ca3be3d1389588580c71498222a267. It caused
make check to pull etc files from where they were already installed,
not from the test directory.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 12:46:22 2014 -0600
Removed export of most of the variables in test/common.sh.in. The
test scripts source common.sh so they don't need them to be exported.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 12:32:14 2014 -0600
Removed copy of all of the etc files from test/common.sh.in.
Instead, for make distcheck, pass the location of the installed etc
directory via DISTCHECK_CONFIGURE_FLAGS, configure, and
TESTS_ENVIRONMENT to a new nmhetcdirinst variable. Outside of make
distcheck, nmhetcdir is valid by itself.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 28 12:12:40 2014 -0600
Rearranged the variable settings at the top of test/common.sh.in.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 27 11:25:48 2014 -0600
Changed direct access to etc files in a couple of tests to be the
installed (for the test) versions, not the copies made by common.sh.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 27 11:19:43 2014 -0600
Replaced nmhexecdir with nmhlibexecdir in test/common.sh.in (and
test-mhparam) for consisitency with the Makefile.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 25 11:10:52 2014 -0600
Added -fixtype switch to mhfixmsg(1). It ensures that each part of
a message has the correct MIME type shown in its Content-Type header.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 25 11:04:28 2014 -0600
Added const to char * arguments of uprf().
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 25 00:05:36 2014 -0600
Added ct_str_type() and ct_str_subtype() functions, to translate
MIME type and subtype names to the the internal MIME parser codes.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 25 00:04:34 2014 -0600
Merged two adjacent if (verbose) blocks.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 24 18:25:43 2014 -0600
Fixed memory leak in mime_type(). get_file_info() always allocates
its return value.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 24 14:35:41 2014 -0600
Always initialize those two variables made static in commit
771706ac9fed2b902bd4d3ddccb15ee27b0f58ae in case they were
set in previous calls.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 21 19:50:58 2014 -0600
And removed another improperly copied comment.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 21 19:46:25 2014 -0600
Removed improperly copied comment from test-mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 21 19:41:12 2014 -0600
In expand_pseudoheader(), set Content-Type to 7-bit for ASCII text.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 21 16:21:27 2014 -0600
Added mention of profile components that are described
in other man pages. Suggested by Michael Richardson.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 21 10:31:41 2014 -0600
Rearranged code to avoid "might be clobbered by longjmp" warnings from
gcc 4.9.2
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 21 10:22:41 2014 -0600
Removed unnecessary #includes of setjmp.h.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 20 14:27:03 2014 -0600
Removed widths from mhbuild-convert-text/html lines that should
have been removed by commit 5ab36412b5fc49feb41fa816129c68fd6d946e8b.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 20 14:07:37 2014 -0600
Fixed use of text_plain_ct in mhbuildsbr.c so that it works with
multiple text parts. Found by Clang static analyzer.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 20 10:42:11 2014 -0600
Set COLUMNS in test-cd if using readline so that its wrapping doesn't
disturb the test output. The problem arose with a long workspace path.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 20 10:36:10 2014 -0600
posh didn't like use of file wildcard in common.sh.in.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 20 09:21:50 2014 -0600
Removed R from default PARINIT environment variable so that par(1)
does not consider an input word that is too long to be an error.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 17 20:43:37 2014 -0600
Fixed format engine output of negative number with 0 fill character.
Improper output was reported by Bob Carragher.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 14 22:11:00 2014 -0600
Added -convertargs switch to repl(1), to pass arguments to programs
specified in the user's profile or mhn.defaults to convert message
content.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 13 08:30:35 2014 -0600
Rearranged mhn.defaults.sh a bit: consolidated web-browser specific
settings and put most of the mhstore-store- directives in a here doc.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 13 08:04:13 2014 -0600
Clarified in repl(1) man page that -noformat is only the
default when no -filter switch is used.
Author: Eric Gillespie <epg@google.com>
Date: Mon Dec 8 23:37:51 2014 -0800
Strip carriage returns fakehttprequest logging.
Author: Eric Gillespie <epg@google.com>
Date: Mon Dec 8 23:29:07 2014 -0800
Note curl dependencies for Linux and FreeBSD.
Author: Eric Gillespie <epg@google.com>
Date: Mon Dec 8 23:26:27 2014 -0800
Teach mhparam about oauth support.
Author: Eric Gillespie <epg@google.com>
Date: Mon Dec 8 23:20:01 2014 -0800
Implement OAuth 2.0 [1] for XOAUTH2 in SMTP [2] and POP3 [3].
Google defined XOAUTH2 for SMTP, and that's what we use here. If other
providers implement XOAUTH2 or some similar OAuth-based SMTP authentication
protocol, it should be simple to extend this.
[1] https://tools.ietf.org/html/rfc6749
[2] https://developers.google.com/gmail/xoauth2_protocol
[3] http://googleappsdeveloper.blogspot.com/2014/10/updates-on-authentication-for-gmail.html
Technically, XOAUTH2 is a SASL auth mechanism, but the implementation is so
trivial, I can't justify the code complexity or additional dependency
requirement of using Cyrus SASL for this. So it's completely separate.
Changes:
- New dependencies:
- jsmn (JSON processing library) bundled directly rather than linked to as
an external library because there is no clear winner among JSON
libraries for C and this one is tiny
- libcurl is nearly ubiquitous and too heavy-weight to bundle, so link to
the library the user must install separately
- Add oauth.h / oauth.c which do almost all the work, with quite a bit of
help from curl and jsmn.
- Add new mhlogin program to authorize nmh to use the Gmail account and
store the access and refresh tokens.
- Add new user_agent global to version.c (version.sh); not too happy with
such a generic name, but the others had no mh_ prefix or anything...
- Add XOAUTH2 support to:
mts/smtp/smtp.c uip/post.c uip/send.c uip/popsbr.c uip/inc.c uip/msgchk.c
- Split duplicated serving code out of fakepop.c and fakesmtp.c to new
server.c and also use that for new fakehttp.c.
- Add XOAUTH2 support to fakepop.c and fakesmtp.c.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Mon Dec 8 21:47:58 2014 -0800
import jsmn 86:19001fb4adb3
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 6 09:30:52 2014 -0600
Only remove extraneous trailing semicolon from Content-Type and
Content-Disposition headers because those are the only ones that
parse_mime() warns about, but it does appear on others.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Fri Dec 5 21:08:40 2014 -0800
Terminate last arg in proxy argv n popsbr.c:parse_proxy().
This bug seems to have existed since this code was born. I guess
others have been lucky?
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 2 13:41:55 2014 -0500
Set all Content structure elements to NULL as they are free()'d; in a few
cases a content structure is reused and you can get into problems with
double-free()ing elements depending on your MIME composition content syntax.
Merge: 330bdf62 8206fbfd
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 2 13:12:45 2014 -0500
Merge commit '8206fbf', due to my screwup of committing it on a detached
HEAD after a git-bisect.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 2 13:00:47 2014 -0500
Turns out those warnings for ali(1) actually happen when the prefix is
33 characters, not 35.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 2 09:35:02 2014 -0500
Explicitly depend on $(srcdir)/config/version.h rather than depend
on VPATH.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon Dec 1 13:32:26 2014 -0500
cast isspace() arg to unsigned char in previous commit
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon Dec 1 08:57:44 2014 -0500
handle extraneous trailing ';' characters that are followed by whitespace
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 30 21:35:19 2014 -0600
mhfixmsg now removes an extraneous trailing semicolon from header
parameter lists.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 22 19:00:32 2014 -0600
Use Nmh-Attach for attach header field name, and accept Attach.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 22 18:55:39 2014 -0600
Have to check for missing type parameter in message/related part
even though it's required according to RFC 2387 Sec. 3.1.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 22 18:54:48 2014 -0600
Expanded explanation of mhfixmsg return status in its man page.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 20 22:28:28 2014 -0600
Look at type of parent multipart/related when determining whether
a non-plain text part already has a text/plain sibling.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 20 22:27:58 2014 -0600
Added support for multipart/related to MIME parser.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 20 20:25:14 2014 -0600
Added some checks to mhfixmsg.c to avoid dereferecing null pointers
after a failed transformation.
Author: David Levine <levinedl@acm.org>
Date: Thu Nov 20 19:48:58 2014 -0600
Fixed double fclose() in InitMultiPart() and leaks introduced in
commit 5be8db81.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Nov 20 15:41:34 2014 -0500
prevent spurious errors when requesting specific message parts
no one should be reporting NOTOK for failure to display parts that
weren't actually requested. failure should be reserved for parts that
we really attempted to display.
(this fix is an extension of c9794733.)
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 19 21:04:33 2014 -0600
Updated simple integration example in mhfixmsg(1) man page
and added return status values.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 19 20:17:45 2014 -0600
Updated test-mhfixmsg to support -[no]changecur.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 19 20:13:01 2014 -0600
Added -[no]changecur switches to mhfixmsg(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 16 18:13:47 2014 -0600
Updated test-repl to compare with new -help message.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 16 17:14:32 2014 -0600
Fixed repl help message to show "-[no]cc all|to|cc|me" instead of
different options for -cc and -nocc.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 16 17:10:52 2014 -0600
Fixed leak in content_charset(): if get_param() found the charset,
it returns a copy.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 15 10:20:42 2014 -0600
Moved mhstore declarations from uip/mhn.c, uip/mhstore.c, and
uip/mhstoresbr.c to h/mhparse.h.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 15 08:40:36 2014 -0600
Removed "If this draft originated on the local host, then" phrase
from mh-alias man page. Alias resolution applies no matter where
the draft originated.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 7 23:08:13 2014 -0600
Changed content_charset() to not cache, so the user can always, and
should, free the return value.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 7 22:46:17 2014 -0600
Cleaned up leaks from calls to content_charset() in mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 7 22:42:34 2014 -0600
Added deallocation of cts to freects_done().
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 4 21:47:13 2014 -0600
Fixed repl(1) man page to show "msg" instead of "msgs" because
it only allows reply to one message.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 4 17:04:30 2014 -0600
Fixed mlistfree() so that it doesn't dereference a free'd list node
in order to find the next node.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 4 17:00:28 2014 -0600
Fixed commit 6cc9e85e73ff6f6c67ae6e645d184bbf57ecc2f0 to properly
return other than the first mbox/address if there's a match in
getmymbox/getmyaddr.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 29 21:27:55 2014 -0500
Fixed memory management in mhstore. The main problem was a double
free when both -file and -outfile switches were used on a MIME
message.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 29 19:37:18 2014 -0500
Added initial "MH-Profile-Version: 1.0\n" line to newly created
profiles. The main purpose of this first line is to fool file(1).
Without it, if the first line of the profile is Path:, file 5.19
reports its type as message/news. With it, it reports the type as
text/plain.
Author: David Levine <levinedl@acm.org>
Date: Mon Oct 27 21:20:07 2014 -0500
Renamed getmymbox mh-format escape function to getmyaddr, and
added new getmymbox that returns the user's address with any
personal name.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 26 10:41:04 2014 -0500
Added getmymbox function escape.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 25 20:41:55 2014 -0500
Fixed memory leak in do_name() when multiple dates are parsed.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 25 20:38:20 2014 -0500
Added free_fs(), corresponding to new_fs().
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 25 18:54:50 2014 -0500
Fixed dst format escape to return 1 instead of 16, to agree with its
documentation.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 24 23:25:58 2014 -0500
Added mhstore-store-text/html formatting string to mhn.defaults.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 24 23:19:54 2014 -0500
Fixed typo in mhstore man page.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 24 22:22:47 2014 -0500
Reworked charstring_buffer_copy() to not use strdup() so that
charstrings with null bytes can be supported. Added
charstring_append_cstring().
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 11 09:22:52 2014 -0500
Added mh_xcalloc().
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 11 09:17:14 2014 -0500
The units of the zone format escape are minutes, not hours.
Merge: edccf71c a92ba791
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Oct 8 19:13:19 2014 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Oct 8 19:12:28 2014 -0700
no-op to force check the buildbots.
Merge: cdec1be9 64be8525
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 5 12:32:20 2014 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 5 12:28:56 2014 -0700
mhn.defaults: make fetch less agressive on FreeBSD.
Drop the -a flag to fetch. Its retry logic has a bug where it will
go into an endless loop when trying to re-fetch an object behind
an https:// link when it is unable to validate the X.509 certificate
chain.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 5 10:18:25 2014 -0500
Use "mhparam etcdir" instead of hard-coded etc in build_nmh.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 5 01:50:59 2014 -0700
Clean atags file as part of maintainer-clean.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 5 01:27:56 2014 -0700
Add a missing option to mhn fetch command for FreeBSD.
I *always* forget the '-o -' to redirect to stdout :-P
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 5 01:20:56 2014 -0700
On FreeBSD, use fetch(1) to retrieve external content through URLs.
fetch(1) is part of the base system, so it's guaranteed to always be there.
And it is more likely to have been configured for any local site
customizations (local caches, proxies, etc).
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 5 00:26:11 2014 -0700
If building from a non-master git branch, include the branch name in the version string.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Oct 4 22:49:01 2014 -0700
New locations for config files and support binaries, and smarter default for install root directory.
The default locations for config files and back-end executables has
changed.
Config files have moved from ${sysconfdir} to ${sysconfdir}/nmh, and
the back-end programs from ${libdir} to ${libexecdir}/nmh.
The only user-visible change is the addition of a new mhparam(1)
component 'libexecdir', which replaces the previous 'libdir'. User
scripts invoking 'mhparam libdir' will need an update. 'libdir'
has been kept around for the time being, to give people a chance
to update their scripts. It returns the same value as 'libexecdir'.
'libdir' has been marked deprecated in the mhparam(1) manpage and
the release notes; it will be removed in a couple of releases.
In conjunction with this change there was an opportunity to do a
bit of Makefile cleanup. The old 'auxexec' construct has been
replaced with a new scheme that leverages automake's templating.
The auxexec_* references have been replaced with nmhlibexec_* forms,
and a corresponding nmhlibexecdir variable defined as ${libexecdir}/nmh.
Likewise, etcdir has been replaced with nmhetcdir.
These name changes have percolated downstream to some extent, primarily
in the man pages and test scripts.
Finally, configure has been made a bit smarter about setting the
default ${prefix}. If it finds an existing nmh installation, it
will set the default ${prefix} to match, falling back to /usr/local/nmh.
configure looks for an existing installation by searching $PATH for
a viable mhparam binary.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 4 22:43:21 2014 -0500
Fixed commit 2adafe760a9c45b417727a3f5d9481de26471a8b to not
try to allocate a charstring_t of length INT_MAX with -width 0.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 4 22:17:08 2014 -0500
Simplified test-mhl-flags a bit.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Oct 1 17:20:38 2014 -0700
Add a 'guide' file for acme(1).
If we ever find more than one acme user working on the source,
the single-guide-file premise might need a review.
Ultimately, there should be a way for the configure script to
search for and import a personal guide file from the developer's
$HOME or some such. The next person to come along can figure
that out.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Oct 1 15:36:25 2014 -0700
git: ignore top-level tags files
atags is the output from a ctags variant that generates its
output in a format recognized by Plan 9's acme editor.
(ftp://orthanc.ca/unix/atags/ for details.)
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Sep 29 22:42:28 2014 -0700
FreeBSD packages destination directory fixup.
If the ports collection is not installed, assume ports/packages
install under /usr/local.
Also, when querying <bsd.port.mk>, use the value of the $(LOCALBASE)
macro. ($(PREFIX) is for port-specific overrides of $(LOCALBASE).)
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Sep 29 15:52:18 2014 -0700
For FreeBSD builds, also search the ports tree for includes and libs.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 14 20:24:24 2014 -0500
Added checks of return value of fwrite() calls where missing.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 14 19:31:43 2014 -0500
Fixed formatting of rtrim/nortrim in mhl man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 14 19:14:10 2014 -0500
An "rtrim" flag has been added to mhl to remove any trailing
whitespace from filtered text lines. A corresponding "nortrim" flag
has also been added.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 14 19:04:21 2014 -0500
If a component has trailing whitespace, e.g., body:component="> ",
mhl now trims that whitespace off when filtering blank text lines.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 12 22:12:33 2014 -0500
Fixed all anomalies detected by clang static analyzer (with
default checkers on Linux). One was notable: there was a break
missing from a switch case in fmt_scan.c, which caused the result
of the sday function escape to be garbage.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 12 15:06:52 2014 -0400
Fix typo in man page
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 7 09:56:21 2014 -0500
On some platforms, -D_FORTIFY_SOURCE=2 warns about ignoring the
return value from mbtowc() even when it is called to reset the
shift state. So wrap that in an if statement with a null body.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 7 09:18:20 2014 -0500
Added -D_FORTIFY_SOURCE=2 now that the build is clean with it.
Removed -Wno-unused-result because it shold no longer be necessary.
Adjusting all settings of CPPFLAGS to have consistent form.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 6 20:26:42 2014 -0500
Added a couple of new directories and a note about valgrind
warnings from debuginfo to README.developers.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 6 08:00:52 2014 -0500
Check return values of system calls in uip/ and test/ .c files, found
with gcc's -D_FORTIFY_SOURCE=2.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 5 21:18:28 2014 -0500
Quote "$SEARCHPATH" in mhn.defaults.sh to allow spaces, etc., in
PATH components.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 1 21:09:04 2014 -0500
Doubled size of buffers used by m_getfld(), scan, and fmttest to
8192, on any platform, so that -width 0 and -outsize max are
likely to include at least some part of the body of each message.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 1 20:27:33 2014 -0500
Fixed typo in mh-profile.man.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 1 20:14:52 2014 -0500
Don't let scan() use too large a width (BUFSIZ for now) to prevent
allocating a huge output buffer.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 31 15:40:57 2014 -0500
A value of 0 for the width switch of scan(1), inc(1), ap(1), dp(1),
fmttest(1), and mhl(1) now means as many characters as the format
engine can produce [Bug #15274]. That amount is limited by internal
buffers.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 31 15:39:47 2014 -0500
Fixed read of body in fmttest to limit size to that of rbuf, if
smaller than outwidth, to avoid overrunning it.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 29 08:50:51 2014 -0500
fmt_scan() no longer subtracts 1 from the width. This has the effect
of no longer counting the trailing newline in the output of scan(1),
inc(1), and the other programs that rely on it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Aug 28 22:29:21 2014 -0400
Very very rough cut at trying to parse email addresses with Bison.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 25 22:06:11 2014 -0500
Check return values of system calls in several sbr .c files, found
with gcc's -D_FORTIFY_SOURCE=2. Updated checks added previously to
mhfixmsg.c to be consistent.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 25 20:49:39 2014 -0500
Moved reverse_alternative_parts() from mhfixmsg.c to mhparse.c
and added declaration to mhparse.h.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 25 19:50:23 2014 -0500
Removed msh relics from scansbr.c, including a global.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 25 19:29:34 2014 -0500
Added size_t cast of another MB_CUR_MAX to silence the compiler
on FreeBSD 9.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 24 21:46:34 2014 -0500
Added cast of MB_CUR_MAX to size_t to silence compiler warning on
FreeBSD.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 24 21:19:10 2014 -0500
Dynamically allocate space for the output of fmt_scan(), using
charstring_t, so a fixed sized output buffer is no longer needed.
Also got rid of scanl global.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 24 12:06:40 2014 -0500
Added const to last argument of trace_cb signature, it'll be
needed for use with charstring.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 24 08:23:55 2014 -0500
Added charstring "class".
Author: David Levine <levinedl@acm.org>
Date: Wed Aug 20 07:53:56 2014 -0500
Refer to RFC 2046 instead of 1521 in mhlist.man.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 18 20:47:03 2014 -0500
Changed dist_contrib_DATA to dist_contrib_SCRIPTS so that all
of the scripts will be installed with execute permissions.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 18 20:36:00 2014 -0500
Updated mhfixmsg(1) man page to refer to mh-mkstemp(1) instead of
mktemp.
Author: David Levine <levinedl@acm.org>
Date: Sat Aug 16 21:01:26 2014 -0500
Checked return value of write() calls in mhfixmsg.c,
found with gcc's -D_FORTIFY_SOURCE=2.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 15 21:00:57 2014 -0500
Removed h/msh, hopefully the last msh relic.
Author: David Levine <levinedl@acm.org>
Date: Sat Aug 9 09:20:31 2014 -0500
ncurses package is required to run all of test suite on Linux and Cygwin.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Aug 8 14:32:54 2014 -0700
Print information about the compiler toolchain on Darwin and FreeBSD.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Aug 6 17:48:18 2014 -0700
Add new build tool: tools/showbuildenv
This prints some basic information about the build environment.
It's intended use is to print some information about the specific
build environment for each of the builds in the buildbot cluster.
In particular, the patch level of the OS, and the versions of
3rd-party packages installed on the system, compiler versions, etc.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 3 22:08:23 2014 -0500
Removed second argument from m_Eom() in m_getfld.c because
it was unused.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 3 21:05:03 2014 -0500
Here's a better fix to m_Eom() in m_getfld.c than commit
d2520ac7054ad75d60342606bf13c821305d958c. The comparison
of the return value of Getc() with EOF must be as an
integer, not a char.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 3 21:01:16 2014 -0500
Removed eom_action from m_getfld.c because it was only used by
m_eomsbr(), which was removed by commit
68e8c25f906e7353269502d2292c8e99aa8c6605.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 3 20:35:07 2014 -0500
Removed mhlsbr(). It was only used by msh, too.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 3 20:10:45 2014 -0500
Removed m_eomsbr() from m_getfld.c, and its scan_eom_action()
wrapper. It was only used by msh, which was removed by commit
e6917522a770cf2dba9997ca047977bc55fac061.
Author: David Levine <levinedl@acm.org>
Date: Sun Aug 3 07:53:15 2014 -0500
Added -debug switch to pick(1) and deprecated $MHPDEBUG.
Author: David Levine <levinedl@acm.org>
Date: Sat Aug 2 21:37:34 2014 -0500
Fixed refile(1) -retainsequences when the source and destination
folders are the same.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 27 08:32:13 2014 -0500
Separated out list of programs that are required to build from a
source code snapshot from those that are required to build from a
distribution.
Author: David Levine <levinedl@acm.org>
Date: Thu Jul 24 13:10:23 2014 -0500
Fixed sed usage in flex fixup to not use -s (or -e, because
even that's not needed).
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 23 21:20:34 2014 -0500
Removed "true" from end of flex fixups. I don't know why it was
there.
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 23 21:10:47 2014 -0500
Apply flex fixup to dtimep.c with flex 2.5.37 as well as 2.5.36.
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 22 21:50:30 2014 -0500
When mhparam(1) is going to output the value for spoollocking,
call mts_init() first in case it was set in mts.conf.
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 22 21:17:54 2014 -0500
Updated test-spoollocking to restore mts.conf when it's finished
(successfully) so as to not upset subsequent tests. Also fixed
removal of existing spoollocking option each time through.
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 22 20:46:04 2014 -0500
Note in mh-folders(5) man page that spoollocking can be overridden
in mts.conf as well as with configure.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jul 9 12:05:49 2014 -0400
Fix bug #42718; ali(1) still refers to removed options -normalize and
-nonormalize.
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 8 19:58:12 2014 -0500
If the user didn't specify any of the tls switches to post(8), try to
help them by implying -initialtls if they're using port 465 (smtps,
until IANA revoked that registration in 1998).
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 6 22:22:38 2014 -0500
Here's an even simpler fix to enable TLS by default.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 6 16:46:12 2014 -0500
Fix to commit 03e76aecdf671ca13b5912af8206e9bdcb6c0919 to enable
TLS by default. Boolean logic is our friend.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Jul 4 13:24:37 2014 -0700
Revert "Default to enabling (Cyrus) SASL, if available."
This reverts commit fd23674a5829d5092c99a07110086f02f0b4a238.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jul 3 19:31:44 2014 -0700
Turn back the sasl test. Everything broke as a result.
Not surprising.
Revert "Comments should say why a chance matters ..."
This reverts commit 7e6d0b76b1869b4fecc2412ac68f9739ee5916ea.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jul 3 17:49:31 2014 -0700
Comments should say why a chance matters ...
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jul 3 16:40:37 2014 -0700
Default to enabling (Cyrus) SASL, if available.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jul 3 16:33:56 2014 -0700
Fix the release notes to put things in the correct section,
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jul 3 16:25:13 2014 -0700
Note that post uses the submission port now.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jul 3 16:11:38 2014 -0700
Enable TLS by default.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 16 21:04:47 2014 -0500
Check return value of setlocale(3) and admonish on failure.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Jun 16 17:03:06 2014 -0700
Add missing variable initializations on fmt_scan().
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Jun 16 16:03:25 2014 -0700
Ensure getline() is in scope on FreeBSD.
On FreeBSD, to make the getline() prototype visible, you must
'#define _WITH_GETLINE' before including <stdio.h>.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 15 22:43:16 2014 -0500
Fix to commit 0d3875d020fb17d34918f5e81ee7f87fbc5d1565: it seems
that only Linux uses the locale name of en_US.utf8, so added check
for the more common en_US.utf-8 to the tests that use it.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 15 22:05:16 2014 -0500
Reordered #includes of sbr/terminal.c to allow compilation on
Solaris 10. Thanks to Michael Urban for report the problem and
verifying the fix.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 14 11:52:42 2014 -0500
Skip (parts of) tests that require en_US.utf8 locale if it's
not available. Thanks to Alexander Zangerl for reporting the
issue.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jun 13 15:17:48 2014 -0400
Test to make sure inc works properly with a POP server that has
multiple messages on it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jun 13 15:07:26 2014 -0400
Support multiple messages with fakepop.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jun 10 21:08:02 2014 -0400
Always default the username to the local username, even when not
doing SASL. Fix suggested by Michael Urban.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jun 10 19:06:54 2014 -0400
Use variable-size (but in one case, fixed but larger) buffers for the SASL
exchange to deal with larger SASL messages (specifically, when doing GSSAPI
with certain ticket extensions).
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon Jun 9 23:21:35 2014 -0400
mh-profile.man: rewrite the Profile Lookup section for clarity
thanks to Ralph Corderoy for the text.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jun 9 12:00:17 2014 -0400
If "curl" is available, create a nmh-access-url entry that uses it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jun 9 11:36:05 2014 -0400
Fix curl example for nmh-access-url entry.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jun 7 23:14:12 2014 -0400
Return an appropriate error if the input characters are 8-bit, but the
locale character set is US-ASCII.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jun 7 22:40:12 2014 -0400
Whoops, this should be LC_CTYPE. Fixing that exposes the lack of an
appropriate environment variable in test-utf8-body
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Jun 4 12:18:12 2014 -0400
mhlist: don't truncate anything when -verbose
without this change to the -verbose output, there's no easy way to use
mhlist to get an unmodified content-type or content-description. (the
non-verbose output isn't changed.)
Author: David Levine <levinedl@acm.org>
Date: Thu May 29 21:08:59 2014 -0500
Clarified description in comments of context_find_by_type().
Author: David Levine <levinedl@acm.org>
Date: Thu May 29 21:07:25 2014 -0500
Added static to declaration of docc().
Author: David Levine <levinedl@acm.org>
Date: Thu May 29 21:05:36 2014 -0500
Undid commit 475fef2edee9db3c63fc089df76f8e93e3d598cd, it didn't
seem popular. We'd be better off with a proper method, or using
formail(1), to extract the addresses from a message.
Author: David Levine <levinedl@acm.org>
Date: Thu May 29 21:02:49 2014 -0500
Split assignment and export of shell variable.
Author: David Levine <levinedl@acm.org>
Date: Tue May 27 21:35:23 2014 -0500
Added mention of "Reply to <address>?" prompt to repl(1) man
page and code, as comment. Suggested by Norm so that scripts
can depend on it.
Author: David Levine <levinedl@acm.org>
Date: Mon May 26 09:17:34 2014 -0500
Added context_find_by_type(), helper function to search first, if
subtype is non-NULL, for invoname-string-type/subtype and then
invoname-string-type. Also gets rid of some fixed-size temp buffers.
Author: David Levine <levinedl@acm.org>
Date: Fri May 23 17:07:39 2014 -0500
Fixed test-mkstemp to work with valgrind.
Author: David Levine <levinedl@acm.org>
Date: Thu May 22 20:39:45 2014 -0500
Fixed to commit 378589b17424bd78acbfc57d505383ffb8c256cb:
when a -file switch will be used, insert -[no]concat before
the filename (and therefore, the -file switch itself).
Author: David Levine <levinedl@acm.org>
Date: Wed May 21 22:11:42 2014 -0500
Don't pass -[no]concat from show(1) to mhl(1).
Author: David Levine <levinedl@acm.org>
Date: Wed May 21 20:56:25 2014 -0500
Fixed typos in comments.
Author: David Levine <levinedl@acm.org>
Date: Wed May 21 20:50:22 2014 -0500
On platforms with no MIMETYPEPROC, declare the content to be
binary if it contains any NUL characters.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon May 19 13:37:26 2014 -0400
Explain how to get a literal % in format files.
Author: David Levine <levinedl@acm.org>
Date: Sun May 18 21:55:13 2014 -0500
Documented steps to build RPM from tarball, without using autogen.sh.
Author: David Levine <levinedl@acm.org>
Date: Sun May 18 21:43:20 2014 -0500
Added autogen.sh to EXTRA_DIST.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri May 16 13:02:43 2014 -0400
Handle unknown message types in the generic content handler rather
than in the RFC822 handler; this will cause them to be displayed using
an output marker rather than throw an error.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri May 16 12:14:21 2014 -0400
Output a newline if the last character in a text/plain part is
not a newline (but only for mhshow).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri May 16 00:04:24 2014 -0400
Move the prototype for show_content_aux() to a common header file; it
got an extra argument recently but none of the other users of it
noticed.
When fixing this I discovered that the usage of show_content_aux()
by mhstoresbr.c was wrong; the prototype had an extra argument in
the middle of it. Apparently this has been broken for 15 years!
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu May 15 23:01:49 2014 -0400
Switch from %p to %l (%p is no longer supported, although we silently
accept it).
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 15 14:02:07 2014 -0400
fix comment syntax
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue May 13 09:36:42 2014 -0400
clarify scan_content() logic for choosing encoding
Author: David Levine <levinedl@acm.org>
Date: Thu May 15 10:28:03 2014 -0500
Added support for mhbuild-disposition-<type>[/<subtype>] profile
entries when mhbuild expands Attach: headers. Default to
'attachment', but override with 'inline' entries for text/calendar
and message/rfc822 in mhn.defaults.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 15 08:55:45 2014 -0400
change mhlist to use decimal math when abbreviating sizes
the K/M/G/T units imply factors of 1000, so make the code
match. (the alternative would be to change the units to
Ki/Mi/Gi/Ti.) mhlist output might someday be configurable
using mh-format, in which case the user will be able to choose.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue May 13 10:10:09 2014 -0400
add $(kibi) function, as complement to %(kilo)
%(kibi) will convert a number to IEC prefix units, i.e. Ki, Mi, Gi,
Ti, representing factors of 1024. (by comparison, %(kilo) represents
factors of 1000.)
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue May 13 09:43:43 2014 -0400
rename %(units) to %(kilo)
per discussion here:
http://lists.nongnu.org/archive/html/nmh-workers/2014-05/msg00092.html
Author: David Levine <levinedl@acm.org>
Date: Tue May 13 07:02:11 2014 -0500
Added --dereference option, if supported, to file(1) command
in NMH_MIMETYPEPROC and NMH_MIMEENCODINGPROC macros.
Author: David Levine <levinedl@acm.org>
Date: Fri May 9 18:58:11 2014 -0500
Fix to commit b828fcb1695393007a75c41d32b2173c296be9d7: a couple
of commas were missing from the added line.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 8 14:25:14 2014 -0400
add new sample files for mhbuild tests to Makefile.am
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 8 12:42:10 2014 -0400
add new test for 'mhbuild -check'
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 8 11:31:56 2014 -0400
eliminate use of fgets() from calculate_digest() in mhbuildsbr.c
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 8 10:57:40 2014 -0400
eliminate use of fgets() in mhbuild.c
use getline() instead, which is more tolerant of NULs in the input.
also cleaned up error and file cleanup paths a bit.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 8 10:51:30 2014 -0400
eliminate use of fgets() in mhparse.c
use getline() instead, which is more tolerant of NULs in the input.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 19:43:04 2014 -0400
add new test for NUL bytes embedded in text/plain parts
such parts should be encoded with quoted-printable
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 16:57:14 2014 -0400
add new test for attachment containing NULs
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 19:41:39 2014 -0400
clean up whitespace in mhbuildsbr.c
lots of space-follows-tabs, and trailing whitespace.
no code changes.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 19:36:56 2014 -0400
make scan_content() work correctly with content containing NULs
switched from fgets to getline for unambiguous reads in the face of
NUL bytes. added a checkfornuls flag, and use it to cause the correct
encoding when content-types of application or text contain NULs.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 19:34:33 2014 -0400
make writeQuoted() work correctly with content containing NULs
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu May 8 12:37:50 2014 -0400
Treat unknown top-level content types as "application" types, instead
of generating an "unknown content type 0" error.
Author: David Levine <levinedl@acm.org>
Date: Wed May 7 21:16:46 2014 -0500
Fixed test-charset to pass without iconv.
Author: David Levine <levinedl@acm.org>
Date: Wed May 7 21:14:45 2014 -0500
Moved norm_charmap() declaration from h/prototypes.h to
sbr/check_charset.c. That's the only place where it's used and
we want to keep it that way.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed May 7 12:33:56 2014 -0700
Add a doxygen config file.
Sends its output to docs/doxygen/... (see docs/doxygen/html/index.html after
you run doxygen).
Requires graphviz, for the dependency graphs.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed May 7 12:09:21 2014 -0700
Revert "Increment VERSION on the head to 1.7+dev."
This reverts commit 6cce62edaae4cc28ac42a1a796ff18f183407788.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed May 7 12:07:03 2014 -0700
Add a 'tools' subdirectory. This is a home for developer-oriented
scripts and such which can't be run from the Makefile(s) due to
system dependencies.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed May 7 11:49:10 2014 -0700
Increment VERSION on the head to 1.7+dev.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed May 7 11:44:05 2014 -0700
Scrub *.plist (Clang Static Analyzer) files when cleaning.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed May 7 11:43:09 2014 -0700
Git: ingore *.plist files (generated by the Clang Static Analyzer).
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 12:10:35 2014 -0400
remove binaries unintentionally committed
oops.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon May 5 22:41:43 2014 -0400
modify tests for the new mhshow mime part marker format
also added a couple of Content-Description headers to better
test the marker format.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed May 7 10:19:56 2014 -0400
modify mhshow marker format to include the size of the part
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue May 6 17:28:18 2014 -0400
add "%(units)" function, to express numbers with SI units
i.e., 1510 --> 1.5K, 15780000 --> 15.8M etc. useful with %(size),
as in %(units(size)).
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue May 6 11:54:52 2014 -0400
make the %(size) function useful in mhshow marker line formats
normally %(size) returns the size of the message. in mhshow
marker lines, it returns the size of the (decoded, if necessary) part.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue May 6 22:41:34 2014 -0400
Document these functions a bit better.
Author: David Levine <levinedl@acm.org>
Date: Sun May 4 22:30:45 2014 -0500
Removed obsolete comment.
Author: David Levine <levinedl@acm.org>
Date: Sun May 4 09:25:49 2014 -0500
Fixed typo in comment in sbr/readconfig.c.
Author: David Levine <levinedl@acm.org>
Date: Sun May 4 21:51:52 2014 -0500
Replaced use of norm_charmap() in mhshow and mhfixmsg with
case-insensitive string comparison against the charset name.
norm_charmap() is intended for use with result of nl_langinfo(),
and didn't add much value here.
Author: David Levine <levinedl@acm.org>
Date: Sun May 4 09:03:33 2014 -0500
In mhshow, copy result of call to norm_charmap() and get_charset()
because they return a static buffer. Thanks to Alexander Zangerl
for tracking this down, when using an ISO-8859-1 locale.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Apr 23 21:44:54 2014 -0400
mhshow: apply marker form to all part separators
the mhshow "-markform" format is now used for all part separators, not
just those being left out. the format now overloads the %(unseen)
function to indicate that the content of the part being marked has
been suppressed. the built-in default and example formats both make
use of this function.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Apr 26 10:45:47 2014 -0400
mhshow: suppress error for undisplayable parts, if they're not wanted
consider this message:
1 multipart/mixed 1113K
1 multipart/alternative 292
1.1 text/html 66
1.2 text/plain 49
2 image/jpeg 823K
if this is displayed using "mshow -part 2", in the presence of an
MHSHOW variable which _only_ describes a rule for displaying images,
then we don't want to get an error about how nothing in part 1 was
displayable.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Apr 22 12:23:01 2014 -0400
man pages: clarify how profiles entries are searched
(cherry picked from commit d7b59eb68168ead6a81ca40cf8aa5cccbf86c649)
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 21 23:00:47 2014 -0400
Fix minor typo in NEWS file. Pointed out by Norman Shapiro.
Author: David Levine <levinedl@acm.org>
Date: Mon Apr 21 19:00:45 2014 -0500
Added yet another NDBM (gdbm, actually) header/lib pair, for Ralph's
platform.
Author: David Levine <levinedl@acm.org>
Date: Mon Apr 21 13:00:00 2014 -0500
Added mhfixmsg to nmh man page.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun Apr 20 19:01:48 2014 -0400
mhshow.man: fix an incorrect 'mhn' reference
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 20 18:28:21 2014 -0400
Documentation improvements, from Ralph Corderoy.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 20 18:08:47 2014 -0400
Move clsfolds() before the call to context_save(); that is required
when using private sequences, since seq_save() only moves the sequence
information into the context structure; a subsequent call to context_save()
is required to actually write out the context file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 20 00:02:26 2014 -0400
Sigh. Of course I find another bug after I release RC2. Make sure to
initialize the enclosing CT structure when creating a message/external-body
part.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 18 10:57:27 2014 -0400
Remove support for a "*" in alias files (which would add everyone in
the password file to the alias).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 18 10:44:19 2014 -0400
Remove msh(1).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 18 10:03:27 2014 -0400
Remove mhtest(8).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 18 09:30:22 2014 -0400
Remove conflict(8).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 18 09:20:42 2014 -0400
Remove -queue support to post; it is now officially obsolete.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 18 08:43:37 2014 -0400
Fix the same problem in scan that was fixed in commit
9eb9b47593181a3bf987eeaa0398ab5330ec12f8, but fix it for Maildir
support. Patch from Eric Gillespie.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 17 19:55:19 2014 -0500
Unset MAILDROP in test/common.sh so that it doesn't confuse
test/inc/test-msgchk.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 16 11:46:55 2014 -0400
Sigh. Mention that we have to do both a "git push" and a "git push --tags".
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 16 11:44:48 2014 -0400
Mention release branchpoint tagging.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 15 21:57:30 2014 -0500
Fixed popsbr.c to look like its nmh 1.5 version, except it now
uses nmh_get_credentials() instead of ruserpass() directly. Also,
added checks of return values of nmh_get_credentials() to smtp.c.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 15 21:10:41 2014 -0500
Consistently refer to $HOME/.mh_profile and mh-profile(5) in
the man pages.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 15 20:58:32 2014 -0500
Reworked retrieval of username and password with SMTP and sasl so
that if getusername() and no password are accepted by the mechanism,
then the user need not provide them.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Apr 15 21:39:38 2014 -0400
docs/contrib/ml: add a runtime check for known bash-ism
i'm leaving the #! line as /bin/bash, because that's how i wrote
and tested. but with this change i think the script will still
function correctly on a wide variety of shells.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 14 21:32:41 2014 -0400
It turns out that due to the changes to m_getfld() to support file
position tracking, this broke the scan output from inc(1) when POPing
more than one message at a time. Since a new filehandle was being
passed to each call to scan(), it made the most sense to simply
discard the m_getfld() state for each call to scan() when doing POP.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon Apr 14 12:29:39 2014 -0400
replyfilter: flesh out the configuration instructions
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 14 11:58:54 2014 -0400
Updating release notes for new release.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 14 09:57:59 2014 -0400
Update for post-1.6.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 23:09:54 2014 -0400
Update these a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 23:07:45 2014 -0400
Add README-iCalendar to the distribution.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 23:02:57 2014 -0400
Update developer documentation to match reality.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 22:37:53 2014 -0400
If attaching a "message" content type, scan the content to see if it
has 8bit characters and set the CTE on the enclosing MIME headers
appropriately.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 22:36:34 2014 -0400
Create a default CTE so routines in mhparse.c are happy.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 22:17:23 2014 -0400
Make sure the draft filename ends up in the MIME structure, so error
messages have the proper name in them.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sun Apr 13 16:18:07 2014 -0400
add rmf(1) and folder(1) to one another's SEE ALSO sections
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 13 15:13:21 2014 -0500
If mhfixmsg's call to convert_charset() fails, output why.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 13 13:11:00 2014 -0400
If c_termproc is set, include a default display command so the charset
conversion pipeline will work correctly.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 11 17:20:02 2014 -0500
Fixed showproc for RFC 822 messages. Thanks to Mikhail for
pointing this out.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Apr 11 15:55:54 2014 -0400
mhshow: properly report the name of a failing display program
otherwise it's not clear what didn't work.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 10 21:21:28 2014 -0500
If -[no]concat is given to show(1), have it use showmimeproc instead
of showproc and pass those switches along. This way, show won't pass
them to mhl, which doesn't accept them.
Merge: 4c827930 236a2b64
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 18:49:18 2014 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 18:47:43 2014 -0700
Add a note about devel/autotools as a pre-req for building on FreeBSD.
Be a bit more specific about the versions of some OSes we build
in the buildbot cluster.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 10 21:45:14 2014 -0400
Use a dynamically-allocated buffer for character set conversion, and
resize it if we get E2BIG. Also create a test that exercises this
particular problem.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 10 18:58:39 2014 -0400
Don't clobber "cp"; use dp instead.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 10 14:09:18 2014 -0400
Fix bug in error message when reporting character set conversion failure.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 10 12:29:28 2014 -0400
A bad cut-and-paste job made -noinlineonly not work. Patch from
M. Levinson.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 10 12:28:01 2014 -0400
Fix test for inlineonly.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 10 07:52:41 2014 -0500
Added -dump to w3m and elinks invocations in mhn.defaults.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 04:10:34 2014 -0700
When lkfopendata() fails, seqfile is being freed too soon.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 04:00:18 2014 -0700
I missed one spot in getln() where the new quoting flag needs to be cleared.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 03:52:17 2014 -0700
If getln() sees a newline as its first character, it incorrectly
references a character one byte before the start of its input
buffer.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 03:07:16 2014 -0700
Clang's static analyzer reports a potential NULL pointer deref.
This is a "shouldn't happen" case, so I have added an assert
to quell the warning, and catch the failure in the off chance
we do get here with last == NULL.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Apr 10 02:43:36 2014 -0700
Remove dead initialization of fp in main().
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 9 22:04:58 2014 -0500
Added -dump (and -child) to lynx invocation when it's used in
mhshow-show-text/html.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 21:05:07 2014 -0400
Formatting fix, from Mikhail <mp39590@gmail.com>.
Merge: 6e947201 d6e398f9
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 9 19:19:26 2014 -0500
Merge remote-tracking branch 'origin/fix-locking'
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 9 16:32:56 2014 -0500
The size reported by mhshow test-charset is different with and
without iconv, so determine it at runtime.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 9 16:31:06 2014 -0500
Use *ct->c_ceclosefnx() instead of clsoe_encoding() in show_content_aux().
Merge: 1f29440b e6ddebc2
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 16:25:08 2014 -0400
Merge branch 'mhshow-fixup'
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 16:24:34 2014 -0400
Document and distribute mhshow.marker
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 16:16:18 2014 -0400
Document the changes made to mhshow.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 14:53:00 2014 -0400
Change from "concat" to "concatsw" so we don't conflict with the
function concat().
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 13:30:42 2014 -0400
Add new flags for -concat/-noconcat, -inlineonly/-noinlineonly, and
-textonly/-notextonly;
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 13:15:28 2014 -0400
Change things so we only supply a form filename; most programs don't do
both, and this isn't work the extra hassle.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 9 11:29:32 2014 -0400
Now only display text and inline content by default.
Use mh-format(5) to display marker text for skipped content.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 8 21:34:20 2014 -0500
lkopen_dot() would block forever if another process held a lock
forever. Changed it to only retry for 60 seconds, like the other
lkopen's. And have it indicate that it failed to acquire the lock.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 6 13:55:27 2014 -0500
Instead of relying on errno to determine if locking failed, pass
back explicit indication in int * argument to lk(f)opendata() and
lkopenspool().
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 6 11:12:14 2014 -0500
Don't ignore return value of lkfopendata(), most notably of
seq_read() in folder_read(). Increased LOCK_RETRIES from 5 to 60.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 4 20:05:51 2014 -0500
Update context and sequences before showing messages in mhn(1),
just like in mhshow(1).
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 3 18:12:56 2014 -0400
Moving closer to fixing mhshow completely. Includes fix from David Levine
for a slight bug in charset conversion.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 25 22:41:13 2014 -0400
Start of changes for mhshow; compiles, but does nothing (yet).
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 23 08:43:56 2014 -0500
mhn.defaults.sh really doesn't need to look in /usr/demo/SOUND
for helper programs any more. If the user has it in their PATH,
it will anyway.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 23 08:30:37 2014 -0500
Added mhshow-show-application/pdf detection to mhn.defaults.sh.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 23 08:00:12 2014 -0500
Note that order is preserved for messages that have the same date,
when sorting on dates.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 21 18:53:26 2014 -0400
Move pidcheck() into mhshowsbr.c (the only consumer of it) and make
it static.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 21 14:22:58 2014 -0400
Remove support for -pause/-nopause switches to mhshow(1). This and
commit 4c436246f048635446353dadaa68174445c58160 are based on work
originally done by Markus Schnalke.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 21 12:56:37 2014 -0400
Remove support for parallel content display. This means we can finally drive
a stake in the heart of the horrible xpid global!
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 20 09:40:01 2014 -0500
Fixed quoting of charset value in mhn.defaults.sh.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 16 15:03:37 2014 -0500
Renamed mkstemp(1) man page to mh-mkstemp(1), so it doesn't obscure
any existing mkstemp(3) page.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Mar 16 12:19:54 2014 -0700
Update the manpage style guide to be consistent about setting program names in
boldface always.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 16 10:40:27 2014 -0500
Fixed formatting of program name in mh-mime(7) man page. Removed
CONTEXT section from mkstemp(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 16 10:15:41 2014 -0500
Moved "mhparam iconv" description to mhparam(1) man page and put
references to it in mh-mime(7), mhfixmsg(1), and mhshow(1) man pages.
Updated mhparam man page description of other configuration
parameters. Added "Message Rewrite" section to mh-mime page.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 14 20:25:06 2014 -0500
Fixed some of the issues noted by clang --analyze with
mhfixmsg.c and mkstemp.c.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 14 20:22:07 2014 -0500
Fixed fixup of sbr/dtimep.c with flex 2.5.36.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 14 19:56:38 2014 -0500
Modified probe to output sbr/dtimep.c. The flex version is 2.5.36.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 14 19:16:23 2014 -0500
Added probe to configure.ac to output flex version (for fed18arm7 build).
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 14 19:04:45 2014 -0500
Compare character with EOF using signed comparison because
EOF can be (and is likely) negative. This showed up on
arm7, which apparently uses unsigned char for char.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 14 15:22:12 2014 -0400
Sigh. Make localmbox work even if we're not using -debug.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 14 15:21:49 2014 -0400
Whoops, missed a warning groff found.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 14 14:59:39 2014 -0400
Fix some typos and make some style changes suggested by Ralph Corderoy
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 14 12:31:23 2014 -0400
Add support for printing iconv and localmbox.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 13 15:53:05 2014 -0400
Update for mh-mime.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 13 15:51:32 2014 -0400
Create new mh-mime man page, with overview of how MIME handling works in nmh.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 13 15:11:22 2014 -0400
Update and fix some formatting issues.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 10 20:26:51 2014 -0500
Fixed test-mkstemp to work on platforms that don't have mkstemps(3),
such as CentOS 5.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 10 20:24:46 2014 -0500
Check for text/html display programs in this order: w3m, lynx, elinks.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 7 12:04:46 2014 -0500
Fix minor typo.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Mar 7 09:05:17 2014 -0800
Import Dave Crocker's brief history of email development at Rand.
(Added with his permission.)
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 20:32:14 2014 -0600
Fixed test/getcwidth.c to build without MULTIBYTE_SUPPORT.
Found by cppcheck.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 20:15:45 2014 -0600
Fixed a few very minor issues that cppcheck noticed.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 19:46:30 2014 -0600
Removed declaration of unused sm_reply from post.c.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 19:45:37 2014 -0600
Made a couple of globals static in smtp.c.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 19:43:47 2014 -0600
Changed unused symbol that gen-ctype-checked creates with NDEBUG
from a data object to a function, to remove a global from libmh.a.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 19:39:10 2014 -0600
Added remedy for compile warnings when built with --with-tls on
Mac OS 10.7 or later.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 6 19:35:22 2014 -0600
Remove backup file at end of test-ext-params, and a temp file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 6 15:45:19 2014 -0500
Put in check so "attach" is rejected when the draft already has MIME headers.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 6 15:31:01 2014 -0500
Update test to match reality
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 6 15:25:55 2014 -0500
Update documentation to match reality.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 6 14:59:35 2014 -0500
Prevent crash if editfile() is called and both "*ed" and editsave
are NULL. This can happen if you call "mime" and then run "edit" without
any arguments, if you're running whatnow standalone.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 6 14:34:34 2014 -0500
Remove unneeded assignment.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 23:31:31 2014 -0500
Fix up some warnings and problems when iconv doesn't exist.
Merge: 7b9cb49c 5c3a50d7
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 23:17:17 2014 -0500
Merge branch 'extended-params'
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 21:27:25 2014 -0500
Update pending-release-notes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 21:26:02 2014 -0500
More tests for extended-parameter parsing.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 18:22:56 2014 -0500
Add extra argument to add_param() so it can use the passed-in pointers
directly without making copies first.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 15:43:33 2014 -0500
A more complicated RFC 2231 parsing example.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 15:42:59 2014 -0500
Whoops, a little TOO hasty on the last bugfix; put back an assignment.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 15:11:54 2014 -0500
Switch over to using the token parser instead of isspace(), and
make sure we have our pointer correct when doing an encoded parameter
that isn't the first one.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 14:36:43 2014 -0500
Move language tag parser into the block so it only gets
invoked on index 0.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 14:04:47 2014 -0500
Change disposition output slightly.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 13:48:45 2014 -0500
Update information to mention RFC 2231.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 13:40:13 2014 -0500
Add message/external-body test.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 5 13:03:30 2014 -0500
Update mhlist and other relevant utilities to output disposition information
with a new -disposition switch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 4 23:44:09 2014 -0500
Some tests for RFC 2231 decoding; seems like it works, but need to stress
it some more.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 4 23:43:26 2014 -0500
Fix up some error reporting, and reassemble partial parameters correctly.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 4 22:49:13 2014 -0500
Fix up a few pointer mishaps; this should now get everything right!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 4 22:37:10 2014 -0500
Whoops, forgot to set the name element of the partial parameter structure.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 4 19:53:23 2014 -0500
A few minor fixups; the parser now passes the test suite!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 4 13:45:19 2014 -0500
Fixes for the MIME parser; kinda works for regular parameters, but
still needs some fixes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 3 21:52:35 2014 -0500
More work on extended parameter parser. Does not compile yet.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 3 07:14:09 2014 -0800
In test/common.sh.in trap, cd to $MH_TEST_DIR before trying
to remove its Mail subdirectory. rm on Solaris won't remove
it if it's in the path of the current working directory.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 3 00:43:46 2014 -0500
Make parse_header_attrs() a private function (there are no longer any
public consumers of it).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 3 00:42:56 2014 -0500
Convert unqp() to decode_qp(), and make it a public function. Also,
handle the case where decode_qp() is passed a character outside of
the normal ASCII range.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 2 22:38:57 2014 -0600
Added mkstemp(1), wrapper around mkstemp(3)/mkstemps(3), to
auxexec, for use by mhmail.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 2 20:29:20 2014 -0600
Added convenience function die() to mhmail.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 2 21:04:55 2014 -0500
Switch over get_ctinfo() to determine the filename based on the filename if
one was not provided. Remove some unneeded functions as part of this work.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 2 12:00:13 2014 -0600
Added recommendation to use nmh-storage profile setting or
non-default -clobber with mhstore -always.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 2 10:09:18 2014 -0600
Added check of -noverbose to test-mhstore.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 2 09:30:01 2014 -0600
Added commented explaining use of ci_attrs[0] in
build_multipart_alt() of mhfixmsg.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 2 00:07:10 2014 -0500
Whoops, forgot to TEST THIS OUT first.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 2 00:06:13 2014 -0500
For some reason viamail listed mhoutsbr as a dependency. It turned out it
wasn't required, so we removed it so we don't have to pull in a complete MIME
parser into viamail.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 1 23:51:19 2014 -0500
More cleaned and conversion to the new parameter API.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 1 23:24:47 2014 -0500
Add a new get_param_value(); redo iconv() parameter conversion code.
Start having code use get_param() and get_param_value() rather than
walking the whole parameter linked list.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 1 13:55:24 2014 -0600
Removed recommendation from mhstore man page that users not put
-auto in their profile. Added recommendation that users not use
the %a escape string.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 1 13:30:50 2014 -0600
Added description of switches.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 1 12:00:18 2014 -0600
mhstore(1) now obeys its -noverbose switch.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 1 08:32:20 2014 -0600
Fix to commit a2806483a53fcdb62ca8e2bec4f4e023355f4470
to properly handle quoting when text follows quoted
text in a mhshow display string.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 1 08:30:27 2014 -0600
Moved discussion when no messages are matched from BUGS section
to new subsection under DESCRIPTION, per Ralph's suggestion.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 28 22:59:09 2014 -0600
Removed a couple of unnecessary vector typedefs from h/mh.h.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 28 22:05:37 2014 -0600
Updated MACHINES and SPECS/nmh.spec to reflect packages
available for CentOS Linux.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 27 21:43:18 2014 -0500
Fix iconv return value test warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 27 21:38:09 2014 -0500
Support complete encoding for encoding Content-Type parameters. Start
work on retrieving parameters and converting them to the correct charset.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 27 11:50:33 2014 -0500
Use RFC 2047 encoding for Content-Description, and make sure to encode
MIME parameters correctly when building the Content-Disposition header.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 26 22:58:26 2014 -0500
Re-do length calculation for parameter output, and adapt test for new code.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 26 21:48:29 2014 -0600
Fixed quoting of filename, expanded C-T parameter values, etc.,
in mhshow. Removed the workarounds that had built up when it
was broken.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 26 21:13:30 2014 -0500
Closer, but not quite right yet.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 26 19:58:43 2014 -0600
Updated mhparam, man pages, and test-mhparam to reflect split
of locking methods into datalocking and spoollocking.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 25 21:31:18 2014 -0500
Add test for long + encoded line; does not pass right now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 25 21:30:52 2014 -0500
Make sure we include space in the list of characters we need to encode in
a parameter line.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 25 21:28:45 2014 -0500
Remove unused variable, and make sure we free c_dispo_type.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 25 21:15:51 2014 -0500
A new test for longer lines.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 25 21:14:51 2014 -0500
Calculate "characters to use in for current line" based on starting a new
line, rather than the number of characters in the previous line.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 25 15:23:56 2014 -0500
First basic test of extended parameter output: working!
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 24 21:34:12 2014 -0500
Beginnings of test suite for RFC 2231 support; does not work yet.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 24 20:18:17 2014 -0600
Fixed m_getfld() to not return EOF indicator, so that files need
not end with a newline.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 24 13:39:19 2014 -0500
Make sure we don't modify the original text when processing the disposition
header.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 23 18:52:52 2014 -0600
Added mh-folders to nmh(7) man page. Split out Formats section of
nmh man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 23 21:29:52 2014 -0500
Fix up error reporting for the hook code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 22 00:07:55 2014 -0500
It compiles now! And actually sort of works, but still a LOT more
that needs to be done before it is complete.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 21 14:49:07 2014 -0500
Getting closer to getting something working.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 20 14:55:01 2014 -0500
More work on handling encoded params; still does not compile.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 19 22:01:45 2014 -0600
Cast argument to isspace() to unsigned char instead of int.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 19 21:55:19 2014 -0600
Fix to commit ed3214f1518b36c8b96a1a17be4af0a708ea25e3
to not try to quote filenames in multipart parts.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 19 21:36:16 2014 -0600
Generalized %{charset} display string escape to any Content-Type
parameter. Also, always quote the expanded value, whether or not
the escape was quoted in the profile.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 19 20:09:28 2014 -0600
Added reason to mhfixmsg's printout when it fails to decode binary
content.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 19 18:57:29 2014 -0600
Refined commit ed3214f1518b36c8b96a1a17be4af0a708ea25e3 to only
accept single quotes wrapping %f and %F display escapes.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 18 21:26:52 2014 -0600
Migrated show_content_aux2() to argsplit().
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 18 21:16:06 2014 -0600
Removed redundant quoting of %f and %F in display strings. Now,
the code checks to see if those escapes are quoted before quoting
them. Removed quoting of them in mhn.defaults.sh because it isn't
(and wasn't) necessary.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 18 19:16:39 2014 -0600
Removed leading "exec " inserted in show_content_aux2(), which
allows use of shell expansion on Content-Type parameters in
mhshow display straings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 18 12:38:06 2014 -0500
Fix for bug #41618: Supply charset to w3m when converting text/html parts.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 18 07:54:37 2014 -0600
Silenced warnings when built without iconv.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 16 15:25:34 2014 -0600
Added MH libdir to PATH in test-textcharset because it uses ap.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 16 14:12:15 2014 -0600
Removed remaining TMP relics missed with commit
d046c8f0992fddcd69f2172a6607a14dec3b1251. Also, have mhmail clean
up a .orig tmp file, now that it always uses mhbuild.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 16 13:12:39 2014 -0600
Added support for %{charset} display string escape to mhshow(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 16 11:30:41 2014 -0600
Factored out duplicate code into parse_display_string() function.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 16 10:26:34 2014 -0600
Instead of printing PostScript attachments, by default, from mhshow,
try to find a suitable viewer.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 16 10:06:47 2014 -0600
Added associations to mhn.defaults.sh from
http://technet.microsoft.com/en-us/library/cc179224.aspx.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 12 15:41:39 2014 -0500
More extended parameter work. Still non-functional.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 12 15:41:04 2014 -0500
Move contains8bit() to a common file, and make it a bit more general.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 11 23:17:00 2014 -0500
Beginnings of RFC 2231 support. Does not compile (yet).
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 10 23:17:28 2014 -0600
Removed the -[no]textcharset switches that were added to mhshow(1)
in commit 721b0395fb2fceac4e66fed1009ed2f17fd5351f. They weren't
needed. So the net effect is that, if built with iconv, mhshow
will attempt to convert text/plain content to match the user's locale.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 9 12:52:28 2014 -0600
Use test_skip in test-textcharset if not built with iconv.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 9 10:32:46 2014 -0600
Need to set locale to something other than UTF-8 on Cygwin for
the first couple of checks in test-textcharset.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 9 09:59:23 2014 -0600
Removed potential buffer overflow from ruserpass(). It had been
there a long time. Also, move the tokval buffer from global data
to the stack.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 9 09:58:00 2014 -0600
Added -[no]textcharset switches to mhshow(1). These only apply if
nmh was configured with iconv(3) support. If -textcharset is not
used, mhshow will convert, if necessary, the charset of text/plain
content to match the user's locale setting.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 9 09:05:14 2014 -0600
Use $MH shortcut for the profile in a few of the tests.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 9 08:56:42 2014 -0600
In test-mhfixmsg, look at configuration to see if iconv is enabled
rather than detecting it from test output.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 8 22:23:17 2014 -0600
Remove mhbuild backup files at end of a couple of tests, if successful.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 8 21:38:18 2014 -0600
Changed "codeset" to "charset" for (and in) mhfixmsg. Also
cleaned up some comments in mhshowsbr.c.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 8 11:11:25 2014 -0600
Moved upcase(), update_attr(), content_charset(), and
convert_charset() out of mhfixmsg.c so that other programs can
use them.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 7 15:53:35 2014 -0500
Start of changes to support extended parameter parsing and decoding.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 5 13:05:21 2014 -0500
Fix uninitialized variable warning
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 5 11:02:01 2014 -0500
Adjust the quoted-printable output routine to continue when the end of
the buffer is reached, rather than adding a soft line break.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 15:09:12 2014 -0500
Add test for -maxunencoded.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 14:54:16 2014 -0500
A few more C-T-E tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 13:36:29 2014 -0500
Still more CTE tests to cover (hopefully) all of tbe base64 cases.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 13:34:22 2014 -0500
More CTE tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 12:38:34 2014 -0500
More fixes (and tests) for the base64 encoder.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 11:49:49 2014 -0500
Add a new base64 CTE test.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 4 11:19:24 2014 -0500
Fix encoder so at least one case of LF -> CR LF conversion happens correctly.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 3 22:48:38 2014 -0600
Reordered a bit of code in signal handler. Noted in comment that
NetBSD doesn't have mkstemps(3).
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 3 21:42:44 2014 -0600
Use rename(2), not link(2), in m_mktemps() if mkstemps() is not
available.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 3 21:46:33 2014 -0500
Add a new (but incomplete) test for mhbuild's new functionality.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 3 21:46:08 2014 -0500
Fix up mhbuild so the character set is always output when needed, even
when the CTE is specified.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 3 21:45:41 2014 -0500
Document changes to mhbuild.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 3 20:14:55 2014 -0500
Support for selectable Content-Transfer-Encoding.
Now default to 8bit for CTE for text types.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 2 22:34:14 2014 -0600
netbsd uses flock by default for mail spool locking, as reported
by Robert Elz. Use *netbsd* to also include knetbsd, though I
don't know for sure that it uses flock.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 2 22:16:25 2014 -0600
Restored setuid/setgid to slocal: it needs them when run as root,
as a mail delivery agent.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 2 16:45:23 2014 -0600
Removed some unused code that forked /bin/mkdir to make a new
directory if an the effective and real uids differed. There are no
setuid executables in nmh.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 2 09:58:45 2014 -0600
Removed all unnecessary setuid/setgid calls. Using setuid as an
example and not showing the setgid analogues:
1) setuid(getuid());
This dropped privileges before an exec and is normally a
good thing. Except here, the return value isn't checked.
And, we don't have any setuid programs in nmh now, so it was
unnecessary.
2) if (geteuid() == 0) setuid(pw->pw_uid);
This would have been a security hole if the executable was
setuid root because the user specifies the source of the pw
data. This was in slocal(1), which is not setuid, so this
was certainly not needed.
3) setuid(geteuid());
This was in post(8) for when it called the sendmail
executable directly (-mts sendmail or -mts sendmail/pipe.
It's not necessary with modern sendmail or replacements.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 2 08:46:25 2014 -0600
Added m_mktemps(), which creates a temporary file with a specified
suffix. It uses mkstemps(3) where available, which should be most
modern platforms. If not available, it tries link(2), and if that
fails, rename(2).
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 1 16:13:00 2014 -0500
Change mhstore test slightly to test canonical line ending handling for
text MIME parts that are encoded with base64.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 1 15:57:49 2014 -0500
Document changes to base64 encoder/decoder.
Merge: 32355995 d722ee2a
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 1 12:48:20 2014 -0500
Merge branch 'base64-text-fixup'
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 1 11:32:53 2014 -0600
Removed set +e where not needed in test-mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 1 11:24:16 2014 -0600
Fixed test-mhfixmsg check attempted -decode of binary text to
work with the fixed base64 decoder.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 1 10:11:08 2014 -0600
Added note that suffixes were removed from filenames of temporary files.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 1 10:09:13 2014 -0600
Look for w3m if lynx isn't available for mhshow-show-text.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 1 10:11:08 2014 -0600
Added note that suffixes were removed from filenames of temporary files.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 1 10:09:13 2014 -0600
Look for w3m if lynx isn't available for mhshow-show-text.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 31 15:53:04 2014 -0500
Fix base64 to handle text parts properly; currently this breaks mhfixmsg,
and I'm not sure why yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 31 15:00:57 2014 -0500
Add -width when appropriate for this test.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 29 15:56:01 2014 -0500
Beginnings of selectable CTE; allow specification in mhbuild directives,
but it doesn't do anything quite yet.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 28 21:36:05 2014 -0600
Unset LANG, LC_ALL, and LC_TYPE in common.sh so that the tests
don't accidentally rely on any of the user's settings.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 27 18:56:20 2014 -0600
mhl() needs to set invo_name, too.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 27 12:53:03 2014 -0600
WhatNow needs to set invo_name so that switches are interpreted properly.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 26 11:57:29 2014 -0600
No longer look at TMP environment variable for temporary file storage.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 26 11:26:11 2014 -0600
Merge branch 'tmpfiles'
Merge: 14683594 dd259aa5
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 26 11:23:53 2014 -0600
Merge branch 'tmpfiles'
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 25 10:50:29 2014 -0600
Added unregister_for_removal(0) calls to the couple of children
that don't exec() or _exit() after fork().
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 25 10:04:19 2014 -0600
Replaced nearly all unlink(3) calls with m_unlink().
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 25 09:26:13 2014 -0600
Restored the unlinks of temporary files immediately after their
creation in rcvtty.c, now that we have m_unlink().
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 25 09:15:05 2014 -0600
Replaced boilerplate at beginning of each nmh program with new
nmh_init() function. It sets up an atexit() function and signal
handlers so that all temporary files are removed when the program
terminates, however that happens. It relies on a call in m_mktemp()
to register each temporary file for removal. See new "nmh temporary
files" section in README.developers and comments in m_mktemp.c.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 24 21:10:03 2014 -0600
Removed 3 renames of temporary files in mhparse.c. They added
unnecessary filename extensions to the temp files. They weren't good
from a security standpoint and added a failure mode.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 24 20:29:38 2014 -0600
Replaced use of mkstemp() with m_mktemp() in lock_file.c.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 24 13:17:56 2014 -0500
Move uip/attach.c to sbr/mime_type.c; it was used by enough programs
that it deserved to be in libmh.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 24 12:38:03 2014 -0500
In my over-eager trimming I didn't realize the fallback code that
used the mhshow-suffix configuration information to determine the
MIME type was removed; put that back into mime_type().
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 23 22:16:34 2014 -0600
Replaced use of mkstemp() with m_mktemp2() in header_fd() of
rcvtty.c. It never would have worked, anyway, because it had 5
instead of 6 X's in the template.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 21:48:24 2014 -0500
Switch from volatile char * to the more correct char *volatile.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 23 19:58:41 2014 -0600
Separate export from assignment in test-dist and test-attach.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 14:55:21 2014 -0500
Whoops, forgot to initialize the linked list next pointer to NULL.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 14:55:06 2014 -0500
Make sure we include tiny.jpg we need for the test suite.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 14:40:44 2014 -0500
Try to suppress warnings from changes (but why is this thing complaining
about drft being clobbered now??)
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 14:24:35 2014 -0500
Hm, maybe I can't put environment variable assignments in front of
functions?
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 14:01:53 2014 -0500
Whoops, forgot a newline.
Merge: 05b74a00 18a36943
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 13:35:31 2014 -0500
Merge branch 'mhbuild-always'
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 13:35:03 2014 -0500
Document changes to mhbuild and send.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 00:34:18 2014 -0500
Garbage collect unused code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 00:32:18 2014 -0500
Remove automimeproc functionality; it's redundant now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 00:31:55 2014 -0500
Update the pending-release-notes for changes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 23 00:07:54 2014 -0500
Flesh out test-attach, and set it to run as part of the test suite.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 22 18:59:07 2014 -0500
Fix mhmail so it works with the new world order.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 22 15:22:07 2014 -0500
Convert whatnow over to using the new Attach header.
Mark the old -attach switches as deprecated (and make them not show
up in help). Still more documentation cleanup to do.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 22 12:06:49 2014 -0500
Fixed this to use Attach instead of Nmh-Attachment.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 21 22:09:49 2014 -0600
Added svector_find() function.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 21 22:35:35 2014 -0500
Make viamail read the user's profile; this is required because sendsbr()
wants to call mhbuild, which can be overridden via the user's profile
(which is required for the test suite to work).
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 21 20:55:57 2014 -0600
Always check that mktemp()/mktemp2() succeeds before trying to
use result. And if it fails, have the error message report
the directory where the failed temporary file creation occurred.
And, removed all chmod()'s of temporary files created by mktemp()/
mktemp2() because they set the umask to 077 before calling mkstemp(3).
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 21 20:51:00 2014 -0600
Expose get_temp_dir().
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 21 20:50:11 2014 -0600
Enable asserts when debug is enabled, in build_nmh.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 21 20:12:29 2014 -0500
Fix a bunch of tests for the mhbuild changes; still more to do.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 20 21:08:47 2014 -0600
Replaced use of m_mktemp() with m_mktemp2() so that tmp files created
by attach, burst, mhbuild, and post will be in the directory specified
by the first non-null of {MHTMPDIR, TMPDIR, TMP, MH Path directory}.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 20 21:07:08 2014 -0600
Removed remaining occurrences of char *tmp from uip/mh* programs.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 20 20:53:10 2014 -0600
Expanded mhpath(1) man page discussion of its handling of out-of-range
message numbers, and fixed a couple of formatting glitches.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 20 10:52:07 2014 -0600
Use LC_ALL instead of LC_CTYPE in test-pick because LC_ALL has
precendence.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 20 10:31:16 2014 -0600
Fixed three LC_ALL settings:
1) Replaced en_US.ISO8859-1 with C because that's sufficient to show
decoding with an invalid multibyte sequence.
2) Removed redundant LC_ALL=en_US.UTF-8; that is set for the entire test.
3) Removed the last en_US.ISO8859-1 because it hid what the test was
trying to show.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 20 01:27:15 2014 -0500
Remove autoconf checks for nl_langinfo() and langinfo.h
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 20 01:15:55 2014 -0500
Completely deprecate support for MM_CHARSET.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 19 23:21:51 2014 -0600
Removed "tmp" from the uip/mh* programs, so that they no longer
use the nmh-storage profile component for their tmp files. Or
their invoname, but that will be taken care of later.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 19 23:21:32 2014 -0500
Remove the --disable-locale configure option and make locale support
unconditional.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 19 13:47:07 2014 -0500
Document the -dist flag.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 19 11:59:25 2014 -0500
Change error message so "Unknown error 0" doesn't get printed if there
is an error parsing an address.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 19 11:52:47 2014 -0500
Add a test for dist to make sure it works with headers that need RFC-2047
encoding.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 19 10:48:14 2014 -0600
Updated MACHINES to show package requirements on Linux and Cygwin.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 19 01:11:59 2014 -0500
Add support for not outputting any MIME headers when using dist.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 19 00:50:49 2014 -0500
Allow mhbuild to work when the message body is empty. You know, that
was actually a giant pain!
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 18 23:34:41 2014 -0500
Removed unused argument "file" to user_content().
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 18 01:17:12 2014 -0500
Beginning of work to run mhbuild always. A bit more complicated than I
originally expected.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 18 00:38:39 2014 -0500
Explictly return the exit code, so we can portably guarantee that
pidstatus() will return 0 on a successful command execution.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 17 18:42:52 2014 -0600
Removed -a option from whatnow attach, in anticipation of
removal of send -attachformat.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 17 15:45:31 2014 -0500
Add support for -auto flag to mhbuild.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 17 14:20:12 2014 -0500
Remove WHATNOW #ifdefs; that code was obsolete a long time ago.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 16 21:48:01 2014 -0600
Moved readline check to after termcap/curses check in configure.ac.
This way, $TERMLIB can be included in the readline check. That's
neeed on CentOS 5.9.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 16 19:55:58 2014 -0600
Moved readconfig() of mhn.defaults into construct_build_directive().
This way, platforms that don't define MIMETYPEPROC will display
the proper directive with attach -v.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 14 20:09:40 2014 -0600
Added check to get_file_info() in attach.c for failed fgets() call.
It can happen on Cygwin for mysterious reasons,
http://cygwin.com/faq/faq.html#faq.using.bloda.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 14 19:39:42 2014 -0600
Removed the tests of attach -v -a from test-attach-detach, and
added -prompt '' to try to get the test to pass on Mac OS X.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 14 07:41:28 2014 -0600
Modified last check added to test-scan-multibyte so that it
also works without iconv support.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 13 20:29:19 2014 -0600
Skip the last check that I added to test-scan-multibyte if we don't
have iconv support because it requires converting from ISO-8859-1 to
UTF-8.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 13 20:08:55 2014 -0600
In cpstripped(), check for negative return value from wcwidth().
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 13 14:33:44 2014 -0800
Better fix for test-attach-detach on platforms without readline.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 13 13:35:41 2014 -0800
Fixed build on Solaris by only checking for -Wno-unused-result with gcc.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 12 12:18:47 2014 -0600
Hacked test-attach-detach to pass on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 12 11:45:16 2014 -0600
Final fix to test-attach-detach: on some platforms, there's no
charset for a text/plain file.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 12 11:32:11 2014 -0600
Really fix mode of file that's used in test-attach-detach.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 12 11:26:07 2014 -0600
One final fix to test-attach-detach.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 12 11:22:57 2014 -0600
Fixed test-attach-detach to work with any umask, and without readline.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 12 10:18:20 2014 -0600
Added -v and -a switches to whatnow attach so the user can see
the mhbuild directive that send(1) will use.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 16:30:42 2014 -0600
Refined the POSTLINK used on OpenBSD so that it leaves the warnings,
but capitalizes the "w" so that they don't color the buildbot waterfall.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 16:00:14 2014 -0600
Refined the autoconf test for -Wno-unused-result so that
it's only used where we need it (currently Ubuntu gcc 4.8.1
with -O2).
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 11:22:50 2014 -0600
Calculate port numbers in test suite based on uid so that different
users can run the test suite on a host simultaneously.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 11:02:19 2014 -0600
Updated Cygwin and Linux build notes.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 11:01:21 2014 -0600
Added more .exe files to .gitignore.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 10:15:27 2014 -0600
Work around OpenBSD 5.4 file(1), which reports the --mime-encoding
of text files as "binary".
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 09:22:36 2014 -0600
Reworked attach to add charset to Content-Type string for
text content.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 08:09:20 2014 -0600
Changed how build_nmh deals with older mhparam that doesn't
report SASL/TLS.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 11 08:00:55 2014 -0600
Reorganized autoconf test for -Qunused-warnings so that it
outputs something when configuring on any platform.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 11 01:41:44 2014 -0500
Change test-mhmail so it can handle a MIMETYPEPROC that doesn't output
the character set.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 11 01:11:45 2014 -0500
Switch over to using --mime-type, since --mime seems to include a
charset for non-text MIME types.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 10 23:41:04 2014 -0600
Fixed POSTLINK (on OpenBSD) now that it doesn't use -Qunused-arguments.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 11 00:32:54 2014 -0500
More tests, but not quite there yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 10 13:31:05 2014 -0500
Don't error out if the message body is empty.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 10 23:25:19 2014 -0600
Only add -Qunused-arguments to LDFLAGS if compiler is clang.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 10 20:49:24 2014 -0800
Reworked LFLAGS hack for flex 2.5.35 and 2.5.36 to work on
Ubuntu. And use sed instead of ed.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 10 19:36:34 2014 -0600
No longer add -g or -s to LDFLAGS. autoconf handles -g. And "make
install-strip" is the approved way to install stripped executables.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 10 19:03:56 2014 -0600
Added -Wno-unused-result to silence warnings on Ubuntu.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 10 00:45:38 2014 -0500
Make sure we use the 'short' filename and add newlines where appropriate.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 9 23:17:25 2014 -0500
A bit closer, but don't run the test just yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 9 16:03:21 2014 -0500
Preliminary Attach: header support. Untested just yet.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 8 20:54:50 2014 -0600
OpenBSD 5 needs an other-libraries (fourth argument) to the
AC_CHECK_LIB for SSL_library_init, because it doesn't automatically
append -lcrypto when linking with -lssl.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 8 20:14:57 2014 -0600
Hard-code the config/version.c target, instead of using $@, so its
rule works for the distcheck target with Solaris (System V) make.
distcheck uses VPATH, causes that make to prepend the VPATH to $@.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 8 19:02:58 2014 -0600
Replace use of awk with sed in test-anno because it failed
on Solaris (gawk).
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 8 18:23:10 2014 -0600
Detect whether or not to use -n with tail in build_nmh.
Synched that to uip/mhmail.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 7 22:51:41 2014 -0600
Fixed typo in last commit of test-curses.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 7 22:49:51 2014 -0600
Added -Txterm-color to tput invocations that didn't have it.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 7 22:27:55 2014 -0600
In test-curses, use termcap codes if terminfo capabilities
are not supported, such as on FreeBSD 9.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 7 20:18:52 2014 -0600
Added sbr/dtimep.c to CLEANFILES so that make distcheck passes on
FreeBSD 9.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 7 19:51:58 2014 -0600
Clarified advisory message it test-mhfixmsg if a text browser
isn't available.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 7 23:15:39 2014 -0500
Update this for From, Resent-From, and Envelope-From. Also document
Attach even though the code hasn't been written yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 7 11:45:24 2014 -0500
Prevent message status allocation code from overflowing if we get a
message number that is too high; simply abort instead.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 6 20:49:18 2014 -0600
Replaced hidden make_mime_composition_file_entry() used by attach()
with public construct_build_directive().
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 6 19:14:20 2014 -0600
Here's a better fix for the whatnow tests: set and export
TERM at the beginning of each test so that valgrind can be
supported.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 6 11:30:42 2014 -0600
Removed remaining run_prog's from tests that set an
environment variable.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 6 11:20:47 2014 -0500
Add a test for the new curses-based format escapes.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 5 14:48:18 2014 -0600
Fixed description of send -attach switch in whatnow: its argument
is the header file name, not a filename.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 5 10:01:48 2014 -0600
Removed remaining globals in uip/attach.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 5 09:51:53 2014 -0600
Got rid of a couple of globals used by attach get_line().
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 5 09:39:11 2014 -0600
Moved the functions that implement whatnow attach from
uip/sendsbr.c to new uip/attach.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 5 08:28:58 2014 -0600
In whatnow help, don't show that detached can be abbreviated
with "de", because that conflicts with "delete".
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 4 20:44:21 2014 -0500
Whoops, I'm supposed to NUL-terminate the string, not set the actual pointer
itself!
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 4 14:01:58 2014 -0500
Make sure scan.curses is installed & distributed.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 4 00:59:38 2014 -0500
Support for sending color escape sequences retrieved from terminfo(5).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 15:55:10 2014 -0500
Add support for %(hascolor), and a new function for parameterized
terminfo capabilities.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 14:40:35 2014 -0500
Document %(nodate), and update things a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 11:43:16 2014 -0500
Garbage collect some Autoconf cruft that has been around a lot longer
than necessary.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 11:06:29 2014 -0500
Also make sure outc() uses TPUTS_PUTC_ARG.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 11:05:18 2014 -0500
Whoops, I forgot that AC_CACHE_CHECK calls AC_MSG_RESULT.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 10:44:59 2014 -0500
Create an autoconf test to determine the argument of the tputs() callback.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 09:27:39 2014 -0500
Remove checks for termcap.h and ncurses/termcap.h, since we're not using
those header files anymore.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 00:42:05 2014 -0500
Sigh. Fix up missing conversion from clear->ti_clear.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 00:30:15 2014 -0500
I guess we can't include both termcap and terminfo headers on Solaris.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 3 00:15:56 2014 -0500
include curses.h so this (hopefully) now works on Solaris.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 23:59:57 2014 -0500
Convert all of the terminal functions over to terminfo(5) instead of
the older termcap.
Move the terminal-specific code from fmt_compile.c to terminal.c, so it
is all in one place.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 15:55:33 2014 -0500
Garbage collect unused code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 15:52:49 2014 -0500
Remove baudrate-handing code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 15:04:17 2014 -0500
Always emit an STR instruction for terminal escape sequences, otherwise you
can get unintended results (like printint the previous contents of the str
register, which is almost certainly what you don't want).
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 15:00:46 2014 -0500
Switch from the M-X format for characters with the high bit set to
\xXX instead when printing format strings and other characters.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 14:46:52 2014 -0500
Fix problem with %(putlit) and %(zputlit) causing a SIGSEGV
if str is NULL.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 13:54:07 2014 -0500
Drop support for different behavior on hardcopy terminals. It's 2014,
I'm assuming this is not a valid concern anymore.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 2 11:38:20 2014 -0500
Move the termsbr code into the libmh library, where it belongs.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 1 13:43:51 2014 -0600
Give up on fmt_compile.c for now.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 1 13:21:56 2014 -0600
That didn't work. Try including termcap.h first, instead of
ncurses/termcap.h.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 1 13:18:08 2014 -0600
Changed several globals to be static, to avoid collision,
notably with "filter" in libtermcap.so, on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 1 13:16:48 2014 -0600
Try including termcap.h before curses.h to see if that solves
the tputs() mismatch on Solaris.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 31 15:29:40 2013 -0500
It looks like some systems also need curses.h as well as term.h
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 31 15:20:22 2013 -0500
Add support for outputing a few (limited) terminal attributes in format
sequences. Needs documentation and some expansion.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 31 15:19:21 2013 -0500
Make sure that branching instructions are traced even if we're executing the
branch (previously, they would only be traced if they did not execute the
branch).
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 31 00:13:21 2013 -0500
Change fmttest to use litputs() on str and output buffers during tracing.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 29 08:01:28 2013 -0600
Generalized the valgrind suppression for sendmsg via readLine.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 28 18:24:54 2013 -0600
Added test/valgrind.supp to EXTRA_DIST in Makefile.am so that
NMH_VALGRIND=1 works with make distcheck.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 28 18:23:49 2013 -0600
Removed one run_prog from test-pick because it loses the setting
of the LC_CTYPE environment variable.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 28 11:55:12 2013 -0600
Fixed chmod of temp file in prompter. Noticed by valgrind.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 28 11:54:05 2013 -0600
Null-terminate buffer in mbx_copy() in dropsbr.c. Noticed by
valgrind.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 28 11:51:01 2013 -0600
Added support for running the test suite with valgrind by setting
the NMH_VALGRIND environment variable. To support that, nmh
programs that are invoked in the test suite should be run via
(the new function) run_prog or run_test.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 24 09:02:15 2013 -0600
Have configure print out what it detects for the program to detect
the MIME type string for a file.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 23 15:32:45 2013 -0600
Added "true" to end of flex fixups in configure.ac, in case the
user has hacked flex to not produce the errant code.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 23 15:09:23 2013 -0600
Removed flex fixup for version 2.5.37, it's not necessary with
flex 2.5.37 on Fedora 20.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 18:09:55 2013 -0600
Use --brief option, if supported, with file --mime.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 17:38:59 2013 -0600
In test-mhmail, insert semicolon in output of "file --mime" if needed.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 16:42:34 2013 -0600
file --mime on OpenBSD returns strings such as "text/plain
charset=us-ascii", without an intervening semilcolon. Insert one if
there isn't one.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 16:12:02 2013 -0600
Removed support for file -i, it just spits out "regular file"
on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 16:11:18 2013 -0600
Removed temporary printouts.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 15:30:30 2013 -0600
More debugging statements for OpenBSD.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 15:08:30 2013 -0600
Added debuging printouts.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 15:05:38 2013 -0600
Whooops, gcc on OpenBSD noticed a nasty in the last commit.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 14:42:26 2013 -0600
With whatnow attach, determine the content MIME type that's inserted
into the Content-Type header using file --mime or file -i, if
available on the platform at configuration time. If not, continue to
use the mhshow-suffix- method. Added a mimetypeproc component to
mhparam so that a user can query the configuration.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 14:38:49 2013 -0600
Updated date on a few man pages.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 10:41:09 2013 -0600
Removed temporary probes added in commit
3441b5648a0c21e067c05f428a51bf96352735e7.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 09:02:29 2013 -0600
Added temporary probes to see what file --mime and file -i do on
OpenBSD and Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 22 09:01:41 2013 -0600
Increased size of file command buffer in make_mime_composition_file_entry()
because it was a bit too small.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 14 10:41:01 2013 -0600
Cleaned up setting of CFLAGS in configure.ac.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 14 10:29:33 2013 -0600
Added POSTLINK to remainder of executables in Makefile.am.
Replaced hard-coded sbr/libmh.a with $(LDADD) in LDADD
macro for test/getfullname.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 14 09:51:47 2013 -0600
The buildbot was reporting "warning" on stdin, not stderr.
Escape "warning" so that it doesn't snag it.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 14 08:51:42 2013 -0600
The build failed mysteriously on the OpenBSD buildbot host ("Provide
an AUTOCONF_VERSION environment variable, please"). This was in the
compile, not autogen, phase. Committing trivial change to kick off
another build.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 14 08:37:11 2013 -0600
That didn't quite work, try reducing size of warning filter
temporarily.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 14 08:24:14 2013 -0600
Filter out "often/almost always misused" warnings from OpenBSD linker.
Added POSTLINK macro to configure/Makefile for this purpose.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 13 19:23:27 2013 -0600
Added mention of filename completion at whatnow prompt if nmh
was configured with readline enabled.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 13 19:20:12 2013 -0600
Moved the set -x after the uname and string test in autogen.sh
to reduce build log clutter.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 13 19:12:15 2013 -0600
Generalized -Wel fix in test-manpages of commit
27659f0aa30c07081f7b8647c51a6ca82837e5d1 to apply on
any platform.
Author: Pascal Stumpf <Pascal.Stumpf@cubes.de>
Date: Fri Dec 13 18:57:57 2013 -0600
rand()/srand() are not cryptographically secure PRNGs. Some systems
have the much better suited arc4random() family of functions; there's
no reason to not use it if it is available. Make m_rand() just a
wrapper around arc4random_buf() in that case. (There's no need to
ever seed it manually.)
As a bonus, silences some warnings on OpenBSD.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 13 16:48:02 2013 -0600
groff -man silence the test-manpages warnings. One more try: -Wel.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 13 16:25:24 2013 -0600
Try using -man instead of -mandoc in test-manpages on OpenBSD
to see if it silences the warnings.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 13 15:33:14 2013 -0600
Disable assertions by default.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Dec 13 15:38:58 2013 -0500
Minor autoconf style cleanup.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 20:15:14 2013 -0600
Minor changes to configure.ac:
1) Replaced direct manipulation of NDEBUG with AC_HEADER_ASSERT.
2) Removed unnecessary level of quoting around LFLAGS assignments.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 20:11:42 2013 -0600
Moved all LDFLAGS manipulations in configure.ac to one place.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 18:37:58 2013 -0600
Tweaked rcvtty.c to squelch warnings on OpenBSD. Three of the
four were due to unused artifacts with HAVE_GETUTXENT not defined.
The fourth was due to control reaching the end of non-void
function message_id(), which had an _exit() call at the end.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 18:29:31 2013 -0600
Initialize local child_id in main() of whom.c to squelch warning
from cc on OpenBSD.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 18:27:17 2013 -0600
Squelch warning from cc on OpenBSD that fd argument of usr_pipe() in
slocal.c might get clobbered by vfork() by copying it to a volatile
local.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 18:23:45 2013 -0600
Removed --posix from awk invocation in test-anno.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 12 18:08:01 2013 -0600
It looks like the sed "a" in test-anno didn't emit a trailing
newline on OpenBSD. It does on other platforms. Try using
awk instead.
Author: Lyndon Nerenberg <lyndon@bbsobsd5.bitsea.ca>
Date: Thu Dec 12 11:55:58 2013 -0800
Add buildbot hacks for OpenBSD.
OpenBSD auto{conf,make} want a version specified in the environment
for each of the tools. For now, hardwire this into autogen.sh until
we can figure out a better way of dealing with this.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 11 20:52:49 2013 -0600
Sun Studio cc -V must output to stderr.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 11 20:28:10 2013 -0600
Try 9efa994ecac2790dbc56113f78c464eed1371590 again.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 11 19:47:29 2013 -0600
Undid last commit of temporary printouts because buildbot is down.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 11 17:19:48 2013 -0600
Temporarily add some printouts to configure.ac to see why -v
isn't added to Sun Studio cc on Solaris build host.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Dec 11 10:53:28 2013 -0800
Prefer cc over gcc.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Dec 11 10:42:04 2013 -0800
One more attempt at getting the buildbot $PATH correct on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 19:17:00 2013 -0600
OK, this should work to detect Sun Studio cc.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 19:07:25 2013 -0600
Oops, that didn't work. Disable -v with SunStudio cc for now.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 19:05:32 2013 -0600
OK, use SunStudio cc, if present, on Solaris if user didn't set CC.
And with it, use -v and suppress the statement not reached warning.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 18:45:26 2013 -0600
Suppress E_STATEMENT_NOT_REACHED warning from SunStudio cc.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 18:35:08 2013 -0600
Added -errtags=yes to SunStudio cc options.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 18:22:23 2013 -0600
Removed a bunch of unreachable break statements found by
SunStudio cc -v. Also fixed an "end-of-loop code not
reached" condition in uip/dropsbr.c. That one is significant
because it meant that retries were not attempted when attempting
to open and lock a file.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 16:43:20 2013 -0600
Need full path to cc on Solaris buildbot host, at this point.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 16:16:59 2013 -0600
Try -v with SunStudio cc. Also, try setting CC instead of modifying
AC_PROC_CC to pick up cc on the buildbot Solaris host.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Dec 10 14:05:08 2013 -0800
Remove the Solaris cc hack; the buildbot should have the correct
cc in its $PATH now.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 08:40:59 2013 -0600
Removed +w from SunStudio cc, it caused compilation failure.
Maybe it can only be used with CC.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 08:36:15 2013 -0600
That worked. Now try +w2 with SunStudio cc.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 08:15:22 2013 -0600
Of course that didn't work. Try specifying the SunStudio
compiler in CC.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 10 07:53:14 2013 -0600
That didn't work. Set PATH to pick up SunStudio cc.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 9 23:45:54 2013 -0600
Use SolarisStudio cc if available.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 9 23:20:27 2013 -0600
Added temporary probe to find cc on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 9 18:25:03 2013 -0600
Removed temporary favor of cc over gcc.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 9 18:19:17 2013 -0600
Temporarily favor cc over gcc to try it out on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 23:17:50 2013 -0600
Commit 9c663383ab54e0290781ac1c25d790ce03160e08 introduced
a backward incompatibility to build_nmh. Refuse to support
-y if the current nmh installation has an mhparam that doesn't
support the sasl and tls components.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Dec 8 22:18:46 2013 -0500
Clean up comments, and update information on file locking.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 19:02:28 2013 -0600
Removed dependence of build_nmh on ldd by adding sasl and tls
components to mhparam(1).
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Dec 8 18:05:42 2013 -0500
Fix one of the POP tests to work on wide terminals.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 13:27:33 2013 -0600
Removed temporary diagnostic to determine gcc version on Solaris
buildbot host. It's 4.5.2. 4.6.0 and later return an error
status with an unrecognized option, which we rely on for the test
for -Qunused-arguments. 4.5.2 doesn't. But that option doesn't
produce any errors, just warnings that don't contain "warning".
So ignore it.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 13:16:19 2013 -0600
Added temporary diagnostic to see what version of gcc is
used on the buildbot Solaris host.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 12:50:39 2013 -0600
With the fix of 4929cad323afc87404752a1e88664a7f42cbb737,
prepare_space() no longer needs to insert initial space.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 12:15:18 2013 -0600
Try this sed command for squeeze_lines().
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 11:19:13 2013 -0600
Added -eval 'set document.browse.margin_width = 0' to elinks
command in mhfixmsg-format-text/html in mhn.defaults, to disable
indentation of converted text. Thanks to Rickard Carlsson for
this suggestion.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 10:56:35 2013 -0600
That didn't work, so try this awk command from Robert Elz.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 8 10:29:00 2013 -0600
Fixed squeeze_lines() test function to be compatible with POSIX awk.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 7 20:27:37 2013 -0600
Fixed test-mhfixmsg to work with elinks, which inserted leading
space on a line. Thanks to Valdis for reporting that and to
Ralph for the awk and sed magic to emulate diff -w (and cat -s).
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 7 10:44:31 2013 -0600
Added notes to README.developers about write access to
the git repo and git rebase.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 7 10:39:16 2013 -0600
Replaced hard-coded use of "," with `mhparam sbackup` in
test-header-encode.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 7 09:34:05 2013 -0600
Disable clang complaint about unused -ansi when linking by
adding -Qunused-arguments to LDFLAGS, if supported.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 6 18:56:11 2013 -0600
Removed bash-isms from inc/test-deb359167.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 6 18:43:20 2013 -0600
Skip inc/test-deb359167 on FreeBSD >= 10 because its valgrind
throws a strange error. Code provided by Lyndon.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Dec 6 14:52:03 2013 -0800
test/common.sh.in: use awk to pick off first output field.
md5 and md5sum are inconsistent in their use of SP vs HT as a field separator.
cut(1) can only handle a single field delimiter character; awk is more forgiving.
Merge: 2734ae8b 7d7ed69e
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 22:49:54 2013 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 22:49:49 2013 -0600
Renamed test/getfqdn to test/getcanon.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 5 23:40:44 2013 -0500
I give up for now; revert these debugging commits.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 5 23:28:44 2013 -0500
One final check to make sure the binary isn't stripped
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 5 23:15:57 2013 -0500
Sigh. Make sure the binaries aren't stripped as well.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 5 22:56:57 2013 -0500
Switch to default of -g so hopefully we can get something useful from the
FreeBSD buildbot valgrind output.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 5 22:48:04 2013 -0500
Sigh, I always forget this is errno.h, not sys/errno.h.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 5 21:59:22 2013 -0500
Have getfqdn fall back to printing out the given hostname if the DNS lookup
fails, to replicate the behavior of LocalName().
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 18:38:16 2013 -0600
That didn't work, either. Restoring configure.ac.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 18:35:00 2013 -0600
That didn't work, try adding -pedantic-errors.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 18:10:01 2013 -0600
The linker on FreeBSD 10 doesn't like -ansi. So added a
configure check to not put -ansi in CFLAGS if the linker
doesn't like it. Though may need to add -pedantic-errors.
There doesn't seem to be an easy way to get automake to
not put CFLAGS in the link command.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 17:48:08 2013 -0600
Clean up mhbuild backup files left by test-header-encode.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 08:02:27 2013 -0600
Better fix than commit 605d80e7cf0d02d4bab9387f03b4e1d43177e33e
for test-mhfixmsg: always overwrite HOME environment variable
if mhfixmsg uses w3m.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 5 07:04:51 2013 -0600
Fix to commit 7e40862e6a4da7810a46aa1e28b05e527fdc208a:
only one of the variables should have ICONV_CONST.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 22:25:14 2013 -0600
In test-mhfixmsg, make sure that $HOME is writeable, in case
nmh has been configured to use w3m.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 21:48:04 2013 -0600
Really fixed mhmail.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 21:18:38 2013 -0600
Removed temporary hack.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 21:15:31 2013 -0600
Removed temporary hack to enable debug from configure.ac.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 21:13:55 2013 -0600
Fixed test-mhmail failure on Solaris: its tail doesn't suport -n.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 22:03:23 2013 -0500
Update pending-release-notes regarding removal of the -normalize and
-nonormalize switches.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 21:56:50 2013 -0500
Garbage collect "normalize".
The code to normalize addresses (look up the hostnames in DNS for the
"official" hostnames) was disabled when we made DUMB the default configuration
in 1.5. Since them, the -normalize switch was still around in various
utilities, but it didn't do anything. Remove all of those switches and
garbage collect various other bits of the "normalize" functionality.
At the same time, improve getm() a bit; it now takes an argument specifying
the length of the error buffer.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 20:54:03 2013 -0600
Added temporary diagnostic hack to test-mhmail.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 20:40:59 2013 -0600
The buildbot is up, put in hacks to enable debug and print out hostname.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 20:30:04 2013 -0600
Fixed m_getfld() bug introduced in commit
0c7ac5073c24f01663fadc78b5112c86d52e4452. This bug caused parsing
of messages with long (>= 8K) header field values to fail. The fix
was easy: decrement the counter of bytes read when decrementing the
current read position, in FLDPLUS state.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 20:29:05 2013 -0600
Use ICONV_CONST in declaration of variable that's passed to
iconv(), to quiet warning in FreeBSD 10.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 19:49:36 2013 -0600
Added identifier to each check in test-mhlist to help diagnose
test failure.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 19:38:11 2013 -0600
Added comment about not supporting trailing semicolons
for aliases (in alias file).
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 19:37:00 2013 -0600
Undid temporary hacks, it looks like the buildbot is down.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 4 19:24:57 2013 -0600
Temporarily added a few hacks to diagnose problems found by buildbot.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 18:11:31 2013 -0500
Fix another warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 15:49:52 2013 -0500
A few more tests; I think that's enough for now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 14:29:54 2013 -0500
Fix a few warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 12:57:20 2013 -0500
More tests (but not quite finished yet).
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 12:56:54 2013 -0500
Fix cut & paste mistake.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 12:12:55 2013 -0500
More man page minor fixup.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 11:56:34 2013 -0500
Slightly clarify mhbuild man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 4 11:40:52 2013 -0500
Minor typo fix.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 3 21:57:01 2013 -0500
Note changes to mhbuild.
Merge: 4c1236a0 4fcf75e4
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 3 21:52:30 2013 -0500
Merge branch 'encode-rfc2047'
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 3 21:52:11 2013 -0500
Support for more tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 3 21:36:39 2013 -0500
Whoops, shouldn't use autoincrement with a macro; forgot about side
effects!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 3 15:52:00 2013 -0500
First round of tests! Still want to do more before it gets merged.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Dec 3 15:21:29 2013 -0500
Add support for a -file switch to handle messages that are not in folders.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 23:34:02 2013 -0500
Don't put a space after the trailing semicolon for group termination.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 23:14:47 2013 -0500
Use pref_encoding() to select the default encoding for all headers.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 23:11:27 2013 -0500
Do proper group handling, and fix a bug in the q-p encoder.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 15:49:35 2013 -0500
I think we're very close to get address encoding working, but still have
to test it more.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 13:47:34 2013 -0500
Document a few more things.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 13:41:51 2013 -0500
Since our last caller of getlocaladdr() was removed, garbage-collect this
function.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 2 13:39:34 2013 -0500
Remove code to set the signature buffer; it turns out that with our
refactoring for 1.5, it was no longer used.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 27 12:49:07 2013 -0500
More work, but still stuff to do.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 25 14:06:38 2013 -0500
Fix up a few warnings and problems.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 21 15:59:21 2013 -0500
More work on address portion of RFC 2047 encoder.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 14 15:30:15 2013 -0500
A little bit closer to working for address headers.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 14 11:43:33 2013 -0500
Break out the unquote functionality to a separate function.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 14 10:16:22 2013 -0500
Fix up the unquote test, with help from Lyndon and Ralph.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 13 22:26:09 2013 -0500
Test for unquoting, but it doesn't work yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 13 20:54:48 2013 -0500
Switch fmttest over to using snprintb() instead of the private custom version
we originally cribbed from fmtdump.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 13 20:54:22 2013 -0500
Document snprintb() a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 13 20:54:05 2013 -0500
Actually check the output buffer length all of the time.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 13 15:51:08 2013 -0500
Start work on address header parsing.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 13 11:03:12 2013 -0500
Fix up date mode so it works without providing a format string.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Nov 10 22:46:49 2013 -0500
Document things a bit more.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Nov 10 00:46:23 2013 -0500
A number of bug fixes:
- Fix macro to calculate the number of characters that will fit
within a specified base64 encoding length.
- Refactor code to handle leading spaces, and insert a leading space
correctly after the start of a header.
With all this, it seems to work!
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Nov 9 14:27:12 2013 -0500
Don't increment the buffer pointer for the NUL string terminator; this
lets us concatenate new text on the end of the current output buffer.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Nov 9 10:39:48 2013 -0500
Add support for -changecur and -nochangecur to mhlist(1).
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 7 22:44:13 2013 -0500
A little closer, but still has problems.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 7 22:43:50 2013 -0500
Fix handling of -headerencoding switch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 7 16:02:14 2013 -0500
Getting closer to getting base64 header encoding working.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 3 12:36:10 2013 -0600
Removed spurious space before a period in rcvpack man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 3 12:34:12 2013 -0600
Cleaned up the "stripped CRs" mhfixmsg verbose message.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 31 11:51:52 2013 -0400
Beginning stubs to support base64 header encoding.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 31 11:37:52 2013 -0400
Support the -headerencoding switch to select the header encoding algorithm.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 31 11:36:46 2013 -0400
Switch to the (correct) casting of char to unsigned char for is*() macros.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 30 20:44:19 2013 -0400
Fix some space calculation/whitespace handling bugs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 30 15:32:03 2013 -0400
Fix qpspecial() macro test, and do proper casts to handle signed chars.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 30 14:04:16 2013 -0400
It looks like simple quoted-printable encoding of headers works!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 29 22:52:06 2013 -0400
Remove unused argument.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 29 22:42:51 2013 -0400
Fix up a few miscalculations.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 29 15:58:35 2013 -0400
A hopefully-functional quoted-printable encoder
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Oct 28 14:44:30 2013 -0400
Test to make sure mhshow is actually invoking a charset conversion
program if one is defined.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Oct 27 22:31:50 2013 -0400
Fix bug found by LLVM.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Oct 27 22:31:35 2013 -0400
Fix up warnings reported by LLVM.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 27 08:57:55 2013 -0500
Interpret a full path argument to mhfixmsg as a filename, not
a message.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Oct 23 14:40:02 2013 -0400
A little tiny bit closer to working.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 11:24:34 2013 -0500
Success! Clean build on the buildbot Solaris11 host.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 11:04:52 2013 -0500
Ooops, fixed typo in configure.ac.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 11:02:47 2013 -0500
See if this cleans up the Solaris build on the buildbot.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 10:47:23 2013 -0500
More probing: print out sbr/dtimep.c.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 10:20:49 2013 -0500
OK, Solaris on the buildbot uses flex 2.5.35.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 10:16:31 2013 -0500
More probing: added flex -V.
Author: David Levine <levinedl@acm.org>
Date: Wed Oct 23 09:57:16 2013 -0500
Added back an enhanced hack to configure.ac to try to diagnose
the flex 2.5.36/.36 bug workaround. Changed test-dist a bit
to help isolate where it just failed. (My last commit message
was incorrect: it was test-dist that failed, not test-comp-format.)
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 22 22:54:08 2013 -0500
Reverted commit 9caa7da143644ed93c6ba6351f48fa1327ad4392
because it didn't solve the problem on Solaris, and
apparently broke test-comp-format, though I don't see how.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 22 19:46:51 2013 -0500
Added hack to configure.ac to work around bug in flex 2.5.36 and
2.5.37 that prevents the builds from being completely green.
According to http://sourceforge.net/p/flex/bugs/140/, this should
be fixed in the next release of flex. The hack is confined to
just configure.ac so it'll be easy to remove.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Oct 21 23:51:57 2013 -0400
Minor comment update.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Oct 21 16:01:02 2013 -0400
Start of RFC 2047 encoding code. Not complete in the slightest.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Oct 21 12:48:23 2013 -0400
Some comments describing the MIME structures.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 19 09:58:14 2013 -0500
Added volatile qualifier in a couple of places to get rid of
"might be clobbered" warning from when -Wno-clobbered isn't
supported. And I removed the check for Wno-clobbered from
configure.ac. It's no longer needed on any of the platforms
I use, we'll see if others need it.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 19 09:19:58 2013 -0500
Allow mhfixmsg to strip carriage returns from ISO-8850, UTF-8,
and Windows-12xx text, in addition to ASCII.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 19 09:17:22 2013 -0500
Added docs/README-iCalendar.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 17 22:03:07 2013 -0400
Implemented -build switch for comp, at the request of the MH-E developers.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 17 21:44:52 2013 -0400
Minor comment cleanup.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Oct 17 15:43:15 2013 -0400
Update the mh-sequence(5) man page with details of the format of the
sequence file. Also mention that nonexistant messages will be removed
from sequences.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 15 20:21:32 2013 -0400
Add locking support to the version of the sequence file reading code used
by the "new" command. Based on a patch by Harvey Eneman.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 15 15:02:18 2013 -0400
Remove support for NOPUBLICSEQ.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Oct 15 14:48:19 2013 -0400
Remove unneeded stat() call; was a leftover from the original MH
code where the owner of the folder was checked against the results of
getuid().
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 6 08:45:22 2013 -0500
The Content-Disposition type needs to be "inline" for MS Outlook and
BlackBerry calendar programs to properly handle a text/calendar
attachment. So do that with attachformat values of 1 and 2.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 19 18:30:19 2013 -0500
Added script name to test-mhfixmsg printout.
Author: David Levine <levinedl@acm.org>
Date: Thu Sep 19 08:13:24 2013 -0500
Don't check -replacetextplain in test-mhfixmsg if skipping -reformat
check.
Author: David Levine <levinedl@acm.org>
Date: Wed Sep 18 21:40:19 2013 -0500
Run output of -replacetextplain test through uniq.
Author: David Levine <levinedl@acm.org>
Date: Mon Aug 19 00:42:01 2013 -0500
Added -replacetextplain switch to mhfixmsg. If enabled, -reformat
will replace any existing text/plain part, such as those that are
empty or that don't match their corresponding text/html part.
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 2 18:33:37 2013 -0500
Added unsigned char cast of char argument to isascii() call.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 1 15:44:22 2013 -0400
Reject email addresses which contain 8-bit characters.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 1 15:07:16 2013 -0400
Add warnings about the use of %(decode) on addresses.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 1 14:31:51 2013 -0400
If mbtowc() fails to handle a character, replace the offending character
with a '?' and continue.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 1 07:11:27 2013 -0500
In test-mhfixmsg, run output through uniq before head instead of after.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 22:29:12 2013 -0500
Punted on comparing that html part in test-mhfixmsg: it
can get reformatted legally.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 21:20:00 2013 -0500
Try this formatting change to test-mhfixmsg.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 20:46:18 2013 -0500
One more formatting chagned to the input in test-mhfixmsg. One of
the lines is one character longer than the others and that's about
where the problem shows up, so yanked a character out of it.
Merge: 1863e693 03da1d1f
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 18:11:42 2013 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 18:11:13 2013 -0700
Revert "Move a variable manipulation outside the context of setjmp() to quell a compiler warning."
Turns out it didn't fix it after all.
This reverts commit 0152658e840581077e5cd575b5195faf18b9df8b.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 20:11:08 2013 -0500
Changed formatting of the input in test-mhfixmsg that breaks
on Solaris 11, maybe this will fix it.
Merge: 0152658e 7970ff4d
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 17:59:59 2013 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 17:59:31 2013 -0700
Move a variable manipulation outside the context of setjmp() to quell a compiler warning.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 19:40:34 2013 -0500
Restored test-mhfixmsg. Not sure what to do about failure on Solaris.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 17:24:48 2013 -0700
Copy a parameter off the call stack to quell a longjmp warning.
Merge: 5fb90fae daae5d9e
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 19:14:46 2013 -0500
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 19:12:58 2013 -0500
See if the rest of test-mhfixmsg will pass on Solaris.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 16:58:23 2013 -0700
Remove spurious return statements after exit().
These are holdovers from a long forgotten era.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 18:50:50 2013 -0500
OK, fixed test-mhfixmsg on Solaris 11, where BUFSIZ is 1024.
The problem was in the content_encoding() function of mhfixmsg:
it would restart its counter of the characters on a line whenever
new characters were read in. The fix was easy, just move the
initialization of that counter outside of the fread() loop.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 18:28:56 2013 -0500
Added to the Solaris debug printout.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 18:11:43 2013 -0500
Removed exit() after a longjmp() in uip/sendsbr.c to quiet
compile warning on Solaris 11.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 18:03:28 2013 -0500
More debugging of test-mhfixmsg on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 17:50:44 2013 -0500
Fixed removal of <> in test-dist and test-rcvdist.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 16:44:23 2013 -0500
Remove any <> surrounding localmbox in test-dist and test-rcvdist,
so that the tests pass when the user doesn't have a SIGNATURE set.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 16:35:39 2013 -0500
That didn't work, fixed location of mhn.defaults in test.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 30 16:19:56 2013 -0500
Added debug printouts to see why the test fails on Solaris 11.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 13:14:12 2013 -0700
Prefer /usr/sbin/sendmail over /usr/lib/sendmail.
If the site installs a sendmail replacement, or updates to a newer
version, odds are better for the new sendmail preferring to install in
/usr/sbin over /usr/lib.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Jun 30 12:39:46 2013 -0700
Add compilation guard around lkopen_flock.
Oracle Solaris 11 doesn't have flock().
Author: Lyndon Nerenberg <lyndon@nmhsol11.(none)>
Date: Sun Jun 30 12:16:07 2013 -0700
If we're searching for commands, prefer xpg4 versions on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 11 20:30:31 2013 -0500
Removed hyphen from all occurrences of RFC-*.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 11 20:17:29 2013 -0500
Changed all bare occurrences of 822/2822 to RFC 822/RFC 2822.
Reported by Norm.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 11 19:46:51 2013 -0500
Changed "separated by spaces" in mh-sequence man page to
"as separate arguments", as suggested by Norm.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 11 19:45:47 2013 -0500
Changed a couple of occurrences of "white-space" to "whitespace"
to be consistent with other man pages.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun May 26 12:37:40 2013 -0700
conflict(8): style - move deprecation notice into DESCRIPTION.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun May 26 12:28:24 2013 -0700
Remove SYNOPSIS from nmh(7).
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun May 26 12:23:00 2013 -0700
Delete SYNOPSIS from section 5 manpages.
This isn't applicable to section 5 manpages.
Merge: c943fb3c 48590416
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun May 26 12:17:41 2013 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun May 26 12:17:31 2013 -0700
Fix typo.
Author: David Levine <levinedl@acm.org>
Date: Sun May 26 11:11:48 2013 -0500
Added note to pending-release-notes that "*" address-group is
obsolescent. Split obsolete and deprecated features into
separate sections.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat May 25 20:19:50 2013 -0700
Stupid typo in manpage.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat May 25 20:14:04 2013 -0700
Clean up mh-alias(5) manpage.
Word-smithing, update to use *.example domains for addresses,
literal text in bold rather than italic, use typographers quotes on
single character references, etc.
Re-organize sections to match documentation convention.
Mark "*" address-group as obsolescent.
Author: David Levine <levinedl@acm.org>
Date: Sun May 12 08:29:34 2013 -0500
Fixed strip_crs() in mhfixmsg to work even if it's the
only modification to the message. Also, fixed the test
so that it succeeds even if there is no lynx, w3m, etc.
Author: David Levine <levinedl@acm.org>
Date: Mon May 6 20:14:57 2013 -0500
Fixed number of bytes to fread() in strip_crs() in mhfixmsg.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun May 5 14:41:34 2013 -0700
More .ta -> .TP manpage cleanup.
Author: David Levine <levinedl@acm.org>
Date: Sat May 4 10:38:35 2013 -0500
Per Ralph's suggestion, added note that "moreproc" is not
supported in user profile display strings.
Author: David Levine <levinedl@acm.org>
Date: Sat May 4 10:30:21 2013 -0500
Replaced hard-coded "more" with DEFAULT_PAGER in show_text().
Author: David Levine <levinedl@acm.org>
Date: Sat May 4 09:36:42 2013 -0500
When the mhfixmsg -decodetext switch is enabled, each carriage
return character that precedes a linefeed character is removed
from ASCII-encoded text parts.
Author: David Levine <levinedl@acm.org>
Date: Sat May 4 09:03:27 2013 -0500
Removed unused declaration of "nolist" from mhshow.c.
Author: David Levine <levinedl@acm.org>
Date: Sat May 4 09:01:42 2013 -0500
Replaced raw hack to add the credentials profile entry in post.c
with new add_profile_entry() function.
Author: David Levine <levinedl@acm.org>
Date: Thu May 2 20:36:21 2013 -0500
Fixed failure reported by Valdis of post to retrieve login and
password with legacy credentials.
Author: David Levine <levinedl@acm.org>
Date: Wed May 1 20:40:55 2013 -0500
Fixed problem with m_getfld() with long headers reported by
Paul Fox. The problem occurred with the 512th byte of the
header was a newline: it then skipped the next character.
Author: David Levine <levinedl@acm.org>
Date: Wed May 1 20:38:48 2013 -0500
Set the return status from the check() function of the test
suite if the check failed.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 30 20:59:55 2013 -0500
Removed remaining #includes of stdio.h and stdlib.h because
they're #include'd by h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 30 20:54:43 2013 -0500
Applied what was done to uip/send.c in commit
af429a902add614e35cd76d15172a4ccb70a3be1 to uip/viamail.c and
uip/whatnowsbr.c, because they call sendsbr() directly.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 19:42:09 2013 -0500
Removed some #includes of stdio.h, ctype.h, stdlib.h, and
string.h because they're #include'd by h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 19:32:44 2013 -0500
Removed some #includes of unistd.h and stdio.h because they're
in h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 19:26:58 2013 -0500
Redirect some outputs in the test suite to standard error.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 14:59:34 2013 -0500
Fix to commit af429a902add614e35cd76d15172a4ccb70a3be1 to
use the user found by nmh_get_credentials() in sm_auth_sasl().
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 13:07:31 2013 -0500
Tweaked check of -outfile in test-mhstore.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 12:49:44 2013 -0500
Allow -clobber with mhstore -outfile.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 11:29:47 2013 -0500
Added -outfile switch to mhstore(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 28 11:13:41 2013 -0500
Refined error message from check() shell function of test suite.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Apr 27 20:32:55 2013 -0400
Remove extra arguments from two anno tests; the check() function now
complains about them. Looks like they were always there.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 27 14:08:49 2013 -0500
Removed #include of sys/param.h from sbr/makedir.c. It's
#include'd by h/nmh.h, with HAVE_SYS_PARAM_H protection.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 27 13:26:18 2013 -0500
Allow mhfixmsg -reformat to succeed even when decode of binary
text fails. This is a refinement of commit
ebf35185aa9256b0cd09234f39bd14db9e90e81c.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 27 13:24:53 2013 -0500
Added support for 'ignore space' argument to check() function
of test/common.sh.in.
Author: David Levine <levinedl@acm.org>
Date: Mon Apr 22 22:00:38 2013 -0500
Completed commit 52a236230220232fd632b5aa88eb9bb31dba346e so
that send(1)/post(1) use "credentials" profile entry. post
doesn't read the profile so pass the credentials setting to
it via a new switch.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 21 09:49:48 2013 -0500
Replaced calls to static getcpy() in mf.c with calls to strdup()
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 21 09:43:27 2013 -0500
Added quoting of local part of invalid address in message being
replied to [Bug #26780].
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 21 09:42:00 2013 -0500
Fixed small formatting glitch in repl man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 21 09:41:03 2013 -0500
Added const to arguments of mf functions.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 21 09:39:44 2013 -0500
Added const to argument of getname().
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 21 09:39:20 2013 -0500
Added const to argument of getcpy().
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 20 08:36:12 2013 -0500
Refined commit 9b70e8396d50989db2177547515594bc15ee8b17 to allow
options to be passed to ls from whatnow prompt. This way, "ls -l"
works as expected.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 19 21:06:50 2013 -0500
Added mention to mhlist(1) man page, in response to question
from Ralph, that it lists multipart/alternative parts in reverse
order of their placement in a message.
And in response to suggestion from Ralph, trimmed whitespace from
ends of mhlist output lines.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Apr 9 14:32:32 2013 -0400
test-mark: add tests for relative message selections
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Apr 4 08:21:19 2013 -0400
mh-sequence.man: document new '=+' and '=-' for selecting relative msgs
also add a line-item to docs/pending-release-notes.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Apr 4 08:21:50 2013 -0400
m_convert: 'foo=n' and 'foo=+/-n' now select msgs with relative offsets
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 18 21:30:33 2013 -0500
Fixed permissions of maildelivery file in test-slocal to fix
test failure reported by Paul Fox. Also added code to the test
to help diagnose any failure.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 16 08:00:54 2013 -0500
Plugged memory leak in m_unknown().
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 16 07:59:54 2013 -0500
Added date to test message with two blank lines between header
and body so that the test can pass on other days.
Author: David Levine <levinedl@acm.org>
Date: Mon Apr 15 21:01:12 2013 -0500
Fixed problem in m_getfld() reported by Paul Fox. When
inc'ing a message from a maildrop with two blank lines
between the header and body, the last 3 or 4 characters of
the last header would be copied into the body.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 14 10:47:31 2013 -0500
Moved #include of signal.h to h/signals.h. And it was already
in h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 14 10:27:47 2013 -0500
Moved #include of errno.h to h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 14 10:13:42 2013 -0500
Removed #include of sys/wait.h from sbr/pidstatus.c. I missed
it with b523a72928c0ef630be33cf5f5aab9fc301958e1.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 14 09:53:32 2013 -0500
A "credentials" mh-profile entry has been added. This allows
post(8), whom(1), send(1), inc(1), and msgchk(1) to (optionally)
honour the username in the .netrc file [Bug #23168]. And, it
allows specification of any valid filename in place of $HOME/.netrc.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 9 20:26:43 2013 -0500
Fixed typo in several man pages.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 3 20:06:19 2013 -0500
Added vpick to dist_contib_DATA so it gets distributed.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 3 19:56:54 2013 -0500
Be sure that mhfixmsg returns a status of non-zero if
it can't reformat a part.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 3 18:46:22 2013 -0500
Added port number to "Connecting to" message with -snoop.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 1 12:10:28 2013 -0400
Document new -initialtls option.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 31 20:56:49 2013 -0500
Cast away constness of SSL_CTX_new() arg because that's
what older versions of ssl use.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 31 20:39:55 2013 -0500
Look at post instead of inc to determine build options in build_nmh.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 31 20:39:22 2013 -0500
Added const to SSL_METHOD *.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 31 18:33:46 2013 -0400
Preliminary support for TLS negotiation at the very start of SMTP session.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 31 16:32:10 2013 -0500
Moved #include <sys/wait.h> to h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 31 11:45:09 2013 -0500
Removed limit on maximum number of sequences in a folder.
Dynamically sized vectors in sbr/vector.c were added to support
this. Their sizes are limited only by virtual memory.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 30 09:53:10 2013 -0500
Moved #include <assert.h> to h/nmh.h.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 29 12:09:15 2013 -0500
A bug fix and an enhancement to mhfixmsg based on patches
provided by M. Levinson:
1) Set status to NOTOK in get_multipart_boundary() if the
message is missing its end boundary. This avoids a seg fault
in fix_boundary(); also added check for null return from
parse_mime(). If this turns out to be a common problem, we
could consider adding code to repair it. Now, mhfixmsg ignores
the condition and proceeeds with any other transformations.
2) With -decodetext 7bit, mhfixmsg now converts base64-encoded
parts to quoted-printable 8bit if the part will not fit into
7bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 27 14:56:44 2013 -0400
Document changes regarding increased per-folder sequence limits.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 27 14:51:33 2013 -0400
Warn the user if too many sequences exist during sequence initialization.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 27 14:22:40 2013 -0400
Change seqset_t to unsigned long to support more sequences on LP64 systems.
Also include necessary casts to make sequence macros worked properly.
Based on code contributed by M. Levinson.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 25 22:29:06 2013 -0500
Reworded description of "mark -seq foo delete all" example
in mark(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 13:37:47 2013 -0500
Finished replacing mh_strcasecmp() with strcasecmp(). Removed
sbr/strcasecmp.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 13:23:59 2013 -0500
More replacements of mh_strcasecmp() with strcasecmp().
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 11:45:42 2013 -0500
More replacements of mh_strcasecmp() with strcasecmp().
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 11:28:51 2013 -0500
More replacements of mh_strcasecmp() with strcasecmp().
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 11:15:27 2013 -0500
More replacements of mh_strcasecmp() with strcasecmp().
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 10:36:18 2013 -0500
More replacements of mh_strcasecmp() with strcasecmp().
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 24 09:09:02 2013 -0500
Started replacing uses of mh_strcasecmp() with strcasecmp().
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 23 22:59:24 2013 -0400
Change folder_delmsgs() to save context and sequence files (and make
sure those changes are before calling rmmproc(). Update programs
that use folder_delmsgs() to make all changes to sequences and
the context before calling folder_delmsgs().
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 22 00:28:35 2013 -0400
Make some formatting changes to conform to our manpage style.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 22 08:33:40 2013 -0500
Always update sequences and context in mhfixmsg, not just when
there is a rmmproc.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 21 21:05:09 2013 -0500
Fixes from M. Levinson:
1) Fixed typo in elinks option in etc/mhn.defaults.sh.
2) Added #include <sys/wait.h> to mhfixmsg.c.
3) Fixed seg fault when there's no corresponding profile entry
for a message part in mhfixmsg.
4) If rename() fails in write_content() of mhfixmsg, attempt to
copy and then remove the file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 21:49:29 2013 -0400
Minor formatting fix for fmttest man page.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Thu Mar 21 20:22:21 2013 -0500
Went through the sources and checked where etcpath() is
used, and added/cloned an explanatory bit of text from the
fmttest man page to the files section for all affected
programs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 18:28:21 2013 -0400
Make sure to mark the sequence file as closed in the msgs struct.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 17:19:46 2013 -0400
Change mhfixmsg to the new world folder_read() API.
Merge: 6f709079 85bb87a2
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 17:14:30 2013 -0400
Merge branch 'newlock'
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 17:12:42 2013 -0400
More documentation about locking changes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 17:12:13 2013 -0400
Support for sequence file locking in inc(1).
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 21 13:47:04 2013 -0400
Don't lock and write the sequence files until after the searching
is complete.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 21 09:13:13 2013 -0500
Replaced reference to mktemp(3) with mkstemp(3) in
rmmproc.messageid.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 20 21:48:57 2013 -0500
Added support for Content-Disposition header (RFC 2183) to
mhstore(1) and mhn(1) when used with -auto.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 20 20:52:10 2013 -0500
Removed hard-coded locking selection from SPECS/nmh.spec.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 20 20:25:31 2013 -0500
Fixed typo in rmf man page.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 19 07:32:24 2013 -0500
Added -[no]rmmproc switches to rmm and mhfixmsg.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 19 01:02:45 2013 -0400
Make sure the building of config/config.o and sbr/mts.o depend on
the Makefile so changes to the Makefile are properly reflected in the build.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 18 20:00:10 2013 -0500
Added -[no]rmmproc switches to rmm and mhfixmsg.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 18 15:29:35 2013 -0400
Add code for (and convert world to) the new world lock order.
Still need to add some code to make inc and pick behave better (not hold locks
for as long).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 18 10:38:06 2013 -0400
Add ICONVLIB to build rule for mhfixmsg
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 18 08:54:55 2013 -0500
Fixed use of WIFEXITED in mhfixmsg.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 17 21:55:56 2013 -0500
Fixed procmail example in mhfixmsg man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 17 15:40:36 2013 -0500
Removed color-tests from AM_INIT_AUTOMAKE because the build
breaks if not supported, and automake 1.13 enables it by
default.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 17 10:32:57 2013 -0500
Added mhfixmsg(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 17 10:29:26 2013 -0500
Fixed typo in fmmtest man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 16 00:04:38 2013 -0400
Add information about locking support entries to the man pages.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 15 23:45:54 2013 -0400
Support for locking tests in the test suite.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 15 19:42:43 2013 -0400
Turns out the close function can be called with FILE * == NULL, so handle
that case.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 15 15:57:56 2013 -0400
Mostly complete now, but not yet functional.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 15 08:50:23 2013 -0500
Corrected comment describing copy_seqs().
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 14 22:02:30 2013 -0500
Changed c_cefile member of struct Content from pointer to
struct cefile. The memory cost will be negligible and it
simplifies the MIME parser code a bit.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 14 20:58:31 2013 -0500
Added -[no]retainsequences switches to refile(1).
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 14 20:37:49 2013 -0500
Changed loop in dumpwidth() to go from [0, 0xffff) because
wchar_t is 2 bytes wide on Cygwin. gcc noticed that the loop
would never terminate because 0xffff would increment to 0.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 14 19:08:15 2013 -0500
Changed detection of warning in build_nmh for sign mismatch
in sbr/dtimep.c to work with older gcc.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 14 15:57:07 2013 -0400
More locking updates; still doesn't compile yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 13 21:02:48 2013 -0400
Start of the changes for the new lock code. Does not compile yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 12 14:22:49 2013 -0400
Add support for RFC-2017, message/external-body content which contains URLs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 12 12:57:41 2013 -0400
Change sample disposition from "application" to "attachment"
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 11 18:57:01 2013 -0500
Added check that writesomecmd() isn't at the end of argp before
dereferencing ++argp. I'm surprised that no one, including me,
tripped over this before: whatnow(1) would seg fault when
handling, e.g., detach -n 4. But until I upgraded to Fedora 18,
I never noticed it. (valgrind did.)
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 11 18:42:16 2013 -0500
Ignore the sign mismatch warning when sbr/dtimep.c is built with
flex 2.5.36 or 2.5.37.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 8 06:40:07 2013 -0600
Fixed spelling of "preserve" in refile man page.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 7 20:11:22 2013 -0600
In the locking discussion of mh-folders(5), discourage direct
access to the nmh state files.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 5 20:17:08 2013 -0600
Added lockmethod pseudocomponent to mhparam so that users
can easily find out what locking method was configured in.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 5 14:30:51 2013 -0500
Update with more information.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 3 21:45:09 2013 -0600
Added a bit more on sequences to mh-folders.man.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 3 09:53:10 2013 -0600
Added beginnings of storage format spec to new mh-folders.man.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 3 09:49:05 2013 -0600
Fixed typo in rmmproc.messageid.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 27 19:32:38 2013 -0600
Reworked internals of MIME parser's reverse_parts() and made it
public.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 27 19:31:31 2013 -0600
Added tolower(), toupper(), and toascii() to
gen-ctype-checked.c.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 26 19:23:58 2013 -0600
Added a handful of functions to the parser to allow access to
init functions and string representations of enum valus for
content types and encodings.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 26 19:08:38 2013 -0600
Added nmh_strcasestr() because POSIX doesn't have strcasestr().
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 26 13:19:06 2013 -0500
Support RFC 2231 language tags in RFC 2047 header strings.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 25 23:02:05 2013 -0600
Added cpytrim() function. Unlike trimcpy(), it does not modify
its argument.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 25 22:46:00 2013 -0600
Added const qualifier to arguments of concat() and copy().
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 24 21:55:28 2013 -0600
Added find_str() and rfind_str() to sbr/utils.c
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 24 21:38:33 2013 -0600
Added const qualifier to char * arguments of add(), addlist(),
and folder_exists() in sbr/utils.{h,c}.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 22 00:52:50 2013 -0500
Add support for LS_UNQUOTE instruction.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 22 00:47:47 2013 -0500
Fix the code to print out an unknown instruction. Wow, this never worked
back from the original fmtdump.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 23:56:02 2013 -0500
Whoops, forgot a \ when adding fmttest.man to man_SRCS.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 23:03:31 2013 -0500
Quote the arguments to the .I macro so the manpage test doesn't complain.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 22:55:41 2013 -0500
Document new fmttest program.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 22:55:23 2013 -0500
Fix a few issues resulting from m_getfld() API changes.
Merge: b5f3b745 7344831d
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 22:40:48 2013 -0500
Merge branch 'format-test'
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 22:38:18 2013 -0500
Add a lot more text to the man page; it should be in reasonable shape now.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 22:37:47 2013 -0500
Update instruction output to be a bit more cleaner
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 21 21:01:55 2013 -0600
Fixed write8Bit() to use fread()/fwrite() instead of
fgets()/fputs().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 15:53:06 2013 -0500
Flesh this out so finally it's halfway useful.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 15:52:36 2013 -0500
Rearrange options a bit and support the -nodump flag. Also clean up how
-raw mode works.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 21 15:52:09 2013 -0500
Bring this up to best practices.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 20 22:37:50 2013 -0500
Minor updates for fmttest man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 20 15:53:54 2013 -0500
Basic format tracing support; seems to work!
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 20 15:19:11 2013 -0500
Support for the address duplication done by repl, and also clean up
some stuff.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 20 12:01:05 2013 -0500
Support callbacks into the format engine. This is so we can add in proper
hooks for %(formataddr), %(concataddr), and (eventually) tracing.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 19 21:57:32 2013 -0500
Make generating the ChangeLog work if you're building a distribution from
an object directory.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 19 21:54:14 2013 -0500
The beginnings of a fmttest man page.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 19 19:45:25 2013 -0600
In m_getfld.c, cast the returns of valid characters to
unsigned char. This differentiates them from EOF and matches
the behavior prior to the recent m_getfld() rework. But that
behavior is very broken on 8-bit input.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 19 13:51:47 2013 -0500
Apply David Levine's fix from whomfile() to sendfile() as well.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 18 21:32:24 2013 -0600
Removed addition of whomproc to the vec array in whomfile()
now that argsplit() does it.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 18 21:24:29 2013 -0600
Added locking discussion to rcvstore(1) man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 18 20:51:46 2013 -0500
fmttest is actually starting to get useful now. Some changes were required
to the format code to make this code cleaner.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 17 22:04:51 2013 -0600
"RFC-2045 to RFC-2049" instead of "thru".
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 16 08:27:29 2013 -0600
When output_content() outputs a non-MIME message with no body,
suppress the newline after the headers.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 16 08:23:10 2013 -0600
Added mention of rcvstore(1) to inc(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 16 08:21:10 2013 -0600
Plugged small memory leak in etcpath().
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 16 08:19:45 2013 -0600
In InitMultiPart(), always set bogus_mp_content if boundaries
don't match.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 16 00:37:36 2013 -0500
Remove dead UUCP address parsing code. Sadly, this is not the complete
removal of UUCP support, but it's a good start.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 16 00:31:16 2013 -0500
Slightly more useful, but still more work to do.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 15 15:58:21 2013 -0500
Add more functionality to fmttest; it's starting to get semi-useful.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 14 21:53:50 2013 -0600
Added a couple of global variables to mhparse.c to allow
suppression of the warning about bogus multipart content,
and detection of it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 14 13:50:28 2013 -0500
More work on fmttest, but still plenty more to go.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 14 13:49:54 2013 -0500
Correct man page information for %(width) format instruction.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 13 21:11:59 2013 -0600
Added support for multiple message/file arguments to
rmmproc.message.id. Added mention of it to rmm man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 13 15:53:13 2013 -0500
Clean up argument handling to fmttest, as a precursor to actually getting
it done.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 13 14:42:50 2013 -0500
Remove support for -mail, -saml, -send, and -soml switches in send
and whatnow. The code in post implementing these options was removed
as part of commit 537e02c38f4bb.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 13 14:24:11 2013 -0500
Convert fmttest over to the new argument processing world order.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 13 10:47:26 2013 -0500
Document argsplit changes in mh-profile man page.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 12 22:03:54 2013 -0600
Fixed typo in mhlist man page. Also removed sendfiles(1)
from its SEE ALSO list.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 12 20:05:17 2013 -0500
Remove installproc from the test since we don't have it anymore.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 12 15:39:18 2013 -0500
Remove "installproc" since it is no longer used.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 12 15:37:00 2013 -0500
Final conversion to new argsplit() code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 11 15:57:31 2013 -0500
Add a new test for the MIME functionality in burst.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 10 20:55:54 2013 -0600
Multipart parts might have content before the first subpart
and/or after the last subpart that hasn't been stored anywhere
else, so do that at the end of InitMultiPart(), and output it
in output_content().
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 10 19:05:37 2013 -0600
Added etc/rmmproc.messageid, which shows how to try to move
a message or file to a file that's named based on Message-ID.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 8 15:46:31 2013 -0500
Make burst(1) be able to burst MIME-formatted messages with message/rfc822
parts in them.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 8 13:02:00 2013 -0500
Create a central prototype for free_content().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 7 14:34:12 2013 -0500
More conversion to argsplit().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 7 11:31:45 2013 -0500
Move etc/gen-ctype-checked into an Automake primary so dependency information
can properly be recorded for it.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 6 20:39:06 2013 -0600
When debugging is enabled, replace the ctype functions with
macros that index into arrays. This allows the compiler to
catch use of char, instead of unsigned char, arguments to
those functions. gcc uses -Wchar-subscripts, which is enabled
with the -Wall that we use by default. Thanks to Tom Lane for
suggesting this approach.
This feature can be enabled by undef'ing NDEBUG in config.h.
configure --enable-debug does that. We can now use the same
mechanism to enable and disable assert(3), too.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 6 20:31:18 2013 -0600
Added global variable skip_mp_cte_check to turn off that check
for incorrect encoding of multipart messages in InitMultiPart().
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 6 20:28:29 2013 -0600
output_content() assumed that ci->ci_values[0] was the boundary,
but that's not always the case. Added search for the boundary
in ci->ci_attrs[].
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 6 15:51:04 2013 -0500
More work to convert programs over to the use of argsplit().
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 6 11:12:56 2013 -0500
Make sure these stdarg lists are properly terminated with pointer-context
NULLs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 5 21:06:35 2013 -0500
Remove warning suppression we no longer need. Hooray!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 5 21:00:40 2013 -0500
FINALLY clean up our signed/unsigned character warning mess. In short, we
have switched to using "char" almost everywhere, and casting char to
unsigned char when using the ctype macros/functions.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 5 16:20:53 2013 -0600
Changed m_getfld() to use char instead of unsigned char.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 5 15:25:23 2013 -0600
Changed m_getfld() to use char instead of unsigned char.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 5 13:01:09 2013 -0500
Start of the signed/unsigned char cleanup.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 3 22:51:00 2013 -0600
Tweaked logic in brkstring.c and showfile.c to get rid of the
remaining "statement not reached" warnings from Solaris cc.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 2 14:28:39 2013 -0500
Make sure we don't link getcwidth with the nmh libraries.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 12:56:53 2013 -0600
Added support for "-" to indicate stdout to output_message().
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 12:54:55 2013 -0600
Removed unlink of "core" from signal handler of mhlist, mhn,
mhshow, and mhstore. Those programs shouldn't remove a file
that has nothing to do with them.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 12:40:59 2013 -0600
Removed myuid and mygid variables, they're no longer used and
the Solaris C compiler complained about their initializers.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 2 13:30:24 2013 -0500
Cast wchar_t to long unsigned int to deal with differing types of
wchar_t across systems.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 11:55:23 2013 -0600
Suppress warning from test-manpages that groff can't break a line if
the user's prefix is too long.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 10:54:32 2013 -0600
The Solaris compiler was right about unreachable statements.
Fixed all of them in uip/.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 10:21:14 2013 -0600
Added l modifier to X printf conversions of wchar_t's.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 10:18:24 2013 -0600
Removed unused vec[0] relic from before argsplit conversion.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 10:12:57 2013 -0600
Added trailing newline to sed input in mhmail when processing
-headerfield argument, to squelch complain from Solaris sed.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 09:59:28 2013 -0600
Set MHTMPDIR to try to keep all test-related files together.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 09:58:20 2013 -0600
More test-mhmail probing.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 09:23:49 2013 -0600
Try this test-mhmail probe.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 08:43:32 2013 -0600
More test-mhmail probing.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 08:26:43 2013 -0600
Modified test-mhmail probe.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 2 08:15:15 2013 -0600
Added temporary probe to test-mhmail.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 2 01:10:06 2013 -0500
Convert post over to use new argsplit code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 2 00:48:54 2013 -0500
Handle the case where (on Solaris) the width of U+2019 is 2 (which seems
TOTALLY bizarre to me, but there you have it).
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 2 00:33:51 2013 -0500
Rework multibyte test so it will calculate the width of all of the
Unicode characters we are using.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 23:24:27 2013 -0600
In setup_test(), set PATH after install.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 23:12:09 2013 -0600
Added set -x to test-ali.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 22:52:00 2013 -0600
Maybe the mkdir in setup_test() needs a -p?
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 22:39:49 2013 -0600
More test-ali diagnostics for Solaris.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 22:25:51 2013 -0600
Use test -t 1 instead of test -w in test-pick.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 22:24:48 2013 -0600
More setup_test() and test-ali attempts on Solaris.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 18:46:02 2013 -0600
Removed the ls of folder from setup_test().
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 18:35:13 2013 -0600
Try full path to folder in setup_test().
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 18:16:26 2013 -0600
Maybe the PATH needs to be exported again in setup_test()?
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 17:37:02 2013 -0600
So folder does exist the first time through setup_test().
Let's see its stdout.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 17:20:37 2013 -0600
Suppressed display of info message when test-eom-align isn't
run with stdout to a terminal.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 17:19:40 2013 -0600
Temporarily added ls of folder to setup_test().
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 15:08:32 2013 -0600
In setup_test(), create the Mail directory if it doesn't
already exist.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 15:41:00 2013 -0500
Ignore the return status of diff, so we don't exit if diff fails when using
set -e.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 15:18:47 2013 -0500
Add some diagnostics to determine what is going wrong.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 14:08:45 2013 -0600
It looks like the first test fails on Solaris because it
can't find folder. So, added a test/sleep before its first
use, in setup_test().
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 15:03:16 2013 -0500
If the multibyte width test fails, dump the values of wcwidth() for the
complete BMP.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 13:38:36 2013 -0600
Added diagnostic to setup_test() to try to figure out
why the first test fails on the Solaris buildbot.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 1 13:36:23 2013 -0600
Restored test-ali to its prior condition. It failed on the
Solaris buildbot because it was the first test.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 14:06:49 2013 -0500
Make sure we created the test file even if we don't have iconv support;
it's needed for two tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 13:42:51 2013 -0500
Move ICONV_ENABLED so it always gets initialized even if the header check
for iconv.h fails.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 13:25:17 2013 -0500
If we don't have iconv, skip the multibyte test that requires character
set conversion.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 12:30:45 2013 -0500
Finally switch over from vfork() to fork() completely.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 1 12:11:59 2013 -0500
More code converted to use argsplit().
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Feb 1 07:25:44 2013 -0800
Fix configure tests for -Wfoo option support.
Drooped support for -Wunused-macros and -Wno-unused-macros. The
warnings serve no useful purpose, and causing subsequent configure
checks for -Wfoo flags to get messed up.
Split each test of -Wfoo into a separate check. Include -Werror in
the individual flag tests to ensure the test compile fails if the
other flag isn't supported. Without this, clang issues a diagnostic
message about the flag being ignored, but otherwise carries on, fooling
configure into thinking the flag is in fact supported.
Merge: ae9b723f b78be76b
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Feb 1 04:44:29 2013 -0800
Merge branch 'master' into savannah
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Feb 1 00:20:44 2013 -0800
Update manpages to use .TP for tagged paragraphs (part I).
This replaces .fc/.nf and friends with the man(7) .TP macro.
This commit covers about half of the man pages. The rest will
follow in a couple of days.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Feb 1 00:20:44 2013 -0800
Update manpages to use .TP for tagged paragraphs (part I).
This replaces .fc/.nf and friends with the man(7) .TP macro.
This commit covers about half of the man pages. The rest will
follow in a couple of days.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jan 31 21:28:51 2013 -0800
Update the manpage template documentation.
Update the section ordering to follow the UNIX order. This
pulls nmh-specific sections into the body of the manpage, and
pushes FILES, SEE ALSO, and BUGS to the end.
Clarifies a few other minor points.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 22:32:26 2013 -0600
More probing of test-ali on Solaris: exit before the
setup_test call, which has the folder invocation.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 22:30:36 2013 -0600
OK, test-pick should be good on Solaris now.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 21:27:46 2013 -0600
Added exit to test-ali, temporarily, to isolate failure on
Solaris.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 21:24:53 2013 -0600
More homing in on the test-pick warning. Also, removed
warning to user that the tty test is being skipped, it's
not that important.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 20:10:59 2013 -0600
Removed an used sed invocation from test-mhmail. I don't
know if it was causing the warnings on Solaris, we'll see.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 31 21:04:43 2013 -0500
Fix some warnings for Solaris.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 20:04:50 2013 -0600
it looks like the write to /dev/tty is causing the warning from
test-pick on Solaris, here's an attempt to squelch that.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 19:44:47 2013 -0600
Removed sizes from mhlist output. Apparently tar files are
so much smaller on Solaris that they cause the check of its
output to break. The test also compares the contents of
the tar file, so it's still adequate.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 31 19:43:09 2013 -0600
Redirected stderr to /dev/null in the test for presence of
/dev/tty. Solaris warns that it can't create the device.
This may not fix it, but it should help isolate which part of
the test is causing the warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 31 20:01:27 2013 -0500
Set the locale for one of the "pick" invocations to UTF-8, so we can decode
the UTF-8 header correctly in the test.
Author: Lyndon Nerenberg <lyndon@minisun.(none)>
Date: Thu Jan 31 03:56:55 2013 -0800
Use cmp(1) to compare acheieved and expected test results.
'diff -c' on Solaris 11 generate a spurious 'No differences encountered'
message (on stdout, no less!) when the compared files are identical. This
changes the test logic to compare with 'cmp -s', and then perform a
'diff -c' if the results don't match expectations.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jan 31 01:44:03 2013 -0800
Wrap 'pick -subject foobar 13' test with set +e/-e.
The command was failing silently on FreeBSD, leading to
premature script termination.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Jan 30 23:55:26 2013 -0800
Change the MD5FMT macro in configure.ac to not emit filename.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Jan 30 23:07:17 2013 -0800
How hard can it be to write a portable shell function that does nothing?
Pretty hard, apparently :-P
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Jan 30 21:45:16 2013 -0800
Hush progress indicator during tests when stdout is not a tty.
This eliminates 100 lines of logfile spam during buildbot runs.
Merge: e716be9c f1722de8
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Jan 30 19:58:16 2013 -0800
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh into nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Wed Jan 30 19:57:22 2013 -0800
IPPROTO_TCP requires <netinet/in.h>
At least on BSD it does.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 30 15:47:32 2013 -0500
More changes to use argsplit() for helper programs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 29 15:58:34 2013 -0500
Switch the editor invocation over to use argsplit().
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 29 15:30:36 2013 -0500
The start of the use of argsplit() to process command strings.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 28 21:38:39 2013 -0600
Changed m_getfld() buffer size to 4096 from 8192, to benefit
scan(1). We could consider using a larger buffer size when
readying message bodies. But I expect any benefit would be
overshadowed by the way parse_mime() currently reads MIME
messages: it reopens the file for each part.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 28 21:20:22 2013 -0600
Added m_getfld_track_filepos() for callers to indicate that they
may interleave fseek*/ftell* calls with m_getfld() calls. This
eliminates the need for m_getfld() to call fseek() when called
by inc(1) and scan(1).
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 28 19:12:17 2013 -0600
Added scan_reset_m_getfld_state(), for msh only. It needs to
call that so that it can support more than one operation on its
mailbox.
Merge: a5a47578 45382519
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 27 10:37:54 2013 -0600
Merge branch 'm_getfld'
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 27 10:11:10 2013 -0600
In the sortm warning message, say "file modification time"
instead of "file mtime", per Paul F.'s suggestion.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 27 09:34:58 2013 -0600
Changed sortm warning message from an amonish() to and advise(),
and included the remedy of using the file mtime, per suggestions
of Norm and Ralph.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 27 08:37:31 2013 -0600
Fixed a couple of calls to m_getfld(): they were in while loops
and the loop bodies were missing brackets.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 26 09:42:25 2013 -0600
Deprecated msh(1).
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 26 09:00:48 2013 -0600
In build_nmh's output from the test suite: retain
colorization and list any test failures.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 26 08:52:50 2013 -0600
Enabled colorized test output (PASS/FAIL/summary) by default
via "color-tests" automake option. To disable at runtime,
either set your AM_COLOR_TESTS environment variable to "no",
or provide that on the make check command line.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 25 22:21:53 2013 -0600
Reworked the new documentation in m_getfld.c.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 25 22:22:46 2013 -0500
Handle the case in the test suite where wcwidth() can return different
values for combining Unicode codepoints on different operating systems.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 24 16:05:36 2013 -0500
Fix the format engine so it properly keeps track of multibyte characters
and column positions when processing components and other functions.
When working on this code I realized we have nothing that checks to make
sure right justification of format function output works properly, so a
test for right justification is also included.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 23 20:24:21 2013 -0600
Added functions for inc, msh, rcvtty, and scan to access
scansbr's gstate instance so it can be hidden, except for
msh's uses of m_getfld().
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 21 10:32:37 2013 -0500
Fix a bug leading to message corruption with inc when incorporation more
than one message at a time.
When I reworked the scan() code to remove the use of stdio internals,
two code paths were created. The inc code path consumed another buffer
from the nxtbuf list for processing the message body. At the end of
scan() there was code to push back all of the consumed buffers to the
nxtbuf list. The extra buffer consumed in the inc code path wasn't
being pushed back, and as a result the nxtbuf list would end up with
duplicate pointers in it. This would result in two components sharing
the same text buffer, which caused the message corruption.
When I looked at this closer, I realized that there was no reason to
push those buffers back to the list; nxtbuf gets reset to compbuffers
at the start of every call to scan(), and nxtbuf isn't used after the
buffers are pushed back. Some researched revealed that this was the
same back in the original MH code. I decided it was simplest to simply
delete the buffer recycling code.
(cherry picked from commit 22d2acba60374851c291260ff6aa716e9bf44a6d)
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 23 19:42:56 2013 -0600
Brought over changes to test-pop from master to m_getfld branch.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 20 08:38:18 2013 -0600
Added scan and inc from mbox with multiple messages.
(cherry picked from commit c4c53777458bfcfd288d45b7708e52eb47c56405)
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 17 20:58:25 2013 -0600
Added test-msg-buffer-boundaries.
(cherry picked from commit dbd0fa0a56a222bd118fea627eba53e5d9811d01)
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 23 19:20:40 2013 -0600
Brought over changes to test-pop from m_getfld branch.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 22 21:02:49 2013 -0600
Changed m_getfld() to automatically allocate a new state
instance as needed. Callers no longer use
m_getfld_state_init().
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 22 17:08:21 2013 -0600
Removed unnecessary m_getfld_state_destroy() from scan.c.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 22 17:07:47 2013 -0600
Reworked enter_getfld() and Peek().
Merge: 2f5c4e86 22d2acba
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 21 10:58:07 2013 -0500
Merge branch 'master' into format-test
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 21 10:32:37 2013 -0500
Fix a bug leading to message corruption with inc when incorporation more
than one message at a time.
When I reworked the scan() code to remove the use of stdio internals,
two code paths were created. The inc code path consumed another buffer
from the nxtbuf list for processing the message body. At the end of
scan() there was code to push back all of the consumed buffers to the
nxtbuf list. The extra buffer consumed in the inc code path wasn't
being pushed back, and as a result the nxtbuf list would end up with
duplicate pointers in it. This would result in two components sharing
the same text buffer, which caused the message corruption.
When I looked at this closer, I realized that there was no reason to
push those buffers back to the list; nxtbuf gets reset to compbuffers
at the start of every call to scan(), and nxtbuf isn't used after the
buffers are pushed back. Some researched revealed that this was the
same back in the original MH code. I decided it was simplest to simply
delete the buffer recycling code.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 21 08:42:20 2013 -0600
Plugged small memory leak in m_unknown().
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 20 22:22:17 2013 -0600
Replaced hard-coded value with MAX_DELIMITER_SIZE in m_getfld.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 20 21:27:54 2013 -0600
Removed the static m_getfld() state instance and replaced
with functions for callers to create and destroy their own
instances. This also allows inc, msh, and pick to call
m_getfld() with an initial file stream position other than 0.
There is now a global state instance so that scan can call
m_unknown() on maildrop files. It'd be nice to get rid of
that.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 20 22:23:58 2013 -0500
Fix memory leak in arglist code
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 20 08:38:18 2013 -0600
Added scan and inc from mbox with multiple messages.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 20 07:49:58 2013 -0600
Updated test-inc-scanout on master to match version of
m_getfld branch.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 19 08:33:38 2013 -0600
Added a FILE * to the m_getfld_state struct so that most
functions don't need to pass it explicitly. Note that
m_getfld() must still be passed the FILE * because some
callers, e.g., those in mhparse.c, reopen their input file
and therefore pass different FILE *'s for the same input.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 19 08:00:03 2013 -0600
Moved all file static data in m_getfld.c into the
m_getfld_state struct. Changed MSG_INPUT_SIZE from
hard-coded number to BUFSIZ.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 19 06:54:10 2013 -0600
Added check of -pack to test-pop.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 18 19:19:00 2013 -0600
Fixed test-header to work on Cygwin, which has a BUFSIZ of
only 1024. That caused an error message to be truncated.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 18 16:03:26 2013 -0500
Beginning of implementation of new argsplit() function to handle arguments
to profile-defined commands.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 17 21:58:50 2013 -0600
Removed all traces of m_getfld() FLDEOF and BODYEOF states.
They were never set by m_getfld(), so all caller code that
supported them was completely unexercised.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 17 21:46:54 2013 -0600
Minimized message files reads in m_getfld() when the caller
interleaves calls to fseek(). Added check of handling of
long header field name without a colon to test-header.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 17 20:58:25 2013 -0600
Added test-msg-buffer-boundaries.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 16 22:02:12 2013 -0600
More cleanup of m_getfld(), changed some variable names.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 16 21:48:11 2013 -0600
Added check of header field body with more than 511
characters to test-inc-scanout. Also changed a couple of
test message files to be generated on the fly.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 16 20:13:04 2013 -0600
Cleaned up m_getfld() code a bit. The most notable change
was to remove the check for mmdlm2 not being null. It's
global data so that shouldn't happen.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 15 22:56:33 2013 -0600
Added check of a header with name that's 998 bytes long to
test-header.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 15 20:11:41 2013 -0600
Removed the for-loop that was used to get a header field
name in m_getfld (). It was no longer necessary when not
drawing directly from the stdio buffer.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 15 19:38:16 2013 -0600
Check that a character array isn't empty before looking for its
next-to-last element.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 15 18:14:46 2013 -0600
In build_nmh, removed configuration of pager and editor.
And replaced use of which(1) with a self-contained function.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 15 15:30:17 2013 -0500
Support the VISUAL and EDITOR environment variables, and remove support
for configuring a default editor with --with-editor.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 15 13:22:13 2013 -0500
Remove the --with-pager configure option and replace it with a default
of "more".
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 14 22:05:38 2013 -0600
Renamed a couple of m_getfld auxiliary functions.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 14 21:34:08 2013 -0600
Cleaned up m_getfld's read_more().
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 14 21:05:22 2013 -0600
In m_getfld(), fixed the loop that handles the FLDPLUS case.
In Getc(), removed the increment of the byte count at EOF,
it didn't seem correct or necessary.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 14 20:58:56 2013 -0600
m_getfld() now supports interleaving calls with
fseek()/ftell(). Reverted the changes to uip/mhparse.c of
commit 484eb1003ae647e4b751e4d7829c7daf44fb99c9 because
they're no longer necessary.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 14 09:45:23 2013 -0600
Moved test of empty header field from
test/inc/test-inc-scanout to test/bad-input/test-header.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 14 09:41:50 2013 -0600
Cleaned up a bit.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 13 21:56:07 2013 -0600
Added support for m_getfld() callers interleaving fseek() calls
with their m_getfld() calls.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 13 11:08:28 2013 -0600
Added bytes_read to m_getfld() buffer state. This is the
next step in supporting ftell()/fseek().
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 13 09:43:15 2013 -0600
Removed unused local char_read from forwsbr.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 13 09:17:47 2013 -0600
Added check of m_getfld() handling of fields with trailing
whitespace to test-inc-scanout.'
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 12 11:14:45 2013 -0600
Removed "sleazy hack" of negative bufsz because commit
05d8af21d26673279a1ca079ad9c6f301426fe0e removed the only
use of it.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 12 10:58:31 2013 -0600
Cleaned up FLDPLUS handling in m_getfld(). As part of this,
removed the backing up of the read pointer in the "something
went wrong" portion of the FLD handling. It had been moved
back two positions. The first is no longer necessary
because a Getc() was replace by a Peek(), and the second
caused the extra blank line noted in the old comments.
Updated the expected output in test/bad-input/test-header to
correspond.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 12 09:23:19 2013 -0600
Fixed addition to test-inc-scanout in
683e0fb1a14da5b9ce7bc5db6e76951d14d79348 to not depend on
current date.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 12 09:21:59 2013 -0600
Very minor cleanup to m_getfld() to remove an increment of j.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 11 11:13:44 2013 -0500
We never use the autoconf checks for errno.h, crypt.h, or netdb.h, so
remove them.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 11 11:07:51 2013 -0500
At this point we're assuming at least C89 support, so there's no reason
we should check for support for const and standard header files.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 10 22:52:59 2013 -0600
Started revising m_getfld() code to replace direct buffer
access with Getc(). The goal is to again support fseek()
after return from m_getfld().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 10 14:18:15 2013 -0500
Convert the MIME content cache switches over to the smatch() New World Order.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 10 08:00:20 2013 -0600
Added explicit third initializer to some swit struct values
to silence gcc -Wmissing-field-initialziers warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 9 22:04:23 2013 -0500
Convert all argument processing over to using X-Macros for cleanup.
Based on a suggestion by Ralph Corderoy.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 9 20:58:03 2013 -0600
Added comments to and started cleaning up m_getfld.c.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 9 20:50:58 2013 -0600
When read_more() loads more bytes, save some from the end of the
current chunk and move them to the front of the buffer. This
allows backing up of the current position, which is necessary when
looking for the message delimiter in a maildrop file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 7 17:41:27 2013 -0500
Fix bug where a "cur" sequence that was outside the folder allocation limits
could trigger a core dump on some systems.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 6 15:04:24 2013 -0600
Removed support for #ifdef LBL. It was broken anyways,
sometime between MH 6.8.5 and the Apr 1999 entry into CVS.
Also removed the addtoseq format function that could only be
accessed with it.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 6 09:38:21 2013 -0600
Fixed test-utf8-body to actually contain the UTF-8 character
instead of the single byte, 8-bit character. This was caught
using Heirloom shell with a UTF-8 locale: when it wrote the
test draft from a here document, it converted the single byte
character to UTF-8. This verifies that behavior:
LANG=en_US.utf-8 /usr/lib/heirloom/5bin/sh -c "od -x <<EOF
`printf '\xA1'`
EOF
"
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 5 09:55:35 2013 -0600
Expanded warning message for invalid Content-Transfer-Encoding.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 4 18:50:06 2013 -0600
Added reference to RFC-1864 to mhbuild man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 4 15:12:15 2013 -0500
Remove support for -ebcdicsafe/-noebcdicsafe switches in various utilities.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 4 15:03:32 2013 -0500
Create a dependency for mh-chart.man on all of the man page sources so
it gets rebuilt correctly if the man pages change.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 3 22:33:42 2013 -0600
Block SIGPIPE before killing the child in sm_end(). This replaces
the discard() calls that were removed in commit 4548a3ecc4248a1d4.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 3 22:32:28 2013 -0600
Removed discard() call in post(8). It was only used with -debug
and seemed to serve no useful purpose any more. Its comment
said that it was needed to help the loader.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 3 21:59:44 2013 -0600
In cpstripped() and cptrimmed(), if a multibyte character is
found, only count it as taking up one character in the
destination buffer (if it has enought room). This way,
scan(1)'s output won't be jagged if there are any subjects,
for example, that have multibyte characters.
Added a test for this to test-scan-multibyte, and moved the
test for an invalid multibyte sequence from test-scan to it.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 3 21:51:56 2013 -0600
Removed empty file name .null from the historical mh-6.8.5 tree.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 2 20:07:43 2013 -0600
Fixed decoding of header fields when they contain a character that
can't be converted. Added test case to test-scan. valgrind also
noticed that things went amiss.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 2 18:13:59 2013 -0600
Remove test .netrc file at the end of test-pop.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 2 15:23:29 2013 -0500
Switch to using native automake rules for cscope.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 1 22:06:33 2013 -0500
Change TLS support to only link the TLS libraries with the programs that
need them.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 1 02:40:30 2013 -0500
Clean up (and hopefully improve) the autoconf iconv tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 1 01:50:06 2013 -0500
Still MORE autoconf cleanup.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 1 01:27:08 2013 -0500
Autoconf/automake cleanup
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 1 01:01:32 2013 -0500
Document removal of --enable-nmh-debug
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 1 01:00:03 2013 -0500
Finally deprecate --enable-nmh-debug
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Dec 30 20:17:01 2012 -0500
Note changes to autoconf requirements here.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Dec 30 19:40:42 2012 -0500
We are now requiring autoconf 2.68 and automake 1.13.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 30 12:19:47 2012 -0800
Note that the minimum required version of automake is 1.12.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 30 09:38:46 2012 -0800
Ignore top-level ar-lib file.
This is detritus from the AM_PROG_AR macro I added to configure.ac.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 30 01:27:49 2012 -0800
Add an AM_PROG_AR program check to configure.ac This quells a
warning when configuring on FreeBSD 10.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 27 13:53:33 2012 -0600
Corrected fseek() emulation to fix test/bad-input/test-header.
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 27 09:51:09 2012 -0600
Replace use of ftell() in mhparse.c:get_content() by keeping track
of bytes read by m_getfld().
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 26 14:03:20 2012 -0600
Tweaked last commit to test/common.sh.in to eliminate a mv.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 26 11:09:28 2012 -0600
Added note about PATH when running "make check" on Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 26 11:04:23 2012 -0600
Fixed test-slocal to work with mmdfldir set to /dev/null, and on
Cygwin, which needs the full path to tee(1).
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 26 09:52:12 2012 -0600
Restored an explicit refill of the buffer in m_getfld() that I
removed in the big stdio cleanup. Its need is shown by reducing
the message buffer size to 2048.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 25 19:25:43 2012 -0600
Removed call to fpurge() and its platform-specific emulations
from discard.c. discard() is called on stdout from mhl(1) and
msh(1) in interrupt handlers, and post(8) but only with -debug.
tcflush() should do the purge when stdout is a terminal. If
it's a file or pipe, well, maybe some garbage could get flushed
out. And it's called on the streams that post uses to talk to
its smtp server, so removed those calls because they no longer
do anything. And removed LINUX_STDIO define from configure.ac.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 25 11:57:31 2012 -0600
Replaced all the stdio buffer access in m_getfld.c with a single call
to fread() and then some almost straightforward buffer manipulations.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 25 11:57:02 2012 -0600
Fixed formatting of last change to scansbr.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 23 09:27:03 2012 -0600
Updated m_getfld() interface description.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 22 11:51:21 2012 -0600
Changed bufsz argument of m_getfld() to be in-out instead of in.
This allowed removal of the msg_count global, in turn allowing
removal of sbr/m_msgdef.c
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 22 10:14:36 2012 -0600
Changed msg_style and msg_delim to be file static to m_getfld.c
instead of global.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 22 10:05:51 2012 -0600
Changed type of name argument to m_getfld() from unsigned char *
to unsigned char[NAMESZ].
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 22 09:51:25 2012 -0600
Added m_getfld () interface description.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 11 23:24:19 2012 -0600
Removed a few #ifndef JLR/#endif pairs because they're not needed.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 11 19:45:29 2012 -0600
Removed some dead code, all inside #if 0's. I tried to not remove
anything useful, so there are a few #if 0's remaining.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Dec 10 20:54:15 2012 -0800
Import a copy of Markus Schnalke's master's thesis: The Modern Mail Handler.
(Added with Markus' permission.)
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 10 23:23:44 2012 -0500
Remove the peeking into the stdio internals inside of scan(). Hm, this
was more complicated than I originally thought.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 10 16:01:59 2012 -0500
The beginnings of a program to test format functions/files.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 9 21:26:49 2012 -0600
Added release notes for releases 1.4 and 1.3 to tail of NEWS.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Dec 7 10:27:52 2012 -0500
mhshow: properly treat unknown multipart subtypes as "mixed"
Author: David Levine <levinedl@acm.org>
Date: Thu Dec 6 09:46:18 2012 -0600
Added test of -nosequence to test-pick.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Wed Dec 5 21:47:12 2012 -0500
pick: add -nosequence command line switch
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 3 18:45:55 2012 -0600
Note in dist, mh-profile, and repl man pages that the @ link
is only created with -atfile.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 3 08:54:21 2012 -0600
Fix to 25581a94c5113eb78b2baf7110408df96efc4418: always set $editalt,
even without -atfile.
Author: Jerrad Pierce <belg4mit@pthbb.org>
Date: Sun Dec 2 21:02:11 2012 -0600
Added docs/contrib/vpick.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 2 09:19:21 2012 -0600
Cleaned up sendfiles(1) man page just a bit.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Dec 2 09:05:37 2012 -0600
Corrected the last addition to man/nmh.man. Might be nicer to explain
the warty truth from the off.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 1 10:53:36 2012 -0600
Updated the TODO file.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 1 10:52:27 2012 -0600
Copied atexit() code from fakesmtp.c to fakepop.c so that its
pid file gets cleaned up. Also copied the sig handler.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 30 18:42:40 2012 -0600
Fixed formatting glitch in msh.man.
Author: Jerrad Pierce <belg4mit@pthbb.org>
Date: Fri Nov 30 18:40:52 2012 -0600
Added description of @folder format to nmh.man.
Merge: d6c134e8 b6f8e446
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 29 15:28:12 2012 -0500
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Nov 29 14:54:49 2012 -0500
show: remove unused variable
this should have been part of the previous removal of unreachable code.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu Nov 29 13:59:55 2012 -0500
show: remove unreachable code
the stanza in question has been impossible to reach for some time. i
believe its purpose was to give a non-mh display proc full pathname
arguments to work with. since we've chdir'd to the folder, giving it
message numbers (i.e., relative pathnames) is fine.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Nov 27 00:20:55 2012 -0500
show: remove MAXARGS limit when running any of the helper procs
use app_msgarg() to maintain both the msgs[] and vec[] string vectors.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon Nov 26 23:43:00 2012 -0500
forw: remove MAXARGS limit when running mhlproc
use app_msgarg() to maintain both the msgs[] and vec[] string vectors.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Nov 27 09:53:56 2012 -0500
burst: eliminate use of MAXARGS
use the already available app_msgarg() utility to make this easy.
(the MAXARGS limit was highly unlikely to be exceeded, in practice.)
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Nov 28 11:21:50 2012 -0500
Update about changes to rmmproc support.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Nov 27 12:05:56 2012 -0500
app_msgarg: de-obfuscate
add some whitespace and break things up. and add comment to reflect
that this might be (and is) used for more than just msg parameters.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon Nov 26 21:00:28 2012 -0500
Artificial argv limits.
when i skimmed the code earlier, i was looking at all the uses of
MAXARGS -- many of which are used to size local arrays. converting
them all to be dynamically-sized might be a fair amount of work.
but looking at rmm.c, refile.c, and folder_delmsgs(), i don't think
that issue applies. the patch below fixes the problem, and makes
rmmproc and refile do the right thing (well, at least, the modern
thing). NB: i didn't test to the limit where execvp should return
E2BIG.
as for the rest of mh -- it's certainly possible to hit the MAXARGS
limit with other commands (show, for instance), but i suspect the
frequency is much lower, and those, too, can be fixed as needed.
paul
>From 9636bc0e1697829966f51d2c301cd5d730c38c0a Mon Sep 17 00:00:00 2001
From: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Mon, 26 Nov 2012 20:49:55 -0500
Subject: [PATCH] rmm/refile: remove the MAXARGS limit when running rmmproc
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 26 11:25:31 2012 -0500
Since pick now uses decode_rfc2047, we need to be sure to link in the
iconv library (if we need it).
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 25 09:17:15 2012 -0600
In pick(1), attempt to decode each header field as if it were
MIME encoded.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 25 09:06:20 2012 -0600
In pick(1), attempt to decode each header field as if it were
MIME encoded.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Nov 25 00:49:04 2012 -0500
A new test for the POP support in inc. Very simple for now, but it seems
to at least check the basic functionality.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Nov 24 23:50:31 2012 -0500
Add support for a -nosasl switch.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 24 09:08:31 2012 -0600
Fixed pick(1) to properly unfold multiple-line header fields
by removing newlines instead of replacing them with spaces
[Bug #15215].
Author: Bill Wohler <wohler@newt.com>
Date: Sat Nov 24 01:41:06 2012 -0500
The big news for this update is nmh 1.5.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 23 20:54:28 2012 -0500
Fix the race condition with fakesmtp so it works without needing retries.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 23 19:59:37 2012 -0500
Document changes to inc.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 23 19:58:34 2012 -0500
Document the -port switch to inc. Also, fix the -port switch to inc so
it actually works.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 23 09:27:44 2012 -0600
Added test-slocal.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 23 09:26:21 2012 -0600
slocal used to support two different formats for three of
its arguments:
[address info sender]
[-addr address] [-info data] [-sender sender]
But it hasn't properly supported the first form since at
least April 1999. So, I removed that first form from the
man page and the broken support from the code. Score
another for the test suite!
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 23 09:25:15 2012 -0600
Added Message-Id to messages in test suite.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 19 19:19:59 2012 -0600
Fixed a couple of signed-unsigned comparisons.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Nov 20 00:47:24 2012 +0100
Yozo TODA: fix for mhshow-charset- directives in .mh_profile being broken
Merge: ea28cc1b c6161819
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 15:31:21 2012 -0500
Merge branch 'format-memory-rework'
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 15:29:01 2012 -0500
Make sure we strip off a newline from components we want to display (we
were stripping off a newline from the wrong copy of the component).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 14:37:14 2012 -0500
Convert repl to the new world format API.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 14:19:30 2012 -0500
Support for the new world format API for comp and forw.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 14:18:55 2012 -0500
Whoops, with the new world order we need to make sure we allocate memory
for all strings in format instructions.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 13:48:16 2012 -0500
Convert scan() to the new world format API.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 13:47:46 2012 -0500
Change fmt_findcasecmp() to fmt_findcasecomp(). The new name is more
consistent.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 12:23:16 2012 -0500
Change API a bit.
Rename fmt_addcomp() to fmt_addcomptext().
Create new function fmt_addcompentry().
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Nov 19 12:22:26 2012 -0500
Remove unused variable.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 17 12:05:22 2012 -0600
Removed leading space from lines in mhbuild and rmm man pages
to correct formatting.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 16 23:56:26 2012 -0500
Finished work on rcvdist to convert to new world format API.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 16 23:41:10 2012 -0500
More (and hopefully for now) the final cleanup for mhl.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 16 23:22:23 2012 -0500
Basic support for the new world API; seems to work!
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 16 23:21:54 2012 -0500
Add missing functions for manipulating component text.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 16 23:20:28 2012 -0500
Fix up documentation a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 21:47:59 2012 -0500
Partial work for mhl; still more stuff to do.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 21:47:36 2012 -0500
Fix missing argument to fmt_free().
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 15:53:24 2012 -0500
Beginnings of conversion of code to new format interface.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 15:50:46 2012 -0500
Update documentation to match code change.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 14:21:20 2012 -0500
Fix a few bugs:
Make sure to add a ref when adding to the hash table.
Forgot the increment the format array inside of fmt_free().
Marked an allocated string when doing FT_LIT.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 13:30:30 2012 -0500
Add some comments to explain how format loop support was supposed to work.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 11:05:55 2012 -0500
Add refcounting to struct comp.
Move CHASH and FINDCOMP into fmt_compile.c to make private.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 09:19:36 2012 -0500
Beginnings of the changes to fmt_compile for memory rework.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Nov 15 09:18:11 2012 -0500
Update with new functions and comments describing them.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 14 08:47:14 2012 -0600
Removed support for zip from sendfiles. I added it as part of the
sendfiles rewrite, f8baa5a34335fc0fc8ccabfabc601d0af73ab769, a few
weeks ago. But because sendfiles fed zip from standard input, zip
would use Zip64 extensions. That would require unzip 6.0 or later
to extract, according to the zip man page. But current MacOS X
uses unzip 5.52, so it broke there.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 13 22:35:57 2012 -0600
1) Don't bother checking stderr output from sendfiles because tar's
output format isn't standardized.
2) Added -c to uncompress.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 13 22:32:22 2012 -0600
Updated scan.highlighted to feed an expression to %(zputlit).
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Nov 13 22:23:02 2012 -0500
Make sure we stick to POSIX-sed only. I _think_ this portable enough to
work everywhere.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Nov 13 18:53:55 2012 -0500
Change %(putlit) and %(zputlit) to take TF_EXPR instead of TF_STR. This
was originally my fault; TF_STR means a string literal as an argument, but
the documentation (and the code) really means for it to take an expression.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 9 15:02:53 2012 -0600
Updated test-scan to correspond to commit
112b90c43391644f24559f5aa58752214de0e8a5.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Nov 9 14:53:21 2012 -0600
Added ml script to docs/contrib.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 9 14:39:59 2012 -0600
Refer to just "root" in slocal man page.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Nov 9 14:37:59 2012 -0600
Added ml script to docs/contrib.
Author: David Levine <levinedl@acm.org>
Date: Wed Nov 7 16:48:05 2012 -0600
In scan.highlighted, set black background on the colorized lines
to enhance visibility if the user has a light background.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 6 18:43:42 2012 -0600
Removed note from BUGS section of several man pages saying
that command line arguments must be quoted for protection from
the shell. That's not a bug, and has nothing to do with nmh.
Changed "back-quoted" to "backquoted" for consistency in a few
man pages.
Author: David Levine <levinedl@acm.org>
Date: Tue Nov 6 18:42:45 2012 -0600
Fixed typo in mhn.man.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 5 13:10:16 2012 -0600
Fixed typo in mh-format man page description of zputlit.
Author: David Levine <levinedl@acm.org>
Date: Mon Nov 5 11:25:33 2012 -0600
Added application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
for .xlsx files.
Author: David Levine <levinedl@acm.org>
Date: Sun Nov 4 20:58:47 2012 -0600
Added format support for zputlit function escape. It requires
that the str contents have zero display width, such as for
terminal escape sequences.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Nov 3 19:22:49 2012 -0700
nmh.7 isn't the place to advise people how to change their $PATH.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 3 08:13:34 2012 -0500
Fixed comparison to be signed instead of unsigned.
Author: David Levine <levinedl@acm.org>
Date: Sat Nov 3 07:37:40 2012 -0500
Added description of "all" range abbreviation.
Author: David Levine <levinedl@acm.org>
Date: Fri Nov 2 22:45:07 2012 -0500
Added argument to fmt_scan() to specify the buffer size.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 28 22:35:45 2012 -0500
Updated date on sortm(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 28 13:21:46 2012 -0500
Updated build-nmh-cygwin for release of Cygwin nmh 1.5-2. To use:
1) Change VERSION to 1.5-2.
2) make dist
3) Symlink build-nmh-cygwin to nmh-1.5-2 and run that with "all".
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 27 12:36:29 2012 -0500
Fixed typo reported by Ralph.
I also should have mentioned in the commit message for
sortm(1) -check/-nocheck that Norm proposed their addition.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 27 12:18:45 2012 -0500
In test-post-common.sh and test-mhmail, wait for fakesmtp to start
for up to 40 seconds. 10 seconds wasn't long enough when I leaned
on my machine. Also, print out a message if exiting due to that
timeout.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 27 12:14:01 2012 -0500
Added -check/-nocheck switches to sortm(1). Also removed obsolete
note in the BUGS portion of its man page about how it sorts messages
that are missing or have an invalid Date: field. It actually sorts
them using their file modification times.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 23 19:18:20 2012 -0500
Fixed typo in Cygwin section of MACHINES.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 23 19:16:56 2012 -0500
Cyrus SASL 2.1.25 introduced the sasl_callback_ft prototype,
which has an explicit void parameter list, according to best
practice. So we need to cast to avoid compile warnings.
And provide a sasl_callback_ft prototype for earlier versions.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 21 12:39:43 2012 -0700
Clarify that manpage references use the .IR macro everywhere.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 21 12:38:40 2012 -0700
Fix one last missed %nmhdate% substitution.
Remove empty CONTEXT section.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 21 12:37:49 2012 -0700
Remove %nmhdate% substitution from man.sed. It's no longer used.
Merge: 9dedfb15 cbaaccc1
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Oct 21 12:33:21 2012 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 21 12:02:40 2012 -0500
Corrected date in sendfiles.man
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 21 09:52:46 2012 -0500
Updated sendfiles(1):
1) Added -from switch.
2) sendfiles will now construct a From address, using the sender's
localmbox, if the user does not specify it with -from or the PERSON
environment variable.
3) Added support for bzip2, lzma, and zip compression methods. Added
a new switch to select the method: -compress <method>. Because
support for the old -compress with was broken (it did not use
-c with compress/uncompress) and it was undocumented, it has
been replaced. Retained old -gzip and -none switches for backward
compatibility even though they were undocumented.
4) Allow the recipient argument to be preceded by the optional -to
switch iff the subject argument is preceded by the optional
-subject switch. Allow the delay value to be specified using the
optional -delay switch.
5) Added -version and -help switches.
6) All switches can now be abbreviated.
/etc/sendfiles no longer needs to be configured. It's easier to
support make distcheck by having it figure out its path at runtime.
In viamail, set postproc to post in the same directory as itself, if
invoked with a full path. This allows it to support make distcheck.
viamail does not read the profile so its postproc is otherwise
hard-coded at compile time.
Added test-sendfiles.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Oct 20 16:51:01 2012 -0700
Update the manpage style guide.
Merge: d1cb667b a69289ce
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Oct 20 15:02:16 2012 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Oct 20 14:42:32 2012 -0700
Rationalize .TH manpage macro invocations.
This patch addresses the following issues with .TH macro usage:
.TH COMP %manext1% "%nmhdate%" MH.6.8 [%nmhverion%]
1) "MH.6.8" is no longer relevant.
2) %nmhdate% is a hardwired value that only gets updated along with
%nmhversion% and is therefore redundant.
This patch nukes the MH.6.8 tag, and replaces the hardwired
%nmhdate% field with the latest date the associated manpage has
been updated. I pulled the dates - as best I could - from the
git logs.
Going forward, it is incumbent on developers to update the
manpage date stamps as they update the pages themselves.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 20 16:40:06 2012 -0500
Cleaned up a couple of shell variables.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 20 16:39:25 2012 -0500
Fixed the trap to work with posh.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 20 10:41:43 2012 -0500
Fixed printf's in test suite.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 20 07:44:34 2012 -0500
Fixed the trap in mhmail.
Author: David Levine <levinedl@acm.org>
Date: Fri Oct 19 14:23:17 2012 -0500
Cleaned up uip/mhmail. Added chmod +x of spost in configure.ac.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 20:18:03 2012 -0700
Manpage cross-reference cleanups: convert '.BR cmd (section)' to '.IR cmd (section)'
throughout the text.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 19:48:02 2012 -0700
A couple more manpage typo cleanups.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 19:45:38 2012 -0700
Typo.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 19:39:37 2012 -0700
Manpage SEE ALSO cleanup.
Convert to '.IR cmd (section)' format for manpage references.
Fixed a couple of inline '.BR cmd (section)' instances as well.
Removed HISTORY from new(1); this stuff doesn't belong in manpages.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 18:20:18 2012 -0700
Elide spurious empty lines in manpage source files.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 17:29:30 2012 -0700
Ensure the .TH macro is the first line of the manpage source files. Some
versions of man(1) get upset if .TH doesn't come first.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 17:08:17 2012 -0700
Update the manpage authors guide, primarily for .TP, but also fixes
a couple of other incorrect style recommendations.
These updates are incomplete ... more to follow.
Merge: 956ddacc e2d655de
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 16:40:17 2012 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 16:32:48 2012 -0700
Incorporate Paul Fox's changes that group the commands by functional groups.
Move the "generated code" warning comment below the .TH macro to work around some buggy
man(1) implementations.
Removed all the .RS/.RE indenting and replaced the use of .fc and tab indenting
with .TP macros.
Move the BUGS section below SEE ALSO to follow the usual section ordering convention.
Fixed up some italic vs. bold usage.
Use '.IR foo (section)' in the SEE ALSO section.
Removed some irrelevant text, along with a small amount of word-smithing.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 16 14:53:04 2012 -0500
Unset PAGER in test/common.sh so that make distcheck passes.
Merge: a7b486a1 342e3551
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 12:39:59 2012 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 12:36:30 2012 -0700
Add new make targets 'man' and 'cleanman' to build and clean just
the man/ sub-directory. I also removed the '@' supressors for the
internal manpage targets. There's no net benefit to hiding this stuff.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 16 13:27:32 2012 -0500
Cleaned up some printf's.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 16 13:23:43 2012 -0500
Updated sendfiles(1) man page to reflect upcoming code update.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Oct 16 11:12:27 2012 -0700
Some version of man(1) barf if the first line of the manpage is not
the .TH macro. Re-order the generated mh-chart.man so that the 'auto-generated'
comment appears after the .TH macro.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Oct 15 17:08:29 2012 -0700
Slightly reformat the FINDCOMP macro to quell a clang warning about
an empty for()-loop body.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Oct 15 17:06:40 2012 -0700
automake 1.12 generates some (apparently) harmless warnings, but the build
fails becuase we invoke automake with -Werror. Remove -Werror from the
automake options until the autotools gurus can patch things up.
Merge: 5548c9aa 47dca820
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Oct 15 15:22:39 2012 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Oct 15 15:21:48 2012 -0700
Allow $PAGER to override the compiled-in default pager command.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 14 21:13:05 2012 -0500
Removed unused function seek_home().
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 14 19:27:17 2012 -0500
The first alias contained in a blind list is now expanded. The
mh-alias(5) man page was updated to show that blind lists must not
be terminated with, or contain, a trailing semicolon [Bug #15604].
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 14 19:02:43 2012 -0500
Changed error message to say that blind lists aren't
compatible with sendmail/pipe.
Author: Ralph Corderoy <ralph@inputplus.co.uk>
Date: Sun Oct 14 18:59:06 2012 -0500
Fixed "mark -sequence cur -delete all" to work for cur as
well as any other sequence, to allow clearing of the current
message indication.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 13 18:00:39 2012 -0500
Don't allow blind aliases with sendmail/pipe mts. Before this change,
they would be fed to sendmail, which would reject them anyway. This
change catches that in post and presents a more helpful error message
to the user (at the "What now?" prompt, if used).
A possible future enhancement might be, with sendmail/pipe, to expand
out blind aliases and put the addresses in Bcc: header fields, but
then the recipients would get messages with the Blind-Carbon-Copy
indication. (Note that Dcc isn't supported with sendmail/pipe,
either.)
Just for information: old spost fed the addresses of blind aliases to
sendmail, making them visible to all recipients. Oops.
Author: David Levine <levinedl@acm.org>
Date: Sat Oct 13 09:56:08 2012 -0500
Removed potential buffer overflow in ali.c by replacing array of
hard-coded maximum size with dynamically-sized array.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 11 23:00:43 2012 -0500
Fixed sortm(1) verbose message and man page to reflect that with
-limit 0, the sort is only on the text field.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 11 21:48:42 2012 -0500
Added -noall/-all switches to sortm(1).
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 7 22:55:33 2012 -0500
Fixed typo in mh-alias man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 7 11:25:01 2012 -0500
Added newline to "send" that's piped to dist. Old 2.6 Linux
needs it.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 7 10:31:12 2012 -0500
Added test-anno, test-dist, test-msgchk, and test-rcvtty.
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 7 10:27:31 2012 -0500
Changed nmh-fcc to fcc. See etc/forwcomps. Another catch by the
test suite!
Author: David Levine <levinedl@acm.org>
Date: Sun Oct 7 10:18:54 2012 -0500
Updates to test/common.sh.in:
1) Added function check_for_hard_links. Moved this code out of
test-refile so that other tests can use it.
2) Added mmdfldir and mmdflfil settings to the mts.conf for tests, to
support test-msgchk.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 23 09:02:18 2012 -0500
Removed double quotes around case arguments in test scripts.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 23 09:00:11 2012 -0500
When determining the path of the script inside mhmail, handle case
where $0 is just the script name, without any directory. Bourne
shell does that if the script is found using PATH.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 18 22:18:21 2012 -0500
Disabled echo of rm -f lines in Makefile to quiet builds and
installs a bit.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 18 22:00:00 2012 -0500
Replaced spost with script that exec's post -mts sendmail/pipe.
Author: David Levine <levinedl@acm.org>
Date: Mon Sep 17 19:42:27 2012 -0500
Removed mhmail.c because it was no longer needed and could get in
the way of make if its timestamp was newer than that of the mhmail
script. Thanks to Johan Viklund for reporting this.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 16 23:12:19 2012 -0500
For the mhstore -clobber test, cd to the Mail subdirectory so that
the stored files will get cleaned up by the exit trap in common.sh.
Merge: b471d7a3 2b7b705f
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Sep 16 14:39:27 2012 -0700
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Sep 16 14:38:54 2012 -0700
Fix a comment typo.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 16 13:54:23 2012 -0500
With mhstore -clobber auto/suffix, when looking for a new filename,
actually open(2) the file with O_CREAT | O_EXCL to avoid the race
condition when figuring out the filename first and opening it later.
Author: David Levine <levinedl@acm.org>
Date: Sun Sep 16 12:45:12 2012 -0500
Added "-d --" to invocation of ls when figuring out what files
to attach in whatnow.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 15 21:18:38 2012 -0500
Fixed description of n with mhstore -clobber auto/suffix.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 15 14:07:07 2012 -0500
Clarified description of clobber -auto/-suffix per Ralph's suggestion.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 15 13:40:50 2012 -0500
Added -clobber switch to mhstore(1) [Bug #11160].
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 15 13:14:18 2012 -0500
Changed ; to && in shell command, per Ralph's suggestion. There
were two remaining places that still used ";". Though they
weren't of consequence, it's the right thing to do.
Author: David Levine <levinedl@acm.org>
Date: Sat Sep 15 08:24:37 2012 -0500
Allow whatnow to accept "l" as an abbreviation for "list", instead of
requiring at lest "li".
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 14 20:46:02 2012 -0500
Filter out all Nmh-* headers in post(1). Do that silently for empty
ones (no header body), and warn about non-empty ones.
Author: David Levine <levinedl@acm.org>
Date: Fri Sep 14 17:05:24 2012 -0500
Added check in send(1) of attach (default Nmh-Attachment) headers to
ensure that only plain files are attached. Otherwise, it is a fatal
error. Note that whatnow's attach will continue to allow attachment
of directories because it expands those out to their contents. It
doesn't check what the contents are, though. That's why we needed to
add this check.
Also added a check to skip attach headers that are empty so that
they can be put in drafts, per Norm's request.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 11 08:44:43 2012 -0500
Updated docs/README-ATTACHMENTS, mainly to reflect that no setup is
required with nmh 1.5 and beyond. And the user documentation is in
the send(1) and whatnow(1) man pages.
Author: David Levine <levinedl@acm.org>
Date: Tue Sep 11 08:42:58 2012 -0500
Added references to the whatnow(1) man page description of its
attach support to the nmh(7) and send(1) man pages.
Author: Eric Schnoebelen <eric@cirr.com>
Date: Fri Aug 31 09:49:37 2012 -0400
Move chdir() call so -recurse option works again.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Aug 31 09:46:03 2012 -0400
New test for folder -recurse
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Aug 23 10:08:59 2012 -0400
Change the Bcc: code in post so it includes the From: header from the original
message.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 17 19:31:22 2012 -0500
Cleaned up message_id().
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 17 19:29:49 2012 -0500
Removed chmod of bccfil from make_bcc_file(). It was done before
bccfil was defined so it had no useful effect. m_mktemp2() sets
the umask so it wasn't necessary, anyway.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 10 05:20:25 2012 -0500
Cleaned up test-utf8-body a bit.
Author: David Levine <levinedl@acm.org>
Date: Fri Aug 10 03:33:38 2012 -0500
Added mhbuild: -nocontentid to profile used for tests, to simplify
output checking.
Author: David Levine <levinedl@acm.org>
Date: Thu Aug 9 17:13:38 2012 -0500
Added default_content_type argument to
make_mime_composition_file_entry(). It's used only to force message
bodies to always use text/plain content type, which allows mhbuild to
do the right thing with them. Thanks to Steve Rader for reporting
that UTF-8 characters in message bodies had previously caused them to
be encoded as octet-streams (with attachments managed by send), and to
Ken for coming up with the fix.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 23 18:17:11 2012 -0500
Removed nmh-from condition from rcvdistcomps.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 22 20:19:19 2012 -0500
Fixed explanation of why the unset SHELL test is uselessif /bin/sh is bash.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 22 12:04:47 2012 -0500
Reworked test-rcvdist so that it sees the output of post.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 22 12:03:36 2012 -0500
Added test of whatnow with SHELL unset to test-ls, though it doesn't
reveal anything on Linux, at least.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Sun Jul 22 12:01:00 2012 -0500
whatnow cooks up strings for executing external commands, and then
feeds these strings to popen or system. These command strings rely on
$SHELL being present - and if that is not the case, then we get weird
error messages ("sh: -c not found" or similar). (Because both
system() and popen() start up fine with the std shell, but their arg
string to parse doesn't include a cmdname/path before the -c.)
As far as i understand the POSIX standard, SHELL is recommended but
not actually mandatory, so i think it would be good to handle this a
bit more robustly: by setting SHELL to /bin/sh if not present.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 20:00:14 2012 -0500
Tidied up for loop in message_id().
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 19:45:48 2012 -0500
With -messageid random, make the part after the @ more resemble a
hostname by inserting a couple of dots, and using - and _ instead of
+ and /.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 16:17:41 2012 -0500
Added -messageid switch to send(1) and post(8). This allows selection
of the style to use for generated Message-ID and Content-ID header
fields. The default localname style is pid.time@localname, where time
is in seconds, and matches previous behavior. The random style
replaces the localname with some (pseudo)random bytes and uses
microsecond-resolution time.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 12:42:14 2012 -0500
Here's a better test of Resent-From: in test-rcvdist: use the user's
actual localmbox.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 12:19:18 2012 -0500
Added check to notpost for presence of Resent-From:.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 12:01:41 2012 -0500
If post or send fail, exit with their exit status.
Author: David Levine <levinedl@acm.org>
Date: Sat Jul 21 11:58:57 2012 -0500
Removed #ifndef RAND/#endif that no longer had any effect.
Author: Harvey Eneman <harvey.eneman@oracle.com>
Date: Sat Jul 21 11:57:29 2012 -0500
Fixed the default rcvdistcomps and rcvdistcomps.outbox to to insert
the Resent-From: header.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 15 13:35:42 2012 -0500
Removed debugging statement and added comments to the duplicate check
of readconfig ().
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 11 21:37:39 2012 -0500
Added -mts switch to post, send, and whom. Replaced test-sendmail-pipe
with test-mts.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 9 22:49:59 2012 -0500
Removed -m from sendmail invocation with sendmail/pipe. Modern
sendmail and postfix, at least, ignore it.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 9 21:25:36 2012 -0500
Correction to previous commit, 704bdde497da69854846d51d86c440fc980c5489,
to restore the behavior when using SMTP and with any blind addresses.
Don't quit the SMTP session between sending the message and bcc's, but
instead reset it.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 9 19:47:47 2012 -0500
Removed use of the ONEX sendmail verb. It is obsolete,
according to http://smtpfilter.sourceforge.net/esmtp.html.
And was removed over 10 years ago from sendmail (8.12),
according to http://www.irbs.net/internet/postfix/0111/2237.html.
Author: David Levine <levinedl@acm.org>
Date: Mon Jul 9 19:15:13 2012 -0500
Renamed "sendmail" mts method to "sendmail/smtp", allowing "sendmail"
as an alias. Renamed "pipe" to "sendmail/pipe".
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 8 23:17:04 2012 -0500
spost(8) has been merged into post(8). Its functionality is
enabled by selecting the "pipe" mail transport method in
etc/mts.conf, which in turn can be configured using
--with-mts=pipe. The spost -noalias, -backup/-nobackup,
-push/-nopush, and -remove/-noremove switches are not
supported by post. Note that spost did not support -whom or
Dcc, and neither does post when using mts: pipe. spost is
now deprecated.
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 4 09:57:49 2012 -0500
Added test-packf.
Author: David Levine <levinedl@acm.org>
Date: Wed Jul 4 07:27:15 2012 -0500
test-prompter: removed an unused input that was piped to the
program because it sometimes caused printf to complain about a
write error.
Author: David Levine <levinedl@acm.org>
Date: Tue Jul 3 20:50:23 2012 -0500
Filtered out "From " lines when comparing mboxes because their
timestamps sometimes differed by a second.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 20:20:42 2012 -0500
Updated pending-release-notes.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 19:24:36 2012 -0500
Rather than fix the reported bug, backslash in commented lines
in alias file is interpreted, I documented that behavior in
the mh-format man page and etc/MailAliases. This behavior is
unfortunate, but it is a result of the implementation of nmh's
vfgets() function. That function is used by other callers
that expect the behavior. [Bug #23553]
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 19:20:22 2012 -0500
Added test-dp, test-fmtdump, test-prompter, test-rcvstore,
test-rcvpack, and test-rcvdist.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 16:44:43 2012 -0500
Applied patch #5571, Propagate Mail-Followup-To.
Also clarified man page: replgroupcomps won't be used if you
specify another forms file on the command line or in your profile.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 10:21:22 2012 -0500
Added note that mhmail does not read context file itself.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 10:09:06 2012 -0500
Removed unused #ifdef NRTC and reference to its contents in the
rcvdist man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 09:14:27 2012 -0500
Updated man page descriptions of Msg-Protect: it defaults to 0600 and
is not supported on some filesystems, such as FAT32.
Author: David Levine <levinedl@acm.org>
Date: Sun Jul 1 08:32:18 2012 -0500
Wrapped some shell variables with quotes so the tests have a chance of
running if the current directory has a character such as a space in
it. Though the tests themselves need the same help for them to work.
Also, added mention of Heirloom shell to test/README.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 28 21:59:47 2012 -0500
Replaced utilities that operate on pbm files with those that operate
on pnm files, per the bug report referenced below (from Dec 2005!).
And changed the mhshow-show-image/x-pbm mime type to
mhshow-show-image/x-pnm. [Bug #15152]
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 28 21:19:06 2012 -0500
Removed BUGS section at end of rcvstore(1) man page. It
said to not use rcvstore if you use the "Unseen-Sequence"
profile entry because the context (sequences file, actually)
could be corrupted if multiple nmh processes tried to update
it simultaneously. The locking added by commit
82a21b6f3cddf8ab048dcb02c080ea9797c73c5a serialized that
simultaneous update. [Bug #4361]
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 28 21:12:13 2012 -0500
Removed the one remaining unused #ifdef ISI.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 28 21:11:07 2012 -0500
Simplified getm() a bit, removing a goto.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 28 20:59:23 2012 -0500
Fixed ismymbox() to look at Local-Mailbox as well as
Alternate-Mailboxes. The problem was that when an alternate
mailbox was added to the list, the node for the local
mailbox information was lost. Added check to test-mymbox.
Added test-repl, because this is where it was first noticed.
Also enhanced output with MHWDEBUG set to show the entire
list, not just each alternate mailbox as it is added to the
list. [Bug #36635].
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 25 08:42:14 2012 -0500
Deprecated mhtest.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 25 08:21:03 2012 -0500
Removed unused UUCPDIR and UUCPFIL #defines.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 24 22:26:27 2012 -0500
Added test-sortm. Also clarified some details in the sortm man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 24 19:03:05 2012 -0500
Added status to conflict(8) man page to note that it is deprecated.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 23 09:55:01 2012 -0500
Allow optional -to in front of To: addresses with mhmail.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 23 08:04:08 2012 -0500
Added checks for missing mandatory arguments to mhmail.
Author: David Levine <levinedl@acm.org>
Date: Fri Jun 22 10:45:33 2012 -0500
Changed -header-field to -headerfield. And refer to its argument
as name:value instead of name:body, to avoid the obvious confusion.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Thu Jun 21 11:11:40 2012 -0700
Default to flock() locking on OpenBSD and Darwin.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 20 19:19:31 2012 -0500
Refined 48959daf724bb10802ca489654035f69e701efc0 by setting up a
LN variable in the Makefile that can be used to override the
link command at install time. For example, on Cygwin, LN will be
configured to cp. If installing on an NTFS filesystem, the user
could install with make LN=ln to use ln instead of cp.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 20 19:16:18 2012 -0500
Truncated -help test in test-whom because its output depends on whether
sasl support was configured in. It's not configured in by distcheck.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 20 09:09:24 2012 -0500
For whatever reason, gcov got fooled by test-whom until a test of
-help was added.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 20 08:13:46 2012 -0500
Quoted a bunch of shell variables in build_nmh.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 21:30:54 2012 -0500
Added test-ali.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 20:36:14 2012 -0500
Added printout to build_nmh to report number of tests not run.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 20:15:18 2012 -0500
Added a few clarifications and more DEFAULTS to mhmail(1) man page.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 19:54:04 2012 -0500
Refinement to e30560d793ff5bc704dadc2eab9d31100ad4636b: don't
warn about profile components that are null, e.g.,
: This could be a comment.
or just a hash, e.g.,
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 10:29:47 2012 -0500
Changed permissions from 0755 to 0644 on a few .c files.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 10:25:54 2012 -0500
Forget to add test/mhmail/attachment.txt to last commit.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 19 10:13:28 2012 -0500
Added -attach switch to mhmail.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 18 21:49:01 2012 -0500
Moved test-mhmail to its own test directory.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 18 21:30:58 2012 -0500
Added mention of checkbashims script to test/README. And fixed
false positive that it reported for test-mhmail.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 18 21:28:26 2012 -0500
Added -header-field switch to mhmail.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 18 18:25:10 2012 -0500
Added Jerrad Pierce's suggestion to use -editor prompter.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 17 22:56:23 2012 -0500
Removed possible tmp file leak.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 17 22:51:51 2012 -0500
mhmail now supports -profile -resend.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 17 20:59:16 2012 -0500
Here's a better fix that e194fdf11df779597e19039a67454e9b42a77ef0
for support `mhparam libdir` under "make distcheck": explicitly
set libdir in the profile.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 17 15:25:28 2012 -0500
Replaced mhmail -debug switch with -nosend, and added -send.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 17 14:35:14 2012 -0500
Added -resent support to mhmail. It doesn't work with -profile, though.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 16 10:56:53 2012 -0500
Fixed warning introduced by last change to man/mhmail.man.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 16 10:08:18 2012 -0500
Removed extra [ from synopsis.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 16 09:24:29 2012 -0500
Replaced compiled mhmail with script that was formerly named mhmail.in.
Added test-mhmail.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 16 09:16:18 2012 -0500
Reworked to be as compatible as possible with compiled mhmail.
Author: David Levine <levinedl@acm.org>
Date: Fri Jun 15 21:00:28 2012 -0500
Added mention of mhmail as a message composition utility.
Author: David Levine <levinedl@acm.org>
Date: Fri Jun 15 20:53:03 2012 -0500
Added nmh lib directory to PATH in setup_test (). This is necessary
with "make distcheck" for scripts to access the lib directory that it
installs for testing. (The distcheck target does not configure them;
they retain their build configuration.) If we ever add a test for
etc/sendfiles, we'll have to deal with its configured %libdir%.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 14 23:28:05 2012 -0500
Fixed temporary autoconf workaround by hard-coding nmhbindir.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 14 23:17:33 2012 -0500
Add trailing newline to body, if needed.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jun 14 10:36:09 2012 -0400
Fix test for changes to mhparam.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jun 14 10:33:21 2012 -0400
Make the base64 encoder endian-agnostic, and remove the function
set_endian() since it's no longer needed.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 14 09:10:23 2012 -0500
Documented mhparam -debug option.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 14 08:54:35 2012 -0500
If heirloom shell is in /usr/lib/heirloom/5bin/sh, use it to run tests.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 14 08:35:14 2012 -0500
If post/send fail, save the draft in dead.letter, the same as
compiled mhmail.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 14 08:30:30 2012 -0500
Added etcdir and libdir. And added mention that component name
matching is case-insensitive.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Thu Jun 14 07:31:40 2012 -0500
The base64-decoder doesn't work on 64-bit big-endian architectures:
mhstore and co. write files of the correct length but which consist
only of \0s.
The culprit is uip/mhparse.c, which contains a pretty ugly base64
decoder (in two places). that thing allocates a "long int" as a
container for the 24 bits that you get from four base-64 chars. the
container is then accessed both as a single entity and as a byte
array, which naturally depends on how wide the long int is and in what
order things end up in there.
The code distinguishes between big- and little-endian systems but
wrongly assumes that sizeof(long int) == 4, which isn't universally
true (quel surprise...).
The attached patch fixes the issue, but in the long run we should
insist on posix and use a64l().
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 23:12:22 2012 -0500
Support empty message body in mhmail.in the same way as in mhmail.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 22:59:05 2012 -0500
Added support to mhmail.in to read message from stdin.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 22:32:46 2012 -0500
Removed newline before generated From:.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 22:19:19 2012 -0500
Added mhmail.in. start of a replacement for compiled mhmail.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 22:18:43 2012 -0500
Removed unnecessary comment.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 22:16:46 2012 -0500
Removed another faceproc relic.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 13 08:55:19 2012 -0500
Added BUGS section to mh-tailor man file to note that failure to open
mts.conf is silently ignored.. And added to its DEFAULTS section.
Also changed to consistent use of "mail transport configuration file".
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 12 21:36:16 2012 -0500
Generate a From: header, using localmbox, if the user doesn't provide
a -from when sending with mhmail.
Author: David Levine <levinedl@acm.org>
Date: Tue Jun 12 21:16:34 2012 -0500
Fixed the export of LC_ALL so that it work with old Bourne shell.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Tue Jun 12 21:06:44 2012 -0500
Occasionally the post tests attempt to talk to fakesmtp before that
has completly started up. Inserted a check between starting up
fakesmtp and talking to it, and delay and retry if necessary, to
avoid that scenario.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Tue Jun 12 19:11:57 2012 -0500
Changed remaining uses of MAXPATHLEN to PATH_MAX.
Author: David Levine <levinedl@acm.org>
Date: Mon Jun 11 22:02:55 2012 -0500
Can't use -ansi with gcc 4.5.3 on Cygwin, at least through setup
setup version 2.763, because it disables some features in the
system system header files. Added configure check, when using gcc,
for -ansi (and don't use -pedantic without it).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jun 11 00:26:21 2012 -0400
Fix typo in gpg command and handle the .sig file properly.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 10 22:50:24 2012 -0500
Replaced run-time detection of hard-link support with compile- time
detection. This way, Cygwin packages can be built on NTFS or other
filesystems but still bee installed on FAT file systems, which do not
support hard links.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 10 09:58:52 2012 -0500
Added section 7 to man pages.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 10 09:53:48 2012 -0500
Updates to SPECS/build-nmh-cygwin:
1) Configure with sysconfdir=/etc/nmh so to minimize pollution of /etc.
2) Disabled install_docs because nmh's make install takes care of it.
Though it installs in /usr/share/doc/nmh/ instead of
/usr/share/doc/nmh-<version>/, that seems to be more common on Cygwin
than using the -<version>.
3) Added comments (also added to MACHINES) about the packages that would
be needed to configure with --with-cyrus-sasl and --with-tls.
Author: David Levine <levinedl@acm.org>
Date: Sun Jun 10 09:51:03 2012 -0500
Moved nmh and mh-chart man pages from section 1 to section 7.
Alexander Zangerl noted that Debian already did this, and it
seems appropriate.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Sun Jun 10 09:20:08 2012 -0500
Corrected install-mh man page to show that it is installed in section 1, not 8.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Sun Jun 10 09:19:20 2012 -0500
Ensure that writes to /dev/tty succeed to determine if it is writeable.
Author: Alexander Zangerl <exmh@bin.snafu.priv.at>
Date: Sun Jun 10 09:18:22 2012 -0500
Use cat for moreproc in testsuite in case it is run without tty.
Author: David Levine <levinedl@acm.org>
Date: Sat Jun 9 09:31:19 2012 -0500
Added warning to all nmh programs for multiple profile entries for the
same component. Until now, all but the first were silently ignored.
Author: David Levine <levinedl@acm.org>
Date: Fri Jun 8 20:59:32 2012 -0500
Added INSTALL, NEWS, and README to dist_doc_DATA so that they get installed.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 7 22:07:54 2012 -0500
Changed repl and dist default to -noatfile.
Author: David Levine <levinedl@acm.org>
Date: Thu Jun 7 11:07:00 2012 -0500
Removed docs/pending-release-notes-tmp, which was added by mistake.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 6 22:41:29 2012 -0500
Removed faceproc support, deprecated in nmh 1.5.
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 6 22:02:21 2012 -0500
Removed the following environment variables, deprecated in nmh 1.5:
MHPOPDEBUG (use -snoop command line switch instead)
MM_NOASK (use -nolist and -nopause command line switches instead)
NOMHNPROC (use -nocheckmime command line switch instead)
Author: David Levine <levinedl@acm.org>
Date: Wed Jun 6 21:08:53 2012 -0500
Changed exit status of each nmh command's -version and -help switches
from 1 to 0.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jun 3 15:38:39 2012 -0400
Fix incorrect documentation about the install process for files in 'etc'.
Noted by Norm Shapiro.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jun 3 15:29:27 2012 -0400
One more lowercase for the content-transfer-encoding.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jun 1 10:25:37 2012 -0400
Fix off-by-one error, noticed by Ralph Corderoy.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Thu May 31 15:15:36 2012 -0400
Implement the following changes:
- Special #on/#off/#pop directives to control the MIME directive
processing state
- A flag (-directives) to control whether or not mhbuild will honor MIME
directives by default.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu May 31 14:56:47 2012 -0400
Convert the content-transfer-encoding to lower-case always.
Author: David Levine <levinedl@acm.org>
Date: Tue May 29 07:57:30 2012 -0500
Unset MM_CHARSET so it doesn't interfere with test-scan-multibyte.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat May 26 01:55:08 2012 -0400
Support for handling multibyte encodings in cpstripped(), which
means that multibyte character encodings should work correctly
on all systems which support the POSIX wide character functions.
Author: David Levine <levinedl@acm.org>
Date: Wed May 23 22:16:14 2012 -0500
Update the current folder and current message and synchronize
sequences before showing the messages instead of after. This
way, the context will be updated even if the user exists while
viewing the messages.
Author: David Levine <levinedl@acm.org>
Date: Mon May 21 20:05:19 2012 -0500
comp and dist cannot take multiple message arguments. mhbuild does
not set context.
Author: David Levine <levinedl@acm.org>
Date: Mon May 21 20:03:57 2012 -0500
Changed wording to say that the last message selected (not necessarily
shown) will become the current message. That's consistent with the
mhlist and mhstore man pages.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu May 17 08:34:29 2012 -0400
Minor changes to replyfilter to make it compatible with older versions of Perl.
Author: David Levine <levinedl@acm.org>
Date: Sat May 12 11:02:21 2012 -0500
Used this version, renamed nmh-1.5-1.sh, in application for Cygwin package.
Author: David Levine <levinedl@acm.org>
Date: Sat May 12 09:30:27 2012 -0500
Allow selection of locking type.
Author: David Levine <levinedl@acm.org>
Date: Sat May 12 07:44:16 2012 -0500
SIGNATURE/Local-Mailbox are not used by post, but just by front
ends (comp, forw, repl, etc.) that read the profile.
Author: David Levine <levinedl@acm.org>
Date: Thu May 10 21:23:09 2012 -0500
Don't test with sendmail because it would really send the mail. If
configured to use sendmail, change the mts.conf used by the test suite
to use smtp instead.
Author: David Levine <levinedl@acm.org>
Date: Wed May 9 22:05:28 2012 -0500
Wrap local part (username) of address with double quotes if needed.
Author: David Levine <levinedl@acm.org>
Date: Tue May 8 22:19:29 2012 -0500
Skip the Cygwin package (.bz2) file when searching for the input (.gz) file.
Author: David Levine <levinedl@acm.org>
Date: Tue May 8 20:29:57 2012 -0500
Added test script constructs to avoid.
Author: David Levine <levinedl@acm.org>
Date: Tue May 8 10:16:46 2012 -0500
Fixed patch section of prep().
Author: David Levine <levinedl@acm.org>
Date: Tue May 8 10:16:17 2012 -0500
Added MACHINES to EXTRA_DIST so that it gets put in the distribution.
Author: David Levine <levinedl@acm.org>
Date: Mon May 7 18:35:28 2012 -0500
Removed locking type selection from build_nmh now that it's in configure.
Author: David Levine <levinedl@acm.org>
Date: Mon May 7 18:33:18 2012 -0500
build-nmh-cygwin no longer needs to DISABLE_SETGID_MAIL now that configure
uses fcntl on Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Mon May 7 17:25:43 2012 -0500
Added -ansi -pedantic with gcc.
Author: David Levine <levinedl@acm.org>
Date: Mon May 7 16:45:32 2012 -0500
Added $(TESTS_SHELL) at end of TESTS_ENVIRONMENT. This lets the
user run the tests using a shell other than the default /bin/sh
by using, e.g., make check TESTS_SHELL=/bin/bash. Thanks to
Tom Lane <tgl@sss.pgh.pa.us> for suggesting this.
Author: David Levine <levinedl@acm.org>
Date: Mon May 7 16:35:16 2012 -0500
Fixed some more problems caught by gcc -ansi -pedantic.
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon May 7 16:14:37 2012 -0500
Fixed places in the code relying the C99-ism of declarations in the
midst of a code block.
Author: David Levine <levinedl@acm.org>
Date: Mon May 7 08:57:38 2012 -0500
Removed --enable-pop and SETGID_MAIL= from nmh.spec.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon May 7 09:45:38 2012 -0400
Fix test so it will work on terminal widths other than 80.
Author: David Levine <levinedl@acm.org>
Date: Sun May 6 21:53:18 2012 -0500
Default to fcntl locking for AIX, Cygwin, and Linux. Without it
on Cygwin, nmh is unusable on FAT32 filesystems.
Default to flock on FreeBSD.
Author: David Levine <levinedl@acm.org>
Date: Sun May 6 21:52:22 2012 -0500
Added note about test/inc/test-deb359167 failing because valgrind
detects use of an uninitialized variable on older Linux distributions.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun May 6 13:41:07 2012 -0400
Fix the case of the MacOS X dSYM directories.
Author: David Levine <levinedl@acm.org>
Date: Sun May 6 11:14:49 2012 -0500
Remove any existing Local-Mailbox: profile component before adding one.
Author: David Levine <levinedl@acm.org>
Date: Sun May 6 10:59:42 2012 -0500
Added check for EPERM when checking errno after a failed link(2).
Cygwin will produce that on FAT32 filesystems. Must do this at
runtime rather than configure time because link() succeeds on
NTFS filesystems.
Author: David Levine <levinedl@acm.org>
Date: Sat May 5 10:05:36 2012 -0500
Check for success of hard links of bin files. If they fail, try sym
links. On Cygwin, the choice of ln or ln -s must be made at install
time, not configure time, because some filesystems (NTFS) support hard
links but others (FAT32) don't. Fallback to cp -p, though might not
be needed, just in case.
Author: David Levine <levinedl@acm.org>
Date: Sat May 5 10:04:35 2012 -0500
Customized generic SPECS/build-nmh-cygwin for nmh.
Author: David Levine <levinedl@acm.org>
Date: Sat May 5 09:54:10 2012 -0500
Replaced mh_profile man page hard link with new man/mh_profile.man.
The hard link isn't be supported by SPECS/build-nmh-cygwin. And it's
consistent with the handling of other aliased man pages.
Author: David Levine <levinedl@acm.org>
Date: Sat May 5 09:16:49 2012 -0500
Added SPECS/build-nmh-cygwin. This version isn't ready: it's
a renamed download of
http://sourceware.org/cgi-bin/cvsweb.cgi/~checkout~/packaging/templates/generic-build-script?content-type=text/plain&cvsroot=cygwin-apps
It's committed in its original form so we can easily view changes
to it.
Author: David Levine <levinedl@acm.org>
Date: Sat May 5 09:14:48 2012 -0500
Moved nmh.spec to new SPECS directory.
Author: David Levine <levinedl@acm.org>
Date: Mon Apr 30 21:56:26 2012 -0500
Removed documentation of obsolete WHATNOW configuration option and
built-in FTP client. Removed some completed and obsolete tasks from
TODO.
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 28 15:56:36 2012 -0500
Allow a user to enable setgid of inc when running distcheck with:
make distcheck DISTCHECK_CONFIGURE_FLAGS=DISABLE_SETGID_MAIL=0
though that's probably never going to be used.
(cherry picked from commit b83b264039d4245810cb845a540c024032a45ac4)
Author: David Levine <levinedl@acm.org>
Date: Sat Apr 28 07:55:16 2012 -0500
Disable setgid of inc (SETGID_MAIL=1) when running distcheck.
(cherry picked from commit 9ba93ac9c535b678bb602094997a797ba8b33666)
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Apr 27 18:31:36 2012 -0700
Formatting cleanup.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 27 20:25:20 2012 -0400
Updates OS specific notes.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 26 20:37:59 2012 -0500
Moved the set +e up to capture one more test in test-pick. That
test heirloom-sh to exit.
(cherry picked from commit f793aa71e4f7375daeb2cc9ef25512172fcb1451)
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 25 20:32:10 2012 -0500
Use case statement to check for proper result from "mhparam sbackup".
Also replaced a couple of other uses of grep with case statements.
(cherry picked from commit 2f4fc229fd6578389b0435b044dc559d9d9bc292)
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 25 20:08:55 2012 -0500
Removed the mv of the file after running sed on it.
(cherry picked from commit 214da7bcd1ef52c46d4e77c787517d9403c97046)
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 25 20:08:03 2012 -0500
Unset all MH environment variables that aren't set below.
(cherry picked from commit 16dba0d07e94832ef9a077e6524714d0e433a111)
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 25 14:21:42 2012 -0500
1) With SETGID_MAIL enabled (only with dot locking), if the chgrp of
inc fails during install, don't attempt to chmod it. This will
cause make install to fail, which is good in this case.
2) Added SETGID_MAIL= to the install by the test suite so that it
does not attempt the chgrp+chmod. The test suite didn't need them.
3) Removed the SETGID_MAIL= from the test suite invocation in build_nmh.
(cherry picked from commit 721276218bc03d4b0d86306c9b2990fae6f07426)
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 25 13:02:33 2012 -0500
Disable utmpx support for systems that lack getutxent.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Apr 25 17:40:09 2012 +0200
futher test suite fixes to work on Solaris
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 24 21:04:54 2012 -0500
Fixed test suite to work with Solaris Bourne shell:
1) Removed ! (negation) of statuses.
2) Removed initializations from export statements.
3) Replaced $() with ``.
4) Replaced $(()) (and expr) with new function arith_eval ().
(cherry picked from commit a6af3b6300e02ade9f223f8d91667f590d191dc9)
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Apr 24 17:02:38 2012 -0500
Update info for mh-profile documenting comment format and the
restriction on blank lines.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 24 14:23:44 2012 -0500
Fixed to work with Solaris Bourne shell.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 24 14:22:06 2012 -0500
Added build_nmh to dist_contrib_DATA.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 22 14:47:57 2012 -0500
The mh-users list at UCI is no longer.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 22 13:30:33 2012 -0500
Got the hostname for the savannah upload area wrong.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 22 12:59:18 2012 -0500
Update for post-1.5 release.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 22 09:37:36 2012 -0400
Clean up help messages a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Apr 22 09:37:24 2012 -0400
Clean up install documentation a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 20 14:43:16 2012 -0400
Implment -noatfile in a different way; it turns out my previous change
broke dist with -noatfile.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 16 10:33:13 2012 -0400
Change the cscope target slightly so the source code from the historical
tree isn't found.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 15 10:02:23 2012 -0500
Added declaration of __srget() on Cygwin. Used point solution because
this shouldn't be needed for much longer.
Author: David Levine <levinedl@acm.org>
Date: Sun Apr 15 10:00:22 2012 -0500
Added -Wno-sign-compare, if supported, to compile of sbr/dtimep.c.
It's code generated by flex and some versions produce a
signed/unsigned mismatch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 13 11:23:20 2012 -0400
Sigh. More changes for newer versions of perl.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 12 21:07:57 2012 -0400
Support -fmtproc -nofmtproc in show.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 12 20:42:52 2012 -0400
More updates to replyfilter
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Apr 12 11:40:42 2012 -0400
Clean up fakesmtp and the post tests a bit to hopefully reduce race
conditions that make the tests fail sometimes.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 11 20:59:57 2012 -0500
Undid wrapping of setjmp() and sigsetjmp() of
4548981fb45fbc917cc2c26b7c96b31cf a14bc9b. What a bad idea.
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 11 20:42:22 2012 -0500
Tweaked build_nmh to work with Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 10 20:47:46 2012 -0500
Removed unused Hesiod relic.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 10 20:47:16 2012 -0500
Added docs/contrib/build_nmh script.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 6 15:55:14 2012 -0400
Add support for -fmtproc and -nofmtproc switches to repl.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 6 13:27:30 2012 -0500
Changed test-mhparam to allow # sbackup.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 6 13:57:20 2012 -0400
Fix forw so it respects the -form switch again for non-digests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Apr 6 13:56:03 2012 -0400
Refere to VERSION via srcdir so this works when doing objdir builds.
Author: David Levine <levinedl@acm.org>
Date: Fri Apr 6 12:27:22 2012 -0500
Reworked mhparam tests of components in procs array to depend on
values set in common.sh, notably $pagerpath.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 5 20:15:06 2012 -0500
Added mhparam test of each component in procs array in uip/mhparam.c.
Author: David Levine <levinedl@acm.org>
Date: Thu Apr 5 17:14:57 2012 -0500
Fixed install-mh -auto test by specifying HOME.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 4 23:33:40 2012 -0400
Sigh. More corner cases to deal with!
Author: David Levine <levinedl@acm.org>
Date: Wed Apr 4 21:41:39 2012 -0500
Changed rmm, send, and whatnow man pages to be consistent with the
refile man page with mention of site-dependent prefix (usually a comma).
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 4 15:55:36 2012 -0400
Fixed some more charset/encoding stuff.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Tue Apr 3 19:07:52 2012 -0700
This is a test commit to se if the savannah git hub will stop spewing
source diffs in commit email messages.
In this case, there should be a half-dozen lines of my bable, and
no context diffs from the one line change I made in this commit.
Author: David Levine <levinedl@acm.org>
Date: Tue Apr 3 20:47:17 2012 -0500
Moved nmh.spec and docs/replyfilter to new docs/contrib/ directory.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Apr 3 15:56:41 2012 -0400
A few more bugs I didn't catch earlier.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Apr 3 13:04:47 2012 -0400
Fix some bugs in replyfilter.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 2 15:58:12 2012 -0400
Whoops, fix a typo in my last commit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 2 15:39:00 2012 -0400
Bring in replyfilter to the docs directory.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Apr 2 15:38:40 2012 -0400
Implement fix in 59b086daa57105e8fbd8b1e6ba60be6a845faf95 here as well.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 31 11:52:10 2012 -0500
Added const qualifier to a couple of local pointers to get rid of compile warnings with --with-tls.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 26 21:28:54 2012 -0500
Removed hostable relics from h/mts.h and sbr/mts.c.
Author: David Levine <levinedl@acm.org>
Date: Mon Mar 26 20:32:03 2012 -0500
Removed the hostable option from mts.conf because it's no longer used.
This allowed removal of mts/smtp/hosts.c.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 25 22:42:36 2012 -0500
Added test-install-mh.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 24 21:47:31 2012 -0500
Note that %(myname) truncates the GECOS field at the first comma, if
it contains one.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 24 22:32:13 2012 -0400
Add support for %(size).
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 24 21:09:20 2012 -0500
Removed -realsize from man page because mhshow doesn't support it.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 24 09:22:41 2012 -0500
Fixed Cygwin notes.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 24 09:13:47 2012 -0500
Ensure that escape_display_name() can't overrun a buffer.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 24 09:04:34 2012 -0500
Cleaned up compile warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 24 02:15:49 2012 -0400
Add this support for setting the CT_ADDR flag.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 24 02:08:03 2012 -0400
Sigh. Turns out last change broke a few tests, because it trimmed the
newline on the "body" component. Ignore that and the text component as
well for trimming. Also create some tests for the repl changes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 24 01:16:42 2012 -0400
Revert commit 255d4c646c0d7aa6b049052fef47fa083b1b1506 and solve
the problem another way.
The component parser needs to save the newlines so it can combine
multiple headers properly. So for us, strip out any trailing newlines
when we call fmt_scan().
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 23 23:21:35 2012 -0400
Modify the whatnow tests to deal with different versions of readline;
some echo the input, some do not.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 22 23:34:08 2012 -0400
If the number of messages in a folder is zero, then don't try to
clear out the sequence list; this can cause you to run off the
beginning of the malloc'd buffer. This can happen when you use
"comp" with a draft folder, the draft folder is empty, and you have
a previous sequence set in your .mh_profile. As far as I can tell
this has been a problem for nearly forever, but I only ran into it
recently when adding the readline support. Go figure.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 22 21:06:47 2012 -0500
Added function escape_display_name() to double quote, if not already,
a fullname that contains any of the special characters listed in RFC
5322, and escape unescaped, embedded double quotes.
With this change, nmh should work with no special configuration on
Cygwin, even if the user's fullname is of the form server\name.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 22 19:40:17 2012 -0500
Moved NMH_READLINE to after our setting of CFLAGS, because
AC_SEARCH_LIBS messes with them.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 21 20:01:06 2012 -0500
If a pager isn't specified with configure --with-pager, look in order
for more, less, and most. Fall back to cat, to avoid catastrophic
failure of mhshow, et al., if pagerpath is set to "no".
Updated Cygwin section of MACHINES.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 21 15:27:15 2012 -0400
Support for readline command history, editing, and completion at the
WhatNow? prompt. Based on work by Steve Rader.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 21 12:22:16 2012 -0400
Revert previous change to get rid of MULTIBYTE_SUPPORT ifdef. It turns out
this breaks the Plan 9 build. But include a check for the multibyte functions
so we get MULTIBYTE_SUPPORT on systems that have it.
This reverts commit bd4fca3a8a15b35a04bdc333503c901d677c12eb.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 20 23:49:17 2012 -0500
Fixed harmless compile warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 20 21:36:37 2012 -0400
It turns out that as part of POSIXification we got rid of checks for
wcwidth and mbtowc (because they're part of POSIX) but we didn't turn on
MULTIBYTE_SUPPORT because configure was testing to see if those functions
were supported ... and because the tests never ran, it always came back
as not being supported. Time to bite the bullet and turn MULTIBYTE_SUPPORT
on by default.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 20 20:22:19 2012 -0400
Document formatarg.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 20 19:52:29 2012 -0400
Use _exit() instead of exit() so our writer process doesn't flush out
the stdio buffers on exit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 20 19:15:18 2012 -0400
Basic work to add arguments to formatproc calls.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 19 21:37:14 2012 -0400
Just for sanity's sake, double check the "inc" results also with "scan".
Merge: e8ed3af7 740e258c
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 18 20:59:06 2012 -0500
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: Steve Rader <rader@hep.wisc.edu>
Date: Sun Mar 18 20:57:08 2012 -0500
Added list of hand picked types initially genereted by...
cat /etc/mime.types \
| perl -ane 'if ($F[1] ne "") {print "mhshow-suffix-$F[0]:.$F[1]\n"}'
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 18 21:29:39 2012 -0400
Fix a bug where a message header ending right on the stdio boundary
would cause the body output in scan to be truncated.
Also include a test for the aforementioned bug.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 17 23:42:26 2012 -0400
Fix typo in man page
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 18 10:27:05 2012 -0500
Added release note that ./@ is obsolete/deprecated.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 18 09:53:31 2012 -0500
Added test-whom.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 18 09:17:56 2012 -0500
Added documentation of -sever, -port, -sasl, -saslmech, -snoop, -user,
-tls, and -notls to whom man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 18 09:15:30 2012 -0500
Added whom, it's the fifth program referred to in mh-draft man page.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 17 14:33:43 2012 -0500
In gcov target, added warning if configured with --enable-debug.
While gcov will work with it, it won't reflect optimizations that
are disabled with that option.
Merge: 7cc0e995 67c56bad
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 16 22:11:09 2012 -0500
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Conflicts:
Makefile.am
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 16 21:07:52 2012 -0500
Automated generation of mh-chart.man.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 16 21:07:52 2012 -0500
Automated generation of mh-chart.man.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 16 21:05:21 2012 -0500
Commmiting last manual update of mh-chart.man before removing it.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 16 21:02:57 2012 -0500
Removed some unused code having to do with permissions of symlinks.
Author: David Levine <levinedl@acm.org>
Date: Fri Mar 16 21:01:30 2012 -0500
Added mhshow-suffix-text/calendar.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 16 13:21:38 2012 -0400
Improve the documentation for "send" a bit in terms of how it maps file
suffixes to MIME types.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 16 13:02:43 2012 -0400
Make -attach Nmh-Attachment & -attachformat 1 the default.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 16 11:37:31 2012 -0400
Update for changes to post.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 16 11:32:35 2012 -0400
Create new switches -atfile and -noatfile to control the creation of the @
file when repl'ing or dist'ing a message.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Mar 16 00:21:35 2012 -0400
Update post(8) regarding the New World Order.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 23:14:48 2012 -0400
Whoops, forgot to put "." before some of the suffixes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 23:09:41 2012 -0400
Add some more default MIME content suffixes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 23:00:06 2012 -0400
Call readconfig() on mhn.defaults so we get default entries in for use
with attach.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 22:23:20 2012 -0400
A test for the group addressing functionality handled by "post".
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 15:54:02 2012 -0400
Remove all masquerade support (draft_from is now the default, and the other
two can be accomplished via the components file).
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 13:55:15 2012 -0400
Clean up prototypes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 13:04:38 2012 -0400
Fix some warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 15 11:55:34 2012 -0400
I guess the -i option to sed works differently on Linux and MacOS
X; deal with it.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 14 21:05:16 2012 -0500
Initialized local format_len. gcc on 64-bit Linux warned about it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 14 21:15:54 2012 -0400
New test suite for "post"; uses fakesmtp to trap the SMTP protocol.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 14 21:15:17 2012 -0400
Make sure we don't send Envelope-From if we're using spost.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 14 15:51:22 2012 -0400
A new test program, fakesmtp, to help us test post.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Mar 14 15:47:01 2012 -0400
Fix the SMTP code so it doesn't end up in a hard loop during a DATA
command.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 13 22:28:03 2012 -0500
Disabled the optimization to stop stat'ing directory entries in
BuildFolderListRecurse() of flist.c under conditions where st_nlink is
set to 1. That happens on Cygwin, for example:
http://cygwin.com/ml/cygwin-apps/2008-08/msg00264.html
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 13 22:01:52 2012 -0500
Changed output_md5() to output just the checksum. If the filename
needs to appear on the same line, the caller needs to add it. This
avoids differences due to a leading '*' binary file indicator, even
for text files, on Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 13 21:20:47 2012 -0500
Added test/getfqnd.c, a replacement for "hostname" that always
tries to provide the fully qualified domainname of the host, even
on Cygwin. It uses the code that LocalName in sbr/mts.c uses.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 13 19:58:33 2012 -0500
On some platforms, need to be out of $SPDIR in order to remove it.
So do that in test/whatnow/test-ls.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 13 19:56:06 2012 -0500
Promote uid_t value to long and print with %ld to prevent compile
warning on platforms, such as Cygwin, where it is a long.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 13 15:25:41 2012 -0400
Modify getfullname so it performs the same processing that
mts.c:getuserinfo() does.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 13 15:15:42 2012 -0400
Create proper prototypes for formataddr() and concataddr().
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 12 22:52:21 2012 -0400
New changes: Sender: cannot be blank, Sender: always overrides From:
for SMTP envelope, and Envelope-From: will cause a Sender: header to be
output if multiple From: addresses are used.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 11 21:47:04 2012 -0400
Require From: header in all outgoing messages.
Allow Sender: header (require if multiple addresses are in From:).
Support new Envelope-From: header for overriding post's choice of
SMTP envelope-from address.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Mar 11 18:08:03 2012 -0400
Add support for a -notls switch, for consistency's sake.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Mar 10 22:55:16 2012 -0500
Clean up a bunch of unused code and options. Specifically:
- Remove support for SMTP SEND, SAML, and SOML commands
- Remove -deliver, -fill-in and -fill-up switch for post (and related code)
- Document -server and -port switches better in post man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Mar 6 09:25:00 2012 -0500
SMTPMTS has been the default for over a decade, so it's time to get rid of
the #ifdefs to clean up the code a bit.
Author: David Levine <levinedl@acm.org>
Date: Sun Mar 11 19:52:38 2012 -0500
Fixed mhstore to honor nmh-storage profile entry even with -auto [Bug #35303].
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 10 20:33:24 2012 -0600
There were two fd leaks in mhparse.c:
1) In openQuoted(), the decoded contents file was opened twice in
succession. The second open was added by a patch in March 2000.
2) openBase64(), openQuoted(), and open7Bit() could open the contents
file, but it never would be closed. Added code to each to close the
file if the function opened it.
[Bug #24004: (debbug 344182)]
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 10 10:45:01 2012 -0600
Replaced UTC-8 with UTF-8.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 10 10:44:30 2012 -0600
Removed bash-ism from test-pick.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 8 21:29:28 2012 -0600
Enabled all groff warnings, with -ww, in manpages test. Fixed a bunch
of minor problems that it revealed.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 8 21:09:59 2012 -0600
Fixed mhlist -verbose to work with all content types [Bug #35219].
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 8 20:19:53 2012 -0600
1) Removed -noverbose from defaults of mhshow man page. While it
accepts -verbose/-noverbose, it ignores them.
2) Added -verbose/-noverbose to mhlist synopsis.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 7 22:08:03 2012 -0600
Added test-refile.
Author: David Levine <levinedl@acm.org>
Date: Wed Mar 7 20:20:13 2012 -0600
Replaced us-ascii with iso-8859-1 in examples, just because.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 21:57:16 2012 -0600
Added test-mhparam and test-mhstore.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 19:57:22 2012 -0600
Removed all traces of rmfproc. It had been used by bbl but was
no longer used.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 19:08:21 2012 -0600
Some of the man pages had mentioned that arguments should be
double-quoted to protect them from the shell. Removed "double-"
because single quoting is fine, too.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 18:52:41 2012 -0600
Escape spaces in DEFAULTS sections of man pages so they no longer are lost.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 18:51:12 2012 -0600
Removed ignored -verbose (and -noverbose) options to mhstore, just in the man pages. The code remains unchanged.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 18:49:27 2012 -0600
Fixed example to show that mhparam preserves case of component name.
Author: David Levine <levinedl@acm.org>
Date: Tue Mar 6 18:48:21 2012 -0600
Initialized local wasdlm to prevent uninitialized use.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 5 13:55:04 2012 -0500
Finally got a reasonable burst test working.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 5 13:24:41 2012 -0500
Update with recent fix.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 5 13:21:04 2012 -0500
Change this to use "uint32_t" for a 32-bit type, otherwise we can get
wrong MD5 checksums on 64-bit systems. Score another one for the
test suite!
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Mar 5 12:23:15 2012 -0500
Fix burst so it actually complies with RFC 934. This means discarding
any extra stuff leftover at the end of an encapsulated message.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 1 15:17:43 2012 -0500
A test for burst; still needs work.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 3 12:23:58 2012 -0600
Added test-mhlist.
Author: David Levine <levinedl@acm.org>
Date: Sat Mar 3 12:21:00 2012 -0600
mhbuild -check would always fail because it tried to build the
digest for the decoded contents file (cefile), which can be null.
If it is, use the contents file itself.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 1 18:01:52 2012 -0600
Brought mh-chart man page up to date.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 1 12:33:19 2012 -0600
Added documentation of -snoop.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 1 12:32:23 2012 -0600
Removed RCS sparc object file.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 1 12:29:33 2012 -0600
Under docs/historical/mh-6.8.5, mh.rf and mh.me were renamed to
mh-intro.rf and mh-intro.me, respectively, to avoid name clashes with
other files on case-insensitive file systems.
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 1 12:13:14 2012 -0600
Removed entire docs/historical/mh-6.8.5/local/ tree. It had a pair of
files, Distfile and distfile, with clashing case-insensitive names.
The rest of it was specific to UCI and LBL.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 1 12:33:42 2012 -0500
%G isn't actually part of POSIX, so change to %Y.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Mar 1 12:02:29 2012 -0500
Fixed a problem that caused the test to fail if you ran it on the first
nine days of the month.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 29 20:33:24 2012 -0600
Initialized local msgnum to 0.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 29 18:41:14 2012 -0600
Added all of the MH sources, including RCS files, in
docs/historical/mh-6.8.5. Sources for the papers are below papers/.
Sources for the MH User's Manual are in conf/doc/.
Merge: c7f326f4 7565efea
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 29 16:36:59 2012 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Conflicts:
docs/historical/README
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 29 13:49:28 2012 -0600
Removed the sources to the historical documents just added, they're
in the mh-6.8.5 tarball.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 29 13:49:28 2012 -0600
Added sources to historical documents downloaded from
http://stuff.mit.edu/afs/sipb/project/sipb-athena/src/mh/papers/
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 29 08:52:26 2012 -0500
Fix a segfault that happens when using the -file option.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 29 08:51:27 2012 -0500
Argh, I didn't mean to commit the distcomps I was using for testing!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 28 15:38:56 2012 -0500
dist(1) now processes drafts using mh-format! The last of the programs
to do so!
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 28 15:38:37 2012 -0500
Fix this man page for the New World Order.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 28 15:29:56 2012 -0500
Improve these man pages a bit.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 28 14:45:03 2012 -0500
Add support for %(msg) function working when not using -digest. I can't
imagine what someone would use it for but it's cheap to do, so why not?
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 28 10:32:41 2012 -0500
Part of the patch from bug #4301; clean up our prototypes, a lot. Still
plenty of work to do!
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 28 22:05:55 2012 -0600
Added docs/historical/. See README for where they were found.
Merge: 56f140c6 e22a2c8b
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 27 21:12:22 2012 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 27 21:10:47 2012 -0600
Removed blank line after "End of Forwarded Message" lines. It's
always bothered me.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 22:11:34 2012 -0500
Add the note about the burst(1) change to pending-release-notes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 22:05:41 2012 -0500
Fix bug #1466. It turns out that RFC 934 specifies that any line starting
with a "-" but NOT followed by a space is a valid message delimiter. We
only supported one type of message delimiter. Adapt the code so any
valid delimiter is supported.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 27 20:56:58 2012 -0600
Added cast in conditional to prevent signed/unsigned comparison, and wrapped argument to prevent warning about unused argument when built without SASL support.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 27 20:50:29 2012 -0600
Changed domains in man page and test examples to use example.com
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 27 20:42:19 2012 -0600
Fixed to report failure if getfulname hadn't been built yet.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 27 20:40:15 2012 -0600
They test with output to a tty didn't work under make distcheck. Tried to work around it by writing directly to /dev/tty, if that's available.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 20:50:49 2012 -0500
Add support for -nosasl and -saslmaxssf switches.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 14:13:02 2012 -0500
Document changes to forw(1).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 14:12:34 2012 -0500
Clean up some typos in here.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 13:45:37 2012 -0500
Got the forw -digest test working.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 13:37:09 2012 -0500
Update digestcomps and forwcomps with comments and better formatting.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 27 12:56:00 2012 -0500
Make -volume switch actually work (it always got overridden). As far
as I can tell, this never worked. Found by the test suite!
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 21:29:44 2012 -0500
Remove the forw-digest test until we have it working.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 21:29:01 2012 -0500
A test for forw -digest. It doesn't quite work yet.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 21:14:04 2012 -0500
Fix up some of the pick tests:
- Change sed invocation around to get rid of GNU sed extensions
- Put explicit times in the pick tests (if you don't, it uses the current
hour/minutes as the timestamp, which means it could work or not work
depending on what time of day you run the tests).
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 13:02:41 2012 -0500
Update the pending release notes with new features.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 12:45:48 2012 -0500
Add a new README documenting the changes to the components files.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 12:12:28 2012 -0500
Beginnings of a test suite for the mh-format support in forw.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 10:55:46 2012 -0600
Added test-pick.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 10:32:29 2012 -0600
Suppress echoing of man page build lines. One of them says "warning", and it's handy to check that build output doesn't say that.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 10:10:35 2012 -0600
Changed type of a local to unsigned and removed local ncomps to suppress compile warnings.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 26 10:09:35 2012 -0600
Added gcov and gcov-clean targets.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 26 00:09:52 2012 -0500
Finally, some support for mh-format when using forw(1). Still needs some
tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 23 12:03:09 2012 -0500
Create a test for the new mh-format processing available in comp(1).
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 22 22:23:05 2012 -0600
Added test-flist and test-mark sequences tests.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 22 22:21:56 2012 -0600
Don't list _sysconfdir/ directory in RPM spec. We don't list any other directories, so now it will be created with the same permissions as all of the others.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 21 19:35:05 2012 -0600
Removed reference to mhost.com.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 21 19:34:33 2012 -0600
Updated to reflect that all of the lists are on nongnu.org.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 21 19:31:08 2012 -0600
With "make rpm", configure all modified files in sysconfdir (etc) to be saved when erasing or upgrading the package. Also, leave the doc directory whereever "make install" puts it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 21 15:56:06 2012 -0500
Add support for a -subject switch to comp.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 21 12:58:50 2012 -0500
Switch from (me) to (localmbox) to make -cc me work correctly.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 20 22:02:26 2012 -0600
Migrated a couple more tests to use run_test() in common.sh.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 20 00:31:14 2012 -0500
Put default From: headers in these component files, and document the
components file now that we can have comments.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 20 00:31:01 2012 -0500
Clean up documentation formatting
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 19 22:29:14 2012 -0600
Removed unused local ncomps because gcc complained about it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 19 19:59:06 2012 -0500
Add support for "to", "cc", "from", and "fcc" components via command-line
switches.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 19 18:03:26 2012 -0500
Fix a bug leftover from the Automake conversion; the AC_SUBST'd variable
names are really editorpath and pagerpath, use those instead.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 22:36:50 2012 -0600
Ken noted that "make check" can be run before installation because the only program in lib that the tests currently use is mhlproc, and we have an mhlproc entry in the test .mh_profile for that. Added showproc and postproc entries in case they're ever needed.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 17:32:15 2012 -0600
Moved "make check" to after "make install".
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 17:31:37 2012 -0600
gcc was warning about unused arguments to main, so added use of them in a usage check.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 17:30:47 2012 -0600
Consolidated runtest and check_string test functions.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 11:21:28 2012 -0600
Have each test clean up after itself if it completes successfully.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 09:42:04 2012 -0600
Added mhpath test. Updated mhpath man page to reflect actual behavior for a message number greater than that of the highest existing message in a folder.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 08:03:21 2012 -0600
The test check() function now removes the expected and actual output files if they're the same, by default. Added check-string() function.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 17 19:10:08 2012 -0600
Initialized local "in" to suppress gcc warning about possible uninitialized use.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 17 19:08:42 2012 -0600
Enclosed program name and directory in double quotes so that they can contain whitespace.
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 17 18:44:35 2012 -0600
Here's the proper fix instead of the hack of d28ce569fe233141f86fe516878361da01c9f9cb. Use ${srcdir} in to refer to extra files in tests, as before.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 17 15:56:08 2012 -0500
Beginning support for mh-format support in comp(1). Includes changes to
default component file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 17 15:10:06 2012 -0500
Sigh. Looks like we need a function after all; create a new function
called %(localmbox).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 17 14:02:44 2012 -0500
Switch to including h/mts.h for getusername() prototype.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 16 22:56:02 2012 -0600
Added a couple of NMH_UNUSED's to suppress warnings when building without Cyrus SASL.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 16 22:49:03 2012 -0600
Hacked to work with make distcheck. Maybe not the best way but it works for now.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 16 22:02:21 2012 -0600
Moved check() function from individual tests to common.sh.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 16 21:30:43 2012 -0600
Rearranged test suite environment variables so that individual tests
can now be run standalone (outside of make). But see WARNING in
test/README about how it's better to use "make check" because that
ensures that the current code in your workspace is tested. Also, the
clean script no longer needs to call setup_test.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 16 11:46:16 2012 -0500
Report an error when the width used by putaddr is less than the label width.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 16 00:17:49 2012 -0500
Hopefully made the format documentation a little bit clearer.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 21:45:13 2012 -0500
Fix typo in repl man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 15:54:47 2012 -0500
Create test cases for the new format functions for local address writing.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 15:53:26 2012 -0500
Make it so we do NOT check our address against the "local" userid and
hostname if Local-Mailbox is set.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 15:46:28 2012 -0500
Sigh. Turns out the first entry in the list isn't actually checked, so
we need to make sure that our Local-Mailbox entry starts second.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 14:55:25 2012 -0500
Hm, it turns out we need to make sure we call getname() until we get
a NULL, otherwise the next set of calls to it will be working from the
"old" search string.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 11:36:36 2012 -0500
Beginning of support for the Local-Mailbox profile entry.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Feb 15 10:48:52 2012 -0500
Support getting the "fullname" out of the Signature profile setting.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 14 20:47:06 2012 -0600
Updated documentation of environment variables in mh-profile man page.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Feb 14 20:24:43 2012 -0500
Add two new format functions: %(myhost) and %(myname).
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 13 19:55:53 2012 -0600
Changed "make test" to "make check".
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 13 19:54:41 2012 -0600
Fixed progress indicator.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 11 23:28:10 2012 -0500
Another problem discovered by the test suite.
With multiple sequence arguments on the command line you might end
up with garbage in the sequence[] array (it needs the last argument
to be a NULL. So do two things: make the first two arguments NULL, and
as we add arguments to sequence[] make sure the list has a NULL on the
end.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Feb 11 13:06:47 2012 -0500
correct the maximum number of sequences in the mark(1) man page
also add a note explaining the somewhat low limit.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Feb 11 12:41:30 2012 -0500
mhshow: suppress pause actions if stdout isn't a tty
previously, "mhshow | cat" would both print a "Press return" prompt
to, and attempt to read from, its piped output fd.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 23:38:40 2012 -0500
Fix this so it works when valgrind is installed.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 23:27:36 2012 -0500
Switch over to using the template files out of our inst directory.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 23:22:12 2012 -0500
Switch to using the "inst" version of mhl for tests.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 23:09:03 2012 -0500
Re-work the test suite so it now works with Automake (via "make check").
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 20:59:21 2012 -0500
Fix typo in alternate mts.conf location support.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 15:11:05 2012 -0500
Make the test suite work on systems other than Linux. Still needs work.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 10 09:50:48 2012 -0500
With the fixing of the bug that caused CPPFLAGS to get tromped on, remove
support for OURDEFS and direct people to use CPPFLAGS instead.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 9 23:43:30 2012 -0500
Fix typo in variable test.
Author: David Levine <levinedl@acm.org>
Date: Thu Feb 9 20:38:22 2012 -0600
Show assignment of configure variables using VAR=VALUE instead of in the shell environment.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 8 22:29:59 2012 -0600
Updated INSTALL and MACHINES documentation a bit.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 8 21:42:46 2012 -0600
Added mhshow subpart test.
Author: David Levine <levinedl@acm.org>
Date: Wed Feb 8 21:41:48 2012 -0600
Always run setup-test from make test/runalltests, just in case the test build directory (test/testbuild) isn't up to date. It might be nice to replace all the copies in the test build directory with symlinks, then make could keep the test build up to date.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 7 21:43:26 2012 -0600
Added OURDEFS to DEFS in Makefile.am, to restore it in the Makefile. Updated documentation in INSTALL.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 7 21:23:37 2012 -0600
Removed use of tzset()/tzname in dtimezone(). They caused the returned timezone string to be for the user's current timezone, but the function is supposed to return the string representation of the timezone of its argument. That will be numeric, e.g., +0100, now because we no longer have timezone name support.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 7 21:17:00 2012 -0600
Reverted TZ hack to tests, 9ea2daf5e74e3ff03043cfa6fb68033aea0da52a. A code fix is on its way
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 6 22:35:21 2012 -0600
Another one caught by the test suite: an indented line was too long in the slocal man page. Center it instead.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 6 22:25:25 2012 -0600
Some tests failed because they displayed the user's local
time zone but expected GMT. So, set TZ in runtest to fool
them.
Though I wonder if we're failing to correct for local time zone.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 6 21:47:52 2012 -0600
Caught by the test suite: sequences[0] needs to be initialized to NULL at the beginning of the program. That explains why it seg faulted when invoked with a sequence argument.
Author: David Levine <levinedl@acm.org>
Date: Mon Feb 6 21:19:57 2012 -0600
Reworked test suite to copy the configuration used in the main
nmh directory. Added test target to Makefile. Not all the tests
pass at this point.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 6 14:12:00 2012 -0500
Still more autoconf cleanup (quoting & more use of M4sh).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 6 11:31:18 2012 -0500
Patch from Harvey Eneman: fixes problem on some systems where a free()
would be called on non-malloc'd memory (only would happen if you had more
than one entry in the server: line in mts.conf).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 6 10:27:43 2012 -0500
Update the developer documentation with the changes to the release
process.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 6 09:08:19 2012 -0500
More configure cleanup to modern constructs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Feb 5 17:17:41 2012 -0500
Autoconf cleanup to suggested practice (AS_IF & AC_MSG_FAILURE). More to do.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 5 15:26:16 2012 -0600
Added error message if the file is source directly, rather than through bash-completion.
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 5 14:13:07 2012 -0600
Exit with error message if no library could be found with tgetent.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Feb 4 00:11:27 2012 -0500
Whoops, used "buffer" when I meant "buf".
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 3 23:43:53 2012 -0500
Change LocalName() to take an argument (about whether or not to use
local hostname versus entry in mts.conf).
Merge: 24ccface 196f9810
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 3 17:10:49 2012 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Fri Feb 3 17:10:44 2012 -0600
Use more up-to-date web page links of Jerry Peek's book sections at rand-mh.sourceforge.net instead of oreilly.com.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 3 15:38:49 2012 -0500
Convert from the poorly-named and confusing adrsprintf() to getlocaladdr().
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 3 15:03:00 2012 -0500
Make the upload target phony.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 3 15:01:50 2012 -0500
Beginnings of an upload Makefile target.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 3 13:50:19 2012 -0500
Update with new features.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Feb 3 13:49:46 2012 -0500
Document the formatproc entry.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Feb 2 22:13:57 2012 -0500
Move the eval statements inside of AC_CONFIG_COMMANDS_POST macro, otherwise
the stuff we output might not be correct.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 31 23:17:33 2012 -0600
Added #includes to pick up declaration of waitpid()
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 31 13:20:40 2012 -0500
Whoops, I need to make sure the buffer I pass to putcomp() is NULL-terminated.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 31 12:58:04 2012 -0500
Add support for calling an external format program inside of mhl.
Merge: abf5b4fc c8206d4f
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 28 14:12:05 2012 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 28 13:52:59 2012 -0600
Made ChangeLog target phony so it will always get regenerated. But don't try to regenerate if git repository is not present.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 28 13:52:59 2012 -0600
Made ChangeLog phony so it will always get regenerated. But don't try to regenerated if git repository is not present.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 28 12:45:15 2012 -0600
The www.ics.uci.edu/~mh/ links are dead, so replaced them with corresponding oreilly.com links.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 28 12:33:27 2012 -0600
Replaced static ChangeLog with one generated by git log.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sat Jan 28 00:29:13 2012 -0500
Create "nowrap" flag to turn off all line wrapping.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 27 20:30:58 2012 -0600
Organized .gitignore to show which objects are deleted by the various Makefile clean targets.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 27 19:56:50 2012 -0600
Added superclean Makefile target. Added a.out.DSYM's to clean target. Added .PHONY indication of rpm target.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 27 19:40:48 2012 -0600
Removed config.guess and config.sub because they're generated by autoreconf -i.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 27 19:39:47 2012 -0600
Updated to latest config.guess and config.sub before removing them from the repo, just in case someone needs them and can't generate them.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 27 19:36:14 2012 -0600
Changed a variable to unsigned and noted an argument as unused to silence compile warnings in uip/popsbr.c
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 27 13:47:14 2012 -0500
Fix long-standing problem with getans(); handle the case if we get
an interrupted by a signal during a character read and return an
EINTR.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 27 13:34:17 2012 -0500
Convert to the use of siglongjmp()
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 27 12:30:52 2012 -0500
Make POP support always be turned on.
Merge: da6bfd3e d5c47f78
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Jan 27 08:16:57 2012 -0800
Merge branch 'master' of ssh://git.sv.gnu.org/srv/git/nmh
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Fri Jan 27 08:16:36 2012 -0800
Typo fix.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 26 22:36:17 2012 -0600
Added clean-local target to remove RPM directory.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 26 20:05:30 2012 -0600
Added uip/*.exe, for Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 26 20:04:33 2012 -0600
Removed slash in front of $(man5dir) of install-data-hook rule so that it now works on Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 25 22:22:02 2012 -0600
Fixed rpm target now that nmhdist is gone.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 25 20:48:55 2012 -0600
Updated config test to add -Wextra to be consistent with others. So, it's back!
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 25 19:44:30 2012 -0600
If using gcc, use -Wno-unused-macros when compiling sbr/dtime.o.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 25 19:38:49 2012 -0600
Removed unused local bp.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 25 19:33:17 2012 -0600
Undid most of 3ef341abe440ece07f8deed59fb026ab020e805 because FreeBSD needs the HAVE_STRUCT_TM_TM_GMTOFF test. It has a timezone() function, not a timezone global variable (that's visible with our default configuration.
Author: lyndon <lyndon@treebeard.orthanc.ca>
Date: Wed Jan 25 20:10:52 2012 -0800
Remove hardlink target before attempting new link.
Author: lyndon <lyndon@treebeard.orthanc.ca>
Date: Wed Jan 25 18:15:47 2012 -0800
uip/termsbr.c: remove references to PC and ospeed().
These are no longer referenced by the code base now that vmh has been
removed.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 24 12:56:45 2012 -0500
Create a "cscope" target that creates the necessary files to use cscope.
Author: lyndon <lyndon@treebeard.orthanc.ca>
Date: Mon Jan 23 22:48:24 2012 -0800
cscope.files was missing mts/smtp/*.
Author: lyndon <lyndon@treebeard.orthanc.ca>
Date: Sun Jan 22 23:21:03 2012 -0800
Ignore cscope.out.
Author: lyndon <lyndon@treebeard.orthanc.ca>
Date: Sun Jan 22 23:08:02 2012 -0800
Add a default configuration file for cscope(1).
I generated the file list by hand. While it might be possible to generate it
from the Makefile, it was much simpler to just
ls */*.[cl]|grep -v sbr/dtimep.c
If source files are added or removed down the road, cscope.files will
need a hand edit to keep it in sync.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 22 01:15:40 2012 -0500
Make sigmsg.h NOT depend on the Makefile.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 22 01:14:34 2012 -0500
Clean up DESTDIR usage.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Jan 22 01:12:18 2012 -0500
Add the rule to install inc setgid if requested.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 20 23:39:14 2012 -0500
Fix some problems that the Automake migration caused.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 20 14:05:26 2012 -0500
Convert the build system over to the use of Automake.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 17 17:33:29 2012 -0600
Well the wrap of vfork() calls didn't work: its semantics don't allow that. So removed the wrapper and added -Wno-clobbered to gcc -Wextra.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 17 14:27:06 2012 -0500
Convert from our use of aclocal.m4 to a subdirectory with autoconf macros
in it.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 17 14:15:32 2012 -0500
Change the name of AC_CHECK_NETLIBS, since it's not a macro distributed
by Autoconf.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 17 10:58:40 2012 -0500
Update .gitignore with .DS_Store (seen occasionally on MacOS X systems).
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 17 10:57:54 2012 -0500
Convert from utmp functions to utmpx functions (which are in POSIX).
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 16 20:58:15 2012 -0600
Wrapped setjmp(), sigsetjmp(), and vfork() calls to silence gcc -Wclobbered for good. Undid ca34fbd0a5204d47ad019f64ef03d21ebd3397fd, which added volatile qualifiers but was not general.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 16 18:35:21 2012 -0600
Removed HAVE_STRUCT_TM_TM_GMTOFF support because it didn't work on Cygwin and isn't needed: timezone, tzname, and tzset() are all POSIX.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 16 18:33:57 2012 -0600
Pass int instead of char to iscntrl() and isspace() because that's what they require, and gcc on Cygwin warns about it.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 16 18:30:40 2012 -0600
Added EXEEXT support, for Cygwin.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 16 09:50:10 2012 -0600
Fixed build on Cygwin by adding configure check for ncurses/termcap.h.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 15:33:39 2012 -0600
Argument to alrmser is unused.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 15:28:25 2012 -0600
Fixed warnings from gcc -Wclobbered by adding volatile qualifiers.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 15:04:54 2012 -0600
Cleaned up gcc warnings when CYRUS_SASL is not enabled.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 14:56:16 2012 -0600
Added -Wextra with gcc, if supported.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 14:49:57 2012 -0600
Changed types and added casts so that build is clean with gcc -Wsign-compare.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 09:21:32 2012 -0600
gcc -Wmissing-field-initializers noticed several struct initializations
that didn't explicitly list all fields. Most were of no consequence because
they were for static data, so they were all initialized properly. However,
the two in mhlsbr.c were missing an initialization of other than their last
field, and they contained some subsequent values other than zero. So, those
later fields were initialized incorrectly. Also, changed the initialization
of global.c_ovtxt from "" to NULL because free_queue () freed it if non-NULL,
though I think the "" was always overwritten.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 09:19:49 2012 -0600
configure.ac and aclocal.m4 instead of configure.in and acconfig.h.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 14 09:16:16 2012 -0600
Documented support of OURDEFS to pass compile flags to configure.
Merge: c3ed95b3 3a84d814
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 13 12:05:13 2012 -0500
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 13 12:04:13 2012 -0500
Add some comments to the format compiler and engine.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 13 09:30:03 2012 -0500
Update README.developers with the correct version of autoconf we need.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 12 22:19:24 2012 -0600
Added NMH_UNUSED macro for suppressing warnings about unused parameters
with gcc -Wunused-parameter
Merge: b70215df 162f2a7d
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 12 22:17:54 2012 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 12 22:14:59 2012 -0600
Added -Wunused-macros with gcc, if supported. Added -Wno-unused-macros,
if supported, to compile of sbr/dtimep.o with gcc because it uses
generated code that would be too much trouble to clean up.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 12 21:07:33 2012 -0500
Create two new mh-format functions: %(putlit) and %(concataddr).
%(putlit) outputs a string without any space compression or control character
conversion
%(concataddr) is just like %(formataddr), except that inside of repl there
will not be any duplicate address supression.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 22:38:35 2012 -0600
Enabled support for tls switch.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 22:36:20 2012 -0600
Removed unsupported format and check switches, and commented out unused macro HMNG.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 22:33:45 2012 -0600
Removed, or added use of, unused macros to prevent warnings from gcc -Wunused-macros.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 17:06:44 2012 -0600
Removed or protected some unused macros.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 16:52:17 2012 -0600
Removed unused global zones and local z form dtimezone ().
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 11 16:45:53 2012 -0600
Added #include <grp.h>. It's needed on Linux, should be harmless on others.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 11 15:04:39 2012 -0500
Completely remove the use of TIME_WITH_SYS_TIME (I removed the autoconf
test but never removed the code, and this caused some problems on systems
that needed some prototypes in <time.h>).
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 11 14:52:23 2012 -0500
Ignore a.out.DSYM (this file sometims shows up when using the debugger)
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 11 14:48:45 2012 -0500
Fix two errors in the conversion to m_mktemp2():
- There was an off-by-one error that prevented the temporary file
from being created in the same directory as the message it was being
linked to.
- When using "dist", the assumption was that the temporary file would not
exist when m_scratch was called (it wanted to link() to the name). This
was solved by simply unlink()ing the temporary file after it was created.
Merge: c2191f69 a2469f5e
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 15:52:34 2012 -0500
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 15:51:57 2012 -0500
Remove OS-specific defines. As part of it, remove scary longjmp() inside
signal handlers that was part of the code under #ifdef BSD42.
Author: David Levine <levinedl@acm.org>
Date: Mon Jan 9 14:08:38 2012 -0600
Removed a remaining RETSIGTYPE. Also change a few locals from int to unsigned to prevent signed-unsigned comparison mismatch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 14:43:35 2012 -0500
Clean up time handling; always assume we have tzset() and that the right
prototypes are in time.h (both are valid in POSIX).
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 14:07:37 2012 -0500
Garbage collect autoconf support for checking for the header file for initgroups
and snprintf() prototypes.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 13:56:30 2012 -0500
We are making POSIX signal support a requirement; remove all support for
other signal interfaces.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 13:38:02 2012 -0500
Finally able to get rid of acconfig.h! Since we're doing slightly better
in the autoconf universe, rename configure.in to configure.ac, the "more
correct" name for the configure script template.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jan 9 13:26:59 2012 -0500
Switch from using RETSIGTYPE via autoconf to void, since POSIX says that's
type to use for a signal handler.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 8 17:58:11 2012 -0600
Removed unused bcmp, bcopy, bcpy, and bzero #defines.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 8 13:46:47 2012 -0600
gcc -Wempty-body warned that the check of the result from the call to parse_mime() was ignored. It has been that way since the beginning of history and was probably of no consequence, but fixed anyway.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 8 10:51:05 2012 -0600
Removed traces of bboards and bbc from mh-profile and msh man pages. Added see also of msh to packf man page.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 8 10:34:31 2012 -0600
Wrapped #include of config.h with #ifdef HAVE_CONFIG_H, just in case someone ever wants to build without using configure.
Author: David Levine <levinedl@acm.org>
Date: Sun Jan 8 10:27:15 2012 -0600
Removed hard-coded -I.. and -I../.. from INCLUDES, it was redundant given -I$(top_srcdir).
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 10:03:35 2012 -0600
Added Content-Description header with the filename of the attachment, with attachformats 1 and 2. This seems to be common practice now and gives mhlist something useful to display.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 09:53:36 2012 -0600
Added note about fileproc and mhlproc mh-profile entries.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 09:19:59 2012 -0600
Added removal of autom4te.cache directory to mostlyclean-local.
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 09:17:34 2012 -0600
Quoted argument to AC_LINK_IFELSE to silence authoheader warnings.
Merge: d2e40bd9 0d561416
Author: David Levine <levinedl@acm.org>
Date: Sat Jan 7 08:22:24 2012 -0600
Merge branch 'fileproc_mhlproc_to_post'
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 14:40:31 2012 -0500
Move definition of LINK to mh header file, and garbage collect ATTVIBUG code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 14:18:46 2012 -0500
Hardcode the defaults for Msg-Protect and Folder-Protect. Also fix the
documentation (had the wrong value for the default for Msg-Protect).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 14:12:13 2012 -0500
Huh, apparantly I got rid of any support for POPSERVICE over a year
ago! Good riddance, I say.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:48:03 2012 -0500
Garbage collect all of the builtin ftp client support.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:37:38 2012 -0500
Garbage-collect MHRC (and make it the default).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:36:21 2012 -0500
Garbage-collect SLOCAL_MBOX (and make it the default).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:35:16 2012 -0500
Garbage-collect RPATHS support.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:29:35 2012 -0500
Huh, turns out this define hasn't worked in forever ... the original
changes were made to the lexer output, and silently vanished a decade
ago when code was reorganized from zotnet to sbr!
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:22:44 2012 -0500
Remove last vestiges of #ifdef BANG
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 6 10:21:17 2012 -0500
Remove DBMPWD, make it the default.
Author: David Levine <levinedl@acm.org>
Date: Fri Jan 6 08:55:39 2012 -0600
Added datarootdir definitions to silence warnings from configure.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 5 21:36:51 2012 -0600
Fixed trivial compile warnings.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 5 22:13:08 2012 -0500
Not sure why we're checking for st_blksize; it's required by POSIX and
we're not even using the define!
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 5 22:08:23 2012 -0500
Switch the use of LOCKDIR in acconfig.h to --enable-lockdir.
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 5 21:00:58 2012 -0600
Merge branch 'master', remote-tracking branch 'origin'
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 5 13:39:47 2012 -0500
Garbage collect all of the old UCI #ifdef'd code.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 5 12:26:48 2012 -0500
Update this with mh-e changes.
Merge: 220dcd2d edc8d461
Author: David Levine <levinedl@acm.org>
Date: Thu Jan 5 11:14:56 2012 -0600
Feed fileproc and mhlproc from rcvdist, send, and whatnow to post.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 4 21:05:45 2012 -0600
Feed fileproc and mhlproc from rcvdist, send, and whatnow to post.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Jan 5 12:05:43 2012 -0500
Bring in all of the mh-e support that is actually used to be compiled by
default, and garbage collect the stuff that is not used.
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 4 21:05:45 2012 -0600
Feed fileproc and mhlproc from rcvdist, send, whatnow, and whom to post.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 22:28:44 2012 -0500
Whoops, for right now we do need those signal function checks.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 22:21:07 2012 -0500
Switch to standard autoconf macro for checking d_type field in struct dirent.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Mon Dec 26 09:19:35 2011 -0800
Remove #ifdef around use of sigsetjmp().
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 19:17:58 2011 -0800
Remove overrides for 'broken' stat macros.
Remove redundant SEEK_* macro definitions.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 17:20:26 2011 -0800
Include <stdio.h> for snprintf() prototype.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 12:23:41 2011 -0800
Nuke directory processing conditionals; use dirent.h.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 12:16:08 2011 -0800
Add back missing include of <sys/wait.h>
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 12:09:21 2011 -0800
Clean up process wait to use POSIX waitpid() interface.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 22:01:07 2012 -0500
No longer check for the mkstemp() function in the mkstemp library.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 11:58:38 2011 -0800
Make use of mkstemp() unconditional (vs. mktemp().
This patch also removes the m_scratch() and m_tmpfil() functions.
They have been deprecated for a while, and are no longer used in any of
the code base.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sun Dec 25 11:28:07 2011 -0800
Remove compatibility functions that are always provided by the
POSIX host environment.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 21:54:07 2012 -0500
Get rid of checking for vfork(), since we no longer use.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 18:18:22 2011 -0800
Replace <arpa/ftp.h> with "h/arpa_ftp.h".
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 18:17:10 2011 -0800
Import non-Posix <arpa/ftp.h> for uip/ftpsbr.c.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 18:15:06 2011 -0800
Remove HAVE_ARPA_FTP_H and arpa/ftp.h references.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 21:38:07 2012 -0500
Remove autoconf ospeed checks
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 16:38:47 2011 -0800
Ignore OSPEED/ospeed in termcap. Nothing current should need this.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 21:12:11 2012 -0500
No longer check for termio.h or termios.h
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 16:15:22 2011 -0800
Collapse termio/termios/sgtty terminal interface code down to
the Posix termios interface.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 21:06:45 2012 -0500
Update configure file for removal of POSIX-mandated header files.
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 15:40:48 2011 -0800
Eliminate '#ifdef HAVE_FOO' for Posix-mandated FOOs.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 20:27:45 2012 -0500
No longer need to check for the existance of sys/utsname.h
Author: Lyndon Nerenberg <lyndon@orthanc.ca>
Date: Sat Dec 24 15:30:53 2011 -0800
Deprecate uname() in favour of (Posix) gethostname().
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 20:20:26 2012 -0500
Sigh. I put the documentation about the -tls switch in the long description,
but not in the command summary.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 16:30:50 2012 -0500
Updated pending-release-notes
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 3 15:16:29 2012 -0600
Added note about cpio failing to unpack an nmh tarball.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 15:17:54 2012 -0500
Switch to using buffered I/O when doing TLS (but only for output).
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jan 3 10:36:14 2012 -0500
Updated these files since we've finally got 1.4 out the door.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 27 22:41:24 2011 -0600
Moved #endif so that lockit () is only declared with DOT_LOCKING, to avoid compile warning without it.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 27 22:38:52 2011 -0600
Reworked nmh.spec to support rpmbuild from source RPM.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 25 15:00:49 2011 -0600
Removed unused vmh.c and wmh.c.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 24 20:28:50 2011 -0600
Changed second argument of calls to part_ok() and type_ok() from
0 to 1, to match what store_multi() in mhstoresbr.c does.
A test case is below. Without this fix, the following command:
mhshow -part 1.1 -form mhl.null
produced no output. mhlist showed a part 1.1:
msg part type/subtype size description
1231 multipart/mixed 276
1 multipart/related 107
1.1 text/plain 29
and "mhstore -part 1.1" properly stored it. With this
fix, mhshow behaves properly and shows the part.
Analogous behavior happened with -type text/plain.
test case:
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="NextPart_001"
Content-class: urn:content-classes:message
Date: Thu, 19 May 2011 00:00:00 -0000
From: sender@example.com
To: recipient@example.com
This is a multi-part message in MIME format.
--NextPart_001
Content-Type: multipart/related;
type="multipart/alternative";
boundary="NextPart_002"
--NextPart_002
Content-Type: text/plain;
charset="utf-8"
This is the text/plain part.
--NextPart_002--
--NextPart_001--
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 24 19:36:32 2011 -0600
Replaced cvs with git references. I'm not sure about the cgit
URL at the very end. Also removed mention of source directories
that were deprecated and removed long ago.
Author: David Levine <levinedl@acm.org>
Date: Sat Dec 24 09:59:45 2011 -0600
Added --with-rpmdir configure option so that user can set location of RPM build root.
Author: David Levine <levinedl@acm.org>
Date: Tue Dec 13 18:33:07 2011 -0600
Added comments about source of description, etc.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 12 22:50:06 2011 -0600
Replaced use of GNU make shell function with backticks. These were
for the rpm target, which would most likely only be build on Linux.
So they probably would have been OK, but just in case.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 12 22:25:52 2011 -0600
The docs/Makefile install target didn't do anything before. Added
the files that go into doc to it, and removed them from nmh.spec.
nmh.spec should now require zero maintenance.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 12 21:45:17 2011 -0600
Added RPM/ so that git status doesn't mention that it's an untracked file.
Merge: d7f71730 bc20acd6
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 12 21:37:47 2011 -0600
Merge branch 'master' of git.sv.nongnu.org:/srv/git/nmh
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 12 21:35:52 2011 -0600
Moved version number from nmh.spec to Makefile.in, to minimize
maintenance for nmh.spec.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Dec 12 12:59:42 2011 -0500
Make sure to not reset hghnum (in the Maildir code) if we are incorporating
mail from a POP mailbox.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 17:03:56 2011 -0600
Added first cut at nmh.spec, along with rpm: target in Makefile.in.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 13:44:50 2011 -0600
Removed netdb.h because we no longer distribute it.
Author: David Levine <levinedl@acm.org>
Date: Sun Dec 11 10:24:20 2011 -0600
Removed unused local variables to eliminate warnings from gcc 4.6.2.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 7 12:00:26 2011 -0500
Make sure to ignore the nmh dist file.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Dec 7 11:36:53 2011 -0500
Since we're now moving past 1.4, bump this.
Author: David Malone <dwmalone@maths.tcd.ie>
Date: Wed Dec 7 10:19:40 2011 -0500
Add support to inc for incorporting email from Maildir dropboxes.
Add missing #include for <sys/socket.h> to bring in definitions of PF_UNSPEC.
Signed-off-by: Ken Hornstein <kenh@pobox.com>
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Apr 13 10:50:49 2011 -0400
Whoops, user & port were in the wrong order so msgchk didn't work for POP
connections.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Feb 21 20:44:30 2011 -0500
Updated the developer README with a few notes about the git conversion.
Signed-off-by: Ken Hornstein <kenh@pobox.com>
Author: Paul Vixie <vixie@vix.com>
Date: Mon Feb 7 14:13:54 2011 -0500
Signed-off-by: Ken Hornstein <kenh@pobox.com>
More documentation about the hooks support.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Dec 21 16:50:24 2010 +0000
Clean up code in inc.c
Clean up the confusing use of a variable 'i' in inc.c.
The case where it was being used as 'an error occurred
which means we should not truncate the mailspool' is now
called 'incerr' and merged with the equivalent 'p' variable
used in the POP-specific code. Cases where it was being
used as a random temporary are still called 'i' but now
declared with a much more restricted scope.
This fixes a compilation warning for some compilers.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Dec 20 21:13:32 2010 +0000
Suppress tsort diagnostic waffle
tsort produces waffle to standard error if it detects loops in its input.
For our purposes in ordering object files this is harmless, so just send
it all to /dev/null.
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Dec 20 21:13:32 2010 +0000
Fix unused-function warnings in lex output
Fix the unused-function warnings in the output of lex. In particular, we
silence a warning about yyunput being static but unused by exposing it as
a global function. This costs us a few hundred bytes in the binary but
the other available solutions are flex-specific or more complicated.
YY_NO_UNPUT used to silence this but no longer works in recent flex.
On the other hand YY_NO_INPUT does work to silence warnings about input().
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Dec 20 21:13:32 2010 +0000
Fix used-uninitialised warning in fmt_rfc2047.c
Fix a used-uninitialised warning in fmt_rfc2047.c.
I don't think it can actually be used uninitialised, but the
code is too complicated for the compiler to realise this.
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Dec 20 21:13:32 2010 +0000
Fix used-uninitialised warning in new.c
Fix a used-uninitialised warning in new.c by having the check_folders()
routine return first=last=NULL for empty folder lists. This is a more
sensible API anyway. (It would not actually have been possible for
the code to try to use last while it was uninitialised, as it happens.)
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Dec 20 21:13:32 2010 +0000
Fix crash if fnext/fprev are given an empty folder list
Add a check for a NULL pointer, which stops fnext/fprev
from segfaulting if given an empty folder list (for example
via 'fnext -folders emptyfile').
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Dec 20 19:54:43 2010 +0000
Fix warning in sbr/folder_addmsg.c by code cleanup
Clean up some rather oddly written code in folder_addmsg()
so it is easier to understand for both humans and for the
compiler (and the compiler thus stops complaining about an
uninitialised variable).
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 16 13:20:31 2010 -0500
Fix so this compiles without SASL support.
Damn you, Oliver Kiddle, for finding all of the bugs I add to nmh!
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 16 13:11:17 2010 -0500
All of the arguments to AC_ARG_ENABLE need to be quoted, otherwise the
last action doesn't make it into the configure script.
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 16 13:02:32 2010 -0500
Make sure we ignore config.h.in~
Author: Markus Schnalke <meillo@marmaro.de>
Date: Thu Dec 16 01:36:43 2010 +0100
fix typo and clarify two sentences in mhpath man page
Author: Markus Schnalke <meillo@marmaro.de>
Date: Thu Dec 16 01:25:11 2010 +0100
improve mhparam man page
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Thu Dec 16 01:23:16 2010 +0100
fix badly formatted code found by Markus Schnalke
Author: Scott Snyder <snyder@bnl.gov>
Date: Wed Dec 15 22:17:52 2010 +0100
propagate and check return status of close() in slocal
Author: Markus Schnalke <meillo@marmaro.de>
Date: Wed Dec 15 22:02:30 2010 +0100
document msg parameter to folder
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Dec 14 18:04:01 2010 +0100
switches need to be renumbered following removal of some switches so,
e.g. inc -version was not working
Author: Ken Hornstein <kenh@pobox.com>
Date: Thu Dec 9 15:29:29 2010 -0500
Massive garbage collection. Remove functionality for APOP, RPOP,
all NNTP support (including bboards) and MPOP.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 8 14:36:36 2010 -0600
* uip/whatnowsbr.c: enforce requirement of at least one file
argument to attach command.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 8 10:47:03 2010 -0600
man/send.man: added name= portion to Content-Type
headers to reflect 2006-10-24 change to uip/sendsbr.c.
That change allowed mhstore to use the (file)name when
extracting attachments.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Dec 3 15:23:11 2010 -0500
Remove RCS keywords, since they no longer work after git migration.
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Thu Dec 2 21:04:30 2010 -0500
Whoops, forgot to bracket the calls for TLS shutdown with a #ifdef TLS_SUPPORT
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Thu Dec 2 20:37:54 2010 -0500
Update for git conversions (and cleanup of autogen.sh to use autoreconf)
Author: Ken Hornstein <kenh@cmf.nrl.navy.mil>
Date: Thu Dec 2 18:03:22 2010 -0500
Change configure.in to emit a warning when an argument is given to
--with-cyrus-sasl.
Author: Ken Hornstein <kenh@pobox.com>
Date: Sun Nov 21 22:19:51 2010 +0000
Fix the test for sasl.h to look in the correct place.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Nov 19 20:13:39 2010 +0000
(Minor) cleanup of some of the autoconf code with respect to the handling
of compiler flags for SASL, and also rototill (and simplify) the autoconf
handling for the same.
Add TLS support for the SMTP MTA.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Fri Nov 12 23:28:26 2010 +0000
man/slocal.man: fix formatting error that meant a subsection heading
wasn't displayed as such. Followon cleanup: since the new heading is too
wide to fit in the margin, tidy the margin to 4 characters wide so we
are consistent with how all the headings are displayed.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed Nov 10 22:26:07 2010 +0000
configure.in: add a level of expansion for mandir when printing the
end-of-configure install path summary.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Nov 9 21:33:22 2010 +0000
man/rmm.man: fix error in synopsis: the option is [no]unlink, not [no]link.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Fri Nov 5 22:06:10 2010 +0000
Silence a (harmless) uninitialized variable warning.
Author: David Levine <levinedl@acm.org>
Date: Tue Aug 31 15:00:53 2010 +0000
* uip/.cvsignore: added "new".
Author: Earl Hood <earl@earlhood.com>
Date: Sat Feb 6 07:47:38 2010 +0000
#ifdef AI_ADDRCONFIG since older IPv4-only systems may not define this flag,
causing files that use to not compile.
Author: Earl Hood <earl@earlhood.com>
Date: Sat Feb 6 07:45:47 2010 +0000
Fixed variable declaration so older compilers will not complain.
I.e. Older compilers may not support C99, so variables must be
declared at the beginning of a block.
Author: Earl Hood <earl@earlhood.com>
Date: Thu Feb 4 01:39:21 2010 +0000
* Bug #15213, #18635: The use of the insecure m_scratch() and
m_tmpfil() functions have been replaced by m_mktemp()
or m_mktemp2() functions (defined in sbr/m_mktemp.c).
The new functions use mkstemp() to securely create
temporary files to avoid the numerous race conditions
that exist with the old functions. This does assume
that mkstemp() is available. Unsure if we need to
create an alternative implementation if mkstemp() is
not available. More information about new temp file
functions in m_mktemp.c, including the support for
MHTMPDIR, TMPDIR, and TMP envvars.
NOTE: The files sbr/m_scratch.c and sbr/m_tmpfil.c should be removed.
Until more testing verifies changes to support new functions have not
broken functionality, the files are be left in the tree, but comments
have been added stating the functions in them should not be called.
Author: Earl Hood <earl@earlhood.com>
Date: Wed Feb 3 05:56:56 2010 +0000
* mts/smtp/smtp.c: added SASL support if mts configuration
setting is set to "sendmail". This is useful if sendmail
conf option is to a custom script that creates a proxy
connection to an smtp server.
* sbr/mts.c: added support for MHMTSCONF and MHMTSUSERCONF
envvars. The former specifies an alternative system
mts.conf to use. The later specifies a user-specific
mts.conf to use. This one will be read after the system
conf, so the user's conf only needs to set options they
want to override. The MHMTSUSERCONF allows a user to set
personal alternative mail submission methods w/o affecting
other users on the system.
* uip/whom.c: added SASL-based options so address checking
can work against a server that requires SASL.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 30 01:42:45 2009 +0000
* uip/mhlistsbr.c, uip/mhlsbr.c, uip/picksbr.c: cast
pointers to unsigned long before casting to unsigned int
to avoid warnings on 64-bit about casting from pointer
to int of different size.
Author: David Levine <levinedl@acm.org>
Date: Wed Dec 30 01:41:47 2009 +0000
* uip/new.c: cast folder_len to int to avoid warning on
64-bit about passing a size_t to an int conversion specifier.
Author: David Levine <levinedl@acm.org>
Date: Fri Dec 25 14:47:39 2009 +0000
* uip/inc.c: gcc 4.4.1 noticed that maildir could have been
used before initialization. In fact, if that code was ever
reached, maildir would never have been initialized. It's in
an adios call, so replaced with NULL.
Author: David Levine <levinedl@acm.org>
Date: Mon Dec 21 17:18:04 2009 +0000
* mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
sasl_inbuffer because it could be used in sm_fget (). Also,
removed allocation of sasl_inbuffer because that was done in
either smtp_init () or sendmail_init ().
Author: Josh Bressers <josh@bress.net>
Date: Mon Jan 26 13:38:13 2009 +0000
Remove duplicate sm_fgetc() declaration
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jan 21 19:38:36 2009 +0000
Fix warning in getaddrinfo() call.
Add missing support for -port in whatnow.
Make sure the SASL input buffer is allocated when using the sendmail mts.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sun Jan 18 04:48:42 2009 +0000
* etc/mhn.defaults.sh: Never try to make mhshow start xterm.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Jan 17 16:53:07 2009 +0000
Note 'new' commands.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Sat Jan 17 16:47:29 2009 +0000
* test/runtest, test/tests/inc/test-deb359167,
test/tests/inc/test-eom-align, test/tests/manpages/test-manpages:
Load common.sh via absolute path, otherwise some /bin/sh
(e.g. dash) can't load it.
* uip/Makefile.in, uip/new.c, test/tests/new/test-basic: Add new
program, and fn/fp/unseen symlinks.
* test/{runtest,setup-test}: Move MH profile under Mail directory
so each test script will have its own to muck with, if needed.
* h/Makefile.in, h/crawl_folders.h, sbr/Makefile.in,
sbr/crawl_folders.c, uip/folder.c: Extract the folder crawling
code from folder.c into new crawl_folders function, using a
callback to assemble the folder info in folder.c. Drop compare
function and use strcmp instead. Rename addfold and addir to
add_folder and add_children (add dir vs. add folder?
confusing names).
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 16 15:48:09 2009 +0000
Move freeaddrinfo() to inside of our loop; this prevents a memory leak
and also prevents it from being called with a NULL pointer.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Jan 16 02:28:54 2009 +0000
Massive overhaul of networking code. Changes:
- All networking interfaces now converted to new APIs (getaddrinfo() and
the like). All networking now supports IPv6 (with the exception of
the built-in FTP client).
- SASL security layers are now supported for SMTP.
- Command-line and profile-based selection of the SMTP server and port.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Fri Dec 26 21:54:19 2008 +0000
* sbr/m_getfld.c: fix two bugs which could cause us to walk off
the beginning of the stdio or prefix-string buffer when checking
for presence of the end-of-message delimiter in some situations.
This might cause inc to dump core if you were unlucky. (This was
Debian bug 359167.)
* test/tests/inc/{md5sums,msgheader.txt,test-deb359167,
test-eom-align,fromline.txt,filler.txt,deb359167.mbox}: new tests
both for the specific problem and to try to check various alignments
of the eom string with the stdio buffer ending.
* test/common.sh: Added some functions for doing progress indicators.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Fri Dec 26 16:32:07 2008 +0000
test/common.sh: new file for common utility functions for the test scripts.
Moved findprog out of manpage test script into this new file.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Thu Dec 25 23:30:33 2008 +0000
test/runtest: automatically run setup-test if it hasn't already
been done. Improve error handling in test script with 'set -e'.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 23 18:38:22 2008 +0000
* h/mh.h: raised NAMESZ from 128 to 999. RFC 2822 limits line
lengths to 998 characters, so a header name can be at most that long.
m_getfld limits header names to 2 less than NAMESZ, which is fine,
because header names must be followed by a colon. Add one for
terminating NULL.
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 23 18:14:52 2008 +0000
* sbr/m_getfld.c: in warning message, use NAMESZ-2 instead of
NAMESZ-1 bytes because the message says "exceeds", not
"is greater than or equal to".
Author: David Levine <levinedl@acm.org>
Date: Thu Oct 23 16:45:36 2008 +0000
* docs/MAIL.FILTERING: added note on removing procmail -f or
-r options to try to suppress generation of a "From " line on
incoming messages.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Tue Aug 19 04:36:42 2008 +0000
+mhn.defaults.sh.cfg
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 19:47:29 2008 +0000
* test/setup-test: Don't run autogen.sh unless needed. Build in a
blddir under the temporary directory so as not to interfere with
whatever the developer may be doing in the source directory.
If the temporary directory already exists, rebuild and install it.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 06:19:08 2008 +0000
This is what happens with last-minute "safe" improvements: actually point
chset to something in the new merged InitText!
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 01:50:45 2008 +0000
* sbr/ambigsw.c: Send print_sw output to stderr. This avoids
strange problems with scan `pick -bogus`, not to mention being
nicer anyway.
* sbr/getans.c, sbr/print_help.c, uip/msh.c: Send print_sw output
to stdout.
* h/prototypes.h, sbr/print_sw.c (print_sw): Add FILE * argument
and send output there rather than to stdout.
* test/tests/pick/test-stderr: Add test that error messages don't
end up going to stdout.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 01:31:11 2008 +0000
* uip/pick.c: Ensure valid sequence name as soon as we parse it from
command, instead of searching the messages first.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 01:28:56 2008 +0000
* uip/pick.c: Print matching messages immediately, instead of
waiting until the very end to print anything.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 01:11:12 2008 +0000
* uip/Makefile.in, uip/popi.c: Remove popi.c, which has been dead
since PatchSet 257 (2000/06/12 11:07:34 UTC).
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Thu Aug 14 00:56:38 2008 +0000
* h/mhparse.h: Move interfaces also used by mhbuildsbr.c here
from mhparse.c.
* uip/Makefile.in (mhbuild): Build with mhparse.o.
* uip/mhbuildsbr.c: Drop the duplication of mhparse.c.
* uip/mhbuild.c, uip/mhlist.c, uip/mhn.c, uip/mhshow.c,
uip/mhstore.c, uip/mhtest.c: Drop check swdeclaration, which is
now in mhparse.h.
* uip/mhparse.c: Move some declarations to mhparse.h, and remove
'static' from the definitions here.
(get_ctinfo): Take magic mhbuild support from mhbuildsbr.c's copy,
and adapt callers.
(incl_name_value, extract_name_value): Move from mhbuildsbr.c to
support get_ctinfo change).
(get_content, open7Bit): Add Content-Disposition support, added to
mhbuildsbr.c's copy in mhbuildsbr.c r1.12 (PatchSet 549).
(InitText): Default to CHARSET_UNSPECIFIED instead of "US-ASCII",
as mhbuildsbr.c's copy did. Explain termproc.
(openBase64, openQuoted, open7Bit): Fix comment from r1.5:
suffixes, not prefixes.
(openMail): Explain showproc.
* test/tests/mhshow/test-cte-binary: Add test for
Content-Transfer-Encoding: binary (Debian #136976).
* test/tests/mhbuild/test-forw: Add an mhbuild test, testing forw
with and without RFC-934 mode. More mhbuild tests would be nice.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Aug 13 23:59:56 2008 +0000
Oops, meant to use $failed (number of failed checks) as the exit code.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Aug 13 23:32:03 2008 +0000
Add descriptive headers, as other tests have.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Aug 13 18:27:36 2008 +0000
* test/tests/bad-input/test-header: Add test for it.
* sbr/m_getfld.c: If we reach the end of the line without finding
a ':' when parsing a header field, treat that line as the
beginning of the body rather than blowing up. These messages are
usually spam, but it's nice to be able to at least scan them.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Aug 13 01:01:12 2008 +0000
* test/tests/mhshow/test-qp: Test various valid and invalid
escape sequences.
* uip/mhparse.c (openQuoted): Simplify the decode-or-show for loop by
peeking ahead to the next byte(s) when encountering '=', and just let
invalid escape sequences through as literals (fixes bug #15245).
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Wed Aug 13 01:00:20 2008 +0000
Ignore test-temp-dir.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Tue Aug 12 21:01:30 2008 +0000
add one more hint for developers, to explicitly point at docs/README.developers
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Aug 12 18:04:29 2008 +0000
autogen.sh (new file): add script for running the GNU autotools in the
right order. Mention and use new script in the appropriate places.
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Fri Aug 8 23:45:24 2008 +0000
* sbr/discard.c, sbr/m_getfld.c, uip/scansbr.c: Add support for
DragonFlyBSD stdio (from NetBSD pkgsrc).
Author: Eric Gillespie <epg@pretzelnet.org>
Date: Fri Aug 8 04:45:05 2008 +0000
s/ls/cd/ in comment (probably pasted from test-ls)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Aug 5 21:06:00 2008 +0000
uip/folder.c: chdir(nmhdir) in main rather than in dodir, which
is called many times. Drop the chdir in get_folder_info, which
served no purpose at all. If struct stat has d_type (BSD), use
that to skip processing (strcmp, stat, and so on) of message
files, mostly undoing the slow-down from the last change.
Plus autoconf machinery to detect d_type field. Patch from Eric Gillespie.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Aug 5 19:09:03 2008 +0000
Dump hacky overoptimisation in addir -- it doesn't actually get the case
of symlinks to directories right. Patch from Eric Gillespie.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Aug 5 19:05:23 2008 +0000
Simplify dodir/addir/addfold (patch from Eric Gillespie)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 18:47:56 2008 +0000
bug #23319: rework the way we handle the working directory when invoking
the user's shell, so that we don't have issues when the cwd contains a
space or shell special character.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 18:45:34 2008 +0000
test/setup-test: use 'set -e' so we stop on compile failure.
Configure --enable-debug for convenience in debugging.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 15:19:53 2008 +0000
Add protective 'do { ... } while (0)' wrappers to multistatement macros
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 15:14:23 2008 +0000
Bug #23436: fix some minor manpage syntax errors and add a test which runs
groff over them and checks that no warnings are emitted.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 15:13:34 2008 +0000
Allow tests to indicate that they have been skipped by printing their
own message and returning with exit status 120.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 13:59:19 2008 +0000
Ignore editor backup files
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 13:54:37 2008 +0000
etc/replcomps, etc/replgroupcomps: Trim trailing whitespace from
Subject field (patch from Eric Gillespie)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Aug 3 13:32:17 2008 +0000
When doing an if-test on the result of a function which returns a string
result, check whether the string is non-empty (as the documentation says we
do). Previously we were always testing the integer 'value'.
Author: Josh Bressers <josh@bress.net>
Date: Fri Jul 25 01:07:39 2008 +0000
* test/setup-test: Run 'make clean' before building
Author: Josh Bressers <josh@bress.net>
Date: Fri Jul 25 00:11:53 2008 +0000
* test/runtest: cat test-temp-dir only once. Destroy and create
test Mail hierarchy here, so each test has its own independent
test data.
* test/setup-test: Drop needless pushd/popd, which don't exist in
sh anyway. Don't use aclocal, which is part of automake.
Don't create Mail hierarchy here (see test/runtest).
* test/tests/folder/test-create, tests/folder/test-total: Drop
unused BINDIR.
* tests/pick/test-pick: Remove failing no-op test.
* test/tests/scan/test-scan: Write expected and actual output to
files and diff them. This way, if the output differs, diff
provides the FAILing exit code and shows the differences.
Author: Josh Bressers <josh@bress.net>
Date: Fri Jun 13 00:11:49 2008 +0000
* man/repl.man, etc/mhl.reply:
Add an attribution line when replying to messages.
Author: Josh Bressers <josh@bress.net>
Date: Thu Jun 12 23:29:16 2008 +0000
Remove an accidentally committed file
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Jun 2 22:37:01 2008 +0000
When building on gcc, use noreturn attribute on adios and the various done
functions.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Jun 2 22:05:11 2008 +0000
Back out previous, completely broken, change (due to a foulup I was
compiling a different tree to the one I was committing to CVS).
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Jun 2 21:49:07 2008 +0000
If we're compiling with gcc, mark adios() as never returning (better code
and fewer spurious 'uninitialized variable) warnings)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Jun 1 16:50:22 2008 +0000
Update bit of docs about release announcements.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Thu May 22 10:37:55 2008 +0000
Don't use MB_CUR_MAX if we aren't compiled with multibyte support.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Thu May 22 10:21:48 2008 +0000
Factor out common code for writing ls shell command. Rework its length
checking so it doesn't rely on the return value of sprintf(), for the
benefit of SunOS 4.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed May 21 18:05:49 2008 +0000
Don't rely on realloc() to follow POSIX in handling a NULL pointer
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed May 21 17:16:44 2008 +0000
Add some table size declarations for the benefit of elderly lexes with
small defaults (eg SunOS 4)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue May 20 19:04:57 2008 +0000
Update comment now we don't use lex -o.
Author: David Levine <levinedl@acm.org>
Date: Sun May 18 13:56:58 2008 +0000
* sbr/addrsbr.c: removed "err" from conditional, because gcc
correctly warned that it would always evaluate as true. It's
the address of a static array.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Fri May 16 15:31:26 2008 +0000
don't use $< in target rules in makefiles, as POSIX says it's only defined
in inference rules
Author: David Levine <levinedl@acm.org>
Date: Tue May 13 02:39:04 2008 +0000
* configure.in, INSTALL: if --enable-masquerade is not
specified to configure, enable all supported masquerade forms.
This allows users to masquerade with the default
configuration. That seems to be more worthwhile now than
trying to prevent users from using it, especially with
single-user installations or those where a user can edit
etc/mts.conf.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun May 4 20:58:35 2008 +0000
bug #23167: sbr/ruserpass.c (ruserpass): make bad permissions on .netrc be
an instantly fatal error. Previously we returned an error value; however, no
caller was checking it. So now ruserpass() has a void return type.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun May 4 16:09:08 2008 +0000
* bug #23163: various minor fixes for the benefit of older Unixes
(specifically SunOS 4): reintroduce strerror() substitute implementation;
provide memmove() substitute implementation
* bug #23163: fix broken 'build outside source directory' feature
* bug #23162: sbr/dtime.c: fix stray HAVE_TM_GMTOFF that wasn't updated
to the new macro name.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed Apr 30 18:47:02 2008 +0000
Provide SASL_CB_AUTHNAME callback (avoids problem with wrong username
being sent in some situations)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Apr 29 21:05:30 2008 +0000
Correct various places in smtp.c where the reply string might not have been
correctly NUL-terminated. Includes a fix for a particularly nasty and long
standing screwup where the buffer length counting in smhear() was totally
broken for continued lines from the server.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Apr 29 20:59:04 2008 +0000
Fix SASL issue properly, by making sm_rrecord() and thus sm_hear() set
the length of the reply string correctly (the SASL libraries now care
if you pass in the wrong length).
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Apr 29 20:53:33 2008 +0000
Revert previous SASL fix (wrong approach)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Tue Apr 29 17:04:38 2008 +0000
Cope with sasl_decode64() returning SASL_CONTINUE as well as SASL_OK.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Apr 28 21:13:53 2008 +0000
Add remark about how to update the homepage.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 27 20:58:50 2008 +0000
Update some of the 'how to do a release' documentation
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 27 20:55:28 2008 +0000
Up version string to 1.3-dev for the CVS trunk.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 27 19:54:37 2008 +0000
Use hyphen, not plus (corresponding to previous RCx naming convention)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 27 19:44:58 2008 +0000
Bump version number, date for release of 1.3 RC1
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Fri Apr 11 14:12:54 2008 +0000
move most remaining macros out of acconfig.h which is an obsolete feature of
autoconf
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Apr 5 19:04:41 2008 +0000
* bug #18655: fix use of admonish() for a fatal error (should
be adios(); only actual effect would be wrong exit code).
Thanks to Craig Leres for spotting this.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Apr 5 18:41:37 2008 +0000
Bug #20028 (Debian bug 399271): fix code assuming that pointer
differences were 32 bits -- thanks to Dean Gaudet for the patch.
Author: Josh Bressers <josh@bress.net>
Date: Fri Jan 25 21:00:42 2008 +0000
* uip/mhshowsbr.c (show_all_messages): Be more generous when parsing
multipart messages.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Thu Nov 8 02:28:38 2007 +0000
Insert types for args of some function pointers to improve type checking.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Nov 4 11:54:32 2007 +0000
Return type of (*done)() changed to void. default_done() replaced by
exit(). All dead code "return 1" lines removed from *_done()s and replaced
by explicit "return 1" following done() calls in main()s (they should
never be reached). This should make cleaning up program termination
structures easier.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Nov 4 08:52:17 2007 +0000
Refactor cts pointer and free()ing on abnormal exit of associated list
into mhfree.c, eliminating duplication.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Nov 4 04:47:17 2007 +0000
Change link-time overriding of done() to run-time reassigning of equivalent
(*done)(). This should make changing the return type of done and the
rationalisation of exit code easier.
Author: Bill Wohler <wohler@newt.com>
Date: Mon Sep 24 07:02:03 2007 +0000
The MH web site is now http://rand-mh.sourceforge.net/ and the MH
book is now at http://rand-mh.sourceforge.net/book/.
Changed Questions
1.02 ...current version? mailutils 1.2
1.03 Where can I get MH? Debian 4.0 nmh 1.1-RC4, update links, mu 1.2
1.04 ...references for MH? Refer to SourceForge
1.06 How...print a MH manual? Refer to SourceForge
2.17 How...build MH on a Mac? Use fink
4.05 ...tools to archive MH? Mention swish++, mairix, and namazu
Author: Josh Bressers <josh@bress.net>
Date: Tue Aug 21 21:19:39 2007 +0000
* Red Hat Bug #253342: inc.c, utils.c, utils.h: When inc is run with the
-silent flag, don't exit(1) for no apparent reason.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 29 22:57:36 2007 +0000
Rename functions to avoid clash with C library exp2().
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 29 22:34:04 2007 +0000
Suppress 'uninitialised variable' warning.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 29 22:05:02 2007 +0000
On Linux, define _GNU_SOURCE so that GNU libc exposes the wcwidth()
prototype in wchar.h.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 29 22:01:04 2007 +0000
Change name of internal function to avoid potential conflicts with GNU
libc's getline() function.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 29 20:49:32 2007 +0000
Minor rearrangement so variables/functions used only if !HAVE_LIBLOCKFILE
are also declared only in that case.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Apr 29 19:36:14 2007 +0000
For gcc, make the default CFLAGS include -Wno-pointer-sign if the compiler
recognises it. gcc 4 now by default produces a large volume of these
warnings, which I believe are probably spurious and definitely a lot of
work to go through and fix. So we suppress them for now so that the other
warnings are more easily visible.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Tue Apr 17 04:53:54 2007 +0000
buffer is compared with cp, and so needs to be changed to unsigned too.
Author: Josh Bressers <josh@bress.net>
Date: Tue Apr 17 01:02:08 2007 +0000
Initial checkin of a testsuite
Author: Joel Reicher <jjr@panacea.null.org>
Date: Fri Apr 13 11:53:08 2007 +0000
Change all chars being passed to the ctype macros (isalph(), etc.) to
be unsigned chars, following through to change any other types as
necessary (e.g. comparison between two pointers). Not all chars have
been changed to unsigned chars; just those that were in danger of being
sign extended when passed to the int-taking ctype macros.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Tue Apr 10 22:12:26 2007 +0000
We're not using the .Bu macro anymore.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Tue Apr 10 06:13:27 2007 +0000
Fix for bug #11139: mhl -form mhl.reply omits '> ' on some lines.
putcomp() was assuming only the first call on the body had the buffer
beginning at the start of a line.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Tue Apr 10 03:32:48 2007 +0000
Application of patch #5218: patch for bug #9742. Fixes a typo in the
size arg of snprintf(). mhlist output which used to have incorrect lines
such as
1.2 multipart/mixed 772
1.21 text/plain 9
1.22 multipart/mixed 162
now have the correct
1.2 multipart/mixed 772
1.2.1 text/plain 9
1.2.2 multipart/mixed 162
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed Mar 21 00:21:10 2007 +0000
bug #18630, #18631, #18632, #18634: various patches from Craig Leres
fixing error message argument problems.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed Mar 21 00:18:19 2007 +0000
bug #15212: remove configure test for broken AT&T vi. This test was broken
and unfixable. Support for manually defining ATTVIBUG remains.
Author: Josh Bressers <josh@bress.net>
Date: Tue Jan 16 02:08:10 2007 +0000
Add a missing header file
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Nov 5 13:20:46 2006 +0000
Changed bold "-all" to unbolded "all". It's a reserved msgs word, not a flag.
Author: David Levine <levinedl@acm.org>
Date: Tue Oct 24 14:31:40 2006 +0000
* uip/sendsbr.c: with attachformat values of 1 or 2, add
name= portion to Content-Type header. This makes them
consistent with attachformat value 0. And it allows mhstore
to use that (file)name when extracting attachments.
Author: Josh Bressers <josh@bress.net>
Date: Sun Aug 27 01:19:39 2006 +0000
* configure.in: If we're not using dotlocking, there is no need to set inc
sgid.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Jun 4 08:37:24 2006 +0000
Fixed bug introduced when changing from check_folder() to new
create_folder() function. The folder name needed to be expanded to an
absolute path first. Similar things may have happened with other
conversions.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Thu Apr 27 12:00:28 2006 +0000
Created pluspath function to check for '+' prefix and change flag for
path() appropriately. This eliminates some duplicate prefix processing,
but not all. The path functions need to be restructed; this is the first
step.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Mon Apr 24 07:10:03 2006 +0000
ssequal() does not check for a substring, but for a prefix, so added a
comment to this effect. If this is sufficient, the function body should
remain unchanged but the name and comments should be modified. If not,
then the function needs to be corrected.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Sat Apr 22 16:33:48 2006 +0000
fixes case where a very long character-class range (128 or
more characters) causes negative indexing into pattern string.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Apr 16 06:47:59 2006 +0000
Fixed a typo.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Fri Apr 14 14:10:15 2006 +0000
Created function open_form() to open form file or fallback to default
components file, with error handling. Replaced duplicated code with call
to this function.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Fri Apr 14 08:42:04 2006 +0000
Fixed a couple of typos.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Fri Apr 14 08:21:35 2006 +0000
Sanitised some dodgy homedir finding code, but it still might not make
sense.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Fri Apr 14 07:54:26 2006 +0000
Get rid of some trivial warnings; unused variables, ambiguous if-else,
missing headers.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Thu Apr 13 14:24:41 2006 +0000
Make print_aka() and print_usr() static. They're not used outside ali.c.
Author: Joel Reicher <jjr@panacea.null.org>
Date: Tue Apr 11 14:09:11 2006 +0000
Created app_msgarg() (append message arg) and a simple resizable array
struct to go with it that do almost exactly what the code they've replaced
was doing.
Replaced this (duplicated) code in many files with a call to app_msgarg().
Author: Joel Reicher <jjr@panacea.null.org>
Date: Tue Apr 11 05:48:43 2006 +0000
Completing the .cvsignore list(s).
Author: Joel Reicher <jjr@panacea.null.org>
Date: Sun Apr 9 14:06:31 2006 +0000
Fixed a small typo.
Author: Paul Fox <pgf@foxharp.boston.ma.us>
Date: Fri Mar 31 15:14:49 2006 +0000
this commit:
- adds range support to character classes
- fixes out-of-bounds references to the case-folding array
when doing case comparisons for 8-bit message text
- makes character classes as case tolerant as the rest
of the pick regexp machine. (where lowercase chars in
patterns should match uppercase in the text.)
- fixes an uninitialized pointer warning, which might actually have
been a real bug
Author: David Levine <levinedl@acm.org>
Date: Thu Mar 30 22:19:50 2006 +0000
* uip/sendsbr.c: with attachformat values of 1 or 2, only
generate Content-Disposition headers for MIME attachments, not
for the message contents themselves. Microsoft Outlook Build
10.0.6626, at least, doesn't show the message contents if they
have Content-Disposition.
Author: Bill Wohler <wohler@newt.com>
Date: Fri Mar 10 09:00:20 2006 +0000
Changed Questions
1.03 Where can I get MH? nmh 1.2
Author: Bill Wohler <wohler@newt.com>
Date: Fri Mar 10 06:58:28 2006 +0000
Since faqs.org appears to be moribund, I'm now using my site as the
official location of the MH FAQ. I added some missing quotes in
various places, so now Emacs highlighting works better.
New Questions
5.26 How do I fix a bogus In-Reply-To or missing References field?
Changed Questions
1.02 current version? nmh 1.2
1.04 references for MH? New FAQ official site. MH-E manual URL
5.15 make sense of replcomps? Use 1.1 version
Author: Josh Bressers <josh@bress.net>
Date: Thu Mar 9 19:51:13 2006 +0000
* sbr/fmt_rfc2047.c (decode_rfc2047): Don't close the iconv descriptor if
it isn't valid.
Author: Josh Bressers <josh@bress.net>
Date: Wed Mar 8 12:14:15 2006 +0000
* (mh_strcasecmp): Rename the private strcasecmp function to mh_strcasecmp.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Sun Mar 5 14:48:05 2006 +0000
and close iconv handle if encoded block empty
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Sun Mar 5 14:38:23 2006 +0000
don't try to malloc 0 bytes if an RFC2047 encoded block is empty
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Mar 4 22:14:18 2006 +0000
Install scripts with INSTALL_SCRIPT so INSTALL_PROGRAM can be set to
'install -s' without it causing the installation of the scripts to fail.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 25 14:14:06 2006 +0000
* uip/sendsbr.c: replaced st_mtim with st_mtime, that's what
it should have been. Added #include of h/tws.h to pick up
dtime() prototype.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 21 04:13:06 2006 +0000
Replaced second line of Content-Tyhpe of -attachformat 0 example.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 21 03:58:31 2006 +0000
* h/mh.h, h/prototypes.h, uip/mhbuildsbr.c, uip/send.c,
uip/sendsbr.c, uip/viamail.c, uip/whatnowsbr.c, man/send.man:
added -attachformat switch to send, to support alternate MIME
header contents when using -attach. See send man page for
description.
Author: David Levine <levinedl@acm.org>
Date: Tue Feb 21 03:51:53 2006 +0000
* man/mhbuild.man: wrapped one appearance of "Content-Disposition"
with quotes, to be consistent with others.
Author: Josh Bressers <josh@bress.net>
Date: Tue Feb 21 01:11:51 2006 +0000
* h/utils.h, sbr/utils.c, uip/flist.c, uip/folder.c: Move duplicate
function num_digits into utils.c
Author: Josh Bressers <josh@bress.net>
Date: Tue Feb 21 01:05:24 2006 +0000
Add missing create_folder prototype.
Author: Josh Bressers <josh@bress.net>
Date: Mon Feb 20 03:09:07 2006 +0000
* sbr/m_draft.c, sbr/utils.c, uip/folder.c, uip/inc.c, uip/mhstoresbr.c,
uip/popi.c, uip/refile.c: Add create_folder() function, replacing duplicate
code during folder creation.
Author: David Levine <levinedl@acm.org>
Date: Sat Feb 18 16:26:37 2006 +0000
Added support for optional Content_Disposition header in mhbuild directive.s
Author: David Levine <levinedl@acm.org>
Date: Sun Feb 12 18:06:44 2006 +0000
Added RFC2183 to reference of RFC1806 for Content-Disposition header.
Author: David Levine <levinedl@acm.org>
Date: Tue Jan 31 02:50:57 2006 +0000
Added -nocontentid (and -contentid, for symmetry) switch to mhbuild. This allows users to disable generation of the Content-ID: header in MIME messages, in order to placate broken version(s) of Outlook.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Sun Jan 29 19:34:42 2006 +0000
remove trailing newlines from components to fix bug with spaces at the end of
Subject/References in replies
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Jan 18 18:08:16 2006 +0000
use AS_HELP_STRING for formatting help messages
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Jan 18 17:07:28 2006 +0000
add autoconf magic to support old systems that don't support multibyte charsets
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Jan 18 16:43:27 2006 +0000
fix bug with insertion of newline being wrong if the num function was used at
the end of the format buffer
Author: David Levine <levinedl@acm.org>
Date: Wed Jan 18 00:09:00 2006 +0000
Fixed make_bcc_file () to use contents of From: in draft, if draft_from masquerade flag is enabled.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Jan 17 18:06:58 2006 +0000
more robust multi-byte/column support for field widths
restore right justification feature
Author: Josh Bressers <josh@bress.net>
Date: Mon Jan 16 17:07:14 2006 +0000
* uip/post.c, uip/spost.c: Move the uptolow macro from spost.c to post.c
where it is needed.
Author: Josh Bressers <josh@bress.net>
Date: Mon Jan 16 12:42:11 2006 +0000
* sbr/fmt_scan.c: Add the missing wchar.h include
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Mon Jan 16 10:40:32 2006 +0000
*** empty log message ***
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Mon Jan 16 10:00:46 2006 +0000
remove remnants of code for MMDF
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Mon Jan 16 09:55:24 2006 +0000
multiply buffer size by MB_CUR_MAX so multi-byte chars fit
Author: Josh Bressers <josh@bress.net>
Date: Sun Jan 15 02:52:12 2006 +0000
* sbr/fmt_scan.c:PUTSF() Fix an off by one formatting issue.
Author: Josh Bressers <josh@bress.net>
Date: Sun Jan 15 02:29:38 2006 +0000
* sbr/fmt_scan.c: Turn the PUTSF macro into a function capable of handling
multi column characters.
Author: Josh Bressers <josh@bress.net>
Date: Sat Jan 7 15:22:19 2006 +0000
* Remove sbr/strerror.c -- strerror(3) is defined in C89.
Author: Josh Bressers <josh@bress.net>
Date: Fri Jan 6 21:51:43 2006 +0000
* patch #3968: Move the add() function from its own file (add.c) and
into utils.c. There was also a duplicate add() function in mf.c which
has been removed.
Author: Josh Bressers <josh@bress.net>
Date: Wed Jan 4 02:10:25 2006 +0000
* mh_xmalloc(), mh_xrealloc(), pwd(): Add comments describing the purpose
of the function.
Author: Josh Bressers <josh@bress.net>
Date: Tue Jan 3 01:08:33 2006 +0000
Remove sbr/pwd.c file, moving the pwd() function into sbr/utils.c.
Author: Josh Bressers <josh@bress.net>
Date: Mon Jan 2 03:25:18 2006 +0000
* patch #3967: Create a mh_xrealloc function to prevent mistakes when
calling realloc.
Author: Josh Bressers <josh@bress.net>
Date: Mon Jan 2 03:17:41 2006 +0000
* patch #3966: Create a mh_xmalloc function to prevent mistakes when
calling malloc.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Dec 24 17:53:26 2005 +0000
Avoid non-portable use of $< outside an inference rule.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Dec 24 17:17:38 2005 +0000
Rework detection and handling of ndbm: we now check for a working
(library,header) combination, and configure defines variables for each
which the makefile and C file just use, rather than a bunch of HAVE_foo
switches. As a bonus, we no longer unnecessarily link every binary with
the ndbm library even though only slocal uses it. Also you can now tell
configure where to get the header/library so even if we guess wrong you
can overrule us.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Thu Dec 22 10:38:32 2005 +0000
Fix stupid accidental dependence on a bash quirk in previous
configure script change.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Dec 20 04:39:51 2005 +0000
Rolled release.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Thu Dec 15 00:45:36 2005 +0000
Improve the checks for where to find ndbm (dbm_open etc); should now
work on systems with new gdbm and libdb4.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Thu Dec 15 00:12:52 2005 +0000
Change some non-standard formatting in a previous log entry so it matches
the conventions used in other entries.
Author: Josh Bressers <josh@bress.net>
Date: Wed Dec 14 01:48:24 2005 +0000
* Fedora Bug #163760: sbr/context_read.c (context_read): Ensure that the
context is only read once.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Mon Dec 12 22:30:44 2005 +0000
Fixed annotate call for new delete argument values.
Author: Josh Bressers <josh@bress.net>
Date: Mon Dec 12 20:26:53 2005 +0000
* uip/sendsbr.c (annoaux): Fix the call to annotate()
Author: Jon Steinhart <jon@fourwinds.com>
Date: Thu Dec 8 15:57:34 2005 +0000
*** empty log message ***
Author: Jon Steinhart <jon@fourwinds.com>
Date: Wed Dec 7 21:25:46 2005 +0000
Fixed a bug where anno -append put the headers in the wrong place
if applied to a message that didn't contain any headers.
Added a special value of "all" to the -number option that causes
anno -delete to delete all matching components instead of just
the first one.
Added new -preserve and -nopreserve options. Using -preserve
retains the original last accessed and last modified times on
annotated messages.
Author: Josh Bressers <josh@bress.net>
Date: Mon Dec 5 13:38:41 2005 +0000
Fix the AC_PATH_PROG default when vi isn't found during build.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Sat Dec 3 23:41:39 2005 +0000
Rolled version. Should have done it last time!
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Nov 19 16:32:34 2005 +0000
Make it clearer that lower-case envariables aren't supposed to be set
by the user.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sat Nov 19 16:04:25 2005 +0000
Special-case an MHCONTEXT of "/dev/null" and don't try to lock it -- some
user scripts may use this to suppress modification of context.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Mon Nov 14 00:18:24 2005 +0000
[bug #9813] Don't crash after removing the folder if the context file
has no Current-Folder entry.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 13 23:57:49 2005 +0000
Pass some globals into sm_init() so that it uses SASL if necessary.
[NB that as I do not have a SASL setup I am relying on (a) the patch
being obviously correct and (b) the original submitter having tested!]
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 13 23:56:30 2005 +0000
Forgot to quote the bug number in the changelog comment.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 13 23:51:18 2005 +0000
Use context/ctxpath==NULL to indicate that no context file should be read,
to avoid inadvertently trying to lock /dev/null (takes 30secs+ with some
locking methods).
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 13 22:36:07 2005 +0000
Fix buffer overrun in address parsing code (would only show up if
scan was run with -width 16536 or similar)
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Sun Nov 13 19:38:32 2005 +0000
remove link to install-mh that caused problems on some systems
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Sun Nov 13 19:27:37 2005 +0000
bug #739: install target now depends on all to avoid problem on
case-insensitive file systems with the INSTALL file
Author: Josh Bressers <josh@bress.net>
Date: Thu Nov 10 21:37:10 2005 +0000
Fix the AC_PATH_PROG default when sendmail isn't found during build.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Wed Nov 9 22:56:35 2005 +0000
Fix a non-ANSI prototype.
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Nov 8 20:22:33 2005 +0000
Simon Burge: fix to handle getutent() on NetBSD
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Nov 8 17:18:09 2005 +0000
update most references to the web page and mailing list locations
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Nov 8 16:58:08 2005 +0000
prepend DESTDIR to install locations
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue Nov 8 16:51:34 2005 +0000
replace obsolete autoconf macros
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 6 21:54:40 2005 +0000
Fix various buffer overruns in fmt_scan.c; the bulk of this is passing
buffer length through to decode_rfc2047() and having that function do
sufficient bookkeeping to avoid running off the end of the buffer.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 6 00:34:56 2005 +0000
Fix a compile error if building nmh with --enable-apop.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 6 00:32:20 2005 +0000
Don't fclose() the file twice in error-exit paths from get_content()
(was causing crashes on multipart mails with invalid Content-Type headers)
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 6 00:28:12 2005 +0000
Remove space between -o and output filename so it works on older versions
of flex as well as newer ones.
Author: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Date: Sun Nov 6 00:23:48 2005 +0000
Add an AC_PREREQ so we don't just fail with an obscure error message if
using old 2.13 era autoconf (or an autoconf-version-guessing wrapper).
Author: Josh Bressers <josh@bress.net>
Date: Fri Nov 4 22:07:48 2005 +0000
Update the instructions for subscribing to the nmh-workers list
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Nov 2 17:43:21 2005 +0000
fail when kpop connection attempted without KPOP support compiled in
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Nov 2 17:29:50 2005 +0000
fix for newer version of flex and remove autogenerated file from cvs
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Nov 2 17:22:27 2005 +0000
speed up flist by skipping stat on files with numbers as names
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Nov 2 17:16:39 2005 +0000
include new files in distribution
Author: Bill Wohler <wohler@newt.com>
Date: Tue Oct 11 01:52:45 2005 +0000
A couple of questions from nmh's original FAQ were folded into
the MH FAQ which is now a part of nmh.
New Questions
1.09 What is the copyright status of nmh?
3.23 Why do folder and flist overlook some of my sub-folders?
Changed Questions
1.02 current version? nmh history update, nmh 1.1-RC4, mailutils 0.6
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Oct 5 10:05:24 2005 +0000
Harald Geyer: back out fork/vfork workaround and handle the issue directly
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed May 18 13:45:03 2005 +0000
use fork instead of vfork on Linux
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed May 18 13:27:44 2005 +0000
test/report error writing to stdout
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed May 18 13:24:14 2005 +0000
correct SASL include file locations
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed May 18 13:16:21 2005 +0000
add bash completion definitions from Debian
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed May 18 12:57:40 2005 +0000
fix a bug affecting AFS where nmh was setting the READONLY flag for a
folder even when you do have write access to the folder
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed May 18 12:50:45 2005 +0000
Carl Mummert: add unquote() function for removing quotes from RFC-2822 headers
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Tue May 17 16:30:15 2005 +0000
fill in a few of the missing ChangeLog entries
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Feb 23 16:20:47 2005 +0000
use iconv to convert RFC-2047 encoded headers to the character set used
by the current locale
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Feb 23 14:07:52 2005 +0000
fix Debian bug #202667: crash when a message's filename overflows an int
when converted
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Wed Feb 23 11:55:25 2005 +0000
Updated config.guess and config.sub to the most recent versions
(from automake 1.9.5)
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Mon Feb 21 16:31:58 2005 +0000
fix bug where inc crashed on failing to reopen the terminal
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Thu Jan 27 16:43:03 2005 +0000
acknowledge that my change was based on an older patch from Michael Richardson
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Thu Jan 27 16:39:56 2005 +0000
Added -proxy option to inc and msgchk
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Thu Jan 27 16:34:20 2005 +0000
Added -proxy option to inc and msgchk
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Thu Jan 27 16:26:24 2005 +0000
On systems where it is available, use nl_langinfo to get the character
set if MM_CHARSET is unset
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Fri Jan 21 19:25:44 2005 +0000
US-ASCII is a subset of UTF-8 so can be handled directly when UTF-8 is
being used
Author: Oliver Kiddle <okiddle@yahoo.co.uk>
Date: Fri Dec 17 15:16:04 2004 +0000
Fix -part option to mhshow/mhlist/mhstore to find sub-parts of the specified
part
Author: Jon Steinhart <jon@fourwinds.com>
Date: Fri Nov 19 05:06:16 2004 +0000
Added mail directory argument to folder_addmsg in order to make it possible
to provide a path to the ext_hook call that is mailpath-based. A problem
existed when a folder was a symbolic link and the pwd call would return
the path relative to the filesystem, not to mailpath. A new argument was
needed because there was otherwise no reasonable way to get that path.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Nov 16 18:14:34 2004 +0000
Fixed problem where the refile hook was being called after a message was
renamed so that it wasn't around for the hook. The hook is now called
before the message file is renamed.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Nov 16 18:08:07 2004 +0000
Fixed typo in comment.
Fixed problem with refile hook when refiling across filesystems.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Nov 16 17:37:41 2004 +0000
Removed unnecessary code.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Nov 16 17:28:33 2004 +0000
Fixed wrong directory for hook when refiling with -src option.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Fri Oct 15 17:10:58 2004 +0000
Fixed calling of external hooks.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Oct 12 21:14:02 2004 +0000
Fixed another weird bug caused by the static mailpath being overwritten.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Oct 12 20:41:34 2004 +0000
Fixed bug that caused anno to mangle headers.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Oct 12 20:40:25 2004 +0000
Fixed strange bug that prevented a lock from ever being obtained if getting
it failed the first time. The problem was that the string of XXXXXX that
is required by mkstemp() was overwritten the first time through, and so
all subsequent times failed because mkstemp() failed. The fix
reinitializes the tmp file string.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Oct 12 20:38:10 2004 +0000
Fixed bug in which the static maildir was overwritted if a format string
was read from the profile.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Oct 12 20:31:14 2004 +0000
Fixed bug that was producing an incorrect path for the external hook.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Oct 6 20:11:39 2003 +0000
db configuration fix for Debian; yet another location for ndbm.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 19:55:12 2003 +0000
restored use of PUTDF() macro; was broken in versions 1.10-1.12;
replacement implementation filled on right instead of on left.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 16:57:26 2003 +0000
[bug #4302] errno is not always an extern int
The errno declaration is best left to errno.h; several systems use
#define errno (*(___errno()))
or similar
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 16:22:54 2003 +0000
corrected termination condition for fill character introduced in last version
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 16:19:12 2003 +0000
[bug #4296] PUTD() macro can't hack 10 digit values
Once the number exceeded 1000000000, the conversion would fail. An execution of
dp -format "%(clock{text})" "Tue, 01 Jul 2003 21:38:05 +0700" would erroneously print
749660476, instead of 1057070285.
The macros PUTD() and PUTDF() have been replaced by snprintf() calls; These macros
should never have been written in the first place, when system functions exist to do the
work.
(prev version 1.10 was erroneously comitted).
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 16:07:49 2003 +0000
[bug #4296] PUTD() macro can't hack 10 digit values
Once the number exceeded 1000000000, the conversion would fail. An execution of
dp -format "%(clock{text})" "Tue, 01 Jul 2003 21:38:05 +0700" would erroneously print
749660476, instead of 1057070285.
The macros PUTD() and PUTDF() have been replaced by snprintf() calls; These macros
should never have been written in the first place, when system functions exist to do the
work.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 14:36:04 2003 +0000
[bug #4297] The strlen mh-format function can crash if 'str' is null.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 14:30:36 2003 +0000
note recent changes
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 30 14:19:20 2003 +0000
fix handling of "-list" and "-seq" options, so behavior is orthoganal.
Previously, "pick -list -seq seqname" meant "pick -nolist -seq seqname".
Now "pick -list -seq seqname" and "pick -seq seqname -list" do the same thing.
Thanks to Robert Elz.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Sep 28 14:27:34 2003 +0000
update 'mp->lowmsg' from 0 to 1 during regular 'inc' from mail spool;
avoids failure of 'folder_realloc()' for case of no messages in
folder, and more than 100 messages to incorporate. Initially,
'folder_read()' will initialize 'mp->lowmsg' to 0, and 'mp->lowoff'
to 1. So the call would be folder_realloc(mp, 1, 200), and the
comparison 'if (mp->nummsg > 0 && lo > mp->lowmsg)' will fail.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Sep 22 16:03:22 2003 +0000
Removed space between command name and man section number (e.g.,
"show (1)" --> "show(1)", so xemacs can recognize them as links to other
man pages.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Sep 22 01:04:04 2003 +0000
make 'spost' handling of "masquerade:" line of mts.conf containing
'draft_from' same as for 'post'. Debian bug report 144098, filed by
Terran Melconian.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Sep 22 00:43:09 2003 +0000
status of action wasn't saved for use by 'N' result, so when 'N' was
used slocal could perform the action even if the previous
action failed. Debian bug report #149745, filed by Daniel Müller.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Sep 21 18:08:35 2003 +0000
Increase timeouts to comply with RFC 1123; Debian bug report #152728 by Ian Jackson
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Sep 21 17:34:31 2003 +0000
added cross references
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Sep 21 17:09:31 2003 +0000
fixed typo: example for scan.default didn't include proper terminating
%> for "%<{date} %|*%>"; reported as Debian bug #143427 by Peter Maydell
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Sep 21 15:43:00 2003 +0000
Apply bug fix reported to Debian (#136976) by Peter Maydell; allows
messages with "Content-Transfer-Encoding: binary" to be
displayed, per RFC 2045 section 6.2 paragraph 4
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Sep 21 02:39:58 2003 +0000
corrected typo for nroff directive
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Tue Sep 16 14:27:55 2003 +0000
add command to remove $(libdir)/install-mh prior to creating the link
Author: Jeffrey C Honig <jch@honig.net>
Date: Sun Sep 14 13:25:55 2003 +0000
The first ``inc'' into an empty folder would not update the unseen
sequence. This is because seq_list() will return NULL if mp->nummsg
is zero. Insure that mp->nummsg is incremented.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Sep 8 18:41:10 2003 +0000
Man page fix from Igor Sobrado
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sat Sep 6 17:27:55 2003 +0000
Added documentation of "Dcc", per recent discussion on mailing list
(main contributors Jerry Peek and Robert Elz)
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 5 21:07:49 2003 +0000
Merge in changes from the 1.1 branch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 5 19:10:21 2003 +0000
Fix from branch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 5 18:37:47 2003 +0000
Quiet lock warning.
Author: Ken Hornstein <kenh@pobox.com>
Date: Fri Sep 5 18:36:36 2003 +0000
Merge in locking fixes into the main line.
Author: Jeffrey C Honig <jch@honig.net>
Date: Mon Aug 11 01:20:52 2003 +0000
When compiling format strings, nmh attempts to avoid multiple parsing
of address and date fields by only inserting calls to the parse
functions (FT_PARSEADDR and FT_PARSEDATE) for a given component once.
The problem with this method is that the initial invocation may
actually be on a code path that is conditionally executed. This can
result cached copies of data from the fields in previous messages to
be used.
My solution is to move this optimization from compile time to run time.
Address and Date parsing calls (FT_PARSEADDR and FT_PARSEDATE) will
always be included. Run time flags are used to prevent these functions
from being run more than once per component per message.
The c_flags field has being converted from a boolean to a bit-field to
facilitate maintenance of the new CT_PARSED value. The result value
that used to be in this field is now the bit CF_TRUE and the
overloaded use of this field by scan() is now the CT_DATEFAB bit.
Some unneeded flags (CT_ADDRPARSE, CT_MYMBOX) have also been removed.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Fri Jul 4 16:15:02 2003 +0000
more detail for bugs fixed, so reader doesn't need to go to Bugzilla
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Fri Jul 4 15:55:55 2003 +0000
update
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Wed Jul 2 02:24:19 2003 +0000
restored use of %manext5% for man section, which was lost
in version 1.4
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Wed Jul 2 02:03:19 2003 +0000
Updated description of default template to reflect current
change to In-Reply-To, and Fcc:
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Wed Jul 2 02:01:50 2003 +0000
Default templates for 'comp', 'forw', 'dist', 'repl' now include
Fcc: +outbox
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Jun 30 19:43:26 2003 +0000
use symbols for date and version so values are
automatically updated during build.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Jun 30 19:40:05 2003 +0000
bump date so everything gets a new timestamp for 1.1
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Jun 30 18:58:07 2003 +0000
fix bug #1393, "sortm core dumps", using patch provided by
Robert Elz, kre@munnari.oz.au. The core dump occurred
when "Subject:" was immediately followed by an
alphanumeric, and "-textfield subject" were used
as arguments.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Jun 30 16:48:50 2003 +0000
Re-write for clarity, using major contributions from
Bart Massey, and Jerry Peek.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Jun 30 16:40:09 2003 +0000
made RFC 2822 compliant, using an "In-reply-to:" format
supplied by Jerry Peek.
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Fri Jun 27 17:02:13 2003 +0000
prevent double free of 'ce->cd_file' or later use of invalid data
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Thu Jun 26 01:30:36 2003 +0000
fix for bug #578 repl leaks umask; there are several other
places in the code where the umask value is not restored,
so there might be other similar bugs
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Mon Jun 23 00:44:28 2003 +0000
Changed use of GNU "simply expanded variables" for MAN1, MAN5, MAN8, so
one makefile will work with SysV make (e.g., Solaris) and GNU make
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Jun 22 23:59:16 2003 +0000
allow gdbm/ndbm.h in addition to db1/ndbm.h; needs corresponding change in
configure.in
Author: Glenn Burkhardt <glenn@aoi.ultranet.com>
Date: Sun Jun 22 23:58:07 2003 +0000
Allowed gdbm as substitute for Berkeley db1/ndbm.h libdb1 (check for
gdbm/ndbm.h, libgdbm now); send only stdout to /dev/null when checking for
'broken vi', this allows 'vim' on Solaris to work, since 'vim' closes stdin
and uses stderr for input when running a script.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Thu Jan 2 04:07:49 2003 +0000
Fix detection of non-mime messages when the charset is not enclosed
in double quotes. (Not perfect yet, but 97% effective.)
Author: Jon Steinhart <jon@fourwinds.com>
Date: Thu Nov 21 21:22:24 2002 +0000
Fixed a typo in the SRCS definition; had a .o where it should have been a .c
Author: Jon Steinhart <jon@fourwinds.com>
Date: Wed Nov 20 19:57:19 2002 +0000
Fixed a bug in the waitpid version where it would return incorrectly if a
child process was interrupted.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Nov 19 20:39:21 2002 +0000
Removed the reference to the library directory since this now goes in bin.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Tue Nov 19 20:37:50 2002 +0000
Changed to move install-mh to the bin directory instead of the lib
directory. A link is made from the lib to the bin just in case.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Mon Nov 18 18:25:00 2002 +0000
The file README-ATTACHMENTS was removed - it has been moved to the docs
subdirectory. I thought that this had already been done but I guess not.
It's unrelated to the rest of these changes.
The remainder of these changes affect the way that nmh is installed. Nmh
has historically prompted the user for installation when any nmh command
is invoked if it doesn't think that it's installed. This is a problem for
programs that want to, for example, interact with nmh programs via pipes.
These changes alter this behavior. Now, when an nmh program thinks that
nmh isn't installed, it tells the user to run install-mh to install it.
A -check option has been added to install-mh that allows the existence of
an installation to be silently checked and indicated via the exit status.
The bulk of this change is in sbr/read_context.c. In the process of making
these changes, I noticed a fair amount of useless code that I removed. In
particular:
1. The program started with a test for whether or not defpath had already
been set. This could only happen if context_read() was called more
than once, which it isn't. This check also existed and was removed
from the following places:
sbr/context_del.c
sbr/context_find.c
sbr/context_replace.c
sbr/seq_read.c
sbr/seq_save.c
uip/flist.c
uip/folder.c
uip/rmf.c
2. A similar test for mypath was removed. No need to test it since it
doesn't happen. I'm just not a believer that
a = 1;
if (a != 1)
error();
is a good way to write code!
3. I removed the code makes a copy of the $HOME environment variable as
returned by getenv(). It's never changed, so it doesn't need copying.
4. I removed code that copied the pw_dir member of the passwd structure
returned by getpwuid() if $HOME isn't set. Yes, the returned structure
is static, but since the function is never called again the returned
values stay valid and don't need copying.
5. I removed the test for a NULL pw_dir member in the passwd structure
returned by getpwuid() since that never happens.
6. I removed code that removed a trailing / from mypath if mypath is more
than one character long. Unnecessary as // is interpreted as / anyway.
mypath never shows up in an error message, so nobody will ever see it.
Besides, this code didn't handle the case of multiple trailing slashes.
7. I removed code that replaced the MH environment variable contents with
an absolute path if it was a relative one. I'm a bit nervous about this
one, only testing will tell. Any nmh program that's invoked will use
the same context_read() code to convert a relative path to an absolute
one anyway. And there's no guarantee (or discussion) of this feature
in any of the documentation.
8. Althout context_read() tested the MH environment variable, install-mh
didn't. This means that the behavior was not consistent between
install-mh and all other nmh programs. I changed install-mh to be
consistent with context_read().
9. install-mh has been installed in the lib directory, not bin. So a
user would be unlikely to find it when prompted to run it. The
installation has been changed to add a link from bin to lib.
Author: Anders Eriksson <aeriksson@fastmail.fm>
Date: Mon Oct 21 19:32:26 2002 +0000
Changed scan to always pass the folder argument. This is in line
with the man page.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Mon Sep 9 14:30:16 2002 +0000
New routine that provides interface to external programs.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Fri Aug 23 20:37:01 2002 +0000
Added external program hooks.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Thu Aug 22 22:06:18 2002 +0000
Moved this file here from the root directory.
Author: Jon Steinhart <jon@fourwinds.com>
Date: Mon Aug 19 20:50:41 2002 +0000
Added an improved user interface for sending messages with attachments.
Author: Ken Hornstein <kenh@pobox.com>
Date: Mon Jul 8 19:29:24 2002 +0000
Remove this file on the head as well.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jul 3 14:49:24 2002 +0000
Bring these changes over from the branch.
Author: Ken Hornstein <kenh@pobox.com>
Date: Wed Jul 3 14:08:11 2002 +0000
Remove these undefines (why were they in there?)
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jul 2 22:10:55 2002 +0000
Update for new version.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jul 2 22:09:12 2002 +0000
Add/update copyright notice in all source code files.
Author: Ken Hornstein <kenh@pobox.com>
Date: Tue Jul 2 21:46:37 2002 +0000
Remove autoconf-generated files (and note such files in .cvsignore)
Author: Dan Harkless <dan@harkless.org>
Date: Sat Mar 17 11:28:27 2001 +0000
Ken Hornstein's configure.in Cyrus SASL checks were doing
`x"$with_cyrus_sasl" != "no"' instead of `... != x"no"'.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Mar 7 05:26:50 2001 +0000
Found some historical information about MH in RFC 808. Supplemented it with
info from Jerry Peek's MH book and added it to docs/README.about.
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Feb 6 20:47:54 2001 +0000
dtimp timezone fixes
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Feb 6 20:35:40 2001 +0000
Be more picky about symbolic time zones, and accept either a symbolic
or numeric time zone, but never both, since a DST offset might be subtracted
twice. Also, be uniform about assuming that pre-1970 dates are Y2K problems.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Feb 6 04:28:04 2001 +0000
Say in README.developers to use `\date' in case anyone is like me and
has `date' aliased in their shell to use a nonstandard (but
subjectively more readable) format.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Feb 6 04:22:09 2001 +0000
Regenerated stamp-h.in using my tcsh alias `date', which uses a
nonstandard format. Replacing it with the standard format. I'll
update README.developers to say to use `\date'.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Feb 6 03:46:27 2001 +0000
* -L isn't sufficient for specifying the path of the Cyrus SASL
shared library. That'll allow us to link successfully, but on
many/most OSes that won't allow us to find libsasl at runtime. On
Solaris, we need to specify the library path with -R as well (or
else the user will have to use the $LD_LIBRARY_PATH kludge, which
is considered harmful). This fix should be extended to other OSes
as well.
* Print whether we have SASL support in the "nmh configuration"
summary configure prints out.
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Jan 25 21:28:30 2001 +0000
man/mh-chart
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Jan 25 21:15:52 2001 +0000
use %etcdir% for spacing instead of hardcoding
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Jan 25 21:14:32 2001 +0000
compiled mh-chart with synopses of commands
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 23 20:27:57 2001 +0000
digest
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 23 20:26:15 2001 +0000
Don't try to force year into a 19xx format
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 23 04:14:08 2001 +0000
SYNOPSIS formating to prevent filling
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Jan 19 21:32:13 2001 +0000
manpages finished
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Jan 19 21:22:08 2001 +0000
don't build vmh.1 since vmh isn't distributed, and we no longer need tmac.h
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Jan 19 21:10:09 2001 +0000
show-whom
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Jan 18 20:27:34 2001 +0000
prompter-sendfiles
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:55:21 2001 +0000
delete old files, manpage progress
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:45:26 2001 +0000
removed deprecated files. sendmail functionality exists in mts/smtp/
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:41:44 2001 +0000
Add an entry for README.manpages
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:40:12 2001 +0000
Added popi.c to SRCS, even though it's not being built currently
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:13:55 2001 +0000
removing mts/generic
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:10:03 2001 +0000
deleting zotnet/ dir -- parts moved to sbr/
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 9 06:01:19 2001 +0000
mh_profile-prev
Author: Shantonu Sen <ssen@mit.edu>
Date: Sat Jan 6 23:38:12 2001 +0000
mh_tailor-mhbuild
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Jan 4 07:07:41 2001 +0000
Updating mh_sequence
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed Jan 3 06:29:06 2001 +0000
mh_mail-mh_profile
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 2 08:10:46 2001 +0000
mh-format
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 2 07:12:46 2001 +0000
Modularizing the Makefile caused some variable expansion problems on non-GNU makes
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue Jan 2 06:43:07 2001 +0000
mh_chart-mh_draft
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Jan 1 10:19:00 2001 +0000
Updating ali-mh_alias
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 20:58:29 2000 +0000
add about pointers to shared pages
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 20:55:48 2000 +0000
Add date to files i missed last time
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 20:55:06 2000 +0000
docs/README.manpages
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 20:48:50 2000 +0000
Add manpage style guide
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 09:25:09 2000 +0000
Updating inc
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 08:19:20 2000 +0000
Updating comp-forw
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 06:31:42 2000 +0000
add flists and folders as pointer pages to flist,folder. Modularize Makefile to allow easier addition of manpages
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 02:44:18 2000 +0000
replace %components% and %distcomps% in man pages with corresponding files
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 31 02:43:34 2000 +0000
updated ali-flist, with batch edit of others
Author: Shantonu Sen <ssen@mit.edu>
Date: Sat Dec 30 23:18:28 2000 +0000
update ali,anno,ap.burst
Author: Shantonu Sen <ssen@mit.edu>
Date: Sat Dec 30 10:01:29 2000 +0000
Updated man pages to remove dependence on tmac.h and have a more modern look
Author: Shantonu Sen <ssen@mit.edu>
Date: Sat Dec 30 10:00:42 2000 +0000
DATE an manpage updating
Author: Shantonu Sen <ssen@mit.edu>
Date: Sat Dec 30 09:51:55 2000 +0000
Use the DATE file
Author: Shantonu Sen <ssen@mit.edu>
Date: Sat Dec 30 09:50:13 2000 +0000
Created DATE that contains a datestamp used in the man pages. It should be updated each release.
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 24 10:13:45 2000 +0000
hesiod and krb5 test changes. add --with-locking to INSTALL
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 24 10:06:30 2000 +0000
Add documentation for --with-locking option
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 24 10:06:00 2000 +0000
hesiod and krb5 test fixes
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 24 10:04:58 2000 +0000
Fixed up the hesiod library test so that the location of res_send
actually helps to determine whether -lresolv needs to be passed
as a hesiod lib. Also, fixed the krb5 test to look for
-lk5crypto if it exists, since that's the new name for -lcrypto.
The old -lcrypto remains in case the new version isn't found.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Dec 23 06:11:03 2000 +0000
-apop and -noapop were not documented in msgchk.man. -snoop was documented but
didn't appear in the usage SYNOPSIS.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 23:49:08 2000 +0000
add --with-locking option
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 23:42:16 2000 +0000
Autoconfing the file locking options
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 19:30:41 2000 +0000
put both linux entries on one line
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 19:29:40 2000 +0000
dtimep, MACHINES
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 19:21:29 2000 +0000
Update to include Mac OS X and Linux 2.4
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 19:18:09 2000 +0000
When building on Mac OS X, don't set LDFLAGS=-s, since the linker doesn't like the flag
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Dec 22 19:15:02 2000 +0000
Take out memory hints, since we are assuming flex over lex, so this shouldn't be a problem
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed Dec 20 16:03:36 2000 +0000
doc/README.developers update, and fixed typo in last ChangeLog entry
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed Dec 20 16:00:46 2000 +0000
Marked deprecated directories in layout description, and added an entry for docs
Author: Dan Harkless <dan@harkless.org>
Date: Wed Dec 20 03:30:14 2000 +0000
Just changed a "can" to a "could" since I don't know if most POP3 servers are
like qpopper in not allowing people with APOP activated to log in via normal
POP3.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Dec 20 03:18:33 2000 +0000
-apop and -noapop were not documented in inc.man. -snoop was documented but
didn't appear in the usage SYNOPSIS.
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Dec 17 19:52:04 2000 +0000
Fixed a type from 'his' to 'this'
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Dec 14 14:55:17 2000 +0000
config.guess/sub update
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Dec 14 14:35:40 2000 +0000
config update procedure (probably unneccessary)
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Dec 14 14:32:09 2000 +0000
Updated config.guess and config.sub from most recent version
from ftp.gnu.org/pub/gnu/config, with timestamp='2000-12-07'.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Dec 14 03:14:08 2000 +0000
Shantonu did his commit in the wrong order earlier today, making configure get
re-built due to a "newer" configure.in.
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Dec 14 01:38:41 2000 +0000
Move mts/generic to sbr/
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Dec 14 01:30:43 2000 +0000
Resolve the circular dependency of libmh on libmts on libmh. The
files mts/generic/client.c and mts.c are moved to sbr/, and mts/generic/mts.h
is moved to h/mts.h. Thus, libmh is self-contained. All header includes
have been appropriately updated, and the Makefiles and configure script
no longer build mts/generic.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Dec 12 06:19:25 2000 +0000
When Shantonu made the new libmts.a, he swapped $(MTSLIB) and libmh.a in
sbr/Makefile.in so that libmh.a comes first, but this causes the build to fail
on Solaris, because libmts.a has to get ruserpass() out of libmh.a. Swapping
them back to the way Ken Hornstein's patch (which I applied on Jul 20) put them,
with libmh.a correctly coming second. If there are times when libmts.a needs to
come second, then it would appear there's a circular dependency and someone
(Shantonu?) did an mts merge incorrectly.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Sep 8 23:19:37 2000 +0000
Just fixed a formatting error.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 01:39:10 2000 +0000
Took out bad zones in dtimep
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 01:36:23 2000 +0000
Took out incorrect time zones like JST and BST.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:49:32 2000 +0000
Included code reorg of zotnet/mts
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:37:54 2000 +0000
Don't make Makefiles in zotnet or mts/mmdf or mts/sendmail
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:36:48 2000 +0000
Don't generate Makefiles for zotnet, or mts/mmdf and mts/sendmail,
since they are no longer being compiled.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:34:41 2000 +0000
Included h/nmh.h, since the MD5 algorithms were missing declarations
for memcpy and memset (I think), which are indirectly included from
strings.h
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:34:08 2000 +0000
Updated #include's to point to new location of mts.h on mts/generic
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:32:47 2000 +0000
No longer descend into zotnet/
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri Sep 8 00:30:58 2000 +0000
Moved code from zotnet/mts to mts/generic. Also, unified generic
mts code and smtp/sendmail into libmts.a as an intermediate, instead
of having two static libs.
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed Sep 6 22:48:43 2000 +0000
Included changes to dtimep.lex to remove military zone parsing.
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed Sep 6 22:40:03 2000 +0000
Took out parsing of military time, which was causing issues when it
encountered something like (MET), which it doesn't recognize as a timezone,
and which was then read as military characters.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Aug 11 20:43:07 2000 +0000
Further clarified Kimmo's etc/Makefile.in comments at his suggestion.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Aug 10 21:32:33 2000 +0000
Changed my mind again on scan.MMDDYY and scan.YYYYMMDD. Put the replied /
encrypted column back in, because it's useful to "always" (at least when you
aren't using replied / encrypted) have a space in between the message number and
date, so you can use awk (with the default field separators) to grab message
numbers from scan output.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Aug 10 20:33:25 2000 +0000
Decided that limiting the message number columns to 3 on my scan.MMDDYY and
scan.YYYYMMDD (to try to regain space taken by extra date info) was
ill-conceived. It's not that tough to get past 999 messages, though I imagine
it's rather rare to exceed 9999. Changed these to 4. I had already removed the
"replied / encrypted" column in YYYYMMDD, but this time I removed it on MMDDYY
as well (I've never seen it used...).
Author: Ruud de Rooij <ruud@ruud.org>
Date: Mon Aug 7 18:42:20 2000 +0000
Modify umask set by mhshow to enable user execute bit, so that viewers that
create temporary directories (e.g., lynx) will be able to access them.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Aug 5 16:00:49 2000 +0000
Kimmo's etc/Makefile.in change note implied that install was previously
completely broken. Not the case. I asked Kimmo about it and he clarified that
it failed when building outside the source tree. Fixed the entry to reflect.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Aug 4 00:15:52 2000 +0000
TODO: Allow multiple simultaneous differing contexts, probably each tied to a
parent (terminal) process.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Tue Aug 1 14:55:53 2000 +0000
Make "make install" work in etc/Makefile.in
Author: Dan Harkless <dan@harkless.org>
Date: Mon Jul 24 23:24:22 2000 +0000
Renamed DSTXXX as ADJUST_NUMERIC_ONLY_TZ_OFFSETS_WRT_DST and added an
explanatory comment by its #definition.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Jul 24 23:06:42 2000 +0000
Updated README.developers with the fact that zotnet/tws is going away.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Jul 24 23:03:38 2000 +0000
When Shantonu wrote the new, more portable dtimep.lex, he left out the #ifdef
DSTXXX stuff for some reason. Not a good idea, as that code is required for
proper printing of numeric-offset timezones that have daylight saving time.
Without that code, -0700 during DST gets printed as MST instead of PDT.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 03:31:39 2000 +0000
Fixed warnings from diff on first-time install of nmh. Also added 'echo's
clarifying the etc file installation activities.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 02:35:43 2000 +0000
Applied Kurt J. Lidl <lidl@eng.us.uu.net>'s $MAILHOST patch:
I have a small patch that would be nice to be included -- basically, it
allows the usage of the "MAILHOST" environment variable, without having to
have HESIOD turned on. I need this functionality for my environment, where
we have identical /usr/local on all my machines (so I cannot just hardcode
into the mts.conf file), and I have multiple POP mail servers for my users.
Modified inc.man to reflect that along with "pophost:" and -host, $MAILHOST can
now activate POP mail inclusion as well.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 02:25:59 2000 +0000
Last pass at README.developers -- Kimmo's 5-step commit was overkill. You only
need 3 steps, since configure.in is the only autoconf file with the RCS $Id
keyword.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 02:11:59 2000 +0000
Meaningless modification to test autoconf file commit order stuff.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 02:04:37 2000 +0000
Meaningless change to test autoconf file commit order stuff.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 02:03:23 2000 +0000
Meaningless change for testing autoconf file commit order stuff.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 01:56:17 2000 +0000
Meaningless change to test autoconf commit order stuff.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 21 01:43:58 2000 +0000
People did not preserve my alphabetization of the --with options when they added
new ones. Re-alphabetized.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jul 20 20:49:00 2000 +0000
Ken Hornstein's SASL patch was not integrated properly with Ruud's new merged
mts/sendmail code. Kimmo has since fixed nmh so it compiles, but according to
Ken, the SASL stuff still does not work. Integrating a patch from him for this.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jul 20 20:32:31 2000 +0000
One more pass at README.developers now that it's clear that my
previously-suggested one-line autoconf-file commit can cause unnecessary local
makes and an out-of-sync stamp-h.in file, but would not cause problems for other
people using the CVS files.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jul 20 20:14:39 2000 +0000
Moved Kimmo's new "--with-hash-backup" to be output with the rest of the --with
options in the configure --help output, rather than being in between two random
--enable options.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Tue Jul 18 23:39:45 2000 +0000
Added answer.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jul 18 02:15:03 2000 +0000
Clarified and made some corrections to Kimmo's README.developers changes (BTW,
if anyone can explain why the RCS Ids are able to cause problems with the
dependencies, please fill in the explanation -- I never encountered a problem
with the old single-commit method).
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jul 18 02:07:51 2000 +0000
I don't understand why Kim's split-up of the autoconf-file cvs commits should be
necessary, so I left a little note hoping for someone to explain technically why
that should be the case. I certainly never ran into any problems with my old
single-commit version (which I added back in along with an explanation of why it
supposedly won't always work).
Also Kim's text implied that the _only_ reason for the given order is the RCS
Ids -- not true -- the timestamps are the main reason a particular order is
necessary. Made a couple of other clarifications as well.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 06:18:03 2000 +0000
Iterating the commit a bit, I think this is how it works without extra
runs of autoconf, autoheader and make.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 06:05:26 2000 +0000
Regen.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 06:01:28 2000 +0000
If $LIBTOOL is empty we should not try to run it.
This gets rid of the "--version: not found" error.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 05:50:33 2000 +0000
Got rid of one mktemp.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 05:11:46 2000 +0000
Complete HAVE_MKSTEMP.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 04:23:50 2000 +0000
We ignore the fact that the user requested SASL, since the pipe to the
mailer is secure. This allows for easier sharing of the MH profile
across hosts.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 04:03:27 2000 +0000
Note replacement of GNU-makeism in sbr/Makefile.in with a common statement.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 03:58:57 2000 +0000
So I don't think you can commit these all in a single commit.
README.developers recommends that (with precise ordering) but
things still get regenerated when I run "make".
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 03:57:47 2000 +0000
Keep this working with other makes than GNU.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 03:56:45 2000 +0000
Still missed one SASL stuff thing.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 03:36:42 2000 +0000
Changed "--with-backup-prefix" to "--with-hash-backup" because # is too
difficult for config.status to get right.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 03:15:17 2000 +0000
Note "--with-backup-prefix".
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 03:13:25 2000 +0000
Add "--with-backup-prefix" so it can be set easily.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 02:08:18 2000 +0000
SASL stuff.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 01:48:37 2000 +0000
SASL stuff.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sun Jul 16 01:46:50 2000 +0000
SASL mods.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jul 13 21:49:45 2000 +0000
Deleted the timezone on Kim's SASL patch entry. Ruud has taken to adding the
timezone even though all previous entries are missing it, and I don't really
agree with that. True, on occasion someone in a different timezone will
commit something later in the day than someone else, and even though the second
change happens later, the time may be earlier, but that doesn't happen too often
and isn't really a big deal, IMHO.
Putting textual timezones like "EDT" isn't really the right solution, IMHO,
since some of those tags are ambiguous. Either an offset-style timezone should
be used or all times should be given as UTC.
I'd just as soon stick with local times, though.
Oh, one thing I forgot to mention in my last CVS entry was that I removed "IMAP"
from the list of protocols supported by Ken's SASL patches -- nmh doesn't have
any IMAP support!
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jul 13 21:42:52 2000 +0000
Modified Kimmo's entry for the application of Ken Hornstein's SASL patches to
clarify that it wasn't Ken applying them himself, and clarified what SASL
support actually means.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jul 13 21:41:42 2000 +0000
Kimmo neglected to commit the regenerated versions of these after changing
configure.in, forcing people using the CVS source to have to have the autoconf
tools installed.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jul 11 21:20:04 2000 +0000
Clarified post.man and send.man for those not completely up on SASL terminology.
"SASL encryption layers are not supported for SMTP" means that encryption is
supported for the authentication but not for the subsequent data stream.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Sat Jul 8 05:36:58 2000 +0000
Note SASL commit.
Author: Kimmo Suominen <kimmo@suominen.com>
Date: Fri Jul 7 03:48:02 2000 +0000
SASL support from Ken Hornstein <kenh@cmf.nrl.navy.mil>.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Mon Jun 12 18:07:34 2000 +0000
* Merged mts/sendmail functionality into mts/smtp; switching between
smtp and sendmail delivery method is now controlled by mts.conf.
* If tsort cannot deal with loops, in addition to defining tsort as
cat, also define lorder as echo.
* Removed uip/popi.c from list of sources.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jun 9 02:45:17 2000 +0000
New dtimep.lex didn't parse day names properly. Fixed. Also clarified
ambiguous comments preceding day_map[] array (from old dtimep.lex) that probably
led to the erroneous cp++ being added.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Wed Jun 7 19:06:52 2000 +0000
* Added one more mkstemp invocation to uip/spost.c (which was in a
#if 0 block).
* Applied patch from Peter Maydell to clean up permissions handling
and error handling in uip/inc.c.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Mon Jun 5 20:13:54 2000 +0000
Use cat instead of tsort if tsort cannot deal with loops in its
input (which is the case for tsort from GNU textutils).
Author: Ruud de Rooij <ruud@ruud.org>
Date: Mon Jun 5 19:20:38 2000 +0000
If liblockfile is present, and its dotlockfile program is setgid,
inc does not need to be setgid.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun Jun 4 20:24:39 2000 +0000
* Added autoconf test for Miquel van Smoorenburg's liblockfile
library, as found on Debian systems.
* Added liblockfile support to sbr/lock_file.c.
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu Jun 1 06:57:57 2000 +0000
make clean now removes generated bin files.
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed May 31 07:22:43 2000 +0000
Made dtimep.lex more lex-friendly.
Author: Shantonu Sen <ssen@mit.edu>
Date: Wed May 31 07:19:30 2000 +0000
Added back memory options for AIX to increase available memory.
Took out %option noyywrap, which wasn't understood by AT&T lex, as
well as the -i case-insensitivity flag.
Author: Doug Morris <doug@mhost.com>
Date: Wed May 31 05:48:06 2000 +0000
added lint targets for Makefiles and a configure test to find whether lclint or lint is installed on the system.
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 31 02:27:40 2000 +0000
Applied Alec Wolman <wolman@cs.washington.edu>'s dropsbr.c patch:
In the map_write routine, a call is made to map_open and this call is supposed
to set the "clear" variable to 0 or 1, depending on whether the map file is
empty or not. In mh6.8.3, this worked because map_open would set "clear" by
calling the mbx_Xopen routine. In nmh, the code for mbx_Xopen was merged into
mbx_open, but the interface for mbx_open doesn't support the clear variable,
so that functionality was lost. The map_open interface still contains "int
*clear" in the prototype, but never sets it.
My patch eliminates "clear" from the map_open interface (I checked to make
sure that map_write is the only client of map_open). Furthermore, my patch
also sets the "clear" variable properly at the beginning of map_write by
calling fstat(). This eliminates the bug in that the value of "clear" being
used later in the routine was just stack garbage.
Having a bad value of clear causes this next bug to be triggered: The fp file
pointer was being opened with fdopen, but in two of the three switch cases it
wasn't being closed. In certain cases, this was causing packf to run out of
file descriptors if you attempted to pack a large folder.
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 31 02:13:57 2000 +0000
A couple more tweaks to etc/Makefile.in:
Generated sendfiles script was not a dependency of the `all' target, and was
incorrectly included in the distribution.
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 31 00:53:20 2000 +0000
INSTALL never documented the etc/*.old thing. Documented the new etc/*.prev
thing (including a note to watch for diff output).
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 31 00:28:14 2000 +0000
Reworded my last entry a bit.
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 31 00:22:05 2000 +0000
etc/Makefile.in was incorrectly installing mts.conf.in and sendfiles.in --
fixed. Changed the suffix for the backed-up previous versions of the etc files
from the ambiguous .old to .prev. Use diff and only keep the .prev file around
if different.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 30 22:52:43 2000 +0000
ChangeLog: I think we should use a uniform style in this file. Reformatted
Ruud's recent entries.
configure: Weird. There's some timestamp screwup somewhere, perhaps in the way
Makefile.in is written, that caused autoconf to get run after I did
a `cvs update'. It regenerated configure, and apparently I'm using
a different version of autoconf, with a different order of awk
alternatives.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon May 29 08:00:33 2000 +0000
Added entry for new lexing function and moving from zotnet/tws to sbr
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon May 29 07:48:14 2000 +0000
Updating root-level files so that zotnet/tws/Makefile is not generated.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon May 29 07:44:51 2000 +0000
Synchronizing Makefiles that had gotten out of sync with directory
contents.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon May 29 07:43:29 2000 +0000
Updated sbr functions to include <h/tws.h> instead of <zotnet/tws/tws.h>.
Also, update Makefile to include new functions dtime.c and dtimep.c
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon May 29 07:35:32 2000 +0000
Updating user programs to use <h/tws> instead of <zotnet/tws/tws.h>
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon May 29 07:29:08 2000 +0000
Moved date/time functions from zotnet/tws to sbr. More importantly,
wrote a new lexing function dparsetime (dtimep.lex) which
plays nicely with flex, needs no "sed hackery". It might work with
lex, but I haven't tried.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun May 28 16:17:49 2000 +0000
* Added autoconf check for getutent().
* Changed uip/rcvtty.c and uip/slocal.c to use getutent() and
friends. Since I can only check on Linux, please check if
this works on other systems.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun May 28 16:15:58 2000 +0000
Added autoconf check for getutent().
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun May 28 14:42:01 2000 +0000
* Applied patch from Peter Maydell to uip/scansbr.c for more
checks for write failures.
* Unlink temporary file properly in uip/rcvtty.c.
* Moved viamail from bindir to libdir.
* Changed sendfiles into sendfiles.in, so that path to viamail
is patched in.
* Added gzip support to sendfiles.
* Added References header to replcomps and replgroupcomps.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun May 28 12:45:53 2000 +0000
Fixed m_getfld bug which caused segmentation faults when
incorporating messages which ended in multiple linefeeds crossing
a buffer boundary.
Author: Dan Harkless <dan@harkless.org>
Date: Fri May 26 20:35:30 2000 +0000
msh has been unable to show MIME messages ever since 1.0. Alec Wolman
<wolman@cs.washington.edu> tracked down the problem to the -show flag being
passed to mhshow. mhshow is equivalent to the old mhn -show, so we don't need
the -show anymore. Removed it.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri May 12 05:19:14 2000 +0000
Moved zotnet/mf to sbr.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri May 12 04:16:46 2000 +0000
zotnet/bboards no longer built by default.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri May 12 02:55:36 2000 +0000
zotnet/bboards is no longer built by default.
Author: Shantonu Sen <ssen@mit.edu>
Date: Fri May 12 02:51:21 2000 +0000
Removed zotnet/bboards from default build.
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu May 11 02:55:11 2000 +0000
Change to MACHINES to include what platforms nmh *does* compile on.
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu May 11 02:53:07 2000 +0000
Added on whish platforms nmh is known to compile, as polled from
recent mailings to nmh-workers. Please add liberally.
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu May 11 02:24:59 2000 +0000
Entered minor change to sbr/Makefile.in
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu May 11 02:21:34 2000 +0000
Removed explicit definition of both SRCS *and* OBJS, and made OBJS simple
a pattern substitution of SRCS, with suffix .c -> .o
Author: Shantonu Sen <ssen@mit.edu>
Date: Thu May 11 02:14:21 2000 +0000
Added my getpass() addition to ChangeLog (after the fact, but at least
it's in now).
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 10 03:39:46 2000 +0000
Added mts.conf.5 page per Neil W Rickert <rickert+nmh@cs.niu.edu>'s report:
This happens on solaris:
% man mts.conf
windex entry incorrect: mts.conf(5) not found.
No manual entry for mts.conf.
It is fixed by
% echo ".so man5/mh-tailor.5" > mts.conf.5
done in the man5 directory. We need to add 'mts.conf.5' as a reference
sourcing mh-tailor.5.
Author: Dan Harkless <dan@harkless.org>
Date: Wed May 10 00:02:53 2000 +0000
Prepended "Portions of this code are" to the copyright message in ruserpass.c
also.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 21:44:15 2000 +0000
* Changed configure.in to use gcc -Wall even without --enable-debug, to prevent
developers compiling optimized from introducing warnings, and to give
end-users a warm, fuzzy feeling as they (hopefully) see no warnings come out
(except perhaps on the lex output file) even with -Wall.
* Renamed getpass() to nmh_getpass() since the prototype for getpass() varies
from OS to OS, and we want to _always_ use our version of the function. Fixed
all the callers to use nmh_getpass() and added it to prototypes.h.
Semi-arbitrarily upped MAX_PASSWORD_LEN from 128 to 256. buf was being
calloc()'d and the memory leaked -- should have just been declared as static
char array. Prepended "Portions of this code are" to the copyright message,
as this version has been changed significantly from the BSD version.
* Added "nmh-local functions to use in preference to OS versions" section to
README.developers (currently just says to use nmh_getpass() instead of system
getpass()).
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 19:56:57 2000 +0000
Oops. Forgot to commit this when I made configure changes yesterday.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 08:16:18 2000 +0000
Added steps to README.developers saying to change the version number to
X.Y.Z+dev. Did a little rearranging and changed the FTP dir from /home/ftp to
/var/ftp to reflect Doug's new machine.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 07:55:58 2000 +0000
Got rid of four warnings in Shantonu's new getpass.c. Needed to #include
<stdlib.h> for calloc(), <unistd.h> for ttyname(), and "h/mh.h" for adios().
Also changed ch from char to int to get rid of "comparison is always 1 due to
limited range of data type" on EOF.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 07:13:59 2000 +0000
Alphabetized Shantonu's $pop_kinds output on configure's "pop is enabled" line.
If POP3 is the only kind of POP enabled, say so, rather than just saying "yes"
(which is ambiguous).
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 06:53:21 2000 +0000
Shantonu updated the DIFFERENCES file to no longer say that APOP isn't
supported, but in so doing, he removed the note that RPOP isn't supported. Put
it back.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 06:47:50 2000 +0000
* I had alphabetized the --configure options in the --help output
awhile back, but Shantonu added --enable-apop just under --enable-pop. Put it
in alphabetical order and clarified what --enable-apop does vs. --enable-pop and
--with-krb4. Also changed --with-mts help line from "mail transport agent" to
"mail transport agent/service" so the 's' in "mts" doesn't seem to come out of
nowhere.
* Added two steps to "releasing nmh" in README.developers. After
making the tarball, it's a good idea to diff the tree vs. the CVS tree to make
sure no files got left out, and then to chown the files so that they're owned by
root, preventing a Trojaning attack by a malicious remote user with a UID
matching yours.
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue May 9 06:27:38 2000 +0000
Updated POP capability to include APOP.
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue May 9 06:16:52 2000 +0000
Removed unnecessary comments, such as "*This warning no longer applies*"
Author: Shantonu Sen <ssen@mit.edu>
Date: Tue May 9 06:09:05 2000 +0000
Fix some compile-time warnings.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 04:52:55 2000 +0000
Doug informed me that the way I had restored the "lost" version histories was
wrong, because `cvs checkout's of old versions of nmh wouldn't work properly.
It occurs to me that this could be fixed by simply deleting those tags in the
new-location *,v files, but oh well. I'm putting everything back to the way
Doug originally had it. To get the old version history for a file that used to
be in the top directory, you'll need to "blindly" do a `cvs log' there (even
though you won't have a local copy of the file in that directory). `cvs diff'
will no longer be able to diff pre-move versions vs. post-move versions --
you'll have to do a lot of manual gyrations with `cvs checkout' and then use
`diff'.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 04:08:55 2000 +0000
Okay, now that the old revisions have been recreated, deleting the file. The
new version is in the 'docs' subdirectory.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 04:07:15 2000 +0000
This is the nmh-1.0.4 version from 2000-03-15 (I see that I was the one that
originally made this change).
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 04:05:46 2000 +0000
This is the nmh-1.0.3 version from 2000-01-18 (1.0.2 had no changes).
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 04:03:55 2000 +0000
This is the nmh-1.0.1 version from 1999-05-17.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 03:58:04 2000 +0000
For reasons explained better elsewhere (e.g. Attic/README.developers), the
version history for this file got lost. Recreating it. This version is from
1998-05-08 -- it's the original nmh-1.0 version.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 03:29:37 2000 +0000
After nmh 1.0.4, moved from top-level 'nmh' directory to 'nmh/docs'.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 03:27:53 2000 +0000
Okay. Removing it now. New location is in 'docs' subdirectory.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 03:25:24 2000 +0000
In the hullaballoo with moving stuff back and forth out of the docs/ directory,
and trying to figure out the right way to preserve the old version history, this
file's version history prior to the first move into docs/ got wiped. I
introduced this file into the project after 1.0.3 was released, and was the only
one to modify it until after the 1.0.4 release. The post-1.0.4 changes have
survived in docs/README.developers, so I just need to check in the 1.0.4 version
and tag it as such, then remove it again, to make a `cvs checkout' of nmh 1.0.4
work again.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 03:18:50 2000 +0000
Man, I'm a retard. Lemme try that again:
Just a silly note 'cause I'm vain -- below where it currently says:
Someone ("ssen" -- looks like Doug forgot to update a chroot() passwd file
It originally said " u i d 6 0 0 0 4 " (or a different number), but minus the
spaces. I guess after Doug added ssen into the chroot() passwd, he did a
search-and-replace for the UID, which changed my comment as well, making it look
like I had no way of determining who ssen was, which is silly. ;^>
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 03:12:59 2000 +0000
Just a silly note 'cause I'm vain --
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 02:43:54 2000 +0000
After nmh 1.0.4, moved from top-level 'nmh' directory to 'nmh/docs'.
Author: Dan Harkless <dan@harkless.org>
Date: Tue May 9 02:36:42 2000 +0000
After nmh 1.0.4, moved from top-level 'nmh' directory to 'nmh/docs'.
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun May 7 06:59:15 2000 +0000
Updated pop instructions and indicated use of standard "./configure"
instead of "sh configure"
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun May 7 06:16:43 2000 +0000
An nmh-specific getpass, to remove dependency on system
getpass()es, which may or may not do what we want (including
flushing input streams, and taking input from stdin in the
absence of a controlling tty).
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun May 7 06:14:31 2000 +0000
Added getpass to SRCS and OBJS.
Author: Dan Harkless <dan@harkless.org>
Date: Sat May 6 15:53:40 2000 +0000
Removed "installing nmh" section. Moved its note about the DIFFERENCES file up
next to the other MH discussion. Changed out-of-date "README" title (should
have been "README.history") to "README.about -- about nmh". After committing,
I'll rename the file to README.about inside the CVSROOT.
Author: Dan Harkless <dan@harkless.org>
Date: Sat May 6 15:29:19 2000 +0000
Restored lost version histories for those moved files by doing a manual `mv' in
the CVSROOT on mhost. CVS badly needs a `cvs mv' command so that you can move
files (without having physical access to the CVSROOT) without losing versioning.
Put MACHINES back at the top level as it needs to be read before building.
Fixed DIST variable in {.,docs}/Makefile.in to reflect that and to add missing
entry for "INSTALL" file.
Author: Dan Harkless <dan@harkless.org>
Date: Sat May 6 15:05:02 2000 +0000
Fixed DIST targets to reflect that INSTALL and MACHINES are back at the top
level.
Author: Dan Harkless <dan@harkless.org>
Date: Sat May 6 14:54:25 2000 +0000
Files that must be read before building nmh should not go in the docs
directory. Moved this file back to the top level (and made a couple of
stylistic and grammar tweaks while I was at it).
Author: Dan Harkless <dan@harkless.org>
Date: Sat May 6 14:19:23 2000 +0000
Deleting the versions Doug moved in with `cvs add', erasing the version history,
in preparation for moving the original versions in the cvsroot.
Author: Doug Morris <doug@mhost.com>
Date: Sat May 6 11:34:02 2000 +0000
reorganized documentation to make it bit neater again
Author: uid1005 <uid1005>
Date: Fri Apr 21 17:36:37 2000 +0000
Corrected status printout when kpop is enabled
Author: Dan Harkless <dan@harkless.org>
Date: Tue Apr 18 00:17:50 2000 +0000
One final tweak to the configure --help output for --enable-masquerade.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 22:49:39 2000 +0000
APOP supprt: Added info to ChangLog.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 22:09:00 2000 +0000
The syntax I gave in the --help output for --enable-masquerade incorrectly
implied that the earlier options were prerequisites for the later options
(pointed out by Scott Blachowicz). No compact, non-confusing way to specify the
real syntax that I can see, so I'll just remove the []s and leave the explaining
about it being okay to specify a subset to the INSTALL file.
Also added a TODO item to put in proper parsing of the masquerade: line and/or
--enable-masquerade so if you misspell an option you find out about it, rather
than just having it silently fail (this weakness was currently only documented
in comments in the mts.conf-handling code).
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 22:04:33 2000 +0000
Someone (unfortunately original version history has been lost so I don't know
who) changed "danh" to "your-id". That makes my introductory comment "we'll use
version 1.0.4 and my mhost.com account, danh, as examples here" make no sense,
though.
If danh is going to be "parameterized", then 1.0.4 should be too. Doesn't make
sense to parameterize one of the changing items and not the other one. If it's
going to be done, danh should be changed to YOUR-ID or something and 1.0.4 (and
1_0_4) should be changed to X.Y.Z (and X_Y_Z). I just thought it'd be clearer
to use real values and disclaim that fact up front. Anyhow, putting danh back
until such time as someone wants to parameterize both items (and change the
introductory text appropriately).
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 21:25:23 2000 +0000
I had left out aclocal.m4 on the "use this order" line as I didn't think it'd
ever need to be changed. Someone ("ssen" -- looks like Doug forgot to update
a chroot() passwd file again) added it, but in a separate sentence. That
doesn't really make sense -- added it to the main sentence.
Also changed my note that none of the mailing lists require you to be subscribed
to post -- not true. As I originally thought, the exmh ones do require that --
the bounce messages were just slow in coming.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 19:02:11 2000 +0000
Undeleted all the stuff Doug deleted at the top level for now. I think it's bad
to lose the CVS revision history, and I don't agree that all of these files
should go in the docs/ directory. Unfortunately Doug made modifications to FAQ
and README.developers after moving them, and I didn't want to lose his changes,
so I just mv'd the ones in the new directory to the top level. This lost the
old version history for those two files -- I know there wasn't much to lose for
README.developers (I originated the file and was the only one to make
modifications to it until Doug's recent change), but I have no idea what
information was lost in the FAQ's version history. The right thing to do on
those two files probably would have been to re-make Doug's changes in the
undeleted old versions and credit them to him in the CVS log.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 18:48:03 2000 +0000
Put a note saying that the paths this file refers to (stuff in docs/) are
currently wrong.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 18:36:59 2000 +0000
Undeleting everything at the top level for now. Doug's comment:
Sat Apr 15 10:33:00 2000 Doug Morris <doug@mhost.com>
* moved the documentation into a "docs" subdirectory. The
top-level directory was becoming messy. I also created another
file MAILING-LISTS describing the various nmh lists and the
archival system, and updated the FAQ to refer to it. I also
created a new README in the top level that is basically a list
of pointers to the various documentation. The old README I've
moved to docs/README.history, since that seemed like the right
thing to call it.
will be lost, but he can put back a modified version when we agree on what
should really go in docs/.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 18:34:40 2000 +0000
Undeleting everything at the top level for now.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Apr 17 16:56:57 2000 +0000
Added note that user questions are acceptable on nmh-workers.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:29:49 2000 +0000
Added that you should check in aclocal.m4 after acconfig.h, if you change it.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:25:18 2000 +0000
APOP support: Making the apop option appear after pop in ./configure --help
and committing in the right order to avoid unnecessary autoconfing.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:12:14 2000 +0000
Don't try to figure out ruserpass - just use version from sbr/
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:09:46 2000 +0000
APOP support: Use the ruserpass function in this directory for
all password prompts, instead of using system functions.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:08:32 2000 +0000
APOP support: If APOP is enabled, build it into inc and msgchk
using $(APOPLIB).
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:07:03 2000 +0000
APOP support: Making APOP a ./configure option with --enable-apop,
and giving more information about the types of POP support
in the configuration summary.
Author: Shantonu Sen <ssen@mit.edu>
Date: Mon Apr 17 05:04:05 2000 +0000
Adding APOP #defines
Author: Shantonu Sen <ssen@mit.edu>
Date: Sun Apr 16 13:28:12 2000 +0000
Changed some string terminations from NULL to \0.
Author: Doug Morris <doug@mhost.com>
Date: Sat Apr 15 04:28:27 2000 +0000
Moved most of the documentation into a new "docs" subdirectory. Added a MAILING-LISTS file talking about the lists and archives, and updated the FAQ to refer to it.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Apr 15 02:00:43 2000 +0000
Added a "releasing nmh" section to README.developers, while the process was
fresh in my mind.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Apr 14 21:38:37 2000 +0000
Okay, got that tag stuff straightened out. Now upping the version to 1.0.4+dev.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Apr 14 21:26:56 2000 +0000
Oops. Had a duplicate entry.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Apr 14 21:05:34 2000 +0000
Oops. Didn't do a `cvs rtag` before changing the version to 1.0.4+dev. Putting
it back.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Apr 14 20:47:32 2000 +0000
Upped the version number to 1.0.4+dev.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Apr 14 20:40:31 2000 +0000
* Added new files README.developers, ChangeLog_MH-3_to_MH-6.6, and
ChangeLog_MH-6.7.0_to_MH-6.8.4.html to DIST target in Makefile.in.
* Released nmh-1.0.4.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Apr 12 00:54:54 2000 +0000
Just reworded the bit about '%s' being safe not to quote (it's only safe not to
quote on the -charset- line).
Author: Dan Harkless <dan@harkless.org>
Date: Wed Apr 12 00:25:23 2000 +0000
Applied Brian Campbell <bacam@tardis.ed.ac.uk>'s mhn.defaults.sh patch:
It appears that there shouldn't be quotes around the %s in the iso-8859-1
charset entry; xterm passes the remaining arguments to the program, quoting
them means that xterm thinks they're part of the program's name.
%s doesn't come from MIME headers, so not quoting it is safe.
Author: Doug Morris <doug@mhost.com>
Date: Sun Apr 9 07:04:24 2000 +0000
bug fix - prevents core-dumping on scan -format '1'
Author: Dan Harkless <dan@harkless.org>
Date: Fri Apr 7 00:42:55 2000 +0000
Richard Coleman threw out a lot of old MH-specific files in nmh. Much of the
stuff, indeed, is not worth saving, but there are nuggets that are very
worthwhile, and should probably be added back in. Most important, IMHO, are the
MH change logs, as they can help answer questions like "Why is this code like
this?" or "How long has this been broken?" or "What was this ever used for?"
I've added a new file to the nmh tree called ChangeLog_MH-3_to_MH-6.6. It's
cobbled together from the mh-6.8.4/papers/mh*/MHCHANGES files. I've re-ordered
the entries to go from newest at the top to oldest at the bottom to match the
ChangeLog convention. Unfortunately there are no change logs for versions of MH
prior to 3 in the MH tar files available at <ftp://ftp.ics.uci.edu/pub/mh>.
Also, it appears to me that there are MH-6.6 changes that aren't documented in
the logs.
I've also added ChangeLog_MH-6.7.0_to_MH-6.8.4.html. This is based on
mh-6.8.4/papers/changes/mh-changes.ms. The nroff format and its "catman"-type
output are a pain to deal with, but I was loath to throw away the formatting, so
I converted the file to HTML. The only actual markup in the body are the "<B>"
and "<U>" tags, and "<" and ">" instead of '<' and '>', so it's quite
doable to view the file in plain ASCII mode as well. Note that some of the
changes this file documents as having been made in MH-6.8.4 may not be present
in nmh -- Richard started with 6.8.3 and later put in certain 6.8.4 stuff.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Apr 6 19:56:35 2000 +0000
Whoah, this should have been changed a long time ago. For one thing, Richard
forgot to update the copyright date when he made modifications in 1999, but more
significantly, this COPYRIGHT notice hasn't been changed since Richard ceded
control of nmh development and it became an open-source project.
Changed the COPYRIGHT notice to a BSD License, with a couple of minor wording
tweaks. Copyright is assigned to "the authors of nmh", which is anyone who
writes code, whether they have CVS accounts or not.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Apr 6 00:22:06 2000 +0000
* Add some way to configure whether you prefer to see text/plain or text/html
parts of multipart/alternative messages.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Apr 6 00:11:50 2000 +0000
Applied Eric Schnoebelen <eric@cirr.com>'s mhshowsbr.c patch fixing apparent
bugs in Dan Winship's new security quoting code:
Since upgrading, I've been getting the following errors while attempting to
process some MIME messages:
(1) Syntax error: Unterminated quoted string
exit 2
and:
(2) line 1/10 (END)Segmentation fault (core dumped)
(2) appears to be due to the testing of an unset pointer in
mhshowsbr.c:show_multi_aux(). (1) appears to be caused by mis-quoting a
filename being handed to the shell in mhshowsbr.c:show_content_aux().
Resolving the pointer reference issue in mhshowsbr.c:show_multi_aux() turned
up a similar mis-quoting problem in the routine.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Mar 31 04:25:26 2000 +0000
Terran Melconian pointed out that my theory as to why -help was printed as
"-(help)" in the -help output was probably not the most likely scenario. Added
his. ;^>
Author: Doug Morris <doug@mhost.com>
Date: Tue Mar 28 14:42:36 2000 +0000
added Todd Miller's packf patch
Author: Dan Harkless <dan@harkless.org>
Date: Fri Mar 17 20:19:43 2000 +0000
When I applied Wesley Craig's original KPOP patch, I made a change directly to
config.h.in. That's a no-no since that file is automatically generated. Now
that I've applied Wesley's second patch that makes things work as I had
originally documented, I'm re-making the change here, but this time by properly
modifying acconfig.h and then generating config.h.in from that.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Mar 17 20:11:03 2000 +0000
wesley.craig@umich.edu did not document his previous KPOP patch, so I did so,
and asked him to check what I wrote. Unfortunately he didn't notice my
misunderstanding of his patch. I wrote that if you #define POPSERVICE "kpop",
inc and msgchk will use KPOP exclusively, but if you leave it as "pop3", you can
use Wesley's new -kpop switch on a given invocation. Instead, however, -kpop
turned out to be necessary on every invocation, and a KPOP user complained.
Applied Wesley's new patch, which makes things work like I thought his original
patch did. After that, did one more clarifying pass to the documentation in
inc.man and msgchk.man.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Mar 16 02:40:42 2000 +0000
Added a new README.developers file. From the file:
This file is intended to provide a few tips for anyone doing development on
nmh. Developers who learn things "the hard way" about the nmh codebase (as
opposed to local info best encoded in a comment) are encouraged to share
their wisdom here.
Currently the topics are "autoconf files" and "directory structure".
Author: Dan Harkless <dan@harkless.org>
Date: Wed Mar 15 23:37:30 2000 +0000
When I added my --enable-masquerade option, you'll note that I didn't make it
--enable-nmh-masquerade. I find the --enable-nmh-* options too wordy and I'm
not sure why Richard went that route. I've renamed them to just --enable-*, but
the old versions will still work as well (they just aren't advertised).
Added a line to the "nmh configuration" output saying whether POP is enabled.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Mar 15 22:25:16 2000 +0000
When I fixed the long-standing makedir() bugs in January, I had the code call
strtoul(..., 0), which I believed to be safe as all modes specified as ASCII
constants in the nmh code started with a leading zero (signifying octal), which
I did as it would work if internal constants were ever changed to hex.
Unfortunately I was unaware of the "Folder-Protect:" .mh_profile entry, which
mh-profile.man documents as an octal-only constant, with no leading zero
required. I've changed the strtoul() call to an atooi() call and removed the
misleading leading zeroes on the ASCII octal constants in the code and man
pages. Also changed the "Folder-Protect:" example in the man page to something
more interesting than a duplication of the default.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 21:21:28 2000 +0000
Added:
I put Simon's patch under the control of a new #define called
FIX_NON_Y2K_COMPLIANT_MUA_DATES. There's some commentary in
acconfig.h about when you might not want to #define it.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 21:15:55 2000 +0000
Added missing dependency in zotnet/tws/Makefile.in for dtimep.c: dtimep.c-lexed.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 21:07:56 2000 +0000
Created new dtimep.c-lexed with Simon's change using dtimep.lex lexed on
Solaris 2.6.
Removed my comment about strdup(). The Solaris 2.6 failure was due to
failing to do a make distclean after configuring for Ultrix 4.2A. I'll
leave the change, though, since it's still a good one (just not worth
reporting in the ChangeLog).
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 20:50:19 2000 +0000
Changed strdup() in strdup.c to take a _const_ char*. Don't know why this
didn't hit anyone before, but I wasn't able to compile on Solaris 2.6 without
doing this, due to a "previous declaration" error.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 20:40:47 2000 +0000
Applied Simon Burge <simonb@thistledown.com.au>'s dtimep.lex patch:
It seems that some MUA's didn't handle y2k very well - ELM seems to be one of
them, and Ultrix's DXmail (based on MH!). I've got a few emails this month
that look like:
575 Jan 00 Xxxxxx Xxxx 3603 ...
and
22+ Jan 00 Xxx Xxxxx 1771 ...
The first has "15 Jan 100" as the date and the second has "19 Jan 00" as the
date. The following works around this so that scan, show, sortm, etc work ok.
Added scan.MMDDYY and scan.YYYYMMDD format files.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 09:20:27 2000 +0000
* Applied, after some finessing,
Simon Burge <simonb@thistledown.com.au>'s --with-smtpservers patch:
Here's a patch that allows you to add
--with-smtpservers=<some.host.name>
to the ./configure command line to set the "servers: " line in etc/mts.conf.
Around here, we use "mailhost" so that all machines in the current domain
just talk to a central machine and nothing else runs an MTA. Now, I can use
--with-smtpservers=mailhost
instead of having to remember to fix this by hand (and often forgetting to
do so!).
* Inspired by Simon's patch, added an --enable-masquerade option
to configure. It will set the "masquerade:" line of mts.conf. You may specify
a subset of the three types of masquerading, like
--enable-masquerade="draft_from mmailid", or leave off explicit arguments to
enable all three types.
* Alphabetized the --enable and --with options in configure.in and INSTALL and
added documentation of the two new options to the latter.
* Added new dependency for mts.conf: Makefile. If this isn't
done, then when you reconfigure nmh with new values for --enable-masquerade or
--with-smtpservers, you'll fail to get an updated copy of mts.conf.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 05:24:57 2000 +0000
Applied Simon Burge <simonb@thistledown.com.au>'s dtime.c patch:
There's a wrap-around problem that affects the implementation of Zeller's
congruence in dtime.c. This causes the day-of-week calculations to fail for
dates after Feb 29, 2000 (probably up until some year far in the future).
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 05:05:49 2000 +0000
Modified username_extension masquerading to only use the extended address on
generated [Resent-]From: lines and SMTP envelope From:. With Neil's original
implementation, nmh's global idea of the username was changed, which would
result in inc lying and saying you had no new mail because it was looking for a
mailbox called, for instance, "dan-nmh" (where username was "dan" and
$USERNAME_EXTENSION was "-nmh").
While in there (adrsprintf()), added checking of snprintf()'s return code and
added calls to adios() when things are not kosher. Also simplfied the really
confusing REALLYDUMB #ifdef'ing, which didn't even jibe with the comment
explaining REALLYDUMB in acconfig.h. Now adrsprintf() will always return just
the username, even if an explicit domain is passed in (which currently doesn't
happen anywhere in nmh).
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 02:39:13 2000 +0000
Just removed the odd space between the "!" and the "/bin/sh". I believe some
OSes might choke on that, and certainly no OS requires it.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Mar 14 02:29:26 2000 +0000
Applied Sullivan N. Beck <sbeck@cise.ufl.edu>'s mhshow-suffix patch:
With the patch below, you can add lines like:
mhshow-suffix-application/msword: .doc
mhshow-suffix-application/PostScript: .ps
to the mhn.defaults file to append the given suffix to a scratch file. This
allows applications which require a certain suffix to run properly.
Removed -force_html from lynx entry in mhn.defaults.sh (I believe older versions
of lynx lack that option) and added "mhshow-suffix-text/html: .html".
Author: Dan Harkless <dan@harkless.org>
Date: Mon Mar 6 20:19:04 2000 +0000
Applied Neil W Rickert <rickert+nmh@cs.niu.edu>'s msh.c patch:
I finally tracked down the problem in msh that was causing errors
whenever I tried to examine a 'mmdf' style mailbox.
It turns out that not enough memory was being allocated with
calloc(), causing memory pointers to be overwritten and corrupted.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Mar 4 00:02:46 2000 +0000
Changed the new "plussed_user" option to mts.conf's "masquerade:" to
"username_extension" after getting feedback from qmail users, who use '-' as a
separator rather than '+'. Removed checking of $USERPLUS variable. Now check
$USERNAME_EXTENSION, which needs to include the appropriate separator for your
MTA ('-', '+', or whatever) as its first character.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Mar 3 07:30:31 2000 +0000
Oops. I was using an older email address for Neil -- now he uses the $USERPLUS
feature that I'm crediting him for. ;^>
Author: Dan Harkless <dan@harkless.org>
Date: Fri Mar 3 07:24:41 2000 +0000
Added a new "boolean" type to mh.h and TRUE and FALSE constants.
Added a note to DIFFERENCES stating that it's out-of-date (Richard was the last
one to update it) and that we should consider only documenting incompatibilities
with MH there.
Implemented (and documented) a third kind of username masquerading: "plussed
user" masquerading. This one was suggested by Neil Rickert
<rickert@cs.niu.edu>. It's based on sendmail's "plussed user" feature, where
mail sent to <user>+<string> will be delivered to <user>. When it's enabled,
it's controlled by the $USERPLUS environment variable. How is it enabled?
Well, that leads me to:
Renamed the "mmailid:" setting in mts.conf to "masquerade:", and changed it so
that rather than being a boolean, it can be set to any combination of the three
values "draft_from", "mmailid", and "plussed_user". Thus it is now possible to
enable the three types of masquerading individually.
Fixed a bug with "mmailid" masquerading (dating back to MH?) where if it was
turned on, ','s would no longer be considered GECOS field delimiters.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Mar 2 08:20:00 2000 +0000
Oops. You can't just change comments in configure.in, or configure won't be
modified (it doesn't contain the comments) and you won't be able to commit it,
and then the timestamps'll be messed up for everyone and unnecessary autoconf
calls will occur. Added some unnecessary (but frequently used in the file)
trailing 'dnl's on some AC_SUBST()s.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Mar 2 07:56:00 2000 +0000
Oops. My last group commit comment failed to mention what I was doing in this
file. I was adding:
* Change all man pages to group all the commandline options together in one
section with each as a separate mini-heading. Having to dig through prose to
find what a particular option does is a pain in the nads.
This time, moved it out of the [POSSIBILITIES] section and put it in the [TODO]
section, as I feel it's very important (and wouldn't be that difficult to do --
somewhat time-consuming, yes, but not difficult).
Author: Dan Harkless <dan@harkless.org>
Date: Thu Mar 2 07:52:47 2000 +0000
Changed the GECOS-field '&' translation behavior to be controlled by the BSD42
#define rather than GCOS_HACK, since it's apparently always appropriate on OSes
where BSD42 is #defined, and never appropriate on any other OSes. Thanks to
Kimmo Suominen for responding to my "What is this code here for?" comment in
mts.c and explaining the feature.
Also added ULTRIX 4.2A to the list of OSes that have an initgroups() function
but no prototype in the system headers.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Feb 29 06:17:58 2000 +0000
Made a goofy change so that I could produce a new configure because when I
checked in the last version I did it with "cvs commit ... configure configure.in
..." and that apparently gives configure.in a newer timestamp than configure,
which results in spurious autoconf runs when people download the source. We
need to write a little note to developers somewhere saying what in order you
need to check in those autoconf files and how long you need to wait in between
each one and such...
Author: Dan Harkless <dan@harkless.org>
Date: Tue Feb 29 05:59:16 2000 +0000
Changed "echo > stamp-h.in" in Makefile.in to "date > stamp-h.in" so that
stamp-h.in will be different each time configure.in and related files are
changed, making it easier to check it in (which is necessary to prevent
unnecessary autoconf calls).
My declaration of initgroups() in slocal.c to eliminate the "no prototype"
warning wasn't portable (FreeBSD 3.[23] choked). Now use AC_EGREP_HEADER to see
where initgroups() is declared, if anywhere.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Feb 29 05:16:35 2000 +0000
Upped the version number to 1.0.3+dev (ideally this should be done by whoever
makes a release tar file, immediately after doing so).
Applied Paul Fox <pgf-spam@foxharp.boston.ma.us>'s scansbr.c patch, posted to
comp.mail.mh, which he says prevents loss of mail when inc'ing into a full
filesystem.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Mon Feb 28 17:09:02 2000 +0000
* Fix security hole in mhshowsbr.c which allowed untrusted shell
code to be executed.
* Released nmh 1.0.3.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Feb 10 18:50:23 2000 +0000
Oops. %-escapes on mhstore lines in mhn.defaults.sh should not be surrounded by
single quotes, as a shell is not spawned when just saving files, and the
filenames will end up with literal quotes embedded in them.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Feb 4 20:36:43 2000 +0000
Removed an item that Richard did without removing its TODO, and removed an item
that was duplicated in two different priority sections.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Feb 4 20:34:07 2000 +0000
Whoever originally added the -help switch to all the commands got too cute and
had the option itself print out as "-(help)" in the -help output. I guess the
idea was to make reference to the fact that clearly you know about the -help
option since you're currently looking at its output. I think it's a bad idea to
overload the meaning of the parentheses, however -- they're supposed to indicate
what abbreviated prefix of the switch you're allowed to specify. It doesn't
make sense to show that you're allowed to "abbreviate" the switch to its entire
length.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Feb 4 20:28:23 2000 +0000
Whoever originally added the -help switch to all the commands got too cute and
had the option itself print out as "-(help)" in the -help output. I guess the
idea was to make reference to the fact that clearly you know about the -help
option since you're currently looking at its output. I think it's a bad idea to
overload the meaning of the parentheses, however -- they're supposed to indicate
what abbreviated prefix of the switch you're allowed to specify. It doesn't
make sense to show that you're allowed to "abbreviate" the switch to its entire
length.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Feb 4 01:46:29 2000 +0000
Modified INSTALL and config.h.in to reflect the new -kpop feature.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Feb 4 01:32:12 2000 +0000
* Applied wesley.craig@umich.edu's KPOP patches. According to him:
The following patch fixes a problem with requesting a service key for a
machine that has multiple 'A' records. It also makes "-kpop" a command
line option, for users who would like to use both "kpop" and "pop".
Did no testing of the new features, as I don't have access to a KPOP server.
One tweak I made to the patch he sent to nmh-workers was to move the
declaration of his new hp2 variable into the #ifdef KPOP section so you don't
get an "unused variable" warning when compiling without KPOP.
* Modified inc.man and msgchk.man to document Wesley's new -kpop.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Jan 29 01:34:20 2000 +0000
Added check for lynx to write mhshow-show-text/html line in mhn.defaults.sh.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jan 28 23:29:06 2000 +0000
Made a couple of minor whitespace changes to test if the latest beta version of
CVS fixes this bug:
dilvish-dan> cvs commit ../ChangeLog mhn.defaults.sh
danh@mhost.com's password:
Warning: Remote host denied X11 forwarding, perhaps xauth program could not be run on the server side.
cvs: lock.c:179: lock_name: Assertion `*short_repos++ == '/'' failed.
Terminated with fatal signal 6
cvs commit: saving log message in /tmp/cvslIx_yb
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jan 28 22:00:33 2000 +0000
All %-escapes in mhn.defaults that actually expand to something should be
surrounded by single quotes. Added quotes to the ones in mhn.defaults.sh that
were missing them.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jan 27 20:20:01 2000 +0000
makedir() had multiple bugs dating back to MH. It passed an octal constant to
atoi(), which interpreted it as decimal, resulting in directories with no user
read or execute permissions, making nested directory creation fail. Also, when
creating a nested directory, correct permissions were only set on the inner one.
A second `make install' would always fail because the check for whether
mh_profile.5 existed was written incorrectly.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jan 27 20:14:58 2000 +0000
Doug's check for whether mh_profile.5 exists was bad -- it looked in the local
directory rather than the installation directory, so the check would always
return false and re-installation when mh_profile.5 did exist would bomb out.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Jan 27 20:12:38 2000 +0000
Fixed multiple bugs in makedir(). First off, when creating nested folders, it
only set permissions properly on the innermost one. Secondly, it passwd an
octal constant to atoi(), which only works on decimal numbers, resulting in
directories with no user read or execute permission, making creation of nested
dirs fail.
Also added a comment wondering why we do special processing when euid != uid.
If no one disagrees with my comments, I'll remove that weird code in the future.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 21:35:43 2000 +0000
Dan Winship informed me that the right fix when gcc -Wall complains about char
indexes to arrays is to cast to unsigned char, not int. You want to prevent
negative indexes into the array.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 10:16:32 2000 +0000
Added documentation on both types of masquerading to post's man page.
Also clarified some wording and added a note that the new type of masquerading
has been implemented only for post, not for the undocumented spost backend.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 10:14:14 2000 +0000
Expanded the mention of the $SIGNATURE environment variable to talk about the
three different ways to override "From:" header construction. Also added
mh-tailor(5) to the "SEE ALSO" section.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 09:27:59 2000 +0000
Just added a comment explaining that akvalue() does mh alias substitution.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 09:26:23 2000 +0000
I had my envelope-From:-setting in the wrong place in the code, before alias
processing was done. Put it in the right place, and properly implemented
Resent-From:-handling, which I had neglected before.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 09:24:15 2000 +0000
Added a comment bemoaning the lack of aliasing on the From: header and
explaining why I wasn't going to bother implementing my new draft-From:-based
email address masquerading right now.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 06:51:50 2000 +0000
Doug's portability fix of my setgid inc autodetection had a caching bug -- if
you re-ran configure, uip/Makefile would be corrupted, and installation would
fail on OSes where inc needs to be setgid.
Implemented a new kind of email address masquerading. When a user writes a
custom "From:" header in a draft, nmh uses it rather than generating one.
However, the user's true address is used in the SMTP envelope "From:" and is
revealed in the "Sender:" header. Now, when mmailid is set to non-zero, the
envelope "From:" uses the address specified in the draft "From:" header, and
there is no "Sender:" header. This is useful when sending on behalf of a remote
POP3 account or when remote mail robots incorrectly use the envelope "From:" in
preference to the body "From:".
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 06:39:49 2000 +0000
I'm surprised this didn't hit anyone sooner. Doug's portability fix of my
setgid inc autodetection didn't do its caching properly. It cached the variable
$nmh_cv_ls_mail_grp (previously $nmh_group_mailspool), but did substitution on
$MAIL_SPOOL_GRP (previously $MAILGROUP) without setting the latter to the
former. That meant that when re-running configure, $MAIL_SPOOL_GRP would be
NULL, so the $(MAIL_SPOOL_GRP) Make variable would be NULL, and installation
would fail with the error "install: 2755 does not exist" (since the argument to
-g was missing).
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 05:40:30 2000 +0000
Implemented a new type of username masquerading, which is also activated by
setting mmailid to non-zero in mts.conf. The new type is based on the From:
header in the message draft rather than the GECOS field of the passwd file like
the old type.
With mmailid turned off, when a user specifies a custom From: header in a draft,
it'll be used, but the user's real address will be revealed in the SMTP envelope
From: and in the Sender: header. With mmailid on, this revelation is disabled.
Also copied to here my new comment from mh.h explaining (if I understand it
correctly) the functionality of struct swit's minchars field. Also, changed the
minchars for "help" from 4 to 0. It doesn't make sense to use a positive
integer that's the exact length of the option. That'll make it print out like
"-(help)". The parentheses are supposed to go around the minimum part of the
option you need to specify when abbreviating it. Perhaps someone thought it
would be cute to put "help" in parentheses to imply that you know about it
already as you just specified it be seeing the current output, but I think this
"overloading" of the meaning of the parentheses is awkward. I need to go around
and change "help" to 0 everywhere, but it's getting too late to do it tonight.
Also added some other explanatory comments to existing code.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 05:28:33 2000 +0000
Updated to reflect that there are now two types of username masquerading
(GECOS-based, the old one, and draft-From:-based, the new one). Also clarified
existing wording.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 05:03:07 2000 +0000
Documented the minchars field of struct swit to the best of my understanding.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 05:01:06 2000 +0000
Modified the mmailid comment to reflect that there are now two types of
masquerading (wouldn't want sysadmins to not realize that by allowing one,
they're allowing the other). I also prefer my new wording of "allow" vs. the
old "turn on" because the latter implied that masquerading would take effect
just by setting that variable (not the case unless /etc/passwd had been
previously modified to have the <fakeusername>s).
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 04:57:57 2000 +0000
Whoever changed all the references to nmh-workers@math.gatech.edu to
nmh-workers@mhost.com missed this file.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Jan 26 04:54:30 2000 +0000
Changed Mmailids to an extern so that we can access it from post.c to see if we
should do the new draft-From:-based masquerading. Also clarified some comments
now that there are two different types of masquerading.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 21:06:09 2000 +0000
Just clarified a couple of points in my last change description.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 07:45:10 2000 +0000
The prototype I gave for initgroups() which was documented in the AIX 4.1 info
page conflicted with the real one that comes from grp.h on Solaris 2.6.
Adjusted it so the local prototype is correct on both (hopefully all)
platforms. Also added an include of <unistd.h>, which is where initgroups()
lives on HP-UX 10.20.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 07:10:25 2000 +0000
I kept going back and forth checking in new pointless revisions of
configure[.in], but it now looks like the problem was that stamp-h.in was older
than configure.in (or maybe there were two problems). Hopefully this'll get rid
of the needless auto* calls.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:56:25 2000 +0000
Shoot. Apparently it gets the timestamp from the check-in time rather than
preserving the actual timestamp on the file when you check it in, so the
timestamp was the same for configure.in and configure, so the Makefile was doing
an autoconf just in case. This time I'm checking in configure.in first and
configure at least a second later. What a pain.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:46:13 2000 +0000
Accidentally checked in configure with older date than configure.in, but I
hadn't made changes to configure.in that would result in a different configure,
so I can't check one in with the right timestamp. Therefore, I made a
meaningless change to configure.in (adding a "dnl" to the end of line that was
like others that had "dnl" at the end but didn't have one itself) and
regenerated configure.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:21:38 2000 +0000
The conditional definition of the "np" variable didn't make any sense. It was
only defined if HAVE_GETHOSTBYNAME was defined and only used when
HAVE_GETHOSTBYNAME wasn't defined. I'm kind of surprised that never blew up
anywhere. Changed the definition conditional to match the usage conditional.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:19:51 2000 +0000
Got rid of the rest of the warnings that I didn't have time for on 1999-07-15
(and, it would seem, some new ones people introduced since then). The primary
ones were the warnings that default prototypes were being used for [v]snprintf()
and str[n]casecmp(). As of right now, there are _no_ compilation warnings
except on the lex output file (at least under AIX 4.1.5 and Solaris 2.6).
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:18:54 2000 +0000
On AIX 4.1, snprintf() is defined in libc.a but there's no prototype in
<stdio.h> or elsewhere. Apparently it's not officially supported (though it
seems to work perfectly and IBM apparently uses it in internal code). Anyhow,
if we omit our own snprintf() and vsnprintf() prototypes when we HAVE_SNPRINTF,
we get a billion warnings at compile time. Use the C preprocessor to preprocess
stdio.h and make sure that there's actually a prototype. Define
HAVE_SNPRINTF_PROTOTYPE if so, and use that to control our local prototype
definition.
Also, define strcasecmp() and strncasecmp() here all the time since we define
our own versions and always use them. The only way we could get into trouble
doing this would be if the vendor's versions didn't have the same parameters,
but I don't see that happening. If we don't define them here, we get warnings
all over the place that default prototypes are being used for 'em, and the
system header to include varies from OS to OS.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:13:38 2000 +0000
On AIX 4.1, snprintf() is defined in libc.a but there's no prototype in
<stdio.h> or elsewhere. Apparently it's not officially supported (though it
seems to work perfectly and IBM apparently uses it in internal code). Anyhow,
if we omit our own snprintf() and vsnprintf() prototypes when we HAVE_SNPRINTF,
we get a billion warnings at compile time. Use the C preprocessor to preprocess
stdio.h and make sure that there's actually a prototype. Define
HAVE_SNPRINTF_PROTOTYPE if so, and use that to control our local prototype
definition.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:06:18 2000 +0000
Added include of signals.h for SIGNAL() prototype.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:04:29 2000 +0000
Added include of mh.h for snprintf() prototype.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 06:00:22 2000 +0000
Added include of mh.h to get snprintf() prototype and changed all references to
getcpy() to our_getcpy() to prevent conflict with the external one.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 05:58:26 2000 +0000
Put in a prototype for stdio internal function _filbuf() to get rid of the
"default prototype" warning (only do this when we didn't #define it to something
specific due to another #define telling us to do so).
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 05:55:20 2000 +0000
Put in a prototype for client() to get rid of the "default prototype" warning.
The prototype should really go in a new client.h file or somewhere, but I don't
have time right now for that.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 05:53:40 2000 +0000
Typecast to get rid of warnings that index into cc[] is a char.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 05:52:31 2000 +0000
Put in prototype for initgroups() to get rid of "default prototype" warning. On
AIX 4.1, at least, the function exists in libc.a but doesn't exist in any .h.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Jan 25 05:50:12 2000 +0000
Typecast to get rid of warnings that array index into types[] is a char.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Thu Jan 6 21:30:07 2000 +0000
* Move mhtest from bindir to libdir.
* Move sendfiles from libdir to bindir.
* Updated sendfiles manpage to reflect this change.
* Added documentation for -build and -file switches to repl and
forw manpages (patch from Peter Maydell).
* Fixed interaction between specifying -cc in profile and -group on
command-line.
Author: Dan Harkless <dan@harkless.org>
Date: Thu Nov 11 01:01:07 1999 +0000
* Add command to reverse the action of rmm [-nounlink] -- "urmm"? "umm"? "um"?
* Allow user customization of which kinds of text parts in multipart/alternative
messages are preferred. It would be nice if one selectable behavior would be
to be prompted at runtime for which version to show.
* Add a new %-escape that makes temp files more permanent than %f, so that you
can use gnuclient -q or netscape -remote on message parts. Put netscape
-remote in mhn.defaults for text/html once this is done.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Nov 2 21:49:47 1999 +0000
Changed the version number from 1.0.3 to 1.0.2+dev. There was not unanimous
support for my proposed even/odd release/developer version number dichotomy.
1.0.2+dev implies release 1.0.2 plus some development.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Oct 29 20:42:13 1999 +0000
Upped the version number to 1.0.3. If we don't do this, then when people report
bugs against 1.0.2, we won't know "which" 1.0.2 they're talking about (since the
development source is publically available via CVS). I think the Linux kernel
version numbers are a good model, so the next time we roll a tarball, it should
be version 1.0.4 (or higher -- anyhow, an even-numbered version).
Author: Doug Morris <doug@mhost.com>
Date: Fri Oct 29 05:10:18 1999 +0000
updated INSTALL directions
Author: Doug Morris <doug@mhost.com>
Date: Fri Oct 29 04:49:01 1999 +0000
release nmh-1.0.2
Author: Doug Morris <doug@mhost.com>
Date: Fri Oct 29 04:32:50 1999 +0000
updated the TODO list and bumped the revision to 1.0.2.
Author: Doug Morris <doug@mhost.com>
Date: Wed Oct 27 05:21:12 1999 +0000
fixed test in Makefiles for LIBTOOL for the case where it doesn't exist
Author: Doug Morris <doug@mhost.com>
Date: Tue Oct 26 21:12:36 1999 +0000
fixed libtool check, sort of...
Author: Doug Morris <doug@mhost.com>
Date: Thu Oct 21 18:59:35 1999 +0000
changes to allow building under Mac OS X/Rhapsody
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun Oct 17 17:39:22 1999 +0000
* Changed repl defaults to partly revert to MH behaviour:
"-cc all" is now only implied with -group.
* The replcomps template includes cc: header again (as in MH).
* Updated repl man page to reflect these changes.
Author: Doug Morris <doug@mhost.com>
Date: Sat Oct 16 00:56:05 1999 +0000
sunos/solaris modifications
Author: Doug Morris <doug@mhost.com>
Date: Fri Oct 15 22:38:55 1999 +0000
replaced the BIND guess (based on BSDishness) with checks for gethostbyname and sethostent
Author: Doug Morris <doug@mhost.com>
Date: Wed Oct 13 14:56:41 1999 +0000
fixed bug in mh-profile/mh_profile manpage link - it did not check first
Author: Doug Morris <doug@mhost.com>
Date: Wed Oct 13 13:58:41 1999 +0000
updated manpage's Makefile and modified the way configure tests to see whether
it should define LINUX_STDIO.
Author: Dan Harkless <dan@harkless.org>
Date: Mon Oct 4 22:23:29 1999 +0000
Added '-L' to the calls of 'ls' in configure.in -- I have seen multiple machines
in the past where the mail spool was a symlink to a directory on another device
with more free space.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Oct 2 06:00:54 1999 +0000
* Fixed a portability problem in Doug's fix of a portability
problem in my MAILGROUP autoconf support ('ls -l' vs. 'ls -lg').
Author: Dan Harkless <dan@harkless.org>
Date: Sat Oct 2 06:00:11 1999 +0000
I didn't like the double use of "MAILGROUP" for two different variables used in
different languages, with different values. I renamed Doug's new Makefile
"MAILGROUP" to MAIL_SPOOL_GRP.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Oct 2 05:57:23 1999 +0000
Touched because I changed configure.in.
Author: Dan Harkless <dan@harkless.org>
Date: Sat Oct 2 05:55:54 1999 +0000
Doug's fix for my MAILGROUP autoconf support on his platform (yep, I was
ignorant about that "wheel" group) broke it on my platforms (AIX 4.1.5.0.01 and
Solaris 2.6). `ls -lg` doesn't do what Doug was expecting on these platforms --
it displays _only_ the group rather than the user and the group (thus awk
'{print $4}' did the wrong thing).
Also did some miscellaneous cleanup, like making variables that were intended to
be cached actually be cached (renamed to nmh_cv_*, etc.), and using the $AWK
that we've auto-detected rather than relying on the $PATH to find one.
Author: Ruud de Rooij <ruud@ruud.org>
Date: Sun Sep 26 17:45:55 1999 +0000
* Added config.sub and config.guess to the list of files to be
distributed.
* Fixed bug in sbr/fmt_scan.c where an extra newline would be
added if a list of addresses was split over several header lines.
* In mts/smtp/smtp.c, undefine strlen and strcpy if they are
macros, regardless of platform.
* Allow q to quit mhshow, and n to skip to next part. Patch from
Kimmo Suominen <kim@tac.nyc.ny.us>.
* Modified mhstore to recognize attachments created by sendfiles
with x-conversions=gzip.
Author: Doug Morris <doug@mhost.com>
Date: Mon Sep 13 19:23:29 1999 +0000
moved canonical guesses back into user config section of config.h
Author: Doug Morris <doug@mhost.com>
Date: Mon Sep 13 18:20:28 1999 +0000
updates to post.c and termsbr.c that prevent warnings on OpenBSD
Author: Doug Morris <doug@mhost.com>
Date: Sun Sep 12 13:50:11 1999 +0000
Lots of little code cleanups to prevent warnings - mostly making sure
some function prototypes are available at compile time. Also fixed
Makefile.in so that make nmhdist will work -- it just blew up after
COMPLETION-TCSH was added and ZSH-COMPLETION was changed to
COMPLETION-ZSH.
Author: Doug Morris <doug@mhost.com>
Date: Sun Sep 12 07:19:40 1999 +0000
updating changelog, should have been done with last commit
Author: Doug Morris <doug@mhost.com>
Date: Sun Sep 12 06:44:02 1999 +0000
fix for configure to find db1/ndbm.h in new linux systems
Author: Doug Morris <doug@mhost.com>
Date: Fri Sep 10 05:22:40 1999 +0000
configure, configure.in stamp-h.in, and uip/Makefile.in modified to fix
MAILGROUP test.
m_getfld.c - added the patch submitted by Richard Cohen to fix
crashing when mh_profile has no trailing newline.
smtp.c, lock_file.c, m_scratch.c, m_tmpfil.c, mhscmds.c, rcvtty.c, and
spost.c modified to fix mkstemp bugs. Some I've simply commented out
because the repair requries either creating another new tempfile
function (there are 3 already) or cleaning up the existing tmpfile
functions and all the calls to them. I'm opting for the latter but
it will take a while.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Sep 7 23:45:20 1999 +0000
Renamed ZSH.COMPLETION to COMPLETION-ZSH and added COMPLETION-TCSH.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Sep 7 23:41:37 1999 +0000
New file along the lines of the old ZSH.COMPLETION, but for tcsh. Pretty bare
right now.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Sep 7 23:34:00 1999 +0000
Renamed to COMPLETION-ZSH so it'll alphabetize next to new COMPLETION-TCSH.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Sep 7 23:29:14 1999 +0000
Renamed from ZSH.COMPLETION so it'll alphabetize next to new COMPLETION-TCSH.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Aug 18 00:05:24 1999 +0000
Crap. That's what I get for using vi instead of xemacs for a change. Inserted
missing newline.
Author: Dan Harkless <dan@harkless.org>
Date: Wed Aug 18 00:01:28 1999 +0000
Just adding some text to this file so that cvs will see a difference and let me check it in. Every time acconfig.h or configure.in are changed (which I just
did), the timestamp on this file needs to be updated or when people do a make
an unnecessary `cd . && autoheader` will be done, and not everybody has the
autoconf tools installed. The next person to change those two files (or
aclocal.m4) will need to change this text, maybe just to a message saying which
dependency files were changed and by whom.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Aug 17 23:31:23 1999 +0000
Automated #define of MAILGROUP and installation of inc as setgid mail when the
mail spool directory isn't world-writable.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Aug 17 23:15:31 1999 +0000
Automated #define of MAILGROUP and installation of inc as setgid mail when the
mail spool directory isn't world-writable.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Aug 17 23:12:42 1999 +0000
Just removed some useless whitespace that [X]Emacs' Make mode highlights as
being semi-bogus.
Author: Dan Harkless <dan@harkless.org>
Date: Tue Aug 17 23:09:46 1999 +0000
Automated #define of MAILGROUP and installation of inc as setgid mail when the
mail spool directory isn't world-writable.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:39:09 1999 +0000
* slocal -debug used to leave a copy of each message processed in /tmp.
* Got rid of a ton of compilation warnings output by gcc -Wall.
* rcvdistcomps no longer has "Resent-Fcc: outbox"; new rcvdistcomps.outbox does.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:30:05 1999 +0000
Eliminated compilation warnings.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:19:29 1999 +0000
Eliminated unsued sigset_t variables set and oset.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:16:08 1999 +0000
Previously contained the code:
if (numburst == 0)
if (!quietsw)
admonish (NULL, "message %d not in digest format",
msgnum);
else
adios (NULL, "burst() botch -- you lose big");
If the indentation is to be believed, this is a bug. I trusted the indentation
and added {}s around the inner if().
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:13:05 1999 +0000
Eliminated compilation warnings. pop_action() and pop_pack() used to return
garbage. They now (arbitrarily) return 0. Dunno if their return values are
ever used...
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:11:44 1999 +0000
Eliminated compilation warnings.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:03:34 1999 +0000
donote() previously was written such that it could return garbage.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 01:01:24 1999 +0000
err2peer() previously returned garbage. Now it returns result of callee
verr2peer().
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:59:36 1999 +0000
Eliminated compilation warnings.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:53:17 1999 +0000
Eliminated compilation warnings.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:52:20 1999 +0000
Eliminated compilation warnings.
slocal -debug left a file in /tmp for every single message it processed!
Totally unacceptable since some people like to have slocal -debug in their
.forward files to get better logging.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:50:01 1999 +0000
Changed done() from returning void to returning int so that main()s who call
done() at the end can instead return done() at the end to eliminate the
compilation warning about falling off the end of a non-void function.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:48:59 1999 +0000
Changed from returning void to returning int so that main()s who call done() at
the end can instead return done() at the end to eliminate the compilation
warning about falling off the end of a non-void function.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:47:33 1999 +0000
Changed call of done() to return of done() to eliminate compilation warning.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:44:40 1999 +0000
I think it's totally inappropriate for the default rcvdistcomps to save all
outgoing messages in an "outbox" folder. I have made a new file called
rcvdistcomps.outbox which looks like this file used to.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:43:04 1999 +0000
New $(DIST_FILES) entry: rcvdistcomps.outbox.
Author: Dan Harkless <dan@harkless.org>
Date: Fri Jul 16 00:40:35 1999 +0000
I renamed the old rcvdistcomps to rcvdistcomps.outbox and removed the
"Resent-Fcc: outbox" line from rcvdistcomps.
Author: Doug Morris <doug@mhost.com>
Date: Sat Jun 12 09:29:45 1999 +0000
added my name to the change
Author: Doug Morris <doug@mhost.com>
Date: Sat Jun 12 09:26:50 1999 +0000
added explanation of change made two nights ago.
Author: Doug Morris <doug@mhost.com>
Date: Wed Jun 9 20:51:59 1999 +0000
use mkstemp on systems that have it
Author: Doug Morris <doug@mhost.com>
Date: Thu May 13 14:42:34 1999 +0000
Added notes about the configure change.
Author: Doug Morris <doug@mhost.com>
Date: Thu May 13 14:28:25 1999 +0000
Modified configure to use config.guess and config.sub to auto-detect
the system type and correctly set the #defines in config.h.
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 03:42:11 1999 +0000
1.0.1
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:32:53 1999 +0000
1.0.1 patches
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:31:47 1999 +0000
Update for the brave new world
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:31:00 1999 +0000
Use "#include <errno.h>" instead of "extern int errno;". Suggested by
Stephen Wilson Bailey <swb@nconnect.net>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:28:40 1999 +0000
add a note about Irix make
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:28:16 1999 +0000
man page updates from Jerry Peek <jpeek@jpeek.com>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:26:41 1999 +0000
deal with SIGPIPE so mhl doesn't print "Broken pipe" if you quit out
of the moreproc
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:25:52 1999 +0000
Fixed a signal-handling bug that could cause whatnow to sometimes exit
without prompting the user. Based on a patch by Richard Geiger
<rmg@netapp.com>.
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:24:47 1999 +0000
Changed configure.in's check for sigsetjmp to properly deal with
systems like Linux where it is a macro. From <elleron@servtech.com>.
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:22:54 1999 +0000
Added -library switch so it can parse user aliases like post does.
From Ruud de Rooij <r.c.m.derooij@twi.tudelft.nl>.
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:22:03 1999 +0000
Don't add line breaks in the middle of long addresses when building a
draft. Fixes a bug where repl would generate invalid headers. From
Ruud de Rooij <r.c.m.derooij@twi.tudelft.nl>.
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:17:23 1999 +0000
Allow display of 8bit encoded messages. From Kimmo Suominen
<kim@tac.nyc.ny.us>.
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:16:14 1999 +0000
Change ordering of a conditional to prevent a bad pointer dereference.
Fixes a segv in inc (and occasionally other programs). Originally from
Ruud de Rooij <r.c.m.derooij@twi.tudelft.nl>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:13:58 1999 +0000
Fix a buffer overrun that caused packf -mbox to mess up on
Return-Path: lines. From Kimmo Suominen <kim@tac.nyc.ny.us>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:12:12 1999 +0000
Make whatnow "list" work with "lproc: show" again. From Ruud de Rooij
<r.c.m.derooij@twi.tudelft.nl>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:10:45 1999 +0000
add HAVE_LIBM
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:07:15 1999 +0000
Add check for modf and link with -lm if it's not in libc. Needed for
at least Digital UNIX. Problem noted by Kevin Oberman <oberman@es.net>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:05:49 1999 +0000
Fix krb4 code to work with the original krb4 libraries as well as
the krb5-compat ones. Based on a patch by Assar Westerlund <assar@sics.se>
Author: Dan Harkless <dan@harkless.org>
Date: Thu May 13 01:03:23 1999 +0000
Properly deal with relative folder names. Problem noted by Jerry Peek
<jpeek@jpeek.com>
Author: Doug Morris <doug@mhost.com>
Date: Fri Apr 30 18:08:34 1999 +0000
Initial revision
|