1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227
|
'use strict';
let http = require('http');
const assert = require('assert');
const fs = require('fs');
const request = require('../support/client');
const express = require('../support/express');
const app = express();
if (process.env.HTTP2_TEST) {
http = require('http2');
}
app.get('/raw-query', (request_, res) => {
res.status(200).send(request_.url.slice(request_.url.indexOf('?') + 1));
});
app.get('/', (request_, res) => {
res.status(200).send(request_.query);
});
app.delete('/url', (request_, res) => {
res.status(200).send(request_.url);
});
app.delete('/', (request_, res) => {
res.status(200).send(request_.query);
});
app.put('/', (request_, res) => {
res.status(200).send(request_.query);
});
let base = 'http://localhost';
let server;
before(function listen(done) {
server = http.createServer(app);
server = server.listen(0, function listening() {
base += `:${server.address().port}`;
done();
});
});
describe('req.query(String)', () => {
// This is no longer true as of qs v3.0.0 (https://github.com/ljharb/qs/commit/0c6f2a6318c94f6226d3cf7fe36094e9685042b6)
// it('should supply uri malformed error to the callback')
it('should support passing in a string', (done) => {
request
.del(base)
.query('name=t%F6bi')
.end((error, res) => {
res.body.should.eql({ name: 't%F6bi' });
done();
});
});
it('should work with url query-string and string for query', (done) => {
request
.del(`${base}/?name=tobi`)
.query('age=2%20')
.end((error, res) => {
res.body.should.eql({ name: 'tobi', age: '2 ' });
done();
});
});
it('should support compound elements in a string', (done) => {
request
.del(base)
.query('name=t%F6bi&age=2')
.end((error, res) => {
res.body.should.eql({ name: 't%F6bi', age: '2' });
done();
});
});
it('should work when called multiple times with a string', (done) => {
request
.del(base)
.query('name=t%F6bi')
.query('age=2%F6')
.end((error, res) => {
res.body.should.eql({ name: 't%F6bi', age: '2%F6' });
done();
});
});
it('should work with normal `query` object and query string', (done) => {
request
.del(base)
.query('name=t%F6bi')
.query({ age: '2' })
.end((error, res) => {
res.body.should.eql({ name: 't%F6bi', age: '2' });
done();
});
});
it('should not encode raw backticks, but leave encoded ones as is', () => {
return Promise.all([
request
.get(`${base}/raw-query`)
.query('name=`t%60bi`&age`=2')
.then((res) => {
res.text.should.eql('name=`t%60bi`&age`=2');
}),
request.get(base + '/raw-query?`age%60`=2%60`').then((res) => {
res.text.should.eql('`age%60`=2%60`');
}),
request
.get(`${base}/raw-query`)
.query('name=`t%60bi`')
.query('age`=2')
.then((res) => {
res.text.should.eql('name=`t%60bi`&age`=2');
})
]);
});
});
describe('req.query(Object)', () => {
it('should construct the query-string', (done) => {
request
.del(base)
.query({ name: 'tobi' })
.query({ order: 'asc' })
.query({ limit: ['1', '2'] })
.end((error, res) => {
res.body.should.eql({ name: 'tobi', order: 'asc', limit: ['1', '2'] });
done();
});
});
// See commit message for the reasoning here.
it('should encode raw backticks', (done) => {
request
.get(`${base}/raw-query`)
.query({ name: '`tobi`' })
.query({ 'orde%60r': null })
.query({ '`limit`': ['%602`'] })
.end((error, res) => {
res.text.should.eql('name=%60tobi%60&orde%2560r&%60limit%60=%25602%60');
done();
});
});
it('should not error on dates', (done) => {
const date = new Date(0);
request
.del(base)
.query({ at: date })
.end((error, res) => {
assert.equal(date.toISOString(), res.body.at);
done();
});
});
it('should work after setting header fields', (done) => {
request
.del(base)
.set('Foo', 'bar')
.set('Bar', 'baz')
.query({ name: 'tobi' })
.query({ order: 'asc' })
.query({ limit: ['1', '2'] })
.end((error, res) => {
res.body.should.eql({ name: 'tobi', order: 'asc', limit: ['1', '2'] });
done();
});
});
it('should append to the original query-string', (done) => {
request
.del(`${base}/?name=tobi`)
.query({ order: 'asc' })
.end((error, res) => {
res.body.should.eql({ name: 'tobi', order: 'asc' });
done();
});
});
it('should retain the original query-string', (done) => {
request.del(`${base}/?name=tobi`).end((error, res) => {
res.body.should.eql({ name: 'tobi' });
done();
});
});
it('should keep only keys with null querystring values', (done) => {
request
.del(`${base}/url`)
.query({ nil: null })
.end((error, res) => {
res.text.should.equal('/url?nil');
done();
});
});
it('query-string should be sent on pipe', (done) => {
const request_ = request.put(`${base}/?name=tobi`);
const stream = fs.createReadStream('test/node/fixtures/user.json');
request_.on('response', (res) => {
res.body.should.eql({ name: 'tobi' });
done();
});
request_.on('error', (err) => {
done(err);
});
stream.on('error', (err) => {
done(err);
});
// wait until stream is valid before piping
stream.on('open', () => {
// wait until request_ is ready before piping
setTimeout(() => {
stream.pipe(request_);
}, 10);
});
});
});
|