1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282
|
# Copyright 2016 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""
Suppressions for V8 correctness fuzzer failures.
We support three types of suppressions:
1. Ignore test case by pattern.
Map a regular expression to a bug entry. A new failure will be reported
when the pattern matches a JS test case.
Subsequent matches will be recoreded under the first failure.
2. Ignore test run by output pattern:
Map a regular expression to a bug entry. A new failure will be reported
when the pattern matches the output of a particular run.
Subsequent matches will be recoreded under the first failure.
3. Relax line-to-line comparisons with expressions of lines to ignore and
lines to be normalized (i.e. ignore only portions of lines).
These are not tied to bugs, be careful to not silently switch off this tool!
Alternatively, think about adding a behavior change to v8_suppressions.js
to silence a particular class of problems.
"""
import itertools
import re
try:
# Python 3
from itertools import zip_longest
PYTHON3 = True
except ImportError:
# Python 2
from itertools import izip_longest as zip_longest
PYTHON3 = False
# Max line length for regular experessions checking for lines to ignore.
MAX_LINE_LENGTH = 512
# For ignoring lines before carets and to ignore caret positions.
CARET_RE = re.compile(r'^\s*\^\s*$')
# Ignore by original source files. Map from bug->list of relative file paths,
# e.g. 'v8/test/mjsunit/d8-performance-now.js'. A test will be suppressed if
# one of the files below was used to mutate the test.
IGNORE_SOURCES = {
}
# Ignore by test case pattern. Map from bug->regexp.
# Bug is preferred to be a crbug.com/XYZ, but can be any short distinguishable
# label.
# Regular expressions are assumed to be compiled. We use regexp.search.
IGNORE_TEST_CASES = {
}
# Ignore by output pattern. Map from bug->regexp like above.
IGNORE_OUTPUT = {
'crbug.com/689877':
re.compile(r'^.*SyntaxError: .*Stack overflow$', re.M),
'_fake_difference_':
re.compile(r'^.*___fake_difference___$', re.M),
}
# Lines matching any of the following regular expressions will be ignored
# if appearing on both sides. The capturing groups need to match exactly.
# Use uncompiled regular expressions - they'll be compiled later.
ALLOWED_LINE_DIFFS = [
# Ignore caret position in stack traces.
r'^\s*\^\s*$',
]
# Lines matching any of the following regular expressions will be ignored.
# Use uncompiled regular expressions - they'll be compiled later.
IGNORE_LINES = [
r'^Warning: .+ is deprecated.*$',
r'^Try --help for options$',
# crbug.com/705962
r'^\s\[0x[0-9a-f]+\]$',
]
###############################################################################
# Implementation - you should not need to change anything below this point.
# Compile regular expressions.
ALLOWED_LINE_DIFFS = [re.compile(exp) for exp in ALLOWED_LINE_DIFFS]
IGNORE_LINES = [re.compile(exp) for exp in IGNORE_LINES]
ORIGINAL_SOURCE_PREFIX = 'v8-foozzie source: '
def get_output_capped(output1, output2):
"""Returns a pair of stdout byte arrays.
The arrays are safely capped if at least one run has crashed.
"""
# No length difference or no crash -> no capping.
if (len(output1.stdout_bytes) == len(output2.stdout_bytes) or
(not output1.HasCrashed() and not output2.HasCrashed())):
return output1.stdout_bytes, output2.stdout_bytes
# Both runs have crashed, cap by the shorter output.
if output1.HasCrashed() and output2.HasCrashed():
cap = min(len(output1.stdout_bytes), len(output2.stdout_bytes))
# Only the first run has crashed, cap by its output length.
elif output1.HasCrashed():
cap = len(output1.stdout_bytes)
# Similar if only the second run has crashed.
else:
cap = len(output2.stdout_bytes)
return output1.stdout_bytes[0:cap], output2.stdout_bytes[0:cap]
def line_pairs(lines):
return zip_longest(
lines, itertools.islice(lines, 1, None), fillvalue=None)
def caret_match(line1, line2):
if (not line1 or
not line2 or
len(line1) > MAX_LINE_LENGTH or
len(line2) > MAX_LINE_LENGTH):
return False
return bool(CARET_RE.match(line1) and CARET_RE.match(line2))
def short_line_output(line):
if len(line) <= MAX_LINE_LENGTH:
# Avoid copying.
return line
return line[0:MAX_LINE_LENGTH] + '...'
def ignore_by_regexp(line1, line2, allowed):
if len(line1) > MAX_LINE_LENGTH or len(line2) > MAX_LINE_LENGTH:
return False
for exp in allowed:
match1 = exp.match(line1)
match2 = exp.match(line2)
if match1 and match2:
# If there are groups in the regexp, ensure the groups matched the same
# things.
if match1.groups() == match2.groups(): # tuple comparison
return True
return False
def diff_output(output1, output2, allowed, ignore1, ignore2):
"""Returns a tuple (difference, source).
The difference is None if there's no difference, otherwise a string
with a readable diff.
The source is the last source output within the test case, or None if no
such output existed.
"""
def useful_line(ignore):
def fun(line):
return all(not e.match(line) for e in ignore)
return fun
lines1 = list(filter(useful_line(ignore1), output1))
lines2 = list(filter(useful_line(ignore2), output2))
# This keeps track where we are in the original source file of the fuzz
# test case.
source = None
for ((line1, lookahead1), (line2, lookahead2)) in zip_longest(
line_pairs(lines1), line_pairs(lines2), fillvalue=(None, None)):
# Only one of the two iterators should run out.
assert not (line1 is None and line2 is None)
# One iterator ends earlier.
if line1 is None:
return '+ %s' % short_line_output(line2), source
if line2 is None:
return '- %s' % short_line_output(line1), source
# If lines are equal, no further checks are necessary.
if line1 == line2:
# Instrumented original-source-file output must be equal in both
# versions. It only makes sense to update it here when both lines
# are equal.
if line1.startswith(ORIGINAL_SOURCE_PREFIX):
source = line1[len(ORIGINAL_SOURCE_PREFIX):]
continue
# Look ahead. If next line is a caret, ignore this line.
if caret_match(lookahead1, lookahead2):
continue
# Check if a regexp allows these lines to be different.
if ignore_by_regexp(line1, line2, allowed):
continue
# Lines are different.
return (
'- %s\n+ %s' % (short_line_output(line1), short_line_output(line2)),
source,
)
# No difference found.
return None, source
def get_suppression(skip=False):
return V8Suppression(skip)
def decode(output):
if PYTHON3:
try:
return output.decode('utf-8')
except UnicodeDecodeError:
return output.decode('latin-1')
return output
class V8Suppression(object):
def __init__(self, skip):
if skip:
self.allowed_line_diffs = []
self.ignore_output = {}
self.ignore_sources = {}
else:
self.allowed_line_diffs = ALLOWED_LINE_DIFFS
self.ignore_output = IGNORE_OUTPUT
self.ignore_sources = IGNORE_SOURCES
def diff(self, output1, output2):
# Diff capped lines in the presence of crashes.
return self.diff_lines(
*map(str.splitlines, map(decode, get_output_capped(output1, output2))))
def diff_lines(self, output1_lines, output2_lines):
return diff_output(
output1_lines,
output2_lines,
self.allowed_line_diffs,
IGNORE_LINES,
IGNORE_LINES,
)
def ignore_by_content(self, testcase):
# Strip off test case preamble.
try:
lines = testcase.splitlines()
lines = lines[lines.index(
'print("js-mutation: start generated test case");'):]
content = '\n'.join(lines)
except ValueError:
# Search the whole test case if preamble can't be found. E.g. older
# already minimized test cases might have dropped the delimiter line.
content = testcase
for bug, exp in IGNORE_TEST_CASES.items():
if exp.search(content):
return bug
return None
def ignore_by_metadata(self, metadata):
for bug, sources in self.ignore_sources.items():
for source in sources:
if source in metadata['sources']:
return bug
return None
def ignore_by_output(self, output):
def check(mapping):
for bug, exp in mapping.items():
if exp.search(output):
return bug
return None
bug = check(self.ignore_output)
if bug:
return bug
return None
|