1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
|
//
// RedundantCastIssue.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
//
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System;
using System.Collections.Generic;
using System.Linq;
using ICSharpCode.NRefactory.Semantics;
using ICSharpCode.NRefactory.TypeSystem;
using ICSharpCode.NRefactory.CSharp.Resolver;
using ICSharpCode.NRefactory.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription ("Redundant cast",
Description = "Type cast can be safely removed.",
Category = IssueCategories.Redundancies,
Severity = Severity.Warning,
IssueMarker = IssueMarker.GrayOut,
ResharperDisableKeyword = "RedundantCast")]
public class RedundantCastIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
{
return new GatherVisitor (context).GetIssues ();
}
class GatherVisitor : GatherVisitorBase<RedundantCastIssue>
{
public GatherVisitor (BaseRefactoringContext ctx)
: base (ctx)
{
}
public override void VisitCastExpression (CastExpression castExpression)
{
base.VisitCastExpression (castExpression);
CheckTypeCast (castExpression, castExpression.Expression, castExpression.StartLocation,
castExpression.Expression.StartLocation);
}
public override void VisitAsExpression (AsExpression asExpression)
{
base.VisitAsExpression (asExpression);
CheckTypeCast (asExpression, asExpression.Expression, asExpression.Expression.EndLocation,
asExpression.EndLocation);
}
IType GetExpectedType (Expression typeCastNode)
{
var memberRefExpr = typeCastNode.Parent as MemberReferenceExpression;
if (memberRefExpr != null) {
var invocationExpr = memberRefExpr.Parent as InvocationExpression;
if (invocationExpr != null && invocationExpr.Target == memberRefExpr) {
var invocationResolveResult = ctx.Resolve (invocationExpr) as InvocationResolveResult;
if (invocationResolveResult != null) {
return invocationResolveResult.Member.DeclaringType;
}
} else {
var memberResolveResult = ctx.Resolve (memberRefExpr) as MemberResolveResult;
if (memberResolveResult != null) {
return memberResolveResult.Member.DeclaringType;
}
}
}
return ctx.GetExpectedType (typeCastNode);
}
bool IsExplicitImplementation(IType exprType, IType interfaceType, Expression typeCastNode)
{
var memberRefExpr = typeCastNode.Parent as MemberReferenceExpression;
if (memberRefExpr != null) {
var rr = ctx.Resolve(memberRefExpr);
var memberResolveResult = rr as MemberResolveResult;
if (memberResolveResult != null) {
foreach (var member in exprType.GetMembers (m => m.SymbolKind == memberResolveResult.Member.SymbolKind)) {
if (member.IsExplicitInterfaceImplementation && member.ImplementedInterfaceMembers.Contains (memberResolveResult.Member)) {
return true;
}
}
}
var methodGroupResolveResult = rr as MethodGroupResolveResult;
if (methodGroupResolveResult != null) {
foreach (var member in exprType.GetMethods ()) {
if (member.IsExplicitInterfaceImplementation && member.ImplementedInterfaceMembers.Any (m => methodGroupResolveResult.Methods.Contains ((IMethod)m))) {
return true;
}
}
}
}
return false;
}
void AddIssue (Expression typeCastNode, Expression expr, TextLocation start, TextLocation end)
{
AddIssue (start, end, ctx.TranslateString ("Remove redundant type cast"),
script => script.Replace (typeCastNode, expr.Clone ()));
}
void CheckTypeCast (Expression typeCastNode, Expression expr, TextLocation castStart, TextLocation castEnd)
{
while (typeCastNode.Parent != null && typeCastNode.Parent is ParenthesizedExpression)
typeCastNode = (Expression)typeCastNode.Parent;
var expectedType = GetExpectedType (typeCastNode);
var exprType = ctx.Resolve (expr).Type;
if (expectedType.Kind == TypeKind.Interface && IsExplicitImplementation (exprType, expectedType, typeCastNode))
return;
if (exprType.GetAllBaseTypes ().Any (t => t.Equals(expectedType)))
AddIssue (typeCastNode, expr, castStart, castEnd);
}
}
}
}
|
