1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242
|
//
// RedundantToStringCallIssue.cs
//
// Author:
// Simon Lindgren <simon.n.lindgren@gmail.com>
//
// Copyright (c) 2012 Simon Lindgren
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System;
using System.Collections.Generic;
using ICSharpCode.NRefactory.TypeSystem;
using ICSharpCode.NRefactory.CSharp.Resolver;
using ICSharpCode.NRefactory.Semantics;
using System.Linq;
using ICSharpCode.NRefactory.TypeSystem.Implementation;
using ICSharpCode.NRefactory.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription("Redundant 'object.ToString()' call",
Description = "Finds calls to ToString() which would be generated automatically by the compiler.",
Category = IssueCategories.Redundancies,
Severity = Severity.Warning,
IssueMarker = IssueMarker.GrayOut,
ResharperDisableKeyword = "RedundantToStringCall")]
public class RedundantToStringCallIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
return new GatherVisitor(context).GetIssues();
}
class GatherVisitor : GatherVisitorBase<RedundantToStringCallIssue>
{
static Tuple<int, int> onlyFirst = Tuple.Create (0, 0);
static IDictionary<Tuple<string, int>, Tuple<int, int>> membersCallingToString = new Dictionary<Tuple<string, int>, Tuple<int, int>> {
{ Tuple.Create("System.IO.TextWriter.Write", 1), onlyFirst },
{ Tuple.Create("System.IO.TextWriter.WriteLine", 1), onlyFirst },
{ Tuple.Create("System.Console.Write", 1), onlyFirst },
{ Tuple.Create("System.Console.WriteLine", 1), onlyFirst }
};
public GatherVisitor (BaseRefactoringContext context) : base (context)
{
binOpVisitor = new BinaryExpressionVisitor (this);
}
HashSet<AstNode> processedNodes = new HashSet<AstNode>();
void CheckExpressionInAutoCallContext(Expression expression)
{
if (expression is InvocationExpression && !processedNodes.Contains(expression)) {
CheckInvocationInAutoCallContext((InvocationExpression)expression);
}
}
void CheckInvocationInAutoCallContext(InvocationExpression invocationExpression)
{
var memberExpression = invocationExpression.Target as MemberReferenceExpression;
if (memberExpression == null) {
return;
}
if (memberExpression.MemberName != "ToString" || invocationExpression.Arguments.Any ()) {
return;
}
var resolveResult = ctx.Resolve(invocationExpression) as CSharpInvocationResolveResult;
if (resolveResult == null) {
return;
}
AddRedundantToStringIssue(memberExpression, invocationExpression);
}
void AddRedundantToStringIssue(MemberReferenceExpression memberExpression, InvocationExpression invocationExpression)
{
// Simon Lindgren 2012-09-14: Previously there was a check here to see if the node had already been processed
// This has been moved out to the callers, to check it earlier for a 30-40% run time reduction
processedNodes.Add(invocationExpression);
AddIssue(memberExpression.DotToken.StartLocation, invocationExpression.RParToken.EndLocation,
ctx.TranslateString("Remove redundant call to ToString()"), script => {
script.Replace(invocationExpression, memberExpression.Target.Clone());
});
}
#region Binary operator
public override void VisitBinaryOperatorExpression(BinaryOperatorExpression binaryOperatorExpression)
{
base.VisitBinaryOperatorExpression(binaryOperatorExpression);
if (binaryOperatorExpression.Operator != BinaryOperatorType.Add)
return;
binOpVisitor.Reset();
binaryOperatorExpression.AcceptVisitor(binOpVisitor);
}
BinaryExpressionVisitor binOpVisitor;
class BinaryExpressionVisitor : DepthFirstAstVisitor
{
GatherVisitor issue;
int stringExpressionCount;
Expression firstStringExpression;
public BinaryExpressionVisitor(GatherVisitor issue)
{
this.issue = issue;
}
public void Reset()
{
stringExpressionCount = 0;
firstStringExpression = null;
}
void Check (Expression expression)
{
if (expression is BinaryOperatorExpression) {
expression.AcceptVisitor(this);
return;
}
if (stringExpressionCount <= 1) {
var resolveResult = issue.ctx.Resolve(expression);
if (resolveResult.Type.IsKnownType(KnownTypeCode.String)) {
stringExpressionCount++;
if (stringExpressionCount == 1) {
firstStringExpression = expression;
} else {
issue.CheckExpressionInAutoCallContext(firstStringExpression);
issue.CheckExpressionInAutoCallContext(expression);
}
}
} else {
issue.CheckExpressionInAutoCallContext(expression);
}
}
public override void VisitBinaryOperatorExpression(BinaryOperatorExpression binaryOperatorExpression)
{
Check(binaryOperatorExpression.Left);
Check(binaryOperatorExpression.Right);
}
}
#endregion
#region Invocation expression
public override void VisitInvocationExpression(InvocationExpression invocationExpression)
{
base.VisitInvocationExpression(invocationExpression);
var target = invocationExpression.Target as MemberReferenceExpression;
var invocationResolveResult = ctx.Resolve(invocationExpression) as CSharpInvocationResolveResult;
if (invocationResolveResult == null) {
return;
}
IMember member = invocationResolveResult.Member;
// "".ToString()
CheckTargetedObject(invocationExpression, invocationResolveResult.TargetResult.Type, member);
// Check list of members that call ToString() automatically
CheckAutomaticToStringCallers(invocationExpression, member);
// Check formatting calls
CheckFormattingCall(invocationExpression, invocationResolveResult);
}
void CheckTargetedObject(InvocationExpression invocationExpression, IType type, IMember member)
{
var memberExpression = invocationExpression.Target as MemberReferenceExpression;
if (memberExpression != null && !processedNodes.Contains(invocationExpression)) {
if (type.IsKnownType(KnownTypeCode.String) && member.Name == "ToString") {
AddRedundantToStringIssue(memberExpression, invocationExpression);
}
}
}
void CheckAutomaticToStringCallers(InvocationExpression invocationExpression, IMember member)
{
if (member.IsOverride) {
member = InheritanceHelper.GetBaseMember(member);
if (member == null) {
return;
}
}
var key = new Tuple<string, int>(member.ReflectionName, invocationExpression.Arguments.Count);
Tuple<int, int> checkInfo;
if (membersCallingToString.TryGetValue(key, out checkInfo)) {
var arguments = invocationExpression.Arguments.ToList();
for (int i = checkInfo.Item1; i < Math.Min(invocationExpression.Arguments.Count, checkInfo.Item2 + 1); ++i) {
CheckExpressionInAutoCallContext(arguments[i]);
}
}
}
void CheckFormattingCall(InvocationExpression invocationExpression, CSharpInvocationResolveResult invocationResolveResult)
{
Expression formatArgument;
IList<Expression> formatArguments;
// Only check parameters that are of type object: String means it is neccessary, others
// means that there is another problem (ie no matching overload of the method).
Func<IParameter, Expression, bool> predicate = (parameter, argument) => {
var type = parameter.Type;
if (type is TypeWithElementType && parameter.IsParams) {
type = ((TypeWithElementType)type).ElementType;
}
var typeDefinition = type.GetDefinition();
if (typeDefinition == null)
return false;
return typeDefinition.IsKnownType(KnownTypeCode.Object);
};
if (FormatStringHelper.TryGetFormattingParameters(invocationResolveResult, invocationExpression,
out formatArgument, out formatArguments, predicate)) {
foreach (var argument in formatArguments) {
CheckExpressionInAutoCallContext(argument);
}
}
}
#endregion
}
}
}
|