1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
|
//
// CallToObjectEqualsViaBaseIssue.cs
//
// Author:
// Simon Lindgren <simon.n.lindgren@gmail.com>
//
// Copyright (c) 2012 Simon Lindgren
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System;
using System.Collections.Generic;
using ICSharpCode.NRefactory.TypeSystem;
using ICSharpCode.NRefactory.Semantics;
using System.Linq;
using ICSharpCode.NRefactory.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription("Call to base.Equals resolves to Object.Equals, which is reference equality",
Description = "Finds potentially erroneous calls to Object.Equals.",
Category = IssueCategories.CodeQualityIssues,
Severity = Severity.Warning,
ResharperDisableKeyword = "BaseObjectEqualsIsObjectEquals")]
public class CallToObjectEqualsViaBaseIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
return new GatherVisitor(context).GetIssues();
}
class GatherVisitor : GatherVisitorBase<CallToObjectEqualsViaBaseIssue>
{
public GatherVisitor(BaseRefactoringContext context) : base (context)
{
}
public override void VisitInvocationExpression(InvocationExpression invocationExpression)
{
base.VisitInvocationExpression(invocationExpression);
if (invocationExpression.Arguments.Count != 1) {
return;
}
var memberExpression = invocationExpression.Target as MemberReferenceExpression;
if (memberExpression == null || memberExpression.MemberName != "Equals" || !(memberExpression.Target is BaseReferenceExpression)) {
return;
}
var resolveResult = ctx.Resolve(invocationExpression) as InvocationResolveResult;
if (resolveResult == null || !resolveResult.Member.DeclaringTypeDefinition.IsKnownType(KnownTypeCode.Object)) {
return;
}
var title = ctx.TranslateString("Call to base.Equals resolves to Object.Equals, which is reference equality");
AddIssue(invocationExpression, title, GetActions(invocationExpression));
}
IEnumerable<CodeAction> GetActions(InvocationExpression invocationExpression)
{
yield return new CodeAction(ctx.TranslateString("Change invocation to call Object.ReferenceEquals"), script => {
var args = Enumerable.Concat(new [] { new ThisReferenceExpression() }, invocationExpression.Arguments.Select(arg => arg.Clone()));
var newInvocation = MakeInvocation("object.ReferenceEquals", args);
script.Replace(invocationExpression, newInvocation);
}, invocationExpression);
yield return new CodeAction(ctx.TranslateString("Remove 'base.'"), script => {
var newInvocation = MakeInvocation("Equals", invocationExpression.Arguments.Select(arg => arg.Clone()));
script.Replace(invocationExpression, newInvocation);
}, invocationExpression);
}
static InvocationExpression MakeInvocation(string memberName, IEnumerable<Expression> unClonedArguments)
{
return new InvocationExpression(new IdentifierExpression(memberName), unClonedArguments);
}
}
}
}
|
