1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
|
//
// DuplicateIfInIfChainIssue.cs
//
// Author:
// Ciprian Khlud <ciprian.mustiata@yahoo.com>
//
// Copyright (c) 2013 Ciprian Khlud
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System.Collections.Generic;
using ICSharpCode.NRefactory.PatternMatching;
using ICSharpCode.NRefactory.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription("Else branch has some redundant if",
Description = "One Else-if was checked before so is not be true",
Category = IssueCategories.CodeQualityIssues,
Severity = Severity.Warning,
IssueMarker = IssueMarker.GrayOut,
ResharperDisableKeyword = "ConditionalTernaryEqualBranch")]
public class DuplicateIfInIfChainIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
{
return new GatherVisitor (context).GetIssues ();
}
class GatherVisitor : GatherVisitorBase<DuplicateIfInIfChainIssue>
{
public GatherVisitor (BaseRefactoringContext ctx)
: base (ctx)
{
}
public override void VisitIfElseStatement(IfElseStatement ifStatement)
{
base.VisitIfElseStatement(ifStatement);
var parentExpression = ifStatement.Parent as IfElseStatement;
//handle only parent sequence
if (parentExpression != null)
return;
var expressions = GetExpressions(ifStatement);
for(var i=0;i<expressions.Count-1;i++) {
for (var j = i+1; j < expressions.Count; j++) {
var leftCondition = expressions[i].Condition;
var rightIf = expressions[j];
var rightCondition = rightIf.Condition;
if (!leftCondition.IsMatch(rightCondition))
continue;
var action = new CodeAction(ctx.TranslateString("Remove redundant expression"),
script => RemoveRedundantIf(script, rightIf),
rightCondition);
AddIssue(rightCondition,
ctx.TranslateString(string.Format("The expression '{0}' is identical in the left branch",
rightCondition)), action);
}
}
}
private static void RemoveRedundantIf(Script script, IfElseStatement expressionRight)
{
var parent = expressionRight.Parent as IfElseStatement;
if(parent==null) { //should never happen!
return;
}
if (expressionRight.FalseStatement.IsNull) {
script.Remove(parent.ElseToken);
script.Remove(parent.FalseStatement);
script.FormatText(parent);
} else {
script.Replace(parent.FalseStatement, expressionRight.FalseStatement.Clone());
}
}
private static List<IfElseStatement> GetExpressions(IfElseStatement expression)
{
var baseExpression = expression;
var falseExpression = baseExpression.FalseStatement as IfElseStatement;
var expressions = new List<IfElseStatement>();
while (falseExpression != null) {
expressions.Add(baseExpression);
baseExpression = falseExpression;
falseExpression = falseExpression.FalseStatement as IfElseStatement;
}
expressions.Add(baseExpression);
return expressions;
}
}
}
}
|
