1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464
|
//
// RedundantAssignmentIssue.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
//
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System.Collections.Generic;
using System.Linq;
using ICSharpCode.NRefactory.CSharp.Resolver;
using ICSharpCode.NRefactory.Semantics;
using ICSharpCode.NRefactory.TypeSystem;
using ICSharpCode.NRefactory.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription("Redundant assignment",
Description = "Value assigned to a variable or parameter is not used in all execution path.",
Category = IssueCategories.CodeQualityIssues,
Severity = Severity.Warning,
IssueMarker = IssueMarker.GrayOut)]
public class RedundantAssignmentIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
{
var unit = context.RootNode as SyntaxTree;
if (unit == null)
return Enumerable.Empty<CodeIssue>();
return new GatherVisitor(context).GetIssues();
}
class GatherVisitor : GatherVisitorBase<RedundantAssignmentIssue>
{
public GatherVisitor(BaseRefactoringContext ctx)
: base(ctx)
{
}
public override void VisitParameterDeclaration(ParameterDeclaration parameterDeclaration)
{
base.VisitParameterDeclaration(parameterDeclaration);
if (parameterDeclaration.ParameterModifier == ParameterModifier.Out ||
parameterDeclaration.ParameterModifier == ParameterModifier.Ref)
return;
var resolveResult = ctx.Resolve(parameterDeclaration) as LocalResolveResult;
BlockStatement rootStatement = null;
if (parameterDeclaration.Parent is MethodDeclaration) {
rootStatement = ((MethodDeclaration)parameterDeclaration.Parent).Body;
} else if (parameterDeclaration.Parent is AnonymousMethodExpression) {
rootStatement = ((AnonymousMethodExpression)parameterDeclaration.Parent).Body;
} else if (parameterDeclaration.Parent is LambdaExpression) {
rootStatement = ((LambdaExpression)parameterDeclaration.Parent).Body as BlockStatement;
}
CollectIssues(parameterDeclaration, rootStatement, resolveResult);
}
public override void VisitVariableInitializer(VariableInitializer variableInitializer)
{
base.VisitVariableInitializer(variableInitializer);
if (!inUsingStatementResourceAcquisition) {
var resolveResult = ctx.Resolve(variableInitializer) as LocalResolveResult;
CollectIssues(variableInitializer, variableInitializer.GetParent<BlockStatement>(), resolveResult);
}
}
bool inUsingStatementResourceAcquisition;
public override void VisitUsingStatement(UsingStatement usingStatement)
{
inUsingStatementResourceAcquisition = true;
usingStatement.ResourceAcquisition.AcceptVisitor(this);
inUsingStatementResourceAcquisition = false;
usingStatement.EmbeddedStatement.AcceptVisitor(this);
}
void CollectIssues(AstNode variableDecl, BlockStatement rootStatement, LocalResolveResult resolveResult)
{
if (rootStatement == null || resolveResult == null)
return;
var references = new HashSet<AstNode>();
var refStatements = new HashSet<Statement>();
var usedInLambda = false;
var results = ctx.FindReferences(rootStatement, resolveResult.Variable);
foreach (var result in results) {
var node = result.Node;
if (node == variableDecl)
continue;
var parent = node.Parent;
while (!(parent == null || parent is Statement || parent is LambdaExpression || parent is QueryExpression))
parent = parent.Parent;
if (parent == null)
continue;
var statement = parent as Statement;
if (statement != null) {
references.Add(node);
refStatements.Add(statement);
}
while (parent != null && parent != rootStatement) {
if (parent is LambdaExpression || parent is AnonymousMethodExpression || parent is QueryExpression) {
usedInLambda = true;
break;
}
parent = parent.Parent;
}
if (usedInLambda) {
break;
}
}
// stop analyzing if the variable is used in any lambda expression or anonymous method
if (usedInLambda)
return;
var startNode = new VariableReferenceGraphBuilder(ctx).Build(rootStatement, references, refStatements, ctx);
var variableInitializer = variableDecl as VariableInitializer;
if (variableInitializer != null && !variableInitializer.Initializer.IsNull)
startNode.References.Insert(0, variableInitializer);
ProcessNodes(startNode);
}
class SearchInvocationsVisitor : DepthFirstAstVisitor
{
bool foundInvocations;
public bool ContainsInvocations(AstNode node)
{
foundInvocations = false;
node.AcceptVisitor(this);
return foundInvocations;
}
protected override void VisitChildren(AstNode node)
{
AstNode next;
for (var child = node.FirstChild; child != null && !foundInvocations; child = next) {
next = child.NextSibling;
child.AcceptVisitor(this);
}
}
public override void VisitInvocationExpression(InvocationExpression invocationExpression)
{
foundInvocations = true;
}
}
private class SearchRefOrOutVisitor : DepthFirstAstVisitor
{
private bool foundInvocations;
private string _varName;
public bool ContainsRefOrOut(VariableInitializer variableInitializer)
{
var node = variableInitializer.Parent.Parent;
foundInvocations = false;
_varName = variableInitializer.Name;
node.AcceptVisitor(this);
return foundInvocations;
}
protected override void VisitChildren(AstNode node)
{
AstNode next;
for (var child = node.FirstChild; child != null && !foundInvocations; child = next) {
next = child.NextSibling;
child.AcceptVisitor(this);
}
}
public override void VisitInvocationExpression(InvocationExpression methodDeclaration)
{
if (foundInvocations)
return;
if (methodDeclaration.Arguments.Count == 0)
return;
foreach (var argument in methodDeclaration.Arguments) {
var directionExpression = argument as DirectionExpression;
if (directionExpression == null)
continue;
if (directionExpression.FieldDirection != FieldDirection.Out && directionExpression.FieldDirection != FieldDirection.Ref)
continue;
var idExpression = (directionExpression.Expression) as IdentifierExpression;
if (idExpression == null)
continue;
foundInvocations = (idExpression.Identifier == _varName);
foundInvocations = true;
}
}
}
class SearchAssignmentForVarVisitor : DepthFirstAstVisitor
{
bool _foundInvocations;
private VariableInitializer _variableInitializer;
public bool ContainsLaterAssignments(VariableInitializer variableInitializer)
{
_foundInvocations = false;
_variableInitializer = variableInitializer;
variableInitializer.Parent.Parent.AcceptVisitor(this);
return _foundInvocations;
}
protected override void VisitChildren(AstNode node)
{
AstNode next;
for (var child = node.FirstChild; child != null && !_foundInvocations; child = next) {
next = child.NextSibling;
child.AcceptVisitor(this);
}
}
public override void VisitAssignmentExpression(AssignmentExpression assignmentExpression)
{
if (_foundInvocations)
return;
base.VisitAssignmentExpression(assignmentExpression);
if (assignmentExpression.Left.ToString() == _variableInitializer.Name
&& assignmentExpression.StartLocation > _variableInitializer.StartLocation) {
_foundInvocations = true;
}
}
}
void AddIssue(AstNode node)
{
var title = ctx.TranslateString("Remove redundant assignment");
var variableInitializer = node as VariableInitializer;
if (variableInitializer != null) {
var containsInvocations =
new SearchInvocationsVisitor().ContainsInvocations(variableInitializer.Initializer);
var varDecl = node.Parent as VariableDeclarationStatement;
var isDeclareStatement = varDecl != null;
var isUsingVar = isDeclareStatement && varDecl.Type.IsVar();
var expressionType = ctx.Resolve(node).Type;
var containsLaterAssignments = false;
if (isDeclareStatement) {
//if it is used later, the redundant removal should remove the assignment
//but not the variable
containsLaterAssignments =
new SearchAssignmentForVarVisitor().ContainsLaterAssignments(variableInitializer);
}
AstNode grayOutNode;
var containsRefOrOut = new SearchRefOrOutVisitor().ContainsRefOrOut(variableInitializer);
if (containsInvocations && isDeclareStatement) {
grayOutNode = variableInitializer.AssignToken;
} else {
if (isDeclareStatement && !containsRefOrOut && !containsLaterAssignments) {
grayOutNode = variableInitializer.Parent;
} else {
grayOutNode = variableInitializer.Initializer;
}
}
AddIssue(grayOutNode, title, script => {
var variableNode = (VariableInitializer)node;
if (containsInvocations && isDeclareStatement) {
//add the column ';' that will be removed after the next line replacement
var expression = (Expression)variableNode.Initializer.Clone();
var invocation = new ExpressionStatement(expression);
if (containsLaterAssignments && varDecl != null) {
var clonedDefinition = (VariableDeclarationStatement)varDecl.Clone();
var shortExpressionType = CreateShortType(ctx, expressionType, node);
clonedDefinition.Type = shortExpressionType;
var variableNodeClone = clonedDefinition.GetVariable(variableNode.Name);
variableNodeClone.Initializer = null;
script.InsertBefore(node.Parent, clonedDefinition);
}
script.Replace(node.Parent, invocation);
return;
}
if (isDeclareStatement && !containsRefOrOut && !containsLaterAssignments) {
script.Remove(node.Parent);
return;
}
var replacement = (VariableInitializer)variableNode.Clone();
replacement.Initializer = Expression.Null;
if (isUsingVar) {
var shortExpressionType = CreateShortType(ctx, expressionType, node);
script.Replace(varDecl.Type, shortExpressionType);
}
script.Replace(node, replacement);
});
}
var assignmentExpr = node.Parent as AssignmentExpression;
if (assignmentExpr == null)
return;
if (assignmentExpr.Parent is ExpressionStatement) {
AddIssue(assignmentExpr.Parent, title, script => script.Remove(assignmentExpr.Parent));
} else {
AddIssue(assignmentExpr.Left.StartLocation, assignmentExpr.OperatorToken.EndLocation, title,
script => script.Replace(assignmentExpr, assignmentExpr.Right.Clone()));
}
}
private static AstType CreateShortType(BaseRefactoringContext refactoringContext, IType expressionType, AstNode node)
{
var csResolver = refactoringContext.Resolver.GetResolverStateBefore(node);
var builder = new TypeSystemAstBuilder(csResolver);
return builder.ConvertType(expressionType);
}
static bool IsAssignment(AstNode node)
{
if (node is VariableInitializer)
return true;
var assignmentExpr = node.Parent as AssignmentExpression;
if (assignmentExpr != null)
return assignmentExpr.Left == node && assignmentExpr.Operator == AssignmentOperatorType.Assign;
var direction = node.Parent as DirectionExpression;
if (direction != null)
return direction.FieldDirection == FieldDirection.Out && direction.Expression == node;
return false;
}
static bool IsInsideTryBlock(AstNode node)
{
var tryCatchStatement = node.GetParent<TryCatchStatement>();
if (tryCatchStatement == null)
return false;
return tryCatchStatement.TryBlock.Contains(node.StartLocation.Line, node.StartLocation.Column);
}
enum NodeState
{
None,
UsageReachable,
UsageUnreachable,
Processing,
}
void ProcessNodes(VariableReferenceNode startNode)
{
// node state of a node indicates whether it is possible for an upstream node to reach any usage via
// the node
var nodeStates = new Dictionary<VariableReferenceNode, NodeState>();
var assignments = new List<VariableReferenceNode>();
// dfs to preprocess all nodes and find nodes which end with assignment
var stack = new Stack<VariableReferenceNode>();
stack.Push(startNode);
while (stack.Count > 0) {
var node = stack.Pop();
if (node.References.Count > 0) {
nodeStates [node] = IsAssignment(node.References [0]) ?
NodeState.UsageUnreachable : NodeState.UsageReachable;
} else {
nodeStates [node] = NodeState.None;
}
// find indices of all assignments in node.References
var assignmentIndices = new List<int>();
for (int i = 0; i < node.References.Count; i++) {
if (IsAssignment(node.References [i]))
assignmentIndices.Add(i);
}
// for two consecutive assignments, the first one is redundant
for (int i = 0; i < assignmentIndices.Count - 1; i++) {
var index1 = assignmentIndices [i];
var index2 = assignmentIndices [i + 1];
if (index1 + 1 == index2)
AddIssue(node.References [index1]);
}
// if the node ends with an assignment, add it to assignments so as to check if it is redundant
// later
if (assignmentIndices.Count > 0 &&
assignmentIndices [assignmentIndices.Count - 1] == node.References.Count - 1)
assignments.Add(node);
foreach (var nextNode in node.NextNodes) {
if (!nodeStates.ContainsKey(nextNode))
stack.Push(nextNode);
}
}
foreach (var node in assignments) {
// we do not analyze an assignment inside a try block as it can jump to any catch block or finally block
if (IsInsideTryBlock(node.References [0]))
continue;
ProcessNode(node, true, nodeStates);
}
}
void ProcessNode(VariableReferenceNode node, bool addIssue,
IDictionary<VariableReferenceNode, NodeState> nodeStates)
{
if (nodeStates [node] == NodeState.None)
nodeStates [node] = NodeState.Processing;
bool? reachable = false;
foreach (var nextNode in node.NextNodes) {
if (nodeStates [nextNode] == NodeState.None)
ProcessNode(nextNode, false, nodeStates);
if (nodeStates [nextNode] == NodeState.UsageReachable) {
reachable = true;
break;
}
// downstream nodes are not fully processed (e.g. due to loop), there is no enough info to
// determine the node state
if (nodeStates [nextNode] != NodeState.UsageUnreachable)
reachable = null;
}
// add issue if it is not possible to reach any usage via NextNodes
if (addIssue && reachable == false)
AddIssue(node.References [node.References.Count - 1]);
if (nodeStates [node] != NodeState.Processing)
return;
switch (reachable) {
case null:
nodeStates [node] = NodeState.None;
break;
case true:
nodeStates [node] = NodeState.UsageReachable;
break;
case false:
nodeStates [node] = NodeState.UsageUnreachable;
break;
}
}
}
}
}
|