1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
|
//
// RedundantObjectCreationArgumentListIssue.cs
//
// Author:
// Mansheng Yang <lightyang0@gmail.com>
//
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.
using System.Collections.Generic;
using ICSharpCode.NRefactory.Refactoring;
namespace ICSharpCode.NRefactory.CSharp.Refactoring
{
[IssueDescription ("Redundant empty argument list on object creation expression",
Description = "When object creation uses object or collection initializer, empty argument list is redundant.",
Category = IssueCategories.Redundancies,
Severity = Severity.Suggestion,
IssueMarker = IssueMarker.GrayOut,
ResharperDisableKeyword = "RedundantEmptyObjectCreationArgumentList")]
public class RedundantObjectCreationArgumentListIssue : ICodeIssueProvider
{
public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
{
return new GatherVisitor (context).GetIssues ();
}
class GatherVisitor : GatherVisitorBase<RedundantObjectCreationArgumentListIssue>
{
public GatherVisitor( BaseRefactoringContext ctx)
: base (ctx)
{
}
public override void VisitObjectCreateExpression (ObjectCreateExpression objectCreateExpression)
{
base.VisitObjectCreateExpression (objectCreateExpression);
if (objectCreateExpression.Initializer.IsNull ||
objectCreateExpression.Arguments.Count > 0 ||
objectCreateExpression.LParToken.IsNull)
return;
AddIssue (objectCreateExpression.LParToken.StartLocation, objectCreateExpression.RParToken.EndLocation,
ctx.TranslateString ("Remove redundant empty argument list"), script => {
var l1 = objectCreateExpression.LParToken.GetPrevNode ().EndLocation;
var l2 = objectCreateExpression.RParToken.GetNextNode ().StartLocation;
var o1 = script.GetCurrentOffset (l1);
var o2 = script.GetCurrentOffset (l2);
script.Replace (o1, o2 - o1, " ");
});
}
}
}
}
|
