1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
|
////////////////////////////////////////////////////////////////////////
//
// Copyright (C) 1996-2021 The Octave Project Developers
//
// See the file COPYRIGHT.md in the top-level directory of this
// distribution or <https://octave.org/copyright/>.
//
// This file is part of Octave.
//
// Octave is free software: you can redistribute it and/or modify it
// under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Octave is distributed in the hope that it will be useful, but
// WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Octave; see the file COPYING. If not, see
// <https://www.gnu.org/licenses/>.
//
////////////////////////////////////////////////////////////////////////
#if defined (HAVE_CONFIG_H)
# include "config.h"
#endif
#include "error.h"
#include "interpreter.h"
#include "ov.h"
#include "profiler.h"
#include "pt-binop.h"
#include "pt-eval.h"
#include "variables.h"
namespace octave
{
// Binary expressions.
void
tree_binary_expression::matlab_style_short_circuit_warning (const char *op)
{
warning_with_id ("Octave:possible-matlab-short-circuit-operator",
"Matlab-style short-circuit operation performed for operator %s",
op);
m_braindead_shortcircuit_warning_issued = true;
}
std::string
tree_binary_expression::oper (void) const
{
return octave_value::binary_op_as_string (m_etype);
}
tree_expression *
tree_binary_expression::dup (symbol_scope& scope) const
{
tree_binary_expression *new_be
= new tree_binary_expression (m_lhs ? m_lhs->dup (scope) : nullptr,
m_rhs ? m_rhs->dup (scope) : nullptr,
line (), column (), m_etype);
new_be->copy_base (*this);
return new_be;
}
octave_value
tree_binary_expression::evaluate (tree_evaluator& tw, int)
{
octave_value val;
if (is_eligible_for_braindead_shortcircuit ())
{
if (m_lhs)
{
octave_value a = m_lhs->evaluate (tw);
if (a.ndims () == 2 && a.rows () == 1 && a.columns () == 1)
{
bool result = false;
bool a_true = a.is_true ();
if (a_true)
{
if (m_etype == octave_value::op_el_or)
{
matlab_style_short_circuit_warning ("|");
return octave_value (true);
}
}
else
{
if (m_etype == octave_value::op_el_and)
{
matlab_style_short_circuit_warning ("&");
return octave_value (false);
}
}
if (m_rhs)
{
octave_value b = m_rhs->evaluate (tw);
result = b.is_true ();
}
return octave_value (result);
}
}
}
if (m_lhs)
{
octave_value a = m_lhs->evaluate (tw);
if (a.is_defined () && m_rhs)
{
octave_value b = m_rhs->evaluate (tw);
if (b.is_defined ())
{
profiler::enter<tree_binary_expression>
block (tw.get_profiler (), *this);
// Note: The profiler does not catch the braindead
// short-circuit evaluation code above, but that should be
// ok. The evaluation of operands and the operator itself
// is entangled and it's not clear where to start/stop
// timing the operator to make it reasonable.
interpreter& interp = tw.get_interpreter ();
type_info& ti = interp.get_type_info ();
val = ::do_binary_op (ti, m_etype, a, b);
}
}
}
return val;
}
// Boolean expressions.
std::string
tree_boolean_expression::oper (void) const
{
std::string retval = "<unknown>";
switch (m_etype)
{
case bool_and:
retval = "&&";
break;
case bool_or:
retval = "||";
break;
default:
break;
}
return retval;
}
tree_expression *
tree_boolean_expression::dup (symbol_scope& scope) const
{
tree_boolean_expression *new_be
= new tree_boolean_expression (m_lhs ? m_lhs->dup (scope) : nullptr,
m_rhs ? m_rhs->dup (scope) : nullptr,
line (), column (), m_etype);
new_be->copy_base (*this);
return new_be;
}
octave_value
tree_boolean_expression::evaluate (tree_evaluator& tw, int)
{
octave_value val;
bool result = false;
// This evaluation is not caught by the profiler, since we can't find
// a reasonable place where to time. Note that we don't want to
// include evaluation of LHS or RHS into the timing, but this is
// entangled together with short-circuit evaluation here.
if (m_lhs)
{
octave_value a = m_lhs->evaluate (tw);
bool a_true = a.is_true ();
if (a_true)
{
if (m_etype == tree_boolean_expression::bool_or)
return octave_value (true);
}
else
{
if (m_etype == tree_boolean_expression::bool_and)
return octave_value (false);
}
if (m_rhs)
{
octave_value b = m_rhs->evaluate (tw);
result = b.is_true ();
}
val = octave_value (result);
}
return val;
}
}
|
