1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
|
# -*- coding: utf-8 -*-
from ast import literal_eval
from unittest.mock import patch
from odoo.addons.account.tests.common import AccountTestInvoicingCommon
from odoo.addons.account.models.account_payment_method import AccountPaymentMethod
from odoo.addons.mail.tests.common import MailCommon
from odoo.tests import Form, tagged
from odoo.exceptions import UserError, ValidationError
@tagged('post_install', '-at_install')
class TestAccountJournal(AccountTestInvoicingCommon):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.other_currency = cls.setup_other_currency('EUR')
cls.company_data_2 = cls.setup_other_company()
def test_constraint_currency_consistency_with_accounts(self):
''' The accounts linked to a bank/cash journal must share the same foreign currency
if specified.
'''
journal_bank = self.company_data['default_journal_bank']
journal_bank.currency_id = self.other_currency
# Try to set a different currency on the 'debit' account.
with self.assertRaises(ValidationError), self.cr.savepoint():
journal_bank.default_account_id.currency_id = self.company_data['currency']
def test_changing_journal_company(self):
''' Ensure you can't change the company of an account.journal if there are some journal entries '''
self.company_data['default_journal_sale'].code = "DIFFERENT"
self.env['account.move'].create({
'move_type': 'entry',
'date': '2019-01-01',
'journal_id': self.company_data['default_journal_sale'].id,
})
with self.assertRaisesRegex(UserError, "entries linked to it"), self.cr.savepoint():
self.company_data['default_journal_sale'].company_id = self.company_data_2['company']
def test_account_control_create_journal_entry(self):
move_vals = {
'line_ids': [
(0, 0, {
'name': 'debit',
'account_id': self.company_data['default_account_revenue'].id,
'debit': 100.0,
'credit': 0.0,
}),
(0, 0, {
'name': 'credit',
'account_id': self.company_data['default_account_expense'].id,
'debit': 0.0,
'credit': 100.0,
}),
],
}
# Should fail because 'default_account_expense' is not allowed.
self.company_data['default_journal_misc'].account_control_ids |= self.company_data['default_account_revenue']
with self.assertRaises(UserError), self.cr.savepoint():
self.env['account.move'].create(move_vals)
# Should be allowed because both accounts are accepted.
self.company_data['default_journal_misc'].account_control_ids |= self.company_data['default_account_expense']
self.env['account.move'].create(move_vals)
def test_account_control_existing_journal_entry(self):
self.env['account.move'].create({
'line_ids': [
(0, 0, {
'name': 'debit',
'account_id': self.company_data['default_account_revenue'].id,
'debit': 100.0,
'credit': 0.0,
}),
(0, 0, {
'name': 'credit',
'account_id': self.company_data['default_account_expense'].id,
'debit': 0.0,
'credit': 100.0,
}),
],
})
# There is already an other line using the 'default_account_expense' account.
with self.assertRaises(ValidationError), self.cr.savepoint():
self.company_data['default_journal_misc'].account_control_ids |= self.company_data['default_account_revenue']
# Assigning both should be allowed
self.company_data['default_journal_misc'].account_control_ids = \
self.company_data['default_account_revenue'] + self.company_data['default_account_expense']
def test_account_journal_add_new_payment_method_multi(self):
"""
Test the automatic creation of payment method lines with the mode set to multi
"""
Method_get_payment_method_information = AccountPaymentMethod._get_payment_method_information
def _get_payment_method_information(self):
res = Method_get_payment_method_information(self)
res['multi'] = {'mode': 'multi', 'type': ('bank',)}
return res
with patch.object(AccountPaymentMethod, '_get_payment_method_information', _get_payment_method_information):
self.env['account.payment.method'].sudo().create({
'name': 'Multi method',
'code': 'multi',
'payment_type': 'inbound'
})
journals = self.env['account.journal'].search([('inbound_payment_method_line_ids.code', '=', 'multi')])
# The two bank journals have been set
self.assertEqual(len(journals), 2)
def test_remove_payment_method_lines(self):
"""
Payment method lines are a bit special in the way their removal is handled.
If they are linked to a payment at the moment of the deletion, they won't be deleted but the journal_id will be
set to False.
If they are not linked to any payment, they will be deleted as expected.
"""
# Linked to a payment. It will not be deleted, but its journal_id will be set to False.
first_method = self.inbound_payment_method_line
self.env['account.payment'].create({
'amount': 100.0,
'payment_type': 'inbound',
'partner_type': 'customer',
'payment_method_line_id': first_method.id,
})
first_method.unlink()
self.assertFalse(first_method.journal_id)
# Not linked to anything. It will be deleted.
second_method = self.outbound_payment_method_line
second_method.unlink()
self.assertFalse(second_method.exists())
def test_account_journal_duplicates(self):
new_journals = self.env["account.journal"].with_context(import_file=True).create([
{"name": "OD_BLABLA"},
{"name": "OD_BLABLU"},
])
self.assertEqual(sorted(new_journals.mapped("code")), ["GEN1", "OD_BL"], "The journals should be set correctly")
def test_archive_used_journal(self):
journal = self.env['account.journal'].create({
'name': 'Test Journal',
'type': 'sale',
'code': 'A',
})
check_method = self.env['account.payment.method'].sudo().create({
'name': 'Test',
'code': 'check_printing_expense_test',
'payment_type': 'outbound',
})
self.env['account.payment.method.line'].create({
'name': 'Check',
'payment_method_id': check_method.id,
'journal_id': journal.id
})
with self.assertRaises(ValidationError):
journal.action_archive()
def test_archive_multiple_journals(self):
journals = self.env['account.journal'].create([{
'name': 'Test Journal 1',
'type': 'sale',
'code': 'A1'
}, {
'name': 'Test Journal 2',
'type': 'sale',
'code': 'A2'
}])
# Archive the Journals
journals.action_archive()
self.assertFalse(journals[0].active)
self.assertFalse(journals[1].active)
# Unarchive the Journals
journals.action_unarchive()
self.assertTrue(journals[0].active)
self.assertTrue(journals[1].active)
@tagged('post_install', '-at_install', 'mail_alias')
class TestAccountJournalAlias(AccountTestInvoicingCommon, MailCommon):
@classmethod
def setUpClass(cls):
super().setUpClass()
cls.company_data_2 = cls.setup_other_company()
def test_alias_name_creation(self):
""" Test alias creation, notably avoid raising constraints due to ascii
characters removal. See odoo/odoo@339cdffb68f91eb1455d447d1bdd7133c68723bd """
# check base test data
journal1 = self.company_data['default_journal_purchase']
company1 = journal1.company_id
journal2 = self.company_data_2['default_journal_sale']
company2 = journal2.company_id
# have a non ascii company name
company2.name = 'ぁ'
for (aname, jname, jcode, jtype, jcompany), expected_alias_name in zip(
[
('youpie', 'Journal Name', 'NEW1', 'purchase', company1),
(False, 'Journal Other Name', 'NEW2', 'purchase', company1),
(False, 'ぁ', 'NEW3', 'purchase', company1),
(False, 'ぁ', 'ぁ', 'purchase', company1),
('youpie', 'Journal Name', 'NEW1', 'purchase', company2),
(False, 'Journal Other Name', 'NEW2', 'purchase', company2),
(False, 'ぁ', 'NEW3', 'purchase', company2),
(False, 'ぁ', 'ぁ', 'purchase', company2),
],
[
f'youpie-{company1.name}',
f'journal-other-name-{company1.name}',
f'new3-{company1.name}',
f'purchase-{company1.name}',
f'youpie-{company2.id}',
f'journal-other-name-{company2.id}',
f'new3-{company2.id}',
f'purchase-{company2.id}',
]
):
with self.subTest(aname=aname, jname=jname, jcode=jcode, jtype=jtype, jcompany=jcompany):
new_journal = self.env['account.journal'].create({
'code': jcode,
'company_id': jcompany.id,
'name': jname,
'type': jtype,
# force alias_name only if given, to check default value otherwise
**({'alias_name': aname} if aname else {}),
})
self.assertEqual(new_journal.alias_name, expected_alias_name)
# other types: no mail support by default
journals = self.env['account.journal'].create([{
'code': f'NEW{jtype}',
'name': f'Type {jtype}',
'type': jtype}
for jtype in ('general', 'cash', 'bank')
])
self.assertFalse(journals.alias_id, 'Do not create useless aliases')
self.assertFalse(list(filter(None, journals.mapped('alias_name'))))
def test_alias_name_form(self):
""" Test alias name update using Form tool (onchange) """
journal = Form(self.env['account.journal'])
journal.name = 'Test With Form'
self.assertFalse(journal.alias_name)
journal.type = 'sale'
self.assertEqual(journal.alias_name, f'test-with-form-{self.env.company.name}')
journal.type = 'cash'
self.assertFalse(journal.alias_name)
def test_alias_from_type(self):
""" Test alias behavior on journal, especially alias_name management as
well as defaults update, see odoo/odoo@400b6860271a11b9914166ff7e42939c4c6192dc """
journal = self.company_data['default_journal_purchase']
# assert base test data
company_name = 'company_1_data'
journal_code = 'BILL'
journal_name = 'Vendor Bills'
journal_alias = journal.alias_id
self.assertEqual(journal.code, journal_code)
self.assertEqual(journal.company_id.name, company_name)
self.assertEqual(journal.name, journal_name)
self.assertEqual(journal.type, 'purchase')
# assert default creation data
self.assertEqual(journal_alias.alias_contact, 'everyone')
self.assertDictEqual(
dict(literal_eval(journal_alias.alias_defaults)),
{
'move_type': 'in_invoice',
'company_id': journal.company_id.id,
'journal_id': journal.id,
}
)
self.assertFalse(journal_alias.alias_force_thread_id, 'Journal alias should create new moves')
self.assertEqual(journal_alias.alias_model_id, self.env['ir.model']._get('account.move'),
'Journal alias targets moves')
self.assertEqual(journal_alias.alias_name, f'vendor-bills-{company_name}')
self.assertEqual(journal_alias.alias_parent_model_id, self.env['ir.model']._get('account.journal'),
'Journal alias owned by journal itself')
self.assertEqual(journal_alias.alias_parent_thread_id, journal.id,
'Journal alias owned by journal itself')
# update alias_name, ensure a fallback on a real name when not explicit reset
for alias_name, expected in [
(False, False),
('', False),
(' ', f'vendor-bills-{company_name}'), # error recuperation
('.', f'vendor-bills-{company_name}'), # error recuperation
('😊', f'vendor-bills-{company_name}'), # resets, unicode not supported
('ぁ', f'vendor-bills-{company_name}'), # resets, non ascii not supported
('Youpie Boum', 'youpie-boum'),
]:
with self.subTest(alias_name=alias_name):
journal.write({'alias_name': alias_name})
self.assertEqual(journal.alias_name, expected)
self.assertEqual(journal_alias.alias_name, expected)
# changing type should void if not purchase or sale
for jtype in ('general', 'cash', 'bank'):
journal.write({'type': jtype})
self.assertEqual(journal.alias_id, journal_alias,
'Dà not unlink aliases, just reset their value')
self.assertFalse(journal.alias_name)
self.assertFalse(journal_alias.alias_name)
# changing type should reset if sale or purchase
journal.company_id.write({'name': 'New Company Name'})
journal.write({'name': 'Reset Journal', 'type': 'sale'})
journal_alias_2 = journal.alias_id
self.assertEqual(journal_alias_2.alias_contact, 'everyone')
self.assertDictEqual(
dict(literal_eval(journal_alias_2.alias_defaults)),
{
'move_type': 'out_invoice',
'company_id': journal.company_id.id,
'journal_id': journal.id,
}
)
self.assertFalse(journal_alias_2.alias_force_thread_id, 'Journal alias should create new moves')
self.assertEqual(journal_alias_2.alias_model_id, self.env['ir.model']._get('account.move'),
'Journal alias targets moves')
self.assertEqual(journal_alias_2.alias_name, 'reset-journal-new-company-name')
self.assertEqual(journal_alias_2.alias_parent_model_id, self.env['ir.model']._get('account.journal'),
'Journal alias owned by journal itself')
self.assertEqual(journal_alias_2.alias_parent_thread_id, journal.id,
'Journal alias owned by journal itself')
def test_alias_create_unique(self):
""" Make auto-generated alias_name unique when needed """
company_name = self.company_data['company'].name
journal = self.env['account.journal'].create({
'name': 'Test Journal',
'type': 'sale',
'code': 'A',
})
journal2 = self.env['account.journal'].create({
'name': 'Test Journal',
'type': 'sale',
'code': 'B',
})
self.assertEqual(journal.alias_name, f'test-journal-{company_name}')
self.assertEqual(journal2.alias_name, f'test-journal-{company_name}-b')
|