1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
/*
* Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8251544
* @summary A dead data loop in dying code is not correctly removed resulting in unremovable data nodes.
* @requires vm.compiler2.enabled
* @library /test/lib /
* @modules java.base/jdk.internal.misc
* java.management
* java.base/jdk.internal.access
* java.base/jdk.internal.reflect
*
* @build jdk.test.whitebox.WhiteBox
* @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
* @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -XX:-TieredCompilation -Xbatch
* compiler.c2.TestDeadDataLoopIGVN
*/
package compiler.c2;
import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.List;
import java.util.LinkedList;
import java.util.ArrayList;
import java.util.Vector;
import java.util.ListIterator;
import jdk.internal.access.SharedSecrets;
import jdk.internal.misc.Unsafe;
import jdk.internal.reflect.ConstantPool;
import java.net.URL;
import java.net.URLClassLoader;
import java.lang.reflect.Executable;
import compiler.whitebox.CompilerWhiteBoxTest;
import jdk.test.whitebox.WhiteBox;
public class TestDeadDataLoopIGVN {
private static final WhiteBox WB = WhiteBox.getWhiteBox();
private static final int TIERED_STOP_AT_LEVEL = WB.getIntxVMFlag("TieredStopAtLevel").intValue();
private static final Unsafe UNSAFE = Unsafe.getUnsafe();
// The original test only failed with CTW due to different inlining and virtual call decisions compared to an
// execution with -Xcomp. This test adapts the behavior of CTW and compiles the methods with the Whitebox API
// in order to reproduce the bug.
public static void main(String[] strArr) throws Exception {
// Required to get the same inlining/virtual call decisions as for CTW
callSomeMethods(new ArrayList<String>());
callSomeMethods(new Vector<String>());
if (TIERED_STOP_AT_LEVEL != CompilerWhiteBoxTest.COMP_LEVEL_FULL_OPTIMIZATION) {
throw new RuntimeException("Sanity check if C2 is available");
}
// To trigger the assertion, we only need to compile Test
compileClass(Test.class);
}
private static void callSomeMethods(List<String> list) {
list.add("bla");
list.add("foo");
ListIterator<String> it = list.listIterator();
it.hasNext();
for (String s : list) {
s.charAt(0);
}
}
// Adaptation from CTW to compile and deoptimize the same methods
private static void compileClass(Class<?> aClass) throws Exception {
aClass = Class.forName(aClass.getCanonicalName(), true, aClass.getClassLoader());
ConstantPool constantPool = SharedSecrets.getJavaLangAccess().getConstantPool(aClass);
preloadClasses(constantPool);
UNSAFE.ensureClassInitialized(aClass);
WB.enqueueInitializerForCompilation(aClass, 4); // Level 4 for C2
for (Executable method : aClass.getDeclaredConstructors()) {
WB.deoptimizeMethod(method);
WB.enqueueMethodForCompilation(method, 4);
WB.deoptimizeMethod(method);
}
for (Executable method : aClass.getDeclaredMethods()) {
WB.deoptimizeMethod(method);
WB.enqueueMethodForCompilation(method, 4);
WB.deoptimizeMethod(method);
}
}
private static void preloadClasses(ConstantPool constantPool) throws Exception {
for (int i = 0, n = constantPool.getSize(); i < n; ++i) {
try {
constantPool.getClassAt(i);
} catch (IllegalArgumentException ignore) {
}
}
}
}
// The actual class that failed by executing it with CTW
class Test {
public static A a = new A();
Test() {
LinkedList<A> l = new LinkedList<A>();
for (int i = 0; i < 34; i++) {
A instance = new A();
instance.id = i;
l.add(instance);
}
test(l, 34);
}
public void test(LinkedList<A> list, int max) {
Integer[] numbers = new Integer[max + 1];
A[] numbers2 = new A[max + 1];
int n = 0;
ListIterator<A> it = list.listIterator();
while (it.hasNext()) {
A b = it.next();
numbers[b.get()] = n;
numbers2[n] = b;
n++;
}
Integer[] iArr = new Integer[max + 1];
A a = getA();
Integer x = numbers[a.get()];
iArr[x] = x;
boolean flag = true;
while (flag) {
flag = false;
it = list.listIterator(34);
while (it.hasPrevious()) {
A b = it.previous();
if (b == a) {
continue;
}
}
}
HashMap<A, A> map = new HashMap<A, A>();
for (Integer i = 0; i < max - 34; i++) {
map.put(numbers2[i], numbers2[iArr[i]]);
}
}
public A getA() {
return a;
}
}
// Helper class
class A {
int id;
public int get() {
return id;
}
}
|
