1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262
|
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8244146
* @summary Verify expected strictfp warnings are producted or not produced
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* @build toolbox.ToolBox toolbox.JavacTask toolbox.TestRunner
* @run main UnneededStrictfpWarningToolBox
*/
import java.io.IOException;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Arrays;
import java.util.List;
import java.io.InputStream;
import java.nio.file.Files;
import java.util.EnumSet;
import javax.tools.JavaFileManager;
import javax.tools.JavaFileObject;
import javax.tools.StandardLocation;
import javax.tools.ToolProvider;
import toolbox.JavacTask;
import toolbox.Task;
import toolbox.Task.Expect;
import toolbox.TestRunner;
import toolbox.ToolBox;
public class UnneededStrictfpWarningToolBox extends TestRunner {
private final ToolBox tb = new ToolBox();
private final String fileSep = System.getProperty("file.separator");
public UnneededStrictfpWarningToolBox() {
super(System.err);
}
public static void main(String... args) throws Exception {
new UnneededStrictfpWarningToolBox().runTests();
}
private void checkLog(List<String> log, List<String> expected) {
if (!expected.equals(log)) {
throw new AssertionError("Unexpected output: " + log);
}
}
private void checkEmptyLog(List<String> log) {
checkLog(log, List.of(""));
}
@Test
public void testWithAndWithOutLint(Path base) throws IOException {
Path src = base.resolve("src");
tb.writeJavaFiles(src, UNNEEDED_STRICTFP_WARNING1_NO_SUPPRESSION);
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log;
// Warning not enabled, no messages expected
log = new JavacTask(tb)
.options("--release", "16", "-Werror")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
checkEmptyLog(log);
// Warning not enabled, no messages expected
log = new JavacTask(tb)
.options("-Xlint:-strictfp", "-Werror")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
checkEmptyLog(log);
// Warning enabled, 5 messages expected
log = new JavacTask(tb)
.options("-XDrawDiagnostics")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
var expected = List.of("UnneededStrictfpWarning1.java:1:17: compiler.warn.strictfp",
"UnneededStrictfpWarning1.java:10:10: compiler.warn.strictfp",
"UnneededStrictfpWarning1.java:12:29: compiler.warn.strictfp",
"UnneededStrictfpWarning1.java:16:28: compiler.warn.strictfp",
"UnneededStrictfpWarning1.java:18:21: compiler.warn.strictfp",
"5 warnings");
checkLog(log, expected);
}
@Test
public void testTopLevelSuppression(Path base) throws IOException {
Path src = base.resolve("src");
tb.writeJavaFiles(src, UNNEEDED_STRICTFP_WARNING2_TOP_LEVEL_SUPPRESSION);
Path classes = base.resolve("classes");
tb.createDirectories(classes);
List<String> log;
// Warning implicitly enabled, no messages expected
log = new JavacTask(tb)
.options("-Werror")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
checkEmptyLog(log);
// Warning explicitly enabled, no messages expected
log = new JavacTask(tb)
.options("-Xlint:strictfp", "-Werror")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
checkEmptyLog(log);
}
@Test
public void testInnerSuppression(Path base) throws IOException {
Path src = base.resolve("src");
tb.writeJavaFiles(src, UNNEEDED_STRICTFP_WARNING3_INNER_SUPPRESSION);
Path classes = base.resolve("classes");
tb.createDirectories(classes);
// Warning enabled, 3 messages expected
List<String> log = new JavacTask(tb)
.options("-XDrawDiagnostics")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
var expected = List.of("UnneededStrictfpWarning3.java:1:17: compiler.warn.strictfp",
"UnneededStrictfpWarning3.java:10:10: compiler.warn.strictfp",
"UnneededStrictfpWarning3.java:17:28: compiler.warn.strictfp",
"3 warnings");
checkLog(log, expected);
}
protected void runTests() throws Exception {
runTests(m -> new Object[] { Paths.get(m.getName()).toAbsolutePath() });
}
// If warnings are enabled, should generate 5 warnings for the 5
// explicit uses of strictfp.
private static final String UNNEEDED_STRICTFP_WARNING1_NO_SUPPRESSION =
"""
public strictfp class UnneededStrictfpWarning1 {
// Implicit strictfp, no warning
public UnneededStrictfpWarning1() {super();}
public static void main(String... args) {
return;
}
}
strictfp interface StrictfpInterface {
default double foo() {return 42.0;};
default strictfp double bar() {return 21.0;};
}
class StrictfpMethod {
static strictfp double quux() {return 42.0;}
static strictfp class NestedStrictfpClass {}
}
""";
// If warnings are enabled, no warnings should be generated due to
// suppression at the top-most level.
private static final String UNNEEDED_STRICTFP_WARNING2_TOP_LEVEL_SUPPRESSION =
"""
@SuppressWarnings("strictfp")
public strictfp class UnneededStrictfpWarning2 {
// Implicit strictfp, no warning
public UnneededStrictfpWarning2() {super();}
public static void main(String... args) {
return;
}
}
@SuppressWarnings("strictfp")
strictfp interface StrictfpInterface {
default double foo() {return 42.0;};
default strictfp double bar() {return 21.0;};
}
@SuppressWarnings("strictfp")
class StrictfpMethod {
static strictfp double quux() {return 42.0;}
static strictfp class NestedStrictfpClass {}
}
""";
// If warnings are enabled, 3 warnings should be generated.
private static final String UNNEEDED_STRICTFP_WARNING3_INNER_SUPPRESSION =
"""
public strictfp class UnneededStrictfpWarning3 {
// Implicit strictfp, no warning
public UnneededStrictfpWarning3() {super();}
public static void main(String... args) {
return;
}
}
strictfp interface StrictfpInterface {
default double foo() {return 42.0;};
@SuppressWarnings("strictfp")
default strictfp double bar() {return 21.0;};
}
class StrictfpMethod {
static strictfp double quux() {return 42.0;}
@SuppressWarnings("strictfp")
static strictfp class NestedStrictfpClass {}
}
""";
}
|