1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369
|
/*
* Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8246774
* @summary Basic tests for prohibited magic serialization methods
* @library /test/lib
* @modules java.base/jdk.internal.org.objectweb.asm
* @run testng ProhibitedMethods
*/
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.Externalizable;
import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectInputStream;
import java.io.ObjectOutput;
import java.io.ObjectOutputStream;
import java.io.ObjectStreamClass;
import java.io.OutputStream;
import java.io.Serializable;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import java.math.BigDecimal;
import java.util.function.Function;
import jdk.internal.org.objectweb.asm.ClassReader;
import jdk.internal.org.objectweb.asm.ClassVisitor;
import jdk.internal.org.objectweb.asm.ClassWriter;
import jdk.internal.org.objectweb.asm.MethodVisitor;
import jdk.test.lib.compiler.InMemoryJavaCompiler;
import jdk.test.lib.ByteCodeLoader;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
import static java.lang.System.out;
import static jdk.internal.org.objectweb.asm.ClassWriter.COMPUTE_FRAMES;
import static jdk.internal.org.objectweb.asm.ClassWriter.COMPUTE_MAXS;
import static jdk.internal.org.objectweb.asm.Opcodes.*;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.expectThrows;
import static org.testng.Assert.fail;
/**
* Checks that the various prohibited Serialization magic methods, and
* Externalizable methods, are not invoked ( effectively ignored ) for
* record objects.
*/
public class ProhibitedMethods {
public interface ThrowingExternalizable extends Externalizable {
default void writeExternal(ObjectOutput out) {
fail("should not reach here");
}
default void readExternal(ObjectInput in) {
fail("should not reach here");
}
}
record Wibble () implements ThrowingExternalizable { }
record Wobble (long l) implements ThrowingExternalizable { }
record Wubble (Wobble wobble, Wibble wibble, String s) implements ThrowingExternalizable { }
ClassLoader serializableRecordLoader;
/**
* Generates the serializable record classes used by the test. First creates
* the initial bytecode for the record classes using javac, then adds the
* prohibited magic serialization methods. For example, effectively generates:
*
* public record Foo () implements Serializable {
* private void writeObject(ObjectOutputStream out) {
* fail("writeObject should not be invoked"); }
* private void readObject(ObjectInputStream in) {
* fail("readObject should not be invoked"); }
* private void readObjectNoData() {
* fail("readObjectNoData should not be invoked"); }
* }
*/
@BeforeTest
public void setup() {
{
byte[] byteCode = InMemoryJavaCompiler.compile("Foo",
"public record Foo () implements java.io.Serializable { }");
byteCode = addWriteObject(byteCode);
byteCode = addReadObject(byteCode);
byteCode = addReadObjectNoData(byteCode);
serializableRecordLoader = new ByteCodeLoader("Foo", byteCode, ProhibitedMethods.class.getClassLoader());
}
{
byte[] byteCode = InMemoryJavaCompiler.compile("Bar",
"public record Bar (int x, int y) implements java.io.Serializable { }");
byteCode = addWriteObject(byteCode);
byteCode = addReadObject(byteCode);
byteCode = addReadObjectNoData(byteCode);
serializableRecordLoader = new ByteCodeLoader("Bar", byteCode, serializableRecordLoader);
}
{
byte[] byteCode = InMemoryJavaCompiler.compile("Baz",
"import java.io.Serializable;" +
"public record Baz<U extends Serializable,V extends Serializable>(U u, V v) implements Serializable { }");
byteCode = addWriteObject(byteCode);
byteCode = addReadObject(byteCode);
byteCode = addReadObjectNoData(byteCode);
serializableRecordLoader = new ByteCodeLoader("Baz", byteCode, serializableRecordLoader);
}
}
/** Constructs a new instance of record Foo. */
Object newFoo() {
try {
Class<?> c = Class.forName("Foo", true, serializableRecordLoader);
assert c.isRecord();
assert c.getRecordComponents() != null;
return c.getConstructor().newInstance();
} catch (ReflectiveOperationException e) {
throw new AssertionError(e);
}
}
/** Constructs a new instance of record Bar. */
Object newBar(int x, int y) {
try {
Class<?> c = Class.forName("Bar", true, serializableRecordLoader);
assert c.isRecord();
assert c.getRecordComponents().length == 2;
return c.getConstructor(int.class, int.class).newInstance(x, y);
} catch (ReflectiveOperationException e) {
throw new AssertionError(e);
}
}
/** Constructs a new instance of record Baz. */
Object newBaz(Object u, Object v) {
try {
Class<?> c = Class.forName("Baz", true, serializableRecordLoader);
assert c.isRecord();
assert c.getRecordComponents().length == 2;
return c.getConstructor(Serializable.class, Serializable.class).newInstance(u, v);
} catch (ReflectiveOperationException e) {
throw new AssertionError(e);
}
}
@DataProvider(name = "recordInstances")
public Object[][] recordInstances() {
return new Object[][] {
new Object[] { newFoo() },
new Object[] { newBar(19, 20) },
new Object[] { newBaz("str", BigDecimal.valueOf(8765)) },
new Object[] { new Wibble() },
new Object[] { new Wobble(1000L) },
new Object[] { new Wubble(new Wobble(9999L), new Wibble(), "str") },
};
}
@Test(dataProvider = "recordInstances")
public void roundTrip(Object objToSerialize) throws Exception {
out.println("\n---");
out.println("serializing : " + objToSerialize);
var objDeserialized = serializeDeserialize(objToSerialize);
out.println("deserialized: " + objDeserialized);
assertEquals(objToSerialize, objDeserialized);
assertEquals(objDeserialized, objToSerialize);
}
<T> byte[] serialize(T obj) throws IOException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
ObjectOutputStream oos = new ObjectOutputStream(baos);
oos.writeObject(obj);
oos.close();
return baos.toByteArray();
}
@SuppressWarnings("unchecked")
<T> T deserialize(byte[] streamBytes)
throws IOException, ClassNotFoundException
{
ByteArrayInputStream bais = new ByteArrayInputStream(streamBytes);
ObjectInputStream ois = new ObjectInputStream(bais) {
@Override
protected Class<?> resolveClass(ObjectStreamClass desc)
throws ClassNotFoundException {
return Class.forName(desc.getName(), false, serializableRecordLoader);
}
};
return (T) ois.readObject();
}
<T> T serializeDeserialize(T obj)
throws IOException, ClassNotFoundException
{
return deserialize(serialize(obj));
}
// -- machinery for augmenting record classes with prohibited serial methods --
static byte[] addWriteObject(byte[] classBytes) {
return addMethod(classBytes, cv -> new WriteObjectVisitor(cv));
}
static byte[] addReadObject(byte[] classBytes) {
return addMethod(classBytes, cv -> new ReadObjectVisitor(cv));
}
static byte[] addReadObjectNoData(byte[] classBytes) {
return addMethod(classBytes, cv -> new ReadObjectNoDataVisitor(cv));
}
static byte[] addMethod(byte[] classBytes,
Function<ClassVisitor,ClassVisitor> classVisitorCreator) {
ClassReader reader = new ClassReader(classBytes);
ClassWriter writer = new ClassWriter(reader, COMPUTE_MAXS | COMPUTE_FRAMES);
reader.accept(classVisitorCreator.apply(writer), 0);
return writer.toByteArray();
}
static abstract class AbstractVisitor extends ClassVisitor {
final String nameOfMethodToAdd;
AbstractVisitor(ClassVisitor cv, String nameOfMethodToAdd) {
super(ASM8, cv);
this.nameOfMethodToAdd = nameOfMethodToAdd;
}
@Override
public MethodVisitor visitMethod(final int access,
final String name,
final String descriptor,
final String signature,
final String[] exceptions) {
// the method-to-be-added should not already exist
assert !name.equals(nameOfMethodToAdd) : "Unexpected " + name + " method";
return cv.visitMethod(access, name, descriptor, signature, exceptions);
}
@Override
public void visitEnd() {
throw new UnsupportedOperationException("implement me");
}
}
/** A visitor that generates and adds a writeObject method. */
static final class WriteObjectVisitor extends AbstractVisitor {
static final String WRITE_OBJECT_NAME = "writeObject";
static final String WRITE_OBJECT_DESC = "(Ljava/io/ObjectOutputStream;)V";
WriteObjectVisitor(ClassVisitor cv) { super(cv, WRITE_OBJECT_NAME); }
@Override
public void visitEnd() {
MethodVisitor mv = cv.visitMethod(ACC_PRIVATE, WRITE_OBJECT_NAME, WRITE_OBJECT_DESC, null, null);
mv.visitCode();
mv.visitLdcInsn(WRITE_OBJECT_NAME + " should not be invoked");
mv.visitMethodInsn(INVOKESTATIC, "org/testng/Assert", "fail", "(Ljava/lang/String;)V", false);
mv.visitInsn(RETURN);
mv.visitMaxs(0, 0);
mv.visitEnd();
cv.visitEnd();
}
}
/** A visitor that generates and adds a readObject method. */
static final class ReadObjectVisitor extends AbstractVisitor {
static final String READ_OBJECT_NAME = "readObject";
static final String READ_OBJECT_DESC = "(Ljava/io/ObjectInputStream;)V";
ReadObjectVisitor(ClassVisitor cv) { super(cv, READ_OBJECT_NAME); }
@Override
public void visitEnd() {
MethodVisitor mv = cv.visitMethod(ACC_PRIVATE, READ_OBJECT_NAME, READ_OBJECT_DESC, null, null);
mv.visitCode();
mv.visitLdcInsn(READ_OBJECT_NAME + " should not be invoked");
mv.visitMethodInsn(INVOKESTATIC, "org/testng/Assert", "fail", "(Ljava/lang/String;)V", false);
mv.visitInsn(RETURN);
mv.visitMaxs(0, 0);
mv.visitEnd();
cv.visitEnd();
}
}
/** A visitor that generates and adds a readObjectNoData method. */
static final class ReadObjectNoDataVisitor extends AbstractVisitor {
static final String READ_OBJECT_NO_DATA_NAME = "readObjectNoData";
static final String READ_OBJECT_NO_DATA_DESC = "()V";
ReadObjectNoDataVisitor(ClassVisitor cv) { super(cv, READ_OBJECT_NO_DATA_NAME); }
@Override
public void visitEnd() {
MethodVisitor mv = cv.visitMethod(ACC_PRIVATE, READ_OBJECT_NO_DATA_NAME, READ_OBJECT_NO_DATA_DESC, null, null);
mv.visitCode();
mv.visitLdcInsn(READ_OBJECT_NO_DATA_NAME + " should not be invoked");
mv.visitMethodInsn(INVOKESTATIC, "org/testng/Assert", "fail", "(Ljava/lang/String;)V", false);
mv.visitInsn(RETURN);
mv.visitMaxs(0, 0);
mv.visitEnd();
cv.visitEnd();
}
}
// -- infra sanity --
static final Class<ReflectiveOperationException> ROE = ReflectiveOperationException.class;
/** Checks to ensure correct operation of the test's generation logic. */
@Test
public void wellFormedGeneratedClasses() throws Exception {
out.println("\n---");
for (Object obj : new Object[] { newFoo(), newBar(3, 4), newBaz(1,"s") }) {
out.println(obj);
{ // writeObject
Method m = obj.getClass().getDeclaredMethod("writeObject", ObjectOutputStream.class);
assertTrue((m.getModifiers() & Modifier.PRIVATE) != 0);
m.setAccessible(true);
ReflectiveOperationException t = expectThrows(ROE, () ->
m.invoke(obj, new ObjectOutputStream(OutputStream.nullOutputStream())));
Throwable assertionError = t.getCause();
out.println("caught expected AssertionError: " + assertionError);
assertTrue(assertionError instanceof AssertionError,
"Expected AssertionError, got:" + assertionError);
assertEquals(assertionError.getMessage(), "writeObject should not be invoked");
}
{ // readObject
Method m = obj.getClass().getDeclaredMethod("readObject", ObjectInputStream.class);
assertTrue((m.getModifiers() & Modifier.PRIVATE) != 0);
m.setAccessible(true);
ReflectiveOperationException t = expectThrows(ROE, () ->
m.invoke(obj, new ObjectInputStream() {
}));
Throwable assertionError = t.getCause();
out.println("caught expected AssertionError: " + assertionError);
assertTrue(assertionError instanceof AssertionError,
"Expected AssertionError, got:" + assertionError);
assertEquals(assertionError.getMessage(), "readObject should not be invoked");
}
{ // readObjectNoData
Method m = obj.getClass().getDeclaredMethod("readObjectNoData");
assertTrue((m.getModifiers() & Modifier.PRIVATE) != 0);
m.setAccessible(true);
ReflectiveOperationException t = expectThrows(ROE, () -> m.invoke(obj));
Throwable assertionError = t.getCause();
out.println("caught expected AssertionError: " + assertionError);
assertTrue(assertionError instanceof AssertionError,
"Expected AssertionError, got:" + assertionError);
assertEquals(assertionError.getMessage(), "readObjectNoData should not be invoked");
}
}
}
}
|