1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307
|
/*
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8314263
* @summary Signed jars triggering Logger finder recursion and StackOverflowError
* @library /test/lib ../lib
* @compile/module=java.base share/classes/jdk/internal/event/EventHelper.java
* @modules java.base/jdk.internal.logger:+open
* @build jdk.test.lib.compiler.CompilerUtils
* jdk.test.lib.process.*
* jdk.test.lib.util.JarUtils
* jdk.test.lib.JDKToolLauncher
* @compile SignedLoggerFinderTest.java SimpleLoggerFinder.java
* @run main SignedLoggerFinderTest init
* @run main SignedLoggerFinderTest init sign
*/
import java.io.File;
import java.nio.file.*;
import java.security.*;
import java.util.*;
import java.util.function.*;
import java.util.jar.*;
import jdk.test.lib.JDKToolFinder;
import jdk.test.lib.JDKToolLauncher;
import jdk.test.lib.Utils;
import jdk.test.lib.process.OutputAnalyzer;
import jdk.test.lib.process.ProcessTools;
import jdk.test.lib.util.JarUtils;
import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
import static java.util.Arrays.asList;
public class SignedLoggerFinderTest {
/**
* This test triggers recursion in the broken JDK. The error can
* manifest in a few different ways.
* One error seen is "java.lang.NoClassDefFoundError:
* Could not initialize class jdk.internal.logger.LoggerFinderLoader$ErrorPolicy"
*
* The original reported error was a StackOverflow (also seen in different iterations
* of this run). Running test in signed and unsigned jar mode for sanity coverage.
* The current bug only manifests when jars are signed.
*/
private static boolean init = false;
private static boolean signJars = false;
private static boolean mutliThreadLoad = false;
private static volatile boolean testComplete = false;
private static final String KEYSTORE = "8314263.keystore";
private static final String ALIAS = "JavaTest";
private static final String STOREPASS = "changeit";
private static final String KEYPASS = "changeit";
private static final String DNAME = "CN=sample";
private static final String CUSTOM_LOGGER_FINDER_NAME =
"loggerfinder.SimpleLoggerFinder";
private static final String CUSTOM_LOGGER_NAME =
"loggerfinder.SimpleLoggerFinder$SimpleLogger";
private static final String INTERNAL_LOGGER_FINDER_NAME =
"sun.util.logging.internal.LoggingProviderImpl";
private static final String INTERNAL_LOGGER_NAME =
"sun.util.logging.internal.LoggingProviderImpl$JULWrapper";
private static final Path jarPath1 =
Path.of(System.getProperty("test.classes", "."), "SimpleLoggerFinder.jar");
private static final Path jarPath2 =
Path.of(System.getProperty("test.classes", "."), "SimpleLoggerFinder2.jar");
public static void main(String[] args) throws Throwable {
init = args.length >=1 && args[0].equals("init");
signJars = args.length >=2 && args[1].equals("sign");
// init only passed in by jtreg test run, initialize the environment
// for the subsequent test run
if (init) {
initialize();
launchTest(false, false);
launchTest(false, true);
launchTest(true, false);
launchTest(true, true);
} else {
// set up complete. Run the code to trigger the recursion
// We're in the JVM launched by ProcessTools.executeCommand
boolean multiThreadLoad = Boolean.getBoolean("multiThreadLoad");
boolean withCustomLoggerFinder = Boolean.getBoolean("withCustomLoggerFinder");
if (multiThreadLoad) {
long sleep = new Random().nextLong(100L) + 1L;
System.out.println("multi thread load sleep value: " + sleep);
new Thread(runnableWithSleep(
() -> System.getLogger("logger" + System.currentTimeMillis()),
sleep, "System.getLogger type: ")).start();
new Thread(runnableWithSleep(
() -> System.LoggerFinder.getLoggerFinder(),
sleep, "System.getLoggerFinder type: ")).start();
}
if (withCustomLoggerFinder) {
JarFile jf = new JarFile(jarPath1.toString(), true);
jf.getInputStream(jf.getJarEntry("loggerfinder/SimpleLoggerFinder.class"));
JarFile jf2 = new JarFile(jarPath2.toString(), true);
jf2.getInputStream(jf.getJarEntry("loggerfinder/SimpleLoggerFinder.class"));
} else {
// some other call to prod LoggerFinder loading
System.getLogger("random" + System.currentTimeMillis());
System.LoggerFinder.getLoggerFinder();
}
Security.setProperty("test_1", "test");
// some extra sanity checks
if (withCustomLoggerFinder) {
assertEquals(System.LoggerFinder.getLoggerFinder().getClass().getName(),
CUSTOM_LOGGER_FINDER_NAME);
System.Logger testLogger = System.getLogger("jdk.event.security");
assertEquals(testLogger.getClass().getName(), CUSTOM_LOGGER_NAME);
} else {
assertEquals(System.LoggerFinder.getLoggerFinder().getClass().getName(),
INTERNAL_LOGGER_FINDER_NAME);
System.Logger testLogger = System.getLogger("jdk.event.security");
assertEquals(testLogger.getClass().getName(), INTERNAL_LOGGER_NAME);
}
testComplete = true;
// LoggerFinder should be initialized, trigger a simple log call
Security.setProperty("test_2", "test");
// allow time to let bootstrap logger flush data
BootstrapLoggerUtils.awaitPending();
}
}
// helper to create the inner test. Run config variations with the LoggerFinder jars
// on the classpath and with other threads running System.Logger calls during load
private static void launchTest(boolean multiThreadLoad, boolean withCustomLoggerFinder) {
List<String> cmds = new ArrayList<>();
cmds.add(JDKToolFinder.getJDKTool("java"));
cmds.addAll(asList(Utils.getTestJavaOpts()));
if (withCustomLoggerFinder) {
cmds.addAll(List.of("-classpath",
System.getProperty("test.classes") + File.pathSeparator +
jarPath1.toString() + File.pathSeparator + jarPath2.toString(),
"-Dtest.classes=" + System.getProperty("test.classes")));
} else {
cmds.addAll(List.of("-classpath",
System.getProperty("test.classes")));
}
Path patches = Paths.get(System.getProperty("test.classes"), "patches", "java.base");
cmds.addAll(List.of(
// patch of EventHelper to log at INFO level (for bootstrap logger)
"--patch-module", "java.base=" + patches.toString(),
// allow test to access internal bootstrap logger functionality
"--add-opens=java.base/jdk.internal.logger=ALL-UNNAMED",
// following debug property seems useful to tickle the issue
"-Dsun.misc.URLClassPath.debug=true",
// console logger level to capture event output
"-Djdk.system.logger.level=DEBUG",
// useful for debug purposes
"-Djdk.logger.finder.error=DEBUG",
// enable logging to verify correct output
"-Djava.util.logging.config.file=" +
Path.of(System.getProperty("test.src", "."), "logging.properties")));
if (multiThreadLoad) {
cmds.add("-DmultiThreadLoad=true");
}
if (withCustomLoggerFinder) {
cmds.add("-DwithCustomLoggerFinder=true");
}
cmds.addAll(List.of(
"SignedLoggerFinderTest",
"no-init"));
try {
OutputAnalyzer outputAnalyzer = ProcessTools.executeCommand(cmds.stream()
.filter(t -> !t.isEmpty())
.toArray(String[]::new))
.shouldHaveExitValue(0);
if (withCustomLoggerFinder) {
outputAnalyzer
.shouldContain("TEST LOGGER: [test_1, test]")
.shouldContain("TEST LOGGER: [test_2, test]");
} else {
outputAnalyzer
.shouldContain("SecurityPropertyModification: key:test_1")
.shouldContain("SecurityPropertyModification: key:test_2");
}
if (withCustomLoggerFinder && signJars) {
// X509 cert generated during verification of signed jar file
outputAnalyzer
.shouldContain(DNAME);
}
} catch (Throwable t) {
throw new RuntimeException("Unexpected fail.", t);
}
}
private static Runnable runnableWithSleep(Supplier s, long sleep, String desc) {
return () -> {
while(!testComplete) {
System.out.println(desc + s.get().getClass().getName());
try {
Thread.sleep(sleep);
} catch (InterruptedException e) {
throw new RuntimeException(e);
}
}
};
}
private static void initialize() throws Throwable {
if (signJars) {
genKey();
}
Path classes = Paths.get(System.getProperty("test.classes", ""));
JarUtils.createJarFile(jarPath1,
classes,
classes.resolve("loggerfinder/SimpleLoggerFinder.class"),
classes.resolve("loggerfinder/SimpleLoggerFinder$SimpleLogger.class"));
JarUtils.updateJarFile(jarPath1, Path.of(System.getProperty("test.src")),
Path.of("META-INF", "services", "java.lang.System$LoggerFinder"));
if (signJars) {
signJar(jarPath1.toString());
}
// multiple signed jars with services to have ServiceLoader iteration
Files.copy(jarPath1, jarPath2, REPLACE_EXISTING);
}
private static void genKey() throws Throwable {
String keytool = JDKToolFinder.getJDKTool("keytool");
Files.deleteIfExists(Paths.get(KEYSTORE));
ProcessTools.executeCommand(keytool,
"-J-Duser.language=en",
"-J-Duser.country=US",
"-genkey",
"-keyalg", "rsa",
"-alias", ALIAS,
"-keystore", KEYSTORE,
"-keypass", KEYPASS,
"-dname", DNAME,
"-storepass", STOREPASS
).shouldHaveExitValue(0);
}
private static OutputAnalyzer signJar(String jarName) throws Throwable {
List<String> args = new ArrayList<>();
args.add("-verbose");
args.add(jarName);
args.add(ALIAS);
return jarsigner(args);
}
private static OutputAnalyzer jarsigner(List<String> extra)
throws Throwable {
JDKToolLauncher launcher = JDKToolLauncher.createUsingTestJDK("jarsigner")
.addVMArg("-Duser.language=en")
.addVMArg("-Duser.country=US")
.addToolArg("-keystore")
.addToolArg(KEYSTORE)
.addToolArg("-storepass")
.addToolArg(STOREPASS)
.addToolArg("-keypass")
.addToolArg(KEYPASS);
for (String s : extra) {
if (s.startsWith("-J")) {
launcher.addVMArg(s.substring(2));
} else {
launcher.addToolArg(s);
}
}
return ProcessTools.executeCommand(launcher.getCommand());
}
private static void assertEquals(String received, String expected) {
if (!expected.equals(received)) {
throw new RuntimeException("Received: " + received);
}
}
}
|