1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
|
/*
* Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 4485208 8252767
* @summary Validate various request property methods on java.net.URLConnection
* throw NullPointerException and IllegalStateException when expected
* @run testng RequestProperties
*/
import org.testng.Assert;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
import java.io.IOException;
import java.net.URL;
import java.net.URLConnection;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.List;
public class RequestProperties {
private static final Class NPE = NullPointerException.class;
private static final Class ISE = IllegalStateException.class;
@DataProvider(name = "urls")
private Object[][] urls() {
final List<String> urls = new ArrayList<>();
urls.add("http://foo.com/bar/");
urls.add("jar:http://foo.com/bar.html!/foo/bar");
urls.add("file:/etc/passwd");
if (hasFtp()) {
urls.add("ftp://foo:bar@foobar.com/etc/passwd");
}
final Object[][] data = new Object[urls.size()][1];
for (int i = 0; i < urls.size(); i++) {
data[i][0] = urls.get(i);
}
return data;
}
/**
* Test that {@link java.net.URLConnection#setRequestProperty(String, String)} throws
* a {@link NullPointerException} when passed null key
*/
@Test(dataProvider = "urls")
public void testSetRequestPropertyNullPointerException(final String url) throws Exception {
final URLConnection conn = new URL(url).openConnection();
Assert.assertThrows(NPE, () -> conn.setRequestProperty(null, "bar"));
// expected to pass
conn.setRequestProperty("key", null);
}
/**
* Test that {@link java.net.URLConnection#addRequestProperty(String, String)} throws
* a {@link NullPointerException} when passed null key
*/
@Test(dataProvider = "urls")
public void testAddRequestPropertyNullPointerException(final String url) throws Exception {
final URLConnection conn = new URL(url).openConnection();
Assert.assertThrows(NPE, () -> conn.addRequestProperty(null, "hello"));
// expected to pass
conn.addRequestProperty("key", null);
}
/**
* Test that {@link java.net.URLConnection#getRequestProperty(String)} returns
* null when the passed key is null
*/
@Test(dataProvider = "urls")
public void testGetRequestPropertyReturnsNull(final String url) throws Exception {
final URLConnection conn = new URL(url).openConnection();
Assert.assertNull(conn.getRequestProperty(null),
"getRequestProperty was expected to return null for null key");
}
/**
* Test that {@link java.net.URLConnection#setRequestProperty(String, String)} throws
* an {@link IllegalStateException} when already connected
*/
@Test
public void testSetRequestPropertyIllegalStateException() throws Exception {
final URLConnection conn = createAndConnectURLConnection();
try {
Assert.assertThrows(ISE, () -> conn.setRequestProperty("foo", "bar"));
} finally {
safeClose(conn);
}
}
/**
* Test that {@link java.net.URLConnection#addRequestProperty(String, String)} throws
* an {@link IllegalStateException} when already connected
*/
@Test
public void testAddRequestPropertyIllegalStateException() throws Exception {
final URLConnection conn = createAndConnectURLConnection();
try {
Assert.assertThrows(ISE, () -> conn.addRequestProperty("foo", "bar"));
} finally {
safeClose(conn);
}
}
/**
* Test that {@link java.net.URLConnection#getRequestProperty(String)} throws
* an {@link IllegalStateException} when already connected
*/
@Test
public void testGetRequestPropertyIllegalStateException() throws Exception {
final URLConnection conn = createAndConnectURLConnection();
try {
Assert.assertThrows(ISE, () -> conn.getRequestProperty("hello"));
} finally {
safeClose(conn);
}
}
/**
* Test that {@link URLConnection#getRequestProperties()} throws
* an {@link IllegalStateException} when already connected
*/
@Test
public void testGetRequestPropertiesIllegalStateException() throws Exception {
final URLConnection conn = createAndConnectURLConnection();
try {
Assert.assertThrows(ISE, () -> conn.getRequestProperties());
} finally {
safeClose(conn);
}
}
private static URLConnection createAndConnectURLConnection() throws IOException {
final URL url = Path.of(System.getProperty("java.io.tmpdir")).toUri().toURL();
final URLConnection conn = url.openConnection();
conn.connect();
return conn;
}
private static void safeClose(final URLConnection conn) {
try {
conn.getInputStream().close();
} catch (Exception e) {
// ignore
}
}
private static boolean hasFtp() {
try {
new java.net.URL("ftp://");
return true;
} catch (java.net.MalformedURLException x) {
System.out.println("FTP not supported by this runtime.");
return false;
}
}
}
|
