1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
|
/*
* Copyright (c) 2002, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 4644775 6230836 8133686
* @summary Test URLConnection Request Properties
* @run main RequestPropertyValues
*/
import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLConnection;
import java.util.*;
/**
* Part1:
* bug 4644775: Unexpected NPE in setRequestProperty(key, null) call
* Part2:
* bug 6230836: A few methods of class URLConnection implemented incorrectly
* Part3:
* bug 8133686: Preserving the insertion-order of getRequestProperties
*/
public class RequestPropertyValues {
public static void main(String[] args) throws Exception {
part1();
part2();
part3();
}
public static void part1() throws Exception {
List<URL> urls = new ArrayList<>();
urls.add(new URL("http://localhost:8088"));
urls.add(new URL("file:/etc/passwd"));
urls.add(new URL("jar:http://foo.com/bar.html!/foo/bar"));
if (hasFtp())
urls.add(new URL("ftp://foo:bar@foobar.com/etc/passwd"));
boolean failed = false;
for (URL url : urls) {
URLConnection uc = url.openConnection();
try {
uc.setRequestProperty("TestHeader", null);
} catch (NullPointerException npe) {
System.out.println("setRequestProperty is throwing NPE" +
" for url: " + url);
failed = true;
}
try {
uc.addRequestProperty("TestHeader", null);
} catch (NullPointerException npe) {
System.out.println("addRequestProperty is throwing NPE" +
" for url: " + url);
failed = true;
}
}
if (failed) {
throw new Exception("RequestProperty setting/adding is" +
" throwing NPE for null values");
}
}
public static void part2() throws Exception {
URL url = null;
String[] goodKeys = {"", "$", "key", "Key", " ", " "};
String[] goodValues = {"", "$", "value", "Value", " ", " "};
URLConnection conn = getConnection(url);
for (int i = 0; i < goodKeys.length; ++i) {
for (int j = 0; j < goodValues.length; ++j) {
// If a property with the key already exists, overwrite its value with the new value
conn.setRequestProperty(goodKeys[i], goodValues[j]);
String value = conn.getRequestProperty(goodKeys[i]);
if (!((goodValues[j] == null && value == null) || (value != null && value.equals(goodValues[j]))))
throw new RuntimeException("Method setRequestProperty(String,String) works incorrectly");
}
}
}
private static void part3() throws Exception{
List<URL> urls = new ArrayList<>();
urls.add(new URL("http://localhost:8088"));
urls.add(new URL("jar:http://foo.com/bar.html!/foo/bar"));
for(URL url : urls) {
System.out.println("Testing " + url.toString().split(":")[0]);
URLConnection urlConnection = url.openConnection();
addCustomRequestProperties(urlConnection);
testRequestPropertiesOrder(urlConnection);
}
}
private static void addCustomRequestProperties(URLConnection urlConnection) {
urlConnection.addRequestProperty("Testprop", "val1");
urlConnection.addRequestProperty("Testprop", "val2");
urlConnection.addRequestProperty("Testprop", "val3");
}
private static void testRequestPropertiesOrder(URLConnection con) {
List<String> expectedTestRequestProperties = Arrays.asList("val1", "val2", "val3");
Map<String, List<String>> requestProperties = con.getRequestProperties();
List<String> actualTestRequestProperties = requestProperties.get("Testprop");
Objects.requireNonNull(actualTestRequestProperties);
if (!actualTestRequestProperties.equals(expectedTestRequestProperties)) {
System.out.println("expectedTestRequestHeaders = " + expectedTestRequestProperties.toString());
System.out.println("actualTestRequestHeaders = " + actualTestRequestProperties.toString());
String errorMessageTemplate = "expectedTestRequestProperties = %s, actualTestRequestProperties = %s";
throw new RuntimeException("expectedTestRequestProperties != actualTestRequestProperties for URL = " + con.getURL().toString() + String.format(errorMessageTemplate, expectedTestRequestProperties.toString(), actualTestRequestProperties.toString()));
}
}
static URLConnection getConnection(URL url) {
return new DummyURLConnection(url);
}
static class DummyURLConnection extends URLConnection {
DummyURLConnection(URL url) {
super(url);
}
public void connect() {
connected = true;
}
}
private static boolean hasFtp() {
try {
return new java.net.URL("ftp://") != null;
} catch (java.net.MalformedURLException x) {
System.out.println("FTP not supported by this runtime.");
return false;
}
}
}
|
