1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
/*
* Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 4729669
* @summary 1.4 REGRESSION: Text edge of different types of JMenuItems are not aligned
* @library /java/awt/regtesthelpers
* @build PassFailJFrame
* @run main/manual bug4729669
*/
import java.awt.Color;
import java.awt.ComponentOrientation;
import java.awt.Component;
import java.awt.Graphics;
import java.awt.event.ActionEvent;
import java.awt.event.KeyEvent;
import javax.swing.AbstractAction;
import javax.swing.Icon;
import javax.swing.JCheckBoxMenuItem;
import javax.swing.JFrame;
import javax.swing.JMenu;
import javax.swing.JMenuBar;
import javax.swing.JMenuItem;
import javax.swing.JRadioButtonMenuItem;
import javax.swing.KeyStroke;
import java.util.List;
public class bug4729669 {
private static final String INSTRUCTIONS = """
Two windows should appear: Left-to-right and Right-to-left.
Check that text on all the menu items of all menus
is properly vertically aligned.""";
public static void main(String[] args) throws Exception {
PassFailJFrame.builder()
.title("bug4729669 Instructions")
.instructions(INSTRUCTIONS)
.columns(35)
.testUI(bug4729669::createTestUI)
.position(PassFailJFrame.Position.TOP_LEFT_CORNER)
.logArea()
.build()
.awaitAndCheck();
}
private static List<JFrame> createTestUI() {
JFrame f1 = MenuItemTest.doMenuItemTest(true);
f1.setLocation(300, 300);
JFrame f2 = MenuItemTest.doMenuItemTest(false);
f2.setLocation(500, 300);
return List.of(f1, f2);
}
}
class MenuItemTest {
public static JFrame doMenuItemTest(boolean isLeft) {
JMenu menu = new JMenu("View");
menu.setMnemonic('V');
menu.add(new JMenuItem("Refresh"));
menu.add(new JMenuItem("Customize..."));
menu.add(new JCheckBoxMenuItem("Show Toolbar"));
menu.addSeparator();
menu.add(new JRadioButtonMenuItem("List"));
menu.add(new JRadioButtonMenuItem("Icons"));
JRadioButtonMenuItem rm2 = new JRadioButtonMenuItem("And icon.");
rm2.setAccelerator(KeyStroke.getKeyStroke(KeyEvent.VK_F1,
KeyEvent.SHIFT_MASK));
menu.add(rm2);
JRadioButtonMenuItem mi3 = new JRadioButtonMenuItem("Radio w/icon");
Icon myIcon = new Icon() { // 10 pixel red
public void paintIcon(Component c, Graphics g, int x, int y) {
Color color = g.getColor();
g.setColor(Color.RED);
g.fillRect(x, y, 10, 10);
g.setColor(color);
}
public int getIconWidth() {
return 10;
}
public int getIconHeight() {
return 10;
}
};
Icon myIcon2 = new Icon() { // 15 pixel green
public void paintIcon(Component c, Graphics g, int x, int y) {
Color color = g.getColor();
g.setColor(Color.GREEN);
g.fillRect(x, y, 15, 10);
g.setColor(color);
}
public int getIconWidth() {
return 15;
}
public int getIconHeight() {
return 10;
}
};
rm2.setIcon(myIcon2);
mi3.setIcon(myIcon);
menu.add(mi3);
menu.add(new JMenuItem(myIcon2));
final JMenu menu2 = new JMenu("No nothing");
menu2.add("One").addActionListener(new AbstractAction() {
public void actionPerformed(ActionEvent e) {
PassFailJFrame.log("menu.width = " + menu2.getPopupMenu().getWidth());
}
});
menu2.add("Two").addActionListener(new AbstractAction() {
public void actionPerformed(ActionEvent e) {
PassFailJFrame.log("menu.width = " + menu2.getPopupMenu().getWidth());
}
});
menu2.add("Threeee").addActionListener(new AbstractAction() {
public void actionPerformed(ActionEvent e) {
PassFailJFrame.log("menu.width = " + menu2.getPopupMenu().getWidth());
}
});
JMenuItem mi4 = new JMenuItem("Item with icon");
mi4.setIcon(myIcon);
menu.addSeparator();
menu.add(mi4);
String title = "Menu Item Test " + (isLeft ? "(Left-to-right)" : "(Right-to-left)");
JFrame frame = new JFrame(title);
JMenuBar menuBar = new JMenuBar();
menuBar.add(menu);
menuBar.add(menu2);
JMenu someIcons = new JMenu("Some icons");
JMenuItem imi1 = new JMenuItem("Icon!");
imi1.setIcon(myIcon);
someIcons.add(imi1);
JMenuItem imi2 = new JMenuItem("Wide icon!");
imi2.setIcon(myIcon2);
someIcons.add(imi2);
someIcons.add(new JCheckBoxMenuItem("CheckBox"));
someIcons.add(new JRadioButtonMenuItem("RadioButton"));
menuBar.add(someIcons);
frame.setJMenuBar(menuBar);
ComponentOrientation co = (isLeft ?
ComponentOrientation.LEFT_TO_RIGHT :
ComponentOrientation.RIGHT_TO_LEFT);
frame.applyComponentOrientation(co);
frame.setSize(300, 300);
int frameX = isLeft ? 0 : 600;
frame.setLocation(frameX, 20);
return frame;
}
}
|
