1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
|
/*
* Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8326949
* @summary Authorization header is removed when a proxy Authenticator is set
* @library /test/lib /test/jdk/java/net/httpclient /test/jdk/java/net/httpclient/lib
* @build jdk.test.lib.net.SimpleSSLContext jdk.httpclient.test.lib.common.HttpServerAdapters
* jdk.httpclient.test.lib.http2.Http2TestServer
* jdk.test.lib.net.IPSupport
*
* @modules java.net.http/jdk.internal.net.http.common
* java.net.http/jdk.internal.net.http.frame
* java.net.http/jdk.internal.net.http.hpack
* java.logging
* java.base/sun.net.www.http
* java.base/sun.net.www
* java.base/sun.net
*
* @run main/othervm UserAuthWithAuthenticator
*/
import java.io.*;
import java.net.*;
import java.net.http.HttpClient;
import java.net.http.HttpClient.Version;
import java.net.http.HttpRequest;
import java.net.http.HttpRequest.BodyPublishers;
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import javax.net.ssl.*;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.regex.*;
import java.util.*;
import jdk.test.lib.net.SimpleSSLContext;
import jdk.test.lib.net.URIBuilder;
import jdk.test.lib.net.IPSupport;
import jdk.httpclient.test.lib.common.HttpServerAdapters;
import jdk.httpclient.test.lib.common.HttpServerAdapters.HttpTestHandler;
import jdk.httpclient.test.lib.common.HttpServerAdapters.HttpTestExchange;
import jdk.httpclient.test.lib.common.HttpServerAdapters.HttpTestServer;
import jdk.httpclient.test.lib.http2.Http2TestServer;
import com.sun.net.httpserver.BasicAuthenticator;
import jdk.test.lib.net.URIBuilder;
import static java.nio.charset.StandardCharsets.US_ASCII;
public class UserAuthWithAuthenticator {
private static final String AUTH_PREFIX = "Basic ";
static class AuthTestHandler implements HttpTestHandler {
volatile String authValue;
final String response = "Hello world";
@Override
public void handle(HttpTestExchange t) throws IOException {
try (InputStream is = t.getRequestBody();
OutputStream os = t.getResponseBody()) {
byte[] bytes = is.readAllBytes();
authValue = t.getRequestHeaders()
.firstValue("Authorization")
.orElse(AUTH_PREFIX)
.substring(AUTH_PREFIX.length());
t.sendResponseHeaders(200, response.length());
os.write(response.getBytes(US_ASCII));
t.close();
}
}
String authValue() {return authValue;}
}
// if useHeader is true, we expect the Authenticator was not called
// and the user set header used. If false, Authenticator must
// be called and the user set header not used.
// If rightPassword is true we expect the authentication to succeed and 200 OK
// If false, then an error should be returned.
static void h2Test(final boolean useHeader, boolean rightPassword) throws Exception {
SSLContext ctx;
HttpTestServer h2s = null;
HttpClient client = null;
ExecutorService ex=null;
try {
ctx = new SimpleSSLContext().get();
ex = Executors.newCachedThreadPool();
InetAddress addr = InetAddress.getLoopbackAddress();
h2s = HttpTestServer.of(new Http2TestServer(addr, "::1", true, 0, ex,
10, null, ctx, false));
AuthTestHandler h = new AuthTestHandler();
var context = h2s.addHandler(h, "/test1");
context.setAuthenticator(new BasicAuthenticator("realm") {
public boolean checkCredentials(String username, String password) {
if (useHeader) {
return username.equals("user") && password.equals("pwd");
} else {
return username.equals("serverUser") && password.equals("serverPwd");
}
}
});
h2s.start();
int port = h2s.getAddress().getPort();
ServerAuth sa = new ServerAuth();
var plainCreds = rightPassword? "user:pwd" : "user:wrongPwd";
var encoded = java.util.Base64.getEncoder().encodeToString(plainCreds.getBytes(US_ASCII));
URI uri = URIBuilder.newBuilder()
.scheme("https")
.host(addr.getHostAddress())
.port(port)
.path("/test1/foo.txt")
.build();
HttpClient.Builder builder = HttpClient.newBuilder()
.sslContext(ctx)
.executor(ex);
builder.authenticator(sa);
client = builder.build();
HttpRequest req = HttpRequest.newBuilder(uri)
.version(HttpClient.Version.HTTP_2)
.header(useHeader ? "Authorization" : "X-Ignore", AUTH_PREFIX + encoded)
.GET()
.build();
HttpResponse<String> resp = client.send(req, HttpResponse.BodyHandlers.ofString());
if (!useHeader) {
assertTrue(resp.statusCode() == 200, "Expected 200 response");
assertTrue(!h.authValue().equals(encoded), "Expected user set header to not be set");
assertTrue(h.authValue().equals(sa.authValue()), "Expected auth value from Authenticator");
assertTrue(sa.wasCalled(), "Expected authenticator to be called");
System.out.println("h2Test: using authenticator OK");
} else if (rightPassword) {
assertTrue(resp.statusCode() == 200, "Expected 200 response");
assertTrue(h.authValue().equals(encoded), "Expected user set header to be set");
assertTrue(!sa.wasCalled(), "Expected authenticator not to be called");
System.out.println("h2Test: using user set header OK");
} else {
assertTrue(resp.statusCode() == 401, "Expected 401 response");
assertTrue(!sa.wasCalled(), "Expected authenticator not to be called");
System.out.println("h2Test: using user set header with wrong password OK");
}
} finally {
if (h2s != null)
h2s.stop();
if (client != null)
client.close();
if (ex != null)
ex.shutdown();
}
}
static final String data = "0123456789";
static final String data1 = "ABCDEFGHIJKL";
static final String[] proxyResponses = {
"HTTP/1.1 407 Proxy Authentication Required\r\n"+
"Content-Length: 0\r\n" +
"Proxy-Authenticate: Basic realm=\"Access to the proxy\"\r\n\r\n"
,
"HTTP/1.1 200 OK\r\n"+
"Date: Mon, 15 Jan 2001 12:18:21 GMT\r\n" +
"Server: Apache/1.3.14 (Unix)\r\n" +
"Content-Length: " + data.length() + "\r\n\r\n" + data
};
static final String[] proxyWithErrorResponses = {
"HTTP/1.1 407 Proxy Authentication Required\r\n"+
"Content-Length: 0\r\n" +
"Proxy-Authenticate: Basic realm=\"Access to the proxy\"\r\n\r\n"
,
"HTTP/1.1 407 Proxy Authentication Required\r\n"+
"Content-Length: 0\r\n" +
"Proxy-Authenticate: Basic realm=\"Access to the proxy\"\r\n\r\n"
};
static final String[] serverResponses = {
"HTTP/1.1 200 OK\r\n"+
"Date: Mon, 15 Jan 2001 12:18:21 GMT\r\n" +
"Server: Apache/1.3.14 (Unix)\r\n" +
"Content-Length: " + data1.length() + "\r\n\r\n" + data1
};
static final String[] authenticatorResponses = {
"HTTP/1.1 401 Authentication Required\r\n"+
"Content-Length: 0\r\n" +
"WWW-Authenticate: Basic realm=\"Access to the server\"\r\n\r\n"
,
"HTTP/1.1 200 OK\r\n"+
"Date: Mon, 15 Jan 2001 12:18:21 GMT\r\n" +
"Server: Apache/1.3.14 (Unix)\r\n" +
"Content-Length: " + data1.length() + "\r\n\r\n" + data1
};
public static void main(String[] args) throws Exception {
testServerOnly();
testServerWithProxy();
testServerWithProxyError();
testServerOnlyAuthenticator();
h2Test(true, true);
h2Test(false, true);
h2Test(true, false);
}
static void testServerWithProxy() throws IOException, InterruptedException {
Mocker proxyMock = new Mocker(proxyResponses);
proxyMock.start();
ProxyAuth p = new ProxyAuth();
try (var client = HttpClient.newBuilder()
.version(java.net.http.HttpClient.Version.HTTP_1_1)
.proxy(new ProxySel(proxyMock.getPort()))
.authenticator(p)
.build()) {
var plainCreds = "user:pwd";
var encoded = java.util.Base64.getEncoder().encodeToString(plainCreds.getBytes(US_ASCII));
var request = HttpRequest.newBuilder().uri(URI.create("http://127.0.0.1/some_url"))
.setHeader("User-Agent", "myUserAgent")
.setHeader("Authorization", AUTH_PREFIX + encoded)
.build();
var response = client.send(request, HttpResponse.BodyHandlers.ofString());
assertEquals(200, response.statusCode());
assertTrue(p.wasCalled(), "Proxy authenticator was not called");
assertEquals(data, response.body());
var proxyStr = proxyMock.getRequest(1);
assertContains(proxyStr, "/some_url");
assertPattern(".*^Proxy-Authorization:.*Basic " + encoded + ".*", proxyStr);
assertPattern(".*^User-Agent:.*myUserAgent.*", proxyStr);
assertPattern(".*^Authorization:.*Basic.*", proxyStr);
System.out.println("testServerWithProxy: OK");
} finally {
proxyMock.stopMocker();
}
}
static void testServerWithProxyError() throws IOException, InterruptedException {
Mocker proxyMock = new Mocker(proxyWithErrorResponses);
proxyMock.start();
ProxyAuth p = new ProxyAuth();
try (var client = HttpClient.newBuilder()
.version(java.net.http.HttpClient.Version.HTTP_1_1)
.proxy(new ProxySel(proxyMock.getPort()))
.authenticator(p)
.build()) {
var badCreds = "user:wrong";
var encoded1 = java.util.Base64.getEncoder().encodeToString(badCreds.getBytes(US_ASCII));
var request = HttpRequest.newBuilder().uri(URI.create("http://127.0.0.1/some_url"))
.setHeader("User-Agent", "myUserAgent")
.setHeader("Proxy-Authorization", AUTH_PREFIX + encoded1)
.build();
var response = client.send(request, HttpResponse.BodyHandlers.ofString());
var proxyStr = proxyMock.getRequest(0);
assertEquals(407, response.statusCode());
assertPattern(".*^Proxy-Authorization:.*Basic " + encoded1 + ".*", proxyStr);
assertTrue(!p.wasCalled(), "Proxy Auth should not have been called");
System.out.println("testServerWithProxyError: OK");
} finally {
proxyMock.stopMocker();
}
}
static void testServerOnly() throws IOException, InterruptedException {
Mocker serverMock = new Mocker(serverResponses);
serverMock.start();
try (var client = HttpClient.newBuilder()
.version(java.net.http.HttpClient.Version.HTTP_1_1)
.build()) {
var plainCreds = "user:pwd";
var encoded = java.util.Base64.getEncoder().encodeToString(plainCreds.getBytes(US_ASCII));
var request = HttpRequest.newBuilder().uri(URI.create(serverMock.baseURL() + "/some_serv_url"))
.setHeader("User-Agent", "myUserAgent")
.setHeader("Authorization", AUTH_PREFIX + encoded)
.build();
var response = client.send(request, HttpResponse.BodyHandlers.ofString());
assertEquals(200, response.statusCode());
assertEquals(data1, response.body());
var serverStr = serverMock.getRequest(0);
assertContains(serverStr, "/some_serv_url");
assertPattern(".*^User-Agent:.*myUserAgent.*", serverStr);
assertPattern(".*^Authorization:.*Basic " + encoded + ".*", serverStr);
System.out.println("testServerOnly: OK");
} finally {
serverMock.stopMocker();
}
}
// This is effectively a regression test for existing behavior
static void testServerOnlyAuthenticator() throws IOException, InterruptedException {
Mocker serverMock = new Mocker(authenticatorResponses);
serverMock.start();
try (var client = HttpClient.newBuilder()
.version(java.net.http.HttpClient.Version.HTTP_1_1)
.authenticator(new ServerAuth())
.build()) {
// credentials set in the server authenticator
var plainCreds = "serverUser:serverPwd";
var encoded = java.util.Base64.getEncoder().encodeToString(plainCreds.getBytes(US_ASCII));
var request = HttpRequest.newBuilder().uri(URI.create(serverMock.baseURL() + "/some_serv_url"))
.setHeader("User-Agent", "myUserAgent")
.build();
var response = client.send(request, HttpResponse.BodyHandlers.ofString());
assertEquals(200, response.statusCode());
assertEquals(data1, response.body());
var serverStr = serverMock.getRequest(1);
assertContains(serverStr, "/some_serv_url");
assertPattern(".*^User-Agent:.*myUserAgent.*", serverStr);
assertPattern(".*^Authorization:.*Basic " + encoded + ".*", serverStr);
System.out.println("testServerOnlyAuthenticator: OK");
} finally {
serverMock.stopMocker();
}
}
static void close(Closeable... clarray) {
for (Closeable c : clarray) {
try {
c.close();
} catch (Exception e) {}
}
}
static class Mocker extends Thread {
final ServerSocket ss;
final String[] responses;
volatile List<String> requests;
volatile InputStream in;
volatile OutputStream out;
volatile Socket s = null;
public Mocker(String[] responses) throws IOException {
this.ss = new ServerSocket(0, 0, InetAddress.getLoopbackAddress());
this.responses = responses;
this.requests = new LinkedList<>();
}
public void stopMocker() {
close(ss, s, in, out);
}
public int getPort() {
return ss.getLocalPort();
}
public String baseURL() {
try {
return URIBuilder.newBuilder()
.scheme("http")
.loopback()
.port(getPort())
.build()
.toString();
} catch (URISyntaxException e) {
throw new RuntimeException(e);
}
}
private String readRequest() throws IOException {
String req = "";
while (!req.endsWith("\r\n\r\n")) {
int x = in.read();
if (x == -1) {
s.close();
s = ss.accept();
in = s.getInputStream();
out = s.getOutputStream();
}
req += (char)x;
}
return req;
}
public String getRequest(int i) {
return requests.get(i);
}
public void run() {
try {
int index=0;
s = ss.accept();
in = s.getInputStream();
out = s.getOutputStream();
while (index < responses.length) {
requests.add(readRequest());
out.write(responses[index++].getBytes(US_ASCII));
}
} catch (Exception e) {
e.printStackTrace();
}
}
}
static class ProxySel extends ProxySelector {
final int port;
ProxySel(int port) {
this.port = port;
}
@Override
public List<Proxy> select(URI uri) {
return List.of(new Proxy(Proxy.Type.HTTP, new InetSocketAddress(
InetAddress.getLoopbackAddress(), port)));
}
@Override
public void connectFailed(URI uri, SocketAddress sa, IOException ioe) {}
}
static class ProxyAuth extends Authenticator {
private volatile boolean called = false;
@Override
protected PasswordAuthentication getPasswordAuthentication() {
called = true;
return new PasswordAuthentication("proxyUser", "proxyPwd".toCharArray());
}
boolean wasCalled() {
return called;
}
}
static class ServerAuth extends Authenticator {
private volatile boolean called = false;
private static String USER = "serverUser";
private static String PASS = "serverPwd";
@Override
protected PasswordAuthentication getPasswordAuthentication() {
called = true;
if (getRequestorType() != RequestorType.SERVER) {
// We only want to handle server authentication here
return null;
}
return new PasswordAuthentication(USER, PASS.toCharArray());
}
String authValue() {
var plainCreds = USER + ":" + PASS;
return java.util.Base64.getEncoder().encodeToString(plainCreds.getBytes(US_ASCII));
}
boolean wasCalled() {
return called;
}
}
static void assertTrue(boolean assertion, String failMsg) {
if (!assertion) {
throw new RuntimeException(failMsg);
}
}
static void assertEquals(int a, int b) {
if (a != b) {
String msg = String.format("Error: expected %d Got %d", a, b);
throw new RuntimeException(msg);
}
}
static void assertEquals(String s1, String s2) {
if (!s1.equals(s2)) {
String msg = String.format("Error: expected %s Got %s", s1, s2);
throw new RuntimeException(msg);
}
}
static void assertContains(String container, String containee) {
if (!container.contains(containee)) {
String msg = String.format("Error: expected %s Got %s", container, containee);
throw new RuntimeException(msg);
}
}
static void assertPattern(String pattern, String candidate) {
Pattern pat = Pattern.compile(pattern, Pattern.DOTALL | Pattern.MULTILINE);
Matcher matcher = pat.matcher(candidate);
if (!matcher.matches()) {
String msg = String.format("Error: expected %s Got %s", pattern, candidate);
throw new RuntimeException(msg);
}
}
}
|