1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
|
/*
* Copyright (c) 2012, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 7142509
* @summary Cipher.doFinal(ByteBuffer,ByteBuffer) fails to
* process when in.remaining() == 0
* @key randomness
* @run main DirectBBRemaining DES 8
* @run main DirectBBRemaining AES 16
*/
import java.nio.ByteBuffer;
import java.security.SecureRandom;
import java.util.Arrays;
import java.util.Random;
import javax.crypto.Cipher;
import javax.crypto.SecretKey;
import javax.crypto.spec.SecretKeySpec;
/*
* Simple test case to show that Cipher.doFinal(ByteBuffer, ByteBuffer) fails to
* process the data internally buffered inBB the cipher when input.remaining()
* == 0 and at least one buffer is a direct buffer.
*/
public class DirectBBRemaining {
private static Random random = new SecureRandom();
private static int testSizes = 40;
private static int outputFrequency = 5;
public static void main(String args[]) throws Exception {
boolean failedOnce = false;
Exception failedReason = null;
int keyInt = Integer.parseInt(args[1]);
byte[] keyBytes = new byte[keyInt];
random.nextBytes(keyBytes);
String algo = args[0];
SecretKey key = new SecretKeySpec(keyBytes, algo);
Cipher cipher = Cipher.getInstance(algo + "/CBC/PKCS5Padding",
System.getProperty("test.provider.name", "SunJCE"));
cipher.init(Cipher.ENCRYPT_MODE, key);
/*
* Iterate through various sizes to make sure that the code does empty
* blocks, single partial blocks, 1 full block, full + partial blocks,
* multiple full blocks, etc. 5 blocks (using DES) is probably overkill
* but will feel more confident the fix isn't breaking anything.
*/
System.out.println("Output test results for every "
+ outputFrequency + " tests...");
for (int size = 0; size <= testSizes; size++) {
boolean output = (size % outputFrequency) == 0;
if (output) {
System.out.print("\nTesting buffer size: " + size + ":");
}
int outSize = cipher.getOutputSize(size);
try {
encrypt(cipher, size,
ByteBuffer.allocate(size),
ByteBuffer.allocate(outSize),
ByteBuffer.allocateDirect(size),
ByteBuffer.allocateDirect(outSize),
output);
} catch (Exception e) {
System.out.print("\n Failed with size " + size);
failedOnce = true;
failedReason = e;
// If we got an exception, let's be safe for future
// testing and reset the cipher to a known good state.
cipher.init(Cipher.ENCRYPT_MODE, key);
}
}
if (failedOnce) {
throw failedReason;
}
System.out.println("\nTest Passed...");
}
private enum TestVariant {
HEAP_HEAP, HEAP_DIRECT, DIRECT_HEAP, DIRECT_DIRECT
};
private static void encrypt(Cipher cipher, int size,
ByteBuffer heapIn, ByteBuffer heapOut,
ByteBuffer directIn, ByteBuffer directOut,
boolean output) throws Exception {
ByteBuffer inBB = null;
ByteBuffer outBB = null;
// Set up data and encrypt to known/expected values.
byte[] testdata = new byte[size];
random.nextBytes(testdata);
byte[] expected = cipher.doFinal(testdata);
for (TestVariant tv : TestVariant.values()) {
if (output) {
System.out.print(" " + tv);
}
switch (tv) {
case HEAP_HEAP:
inBB = heapIn;
outBB = heapOut;
break;
case HEAP_DIRECT:
inBB = heapIn;
outBB = directOut;
break;
case DIRECT_HEAP:
inBB = directIn;
outBB = heapOut;
break;
case DIRECT_DIRECT:
inBB = directIn;
outBB = directOut;
break;
}
inBB.clear();
outBB.clear();
inBB.put(testdata);
inBB.flip();
// Process all data in one shot, but don't call doFinal() yet.
// May store up to n-1 bytes (w/block size n) internally.
cipher.update(inBB, outBB);
if (inBB.hasRemaining()) {
throw new Exception("buffer not empty");
}
// finish encryption and process all data buffered
cipher.doFinal(inBB, outBB);
outBB.flip();
// validate output size
if (outBB.remaining() != expected.length) {
throw new Exception(
"incomplete encryption output, expected "
+ expected.length + " bytes but was only "
+ outBB.remaining() + " bytes");
}
// validate output data
byte[] encrypted = new byte[outBB.remaining()];
outBB.get(encrypted);
if (!Arrays.equals(expected, encrypted)) {
throw new Exception("bad encryption output");
}
if (!Arrays.equals(cipher.doFinal(), cipher.doFinal())) {
throw new Exception("Internal buffers still held data!");
}
}
}
}
|
