File: TestMethodCommentsAlgorithm.java

package info (click to toggle)
openjdk-24 24.0.2%2B12-1
  • links: PTS, VCS
  • area: main
  • in suites: sid
  • size: 831,900 kB
  • sloc: java: 5,677,020; cpp: 1,323,154; xml: 1,320,524; ansic: 486,889; asm: 405,131; objc: 21,025; sh: 15,221; javascript: 11,049; python: 8,222; makefile: 2,504; perl: 357; awk: 351; sed: 172; pascal: 103; exp: 54; jsp: 24; csh: 3
file content (529 lines) | stat: -rw-r--r-- 21,272 bytes parent folder | download | duplicates (5)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
/*
 * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 */

/*
 * @test
 * @bug 8285368
 * @library /tools/lib ../../lib /test/lib
 * @modules jdk.javadoc/jdk.javadoc.internal.tool
 * @build toolbox.ToolBox javadoc.tester.*
 * @build jtreg.SkippedException
 * @run main TestMethodCommentsAlgorithm
 */

import java.io.IOError;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.InvalidPathException;
import java.nio.file.Path;
import java.nio.file.StandardOpenOption;
import java.util.Iterator;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import javax.lang.model.element.Modifier;
import javax.lang.model.type.TypeKind;
import javax.tools.ToolProvider;

import com.sun.source.doctree.DocCommentTree;
import com.sun.source.tree.CompilationUnitTree;
import com.sun.source.tree.IdentifierTree;
import com.sun.source.tree.MethodTree;
import com.sun.source.tree.PrimitiveTypeTree;
import com.sun.source.tree.Tree;
import com.sun.source.tree.VariableTree;
import com.sun.source.util.DocTrees;
import com.sun.source.util.JavacTask;
import com.sun.source.util.TreePath;
import com.sun.source.util.TreePathScanner;
import javadoc.tester.JavadocTester;
import jtreg.SkippedException;
import toolbox.ToolBox;

import static javadoc.tester.JavadocTester.Exit.OK;

/*
 * These tests assert search order for _undirected_ documentation inheritance by
 * following a series of javadoc runs on a progressively undocumented hierarchy
 * of supertypes.
 *
 * Design
 * ======
 *
 * Each test creates a hierarchy consisting of N types (T1, T2, ..., Tn) for
 * which the search order is to be asserted. N-1 types are created (T1, T2,
 * ..., T(n-1)) and one type, Tn, is implicitly present java.lang.Object.
 * T1 is a type under test; T2, T3, ..., T(n-1) are direct or indirect
 * supertypes of T1.
 *
 * By design, the index of a type is evocative of the order in which that type
 * should be considered for documentation inheritance. If T1 lacks a doc
 * comment, T2 should be considered next. If in turn T2 lacks a doc comment,
 * T3 should be considered after that, and so on. Finally, Tn, which is
 * java.lang.Object, whose documentation is ever-present, is considered.
 *
 * The test then runs javadoc N-1 times. Each run one fewer type has a doc
 * comment: for the i-th run (1 <= i < N), type Tj has a doc comment if and
 * only if j > i. So, for the i-th run, i comments are missing and N-i are
 * present. In particular, for the first run (i = 1) the only _missing_ doc
 * comment is that of T1 and for the last run (i = N-1) the only _available_
 * doc comment is that of java.lang.Object.
 *
 * The test challenges javadoc by asking the following question:
 *
 *     Whose documentation will T1 inherit if Tj (1 <= j <= i)
 *     do not have doc comments, but Tk (i < k <= N) do?
 *
 * For the i-th run the test checks that T1 inherits documentation of T(i+1).
 *
 * Technicalities
 * ==============
 *
 * 1. To follow search order up to and including java.lang.Object, these tests
 *    need to be able to inherit documentation for java.lang.Object. For that,
 *    the tests access doc comments of java.lang.Object. To get such access,
 *    the tests patch the java.base module.
 *
 * 2. The documentation for java.lang.Object is slightly amended for
 *    uniformity with test documentation and for additional test
 *    coverage.
 *
 * 3. While documentation for java.lang.Object is currently inaccessible outside
 *    of the JDK, these test mimic what happens when the JDK documentation is
 *    built.
 *
 * Note
 * ====
 *
 * If any of these tests cannot find a valid Object.java file in the test
 * environment, they will throw jtreg.SkippedException.
 */
public class TestMethodCommentsAlgorithm extends JavadocTester {

    private final ToolBox tb = new ToolBox();

    public static void main(String... args) throws Exception {
        new TestMethodCommentsAlgorithm().runTests();
    }

    /*
     * Tests that the documentation search order is as shown:
     *
     *               (5)
     *                ^
     *      *        /
     *     [7] (3) (4)
     *      ^   ^   ^
     *       \  |  /
     *        \ | /
     *         [2] (6)
     *          ^   ^
     *          |  /
     *          | /
     *         [1]
     */
    @Test
    public void testMixedHierarchyEquals(Path base) throws Exception {
        var javaBase = findJavaBase();
        for (int i = 1; i < 7; i++) {
            mixedHierarchyI(base, javaBase, i);
            new OutputChecker("mymodule/x/T1.html").check("""
                    <div class="block">T%s: main description</div>
                    """.formatted(i + 1), """
                    <dt>Parameters:</dt>
                    <dd><code>obj</code> - T%1$s: parameter description</dd>
                    <dt>Returns:</dt>
                    <dd>T%1$s: return description</dd>""".formatted(i + 1));
        }
    }

    /*
     * Generates source for the i-th run such that types whose index is less
     * than i provide no documentation and those whose index is greater or
     * equal to i provide documentation.
     */
    private void mixedHierarchyI(Path base, Path javaBase, int i) throws IOException {
        Path src = base.resolve("src-" + i);
        Path mod = base.resolve("src-" + i).resolve("mymodule");
        tb.writeJavaFiles(mod, """
                package x;
                public class T1 extends T2 implements T6 {
                %s
                    @Override public boolean equals(Object obj) { return super.equals(obj); }
                }
                """.formatted(generateDocComment(1, i)), """
                package x;
                public class T2 /* extends Object */ implements T3, T4 {
                %s
                    @Override public boolean equals(Object obj) { return super.equals(obj); }
                }
                """.formatted(generateDocComment(2, i)), """
                package x;
                public interface T3 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(3, i)), """
                package x;
                public interface T4 extends T5 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(4, i)), """
                package x;
                public interface T5 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(5, i)), """
                package x;
                public interface T6 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(6, i)), """
                module mymodule { }
                """);

        createPatchedJavaLangObject(javaBase.resolve("share").resolve("classes").toAbsolutePath(),
                Files.createDirectories(src.resolve("java.base")).toAbsolutePath(),
                generateDocComment(7, i, false));

        javadoc("-d", base.resolve("out-" + i).toAbsolutePath().toString(),
                "-tag", "apiNote:a:API Note:",
                "-tag", "implSpec:a:Implementation Requirements:",
                "-tag", "implNote:a:Implementation Note:",
                "--patch-module", "java.base=" + src.resolve("java.base").toAbsolutePath().toString(),
                "--module-source-path", src.toAbsolutePath().toString(),
                "mymodule/x");

        checkExit(OK);
    }

    private static String generateDocComment(int index, int run) {
        return generateDocComment(index, run, true);
    }

    /*
     * Provides a doc comment for an override of Object.equals in a type with
     * the specified index for the specified run.
     */
    private static String generateDocComment(int index, int run, boolean includeCommentMarkers) {
        if (index > run) {
            String s = """
                    T%s: main description
                    *
                    * @param obj T%1$s: parameter description
                    * @return T%1$s: return description""";
            if (includeCommentMarkers)
                s = "/**\n* " + s + "\n*/";
            return s.formatted(index).indent(4);
        } else {
            return "";
        }
    }

    /*
     * Tests that the documentation search order is as shown:
     *
     *    (3) (4)
     *     ^   ^
     *      \ /
     *      (2) (5)
     *       ^   ^
     *        \ /
     *        (1)
     *         |
     *         v
     *        [6]
     *         *
     */
    @Test
    public void testInterfaceHierarchy(Path base) throws Exception {
        var javaBase = findJavaBase();
        for (int i = 1; i < 6; i++) {
            interfaceHierarchyI(base, javaBase, i);
            new OutputChecker("mymodule/x/T1.html").check("""
                    <div class="block">T%s: main description</div>
                    """.formatted(i + 1), """
                    <dt>Parameters:</dt>
                    <dd><code>obj</code> - T%1$s: parameter description</dd>
                    <dt>Returns:</dt>
                    <dd>T%1$s: return description</dd>""".formatted(i + 1));
        }
    }

    /*
     * Nested/recursive `{@inheritDoc}` are processed before the comments that
     * refer to them. This test highlights that a lone `{@inheritDoc}` is
     * different from a missing/empty comment part.
     *
     * Whenever doclet sees `{@inheritDoc}` or `{@inheritDoc <supertype>}`
     * while searching for a comment to inherit from up the hierarchy, it
     * considers the comment found. A separate and unrelated search is
     * then performed for that found `{@inheritDoc}`.
     *
     * The test case is wrapped in a module in order to be able to patch
     * java.base (otherwise it doesn't seem to work).
     */
    @Test
    public void testRecursiveInheritDocTagsAreProcessedFirst(Path base) throws Exception {
        var javaBase = findJavaBase();
        Path src = base.resolve("src");
        tb.writeJavaFiles(src.resolve("mymodule"), """
                package x;
                public class S {
                    /** {@inheritDoc} */
                    public boolean equals(Object obj) { return super.equals(obj); }
                }
                """, """
                package x;
                public interface I {
                    /** I::equals */
                    boolean equals(Object obj);
                }
                """, """
                package x;
                public class T extends S implements I {
                    public boolean equals(Object obj) { return super.equals(obj); }
                }
                """, """
                module mymodule {}
                """);

        createPatchedJavaLangObject(javaBase.resolve("share").resolve("classes").toAbsolutePath(),
                Files.createDirectories(src.resolve("java.base")).toAbsolutePath(),
                "Object::equals");

        javadoc("-d", base.resolve("out").toString(),
                "-tag", "apiNote:a:API Note:",
                "-tag", "implSpec:a:Implementation Requirements:",
                "-tag", "implNote:a:Implementation Note:",
                "--patch-module", "java.base=" + src.resolve("java.base").toAbsolutePath().toString(),
                "--module-source-path", src.toAbsolutePath().toString(),
                "mymodule/x");

        checkExit(Exit.OK);

        new OutputChecker("mymodule/x/T.html").check("""
                <div class="block">Object::equals</div>""");
    }

    /*
     * Generates source for the i-th run such that types whose index is less
     * than i provide no documentation and those whose index is greater or
     * equal to i provide documentation.
     */
    private void interfaceHierarchyI(Path base, Path javaBase, int i) throws IOException {
        Path src = base.resolve("src-" + i);
        Path mod = base.resolve("src-" + i).resolve("mymodule");
        tb.writeJavaFiles(mod, """
                package x;
                public interface T1 extends T2, T5 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(1, i)), """
                package x;
                public interface T2 extends T3, T4 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(2, i)), """
                package x;
                public interface T3 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(3, i)), """
                package x;
                public interface T4 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(4, i)), """
                package x;
                public interface T5 {
                %s
                    @Override boolean equals(Object obj);
                }
                """.formatted(generateDocComment(5, i)), """
                module mymodule { }
                """);

        createPatchedJavaLangObject(javaBase.resolve("share").resolve("classes").toAbsolutePath(),
                Files.createDirectories(src.resolve("java.base")).toAbsolutePath(),
                generateDocComment(6, i, false));

        javadoc("-d", base.resolve("out-" + i).toAbsolutePath().toString(),
                "-tag", "apiNote:a:API Note:",
                "-tag", "implSpec:a:Implementation Requirements:",
                "-tag", "implNote:a:Implementation Note:",
                "--patch-module", "java.base=" + src.resolve("java.base").toAbsolutePath().toString(),
                "--module-source-path", src.toAbsolutePath().toString(),
                "mymodule/x");

        checkExit(OK);
    }

    /*
     * Locates source of the java.base module.
     */
    private Path findJavaBase() {
        String testSrc = System.getProperty("test.src");
        if (testSrc == null) {
            // shouldn't happen
            throw new SkippedException("test.src is not set");
        }
        Path start;
        try {
            start = Path.of(testSrc).toAbsolutePath();
        } catch (InvalidPathException | IOError e) {
            throw new SkippedException("Couldn't make sense of '" + testSrc + "'", e);
        }
        Path p = start;
        while (!Files.exists(p.resolve("TEST.ROOT"))) {
            p = p.getParent();
            if (p == null) {
                // shouldn't happen as jtreg won't even run a test without TEST.ROOT
                throw new SkippedException("Couldn't find TEST.ROOT above '" + start + "'");
            }
        }
        Path javaBase = p.resolve("../../src/java.base").normalize();
        out.println("Source for java.base is found at: " + javaBase);
        return javaBase;
    }

    /*
     * Finds java/lang/Object.java rooted at src, creates a copy of that file
     * _with the modified doc comment_ for Object.equals in dst, and returns
     * the path to that copy.
     */
    private Path createPatchedJavaLangObject(Path src, Path dst, String newComment) {
        var obj = Path.of("java/lang/Object.java");
        try {
            Optional<Path> files;
            try (var s = Files.find(src, Integer.MAX_VALUE,
                    (p, attr) -> attr.isRegularFile() && p.endsWith(obj))) {
                files = s.findAny();
            }
            if (files.isEmpty()) {
                throw new SkippedException("Couldn't find '" + obj + "' at '" + src + "'");
            }
            var original = files.get();
            out.println("Found '" + obj + "' at " + original.toAbsolutePath());
            var source = Files.readString(original);
            var region = findDocCommentRegion(original);
            var newSource = source.substring(0, region.start)
                    + newComment
                    + source.substring(region.end);
            // create intermediate directories in the destination first, otherwise
            // writeString will throw java.nio.file.NoSuchFileException
            var copy = dst.resolve(src.relativize(original));
            out.println("To be copied to '" + copy + "'");
            if (Files.notExists(copy.getParent())) {
                Files.createDirectories(copy.getParent());
            }
            return Files.writeString(copy, newSource, StandardOpenOption.CREATE);
        } catch (IOException e) {
            throw new SkippedException("Couldn't create patched '" + obj + "'", e);
        }
    }

    private static SourceRegion findDocCommentRegion(Path src) throws IOException {
        // to _reliably_ find the doc comment, parse the file and find source
        // position of the doc tree corresponding to that comment
        var compiler = ToolProvider.getSystemJavaCompiler();
        var fileManager = compiler.getStandardFileManager(null, null, null);
        var fileObject = fileManager.getJavaFileObjects(src).iterator().next();
        var task = (JavacTask) compiler.getTask(null, null, null, null, null, List.of(fileObject));
        Iterator<? extends CompilationUnitTree> iterator = task.parse().iterator();
        if (!iterator.hasNext()) {
            throw new SkippedException("Couldn't parse '" + src + "'");
        }
        var tree = iterator.next();
        var pathToEqualsMethod = findMethod(tree);
        if (pathToEqualsMethod == null) {
            throw new SkippedException("Couldn't find the equals method in '" + src + "'");
        }
        var trees = DocTrees.instance(task);
        DocCommentTree docCommentTree = trees.getDocCommentTree(pathToEqualsMethod);
        if (docCommentTree == null) {
            throw new SkippedException("Couldn't find documentation for the equals method at '" + src + "'");
        }
        var positions = trees.getSourcePositions();
        long start = positions.getStartPosition(null, docCommentTree, docCommentTree);
        long end = positions.getEndPosition(null, docCommentTree, docCommentTree);
        return new SourceRegion((int) start, (int) end);
    }

    private static TreePath findMethod(Tree src) {

        class Result extends RuntimeException {
            final TreePath p;

            Result(TreePath p) {
                super("", null, false, false); // lightweight exception to short-circuit scan
                this.p = p;
            }
        }

        var scanner = new TreePathScanner<Void, Void>() {
            @Override
            public Void visitMethod(MethodTree m, Void unused) {
                boolean solelyPublic = m.getModifiers().getFlags().equals(Set.of(Modifier.PUBLIC));
                if (!solelyPublic) {
                    return null;
                }
                var returnType = m.getReturnType();
                boolean returnsBoolean = returnType != null
                        && returnType.getKind() == Tree.Kind.PRIMITIVE_TYPE
                        && ((PrimitiveTypeTree) returnType).getPrimitiveTypeKind() == TypeKind.BOOLEAN;
                if (!returnsBoolean) {
                    return null;
                }
                boolean hasNameEquals = m.getName().toString().equals("equals");
                if (!hasNameEquals) {
                    return null;
                }
                List<? extends VariableTree> params = m.getParameters();
                if (params.size() != 1)
                    return null;
                var parameterType = params.getFirst().getType();
                if (parameterType.getKind() == Tree.Kind.IDENTIFIER &&
                        ((IdentifierTree) parameterType).getName().toString().equals("Object")) {
                    throw new Result(getCurrentPath());
                }
                return null;
            }
        };
        try {
            scanner.scan(src, null);
            return null; // not found
        } catch (Result e) {
            return e.p; // found
        }
    }

    record SourceRegion(int start, int end) { }
}