1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
|
/*
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package compiler.c2.irTests;
import jdk.test.lib.Asserts;
import jdk.test.lib.Utils;
import compiler.lib.ir_framework.*;
/*
* @test
* @bug 8345766
* @summary Test that Ideal transformations of ModDNode are being performed as expected.
* @library /test/lib /
* @run driver compiler.c2.irTests.ModDNodeTests
*/
public class ModDNodeTests {
public static final double q = Utils.getRandomInstance().nextDouble() * 100.0d;
public static void main(String[] args) {
TestFramework.run();
}
@Run(test = {"constant", "notConstant", "veryNotConstant",
"unusedResult",
"repeatedlyUnused",
"unusedResultAfterLoopOpt1",
"unusedResultAfterLoopOpt2",
"unusedResultAfterLoopOpt3",
})
public void runMethod() {
Asserts.assertEQ(constant(), q % 72.0d % 30.0d);
Asserts.assertEQ(alsoConstant(), q % 31.432d);
Asserts.assertTrue(Double.isNaN(nanLeftConstant()));
Asserts.assertTrue(Double.isNaN(nanRightConstant()));
Asserts.assertEQ(notConstant(37.5d), 37.5d % 32.0d);
Asserts.assertEQ(veryNotConstant(531.25d, 14.5d), 531.25d % 32.0d % 14.5d);
unusedResult(1.1d, 2.2d);
repeatedlyUnused(1.1d, 2.2d);
Asserts.assertEQ(unusedResultAfterLoopOpt1(1.1d, 2.2d), 0.d);
Asserts.assertEQ(unusedResultAfterLoopOpt2(1.1d, 2.2d), 0.d);
Asserts.assertEQ(unusedResultAfterLoopOpt3(1.1d, 2.2d), 0.d);
}
@Test
@IR(failOn = {"drem"}, phase = CompilePhase.BEFORE_MATCHING)
@IR(counts = {IRNode.CON_D, "1"})
public double constant() {
// All constants available during parsing
return q % 72.0d % 30.0d;
}
@Test
@IR(failOn = {"drem"}, phase = CompilePhase.BEFORE_MATCHING)
@IR(counts = {IRNode.CON_D, "1"})
public double alsoConstant() {
// Make sure value is only available after second loop opts round
double val = 0;
for (int i = 0; i < 4; i++) {
if ((i % 2) == 0) {
val = q;
}
}
return val % 31.432d;
}
@Test
@IR(failOn = {"drem"}, phase = CompilePhase.BEFORE_MATCHING)
@IR(counts = {IRNode.CON_D, "1"})
public double nanLeftConstant() {
// Make sure value is only available after second loop opts round
double val = 134.18d;
for (int i = 0; i < 4; i++) {
if ((i % 2) == 0) {
val = Double.NaN;
}
}
return 56.234d % (val % 31.432d);
}
@Test
@IR(failOn = {"drem"}, phase = CompilePhase.BEFORE_MATCHING)
@IR(counts = {IRNode.CON_D, "1"})
public double nanRightConstant() {
// Make sure value is only available after second loop opts round
double val = 134.18d;
for (int i = 0; i < 4; i++) {
if ((i % 2) == 0) {
val = Double.NaN;
}
}
return 56.234d % (31.432d % val);
}
@Test
@IR(counts = {"drem", "1"}, phase = CompilePhase.BEFORE_MATCHING)
@IR(counts = {IRNode.CON_D, "1"})
public double notConstant(double x) {
return x % 32.0d;
}
@Test
@IR(counts = {"drem", "2"}, phase = CompilePhase.BEFORE_MATCHING)
@IR(counts = {IRNode.CON_D, "1"})
public double veryNotConstant(double x, double y) {
return x % 32.0d % y;
}
@Test
@IR(failOn = IRNode.MOD_D, phase = CompilePhase.ITER_GVN1)
@IR(counts = {IRNode.MOD_D, "1"}, phase = CompilePhase.AFTER_PARSING)
public void unusedResult(double x, double y) {
double unused = x % y;
}
@Test
@IR(failOn = IRNode.MOD_D, phase = CompilePhase.ITER_GVN1)
@IR(counts = {IRNode.MOD_D, "1"}, phase = CompilePhase.AFTER_PARSING)
public void repeatedlyUnused(double x, double y) {
double unused = 1.d;
for (int i = 0; i < 100_000; i++) {
unused = x % y;
}
}
// The difference between unusedResultAfterLoopOpt1 and unusedResultAfterLoopOpt2
// is that they exercise a slightly different reason why the node is being removed,
// and thus a different execution path. In unusedResultAfterLoopOpt1 the modulo is
// used in the traps of the parse predicates. In unusedResultAfterLoopOpt2, it is not.
@Test
@IR(counts = {IRNode.MOD_D, "1"}, phase = CompilePhase.ITER_GVN2)
@IR(failOn = IRNode.MOD_D, phase = CompilePhase.BEFORE_MACRO_EXPANSION)
public double unusedResultAfterLoopOpt1(double x, double y) {
double unused = x % y;
int a = 77;
int b = 0;
do {
a--;
b++;
} while (a > 0);
if (b == 78) { // dead
return unused;
}
return 0.d;
}
@Test
@IR(counts = {IRNode.MOD_D, "1"}, phase = CompilePhase.AFTER_CLOOPS)
@IR(failOn = IRNode.MOD_D, phase = CompilePhase.PHASEIDEALLOOP1)
public double unusedResultAfterLoopOpt2(double x, double y) {
int a = 77;
int b = 0;
do {
a--;
b++;
} while (a > 0);
double unused = x % y;
if (b == 78) { // dead
return unused;
}
return 0.d;
}
@Test
@IR(counts = {IRNode.MOD_D, "2"}, phase = CompilePhase.AFTER_CLOOPS)
@IR(failOn = IRNode.MOD_D, phase = CompilePhase.PHASEIDEALLOOP1)
public double unusedResultAfterLoopOpt3(double x, double y) {
double unused = x % y;
int a = 77;
int b = 0;
do {
a--;
b++;
} while (a > 0);
int other = (b - 77) * (int)(x % y % 1.d);
return (double)other;
}
}
|
