1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
|
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8235564
* @summary Verify that passing member references to a method not accepting
* functional interface does not crash the compiler.
* @library /tools/lib /tools/javac/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.file
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.util
* @build toolbox.ToolBox toolbox.JavacTask
* @build combo.ComboTestHelper
* @compile T8235564.java
* @run main T8235564
*/
import combo.ComboInstance;
import combo.ComboParameter;
import combo.ComboTask;
import combo.ComboTestHelper;
import java.io.StringWriter;
import java.util.ArrayList;
import java.util.List;
import java.util.stream.Collectors;
import javax.tools.Diagnostic;
import toolbox.ToolBox;
public class T8235564 extends ComboInstance<T8235564> {
protected ToolBox tb;
T8235564() {
super();
tb = new ToolBox();
}
public static void main(String... args) throws Exception {
new ComboTestHelper<T8235564>()
.withDimension("INVOCATION", (x, invocation) -> x.invocation = invocation, Invocation.values())
.withDimension("PARAM", (x, param) -> x.param = param, Parameter.values())
.run(T8235564::new);
}
private Invocation invocation;
private Parameter param;
private static final String MAIN_TEMPLATE =
"""
public class Test {
static void test() {
Runnable r = () -> {};
#{INVOCATION};
}
private static void existingWithFunctional(Runnable r) {}
private static void existingWithoutFunctional(String parameter) {}
}
""";
@Override
protected void doWork() throws Throwable {
StringWriter out = new StringWriter();
ComboTask task = newCompilationTask()
.withSourceFromTemplate(MAIN_TEMPLATE, pname -> switch (pname) {
case "INVOCATION" -> invocation;
case "PARAM" -> param;
default -> throw new UnsupportedOperationException(pname);
})
.withOption("-XDshould-stop.at=FLOW")
.withOption("-XDrawDiagnostics")
.withOption("-XDdev")
.withWriter(out);
task.analyze(result -> {
List<String> diags = result.diagnosticsForKind(Diagnostic.Kind.ERROR)
.stream()
.map(d -> d.getLineNumber() + ":" + d.getCode())
.collect(Collectors.toList());
List<String> expected = new ArrayList<>();
switch (param) {
case VALID_VARIABLE, VALID_LAMBDA, VALID_MEMBER_REF -> {}
case UNDEFINED_VARIABLE ->
expected.add("4:compiler.err.cant.resolve.location");
case UNDEFINED_METHOD, UNDEFINED_LAMBDA ->
expected.add("4:compiler.err.cant.resolve.location.args");
case UNDEFINED_MEMBER_REF ->
expected.add("4:compiler.err.invalid.mref");
case UNDEFINED_CONDEXPR -> {
if (invocation != Invocation.EXISTING_WITHOUT_FUNCTIONAL) {
expected.add("4:compiler.err.invalid.mref");
expected.add("4:compiler.err.invalid.mref");
}
}
}
switch (invocation) {
case EXISTING_WITH_FUNCTIONAL -> {
if (param == Parameter.UNDEFINED_CONDEXPR) {
expected.add("4:compiler.err.cant.apply.symbol");
}
}
case EXISTING_WITHOUT_FUNCTIONAL -> {
if (param != Parameter.UNDEFINED_VARIABLE &&
param != Parameter.UNDEFINED_MEMBER_REF &&
param != Parameter.UNDEFINED_METHOD) {
expected.add("4:compiler.err.cant.apply.symbol");
}
}
case UNDEFINED -> {
if (param != Parameter.UNDEFINED_VARIABLE &&
param != Parameter.UNDEFINED_MEMBER_REF &&
param != Parameter.UNDEFINED_METHOD) {
expected.add("4:compiler.err.cant.resolve.location.args");
}
}
}
if (!expected.equals(diags)) {
throw new AssertionError("Expected errors not found, expected: " + expected + ", actual: " + diags);
}
if (out.toString().length() > 0) {
throw new AssertionError("No output expected, but got:\n" + out + "\n\n" + result.compilationInfo());
}
});
}
public enum Invocation implements ComboParameter {
EXISTING_WITH_FUNCTIONAL("existingWithFunctional(#{PARAM})"),
EXISTING_WITHOUT_FUNCTIONAL("existingWithoutFunctional(#{PARAM})"),
UNDEFINED("undefined(#{PARAM})");
private final String invocation;
private Invocation(String invocation) {
this.invocation = invocation;
}
@Override
public String expand(String optParameter) {
return invocation;
}
}
public enum Parameter implements ComboParameter {
VALID_VARIABLE("r"),
VALID_LAMBDA("() -> {}"),
VALID_MEMBER_REF("Test::test"),
UNDEFINED_VARIABLE("undefined"),
UNDEFINED_LAMBDA("() -> {undefined();}"),
UNDEFINED_MEMBER_REF("Test::undefined"),
UNDEFINED_METHOD("undefined()"),
UNDEFINED_CONDEXPR("1 == 2 ? Test::undefined : Test::undefined");
private final String code;
private Parameter(String code) {
this.code = code;
}
@Override
public String expand(String optParameter) {
return code;
}
}
}
|
