1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
|
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8260593
* @summary Verify that a temporary storage variable is or is not used as needed when pattern matching.
* @library /tools/lib /tools/javac/lib
* @modules
* jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.file
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.util
* @build toolbox.ToolBox toolbox.JavacTask
* @build combo.ComboTestHelper
* @compile LocalVariableReuse.java
* @run main LocalVariableReuse
*/
import combo.ComboInstance;
import combo.ComboParameter;
import combo.ComboTask;
import combo.ComboTestHelper;
import java.io.IOException;
import javax.tools.JavaFileObject;
import toolbox.ToolBox;
public class LocalVariableReuse extends ComboInstance<LocalVariableReuse> {
protected ToolBox tb;
LocalVariableReuse() {
super();
tb = new ToolBox();
}
public static void main(String... args) throws Exception {
new ComboTestHelper<LocalVariableReuse>()
.withDimension("CODE", (x, code) -> x.code = code, Code.values())
.run(LocalVariableReuse::new);
}
private Code code;
private static final String MAIN_TEMPLATE =
"""
public class Test {
#{CODE}
}
""";
@Override
protected void doWork() throws Throwable {
ComboTask task = newCompilationTask()
.withSourceFromTemplate(MAIN_TEMPLATE, pname -> switch (pname) {
case "CODE" -> code;
default -> throw new UnsupportedOperationException(pname);
});
task.withOption("-printsource");
task.generate(result -> {
for (JavaFileObject out : result.get()) {
try {
String actualDesugared = out.getCharContent(false).toString();
boolean hasTempVar = actualDesugared.contains("$temp");
if (hasTempVar != code.useTemporaryVariable) {
throw new AssertionError("Expected temporary variable: " + code.useTemporaryVariable +
", but got: " + actualDesugared);
}
} catch (IOException ex) {
throw new AssertionError(ex);
}
}
});
}
public enum Code implements ComboParameter {
LOCAL_VARIABLE(
"""
private boolean test() {
Object o = null;
return o instanceof String s && s.length() > 0;
}
""", false),
PARAMETER(
"""
private boolean test(Object o) {
return o instanceof String s && s.length() > 0;
}
""", false),
LAMBDA_PARAMETER(
"""
private void test(Object o) {
I i = o -> o instanceof String s && s.length() > 0;
interface I {
public boolean run(Object o);
}
""", false),
EXCEPTION(
"""
private boolean test() {
try {
throw new Exception();
} catch (Exception o) {
return o instanceof RuntimeException re && re.getMessage() != null;
}
}
""", false),
RESOURCE(
"""
private boolean test() throws Exception {
try (AutoCloseable r = null) {
return r instanceof java.io.InputStream in && in.read() != (-1);
} catch (Exception o) {
}
}
""", false),
FIELD("""
private Object o;
private boolean test() {
return o instanceof String s && s.length() > 0;
}
""",
true),
FINAL_FIELD("""
private final Object o;
private boolean test() {
return o instanceof String s && s.length() > 0;
}
""",
true),
ARRAY_ACCESS("""
private boolean test() {
Object[] o = null;
return o[0] instanceof String s && s.length() > 0;
}
""",
true),
METHOD_INVOCATION("""
private boolean test() {
return get() instanceof String s && s.length() > 0;
}
private Object get() {
return null;
}
""",
true),
;
private final String body;
private final boolean useTemporaryVariable;
private Code(String body, boolean useTemporaryVariable) {
this.body = body;
this.useTemporaryVariable = useTemporaryVariable;
}
@Override
public String expand(String optParameter) {
return body;
}
}
}
|
