1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474
|
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8294942
* @summary Check compilation outcomes for various combinations of case label element.
* @library /tools/lib /tools/javac/lib
* @modules
* jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.file
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.util
* @build toolbox.ToolBox toolbox.JavacTask
* @compile NewCaseStructureTest.java
* @run main NewCaseStructureTest
*/
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.*;
import toolbox.JavacTask;
import toolbox.Task;
import toolbox.TestRunner;
import toolbox.ToolBox;
public class NewCaseStructureTest extends TestRunner {
private static final String JAVA_VERSION = System.getProperty("java.specification.version");
ToolBox tb;
public static void main(String... args) throws Exception {
new NewCaseStructureTest().runTests();
}
NewCaseStructureTest() {
super(System.err);
tb = new ToolBox();
}
public void runTests() throws Exception {
runTests(m -> new Object[] { Paths.get(m.getName()) });
}
@Test
public void testCorrectMultiLabelCaseStructure(Path base) throws Exception {
for (String pattern : new String[] {"String s",
"R(int i)",
"null, default",
"null",
"1",
"1, 2",
"1, 2, 3"}) {
for (String sep : new String[] {":", "->"}) {
doTest(base,
"""
package test;
public class Test {
private int test(${switchType} obj) {
return switch (obj) {
case ${pattern} ${sep} { yield 0; }
${default}
};
}
}
record R(int i) {}
""".replace("${switchType}", pattern.contains("1") ? "Integer" : "Object")
.replace("${pattern}", pattern)
.replace("${sep}", sep)
.replace("${default}", pattern.contains("default") ? "" : "default " + sep + " { yield 1; }"),
false);
}
}
}
@Test
public void testMalformedCaseStructure(Path base) throws Exception {
for (String pattern : new String[] {"String s, Integer i",
"String s, R(int i)",
"E1(), E2()",
"String s, null",
"String s, default",
"String s, null, default",
"null, String s",
"null, default, String s",
"default, String s",
"1, Integer i",
"1, 2, 3, Integer i",
"Integer i, 1, 2, 3",
"1, null",
"1, 2, 3, null",
"null, 1, 2, 3",
"default, null",
"default"}) {
for (String sep : new String[] {":", "->"}) {
doTest(base,
"""
package test;
public class Test {
private int test(${switchType} obj) {
return switch (obj) {
case ${pattern} ${sep} { yield 0; }
${default}
};
}
}
record R(int i) {}
record E1() {}
record E2() {}
""".replace("${switchType}", pattern.contains("1") ? "Integer" : "Object")
.replace("${pattern}", pattern)
.replace("${sep}", sep)
.replace("${default}", pattern.contains("default") ? "" : "default " + sep + " { yield 1; }"),
true);
}
}
}
@Test
public void testSwitchLabeledStatementGroups(Path base) throws Exception {
doTest(base,
"""
package test;
public class Test {
private int test(Object o) {
return switch (o) {
case null:
case Object obj: System.err.println(); yield 0;
};
}
}
""",
"Test.java:6:18: compiler.err.flows.through.to.pattern",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Object o) {
return switch (o) {
case null: System.err.println();
case Object obj: System.err.println(); yield 0;
};
}
}
""",
"Test.java:6:18: compiler.err.flows.through.to.pattern",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Object o) {
return switch (o) {
case Object obj:
case null: System.err.println(); yield 0;
};
}
}
""",
"Test.java:5:18: compiler.err.flows.through.from.pattern",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Object o) {
return switch (o) {
case Object obj: System.err.println();
case null: System.err.println();
yield 0;
};
}
}
""");
doTest(base,
"""
package test;
public class Test {
private int test(Object o) {
return switch (o) {
case String s: System.err.println();
case E1(): System.err.println(); yield 0;
default: yield 0;
};
}
}
record E1() {}
""");
doTest(base,
"""
package test;
public class Test {
private int test(Object o) {
return switch (o) {
case String s: System.err.println();
default: System.err.println(); yield 0;
};
}
}
""");
doTest(base,
"""
package test;
public class Test {
private void test(Object o) {
switch (o) {
case String s:
case Integer i:
case Object obj:
}
}
}
""");
doTest(base,
"""
package test;
public class Test {
private void test(Object o) {
switch (o) {
case Object obj: System.err.println();
case null: System.err.println(obj);
}
}
}
""",
"Test.java:6:43: compiler.err.cant.resolve.location: kindname.variable, obj, , , (compiler.misc.location: kindname.class, test.Test, null)",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
case default -> 0;
case 0 -> 0;
};
}
}
""",
"Test.java:5:18: compiler.err.default.label.not.allowed",
"1 error");
}
@Test
public void testDominance(Path base) throws Exception {
//A case label with a case pattern p (guarded or unguarded) dominates another case label with a case constant c if p dominates c, which is defined as follows:
// (unguarded case with) A type pattern that declares a pattern variable of type T dominates a constant c of a primitive type P if the wrapper class of P ([5.1.7]) is a subtype of the erasure of T.
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
case Integer i when i > 0 -> 0;
case 0 -> 0;
case Integer i -> 0;
};
}
}
""");
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
case Integer i -> 0;
case 0 -> 0;
};
}
}
""",
"Test.java:6:18: compiler.err.pattern.dominated",
"1 error");
// (unguarded case with) A type pattern that declares a pattern variable of type T dominates an enum constant c of type E if E is a subtype of the erasure of the type of T.
doTest(base,
"""
package test;
public class Test {
private int test(E o) {
return switch (o) {
case E e when e == E.A -> 0;
case B -> 0;
case E e -> 0;
};
}
}
enum E {A, B;}
""");
doTest(base,
"""
package test;
public class Test {
private int test(E o) {
return switch (o) {
case E e -> 0;
case B -> 0;
};
}
}
enum E {A, B;}
""",
"Test.java:6:18: compiler.err.pattern.dominated",
"1 error");
//dtto for String:
doTest(base,
"""
package test;
public class Test {
private int test(String o) {
return switch (o) {
case String s when s.isEmpty() -> 0;
case "a" -> 0;
case String s -> 0;
};
}
}
""");
doTest(base,
"""
package test;
public class Test {
private int test(String o) {
return switch (o) {
case String s -> 0;
case "a" -> 0;
};
}
}
""",
"Test.java:6:18: compiler.err.pattern.dominated",
"1 error");
// A default label dominates a case label with a case pattern, and it also dominates a case label with a null case constant.
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
default -> 0;
case Integer i when i > 0 -> 0;
case Integer i when i > 0 -> 0;
};
}
}
""",
"Test.java:6:18: compiler.err.pattern.dominated",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
case Integer i when i > 0 -> 0;
default -> 0;
case null -> 0;
};
}
}
""",
"Test.java:7:18: compiler.err.pattern.dominated",
"1 error");
// case label with a default dominates all other switch labels.
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
case null, default -> 0;
case Integer i when i > 0 -> 0;
};
}
}
""",
"Test.java:6:18: compiler.err.pattern.dominated",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
case null, default -> 0;
case 0 -> 0;
case 1 -> 0;
};
}
}
""",
"Test.java:6:18: compiler.err.pattern.dominated",
"1 error");
doTest(base,
"""
package test;
public class Test {
private int test(Integer o) {
return switch (o) {
default -> 0;
case 0 -> 0;
};
}
}
""");
}
private void doTest(Path base, String testCode, boolean expectErrors) throws IOException {
doTest(base, testCode, expectErrors, (String[]) null);
}
private void doTest(Path base, String testCode, String... output) throws IOException {
doTest(base, testCode, output != null && output.length > 0, output);
}
private void doTest(Path base, String testCode, boolean expectErrors, String... output) throws IOException {
Path current = base.resolve(".");
Path src = current.resolve("src");
tb.writeJavaFiles(src, testCode);
Path classes = current.resolve("classes");
Files.createDirectories(classes);
List<String> actual = new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Xlint:-preview",
"-XDshould-stop.at=FLOW")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(expectErrors? Task.Expect.FAIL : Task.Expect.SUCCESS)
.writeAll()
.getOutputLines(Task.OutputKind.DIRECT);
if (output != null) {
actual.remove("- compiler.note.preview.filename: Test.java, DEFAULT");
actual.remove("- compiler.note.preview.recompile");
actual.remove("");
List<String> expected = List.of(output);
if (!Objects.equals(expected, actual)) {
throw new AssertionError("Unexpected output: " + actual);
}
}
}
}
|