1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
|
/*
* Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* @test
* @bug 8291769 8300195
* @summary Verify the compiled code does not have unwanted constructs.
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.util
* jdk.jdeps/com.sun.tools.javap
* @build toolbox.ToolBox toolbox.JavacTask
* @run main PatternDesugaring
*/
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.PrintStream;
import java.lang.reflect.Method;
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Objects;
import java.util.function.Consumer;
import toolbox.TestRunner;
import toolbox.JavacTask;
import toolbox.JavapTask;
import toolbox.Task;
import toolbox.ToolBox;
public class PatternDesugaring extends TestRunner {
ToolBox tb;
public static void main(String... args) throws Exception {
new PatternDesugaring().runTests();
}
PatternDesugaring() {
super(System.err);
tb = new ToolBox();
}
public void runTests() throws Exception {
runTests(m -> new Object[] { Paths.get(m.getName()) });
}
@Test
public void testPrimitiveNoBoxUnbox(Path base) throws Exception {
doTest(base,
new String[0],
"""
package test;
public class Test {
public int test(Object obj) {
return switch (obj) {
case R(int i) -> i;
default -> -1;
};
}
record R(int i) {}
}
""",
decompiled -> {
if (decompiled.contains("intValue") || decompiled.contains("valueOf")) {
throw new AssertionError("Has boxing/unboxing.");
}
});
doTest(base,
new String[0],
"""
package test;
public class Test {
public int test(Object obj) {
return obj instanceof R(int i) ? i : -1;
}
record R(int i) {}
}
""",
decompiled -> {
if (decompiled.contains("intValue") || decompiled.contains("valueOf")) {
throw new AssertionError("Has boxing/unboxing.");
}
});
}
@Test
public void testCacheRecordsForRecordPatterns(Path base) throws Exception {
doTest(base,
new String[0],
"""
package test;
public class Test {
public int test(Object obj) {
return switch (obj) {
case R(Integer i, Integer j, Integer k) -> i + j + k;
default -> -1;
};
}
record R(Integer i, Integer j, Integer k) {}
}
""",
decompiled -> {
if (decompiled.split("checkcast").length != 2) {
throw new AssertionError("Unexpected number of checkcasts.");
}
});
doTest(base,
new String[0],
"""
package test;
public class Test {
public int test(Object obj) {
return obj instanceof R(Integer i, Integer j, Integer k) ? i + j + k: -1;
}
record R(Integer i, Integer j, Integer k) {}
}
""",
decompiled -> {
if (decompiled.split("checkcast").length != 2) {
throw new AssertionError("Unexpected number of checkcasts.");
}
});
}
private void doTest(Path base, String[] libraryCode, String testCode, Consumer<String> validate) throws IOException {
Path current = base.resolve(".");
Path libClasses = current.resolve("libClasses");
Files.createDirectories(libClasses);
if (libraryCode.length != 0) {
Path libSrc = current.resolve("lib-src");
for (String code : libraryCode) {
tb.writeJavaFiles(libSrc, code);
}
new JavacTask(tb)
.outdir(libClasses)
.files(tb.findJavaFiles(libSrc))
.run();
}
Path src = current.resolve("src");
tb.writeJavaFiles(src, testCode);
Path classes = current.resolve("libClasses");
Files.createDirectories(libClasses);
var log =
new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Xlint:-preview",
"--class-path", libClasses.toString(),
"-XDshould-stop.at=FLOW")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Task.Expect.SUCCESS)
.writeAll();
var decompiled =
new JavapTask(tb)
.classpath(classes.toString())
.classes("test.Test")
.options("-s", "-verbose")
.run()
.writeAll()
.getOutput(Task.OutputKind.DIRECT);
System.err.println("decompiled: " + decompiled);
validate.accept(decompiled);
}
@Test
public void testRuleCases(Path base) throws Exception {
doTestRun(base,
new String[0],
"""
package test;
public class Test {
public static void main(String... args) {
System.out.println(test(new R("a")));
System.out.println(test(new R(3)));
System.out.println(test(new R(new R("a"))));
System.out.println(test(new R(new R(3))));
}
public static int test(Object obj) {
int res;
switch (obj) {
case R(String s) -> res = s.length();
case R(Integer i) -> res = i;
case R(R(String s)) -> res = 10 + s.length();
case R(R(Integer i)) -> res = 10 + i;
default -> res = -1;
}
return res;
}
record R(Object o) {}
}
""",
output -> {
String expectedOutput = """
1
3
11
13
""";
if (!Objects.equals(output, expectedOutput)) {
throw new AssertionError("Unexpected output," +
" expected: " + expectedOutput +
" actual: " + output);
}
});
}
private void doTestRun(Path base, String[] libraryCode, String testCode, Consumer<String> validate) throws Exception {
Path current = base.resolve(".");
Path libClasses = current.resolve("libClasses");
Files.createDirectories(libClasses);
if (libraryCode.length != 0) {
Path libSrc = current.resolve("lib-src");
for (String code : libraryCode) {
tb.writeJavaFiles(libSrc, code);
}
new JavacTask(tb)
.outdir(libClasses)
.files(tb.findJavaFiles(libSrc))
.run();
}
Path src = current.resolve("src");
tb.writeJavaFiles(src, testCode);
Path classes = current.resolve("libClasses");
Files.createDirectories(libClasses);
var log =
new JavacTask(tb)
.options("-XDrawDiagnostics",
"-Xlint:-preview",
"--class-path", libClasses.toString(),
"-XDshould-stop.at=FLOW")
.outdir(classes)
.files(tb.findJavaFiles(src))
.run(Task.Expect.SUCCESS)
.writeAll();
ClassLoader cl = new URLClassLoader(new URL[] {classes.toUri().toURL()});
Class<?> testClass = cl.loadClass("test.Test");
Method main = testClass.getMethod("main", String[].class);
PrintStream prevOut = System.out;
var data = new ByteArrayOutputStream();
try (var outStream = new PrintStream(data, true, StandardCharsets.UTF_8)) {
System.setOut(outStream);
main.invoke(null, (Object) new String[0]);
} finally {
System.setOut(prevOut);
}
String output = new String(data.toByteArray(), StandardCharsets.UTF_8);
output = output.replaceAll("\\R", "\n");
validate.accept(output);
}
}
|
