1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
|
/*
* Copyright (c) 2020, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @summary test binary compatibility rules for record classes
* @library /tools/lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
* jdk.compiler/com.sun.tools.javac.util
* jdk.compiler/com.sun.tools.javac.code
* @build toolbox.ToolBox toolbox.JavacTask
* @run main RecordsBinaryCompatibilityTests
*/
import java.util.*;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.stream.IntStream;
import com.sun.tools.javac.code.Flags;
import com.sun.tools.javac.util.Assert;
import toolbox.TestRunner;
import toolbox.ToolBox;
import toolbox.JavaTask;
import toolbox.JavacTask;
import toolbox.Task;
import toolbox.Task.OutputKind;
public class RecordsBinaryCompatibilityTests extends TestRunner {
ToolBox tb;
RecordsBinaryCompatibilityTests() {
super(System.err);
tb = new ToolBox();
}
protected void runTests() throws Exception {
runTests(m -> new Object[]{Paths.get(m.getName())});
}
public static void main(String... args) throws Exception {
RecordsBinaryCompatibilityTests t = new RecordsBinaryCompatibilityTests();
t.runTests();
}
Path[] findJavaFiles(Path... paths) throws IOException {
return tb.findJavaFiles(paths);
}
@Test
public void testCompatibilityAfterAddingRecordComponent(Path base) throws Exception {
testCompatibilityAfterModifyingRecord(
base,
"""
package pkg;
public record R(String i) {}
""",
"""
package pkg;
public record R(String i, String j) {}
""",
"""
package pkg;
public class Client {
public static void main(String... args) {
R r = new R("Hello World!");
System.out.println(r.i());
}
}
""",
true,
NoSuchMethodError.class
);
}
@Test
public void testCompatibilityAfterDeletingRecordComponent(Path base) throws Exception {
testCompatibilityAfterModifyingRecord(
base,
"""
package pkg;
public record R(String i, String j) {
public R(String j) {
this("Hello World!", j);
}
}
""",
"""
package pkg;
public record R(String j) {}
""",
"""
package pkg;
public class Client {
public static void main(String... args) {
R r = new R("Hi");
System.out.println(r.i());
}
}
""",
true,
NoSuchMethodError.class
);
}
@Test
public void testCompatibilityAfterChangingRecordComponent(Path base) throws Exception {
testCompatibilityAfterModifyingRecord(
base,
"""
package pkg;
public record R(String i, double j) {}
""",
"""
package pkg;
public record R(String i, int j) {}
""",
"""
package pkg;
public class Client {
public static void main(String... args) {
R r = new R("Hello World!", 1);
System.out.println(r.i());
}
}
""",
true,
NoSuchMethodError.class
);
}
@Test
public void testCompatibilityAfterReorderingRecordComponents(Path base) throws Exception {
testCompatibilityAfterModifyingRecord(
base,
"""
package pkg;
public record R(String i, int j) {}
""",
"""
package pkg;
public record R(int j, String i) {}
""",
"""
package pkg;
public class Client {
public static void main(String... args) {
R r = new R("Hello World!", 1);
System.out.println(r.i());
}
}
""",
true,
NoSuchMethodError.class
);
}
@Test
public void testCompatibilityAfterChangingRecordComponent2(Path base) throws Exception {
testCompatibilityAfterModifyingRecord(
base,
"""
package pkg;
public record R(String j) {
public static String i() { return "Hello World!"; }
}
""",
"""
package pkg;
public record R(String i) {}
""",
"""
package pkg;
public class Client {
public static void main(String... args) {
R r = new R("Hello World!");
System.out.println(r.i());
}
}
""",
true,
IncompatibleClassChangeError.class
);
}
@Test
public void testCompatibilityAfterChangingRecordComponent3(Path base) throws Exception {
testCompatibilityAfterModifyingRecord(
base,
"""
package pkg;
public record R(String i) {
}
""",
"""
package pkg;
public record R(String j) {}
""",
"""
package pkg;
public class Client {
public static void main(String... args) {
R r = new R("Hello World!");
System.out.println(r.i());
}
}
""",
true,
NoSuchMethodError.class
);
}
/* 1- compiles the first version of the record class source code along with the client source code
* 2- executes the client class just to make sure that it works
* 3- compiles the second version of the record class
* 4- executes the client class and makes sure that the VM throws the expected error or not
* depending on the shouldFail argument
*/
private void testCompatibilityAfterModifyingRecord(
Path base,
String recordCode1,
String recordCode2,
String clientCode,
boolean shouldFail,
Class<?> expectedError) throws Exception {
Path src = base.resolve("src");
Path pkg = src.resolve("pkg");
Path recordSrc = pkg.resolve("R");
Path client = pkg.resolve("Client");
tb.writeJavaFiles(recordSrc, recordCode1);
tb.writeJavaFiles(client, clientCode);
Path out = base.resolve("out");
Files.createDirectories(out);
new JavacTask(tb)
.outdir(out)
.files(findJavaFiles(pkg))
.run();
// let's execute to check that it's working
String output = new JavaTask(tb)
.classpath(out.toString())
.classArgs("pkg.Client")
.run()
.writeAll()
.getOutput(Task.OutputKind.STDOUT);
// let's first check that it runs wo issues
if (!output.contains("Hello World!")) {
throw new AssertionError("execution of Client didn't finish");
}
// now lets change the record class
tb.writeJavaFiles(recordSrc, recordCode2);
new JavacTask(tb)
.outdir(out)
.files(findJavaFiles(recordSrc))
.run();
if (shouldFail) {
// let's now check that we get the expected error
output = new JavaTask(tb)
.classpath(out.toString())
.classArgs("pkg.Client")
.run(Task.Expect.FAIL)
.writeAll()
.getOutput(Task.OutputKind.STDERR);
if (!output.startsWith("Exception in thread \"main\" " + expectedError.getName())) {
throw new AssertionError(expectedError.getName() + " expected");
}
} else {
new JavaTask(tb)
.classpath(out.toString())
.classArgs("pkg.Client")
.run(Task.Expect.SUCCESS);
}
}
}
|