File: libltdl-preopen-error.diff

package info (click to toggle)
openmpi 1.6.5-9.1%2Bdeb8u1
  • links: PTS, VCS
  • area: main
  • in suites: jessie
  • size: 91,628 kB
  • ctags: 44,305
  • sloc: ansic: 408,966; cpp: 44,454; sh: 27,828; makefile: 10,486; asm: 3,882; python: 1,239; lex: 805; perl: 549; csh: 253; fortran: 232; f90: 126; tcl: 12
file content (27 lines) | stat: -rw-r--r-- 1,114 bytes parent folder | download | duplicates (2)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
--- opal/libltdl/loaders/preopen.c.~1~	2010-03-03 14:13:28.000000000 -0500
+++ opal/libltdl/loaders/preopen.c	2010-03-05 17:57:11.000000000 -0500
@@ -185,7 +185,24 @@
 	}
     }
 
+#if 0
+  /* Open MPI: This line is commented out because Open MPI does not
+     use the preopen functionality in libltdl at all -- so we never
+     need to see errors from this module.  Additionally, this module
+     is usually invoked last in the sequence when trying to
+     lt_dlopenadvise() a DSO -- so if there was a real error when
+     opening that DSO (e.g., a symbol not found), setting the
+     FILE_NOT_FOUND error here will mask the real error.
+
+     This error has been reported upstream to the Libtool maintainers;
+     they acknowledge that it is a problem but no one has come up with
+     a good general solution yet.  This Open MPI-specific solution is
+     workable for us, but not workable as a general solution.  Hence,
+     we patch in this "if 0" block in autogen.sh after Libtool
+     installs libltdl in the opal/ tree.
+  */
   LT__SETERROR (FILE_NOT_FOUND);
+#endif
 
  done:
   return module;