1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370
|
# Unit tests for command_manager.py methods.
#
# Copyright 2025 Igalia, S.L.
# Author: Joanmarie Diggs <jdiggs@igalia.com>
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the
# Free Software Foundation, Inc., Franklin Street, Fifth Floor,
# Boston MA 02110-1301 USA.
# pylint: disable=wrong-import-position
# pylint: disable=import-outside-toplevel
# pylint: disable=protected-access
"""Unit tests for command_manager.py methods."""
from __future__ import annotations
from typing import TYPE_CHECKING
import pytest
if TYPE_CHECKING:
from unittest.mock import Mock
from .orca_test_context import OrcaTestContext
@pytest.mark.unit
class TestCommand:
"""Test Command base class methods."""
def _setup_dependencies(self, test_context: OrcaTestContext) -> dict[str, Mock]:
"""Returns dependencies for command_manager module testing."""
essential_modules = test_context.setup_shared_dependencies([])
input_event_mock = essential_modules["orca.input_event"]
input_event_mock.InputEventHandler = test_context.Mock
keybindings_mock = essential_modules["orca.keybindings"]
keybindings_mock.KeyBinding = test_context.Mock
keybindings_mock.KeyBindings = test_context.Mock
return essential_modules
def _create_mock_function(self, test_context: OrcaTestContext) -> Mock:
"""Creates a mock function for a Command."""
function = test_context.Mock()
function.return_value = True
return function
def test_init_minimal(self, test_context: OrcaTestContext) -> None:
"""Test Command.__init__ with minimal arguments."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command("testCommand", function, "Test Group")
assert command.get_name() == "testCommand"
assert command.get_function() == function
assert command.get_group_label() == "Test Group"
assert command.get_description() == ""
def test_init_full(self, test_context: OrcaTestContext) -> None:
"""Test Command.__init__ with all arguments."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command(
"fullCommand", function, "Full Group", "Full description", enabled=False, suspended=True
)
assert command.get_name() == "fullCommand"
assert command.get_function() == function
assert command.get_group_label() == "Full Group"
assert command.get_description() == "Full description"
assert command.is_enabled() is False
assert command.is_suspended() is True
def test_set_group_label(self, test_context: OrcaTestContext) -> None:
"""Test Command.set_group_label."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command("testCommand", function, "Original Group")
assert command.get_group_label() == "Original Group"
command.set_group_label("New Group")
assert command.get_group_label() == "New Group"
def test_init_enabled_suspended_defaults(self, test_context: OrcaTestContext) -> None:
"""Test that enabled defaults to True and suspended defaults to False."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command("testCommand", function, "Test Group")
assert command.is_enabled() is True
assert command.is_suspended() is False
def test_init_enabled_suspended_explicit(self, test_context: OrcaTestContext) -> None:
"""Test Command.__init__ with explicit enabled and suspended values."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command("testCommand", function, "Test Group", enabled=False, suspended=True)
assert command.is_enabled() is False
assert command.is_suspended() is True
def test_set_enabled(self, test_context: OrcaTestContext) -> None:
"""Test Command.set_enabled."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command("testCommand", function, "Test Group")
assert command.is_enabled() is True
command.set_enabled(False)
assert command.is_enabled() is False
command.set_enabled(True)
assert command.is_enabled() is True
def test_set_suspended(self, test_context: OrcaTestContext) -> None:
"""Test Command.set_suspended."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
command = Command("testCommand", function, "Test Group")
assert command.is_suspended() is False
command.set_suspended(True)
assert command.is_suspended() is True
command.set_suspended(False)
assert command.is_suspended() is False
def test_execute_calls_function(self, test_context: OrcaTestContext) -> None:
"""Test that execute calls the command's function."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
function.return_value = True
command = Command("testCommand", function, "Test Group")
mock_script = test_context.Mock()
mock_event = test_context.Mock()
result = command.execute(mock_script, mock_event)
function.assert_called_once_with(mock_script, mock_event)
assert result is True
def test_execute_returns_function_result(self, test_context: OrcaTestContext) -> None:
"""Test that execute returns the function's return value."""
self._setup_dependencies(test_context)
from orca.command_manager import Command
function = self._create_mock_function(test_context)
function.return_value = False
command = Command("testCommand", function, "Test Group")
mock_script = test_context.Mock()
result = command.execute(mock_script, None)
assert result is False
@pytest.mark.unit
class TestKeyboardCommand:
"""Test KeyboardCommand class methods."""
def _setup_dependencies(self, test_context: OrcaTestContext) -> dict[str, Mock]:
"""Returns dependencies for command_manager module testing."""
essential_modules = test_context.setup_shared_dependencies([])
input_event_mock = essential_modules["orca.input_event"]
input_event_mock.InputEventHandler = test_context.Mock
keybindings_mock = essential_modules["orca.keybindings"]
keybindings_mock.KeyBinding = test_context.Mock
keybindings_mock.KeyBindings = test_context.Mock
return essential_modules
def _create_mock_function(self, test_context: OrcaTestContext) -> Mock:
"""Creates a mock function for a Command."""
function = test_context.Mock()
function.return_value = True
return function
def _create_mock_keybinding(
self, test_context: OrcaTestContext, keyval: int = 65, keycode: int = 38
) -> Mock:
"""Creates a mock KeyBinding with default keyval/keycode for indexing."""
kb = test_context.Mock()
kb.keyval = keyval
kb.keycode = keycode
return kb
def test_init_minimal(self, test_context: OrcaTestContext) -> None:
"""Test KeyboardCommand.__init__ with minimal arguments."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
command = KeyboardCommand("testCommand", function, "Test Group")
assert command.get_name() == "testCommand"
assert command.get_function() == function
assert command.get_group_label() == "Test Group"
assert command.get_description() == ""
assert command.get_keybinding() is None
def test_init_with_keybindings(self, test_context: OrcaTestContext) -> None:
"""Test KeyboardCommand.__init__ with keybindings."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
desktop_kb = self._create_mock_keybinding(test_context)
laptop_kb = self._create_mock_keybinding(test_context)
command = KeyboardCommand(
"fullCommand",
function,
"Full Group",
"Full description",
desktop_keybinding=desktop_kb,
laptop_keybinding=laptop_kb,
)
assert command.get_name() == "fullCommand"
assert command.get_default_keybinding(is_desktop=True) == desktop_kb
assert command.get_default_keybinding(is_desktop=False) == laptop_kb
def test_set_keybinding(self, test_context: OrcaTestContext) -> None:
"""Test KeyboardCommand.set_keybinding."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
command = KeyboardCommand("testCommand", function, "Test Group")
assert command.get_keybinding() is None
new_kb = self._create_mock_keybinding(test_context)
command.set_keybinding(new_kb)
assert command.get_keybinding() == new_kb
command.set_keybinding(None)
assert command.get_keybinding() is None
def test_is_active_enabled_not_suspended_with_keybinding(
self, test_context: OrcaTestContext
) -> None:
"""Test is_active returns True when enabled, not suspended, and has keybinding."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
keybinding = self._create_mock_keybinding(test_context)
command = KeyboardCommand(
"testCommand", function, "Test Group", desktop_keybinding=keybinding
)
command.set_keybinding(keybinding)
assert command.is_active() is True
def test_is_active_disabled(self, test_context: OrcaTestContext) -> None:
"""Test is_active returns False when disabled."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
keybinding = self._create_mock_keybinding(test_context)
command = KeyboardCommand(
"testCommand", function, "Test Group", desktop_keybinding=keybinding, enabled=False
)
command.set_keybinding(keybinding)
assert command.is_active() is False
def test_is_active_suspended(self, test_context: OrcaTestContext) -> None:
"""Test is_active returns False when suspended."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
keybinding = self._create_mock_keybinding(test_context)
command = KeyboardCommand(
"testCommand", function, "Test Group", desktop_keybinding=keybinding, suspended=True
)
command.set_keybinding(keybinding)
assert command.is_active() is False
def test_is_active_no_keybinding(self, test_context: OrcaTestContext) -> None:
"""Test is_active returns False when no keybinding is assigned."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
command = KeyboardCommand("testCommand", function, "Test Group")
assert command.is_active() is False
def test_is_group_toggle_init(self, test_context: OrcaTestContext) -> None:
"""Test KeyboardCommand initializes is_group_toggle correctly."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand
function = self._create_mock_function(test_context)
# Default is False
cmd_default = KeyboardCommand("cmd1", function, "Test Group")
assert cmd_default.is_group_toggle() is False
# Explicit True
cmd_toggle = KeyboardCommand("cmd2", function, "Test Group", is_group_toggle=True)
assert cmd_toggle.is_group_toggle() is True
@pytest.mark.unit
class TestBrailleCommand:
"""Test BrailleCommand class methods."""
def _setup_dependencies(self, test_context: OrcaTestContext) -> dict[str, Mock]:
"""Returns dependencies for command_manager module testing."""
essential_modules = test_context.setup_shared_dependencies([])
input_event_mock = essential_modules["orca.input_event"]
input_event_mock.InputEventHandler = test_context.Mock
keybindings_mock = essential_modules["orca.keybindings"]
keybindings_mock.KeyBinding = test_context.Mock
keybindings_mock.KeyBindings = test_context.Mock
return essential_modules
def _create_mock_function(self, test_context: OrcaTestContext) -> Mock:
"""Creates a mock function for a Command."""
function = test_context.Mock()
function.return_value = True
return function
def test_braille_bindings_default_empty(self, test_context: OrcaTestContext) -> None:
"""Test that braille bindings default to empty tuple."""
self._setup_dependencies(test_context)
from orca.command_manager import BrailleCommand
function = self._create_mock_function(test_context)
command = BrailleCommand("testCommand", function, "Test Group")
assert command.get_braille_bindings() == ()
def test_init_with_braille_bindings(self, test_context: OrcaTestContext) -> None:
"""Test BrailleCommand.__init__ with braille bindings."""
self._setup_dependencies(test_context)
from orca.command_manager import BrailleCommand
function = self._create_mock_function(test_context)
command = BrailleCommand(
"testCommand", function, "Test Group", "Test description", braille_bindings=(1, 2, 3)
)
assert command.get_braille_bindings() == (1, 2, 3)
@pytest.mark.unit
class TestCommandManager:
"""Test CommandManager class methods."""
def _setup_dependencies(self, test_context: OrcaTestContext) -> dict[str, Mock]:
"""Returns dependencies for command_manager module testing."""
essential_modules = test_context.setup_shared_dependencies([])
input_event_mock = essential_modules["orca.input_event"]
input_event_mock.InputEventHandler = test_context.Mock
keybindings_mock = essential_modules["orca.keybindings"]
keybindings_mock.KeyBinding = test_context.Mock
keybindings_mock.KeyBindings = test_context.Mock
# Configure settings mock so _is_desktop is True (uses desktop keybindings)
settings_mock = essential_modules["orca.settings"]
settings_mock.GENERAL_KEYBOARD_LAYOUT_DESKTOP = 1
settings_mock.keyboardLayout = 1
return essential_modules
def _create_mock_function(
self,
test_context: OrcaTestContext,
description: str = "Test function",
) -> Mock:
"""Creates a mock function for a Command."""
function = test_context.Mock()
function.return_value = True
return function
def _create_mock_keybinding(
self, test_context: OrcaTestContext, keyval: int = 65, keycode: int = 38
) -> Mock:
"""Creates a mock KeyBinding with default keyval/keycode for indexing."""
kb = test_context.Mock()
kb.keyval = keyval
kb.keycode = keycode
kb.keysymstring = "a"
return kb
def test_init(self, test_context: OrcaTestContext) -> None:
"""Test CommandManager.__init__."""
self._setup_dependencies(test_context)
from orca.command_manager import CommandManager
manager = CommandManager()
assert manager.get_all_keyboard_commands() == ()
assert manager.get_all_braille_commands() == ()
def test_add_and_get_keyboard_command(self, test_context: OrcaTestContext) -> None:
"""Test CommandManager.add_command and get_keyboard_command."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
command = KeyboardCommand("testCommand", function, "Test Group")
manager.add_command(command)
retrieved = manager.get_keyboard_command("testCommand")
assert retrieved == command
assert manager.get_keyboard_command("nonexistent") is None
def test_get_all_keyboard_commands(self, test_context: OrcaTestContext) -> None:
"""Test CommandManager.get_all_keyboard_commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function1 = self._create_mock_function(test_context)
function2 = self._create_mock_function(test_context)
function3 = self._create_mock_function(test_context)
cmd1 = KeyboardCommand("cmd1", function1, "Group A")
cmd2 = KeyboardCommand("cmd2", function2, "Group B")
cmd3 = KeyboardCommand("cmd3", function3, "Group A")
manager.add_command(cmd1)
manager.add_command(cmd2)
manager.add_command(cmd3)
all_commands = manager.get_all_keyboard_commands()
assert len(all_commands) == 3
assert cmd1 in all_commands
assert cmd2 in all_commands
assert cmd3 in all_commands
def test_get_command_for_event_finds_match(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_event returns matching command."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
kb = self._create_mock_keybinding(test_context)
kb.matches.return_value = True
kb.modifiers = 4
kb.click_count = 1
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
event = test_context.Mock()
event.get_click_count.return_value = 1
event.id = 65
event.hw_code = 38
event.modifiers = 4
event.is_keypad_key_with_numlock_on.return_value = False
result = manager.get_command_for_event(event)
assert result == cmd
def test_get_command_for_event_no_match(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_event returns None when no match."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
kb = self._create_mock_keybinding(test_context)
kb.matches.return_value = False
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
event = test_context.Mock()
event.get_click_count.return_value = 1
event.id = 65
event.hw_code = 38
event.modifiers = 4
result = manager.get_command_for_event(event)
assert result is None
def test_get_command_for_event_skips_inactive(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_event skips inactive commands by default."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
kb = self._create_mock_keybinding(test_context)
kb.matches.return_value = True
kb.modifiers = 4
kb.click_count = 1
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb, suspended=True)
cmd.set_keybinding(kb)
manager.add_command(cmd)
event = test_context.Mock()
event.get_click_count.return_value = 1
event.id = 65
event.hw_code = 38
event.modifiers = 4
result = manager.get_command_for_event(event)
assert result is None
def test_get_command_for_event_includes_inactive(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_event can include inactive commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
kb = self._create_mock_keybinding(test_context)
kb.matches.return_value = True
kb.modifiers = 4
kb.click_count = 1
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb, suspended=True)
cmd.set_keybinding(kb)
manager.add_command(cmd)
event = test_context.Mock()
event.get_click_count.return_value = 1
event.id = 65
event.hw_code = 38
event.modifiers = 4
event.is_keypad_key_with_numlock_on.return_value = False
result = manager.get_command_for_event(event, active_only=False)
assert result == cmd
def test_get_command_for_braille_event_finds_match(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_braille_event returns matching command."""
self._setup_dependencies(test_context)
from orca.command_manager import BrailleCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
cmd = BrailleCommand("cmd", function, "Test Group", braille_bindings=(100, 200, 300))
manager.add_command(cmd)
result = manager.get_command_for_braille_event(200)
assert result == cmd
def test_get_command_for_braille_event_no_match(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_braille_event returns None when no match."""
self._setup_dependencies(test_context)
from orca.command_manager import BrailleCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
cmd = BrailleCommand("cmd", function, "Test Group", braille_bindings=(100, 200, 300))
manager.add_command(cmd)
result = manager.get_command_for_braille_event(999)
assert result is None
def test_get_command_for_braille_event_empty_bindings(
self, test_context: OrcaTestContext
) -> None:
"""Test get_command_for_braille_event returns None when command has no braille bindings."""
self._setup_dependencies(test_context)
from orca.command_manager import BrailleCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
cmd = BrailleCommand("cmd", function, "Test Group")
manager.add_command(cmd)
result = manager.get_command_for_braille_event(100)
assert result is None
def test_set_group_enabled(self, test_context: OrcaTestContext) -> None:
"""Test set_group_enabled sets enabled state for all commands in group."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function1 = self._create_mock_function(test_context)
function2 = self._create_mock_function(test_context)
function3 = self._create_mock_function(test_context)
cmd1 = KeyboardCommand("cmd1", function1, "Group A")
cmd2 = KeyboardCommand("cmd2", function2, "Group A")
cmd3 = KeyboardCommand("cmd3", function3, "Group B")
manager.add_command(cmd1)
manager.add_command(cmd2)
manager.add_command(cmd3)
manager.set_group_enabled("Group A", False)
assert cmd1.is_enabled() is False
assert cmd2.is_enabled() is False
assert cmd3.is_enabled() is True
def test_set_group_suspended(self, test_context: OrcaTestContext) -> None:
"""Test set_group_suspended sets suspended state for all commands in group."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function1 = self._create_mock_function(test_context)
function2 = self._create_mock_function(test_context)
function3 = self._create_mock_function(test_context)
cmd1 = KeyboardCommand("cmd1", function1, "Group A")
cmd2 = KeyboardCommand("cmd2", function2, "Group A")
cmd3 = KeyboardCommand("cmd3", function3, "Group B")
manager.add_command(cmd1)
manager.add_command(cmd2)
manager.add_command(cmd3)
manager.set_group_suspended("Group A", True)
assert cmd1.is_suspended() is True
assert cmd2.is_suspended() is True
assert cmd3.is_suspended() is False
def test_has_multi_click_bindings_true(self, test_context: OrcaTestContext) -> None:
"""Test has_multi_click_bindings returns True when multi-click binding exists."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Single-click binding (KP_Up keyval = 65431, keycode = 80)
kb1 = self._create_mock_keybinding(test_context, keyval=65431, keycode=80)
kb1.matches.return_value = True
kb1.click_count = 1
cmd1 = KeyboardCommand("readLine", function, "Flat Review", desktop_keybinding=kb1)
cmd1.set_keybinding(kb1)
manager.add_command(cmd1)
# Double-click binding for same key
kb2 = self._create_mock_keybinding(test_context, keyval=65431, keycode=80)
kb2.matches.return_value = True
kb2.click_count = 2
cmd2 = KeyboardCommand("spellLine", function, "Flat Review", desktop_keybinding=kb2)
cmd2.set_keybinding(kb2)
manager.add_command(cmd2)
assert manager.has_multi_click_bindings(65431, 80, 0) is True
def test_has_multi_click_bindings_false_single_only(
self, test_context: OrcaTestContext
) -> None:
"""Test has_multi_click_bindings returns False when only single-click binding exists."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Only single-click binding (KP_Home keyval = 65429, keycode = 79)
kb = self._create_mock_keybinding(test_context, keyval=65429, keycode=79)
kb.matches.return_value = True
kb.click_count = 1
cmd = KeyboardCommand("previousLine", function, "Flat Review", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
assert manager.has_multi_click_bindings(65429, 79, 0) is False
def test_has_multi_click_bindings_false_no_bindings(
self, test_context: OrcaTestContext
) -> None:
"""Test has_multi_click_bindings returns False when no bindings exist for key."""
self._setup_dependencies(test_context)
from orca.command_manager import CommandManager
manager = CommandManager()
# KP_Home keyval = 65429, keycode = 79
assert manager.has_multi_click_bindings(65429, 79, 0) is False
def test_has_multi_click_bindings_respects_modifiers(
self, test_context: OrcaTestContext
) -> None:
"""Test has_multi_click_bindings distinguishes by modifiers."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Double-click binding with Orca modifier (KP_Up keyval = 65431, keycode = 80)
kb = self._create_mock_keybinding(test_context, keyval=65431, keycode=80)
# matches() returns True only when modifiers=256
kb.matches.side_effect = lambda kv, kc, mods: mods == 256
kb.click_count = 2
cmd = KeyboardCommand("someCommand", function, "Test", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# With modifier: has multi-click
assert manager.has_multi_click_bindings(65431, 80, 256) is True
# Without modifier: no multi-click bindings
assert manager.has_multi_click_bindings(65431, 80, 0) is False
def test_get_command_for_event_shifted_key(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_event finds command via keycode when keyval differs (shifted)."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Command bound to 'h' (keyval=104, keycode=38)
kb = self._create_mock_keybinding(test_context, keyval=104, keycode=38)
kb.matches.return_value = True
kb.click_count = 1
cmd = KeyboardCommand("prevHeading", function, "Structural Nav", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Event has 'H' keyval (72) due to Shift, but same keycode (38)
event = test_context.Mock()
event.get_click_count.return_value = 1
event.id = 72 # 'H' keyval (shifted)
event.hw_code = 38 # Same keycode as 'h'
event.modifiers = 1 # Shift
event.is_keypad_key_with_numlock_on.return_value = False
result = manager.get_command_for_event(event)
assert result == cmd
def test_get_command_for_event_unshifted_key(self, test_context: OrcaTestContext) -> None:
"""Test get_command_for_event finds command via keyval for unshifted key."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Command bound to 'h' (keyval=104, keycode=38)
kb = self._create_mock_keybinding(test_context, keyval=104, keycode=38)
kb.matches.return_value = True
kb.click_count = 1
cmd = KeyboardCommand("nextHeading", function, "Structural Nav", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Event has 'h' keyval (104), no shift
event = test_context.Mock()
event.get_click_count.return_value = 1
event.id = 104 # 'h' keyval (unshifted)
event.hw_code = 38
event.modifiers = 0
event.is_keypad_key_with_numlock_on.return_value = False
result = manager.get_command_for_event(event)
assert result == cmd
def test_has_multi_click_bindings_shifted_key(self, test_context: OrcaTestContext) -> None:
"""Test has_multi_click_bindings finds binding via keycode when keyval differs."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Single-click binding for 'h' (keyval=104, keycode=38)
kb1 = self._create_mock_keybinding(test_context, keyval=104, keycode=38)
kb1.matches.return_value = True
kb1.click_count = 1
cmd1 = KeyboardCommand("nextHeading", function, "Structural Nav", desktop_keybinding=kb1)
cmd1.set_keybinding(kb1)
manager.add_command(cmd1)
# Double-click binding for same key
kb2 = self._create_mock_keybinding(test_context, keyval=104, keycode=38)
kb2.matches.return_value = True
kb2.click_count = 2
cmd2 = KeyboardCommand("listHeadings", function, "Structural Nav", desktop_keybinding=kb2)
cmd2.set_keybinding(kb2)
manager.add_command(cmd2)
# Query with 'H' keyval (72) due to Shift, but same keycode (38)
# Should find multi-click binding via keycode
assert manager.has_multi_click_bindings(72, 38, 1) is True
def test_has_multi_click_bindings_unshifted_key(self, test_context: OrcaTestContext) -> None:
"""Test has_multi_click_bindings finds binding via keyval for unshifted key."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Single-click binding for 'h' (keyval=104, keycode=38)
kb1 = self._create_mock_keybinding(test_context, keyval=104, keycode=38)
kb1.matches.return_value = True
kb1.click_count = 1
cmd1 = KeyboardCommand("nextHeading", function, "Structural Nav", desktop_keybinding=kb1)
cmd1.set_keybinding(kb1)
manager.add_command(cmd1)
# Double-click binding for same key
kb2 = self._create_mock_keybinding(test_context, keyval=104, keycode=38)
kb2.matches.return_value = True
kb2.click_count = 2
cmd2 = KeyboardCommand("listHeadings", function, "Structural Nav", desktop_keybinding=kb2)
cmd2.set_keybinding(kb2)
manager.add_command(cmd2)
# Query with 'h' keyval (104), unshifted - should find via keyval
assert manager.has_multi_click_bindings(104, 38, 0) is True
@pytest.mark.unit
class TestGetManager:
"""Test the get_manager singleton function."""
def _setup_dependencies(self, test_context: OrcaTestContext) -> dict[str, Mock]:
"""Returns dependencies for command_manager module testing."""
essential_modules = test_context.setup_shared_dependencies([])
input_event_mock = essential_modules["orca.input_event"]
input_event_mock.InputEventHandler = test_context.Mock
keybindings_mock = essential_modules["orca.keybindings"]
keybindings_mock.KeyBinding = test_context.Mock
keybindings_mock.KeyBindings = test_context.Mock
return essential_modules
def test_get_manager_returns_singleton(self, test_context: OrcaTestContext) -> None:
"""Test that get_manager returns the same instance."""
self._setup_dependencies(test_context)
from orca.command_manager import get_manager
manager1 = get_manager()
manager2 = get_manager()
assert manager1 is manager2
def test_get_manager_returns_command_manager(self, test_context: OrcaTestContext) -> None:
"""Test that get_manager returns a CommandManager instance."""
self._setup_dependencies(test_context)
from orca.command_manager import CommandManager, get_manager
manager = get_manager()
assert isinstance(manager, CommandManager)
@pytest.mark.unit
class TestDiffBasedGrabUpdates:
"""Test diff-based grab updates in CommandManager."""
def _setup_dependencies(self, test_context: OrcaTestContext) -> dict[str, Mock]:
"""Returns dependencies for command_manager module testing."""
essential_modules = test_context.setup_shared_dependencies(["orca.orca_modifier_manager"])
input_event_mock = essential_modules["orca.input_event"]
input_event_mock.InputEventHandler = test_context.Mock
keybindings_mock = essential_modules["orca.keybindings"]
keybindings_mock.KeyBinding = test_context.Mock
keybindings_mock.KeyBindings = test_context.Mock
orca_modifier_manager_mock = essential_modules["orca.orca_modifier_manager"]
modifier_manager_instance = test_context.Mock()
modifier_manager_instance.refresh_orca_modifiers = test_context.Mock()
orca_modifier_manager_mock.get_manager = test_context.Mock(
return_value=modifier_manager_instance
)
# Mock settings_manager for apply_user_overrides
settings_manager_mock = essential_modules["orca.settings_manager"]
settings_manager_instance = test_context.Mock()
settings_manager_instance.get_active_keybindings = test_context.Mock(return_value={})
settings_manager_mock.get_manager = test_context.Mock(
return_value=settings_manager_instance
)
# Configure settings mock so _is_desktop is True (uses desktop keybindings)
settings_mock = essential_modules["orca.settings"]
settings_mock.GENERAL_KEYBOARD_LAYOUT_DESKTOP = 1
settings_mock.keyboardLayout = 1
essential_modules["modifier_manager_instance"] = modifier_manager_instance
essential_modules["settings_manager_instance"] = settings_manager_instance
return essential_modules
def _create_mock_function(self, test_context: OrcaTestContext) -> Mock:
"""Creates a mock function for a Command."""
function = test_context.Mock()
function.return_value = True
return function
def _create_mock_keybinding(
self,
test_context: OrcaTestContext,
keysymstring: str = "a",
modifiers: int = 0,
click_count: int = 1,
keyval: int = 65,
keycode: int = 38,
) -> Mock:
"""Creates a mock KeyBinding with specified properties."""
kb = test_context.Mock()
kb.keysymstring = keysymstring
kb.modifiers = modifiers
kb.click_count = click_count
kb.keyval = keyval
kb.keycode = keycode
kb.has_grabs = test_context.Mock(return_value=False)
kb.add_grabs = test_context.Mock()
kb.remove_grabs = test_context.Mock()
kb.get_grab_ids = test_context.Mock(return_value=[])
kb.set_grab_ids = test_context.Mock()
return kb
def test_binding_key_returns_tuple(self, test_context: OrcaTestContext) -> None:
"""Test _binding_key returns correct tuple."""
self._setup_dependencies(test_context)
from orca.command_manager import CommandManager
manager = CommandManager()
kb = self._create_mock_keybinding(
test_context, keysymstring="h", modifiers=256, click_count=2
)
result = manager._binding_key(kb)
assert result == ("h", 256, 2)
def test_binding_key_returns_none_for_none(self, test_context: OrcaTestContext) -> None:
"""Test _binding_key returns None for None keybinding."""
self._setup_dependencies(test_context)
from orca.command_manager import CommandManager
manager = CommandManager()
assert manager._binding_key(None) is None
def test_binding_key_returns_none_for_empty_keysymstring(
self, test_context: OrcaTestContext
) -> None:
"""Test _binding_key returns None when keysymstring is empty."""
self._setup_dependencies(test_context)
from orca.command_manager import CommandManager
manager = CommandManager()
kb = self._create_mock_keybinding(test_context, keysymstring="")
assert manager._binding_key(kb) is None
def test_diff_transfers_grab_ids_for_matching_bindings(
self, test_context: OrcaTestContext
) -> None:
"""Test that grab IDs are transferred when bindings match."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Old command with grabs
old_kb = self._create_mock_keybinding(test_context, keysymstring="h", modifiers=256)
old_kb.has_grabs.return_value = True
old_kb.get_grab_ids.return_value = [42, 43]
old_cmd = KeyboardCommand("cmd", function, "Group", desktop_keybinding=old_kb)
old_cmd.set_keybinding(old_kb)
old_commands = {"cmd": old_cmd}
# New command with same binding but no grabs yet
new_kb = self._create_mock_keybinding(test_context, keysymstring="h", modifiers=256)
new_kb.has_grabs.return_value = False
new_cmd = KeyboardCommand("cmd", function, "Group", desktop_keybinding=new_kb)
new_cmd.set_keybinding(new_kb)
new_commands = {"cmd": new_cmd}
manager._keyboard_commands = old_commands
manager._diff_and_update_grabs(new_commands, "test")
# Verify grab IDs were transferred
new_kb.set_grab_ids.assert_called_once_with([42, 43])
old_kb.set_grab_ids.assert_called_once_with([])
# Neither add nor remove should be called
new_kb.add_grabs.assert_not_called()
old_kb.remove_grabs.assert_not_called()
def test_diff_removes_grabs_for_old_only_bindings(self, test_context: OrcaTestContext) -> None:
"""Test that grabs are removed for bindings only in old commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Old command with grabs
old_kb = self._create_mock_keybinding(test_context, keysymstring="h", modifiers=256)
old_kb.has_grabs.return_value = True
old_cmd = KeyboardCommand("old_cmd", function, "Group", desktop_keybinding=old_kb)
old_cmd.set_keybinding(old_kb)
old_commands = {"old_cmd": old_cmd}
# Empty new commands
new_commands: dict = {}
manager._keyboard_commands = old_commands
manager._diff_and_update_grabs(new_commands, "test")
# Verify grabs were removed
old_kb.remove_grabs.assert_called_once()
def test_diff_adds_grabs_for_new_only_bindings(self, test_context: OrcaTestContext) -> None:
"""Test that grabs are added for bindings only in new commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Empty old commands
old_commands: dict = {}
# New command without grabs
new_kb = self._create_mock_keybinding(test_context, keysymstring="h", modifiers=256)
new_kb.has_grabs.return_value = False
new_cmd = KeyboardCommand("new_cmd", function, "Group", desktop_keybinding=new_kb)
new_cmd.set_keybinding(new_kb)
new_commands = {"new_cmd": new_cmd}
manager._keyboard_commands = old_commands
manager._diff_and_update_grabs(new_commands, "test")
# Verify grabs were added
new_kb.add_grabs.assert_called_once()
def test_set_active_commands_uses_diff(self, test_context: OrcaTestContext) -> None:
"""Test set_active_commands uses diff-based updates."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Add initial command with grabs
old_kb = self._create_mock_keybinding(test_context, keysymstring="a")
old_kb.has_grabs.return_value = True
old_cmd = KeyboardCommand("old_cmd", function, "Group", desktop_keybinding=old_kb)
old_cmd.set_keybinding(old_kb)
manager.add_command(old_cmd)
# Set new commands
new_kb = self._create_mock_keybinding(test_context, keysymstring="b")
new_kb.has_grabs.return_value = False
new_cmd = KeyboardCommand("new_cmd", function, "Group", desktop_keybinding=new_kb)
new_cmd.set_keybinding(new_kb)
manager.set_active_commands({"new_cmd": new_cmd}, "test")
# Old binding should have grabs removed, new binding should have grabs added
old_kb.remove_grabs.assert_called_once()
new_kb.add_grabs.assert_called_once()
def test_activate_commands_applies_overrides(self, test_context: OrcaTestContext) -> None:
"""Test activate_commands applies user overrides."""
essential_modules = self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Add a command
kb = self._create_mock_keybinding(test_context, keysymstring="a")
cmd = KeyboardCommand("test_cmd", function, "Group", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Activate commands should apply user overrides
settings_manager = essential_modules["settings_manager_instance"]
settings_manager.get_active_keybindings.return_value = {}
manager.activate_commands("test")
# Should call get_active_keybindings to apply overrides
settings_manager.get_active_keybindings.assert_called()
def test_diff_skips_inactive_commands(self, test_context: OrcaTestContext) -> None:
"""Test that diff skips inactive commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Old command that is disabled (inactive)
old_kb = self._create_mock_keybinding(test_context, keysymstring="h")
old_kb.has_grabs.return_value = True
old_cmd = KeyboardCommand(
"cmd", function, "Group", desktop_keybinding=old_kb, enabled=False
)
old_cmd.set_keybinding(old_kb)
old_commands = {"cmd": old_cmd}
# New command that is also disabled
new_kb = self._create_mock_keybinding(test_context, keysymstring="h")
new_cmd = KeyboardCommand(
"cmd", function, "Group", desktop_keybinding=new_kb, enabled=False
)
new_cmd.set_keybinding(new_kb)
new_commands = {"cmd": new_cmd}
manager._keyboard_commands = old_commands
manager._diff_and_update_grabs(new_commands, "test")
# Neither should have grabs modified since both are inactive
old_kb.remove_grabs.assert_not_called()
new_kb.add_grabs.assert_not_called()
new_kb.set_grab_ids.assert_not_called()
def test_set_group_suspended_removes_grabs_when_suspending(
self, test_context: OrcaTestContext
) -> None:
"""Test set_group_suspended removes grabs when suspending active commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Active command with grabs
kb = self._create_mock_keybinding(test_context, keysymstring="h")
kb.has_grabs.return_value = True
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Suspend the group
manager.set_group_suspended("Test Group", True)
# Grabs should be removed
kb.remove_grabs.assert_called_once()
kb.add_grabs.assert_not_called()
def test_set_group_suspended_adds_grabs_when_unsuspending(
self, test_context: OrcaTestContext
) -> None:
"""Test set_group_suspended adds grabs when unsuspending commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Suspended command without grabs
kb = self._create_mock_keybinding(test_context, keysymstring="h")
kb.has_grabs.return_value = False
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb, suspended=True)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Unsuspend the group
manager.set_group_suspended("Test Group", False)
# Grabs should be added
kb.add_grabs.assert_called_once()
kb.remove_grabs.assert_not_called()
def test_set_group_suspended_no_change_when_already_in_state(
self, test_context: OrcaTestContext
) -> None:
"""Test set_group_suspended does nothing when commands already in desired state."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Already suspended command
kb = self._create_mock_keybinding(test_context, keysymstring="h")
kb.has_grabs.return_value = False
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb, suspended=True)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Suspend again (no change)
manager.set_group_suspended("Test Group", True)
# No grabs should be modified
kb.add_grabs.assert_not_called()
kb.remove_grabs.assert_not_called()
def test_set_group_enabled_removes_grabs_when_disabling(
self, test_context: OrcaTestContext
) -> None:
"""Test set_group_enabled removes grabs when disabling active commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Active command with grabs
kb = self._create_mock_keybinding(test_context, keysymstring="h")
kb.has_grabs.return_value = True
cmd = KeyboardCommand("cmd", function, "Test Group", desktop_keybinding=kb)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Disable the group
manager.set_group_enabled("Test Group", False)
# Grabs should be removed
kb.remove_grabs.assert_called_once()
kb.add_grabs.assert_not_called()
def test_set_group_enabled_skips_group_toggle_commands(
self, test_context: OrcaTestContext
) -> None:
"""Test set_group_enabled skips group toggle commands."""
self._setup_dependencies(test_context)
from orca.command_manager import KeyboardCommand, CommandManager
manager = CommandManager()
function = self._create_mock_function(test_context)
# Group toggle command with grabs
kb = self._create_mock_keybinding(test_context, keysymstring="z")
kb.has_grabs.return_value = True
cmd = KeyboardCommand(
"toggle_cmd", function, "Test Group", desktop_keybinding=kb, is_group_toggle=True
)
cmd.set_keybinding(kb)
manager.add_command(cmd)
# Disable the group
manager.set_group_enabled("Test Group", False)
# Group toggle should not have grabs removed (it stays active)
kb.remove_grabs.assert_not_called()
# Command should still be enabled
assert cmd.is_enabled() is True
|