1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
|
/*
* This software is in the public domain, furnished "as is", without technical
* support, and with no warranty, express or implied, as to its usefulness for
* any purpose.
*
*/
#include "testutils/syncenginetestutils.h"
#include "testutils/testutils.h"
#include <syncengine.h>
#include <localdiscoverytracker.h>
#include <QtTest>
using namespace OCC;
class TestLocalDiscovery : public QObject
{
Q_OBJECT
private Q_SLOTS:
void initTestCase_data()
{
QTest::addColumn<Vfs::Mode>("vfsMode");
QTest::addColumn<bool>("filesAreDehydrated");
QTest::newRow("Vfs::Off") << Vfs::Off << false;
if (VfsPluginManager::instance().isVfsPluginAvailable(Vfs::WindowsCfApi)) {
QTest::newRow("Vfs::WindowsCfApi dehydrated") << Vfs::WindowsCfApi << true;
// TODO: the hydrated version will fail due to an issue in the winvfs plugin, so leave it disabled for now.
// QTest::newRow("Vfs::WindowsCfApi hydrated") << Vfs::WindowsCfApi << false;
} else if (Utility::isWindows()) {
qWarning("Skipping Vfs::WindowsCfApi");
}
}
/// Check correct behavior when local discovery is partially drawn from the db
void testLocalDiscoveryStyle()
{
QFETCH_GLOBAL(Vfs::Mode, vfsMode);
QFETCH_GLOBAL(bool, filesAreDehydrated);
FakeFolder fakeFolder(FileInfo::A12_B12_C12_S12(), vfsMode, filesAreDehydrated);
LocalDiscoveryTracker tracker;
connect(&fakeFolder.syncEngine(), &SyncEngine::itemCompleted, &tracker, &LocalDiscoveryTracker::slotItemCompleted);
connect(&fakeFolder.syncEngine(), &SyncEngine::finished, &tracker, &LocalDiscoveryTracker::slotSyncFinished);
// More subdirectories are useful for testing
fakeFolder.localModifier().mkdir(QStringLiteral("A/X"));
fakeFolder.localModifier().mkdir(QStringLiteral("A/Y"));
fakeFolder.localModifier().insert(QStringLiteral("A/X/x1"));
fakeFolder.localModifier().insert(QStringLiteral("A/Y/y1"));
tracker.addTouchedPath(QStringLiteral("A/X"));
tracker.startSyncFullDiscovery();
QVERIFY(fakeFolder.applyLocalModificationsAndSync());
QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
QVERIFY(tracker.localDiscoveryPaths().empty());
// Test begins
fakeFolder.localModifier().insert(QStringLiteral("A/a3"));
fakeFolder.localModifier().insert(QStringLiteral("A/X/x2"));
fakeFolder.localModifier().insert(QStringLiteral("A/Y/y2"));
fakeFolder.localModifier().insert(QStringLiteral("B/b3"));
fakeFolder.remoteModifier().insert(QStringLiteral("C/c3"));
fakeFolder.remoteModifier().appendByte(QStringLiteral("C/c1"));
tracker.addTouchedPath(QStringLiteral("A/X"));
fakeFolder.syncEngine().setLocalDiscoveryOptions(LocalDiscoveryStyle::DatabaseAndFilesystem, tracker.localDiscoveryPaths());
tracker.startSyncPartialDiscovery();
QVERIFY(fakeFolder.applyLocalModificationsAndSync());
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("A/a3")));
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("A/X/x2")));
QVERIFY(!fakeFolder.currentRemoteState().find(QStringLiteral("A/Y/y2")));
QVERIFY(!fakeFolder.currentRemoteState().find(QStringLiteral("B/b3")));
QVERIFY(fakeFolder.currentLocalState().find(QStringLiteral("C/c3")));
QCOMPARE(fakeFolder.syncEngine().lastLocalDiscoveryStyle(), LocalDiscoveryStyle::DatabaseAndFilesystem);
QVERIFY(tracker.localDiscoveryPaths().empty());
QVERIFY(fakeFolder.applyLocalModificationsAndSync());
QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
QCOMPARE(fakeFolder.syncEngine().lastLocalDiscoveryStyle(), LocalDiscoveryStyle::FilesystemOnly);
QVERIFY(tracker.localDiscoveryPaths().empty());
}
void testLocalDiscoveryDecision()
{
QFETCH_GLOBAL(Vfs::Mode, vfsMode);
QFETCH_GLOBAL(bool, filesAreDehydrated);
FakeFolder fakeFolder(FileInfo::A12_B12_C12_S12(), vfsMode, filesAreDehydrated);
auto &engine = fakeFolder.syncEngine();
QVERIFY(engine.shouldDiscoverLocally(QString()));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X")));
fakeFolder.syncEngine().setLocalDiscoveryOptions(LocalDiscoveryStyle::DatabaseAndFilesystem,
{QStringLiteral("A/X"), QStringLiteral("A/X space"), QStringLiteral("A/X/beta"), QStringLiteral("foo bar space/touch"), QStringLiteral("foo/"),
QStringLiteral("zzz"), QStringLiteral("zzzz")});
QVERIFY(engine.shouldDiscoverLocally(QString()));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("B")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("A B")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("B/X")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("foo bar space")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("foo")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("foo bar")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("foo bar/touch")));
// These are within QStringLiteral("A/X") so they should be discovered
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X/alpha")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X beta")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X/Y")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X space")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("A/X space/alpha")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("A/Xylo/foo")));
QVERIFY(engine.shouldDiscoverLocally(QStringLiteral("zzzz/hello")));
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("zzza/hello")));
QEXPECT_FAIL("", "There is a possibility of false positives if the set contains a path "
"which is a prefix, and that prefix is followed by a character less than '/'", Continue);
QVERIFY(!engine.shouldDiscoverLocally(QStringLiteral("A/X o")));
fakeFolder.syncEngine().setLocalDiscoveryOptions(
LocalDiscoveryStyle::DatabaseAndFilesystem,
{});
QVERIFY(!engine.shouldDiscoverLocally(QString()));
}
// Check whether item success and item failure adjusts the
// tracker correctly.
void testTrackerItemCompletion()
{
QFETCH_GLOBAL(Vfs::Mode, vfsMode);
QFETCH_GLOBAL(bool, filesAreDehydrated);
FakeFolder fakeFolder(FileInfo::A12_B12_C12_S12(), vfsMode, filesAreDehydrated);
LocalDiscoveryTracker tracker;
connect(&fakeFolder.syncEngine(), &SyncEngine::itemCompleted, &tracker, &LocalDiscoveryTracker::slotItemCompleted);
connect(&fakeFolder.syncEngine(), &SyncEngine::finished, &tracker, &LocalDiscoveryTracker::slotSyncFinished);
auto trackerContains = [&](const char *path) {
return tracker.localDiscoveryPaths().find(QString::fromLatin1(path)) != tracker.localDiscoveryPaths().end();
};
tracker.addTouchedPath(QStringLiteral("A/spurious"));
fakeFolder.localModifier().insert(QStringLiteral("A/a3"));
tracker.addTouchedPath(QStringLiteral("A/a3"));
fakeFolder.localModifier().insert(QStringLiteral("A/a4"));
fakeFolder.serverErrorPaths().append(QStringLiteral("A/a4"));
// We're not adding a4 as touched, it's in the same folder as a3 and will be seen.
// And due to the error it should be added to the explicit list while a3 gets removed.
fakeFolder.syncEngine().setLocalDiscoveryOptions(LocalDiscoveryStyle::DatabaseAndFilesystem, tracker.localDiscoveryPaths());
tracker.startSyncPartialDiscovery();
QVERIFY(!fakeFolder.applyLocalModificationsAndSync());
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("A/a3")));
QVERIFY(!fakeFolder.currentRemoteState().find(QStringLiteral("A/a4")));
QVERIFY(!trackerContains("A/a3"));
QVERIFY(trackerContains("A/a4"));
QVERIFY(trackerContains("A/spurious")); // not removed since overall sync not successful
fakeFolder.syncEngine().setLocalDiscoveryOptions(LocalDiscoveryStyle::FilesystemOnly);
tracker.startSyncFullDiscovery();
QVERIFY(!fakeFolder.applyLocalModificationsAndSync());
QVERIFY(!fakeFolder.currentRemoteState().find(QStringLiteral("A/a4")));
QVERIFY(trackerContains("A/a4")); // had an error, still here
QVERIFY(!trackerContains("A/spurious")); // removed due to full discovery
fakeFolder.serverErrorPaths().clear();
fakeFolder.syncJournal().wipeErrorBlacklist();
tracker.addTouchedPath(QStringLiteral("A/newspurious")); // will be removed due to successful sync
fakeFolder.syncEngine().setLocalDiscoveryOptions(LocalDiscoveryStyle::DatabaseAndFilesystem, tracker.localDiscoveryPaths());
tracker.startSyncPartialDiscovery();
QVERIFY(fakeFolder.applyLocalModificationsAndSync());
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("A/a4")));
QVERIFY(tracker.localDiscoveryPaths().empty());
}
void testDirectoryAndSubDirectory()
{
QFETCH_GLOBAL(Vfs::Mode, vfsMode);
QFETCH_GLOBAL(bool, filesAreDehydrated);
FakeFolder fakeFolder(FileInfo::A12_B12_C12_S12(), vfsMode, filesAreDehydrated);
fakeFolder.localModifier().mkdir(QStringLiteral("A/newDir"));
fakeFolder.localModifier().mkdir(QStringLiteral("A/newDir/subDir"));
fakeFolder.localModifier().insert(QStringLiteral("A/newDir/subDir/file"), 10_B);
// Only "A" was modified according to the file system tracker
fakeFolder.syncEngine().setLocalDiscoveryOptions(
LocalDiscoveryStyle::DatabaseAndFilesystem,
{ QStringLiteral("A") });
QVERIFY(fakeFolder.applyLocalModificationsAndSync());
QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("A/newDir/subDir/file")));
}
// Tests the behavior of invalid filename detection
void testServerBlacklist()
{
QFETCH_GLOBAL(Vfs::Mode, vfsMode);
QFETCH_GLOBAL(bool, filesAreDehydrated);
FakeFolder fakeFolder(FileInfo::A12_B12_C12_S12(), vfsMode, filesAreDehydrated);
QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
auto cap = TestUtils::testCapabilities();
cap.insert(
{{QStringLiteral("files"), QVariantMap{{QStringLiteral("blacklisted_files"), QVariantList{QStringLiteral(".foo"), QStringLiteral("bar")}}}}});
fakeFolder.account()->setCapabilities({fakeFolder.account()->url(), cap});
fakeFolder.localModifier().insert(QStringLiteral("C/.foo"));
fakeFolder.localModifier().insert(QStringLiteral("C/bar"));
fakeFolder.localModifier().insert(QStringLiteral("C/moo"));
fakeFolder.localModifier().insert(QStringLiteral("C/.moo"));
QVERIFY(fakeFolder.applyLocalModificationsAndSync());
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("C/moo")));
QVERIFY(fakeFolder.currentRemoteState().find(QStringLiteral("C/.moo")));
QVERIFY(!fakeFolder.currentRemoteState().find(QStringLiteral("C/.foo")));
QVERIFY(!fakeFolder.currentRemoteState().find(QStringLiteral("C/bar")));
}
};
QTEST_GUILESS_MAIN(TestLocalDiscovery)
#include "testlocaldiscovery.moc"
|
