1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956 1957 1958 1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125 2126 2127 2128 2129 2130 2131 2132 2133 2134 2135 2136 2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238 2239 2240 2241 2242 2243 2244 2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294 2295 2296 2297 2298 2299 2300 2301 2302 2303 2304 2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315 2316 2317 2318 2319 2320 2321 2322 2323 2324 2325 2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390 2391 2392 2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404 2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468 2469 2470 2471 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2490 2491 2492 2493 2494 2495 2496 2497 2498 2499 2500 2501 2502 2503 2504 2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517 2518 2519 2520 2521 2522 2523 2524 2525 2526 2527 2528 2529 2530 2531 2532 2533 2534 2535 2536 2537 2538 2539 2540 2541 2542 2543 2544 2545 2546 2547 2548 2549 2550 2551 2552 2553 2554 2555 2556 2557 2558 2559 2560 2561 2562 2563 2564 2565 2566 2567 2568 2569 2570 2571 2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603 2604 2605 2606 2607 2608 2609 2610 2611 2612 2613 2614 2615 2616 2617 2618 2619 2620 2621 2622 2623 2624 2625 2626 2627 2628 2629 2630 2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697 2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729 2730 2731 2732 2733 2734 2735 2736 2737 2738 2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753 2754 2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780 2781 2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859 2860 2861 2862 2863 2864 2865 2866 2867 2868 2869 2870 2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888 2889 2890 2891 2892 2893 2894 2895 2896 2897 2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938 2939 2940 2941 2942 2943 2944 2945 2946 2947 2948 2949 2950 2951 2952 2953 2954 2955 2956 2957 2958 2959 2960 2961 2962 2963 2964 2965 2966 2967 2968 2969 2970 2971 2972 2973 2974 2975 2976 2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103 3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114 3115 3116 3117 3118 3119 3120 3121 3122 3123 3124 3125 3126 3127 3128 3129 3130 3131 3132 3133 3134 3135 3136 3137 3138 3139 3140 3141 3142 3143 3144 3145 3146 3147 3148 3149 3150 3151 3152 3153 3154 3155 3156 3157 3158 3159 3160 3161 3162 3163 3164 3165 3166 3167 3168 3169 3170 3171 3172 3173 3174 3175 3176 3177 3178 3179 3180 3181 3182 3183 3184 3185 3186 3187 3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220 3221 3222 3223 3224 3225 3226 3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257 3258 3259 3260 3261 3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272 3273 3274 3275 3276 3277 3278 3279 3280 3281 3282 3283 3284 3285 3286 3287 3288 3289 3290 3291 3292 3293 3294 3295 3296 3297 3298 3299 3300 3301 3302 3303 3304 3305 3306 3307 3308 3309 3310 3311 3312 3313 3314 3315 3316 3317 3318 3319 3320 3321 3322 3323 3324 3325 3326 3327 3328 3329 3330 3331 3332 3333 3334 3335 3336 3337 3338 3339 3340 3341 3342 3343 3344 3345 3346 3347 3348 3349 3350 3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369 3370 3371 3372 3373 3374 3375 3376 3377 3378 3379 3380 3381 3382 3383 3384 3385 3386 3387 3388 3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402 3403 3404 3405 3406 3407 3408 3409 3410 3411 3412 3413 3414 3415 3416 3417 3418 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 3434 3435 3436 3437 3438 3439 3440 3441 3442 3443 3444 3445 3446 3447 3448 3449 3450 3451 3452 3453 3454 3455 3456 3457 3458 3459 3460 3461 3462 3463 3464 3465 3466 3467 3468 3469 3470 3471 3472 3473 3474 3475 3476 3477 3478 3479 3480 3481 3482 3483 3484 3485 3486 3487 3488 3489 3490 3491 3492 3493 3494 3495 3496 3497 3498 3499 3500 3501 3502 3503 3504 3505 3506 3507 3508 3509 3510 3511 3512 3513 3514 3515 3516 3517 3518 3519 3520 3521 3522 3523 3524 3525 3526 3527 3528 3529 3530 3531 3532 3533 3534 3535 3536 3537 3538 3539 3540 3541 3542 3543 3544 3545 3546 3547 3548 3549 3550 3551 3552 3553 3554 3555 3556 3557 3558 3559 3560 3561 3562 3563 3564 3565 3566 3567 3568 3569 3570 3571 3572 3573 3574 3575 3576 3577 3578 3579 3580 3581 3582 3583 3584 3585 3586 3587 3588 3589 3590 3591 3592 3593 3594 3595 3596 3597 3598 3599 3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611 3612 3613 3614 3615 3616 3617 3618 3619 3620 3621 3622 3623 3624 3625 3626 3627 3628 3629 3630 3631 3632 3633 3634 3635 3636 3637 3638 3639 3640 3641 3642 3643 3644 3645 3646 3647 3648 3649 3650 3651 3652 3653 3654 3655 3656 3657 3658 3659 3660 3661 3662 3663 3664 3665 3666 3667 3668 3669 3670 3671 3672 3673 3674 3675 3676 3677 3678 3679 3680 3681 3682 3683 3684 3685 3686 3687 3688 3689 3690 3691 3692 3693 3694 3695 3696 3697 3698 3699 3700 3701 3702 3703 3704 3705 3706 3707 3708 3709 3710 3711 3712 3713 3714 3715 3716 3717 3718 3719 3720 3721 3722 3723 3724 3725 3726 3727 3728 3729 3730 3731 3732 3733 3734 3735 3736 3737 3738 3739 3740 3741 3742 3743 3744 3745 3746 3747 3748 3749 3750 3751 3752 3753 3754 3755 3756 3757 3758 3759 3760 3761 3762 3763 3764 3765 3766 3767 3768 3769 3770 3771 3772 3773 3774 3775 3776 3777 3778 3779 3780 3781 3782 3783 3784 3785 3786 3787 3788 3789 3790 3791 3792 3793 3794 3795 3796 3797 3798 3799 3800 3801 3802 3803 3804 3805 3806 3807 3808 3809 3810 3811 3812 3813 3814 3815 3816 3817 3818 3819 3820 3821 3822 3823 3824 3825 3826 3827 3828 3829 3830 3831 3832 3833 3834 3835 3836 3837 3838 3839 3840 3841 3842 3843 3844 3845 3846 3847 3848 3849 3850 3851 3852 3853 3854 3855 3856 3857 3858 3859 3860 3861 3862 3863 3864 3865 3866 3867 3868 3869 3870 3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890 3891 3892 3893 3894 3895 3896 3897 3898 3899 3900 3901 3902 3903 3904 3905 3906 3907 3908 3909 3910 3911 3912 3913 3914 3915 3916 3917 3918 3919 3920 3921 3922 3923 3924 3925 3926 3927 3928 3929 3930 3931 3932 3933 3934 3935 3936 3937 3938 3939 3940 3941 3942 3943 3944 3945 3946 3947 3948 3949 3950 3951 3952 3953 3954 3955 3956 3957 3958 3959 3960 3961 3962 3963 3964 3965 3966 3967 3968 3969 3970 3971 3972 3973 3974 3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985 3986 3987 3988 3989 3990 3991 3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002 4003 4004 4005 4006 4007 4008 4009 4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020 4021 4022 4023 4024 4025 4026 4027 4028 4029 4030 4031 4032 4033 4034 4035 4036 4037 4038 4039 4040 4041 4042 4043 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 4055 4056 4057 4058 4059 4060 4061 4062 4063 4064 4065 4066 4067 4068 4069 4070 4071 4072 4073 4074 4075 4076 4077 4078 4079 4080 4081 4082 4083 4084 4085 4086 4087 4088 4089 4090 4091 4092 4093 4094 4095 4096 4097 4098 4099 4100 4101 4102 4103 4104 4105 4106 4107 4108 4109 4110 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4122 4123 4124 4125 4126 4127 4128 4129 4130 4131 4132 4133 4134 4135 4136 4137 4138 4139 4140 4141 4142 4143 4144 4145 4146 4147 4148 4149 4150 4151 4152 4153 4154 4155 4156 4157 4158 4159 4160 4161 4162 4163 4164 4165 4166 4167 4168 4169 4170 4171 4172 4173 4174 4175 4176 4177 4178 4179 4180 4181 4182 4183 4184 4185 4186 4187 4188 4189 4190 4191 4192 4193 4194 4195 4196 4197 4198 4199 4200 4201 4202 4203 4204 4205 4206 4207 4208 4209 4210 4211 4212 4213 4214 4215 4216 4217 4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273 4274 4275 4276 4277 4278 4279 4280 4281 4282 4283 4284 4285 4286 4287 4288 4289 4290 4291 4292 4293 4294 4295 4296 4297 4298 4299 4300 4301 4302 4303 4304 4305 4306 4307 4308 4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321 4322 4323 4324 4325 4326 4327 4328 4329 4330 4331 4332 4333 4334 4335 4336 4337 4338 4339 4340 4341 4342 4343 4344 4345 4346 4347 4348 4349 4350 4351 4352 4353 4354 4355 4356 4357 4358 4359 4360 4361 4362 4363 4364 4365 4366 4367 4368 4369 4370 4371 4372 4373 4374 4375 4376 4377 4378 4379 4380 4381 4382 4383 4384 4385 4386 4387 4388 4389 4390 4391 4392 4393 4394 4395 4396 4397 4398 4399 4400 4401 4402 4403 4404 4405 4406 4407 4408 4409 4410 4411 4412 4413 4414 4415 4416 4417 4418 4419 4420 4421 4422 4423 4424 4425 4426 4427 4428 4429 4430 4431 4432 4433 4434 4435 4436 4437 4438 4439 4440 4441 4442 4443 4444 4445 4446 4447 4448 4449 4450 4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464 4465 4466 4467 4468 4469 4470 4471 4472 4473 4474 4475 4476 4477 4478 4479 4480 4481 4482 4483 4484 4485 4486 4487 4488 4489 4490 4491 4492 4493 4494 4495 4496 4497 4498 4499 4500 4501 4502 4503 4504 4505 4506 4507 4508 4509 4510 4511 4512 4513 4514 4515 4516 4517 4518 4519 4520 4521 4522 4523 4524 4525 4526 4527 4528 4529 4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574 4575 4576 4577 4578 4579 4580 4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602 4603 4604 4605 4606 4607 4608 4609 4610 4611 4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634 4635 4636 4637 4638 4639 4640 4641 4642 4643 4644 4645 4646 4647 4648 4649 4650 4651 4652 4653 4654 4655 4656 4657 4658 4659 4660 4661 4662 4663 4664 4665 4666 4667 4668 4669 4670 4671 4672 4673 4674 4675 4676 4677 4678 4679 4680 4681 4682 4683 4684 4685 4686 4687 4688 4689 4690 4691 4692 4693 4694 4695 4696 4697 4698 4699 4700 4701 4702 4703 4704 4705 4706 4707 4708 4709 4710 4711 4712 4713 4714 4715 4716 4717 4718 4719 4720 4721 4722 4723 4724 4725 4726 4727 4728 4729 4730 4731 4732 4733 4734 4735 4736 4737 4738 4739 4740 4741 4742 4743 4744 4745 4746 4747 4748 4749 4750 4751 4752 4753 4754 4755 4756 4757 4758 4759 4760 4761 4762 4763 4764 4765 4766 4767 4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779 4780 4781 4782 4783 4784 4785 4786 4787 4788 4789 4790 4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815 4816 4817 4818 4819 4820 4821 4822 4823 4824 4825 4826 4827 4828 4829 4830 4831 4832 4833 4834 4835 4836 4837 4838 4839 4840 4841 4842 4843 4844 4845 4846 4847 4848 4849 4850 4851 4852 4853 4854 4855 4856 4857 4858 4859 4860 4861 4862 4863 4864 4865 4866 4867 4868 4869 4870 4871
|
2004-01-16 Christophe Lambin <chris@rebelbase.com>
* pan/task-manager.c (task_manager_build_ui): don't add a treeview to
a scrolled_window with a container. This fixes some incorrect scrolling
behaviour in the Task Manager.
(#122753, buckyball)
* pan/server-ui.c (server_dialog_new): same.
* pan/score-view-ui.c (score_view_dialog): same.
* pan/prefs.c (header_pane_page): same.
2004-01-15 Christophe Lambin <chris@rebelbase.com>
* gmime/gmime-stream-mem.c (stream_read): synced with GMime 2.1.1 to
fix a crash when reading certain messages. A full sync with GMime is
planned for 0.14.3, but it wouldn't be the first time we chicken out
on this. :) Thanks to Randy Hendry for doing the leg work on this bug.
(#125051, Johannes Gijsbers, Randy Hendry)
* pan/pan/pan-glib-extensions.c (pan_header_to_utf8): ensure string
is valid UTF8 after conversion. This fixes bursts of Log entries
saying 'Invalid UTF8 string passed to to pango_layout_set_text()'
when populating / scrolling through the articlelist.
2004-01-11 Christophe Lambin <chris@rebelbase.com>
* pan/util.c (gui_save_window_size): fixed bug that caused Pan not to
remember if it was in maximized mode in between sessions.
(#124633, Arcterex)
2004-01-09 Christophe Lambin <chris@rebelbase.com>
* pan/message-check-ui.c (post_warning_cb): minor HiGification to the
'Post anyway, despite these problems?' dialog.
2004-01-07 Christophe Lambin <chris@rebelbase.com>
* pan/filters/filter-phrase.c (filter_phrase_does_match): fixed regular
expression matching.
* tests/test-filter.c (test_phrases): added some test cases to exercise
the regular expression matching.
2003-12-17 Charles Kerr <charles@rebelbase.com>
* pan/base/article.c: more fiddling.
* pan/base/group.c (group_remove_articles): fix error message
that occurred when trying to remove all the articles in a group
that's not been loaded.
(#123913, Matthew Fischer)
* pan/grouplist.c: added context menu button for
"Get New Headers in Subscribed Groups".
(#128406, Daniel Hobe)
2003-12-16 Charles Kerr <charles@rebelbase.com>
* pan/base/article.c:
* pan/base/pstring.c:
* pan/articlelist.c: more tweaks to "Add Set to Selection".
2003-12-14 Jan De Luyck <jan-bugs@kcore.org>
* tests/Makefile.am: include PCRE_LIBS_POSIX.
* tests/test-pstring.c: sync. with pstring_likeness() changes.
(#129319, Jan De Luyck)
2003-12-13 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: added preferences option to mark a group as read
when you exit the group.
* pan/articlelist.c: sync.
(#129260, Pan Team)
* pan/base/pstring.c: added heuristic code to determine whether or
not two strings are similar.
* pan/articlelist.c: added articlelist_add_set_to_selection()
to select similar posts.
2003-12-10 Christophe Lambin <clambin@easynet.be>
* pan/filters/filter-phrase.c (filter_phrase_set): tolower() isn't safe
for anything other than ASCII when the user isn't in a UTF-8 locale.
Use g_utf8_strdown() instead.
(#128433, Frederic Crozat)
2003-12-10 Charles Kerr <charles@rebelbase.com>
* pan/gmime/gmime-parser.c:
* pan/gmime/Makefile.am: use pcre instead of regex, since pcre
is now required for Pan and dropping regex lets us skip an
unnecessary step when setting up a Windows build environment.
2003-12-09 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (header_pane_remove_articles): when deleting
the last articles in the header pane, move the selection to the
last remaining article instead of wrapping around to the top of
the header pane.
(#128897, Pan Team)
* pan/nntp.c (nntp_download_headers): don't treat articles with
Subjects including "(0/N)" as part of an N-part binary.
They're really text articles that accompany the binary.
This fixes a bug that prevented the (0/N) article from being read
when it had replies.
(#128898, Pan Team)
2003-12-07 Charles Kerr <charles@rebelbase.com>
* pan/pan-file-entry.c (entry_clicked_cb): ensure that, directories
passed into the entry dialog have a trailing directory separator
so that the entry dialog pops up in the right directory.
(#128215, Elton, Woo)
2003-12-03 Frederic Crozat <fcrozat@mandrakesoft.com>
* pan/filters/filter-score.c (filter_score_get_score_mode):
5000 is SCORE_HIGH.
(#128428, Frederic Crozat)
2003-11-30 Charles Kerr <charles@rebelbase.com>
* pan/filter-phrase.c (pcre_info_new): use libpcre's UTF-8 support
only if the system's copy of libpcre was compiled with UTF-8 support.
(#128237, Mahaleo)
* configure.in: bump the pcre requirement to 4.0, and add configure
check to enforce this requirement. pcre_config() wasn't added until 4.0,
and we need it to know whether or not Pan can use UTF8 regexes.
(Brian Morrison)
2003-11-28 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (header_pane_refresh): added bitfield argument
to indicate if rescoring is needed, refiltering is needed, and if
rebuilding the tree is needed. This way we don't have to
rescore/refilter if the user just hit the `sort' button or
toggled threading on or off.
(#127247, Samuli Kärkkäinen)
* pan/filter-mediator.c: yet another fix for syncing the menu buttons
with the toolbar buttons.
(#128154, spiralcow)
2003-11-28 Charles Kerr <charles@rebelbase.com>
0.14.2.90 Released!
2003-11-27 Charles Kerr <charles@rebelbase.com>
* pan/base/article-thread.c: fix article sorting error.
2003-11-27 Charles Kerr <charles@rebelbase.com>
* configure.in: added check for pcre.
* pan.spec.in: added prerequisites for pcre and pcre-devel
* pan/Makefile.am: link against pcre
* pan/filters/Makefile.am: link against pcre
* pan/filters/filter-phrase.c: use perl RE's instead of posix RE's
* pan/filters/score.c: use RE's via filter-phrase instead of directly
* tests/Makefile.am: link against pcre
(#122078, Carl Hudkins)
2003-11-26 Charles Kerr <charles@rebelbase.com>
* pan/action.[ch]: added ACTION_MANUAL_DECODE.
* pan/article-actions.[ch] (article_action_selected_manual_decode): new.
* pan/articlelist.c: added "Manual Decode" button in popup.
* pan/gui.c: added "Manual Decode" button in File menu.
* pan/save-ui.c: added manual decode mode to (1) tweak window title
and (2) not make any guesses about weeding out duplicate articles.
(#119518, Torstein Sunde)
2003-11-25 Christophe Lambin <clambin@easynet.be>
* tests/test-glibext.c: fixed test for pan_file_normalize() on Windows.
(121040, haleykd)
2003-1l-24 Charles Kerr <charles@rebelbase.com>
* pan/message-window.c (apply_identity): fixed a bug that failed to
position the cursor in the follow-up window at the end of a message
if the poster didn't have a signature file.
(#127661, Ted Anderson)
2003-11-23 Christophe Lambin <clambin@easynet.be>
* pan.desktop.in: fixed some errors against the desktop entry spec
(127749, Pawe)
2003-11-20 Christophe Lambin <clambin@easynet.be>
* pan/article-toolbar.c (article_toolbar_set_group_filter): mark the
group dirty, so the changed filters are saved even if no articles are
added.
2003-11-14 Charles Kerr <charles@rebelbase.com>
* pan/filter-mediator.c: mediate between the toolbar and menu
buttons more elegantly.
(#120129, John van der Kamp)
* pan/articlelist.c: minor tweaks.
* pan/base/article.c: same.
* pan/filters/score.c: same.
2003-11-14 Christophe Lambin <clambin@easynet.be>
* pan/log-ui.c (log_save_ok_clicked): when saving the logfile, we were
writing the timestamp in local charset, but the event string in UTF-8.
* pan/util.c (get_date_display_string): changed to return the date in
UTF-8, since that's all we need.
* pan/log-ui.c (log_viewer_add_entry_nolock): sync.
* pan/header-pane-renderer.c (header_pane_renderer_populate_node): sync.
(125921, Artur Brodowski)
2003-11-13 Charles Kerr <charles@rebelbase.com>
* pan/base/util-mime.c (uu_parse_begin_line): return an error
if the user doesn't specify at least 3 octal digits for file
permissions.
(#101510, Juergen P. Meier)
2003-10-23 Charles Kerr <charles@rebelbase.com>
* pan/sockets.c (pan_socket_constructor): silence win32 warning.
(124098, Lenroc)
* pan/header-pane-renderer.c (header_pane_renderer_populate_node):
* pan/header-pane-renderer.c (header_pane_renderer_refresh_node):
When expanding a multipart subthread, only show the top article's
real line count, rather than the sum of all the lines in the multipart.
(119543, Torstein Sunde)
2003-09-08 Christophe Lambin <clambin@easynet.be>
* pan/gmime/gmime-filter-html.c: added '\' as a valid URL character.
(121765, Bill Baker)
2003-09-08 Danilo Šegan <dsegan@gmx.net>
* pan/dialogs/dialog-about.c (get_credits_translators): Added
credits to Serbian translator and Serbian team.
2003-09-02 Hasbullah Bin Pit <sebol@ikhlas.com>
* configure.in: Added 'ms' (Malay) to ALL_LINGUAS.
2003-09-01 Metin Amiroff <metin@karegen.com>
configure.in: Added "az" in ALL_LINGUAS.
2003-08-31 Charles Kerr <charles@rebelbase.com>
Pan 0.14.2 Released!
2003-08-29 Charles Kerr <charles@rebelbase.com>
* pan/dialogs/dialog-about.c: bump copyright to 2003.
Thanks to the Lamb for pointing this out.
2003-08-30 Jeffrey Stedfast <fejj@ximian.com>
* gmime/md5-utils.c (md5_get_digest_from_file): Open in binary
format. Fixes bug #121041 for Win32 systems.
2003-08-29 Charles Kerr <charles@rebelbase.com>
* pan/xpm/Makefile.am: tweak the pan-pixbufs.h generation to work
with gtk+ 2.2.3.
* pan/base/pan-config.c: use libxml's library for writing the XML
file back out. This fixes a bug that forgot to write a closing
"</section>" node when there were no children of the section node.
(121017, Jan Van Besien)
2003-08-27 Charles Kerr <charles@rebelbase.com>
Pan 0.14.1 Released!
2003-08-21 Christophe Lambin <clambin@easynet.be>
* pan.spec.in: fixed 'BuildRequires' entry for gtkspell-devel
(Michael A Chase)
2003-08-20 Charles Kerr <charles@rebelbase.com>
Pan 0.14.0.96 Released!
2003-08-20 Charles Kerr <charles@rebelbase.com>
* pan/serverlist.c: fixed bug that could corrupt the config.xml file.
(120079, Adam Huffman)
2003-08-19 Charles Kerr <charles@rebelbase.com>
* pan/base/group.c (group_get_collapsed_name): handle the case where
the group is only a single word with no dots.
(120159, Soren Boll Overgaard)
* pan/base/serverlist.c: fix "Last_Grouplist_Update" handling, which
was being saved as a ulong but read as a string.
* pan/base/serverlist.c: fix "Auth_Required", which was being
treated as an int rather than a boolean.
* pan/base/article.c (xref_header_foreach): ensure that the march
variable is set even if the xref header is broken/missing.
(Valgrind, Pan Team)
* pan/article-find.c: fix 0.14.0.95 bug that broke article searching.
(Pan Team)
* pan/base/pstring.c (pstring_set): fix memory leak.
(Valgrind, Pan Team)
* configure.in: use LIBS instead of LDFLAGS.
Add windows-specific CFLAGS and LIBS at configure time.
(K. Haley)
2003-08-17 Charles Kerr <charles@rebelbase.com>
* pan/base/file-headers.c: fix Windows portability bug.
(#117345, Michael Van Biesbrouck, fix found by K. Haley)
2003-08-15 Charles Kerr <charles@rebelbase.com>
* pan/article-find.c: use the pan_hig utilities for building
this dialog.
* pan/identities/identity-edit-ui.c: a string that should've
been marked for translation wasn't. Thanks to Toivo for
reporting this.
* pan/prefs.h: fixed tyop bug that gave external apps
the wrong keyname in config.xml.
(119980, Pan Team)
* pan/prefs.c: fixed mislabeling bug in the Layout pane.
(119969, Duncan)
* pan/prefs.c: fixed bug that prevented user selection
of which headers to show in the body pane from `sticking'
to the next Pan session.
(119948, Jakob Breivik Grimstveit)
2003-08-14 Charles Kerr <charles@rebelbase.com>
Pan 0.14.0.95 Released!
2003-08-14 Charles Kerr <charles@rebelbase.com>
* pan/sockets.c (socket_destructor): fix g_warning that
gets tickled in GNet 1 if we couldn't make a connection to
the server.
* pan/filter-mediator.c: fixed bug that broke the
Filter|Match Only Text Articles menu button.
(119783, Brian Morrison)
* pan/prefs.c: minor memory leak: remember to unref a
copy of a GtkStyle.
2003-08-13 Charles Kerr <charles@rebelbase.com>
* pan/util.c (pan_hig_add_row): new utility function.
* pan/prefs.c: sync.
* pan/save-ui.c: sync.
* pan/server-ui.c: sync.
* pan/dialogs/dialog-newuser.c: sync.
* pan/dialogs/dialog-group-props.c: sync.
* pan/identities/identity/edit-ui.c: sync.
* pan/score-add-ui.c (add_this_to_scorefile): Pop up a warning
dialog if the user is entering illegal regular expressions and
don't allow them to be added in the scorefile.
* pan/filters/filter-phrase.c (my_regexec): check the return
value of regcomp and flag illegal regular expressions as such
instead of passing them along to regexec() to crash Pan.
* pan/filters/score.c (get_section): same.
(119748, Phoenix Reads)
2003-08-12 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: more cleanup.
* pan/message-window.c (check_charset_for_body): improved the
error message to let the user know what line and column any
charset errors occurred on.
(119686, Lenroc)
2003-08-11 Charles Kerr <charles@rebelbase.com>
* pan/message-window.c: use the pan_hig functions to build
the workareas in the compose window.
* pan/prefs.c: hig'ify a couple of strings.
* pan/util.c: add more constraints to the hig widgets.
* pan/server-menu-ui.c: fixed oddness that occurred when
Server names include underscores -- pan/gtk tried to use those
underscores for accelerators in the menu.
(119575, Warren)
* pan/message-window.c (post): don't save to the pan.sendlater
folder until the user has approved the message. This prevents
a nasty double-post bug.
(119363, Uwe Naumann)
* pan/message-window.c: Committed patch from Torstein Sunde to
display the identity name in the compose window's From line.
(119527, Torstein Sunde)
2003-08-09 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: Fixed 0.14.0.94 cut-and-paste bug that prevented
Edit|Preferences|Header Pane|Hide Multipart Children from being
modified.
(119516, Torstein Sunde)
2003-08-08 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: more config value cleanup.
2003-08-08 Charles Kerr <charles@rebelbase.com>
* pan/pan-config.c: changed the pan_config_get() funcs to
take a second argument for the default value so that we don't
have to parse the default value by hand.
* pan/pan-config.c: added pan_config_set_if_different() funcs
that take a key, value, and default value. If the value and
default value are the same, then the entry is cleared from the
config file.
* pan/prefs.[ch]: codified a lot of the default values
in #define macros.
2003-08-07 Charles Kerr <charles@rebelbase.com>
* pan/text-massager.c (fill_paragraph): Fix 2003/08/05 bug
that broke wrapping in bodies with lots of empty lines.
(119253, Jan De Luyck)
* pan/header-pane-renderer.c: if the article's score is zero,
just use the regular foreground/background colors in the
score and subject column.
(119058, Mark Derricutt)
* pan/identities/identity-edit-ui.c: added more information in the
fqdn tooltip to explain its behavior.
* pan/message-window.c: reintroduced the `don't generate message-id'
togglebutton in the `extra headers' tab.
(Achim Linder, a.o.l.m)
* pan/header-pane-renderer.c: remove the code that explicitly
sets the row height. This code caused problems when the user changed
the header pane's font, and the code was just a workaround for a
gtkclist bug that's now fixed in gtk+ cvs anyway.
(119228, J. Gardner Biggs)
* pan/message-window.c (apply_identity): fix crash that occurred
when specifying a signature file that doesn't exist.
(119359, Lucius Chiaraviglio)
2003-08-06 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_selection_changed_cb):
invoke selection_changed_upkeep() even if the new selection is empty.
* pan/articlelist.c (selection_changed_upkeep):
only clear the text pane if there's nothing selected.
(119153, Bobby Bryant)
* pan/message-window.c (text_was_inserted_cb): ANOTHER DAMN BUG
in THIS SAME FUNCTION! Shoot me, just shoot me.
(119279, Christophe Lambin)
* pan/message-window.c (text_was_inserted_cb): remember that
if we change the text that was inserted, that we need to revalidate
the GtkTextIterator passed into us by the signal's source.
(118264, Bobby D. Bryant)
* pan/message-window.c (apply_identity): Fix 0.14.0.93 bug
that caused attribution lines in new follow-ups to not be
wrapped properly.
(119154, Lenroc)
* pan/message-window.c (text_was_inserted_cb): the new wrapping
code ate whitespace if the user was typing text and typed a
space key when reaching the wrap column.
(119201, Lenroc, Duncan)
* pan/message-window.c (text_was_inserted_cb): speed up the
wrapping a bit by only wrapping the current paragraph instead
of the entire rest of the document.
(118264)
* test/test-gnksa.c: added a References: header generator
regression test taken from a 0.13.0 bug report.
(118972, Thilo Pfennig)
* pan/base/article-thread.c (sort_articles): minor speed
tweak when sorting by author name.
* pan/base/pan-config.c: fix key searching bug that prevented
`header_pane_custom_font_enabled' from being saved.
(119228, J. Gardner Biggs)
* pan/articlelist.c: download all selected single-parts when user
hits `return' in the header pane. In 0.14.0.94 we just downloaded
the selected text articles.
(117173, Chris Petersen)
2003-08-05 Charles Kerr <charles@rebelbase.com>
* pan/base/text-massager.c: small speedups. Speeds things by 25%
according to cachegrind.
* pan/base/article-thread.c (thread_articles): add more code comments.
* pan/article-actions.c (cancel_article): remove some unnecessary steps.
* pan/article-actions.c (supercede_article): same.
2003-08-04 Charles Kerr <charles@rebelbase.com>
* pan/nntp.c: even if the subject has a (01/50), if the
subject begins with "Re:" and has less than 100 lines then
consider it to _not_ be a multipart article: more likely
it's a follow-up to a multipart.
* pan/filter-mediator.c: if the user hasn't clicked
'show this filter in the Filter menu', don't show the
filter in the filter menu. :)
(Chris Petersen)
2003-08-04 Charles Kerr <charles@rebelbase.com>
Pan 0.14.0.94 Released!
2003-08-04 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_set_selected_nodes_nolock):
fix 0.14.0.91 focus box drawing error.
(118544, Brad Sims)
* pan/base/message-check.c (strip_attribution_and_signature): fixed
bug that allowed unmodified posts to pass the "ERROR: no new content"
posting checks.
* pan/gui.c: remove "Top of Thread" command.
* pan/gui.c: remove "Followup and Reply" command.
* pan/gui.c: remove "Online Users' Manual" command.
* pan/gui.c: remove "Feedback" command.
* pan/gui.c: move "Create Score" from Tools to Article menu.
* pan/articlelist.c: increase the refresh timeout up to
800msec, so that when handling large sets of articles we
can batch up an even greater number to refresh at once
* pan/util.c (gui_queue_init): decrease the idle work timer
down to 200msec.
* pan/grouplist.c: remove some debugging fprintf()'s.
* pan/article-toolbar.c: same.
2003-08-03 Charles Kerr <charles@rebelbase.com>
* pan/gui.c (status_item_active_changed_idle): work the active
tasks as a GSList queue, so that as one finishes, any others
running that didn't have room to be shown in the toolbar will
appear.
* pan/base/group.c (group_get_collapsed_name): added a special
case for moderated, so show the full token before it and collapse
the word "moderated" instead.
(118976, Sebastian Kapfer)
2003-08-02 Charles Kerr <charles@rebelbase.com>
* pan/base/gnksa.c (_quoted_chars): allow "(" and ")" by request.
son-of-1036 attributes this behavior to
"overly-lenient posting agents".
(CL Gilbert)
* pan/articlelist.c (refilter_threads): make sure that changed
scores are propagated up to their parents so that they're shown
properly even when the thread is collapsed.
(118930, Dave Hill)
2003-08-01 Charles Kerr <charles@rebelbase.com>
* pan/article-toolbar.c (article_toolbar_new): fix bug that
caused keyboard shortcuts to break in some Pan layouts.
(118545, Duncan)
* pan/server-ui.c: add sanity checks to make sure the news
server address is set, that username and password are set
if authorization is enabled, and that a filename is specified
if .newsrc support is turned on.
* pan/server-ui.c: add some tooltips to the server edit window too.
* pan/dialogs/dialog-newuser.c: sync.
(118894, Helge Hielscher)
* pan/base/pstring.c (pstring_set): bug fix: don't call strlen()
if the string length is zero.
* pan/filter-mediator.c: added unread/read filtering back in
by popular demand.
* pan/gui.c: sync.
(118804, Dave Hill)
2003-07-31 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: ui tweak: when a task finishes, in the gui bar that
shows all the running tasks, move all the tasks shown to the right
of the finished task, one slot to the left.
* pan/util.c: add pan_hig_workarea_* functions to simplify making
hig-compliant dialog workareas.
* pan/prefs.c: sync.
* pan/save-ui.c: sync.
* pan/score-add-ui.c: sync.
* pan/server-ui.c: sync.
* pan/dialog-newuser.c: sync.
* pan/identities/identity-edit-ui.c: sync.
2003-07-31 Christophe Lambin <clambin@easynet.be>
* pan.spec.in: merged the 'nospell' version into the main spec file.
The nospell packages can be build with 'rpmbuild -ba --without
gtkspell pan.spec'
2003-07-31 Charles Kerr <charles@rebelbase.com>
* pan/util.c (pan_url_show): Pan was impropertly handling some
BROWSER environment variable strings.
(118746, Frederic Crozat)
* pan/text.c (text_set_text_buffer_tags): fix minor memory leak.
(Valgrind)
2003-07-30 Charles Kerr <charles@rebelbase.com>
* pan/nntp.c (nntp_handshake): pop up a dialog when user
authentication fails, so that users will know their password
is wrong or whatever the problem is.
* pan/socket-pool.c (connect_thread_func): go offline if
the handshake fails for non-network problems -- i.e., stay online
if it's a socket error, but go offline if we connected right
but the server returned an error message.
(118169, Guy Rouillier)
* pan/message-window.c: fix the new rewrap code so that it
plays nicely with gtkspell.
(118264, Jan De Luyck)
* pan/base/message-check.c (check_signature): warn if the user
is using "--" as a signature delimiter rather than "-- ".
* tests/test-message-check.c: add regression test for this.
* pan/base/group.h (FILTER_SHOW_MATCHES_AND_REFERENCES):
remove this field.
* pan/base/file-grouplist.c: one-time reset of the filter-show
field to `FILTER_SHOW_MATCHES' for all groups. This is to flush
out any groups still set to FILTER_SHOW_MATCHES_AND_REFERENCES.
2003-07-30 Christophe Lambin <clambin@easynet.be>
* gmime/gmime-filter-html.c: semi-colon is a valid character within a
URL. GMime 2.1 already implements this correctly, so no need to distrub
fejj with this. :)
(Paul Smith)
2003-07-30 Charles Kerr <charles@rebelbase.com>
Pan 0.14.0.93 Released!
2003-07-30 Charles Kerr <charles@rebelbase.com>
* pan/configure.in:
* pan/ANNOUNCE.html: bump to 0.14.0.93
* pan/articlelist.c (header_pane_read_next_new): new func.
* pan/articlelist.c (header_pane_read_next_new_thread): new func.
* pan/gui.c: added menu buttons for `next new' and `next new thread'.
* docs/pan-shortcuts.html: sync.
(Guy Rouillier)
* pan/queue.c (queue_set_task_status): fix minor glib
warning generated on shutdown.
* pan/articlelist.c (articlelist_set_selected_nodes_nolock):
Fixed 0.14.0.90 bug where after resorting, the header pane
no longer showed the selected article in the pane.
(118354, Bobby D. Bryant)
* pan/nntp.c (nntp_download_headers): add a setme argument
for letting the caller know the high article number that
we fetched.
* pan/task-headers.c (task_headers_run_download): use the
new high article number value in group_set_article_range(),
instead of the high returned by nntp's GROUP command. That
way if the task fails halfway through, another `get new'
task will be able to fetch the remaining headers.
Thanks to Tom Warkentin for submitting a fix.
(113265, Tom Warkentin)
* pan/header-pane-renderer.c: work around gtkctree bug that
cuts off descenders (such as the tail on the letter g or q)
in the header pane widget.
(90524, Søren Boll Overgaard)
* pan/sockets.c: set the error flag in socket_constructor()
if we can't make a connection, and give a TASK_FAIL_NETWORK
in pan_socket_getline() and pan_socket_putline() if either
the error flag is true or gio_channel is NULL.
(118588, Jan De Luyck)
2003-07-29 Christophe Lambin <clambin@easynet.be>
* pan/task-header.c (task_headers_run_download): no need to call
server_save_grouplist_if_dirty, since that's already done when
unref'ing the group's articles.
(111790, Dave Hill)
* pan/base/pan-config.c (pan_config_load_ini): when migrating prefs
from Gnome1.x to config.xml, convert values to UTF-8. This fixes a
problem where Pan wouldn't start because config.xml wasn't in UTF-8.
(110314, Samuli Kärkkäinen)
2003-07-29 Charles Kerr <charles@rebelbase.com>
* pan/grouplist.c: fix grammar error.
(118589, Jan De Luyck)
2003-07-29 Charles Kerr <charles@rebelbase.com>
(114308, Pan Team)
* pan/util.c (gui_queue_add): now returns a guint that acts
as a key that can be passed to gui_queue_remove().
* pan/util.c (gui_queue_remove): remove a queued GuiQueueItem
before it's invoked. Useful for removing updates on a widget
that's destroyed before the queue is flushed.
* pan/util.c (gui_queue_add_full): new function that behaves
as gui_queue_add, but also has a GDestroyNotify func that will
be invoked when gui_queue_remove() is called.
* pan/util.c (gui_queue_add_full_to_gobject): new function that
behaves as gui_queue_add_full, but will invoke gui_queue_remove()
when the GObject argument is destroyed.
* pan/task-manager.c (tasks_added_cb): replace gui_queue_add()
with gui_queue_add_full_to_gobject() to avoid thread problems.
* pan/task-manager.c (tasks_removed_cb): same.
2003-07-28 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: simplify the Filter menu.
* pan/filter-mediator.c: sync.
* pan/article-toolbar.c: sync.
* pan/message-window.c (post_checked_cb): remember default
mail/news identities for the next go around.
* pan/identities/identity-ui: removed widgets for default
mail/news identities.
* pan/identities/identity-edit-ui: same.
* pan/identities/identity-manager.c (identity_manager_set_identities):
removed mail/news default arguments
* pan/identities/identity-manager.c (identity_manager_module_init):
do some extra work to ensure we've got valid default mail/news
identities.
(115239, Brian Key)
* pan/message-window.c (window_destroy_cb): disconnect from
some signals that we don't want to keep handling when the
widgetry is being destroyed.
(118497, Pan Team)
* pan/message-window.c (apply_identity): oops, don't give the
attribution if we're posting a new message! I introduced this
bug last Friday.
(118460, Jan De Luyck)
2003-07-26 Charles Kerr <charles@rebelbase.com>
* pan/article-toolbar.c (update_filter_phrase): The header pane
was updated when the search field lost focus, even if the search
phrase hadn't changed.
(116319, Nicolas Girard)
2003-07-25 Charles Kerr <charles@rebelbase.com>
* pan/message-window.c (apply_identity): modified so that the
attribution and signature code know both the old and new info.
This lets us replace Identity fingerprints more accurately.
(117187, Nicolas Girard)
* pan/header-pane-renderer.c (header_pane_renderer_new): The date
column in the header pane wasn't completely displayed when other
fields were expanded.
(102491, Jerry Walter Segers)
* pan/message-window.c (message_window_cut_cb):
* pan/message-window.c (message_window_copy_cb):
* pan/message-window.c (message_window_paste_cb): cut/copy/paste to
the focused widget, rather than always to the GtkTextView.
Pasting to the group/email/subject fields didn't work right.
(112695, Alexander Skwar)
* pan/articlelist.c (articlelist_repopulate_nolock): fix 0.14.0.90
bug that caused a warning in the log window when the user first
loaded a new group.
(118267, Jan De Luyck)
2003-07-24 Charles Kerr <charles@rebelbase.com>
Pan 0.14.0.91 Released!
2003-07-24 Charles Kerr <charles@rebelbase.com>
* pan/task-state.h: break the `state' field into two fields:
`health' and `work'. This is so that when tasks fail, they
don't lose track of what they were working on. That way users
can still requeue the tasks via the Task Manager. This simple
little idea caused a lot of code ripples.
* pan/task-cancel.c:
* pan/task-post.c:
* pan/task-grouplist.c:
* pan/task-headers.c:
* pan/task-group-count.c:
* pan/task-bodies.c:
* pan/task-save.c:
* pan/task.c:
* pan/queue.c:
* pan/sockets.c:
* pan/socket-pool.c: sync.
(113405, Don Horsman)
* pan/articlelist.c (build_gnode_hierarchy): fix very minor
0.14.0.91 memory leak.
2003-07-23 Charles Kerr <charles@rebelbase.com>
* pan/text.c (header_pane_group_changed_cb): when the
header pane's group changes, clear the body pane so that
you don't have an article from the wrong group still showing.
(118152, Kelsey Bjarnason)
* pan/sockets.c (pan_socket_destructor): add workaround
for semantic changes between gnet 1.1.8's
gnet_tcp_socket_get_iochannel and 2.x's
gnet_tcp_socket_get_io_channel -- we no longer need to
unref the iochannel when we're done with it.
(118131, Dave Hill)
* pan/header-pane-renderer.c (set_node_style): respect
the gtk theme's colors in the header pane's score column
(117542, Jan De Luyck)
* pan/articlelist.c (style_set_cb): prevent an unnecessary
header pane refresh when toggling tabbed layout on/off.
(112812, Michael Waters)
* pan/articlelist.c (group_articles_removed_cb): if the number
of articles being removed equals the number of articles in the
group, we speed things up greatly by skipping the individual
node deletion and just gtk_clist_clear() the header pane instead.
(117516, Nicolas Girard)
2003-07-22 Charles Kerr <charles@rebelbase.com>
* pan/base/message-check.c (check_groups): remove the
moderated group warning. Devin reported this because it
was lumped in with check's and gave a `Post anyway,
despite these problems?' prompt, but on thinking about it
I realize how annoyed I'd be if I got _any_ info popup,
with or without the `post anyway?' phrasing, just because
I was posting to a moderated newsgroup.
(117535, Devin Carraway)
* pan/articlelist.c (select_node_nolock): the header pane
was losing focus after deleting articles.
(117183, Nicolas Girard)
* pan/rules/rule-action.c (rule_action_apply):
* pan/article-actions.c (article_actions_delete_articles):
deleting articles via a rule should also purge the articles
out of the article cache.
(111873, Dave Hill)
(117724, Sam Guidice)
* pan/message-window.c: added a status bar at the bottom of
the compose window, showing the line and column of the
text buffer's insert mark.
(104866, Brad Sims)
* pan/article-toolbar.c:
* pan/grouplist.c: add shortcuts for the group and header
pane's `Find' toolbar entry fields.
* docs/pan-shortcuts.html: new shortcuts file for 0.14.1.
(117785, Pan Team)
* pan/configure.in:
* pan/pan.spec.in:
* pan/pan/Makefile.am:
* pan/pan/smtp.c:
* pan/pan/sockets.c:
* pan/pan/pan.c:
* pan/pan/dialogs/dialog-newuser.c: Add support for compiling
with either GNet 1 >= 1.1.8 or GNet 2 >= 2.0.1.
(110833, Thomas Klausner)
2003-07-20 Charles Kerr <charles@rebelbase.com>
* pan/message-window.c: rewrote the "wrap text" code to
handle inserted text more gracefully.
(117651, T. G. Reaper)
* pan/base/serverlist.c: prevent the same server from
being added twice.
* pan/server-ui.c: prevent the user from creating a
new server with the same name of an existing server,
or an empty name of spaces, or a completely empty name.
2003-07-17 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_activate_selected): new
companion function to articlelist_read_selected(). In most
cases it acts as articlelist_read_selected(), but if there's
a large multipart then a `save as' dialog is popped up instead.
* pan/gui.c (gui_page_activate_nolock): sync.
* pan/articlelist.c (selection_changed_upkeep): sync.
(117173, Chris Petersen)
2003-07-16 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/articlelist.c (sort_hierarchy): remove some unneeded
assertions.
* pan/messageidset.c: follow the idiom of using braces
around mutex lock/unlocks to force them to be more visible.
2003-07-16 Charles Kerr <charles@rebelbase.com>
Pan 0.14.0.91 Released!
2003-07-16 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/articlelist.c (sort_hierarchy): only sort if there
is more than one article.
* pan/articlelist.c (articlelist_repopulate_nolock): since
we know the maximum number of Articles in the hierarchy,
allocate a pool of GNodes in one big chunk instead of
calling g_node_new() for each of them.
2003-07-15 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (calculate_article_header_pane_fields):
count the right number of new & unread children based on
the GNode tree (i.e., on the view rather than the model)
(115922, Paul Johnson)
* pan/filters/score.c (score_articles): fix bug that I
introduced yesterday when adding '=' compatability.
(Jan De Luyck)
* pan/articlelist.c: new approach to building the header pane.
We build a GNode tree first, to sort the subtrees (issue 108757)
and build the subtree scores (issue 115460) before we build the
GtkCTreeNodes.
* pan/header-pane-renderer.c: sync.
* pan/base/article.h: added two transient header-pane-only fields.
2003-07-14 Charles Kerr <charles@rebelbase.com>
* pan/filters/score.c (score_articles): slrn compatability:
stop scoring articles after they've matched a section (i.e.
* pan/filters/score.c (score_articles): slrn compatability:
stop scoring articles after they've matched a section (i.e.
a section with a '=' on its Score line).
* pan/dialogs/dialog-group-props.c: restored the group
preferences directory browse button.
(112120, Don Horsman)
(116655: scorefile invalidated callbacks)
* pan/filters/score.c (score_get_scorefile_invalidated_cb): new
function to trigger rescoring in the header pane.
* pan/filters/score.c (score_invalidate): sync.
* pan/filters/score.c (score_add): sync.
* pan/filters/score.c (score_remove): sync.
* pan/score-view-ui.c: sync.
* pan/score-add.c: sync.
* pan/actions.c: sync; remove explicit header pane rescoring.
* pan/article-actions.c: same.
* filters/score.c (ensure_articles_scored): add a new optional
GPtrArray argument to return the articles whose scores changed.
* pan/articlelist.c (rescore_articles): new function for fine-grained
header pane refreshing when the scorefile's invalidated. The idea is
to be faster than rebuilding the entire header pane.
(scorefile section names)
* pan/base/article.h (xref_header_foreach): string version of
article_xref_foreach() that can be used without Article or Group
pointers. article_xref_foreach()'s implementation now uses this.
* pan/filters/score.c (score_create_section_str): helper func
to generate an slrn section header from an article's Xref header.
* pan/article-actions.c (article_action_something_thread): when
adding a watch/ignore rule to the scorefile, set the section
name with the article's Xref header.
* pan/filters/score.c (prep_section_regex): Try to parse a
scorefile's section's newsgroup list in a way that's friendly
to both Xnews and slrn.
(Bug Fixes)
* pan/base/file-headers.c (file_headers_save_group_articles): fix
Solaris crash, where printf ("%*.*s", 0, 0, NULL) crashes instead
of writing zero bytes.
* pan/articlelist.c (articlelist_read_selected): fixed bug that
caused the selected article to be downloaded twice instead of
once.
(117173, Johan, Douglas Bollinger)
(Tweaks)
* pan/gui.c: change `Show Only' tooltips to `Match Only' for
consistency with the Filter menubar.
* pan/base/pstring.c: add (guchar) casts to isspace() calls to
silence compiler warnings.
* pan/base/article-thread.c: same.
* pan/base/pan-glib-extensions.c: same.
2003-07-10 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (header_pane_find_next_iterated_node_from):
fixed infinite loop bug that occurred when no articles matched
in the test_func.
(114464, DevilKin)
* pan/base/file-headers.c (file_headers_destroy): fixed bug
that didn't clear out the old 0.14.0-style header files.
* pan/base/group.c (group_remove_articles): ensure that the
dirty flag is set so the header file will reflect the change.
(Chris Petersen)
* pan/article.c (article_set_from_g_mime_message): fixed
parsing error that failed to pull the important headers
from the GMimeMessage.
(116906, Tihomir)
(117051, Geoff)
2003-07-08 Jason Leach <leach@wam.umd.edu>
* pan/pan.c (main): Move the argument parse block to before the
GTK+ init code, so pan will run with arguments like --version and
--help can be run on a non-graphical display.
(117017, Lloyd Budd)
2003-07-07 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: change the colors tab around a little bit so that
the preferences dialog will fit in 800x600 windows.
(111714, Rob Bedford)
* pan/filter-mediator.c (show_only_mine_cb): remove 0.14.0 'feature'
of tweaking the show flags when user hits `show only mine'.
(107377, Gollum)
* pan/server-ui.c: fix small pstring error.
2003-07-06 Charles Kerr <charles@rebelbase.com>
* pan/base/file-headers.c: bump to file format version 11, which
is a single file optimized for speed (the old format was optimized
for reducing disk space.)
2003-07-06 Christophe Lambin <clambin@easynet.be>
* pan/base/group.c (group_remove_articles): Fix bug where Pan would
incorrectly display the number of unread articles after getting new
headers.
(115315, Pan Team)
2003-07-05 Christophe Lambin <clambin@easynet.be>
* pan/base/pan-glib-extensions.c (get_next_token_pstring): getting two
consecutive tokens shouldn't flag the end of the run. This broke
setting the quoting tags in text.c when an article contained blank
lines (i.e. multiple \n's).
2003-07-03 Charles Kerr <charles@rebelbase.com>
* pan/base/article-thread.c (thread_article): normalizing articles
for threading doesn't require case-insensitive comparisons.
The (cheaper, faster) case-sensitive comparisons can be used.
* pan/articlelist.c (articlelist_repopulate_nolock): sort articles
here, rather than in the refresh/set_group functions, so that we
only have to sort articles that will actually be shown. This
significantly reduces sorting time, particularly in binaries groups.
* pan/pan.c (log_error_breakpoint): new empty function that one can put
a breakpoint on in gdb when trying to track down error messages
generated with g_log().
2003-07-02 Charles Kerr <charles@rebelbase.com>
More PStringification. strlen, strcmp, g_str_equal, and g_str_hash,
have all fallen off of cachegrind's map now. (The new bottleneck
is ... tolower()?!?)
2003-06-27 Charles Kerr <charles@rebelbase.com>
(Bugfixes)
* pan/text.c (task_bodies_ran_cb): fix memory leak.
(Valgrind)
(Tweaks)
* pan/base/pstring.h: Cachegrind's reporting that
strcmp, strlen, and g_str_equal are at the top of the hit list,
so this is a thin wrapper around char* that adds a length field.
* pan/base/article.h: use PStrings for all string fields.
* pan/base/group.h: ...so the Article string chunk is unused.
* pan/base/file-headers.h: ...so is the memory chunk read from disk.
* pan/messageidset.c: use PStrings rather than strings where reasonable.
* pan/acache.c: same.
* pan/articlelist.c: same.
* pan/flagset.c: same.
* pan/gui.c: same.
* pan/header-pane-renderer.c: same.
* pan/queue.c: same.
* pan/base/acache.c: same.
* pan/base/article-thread: quite a bit of strcmp/strlen elimination here.
* pan/base/gnksa.c: same.
* pan/filters/filter-phrase.c: same.
* pan/article-actions.c: sync.
* pan/message-window.c: sync.
* pan/nntp.c: sync.
* pan/base/decode.c: sync.
* pan/base/pan-glib-extensions.h (pan_strcmp_len): new utility.
* pan/base/pan-glib-extensions.h (pan_strncpyn): new utility.
2003-06-22 Christophe Lambin <clambin@easynet.be>
* pan/text.c (text_set_text_buffer_tags): use the monospace font for
article headers, rather than a hardcoded 'courier' font.
* pan/prefs.c (prefs_apply): sync.
(115683, Nick Pinney)
2003-06-21 Christophe Lambin <clambin@easynet.be>
* pan/filters/score.c (make_scorefile_entry): on Windows, use CR/LF
as line separators for the scorefile.
(109281, Paul Hudson)
2003-06-16 Christophe Lambin <clambin@easynet.be>
* pan/task-grouplist.c (task_grouplist_run): when getting all groups,
remove any groups that no longer exist on the server.
* pan/base/server.c (server_remove_unused_groups): sync.
(109578, mark)
* pan/status-item-view.c (string_shorten_nolock): fixed bug that
produced a spurious character in the status bar's shortened
description. Thanks to Per Hedeland for submitting a patch.
(112142, Carl Hudkins)
* pan/dialogs/dialog-about.c (dialog_about): remove obsolete link in
the 'About' dialog.
(103967, Toni Willberg)
2003-06-14 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c (determine_default_identity): fixed bug that
caused the Feedback utility not to use the default mail profile.
(Bruce Wellman)
2003-06-13 Christophe Lambin <clambin@easynet.be>
* pan/filters/filter-score.c (filter_score_dup): fixed bug that
incorrectly duplicated negated score filters. This caused negated
score filters to be saved incorrectly.
(John Aldrich)
2003-06-11 Charles Kerr <charles@rebelbase.com>
* pan/article-actions.c (article_action_selected_save_as): fix
NULL-pointer-dereferenced bug I introduced in CVS after 0.14.0.
(114514, Dave Hill)
2003-06-04 Christophe Lambin <clambin@easynet.be>
* pan/articlelist.c: fixed bug where changing filter settings wouldn't
refresh the articlelist.
2003-06-03 Charles Kerr <charles@rebelbase.com>
* pan/filters/score.c: fix Mac OS build error by making sure to
include <sys/types.h> before <regex.h>.
(114403, Max Horn)
* pan/grouplist.c (grouplist_update_group_nolock): fix bug that didn't
update the unread column in the grouplist when the article qty changed.
(114350, DevilKin)
* pan/articlelist.c (select_node_nolock): fix bug that prevented the
last article in the pane from being read.
(114354, Frank Van Damme)
* pan/util.c (pan_gtk_image_new_from_inline_text): new utility function.
* pan/message-window.c (create_image_from_inline): removed.
* pan/gui.c (create_image): removed.
* pan/message-check-ui.c (post_warning_cb): change the confirmation
dialog's buttons from yes/no to post/cancel, along with the compose
window's post icon for the post button. cancel is the default action.
2003-05-23 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: call gtk_window_set_role for the main window.
* pan/log-ui.c: call gtk_window_set_role for the log window.
* pan/message-window.c: call gtk_window_set_role for the compose window.
* pan/task-manager: call gtk_window_set_role for the task manager window.
(113602, Bobby D. Bryant)
* pan/articlelist.c (select_node_nolock): experimental code to
update the focus and select rows in the same clist call.
I need to run this on Windows to see how it compares to the
flicker seen in the old method.
* pan/header-pane-renderer.c (header_pane_renderer_refresh_node):
don't update cells that haven't changed.
2003-05-22 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_set_selected_nodes_nolock): avoid
flicker with unnecessary gtk_clist_{freeze,thaw} calls (1) inside
the recursive unselect and (2) with the local freeze,thaw call.
* pan/base/group.c (fire_groups_changed): added bitwise field
telling which group properties changed.
* pan/grouplist.c (grouplist_update_group_nolock): only update
columns which map to group properties that changed.
2003-05-21 Abel Cheung <maddog@linux.org.hk>
* configure.in: Added "vi" to ALL_LINGUAS.
2003-05-20 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (remove_article_nolock): small tweak: by
moving the child nodes in from first to last, so that the latest
is always added as the last child of the parent node, then we
can avoid gtkctree from calling gtk_node_collapse() on the
parent node, which fires an articlelist callback to messageidset.
* pan/articlelist.c (articlelist_articles_changed_cb): only add
the articles to the messageidset if it's our group. This avoids
having to build a messageidset on all the articles in
ensure_articles_scored() in set_group_worker_articles().
2003-05-20 Christophe Lambin <clambin@easynet.be>
* pan/base/server.c (server_save_grouplist_if_dirty): prevent multiple
tasks from writing the grouplist in parallel. We may want to make
the filename of the temporary file unique, though.
(111790, Dave)
2003-05-20 Charles Kerr <charles@rebelbase.com>
* pan/message-check-ui.c (post_warning_cb): don't send
strings with linefeeds to log_add() because they don't look
good in the log viewer.
* pan/task-post.c (task_post_run): same.
(113362, DevilKin)
* pan/log-ui.c: moved the log UI out of the dialogs directory
and fixed a memory corruption error.
(112582, Pan Team)
* pan/header-pane-renderer.c: fixed crash on shutdown that
I introduced when separating out the articlelist's renderer
code into a separate module.
(113311, Pan Team)
* pan/base/file-headers.c (file_headers_save_noref): fix
mutex deadlock.
* pan/tests/test-message-check.c: remove some trivial leaks.
2003-05-18 Charles Kerr <charles@rebelbase.com>
* pan/save-ui.c: change titlebar to fix small UI flaw.
(Frank Van Damme)
2003-05-17 Charles Kerr <charles@rebelbase.com>
* pan/group.c (group_get_articles): changed from public to private.
* pan/group.c (group_get_article_array): same.
* pan/group.c (group_article_forall): new public foreach-like function.
2003-05-14 Christophe Lambin <clambin@easynet.be>
* pan/sockets.c (pan_socket_getline): decrease the time slept between
reading on a (non-blocking) sockets to 100ms. This makes reading
articles more responsive.
2003-05-13 Christophe Lambin <clambin@easynet.be>
* pan/base/group.c (group_get_purged_string): fix bug introduced last
week that would expire all read articles.
2003-05-13 Charles Kerr <charles@rebelbase.com>
* pan/sockets.c: added Alberto BARSELLA's patch to resume
downloads when connections to the link to the server is lost.
(Alberto BARSELLA)
2003-05-12 Christophe Lambin <clambin@easynet.be>
* pan/pan-charset-picker.c: added Baltic Windows-1257 charset support.
(#111867, Zygimantas Augilius)
2003-05-12 Charles Kerr <charles@rebelbase.com>
* gmime/gmime-message.c:
* gmime/gmime-part.c:
* pan/base/pan-glib-extensions.c: Fix 64-bit portability bug
where size_t and guint were used interchangably.
(#112818, Blue Meanie)
2003-05-11 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.h (articlelist_node_next): removed.
* pan/articlelist.h (articlelist_node_prev): removed.
* pan/articlelist.h (articlelist_get_selected_node): removed.
* pan/articlelist.h (header_pane_select_next_if): new function.
* pan/articlelist.h (header_pane_select_prev_if): new function.
* pan/articlelist.h (header_pane_select_prev_if): new function.
* pan/article-find.c (find_article): sync.
* pan/base/article.c (article_forall_in_threads): new function.
* pan/base/article.c (article_get_unique_threads)): removed function.
* pan/base/group.c (group_remove_articles)): sync.
* pan/articlelist.c (articlelist_get_active_articles_nolock): sync.
* pan/base/article.c (article_get_subthread): removed function.
* pan/base/article.c (article_get_references): removed function.
* pan/base/article.c (article_forall_in_subthread): new function.
* pan/base/article.c (article_forall_in_references): new function.
* pan/articlelist.c (apply_filter_tests): sync.
* pan/base/article.c (article_forall_in_thread): new function.
* pan/base/article.c (article_get_thread): removed function.
* pan/messageidset.c (messageidset_add_articles): sync.
* pan/articlelist.c (articlelist_get_selected_article_nolock): removed.
* pan/articlelist.c (header_pane_first_selected): new function.
* pan/articlelist.c (header_pane_has_selection): new function.
* pan/action.c (pan_action_do): sync.
* pan/article-actions.c (article_action_supersede_selected): sync.
* pan/article-actions.c (article_action_cancel_selected): sync.
* pan/article-actions.c (article_action_ignore_selected_thread): sync.
* pan/article-actions.c (article_action_watch_selected_thread): sync.
* pan/articlelist.c (articlelist_selection_changed_cb): sync.
* pan/gui.c (update_menus_idle): sync.
* pan/articlelist.c (articlelist_get_active_articles_nolock): removed.
* pan/articlelist.c (header_pane_forall_active): new function.
* pan/articlelist.c (header_pane_foreach_active): new function.
* pan/article-actions.c (article_action_mark_selected_read): sync.
* pan/article-actions.c (article_action_mark_selected_unread): sync.
* pan/article-actions.c (article_action_delete_selected_articles): sync.
* pan/articlelist.c (articlelist_get_selected_articles_nolock): removed.
* pan/articlelist.c (header_pane_forall_selected): new function.
* pan/articlelist.c (header_pane_foreach_selected): new function.
* pan/article-actions.c (article_action_selected_save_as): sync.
* pan/gui.c (gui_page_activate_nolock): sync.
* pan/save-ui.c: removed Group* dependencies.
* pan/base/article-thread.c (thread_articles): take an array,
rather than a GPtrArray, of Articles.
2003-05-10 Christophe Lambin <clambin@easynet.be>
* gmime/Makefile.am: used a forward slash rather than backslash
(112724, Matthew Fischer)
2003-05-08 Charles Kerr <charles@rebelbase.com>
* pan/base/group.[ch]: make the newsrc data fields private,
and instead provide functions like group_is_article_read()
to encapsulate these fields.
* pan/base/article.c: sync.
* pan/base/newsrc-port.c: sync.
* pan/base/message-identifier.c: sync.
* pan/base/file-grouplist.c: sync.
* pan/base/file-headers.c: sync.
* pan/base/util-mime.c: sync.
2003-05-08 Charles Kerr <charles@rebelbase.com>
* pan/util.c (pan_timeout_add): fix small memory leak.
Thanks to Valgrind.
* pan/util.c (try_to_execute_url): fix small memory leak.
Thanks to Valgrind.
* pan/base/newsrc-port.c (newsrc_import): fix minor memory leak
when the .newsrc file being imported doesn't exist.
* pan/tests/test-decode.c: fix scaffolding leaks so we can look
for real Pan leaks by valgrinding the unit tests.
* pan/tests/test-newsrc.c: same.
* pan/tests/test-thread.c: same.
* pan/tests/test-wrap.c: same.
2003-05-06 Charles Kerr <charles@rebelbase.com>
* pan/filters/score.c: rearrange #include order for Mac OS X.
(#111620, Jubal)
* pan/gui.c (menu_translate): fix OS X compiler warning.
(#111620, Jubal)
2003-05-06 Danilo Šegan <dsegan@gmx.net>
* configure.in: Removed "sp" and added "sr@Latn" to ALL_LINGUAS.
2003-05-05 Charles Kerr <charles@rebelbase.com>
* Pan 0.14.0 Released!
2003-04-29 Kjartan Maraas <kmaraas@gnome.org>
* pan/util.c: (pan_unlock_from): Fix a typo in a debug msg.
2003-04-29 Christophe Lambin <clambin@easynet.be>
* configure.in: bumped to 0.14.0
* pan/dialogs/dialog-about.c: added credits
2003-04-24 Christophe Lambin <clambin@easynet.be>
* Pan 0.13.96 Released!
2003-04-23 Charles Kerr <charles@rebelbase.com>
* pan/base/text-massager.h: complying with the Law of Demeter,
one global at a time: replacing the wrap_column and quote_chars
globals, with wrap_column and quote_chars properties of a
TextMassager class, which performs wrap/fill/mute-quoted transforms.
* tests/test-wrap.c: sync.
* tests/base/base-prefs.c: remove quote char globals.
* tests/test-*.c: sync.
* pan/prefs.c: sync.
* pan/text.c: add a TextMassager for the text pane, and update
the update functions to take a TextMassager.
* pan/prefs.c: remove wrap_column global. Update the text pane's
massager, rather than the now-removed wrap/quote globals.
* pan/message-window.c: Compose windows have their own
TextMassager. This way outgoing posts can be held to Usenet
standards (72 char wrap, ">" is the only quote character)
regardless of what nonsense the user has for reading articles.
* pan/filter-ui.c: remove #include <pan/base/base-prefs.h>
* pan/score-add-ui.c: same.
* pan/score-view-ui.c: same.
* pan/server-ui.c: same.
* pan/task-cancel.c: same.
* pan/text.c: same.
2003-04-23 Christophe Lambin <clambin@easynet.be>
* pan/task-headers.c (task_headers_run_download): load the group
before expiring old articles.
(Nathan)
2003-04-22 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c: use g_newa() instead of g_alloca().
* pan/flagset.c: same.
* pan/save-ui.c: same.
* pan/smtp.c: same.
* pan/task-bodies.c: same.
* pan/task-save.c: same.
* pan/base/acache.c: same.
* pan/base/article.c: same.
* pan/base/decode.c: same.
* pan/base/serverlist.c: same.
* pan/base/util-file.c: same.
* pan/base/util-wrap.c: same.
2003-04-22 Christophe Lambin <clambin@easynet.be>
* pan/status-item-view.c (string_shorten_nolock): made this function
UTF8-aware, so that it doesn't truncate the string in the middle
of a multibyte character.
(110547, Pan Team)
* pan/base/article.c (articles_set_decode_state): fixed possible
segfault when saving attachments.
* pan/base/article.c (articles_set_multipart_state): same.
2003-04-22 Charles Kerr <charles@rebelbase.com>
* pan/pan.c (main): If we need to prompt the user whether or not
they want to restore old tasks, move the task file to a scratch
file so that other startup tasks (i.e., `get new headers on startup')
don't corrupt the tasks.xml file before we can restore old tasks.
(#111307, Michael A. Chase)
2003-04-21 Charles Kerr <charles@rebelbase.com>
* README.windows: bump to 0.13.95.
* pan.iss: add gtk2.2/bin to path to pickup the spawn-helper
* pan/message-window.c: fix file substitution
* pan/util.c (try_to_execute_url): same.
2003-04-21 Christophe Lambin <clambin@easynet,be>
* Pan 0.13.95 Released!
2003-04-21 Charles Kerr <charles@rebelbase.com>
* pan/article-actions.c (article_copy_articles_to_folder): handle
the case of copying articles from one folder to another.
(110938, Dave Hill)
* pan/article-actions.c (article_action_delete_selected_articles):
make sure we pass the right acache key to acache, otherwise folders'
bodies won't be purged.
(110937, Dave Hill)
2003-04-21 Charles Kerr <charles@rebelbase.com>
* pan/base/article.h (Article): `state' was an int that held
bit flags for different decode, multipart, and error states.
Replaced `state' with different variables for these three types,
and made their values ints rather than bit flags, so that
articles can't have contradictory states set (i.e., having
MULTIPART_ALL and MULTIPART_SOME both set).
* pan/base/article.c: sync.
* pan/base/article-thread.c: sync.
* pan/base/decode.c: sync.
* pan/base/file-headers.c: sync.
* pan/articlelist.c: sync.
* tests/test-article.c: added new tests for
articles_set_multipart_state(),
article_get_multipart_state(),
articles_set_decode_state(),
article_get_decode_state()
* tests/test-thread.c: added new tests for
article_get_root(),
article_get_subthread(),
article_get_thread(),
article_get_references()
2003-04-19 Charles Kerr <charles@rebelbase.com>
* pan/base/group.c (groups_set_subscribed): fixed crash caused
by a variable that went uninitialized in some cases.
Thanks to Pav Lucistnik for finding this and tracking the problem.
(111145, Pav Lucistnik)
2003-04-17 Charles Kerr <charles@rebelbase.com>
* test/test-article.c: added some more tests.
* test/test-thread.c: added some more tests.
* pan/task-headers.c (task_headers_run_download): remove the
expired headers before adding the new ones.
* pan/base/group.c (group_remove_articles): ensure that the
removed articles are unthreaded.
(#109498, Pan Team)
* pan/base/article-thread.c (normalize_subject): don't strip out
the denominator. If someone posts two multiparts with identical
subjects but different number or parts -- ie, two versions for
low and high bandwidth users -- Pan wasn't able to distinguish
between the two. "abc (1/20)" "abc (1/50)"
(#109498, Pan Team)
* pan/base/article-thread.c (compare_pA_to_pA_by_part): ensure
that non-multipart posts are sorted by subject, reply, and date.
Previously non-multipart child threads were sorted only by
mulitpart number, which doesn't do much good in text groups.
* tests/test-thread.c: new module for testing article_thread().
2003-04-16 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c (populate_message_from_mw): ensure the
author string is encoded.
(110967, Tõivo Leedjärv)
2003-04-16 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: minor HiGification: reordered the toolbar filter
buttons to match the order that they appear in the Filter menu.
2003-04-15 Christophe Lambin <clambin@easynet.be>
* pan/filters/score.c (score_articles): don't use expired scores.
2003-04-15 Charles Kerr <charles@rebelbase.com>
* pan/util.c (launch_external_editor): new utility to handle
letting the user edit files with the outside editor.
Most of the code is from score-view-ui.c, but is promoted
into util so that Tool|Edit Scorefile can use it too.
* pan/articlelist.c (threads_popup_entries): add
"View Article Scores" to the header pane popup menu.
* pan/socket-pool.c (socket_pool_request_connection): don't try
to open a new connection if a connection is pending. This is to
prevent Pan from maxing out on server connections, when only one
is needed, by queue_run_what_we_can().
(110790, Brian Morrison)
2003-04-14 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_key_press): restore the correct
behavior of control-shift-{begin,end}, which broke in 0.13.4
while fixing ticket #88869. Also tweaked the code by request s.t.
shift-{begin,end} behaves the same as control-shift-{begin,end}.
(110794, Duncan)
* pan/base/article.c (articles_are_valid): fix potential
null pointer dereference / FMR bug when called with article_qty == 0.
(110799, Pan Team)
2003-04-14 Christophe Lambin <clambin@easynet.be>
* pan/base/pan-glib-extensions.c (pan_header_to_utf8): replace calls
to g_mime_iconv... with g_mime_charset_strndup(). If this breaks
anything: it was Charles' idea. :-)
2003-04-13 Christophe Lambin <clambin@easynet.be>
Pan 0.13.94 Released!
2003-04-11 Christophe Lambin <clambin@easynet.be>
* pan/text.c (task_bodies_ran_cb,text_set_from_identifiers): when
decoding headers for the article pane, use the article's charset,
if it's specified.
(110491, Toivo Leedjarv)
* pan/text.c (add_header): mimic header pane behavior and fall back
to the locale's charset if decoding using article/group charset fails.
2003-04-10 Charles Kerr <charles@rebelbase.com>
* pan/text.c (text_create): use the right charset for the
copyright and license.
(110478, Toivo Leedjarv)
* pan/queue.c (queue_run_what_we_can): If user has "don't remove
failed tasks" checked in the preferences dialog, don't remove
failed tasks.
(108593, Bobby D. Bryant)
2003-04-09 Charles Kerr <charles@rebelbase.com>
* pan/base/pan-glib-extensions.c (pan_body_to_utf8): handle invalid
charset sequences more gracefully.
(90067, Christian Lohmaier)
* pan/filters/filter-score.c (filter_score_test_articles): fix bug
tickled by yesterday's filter-aggregate changes.
(110389, Pan Team)
* pan/filters/filter-aggregate.c (filter_aggregate_test_articles):
on boolean operations, test for true with !0, rather than ==TRUE.
D'oh, this is a real beginner bug.
2003-04-08 Charles Kerr <charles@rebelbase.com>
* pan/pan.c (restore_tasks_dialog): clean up the text in this message.
(110319, Samuli Karkkainen)
* pan/filters/score.c (remove_unnecessary_filters): if a score entry
has no criteria -- either through a malformed scorefile or if the only
criteria are `expensive' criteria currently unsupported by Pan -- then
remove the score entry so that we don't let every article match.
(110041, Olav Vitters)
* pan/sockets.c (pan_socket_new): replace sigignore (SIGPIPE) with
signal (SIGPIPE, SIG_IGN) for portability.
(110151, Nathan Robertson)
* pan/test/test-filter.c: added 25 new filter-aggregate regression tests.
* pan/filters/filter-aggregate.c (filter_aggregate_test_articles):
since it's more efficient to invoke some filters (such as
filter-score) with all the articles in a batch, rather than one at
a time, filter_aggregate_test_articles() now invokes its child
filters' test functions in batches.
(110259, Pan Team)
* pan/filters/score.c (parse_score_file): handle broken Expires:
headers more gracefully.
(110256, Pan Team)
2003-04-04 Charles Kerr <charles@rebelbase.com>
* pan/base/group.h (group_add_article): remove unused prototype.
* pan/base/server.h (server_add_group): remove unused prototype.
* pan/nntp.c (nntp_download_headers): removed unused code.
* pan/message-identifier.c (message_identifier_add_source):
make certain we don't add a duplicate source for the article.
* pan/message-identifier.c (message_identifier_add_source_from_article):
in the article_xref_foreach(), pass `true' to skip the current
group, as we've already added it as the primary group.
* pan/tests/test-mid.c: new test for exercising MessageIdentifier.
2003-03-31 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: added a sixth layout order.
(109652, Eugenia Loli-Queru)
* pan/filters/filter-phrase.c: fix case-insensitive substring
matching bug that I introduced yesterday.
* pan/test/test-filters.c: added more regression tests.
2003-03-31 Charles Kerr <charles@rebelbase.com>
Pan 0.13.93 Released!
2003-03-30 Charles Kerr <charles@rebelbase.com>
* pan/filters/filter-phrase.c: use the Boyer-Moore-Horspool-Sunday
search algorithm, with case-sensitive and insensitive skip lists,
to get a 5x speed increase in searching for "contains" match-type
filter criteria. This makes a big difference in scoring.
2003-03-30 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-message.c (g_mime_message_set_subject): Encode the
subject before setting the value in the raw header list. Completes
the fix for bug #109004.
2003-03-30 Christophe Lambin <clambin@easynet.be>
* gmime/gmime-header.c (g_mime_header_add,g_mime_header_set): sync. w/
GMime CVS. This fixes a problem where subjects with 8bit characters
weren't displayed correctly in the article pane.
(109004, Patrick Lamaiziere)
2003-03-28 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/file-headers.c (file_headers_server_name_changed):
utility for renaming a servers' data files when its name changes.
* pan/base/file-grouplist.c (file_headers_server_name_changed): same.
* pan/base/server.c (server_set_name): new utility for setting name
and calling file_{headers,grouplist}_server_name_changed() when
appropriate.
* pan/base/serverlist.c: sync.
* pan/server-ui.c: sync.
(100651, John van der Kamp)
* pan/base/acache.c (acache_expire_message_ids): new utility function
that wraps around acache_expire_messages().
* pan/article-actions.c (article_action_delete_selected_articles): call
acache_expire_message_ids().
(109273, Lin Ford)
2003-03-27 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/articlelist.c (apply_filter_tests): The need to hide ignored
articles outweighs the need to show relatives in the thread.
(#108991, BlueJAMC)
* pan/rules/rule-action.c: added watch/ignore back into rule actions.
* pan/rules/rule-edit-ui.c: same.
* pan/rules/rule-xml.c: same.
* pan/article-actions.c: same.
(#109274, Chris Charlebois)
* pan/filters/filter-edit-ui.c: fixed scores in custom filters.
(#109271, Lin Ford)
2003-03-26 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/pan-glib-extensions.c (pan_get_home_dir): wrapper around
g_get_home_dir() that falls back to something reasonable if
g_get_home_dir() returns NULL on Windows.
* pan/pan-file-entry.c: sync.
* pan/prefs.c: sync.
* pan/base/base-prefs.c: sync.
* pan/base/pan-config.c: sync.
* pan/base/util-file.c: sync.
* pan/dialogs/dialog-newuser.c: sync.
(#109279, Paul Hudson)
* pan/prefs.h: made the scorefile default location portable by using
G_DIR_SEPARATOR_S instead of hardcoding a '/'.
2003-03-26 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/message-window.c (load_signature): rejigger the order in which
we decide how to load the signature file. Parsing to the shell and
using argv[0] as the filename is bad on windows, where spaces abound.
(109282, George McAllister)
2003-03-24 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/text.c (add_header): decode any header that's quoted-printable
encoded, unless we're in 'show all headers' mode (where we want to
see the raw header).
2003-03-24 Christophe Lambin <clambin@easynet.be>
* Pan 0.13.92 Released!
2003-03-23 Christophe Lambin <clambin@easynet.be>
(Charset Fun)
* pan/message-window.c (get_author_utf8): decode author for attribution
line when that author is quote-printable encoded.
(108567, Patrick Lamaiziere)
* pan/base/pan-glib-extensions.c (pan_header_to_utf8): fixed bug that
attempted to convert valid UTF-8 text, leading to corrupted text fields.
(109006, Patrick Lamaiziere)
(Bug Fixes)
* pan/prefs.c (prefs_apply): fixed segfault when closing the
Preferences window (Charles: the other way to fix this is
is to add a color picker for 'score 0'. I'm assuming that
wasn't the intention).
2003-03-22 Charles Kerr <charles@rebelbase.com>
* pan/filters/filter-score.c: added more ranges of scores.
* pan/gui.c: sync
* pan/filter-mediator.c: sync
* pan/prefs.c: sync
2003-03-22 Christophe Lambin <clambin@easynet.be>
* pan/prefs.c: added new section to customize the header pane columns.
* pan/prefs.h: sync.
* pan/articlelist.h: sync.
* pan/articlelist.c: sync.
* pan/base/acache.c (acache_basename_to_message_id): fixed bug when
decoding URL-encoded Message ID's.
2003-03-21 Charles Kerr <charles@rebelbase.com>
* pan/filters/filter-phrase.c (regexp_unescape): fix bug that
removed escaped trailing $ characters from strings.
(108769, BlueJAMC)
* pan/base/acache.c: change message-id filename encoding in two ways:
(1) only encode characters listed as illegal on vfat/fat32
(2) use URL encoding instead of the homebrew encoding.
(104716, Jim Dutton)
2003-03-19 Charles Kerr <charles@rebelbase.com>
* pan/text.c (set_text_from_message_nolock): make certain that
the mime-part headers are displayed along with the main message
headers.
(108489, Mahaleo)
* pan/pan.c (main): add GLib-GObject to the list of log sources
that should be directed to log_add().
* pan/text.c (get_pixbuf_from_mime_part): avoid g_warning message
in cases where the pixbuf can't be created.
2003-03-17 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: removed `purge articles older than N days'.
This was an awkward feature, since different servers/groups purge
out at different rates.
(108487, Torstein Sunde)
* pan/text.c (insert_part_partfunc): fix double-yEnc-decode bug.
(107113, Michael Waters)
* pan/pan.c (main): ensure that Pan is online on startup.
(108575, Ketil Thorsen)
* pan/prefs.c: fix another bug of mine of appending paths incorrectly.
At the core of this is that we're playing fast & loose with config
keys in general, so I've started listing all keys in prefs.h so that
(1) key prefix errors will go away,
(2) there won't be any shear in separate files when keys change,
(3) to provide a single location for some low-level prefs documentation
(108592, Bobby D. Bryant)
2003-03-16 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: remove the feature of setting score filter thresholds
arbitrarily. This was for compatability with slrn, but appears to be
of marginal value, mostly unused in slrn, unimplemented in XNews, and
will cause compatability headaches if the values are changed here but
not in another newsreader.
* pan/base/acache.c (acache_expire_to_size): fix crash that occurred
when the article cache directory had been symlinked to a directory
that didn't exist.
(103872, Frederik Vanrenterghem)
* pan/filters/filter-phrase (filter_phrase_test_articles): for cases
of "References STARTS_WITH", walk up the article chain before applying
the test -- some newsreaders munge long References headers, which can
break threading.
(107869, Torstein Sunde)
* pan/actions.[ch]: new file to act as a clearinghouse for invoking
actions without having to know anything about the GUI.
* pan/gui.c: sync.
* pan/articlelist.c: sync.
2003-03-14 Christophe Lambin <clambin@easynet.be>
(Charset Fun)
* pan/message-window.c: Posting Profiles now contain a charset for
outgoing mails/posts. Previously, the group's default charset was used
for this purpose. This splitting of charsets allows us to remember
the posting charset (in the profile) without changing the group's
charset (used to parse messages that don't specify their own charset).
(99247, Petr Chloupek)
* pan/identities/identity.[ch]: added 'posting charset' to the profile.
* pan/identities/identity-xml.c: same.
* pan/identities/identity-edit-ui.c: same.
* pan/pan-charset-picker.[ch] (pan_charset_picker_set_charset): new
function to change the active charset from within the Composer.
(Bugfixes)
* pan/prefs.c (prefs_apply): fixed assertion failure.
2003-03-14 Charles Kerr <charles@rebelbase.com>
(Datafile Backups)
* pan/base/util-file.c (pan_file_swap_datafile): utility for moving
a temporary file into a real datafile location. Any previous real
datafile is backed up, and if the temporary -> real substitution
fails, the datafile is restored from the backup.
* pan/base/file-grouplist.c (save_groups_to_file): sync.
* pan/base/newsrc-port.c (newsrc_export): sync.
* pan/filters/filter-xml.c (filter_xml_write): sync.
* pan/identities/identity-xml.c (identity_xml_write): sync.
(100444, Gabriel Phoenix)
* pan/base/util-file.c (pan_file_write_datafile): utility wrapper
around pan_file_swap_datafile() for files small enough to hold in memory.
Pass the memory to pan_file_write_datafile(), which will write it
to a temporary file and invoke pan_file_swap_datafile(), so that the
caller doesn't have to mess with the tempfile.
* pan/base/pan-config.c (pan_config_save): sync.
(100444, Gabriel Phoenix)
(And a few things I noticed while testing the above changes...)
* pan/base/group.c (groups_set_subscribed): don't change the
subscription states of groups whose subscription state already
matches the desired state. This prevents the server dirty flag
from being set without changes, speeding up newsrc imports.
* pan/gui.c (gui_shutdown): fold all the pan_config_sync() calls
during shutdown into a single call.
* pan/pan.c (pan_shutdown): sync.
* pan/util.c (gui_save_column_widths): sync.
* pan/util.c (gui_save_column_widths_tree_view): sync.
* pan/util.c (gui_save_window_size): sync.
* pan/base/serverlist.c (serverlist_save): folded two
pan_config_sync() calls into one.
2003-03-14 Charles Kerr <charles@rebelbase.com>
* pan/text.c (text_button_pressed): prevent second and third browser
windows from popping up when a user double-clicks on a URL.
(107484, Bruce Bowler)
2003-03-13 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: more layout changes. Added in `font' and `color'
tabs to make room for the group pane font to be plugged back in,
and for chris' GUI for customizing the header pane columns.
2003-03-13 Christophe Lambin <clambin@easynet.be>
* Pan 0.13.91 Released!
2003-03-13 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_set_selected_nodes_nolock): fix bug
that sometimes caused the header panes' scrollbars to disappear when
in 'zoom' mode.
(98452, Sal Tepedino)
* pan/pan.c (show_help): break the --help message into smaller chunks
chunks for easier translation maintainence.
* pan/text.c (text_create): same for the startup message.
(108288, Christian Rose)
* pan/pan.c (show_help): use printf ("Pan %s", VERSION) rather than
printf ("Pan " VERSION); gettext understandably perfers the former.
(108290, Christian Rose)
2003-03-12 Charles Kerr <charles@rebelbase.com>
* pan/filters/filter-bytes.[ch]: new filter for filtering on the
number of bytes in an article.
* pan/filters/score.c (parse_score_file): handle "Bytes" as a
score criterion when parsing scorefiles.
(108126, J. B. Moreno)
2003-03-12 Christophe Lambin <clambin@easynet.be>
* pan/prefs.c (handle_color_picker): fixed bug that saved changed
colors under the wrong pan_config key.
(108220, TRB)
* pan/prefs.c (text_set_text_buffer_tags): fixed some assertion
failures when changing colors.
* pan/gui.c (create_toolbar): changed tooltip of scoring toolbar
button to reflect behavior.
2003-03-12 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: added `rescore articles' menubutton in `tools'.
(108171, Thorsten Ruffle-Brandt)
* pan/status-item-view.c (string_shorten_nolock):
use pango methods instead of deprecated gdk_font calls.
(Valgrind)
* pan/text.c (text_set_text_buffer_tags): another minor
memory leak.
(Valgrind)
2003-03-11 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c (message_gen_attribution_string): ensure author
is in UTF-8 before calling internet_address_parse_string(). This fixes
a message corruption in the composer, when replying to messages
with 8bit characters in the author.
* pan/util-mime.c (pan_g_mime_message_get_charset): new helper function
that parses a charset out a mime message.
2003-03-11 Charles Kerr <charles@rebelbase.com>
* pan/task-grouplist.c: use get_next_token_g_str()
instead of get_next_token_str() to avoid unnecessary
malloc/free calls.
* pan/message-window.c (post_checked_cb): same.
* pan/base/util-mime.c (pan_g_mime_message_mark_read): same.
* pan/filter-mediator.c (rebuild_custom_filter_menu):
fix minor memory leak.
(Valgrind)
2003-03-10 Charles Kerr <charles@rebelbase.com>
* pan/gmime/gmime-utils.c: move some printf()s to only
print when the debug macro d() is #defined.
(107795)
* pan/base/base-prefs.c: added new preferences setting,
remove_articles_more_than_N_days_old, to purge out old
articles. The default value is 14.
(107905)
2003-03-09 Charles Kerr <charles@rebelbase.com>
* pan/filters/score.c (score_add): add support for OR'ing
the criteria together and for naming the score entry.
* pan/article-actions.c (article_action_watch_selected_thread):
new function to implement the old `watch thread' behavior
in the scorefile.
* pan/article-actions.c (article_action_ignore_selected_thread):
same.
(107869, Torstein Sunde)
* pan/filters/score.c: don't create the ~/News directory until
we need to write a scorefile.
(107919, Justin Piszcz)
2003-03-09 Christophe Lambin <clambin@easynet.be>
* pan/prefs.c (prefs_apply): fixed saving the score editor.
(107894, Carl Hudkins)
2003-03-08 Charles Kerr <charles@rebelbase.com>
* pan/print.c: handle delete-print-dialog-from-window-manager.
(Carl Hudkins)
* po/POTFILES.in: removed dead files.
(107900, Evandro Fernandes Giovanini)
* pan/score-view-ui.c (tree_view_row_activated_cb): fixed 0.13.90
bug that miscast the user_data gpointer, causing a crash.
(107891, Carl Hudkins)
* pan/text.c: improved how `show all headers' interacts with 0.13.90's
header display.
(Torstein Sunde)
2003-03-08 Christophe Lambin <clambin@easynet.be>
* pan/filter-edit-ui.c: added article score to the Filter Editor.
2003-03-07 Christophe Lambin <clambin@easynet.be>
* Pan 0.13.90 Released!
2003-03-06 Charles Kerr <charles@rebelbase.com>
* pan/filters/score.c (get_scorefile_filename): ensure
that the scorefile's directory exists.
2003-03-05 Charles Kerr <charles@rebelbase.com>
* pan/gui.c (gui_save_column_widths): moved to util.c
* pan/gui.c (gui_restore_column_widths): moved to util.c
* pan/gui.c (gui_save_window_geometry): moved to util.c
* pan/gui.c (gui_restore_window_geometry): moved to util.c
* pan/base/newsrc.h: made this data structure opaque.
* pan/util.h (gui_queue_add): moved this gui.h to util.h, which
should probably be renamed util-gui.h.
* pan/util.h (pan_widget_set_font): same.
* pan/guil.h: sync.
* pan/base/gnksa.h (pan_remove_signature): moved from util.h.
* pan/util.h: sync.
* other janitorial work, almost all related to cleaning
up obsolete #includes.
2003-03-04 Christophe Lambin <clambin@easynet.be>
* pan/prefs.c (prefs_apply): fixed GTK assertion failures.
2003-03-04 Charles Kerr <charles@rebelbase.com>
* pan/util.c: more janitorial work.
* pan/base/article.c: more janitorial work.
* pan/base/server.c: more janitorial work.
No feature changes, just moving variables to smaller scopes,
cleaning up comments, removing a few tested-as-unused branches,
and sorting the headers for readability.
2003-03-03 Charles Kerr <charles@rebelbase.com>
* pan/base/message-identifier.c (message_identifiers_delete):
new function analogous to message_identifiers_mark_read().
There's no real difference in speed between this and the old
way of deleting articles, but this a lot easier to follow.
* pan/article-actions.c (article_action_delete_selected_articles):
use message_identifiers_delete().
* pan/base/group.c (group_remove_crossposts): removed unused
function.
* pan/pan.c (my_log_handler): route g_log() and g_warning()
messages to Tools|Log Window, rather than the console, so
that they're easier to gather up and mail in a bug report,
and so that they don't annoy Windows users with a popup console.
(107519, Donald L McDaniel)
* pan/text.c: marked the copyright/intro text for translation.
(107219, Pablo Gonzalo del Campo)
* pan/socket-pool.c (socket_pool_checkin): if the socket's error
flag is set, be rude and don't bother sending a quit message
before disconnecting. This eliminates a console warning.
(107324, Erik Funkenbusch)
* pan/base/message-identifier.c (message_identifiers_mark_read):
fixed obscure bug where a "mark unread" action didn't propagate
to crossposts.
2003-03-02 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-iconv.c: Synced up with gmime-2-0 cvs (contains some
fixes to correctly expire iconv_t buckets from the cache).
2003-03-02 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: Finish integrating scoring into the preferences
dialog. The number of settings for the header pane grew such
that some tab shuffling had to be done. It took a spreadsheet
to find non-conflicting mnenonics for everything, but that's done
too. I pity the translators; is there an easy way to
i18nize mnemonics? :P
* pan/base/article.c: finish up this file's cleanup.
* pan/text.c: experimentally put the article headers into the
text pane, rather between the header and text pane, so that more
room is available for reading articles when you page down in
the article body.
2003-03-02 Christophe Lambin <clambin@easynet.be>
* pan/base/article.c (articles_are_valid_in_group): fixed invalid
assert.
2003-03-01 Charles Kerr <charles@rebelbase.com>
* pan/gui.c (main_menu_entries): on Windows, File|Quit should be
File|Exit, and should have an accelerator of alt-F4.
(107328, Simon Cooke)
2003-02-28 Charles Kerr <charles@rebelbase.com>
* pan/base/article.c: more cleanups.
* tests/test-article.c: don't make Chris clean up my cleanups. :)
* tests/test-filter.c: same.
2003-02-28 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: added new default application lists for
browsers & editors on Windows platforms.
(#107302, Donald L McDaniel)
2003-02-28 Christophe Lambin <clambin@easynet.be>
* tests/test-article.c: sync. w/ housekeeping.
* tests/test-filter.c: same.
* pan/base/article.c (article_chunk_header): fixed crash in filter
regression test.
* pan/base/group.c (group_add_articles_impl): grouplist counters
weren't updated when new headers were added.
2003-02-27 Charles Kerr <charles@rebelbase.com>
* pan/base/article.[ch]: some much-needed housekeeping.
* pan/base/group.[ch]: same.
2003-02-27 Charles Kerr <charles@rebelbase.com>
* configure.in: bump to 0.13.90.
(Scoring)
* pan/filters/score.c: new. The heart of all the scoring work.
* pan/score-add-ui.c: new. GUI for creating a new score.
* pan/score-view-ui.c: new. GUI for debugging an article's scores.
* pan/nntp.c: always keep the Xref header, even if the article isn't
crossposted, so that we don't break scoring-by-Xref-headers.
* pan/base/article-thread.[ch]: added support for sorting by score.
* pan/base/article.[ch]: folded `self_passes_filter' and
`tree_passes_filter' into a single field.
* pan/base/article.[ch]: new field: Article.score_date
* pan/base/group.[ch]: added
STATE_FILTER_SCORE_{LOW,HIGH,VERY_LOW,VERY_HIGH}
* pan/articlelist.c: add scoring support.
* pan/filter-mediator.c: same.
* pan/gui.c: added new menu & tollbar buttons for score filtering.
* pan/prefs.c: added in some rather ugly scoring preferences.
Expect this to change soon.
* pan/filters/filter-phrase.c: speedups.
* pan/filters/filter-score.c: add support for 4 levels of score
filtering.
* pan/filters/filter-xml.c: sync with phrase, score changes.
* pan/rules/rule-manager.c: remove manditory canned rules for
spam & bozos. This functionality is now assumed by the scorefile.
* pan/filters/filter-manager.c: removed the spam & bozo filter names.
This functionality is now assumed by the scorefile.
* pan/thread-watch.[ch]: removed.
This functionality is now assumed by the scorefile.
(Cleanup)
* pan/save-ui.c: better adherance to Gnome HiG layout specs.
* pan/util.c (pan_hig_frame_new): removed unused kludge.
* pan/base/article.[ch]: remove unused func: article_dup()
* pan/base/article.[ch]: remove unused func: articles_get_message_ids()
(Utility)
* pan/base/util-file.c (pan_file_normalize): new utility.
* pan/base/newsrc-port.c: use pan_file_normalize().
* pan/message-window.c (load_signature): same.
* pan/save-ui.c: same.
2003-02-26 Charles Kerr <charles@rebelbase.com>
* Pan 0.13.4 Released!
2003-02-25 Charles Kerr <charles@rebelbase.com>
* configure.in: added patch to fall back to libxml2-config
if libxml2's pkgconfig .pc file isn't found. Apparently Sun
left the .pc file out of their Gnome 2 packages.
(Clinton Bunch)
(Bug Fixes)
* pan/base/gnksa.c (gnksa_split_from): Fixed crash that
occured when a posters' email address is longer than
500 characters long.
(107025, Mr. Nice)
* pan/gui-headers.c (add_header_nolock): Fixed off-by-one
error introduced on Feb 12th for bug #105879.
* pan/base/message-check.c (strip_attribution_and_signature):
Fix memory leak found by Valgrind.
* pan/message-window.c (check_charset_for_body):
Fix memory leak found by Valgrind.
(HiG)
* pan/server-ui.c: make sure the HiG's dialog spacer sizes don't get
resized by adding the adustments with gtk_table_attach_defaults.
* pan/identities/identity-edit-ui.c: same.
* pan/prefs.c: same.
* pan/dialogs/dialog-newuser.c: same.
2003-02-16 Charles Kerr <charles@rebelbase.com>
* pan/base/article.c (article_get_author_str): optimizations
for the most common case. cachegrind says this is a hotspot.
2003-02-15 Charles Kerr <charles@rebelbase.com>
* pan/base/article.c (xref_foreach): small speedup.
* pan/base/article.c (article_get_unique_threads): same.
* pan/article-actions.c (remove_duplicate_articles): same.
2003-02-15 Charles Kerr <charles@rebelbase.com>
* pan/base/group.c (group_remove_articles): small speedup.
2003-02-14 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_read_selected): fix bug
introduced yesterday that caused the first article to be
downloaded twice. I only tested in text groups, and the
articles came down so fast I didn't notice.
(106078, Lee Reynolds, Torstein Sunde)
2003-02-13 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/articlelist.c (articlelist_key_press): handle HOME/END
buttons to go to the top and bottom of the header pane.
(88869, Martin Schrode)
* pan/articlelist.c (articlelist_read_selected): if more
than one article is selected, also download articles
2..n, because the user is probably going to read them next.
(104155, Nicolas Girard)
2003-02-12 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/article-thread.c (sort_articles): don't alter
the articles' threading information when sorting articles --
this information is critical for decoding multiparts
correctly.
(105611, Jim Faulkner, Adam Huffman, T'aZ, Dwayne Fontenot, Ken Ford)
* pan/sockets.c (pan_socket_new): ignore SIGPIPE.
(105890, Brian Morrison)
* pan/gui-headers.c (add_header_nolock): On very long words
that exceed the maximum width, don't overwrite characters
with linefeeds.
(105879, Jakob Breivik Grimstveit)
2003-02-09 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/base/filter-headers.c:
* pan/base/group.c (group_ref_articles):
* pan/base/group.c (group_add_articles): batch all the
"group changed" events during loading/adding headers
into a single change event.
2003-02-05 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/text.c: fix minor gcc warnings.
* pan/task-save.c: same.
* pan/socket-pool.c: same.
* pan/base/pan-config.c: same.
2003-02-03 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/articlelist.c (articles_removed_mainthread): the previous
way of removing deleted articles from the header pane's list
of articles scaled very poorly to large groups. We keep that
quick-and-dirty method if a few articles are deleted, such
as if the user hit the `delete' key on an article, but use a
better-scaling method if a lot of articles are deleted.
(Mark Kelly)
2003-02-02 Charles Kerr <charles@rebelbase.com>
(Usability)
* pan/prefs.c: by popular demand, split the `single-click selects,
rather than activates' preference option into two, for groups and
headers.
* pan/prefs.c: made some of the terminology more consistent.
* pan/article-filter-ui.c: cleaned out the useless bits.
2003-02-31 Charles Kerr <charles@rebelbase.com>
(Bugfixes)
* pan/sockets.c: better handling of the GIOStatus return values
from the g_io_*() functions. This should fix the SIGPIPE error
reported on pan-users.
2003-01-31 Charles Kerr <charles@rebelbase.com>
(Bugfixes)
* pan/filters/filter-xml.c (populate_phrase): import phrase
filters from <= 0.13.3.90 correctly.
(Lars Bamberger)
* pan/filter-edit-ui.c: fix signed/unsigned conflict in pulling
out the phrase match_type. We were using -type to reflect `negate';
however, enumerated types are unsigned, so this didn't work right.
(Lars Bamberger)
* pan/filters/filter-phrase.c (filter_phrase_to_string): normal
filters were tostring'ed as negated, and negated were tostring'ed
as normal. And I committed this crap? :)
(Lars Bamberger)
2003-01-31 Charles Kerr <charles@rebelbase.com>
* Pan 0.13.3.91 Released!
2003-01-29 Charles Kerr <charles@rebelbase.com>
(Header Matching)
* pan/filters/filter-phrase.c: now works sort of like Evolution.
* pan/filters/filter-xml.c: sync.
* pan/article-toolbar.c: sync.
* tests/test-filter.c: sync.
* pan/filter-ui.c: added more user-visible features to filter-phrase.
(Sorting Articles)
* pan/base/article-thread (sort_articles): rethread the articles'
children based on the same sorting order. That way the order of
replies in the header pane is clearer to follow.
2003-01-28 Christophe Lambin <clambin@easynet.be>
(Bugfixes)
* gmime/gmime-utils.c (rfc2047_encode_phrase_get_words): suppressed
the 'Invalid UTF-8 sequence encountered' error message. These are
triggered by 8bit data in headers.
(#103908, Bas Mevissen)
* pan/socket.s (pan_socket_get_xfer_rate_KBps): fixed crash when
downloading with the task manager open.
* pan/prefs.c (apps_page): mozilla doesn't support openURL(url,raise).
(Owen)
2003-01-27 Charles Kerr <charles@rebelbase.com>
(Bugfixes)
* pan/queue.c (queue_remove_tasks): add a reference to each Task
in the list before adding REMOVE item to the queue's todo list.
* pan/queue.c (queue_real_remove_tasks): when done, unref each
task in the remove list, to balance out the reference added
to queue_remove_tasks(). This ref/unref pair will let us gracefully
handle cases where a task is queued for removal twice.
(Dave Hill)
2003-01-27 Christophe Lambin <clambin@easynet.be>
(Bugfixes)
* pan/message-window.c (message_gen_attribution_string): fixed bug
problem that would corrupt a follow-up if the original article's author
contained 8bit characters, and the attribution line contained '%a'.
(#104479, Jean-Marc Desperrier)
* pan/message-window.c (message_window_save_ok_clicked): fixed crash
in the Composer's 'Save Message' dialog when clicking OK if the
filename was blank.
(Michaela Susan Buesing)
2003-01-27 Daniel Yacob <locales@geez.org>
* configure.in: Added Amharic (am) to ALL_LINGUAS.
2003-01-26 Charles Kerr <charles@rebelbase.com>
(Bugfixes)
* pan/task-manager.c (get_status_str): grok QUEUE_TASK_STATUS_REMOVING.
(Thomas Gamble)
* pan/queue.c (queue_real_set_online): handle the abort flags explicitly
here so that going offline will stop the tasks immediately, and going
online will clear the abort flags.
(Thomas Gamble)
2003-01-23 Charles Kerr <charles@rebelbase.com>
(Bugfixes)
* pan/message-window.c:
* pan/article-actions.c: accidentally mixed strdup() and g_strdup().
* pan/util.c:
* pan/text.c:
* pan/queue.c: ANSI fix: replaced C++-style comments with C comments.
2003-01-23 Charles Kerr <charles@rebelbase.com>
(Added Article.byte_qty. This field is used by task-manager's
new calculate-time-left code, and will be used by the slrn scoring)
* pan/base/article.h: added gulong Article.byte_qty
* pan/base/article.c (article_constructor): zero out byte_count.
* pan/base/file-headers.c: bumped file format to 9, added byte_count
* pan/nntp.c (nntp_download_headers): set byte_count from XOVER.
* pan/base/message-identifier.h: added gulong field byte_qty
* pan/base/message-identifier.c (add_source_from_article): set the
byte_qty field from the Article struct.
* pan/task-manager.c (get_xfer_str): use byte_qty to estimate
how much time is remaining on a running task.
(Cancel Articles)
* pan/task-cancel.[ch]: new code.
* pan/task-func-ptr.[ch]: removed obsolete code.
* pan/article-actions.c: sync with task_cancel code.
(Task State)
* pan/task-state.[ch]: new object. This object is used by tasks
and the queue to negotiate sockets and workprocs for queued tasks.
This allows the queue to allocate all its sockets on a single
task, speeding up the time it takes to download any given multipart.
* pan/queue.c: rewrite to use task-state.c
* pan/task.[ch]: sync with queue and task changes.
* pan/task-save.c: same.
* pan/task-bodies.c: same.
* pan/task-headers.c: same.
* pan/task-grouplist.c: same.
* pan/task-post.c: same.
(Bugfixes)
* pan/nntp.c (nntp_disconnect): don't read the return result from
the QUIT command, since the socket is in an unknown state when
we send the command in the first place.
* pan/nntp.c (nntp_download_headers): fix minor buffer corruption bug
when the references field is extracted from XOVER. Since we previously
were skipping the next field (byte qty), this bug never mattered
before... :)
2003-01-22 Charles Kerr <charles@rebelbase.com>
* pan/sockets.c: fix encoding/buffing glib warning.
* pan/articlelist.c:
* pan/sockets.c:
* pan/status-item-view.c: very minor tweak:
use g_string_truncate (str, 0); instead of g_string_assign (str, "");
* pan/base/file-grouplist.c (save_groups_to_file): remove
erroneous g_return_if_fail() invoked if the number of groups
being saved was zero. The proper behavior is to continue on
into the function, which will remove the now-empty file.
2003-01-21 Christophe Lambin <clambin@easynet.be>
(Usability)
* pan/articlelist.c: added back custom colors for unread & read
threads. Several people have complained that the default colours
are hard to read. Thanks to Robert Boucher for submitting a patch.
* pan/prefs.c: same.
(Bug Fixes)
* pan/socket-pool.c (connect_thread_func): compiler fix.
* pan/message-window.c (create_reply_body): don't remove the signature
unconditionally: when quoting selected text in a reply, we want to
include it. Thanks to Harav Shivanan for fixing his own bug. :)
2003-01-20 Charles Kerr <charles@rebelbase.com>
* pan/socket-pool.[ch]: new module. This lets us create sockets
without blocking the queue, and decouples the socket code from
the queue somewhat. This is also a prerequisite to the
interruptable tasks idea I floated on pan-users last week.
This also has the nice side-effect that tasks don't fail if a
connection can't be made -- they just sit, queued, until a
connection is available.
* pan/queue.c: use the socket pool.
* pan/gui.c: fix broken menu icon for the Log Viewer menubutton.
(#103907, Bas Mevissen)
2003-01-19 Artis Trops <hornet@navigator.lv>
* configure.in: Added Latvian (lv) to ALL_LINGUAS.
2003-01-17 Christophe Lambin <clambin@easynet.be>
(New Features)
* pan/prefs.c: implemented coloring the signature and automatically
updating the text widget's color tags, so the user does not need to
restart Pan to see the new colors. Thanks to Harav Shivanan for
these patches.
* pan/text.c: same.
* pan/message-window.c: Pan now recognizes signature separators
without a trialling space. Thanks to Haran Shivanan for this patch.
(Bug Fixes)
* pan/message-window.c (load_signature): fixed 0.13.3.90 bug that
failed to convert the signature to UTF-8 when it was actually in
US-ASCII. D'oh!
(103779, Brian Morrison)
2003-01-16 Charles Kerr <charles@rebelbase.com>
* pan/pan.c (main): wrapped calls to gtk_main() with
gdk_threads_enter() and gdk_threads_end(), as recommended by
the GTK faq.
* pan/filter-mediator.[ch]: make `show watched' and `show mine'
buttons tweak the FilterShow variable to show matching articles and
replies, since that's usually what's desired.
* pan/gui.c (gui_set_title_idle): small HiG tweak: rearrange the
items in the titlebar so that the group comes first, then
the news server, then Pan's name.
(103563, Mike Hearn)
2003-01-16 Christophe Lambin <clambin@easynet.be>
Pan 0.13.3.90 Released!
2003-01-15 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/filters/filter-xml.c (populate_new,write_new): save and load the
state of the FilterNew class. Without this, filters for read or unread
articles would be saved as filters for new articles.
(103579, Matt Pinkham)
2003-01-11 Charles Kerr <charles@rebelbase.com>
(Windows)
* pan.iss.in: updated to sync with gtk2.2 build
* README.windows: updated for beta2
* pan/base/util-file.c (pan_mkdir): silently skip mkdir("c:\")
2003-01-10 Charles Kerr <charles@rebelbase.com>
(Usability)
* pan/dialogs/dialog-newuser.c: refreshed the whole new user dialog,
getting it more in spec with the Gnome HIG and getting rid of some
of the more idiotic text. Also, added the ability for new users
to specify their signature files there ... I've seen a surprising
number of people asking `how do I specify a signature file with Pan?'
on Usenet...
2003-01-09 Christophe Lambin <clambin@easynet.be>
(Bug Fixes / Tweaks)
* gmime/gmime-filter-html.c: recognize commas inside URLs.
(102881, holger)
* pan/message-window.c (load_signature): don't use a signature when
we can't convert it to UTF-8 (i.e when it's not in the locale's
charset) and warn the user as to what happened to his signature.
(102158, Ville Skyttä)
2003-01-09 Charles Kerr <charles@rebelbase.com>
(Netiquite)
* pan/base/message-check.c (check_topposting): new function to check
to see if a follow-up post is top-posting.
* tests/test-message-check.c: added two regression tests for
top-posting.
* pan/base/message-check.c (strip_attribution_and_signature): new
private utility function shared by check_topposting() and
check_all_quoted().
(#100747, Pan Team)
2003-01-07 Charles Kerr <charles@rebelbase.com>
(Usability)
* pan/articlelist.c (articlelist_get_active_articles_nolock): new
function like articlelist_get_selected_articles_nolock(), but adds
any collapsed subthreads of those selected articles. This is for
the Agent-like behavior of, when you click `delete' on an article
with a collapsed subthread, the entire subthread is deleted instead
of just the one article. This is used for delete, mark read/unread,
flag/unflag for doewnload, copy to folder, "download selected".
(102577, Jerry Segers)
* pan/articlelist.c (remove_article_nolock): make sure children of
deleted articles are reinserted to their grandparent in the correct
order.
(102586, Jerry Segers)
2003-01-06 Charles Kerr <charles@rebelbase.com>
(Fixes)
* pan/Makefile.am: include $(GNET_CFLAGS).
* pan/dialogs/Makefile.am: same.
(#102755, Nam SungHyun)
* pan/base/util-file.c (pan_mkdir): silence minor compiler warning.
(Usability)
* pan/save-ui.c: when the user hits `enter' inside the directory
entry field, the save dialog now behaves as if the OK button were pressed.
(102208, Bobby D. Bryant)
2003-01-06 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/gui.c (log_entry_added_cb): Fixed bug that kept 'urgent' events
from creating a popup dialog (e.g. rules with an alert configured).
(Michael Waters)
2003-01-06 Charles Kerr <charles@rebelbase.com>
(Windows)
* pan/pan.iss.in: added README.windows to show up in the installer
* pan/README.in: new template to generate README without having to
edit the version number before rolling the tarball.
* pan/README.windows.in: new template to generate README.windows
without having to edit the version number before rolling setup.exe.
2003-01-05 Charles Kerr <charles@rebelbase.com>
(Windows)
* pan/configure.in: added pan.iss to AC_CONFIG_FILES
* pan/pan.iss.in: New file: template for Pan's Windows install script
* pan/pan.spec.in: Added gnet-1.1.5 and gnet-devel-1.1.5
2003-01-04 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/article-actions.c (article_supersede): fixed domain-mangling bug.
(102469, Adam Warner)
2003-01-01 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/pan-color-picker.c (picker_clicked_cb): the color picker didn't
display the currently active color.
2002-12-30 Charles Kerr <charles@rebelbase.com>
More portability changes.
* pan/sockets.h: made PanSocket an opaque data type.
* pan/smtp.c: sync.
* pan/queue.c: sync.
2002-12-30 Charles Kerr <charles@rebelbase.com>
(Use GNet and GLib for socket I/O)
* pan/smtp.c: use GNet instead of Unix-only socket APIs.
* pan/sockets.c: same.
* pan/dialog/dialog-newuser.c: same.
* pan/configure.in: require GNet 1.1.7 or higher.
* pan/pan.spec.in: same.
(Portability Tweaks)
* pan/prefs.c (prefs_init): windows path portability fixes.
* pan/prefs.c (tasks_page): same.
* pan/message-window.c (append_signature): same.
* pan/base/base-prefs.c (get_data_dir): same.
* pan/base/util-file.c (pan_mkdir): new function that
#ifdefs out mkdir's second argument on windows.
* pan/acache.c: add "b" to mode arg for fopen calls.
* pan/base/decode.c: same.
* pan/base/util-file.c (pan_file_copy): same.
* pan/queue.c (queue_get_tasks_filename): portability tweaks.
* pan/thread-watch.c (get_filename): same.
* pan/base/pan-config.c (pan_config_load_ini): same.
2002-12-30 Charles Kerr <charles@rebelbase.com>
Pan 0.13.3 Released!
2002-12-27 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/task-manager.c (periodic_update_timer): only update
those rows whose tasks are running or have changed.
Updating every row caused the CPU to spike when many
tasks were queued.
2002-12-26 Charles Kerr <charles@rebelbase.com>
(MingW portability changes)
* pan/gmime: change all instances of ssize_t to gssize
* pan/task-post.c: same.
* pan/base/util-mime.c: same.
* configure.in: add check to see how many arguments mkdir takes.
* pan/base/util-file.c: added pan_mkdir(), which #ifdefs to handle
platforms where mkdir takes only one argument.
2002-12-23 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/base/group.c (group_add_articles_impl): fixed bug that caused
all read headers to removed from the group when loading.
2002-12-20 Charles Kerr <charles@rebelbase.com>
(Intel compiler tweaks)
* pan/article-toolbar.c (_filter_phrase_om): remove unused field.
* pan/prefs.c (attribution_line): same.
* pan/prefs.c (use_system_bg): same.
* pan/prefs.c (use_system_fg): same.
* pan/text.c (text_vbox): same.
* pan/articlelist.c (refresh_mainthread_end): remove unused variables.
* pan/base/gnksa.c (remove_broken_message_ids_from_references): same.
* pan/base/util-mime.c (separate_encoded_parts): same.
* pan/base/group.c (group_add_articles_impl): same.
* pan/message-window.c (text_inserted_cb): same.
* pan/sockets.c (read_from_socket): same.
* pan/gui.c (update_menus_idle): same.
* pan/gui.c (gui_set_queue_size): make this a static function.
* pan/base/util-mime.c (pan_fake_partial): same.
* pan/base/article.c (xref_foreach): same.
* pan/task-xml.c (write_task): same.
* pan/gui.c (create_image): same.
* pan/gui-headers.c (max_header_width): make this a static field.
* pan/pan-charset-picker.c (charset): same.
* pan/gui-notebook.c (notebook): same.
* pan/articlelist.c (_icons): same.
* pan/gui.c (_status_icons): same.
* pan/status-item-view.c (set_percentage_mainthread): type conversion.
* pan/articlelist.c (articlelist_set_selected_nodes_nolock): same.
* pan/grouplist.c (grouplist_set_selected_groups_nolock): same.
* pan/articlelist.c (articlelist_set_node_style_nolock): same.
2002-12-17 Christophe Lambin <clambin@easynet.be>
Pan 0.13.2.93 Released!
2002-12-16 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/task-manager.c (tasks_moved_cb): add unref the TreeModel's
task for that row before deleting the row. This was a small leak.
* pan/task-manager.c (ui_destroy_cb): call gtk_tree_model_foreach
to unref each of the tasks in the task manager. This caused a minor
leak in 0.13.1 (memory), and a HUGE leak in 0.13.2.92 (task-save
objects were never destroyed, so the cache directory overflowed).
2002-12-15 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/task-save.c (task_save_run): fixed another bug that caused
failed tasks to be removed from the Task Manager, even if the user
has disabled this in the preferences.
(Huub Reuver)
2002-12-14 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/base/acache.c (get_message_id_from_file): huge speedups.
The Message-ID is now passed through a transform to make it
safe for various filesystems, so we can reverse the transform
to derive the Message-ID from the filename without having to
open the file and parse the headers.
* pan/server-edit-ui.c (server_edit_response_cb): call
queue_wakeup() if the user hits `ok'. This is so that if the user
changed the maximum number of connections for the server, the change
will take place immediately.
(101242, Pan Team)
* pan/server-edit-ui.c: fix bug that crashed Pan if you hit
`close' in the server list dialog when an edit dialog was still
open: destroying the edit dialog tried to refresh the list dialog,
which was already destroyed.
(101247, Pan Team)
2002-12-14 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* gmime/gmime-utils.c (datetok): sync w/ GMime CVS. This fixes an
incorrect parsing of timestamps with negative timezone offsets.
As a result, articles with such timestamps contained incorrect
dates in the thread pane.
(97710, wsr23)
2002-12-13 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/message-window.c (make_reply_window): removed unneeded internal
header, which caused corruption to boot.
(101074, Pan Team)
(Tweak)
* pan/message-window.c (determine_charset_for_message): fall back to
the group's charset if the original article contains a unsupported
charset (previously it would fall back to the locale's charset).
* pan/message-window.c (check_charset_for_body): moved & fixed the
broken charset validation from message-check.c.
(101043, Pan Team)
2002-12-12 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/util-wrap.c (pan_text_rot13_inplace): fix stupidity
that I introduced yesterday.
As an aside, http://czyborra.com/utf/#UTF-8 is a nice utf8 primer...
2002-12-12 Christophe Lambin <clambin@easynet.be>
(Charset Fun)
* pan/message-window.c (determine_charset_for_message): implemented
checking the article's charset before falling back to the group's
charset. Follow-ups to message with charsets different from the group
should not have their charset set up correctly.
* pan/pan-charset-picker.c (pan_charset_picker_new): since we may
now pass the article's charset to the picker, make sure to cope
with charsets that don't match any of our charsets.
2002-12-12 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/util-wrap.c (pan_text_rot13_inplace): ensure that
the function doesn't choke on UTF-8 text.
(101045, Pan Team)
* pan/text.c: replace #warning with /* FIXME */ for portability.
* pan/message-window.c: same.
* pan/base/message-check.c: same.
* pan/filters/filter-save.c: same.
(100538, Brandon Corey)
* pan/gui.c: replace C++ comments with C comments for portability.
* pan/text.c: same.
* pan/base/util-mime.c: same.
(New Features)
* pan/prefs.c (task_page): added in a togglebutton to tell Pan
whether to start in online or offline mode.
* pan/prefs.c (prefs_apply): sync.
* pan/queue.c (queue_init): added new argument, gboolean "online"
* pan/pan.c (main): sync.
(101013, Maurizio)
2002-12-12 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/acache.c (get_message_id_from_file): handle folded
Message-ID headers more gracefully. The parsing isn't the
smartest in the world, but it for this, it doesn't need to be.
2002-12-11 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/identities/identity-xml.c (identity_xml_read): fixed bug that
caused the default profile for News to be cleared.
(100904, James Brost)
2002-12-10 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/base/acache.c (get_message_id_from_file): fixed crash when
the cache contains articles with wrapped Message ID's. This needs
a better fix (like supporting wrapped Message ID's), but I don't have
time right now.
2002-12-10 Charles Kerr <charles@rebelbase.com>
Pan 0.13.2.92 Released!
2002-12-10 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/decode.c: remove the acache_checkin call;
move it to task_save_destructor() instead.
This ensures that the task_save_constructor() checkout
is always balanced, even if the task-save is not decoding
attachments.
(100870, Pan Team)
* pan/base/acache.[ch]: require a key argument to tell acache
which path you want to look for / get / check out / check in
messages. This solves a slew of bugs, such as--
-- one's own posts not being marked as read.
(90083, Bas Mevissen)
(90112, Brian Morrison)
(91341, Lars Bamberger)
(93780, Uwe Naumann)
-- following-up your own post had a broken References: header.
(89435, Pan Team)
-- it appeared that the "X-Pan-Internal" headers in your
own posts had been sent to Usenet.
(89435, Bobby Bryant, Gollum)
2002-12-09 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/pan-file-entry.c (entry_clicked_cb): remember to set the
transient parent for the file picker, and to set
gtk_window_set_destroy_with_parent(), so that the entry dialog
doesn't stay alive longer than its parent.
* pan/pan-font-picker.c (picker_clicked_cb): same.
* pan/pan-color-picker.c (picker_clicked_cb): same.
(100605, Bo Flynn)
* gmime/gmime-stream.c: SGI portability fixes.
* gmime/memchunk.c: same.
* pan/article-toolbar.c: same.
(100538, Brandon Corey)
* pan/prefs.c (prefs_init): if all of the show_pane variables
are turned off, then turn them all on. It's very confusing for Pan
to start up with an empty window. :)
* pan/gui.c (update_menus_idle): grey out the third `show pane'
button, so that users can't turn off all of the panes at once.
(99716, Pan Team)
2002-12-08 Charles Kerr <charles@rebelbase.com>
(#100695 - Making tasks more self-descriptive)
* pan/base/message-identifier.[ch]: added a field for a
`readable name', such as the message's subject header.
This is set automatically in mid_new_from_article().
* pan/task-save.c: use the MessageIdentifier's readable name.
* pan/task-bodies.c: same.
* pan/nntp.c: same.
* pan/task-save.c: remove the `readable_name' field
in the TaskSave struct, since the MessageIdentifier now
holds this information.
* pan/article-actions.c: sync with task-save API changes.
* pan/save-ui.c: same.
* pan/task-xml.c: sync with TaskSave, MessageIdentifier changes.
2002-12-08 Jeffrey Stedfast <fejj@ximian.com>
(Backport of the fix for bug #91536 from GMime trunk)
* gmime/gmime-object.c (g_mime_object_register_type): Use a struct
to hold the object_type for the subtype hash. 64 archs use 32bit
ints and so using GINT_TO_POINTER() and GPOINTER_TO_INT() doesn't
work.
(g_mime_object_new_type): Get the object_type from the subtype
bucket.
2002-12-07 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/nntp.c (nntp_download_bodies): fixed bug that caused failed
tasks to be removed from the Task Manager, even if the user has
disabled this in the preferences.
(Bobby D. Bryant)
2002-12-07 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/util-file.c (pan_file_ensure_path_exists): added a mutex
to ensure that two tasks didn't try to create the same directory at
the same time, causing one to fail with `cannot create: file exists'.
(100611)
2002-12-05 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/smtp.c (smtp_send_message): fixed crash when forwarding/replying
via email in Japanese locale. This was related to glibc's
implementation of printf ("%.*s") in certain locales.
(99873, petersen)
* pan/base/serverlist.c (serverlist_save): worked around same printf
behaviour.
* pan/base/util-wrap.c (fill_paragraph): same.
2002-12-04 Charles Kerr <charles@rebelbase.com>
Pan 0.13.2.91 Released!
2002-12-04 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/articlelist.c (style_set_cb): new callback that's
run whenever the header pane's style changes. This
syncs the header pane's colors up with new gtk2 themes.
(97882, Marin Tomasek)
* pan/gui.c (create_toolbar): added support to turn off
the toolbar, or the labels in the toolbar, by editing
pan.config and setting the keys
"/Pan/Display/toolbar_labels_visible" and
"/Pan/Display/toolbar_visible".
I'll add these to the preferences dialog if enough people
request it.
(87553, Kang Jeong-Hee)
2002-12-03 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/util-mime.c (separate_encoded_parts):
Fixed bug that tricked Pan into thinking a text message was a
uuencoded message by starting the message with a uu begin line.
(67554, Marcin Wojtczuk)
* pan/articlelist.c (articlelist_set_sort_bits_nolock):
Fixed minor display bug in the header pane which sometimes
hid the sorting '+' or '-' in the column header.
(90378, Wendell Dingus)
* pan/base/gnksa.c (gnksa_trim_references):
Fixed bug which caused follow-ups in some very long threads to fail.
(99485, Marc Geerlings)
* pan/base/article-thread.c (normalize_subject):
Changed the way Subject sorting is done to better group similar
posts in binaries groups.
(94863, Chris Petersen)
* pan/task-post.c (task_post_run):
Changed bug that caused article bodies to not be saved if the user
checked both `save attachments' and `save body' for an article
that had no attachments.
(99218, Sid Cowles)
2002-12-02 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
Changed the filenames of duplicate saved attachments so that
they're easier to grep for.
(97778, Jerry Segers)
2002-12-02 Charles Kerr <charles@rebelbase.com>
(fnmatch -> GPatternSpec migration)
* pan/base/fnmatch.[ch]: drop fnmatch(). GPatternSpecs are
a little faster than this fnmatch code, plus we get to drop
300+ lines of code from pan/base/. :)
* pan/grouplist.c: sync.
* pan/article-find.c: sync.
GPatternSpec is faster, which is good, but we have to do our
case-insensitivity by hand, which is bad, so maybe the only
real change here is better utf8 friendliness in case-insensitivity.
* pan/filters/filter-phrase.c: sync.
(speed tweaks)
* pan/messageidset.c: since thousands of articles could get added
when a group's articles are marked as `old', use a hash table
internally instead of a sorted string array.
* pan/filter-mediator.c (show_toggled_cb): stop if the button isn't set.
This callback is called by FilterShow's radio menu buttons twice per
change: once by the newly set button, once by the old, unset button.
We only need to refresh the filters once.
* pan/base/article.c (articles_set_new_impl): since we know the size,
use g_ptr_array_sized_new() instead of g_ptr_array_new().
2002-11-26 Charles Kerr <charles@rebelbase.com>
(More grouplist tweaks; it hasn't been combed over in awhile)
* pan/grouplist.c: grouped more related functions; labelled sections.
* pan/grouplist.c: removed unnecessary `grouplist_server_set_callback'.
* pan/grouplist.c (grouplist_add_group_nolock): pass the GtkCList* in
as a function argument instead of downcasting a GtkWidget four times
per call.
* pan/grouplist.c (grouplist_server_activated_cb): move this to an
idle func so that we can make sure we always rebuild the clist in the
main gui thread.
* pan/grouplist.c (grouplist_refresh_filter_nolock): always wrap the
phrase with implicit wildcards.
(91119, Michael Toomim)
(Other Tweaks)
* pan/filters/filter-phrase.c (filter_phrase_test_articles): always wrap
the phrase with implicit wildcards.
(91119, Michael Toomim)
2002-11-25 Charles Kerr <charles@rebelbase.com>
(Fix gcc 3.2 Warnings)
* pan/message-window.c (text_inserted_cb): fix some
variable-possibly-uninitialized conditions found by gcc 3.2.
* pan/message-window.c (run_external_editor): same.
* pan/prefs.c (layout_get_new_string): same.
* pan/server-menu-ui.c (server_menu_update): same.
* pan/base/acache.c (acache_init): same.
* pan/base/decode.c (decode_article): same.
* pan/filters/filter-new.c (filter_new_to_string): same.
(Cleanup #includes)
* pan/dialogs/dialog-group-props.c: remove unnecessary #includes
* pan/dialogs/dialog-headers.c: same.
* pan/dialogs/dialog-log-viewer.c: same.
* pan/dialogs/dialog-newuser.c: same.
* pan/identities/identity-manager.c: add #include <config.h>
* pan/identities/identity-xml.c: same.
* pan/identities/identity.c: same.
* pan/identities/identity-edit-ui.h: fix broken #include.
2002-11-25 Charles Kerr <charles@rebelbase.com>
(Modularity)
* pan/queue.c: decoupled from the gui.c status functions by adding
PanCallback functions that fire notifications whenever the queue
size or connecting state changes.
* pan/gui.c: register for the queue's callbacks, so that the
status bar can be updated when the queue changes.
* pan/queue.c: removed dependency from `remove_failed_tasks' globals:
this is now passed in via queue_init() and
queue_set_remove_failed_tasks().
* pan/pan.c: sync call to queue_init().
* pan/prefs.[ch]: remove `remove_failed_tasks' global.
2002-11-23 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/prefs.c: added the `single click selects, rather than activates'
option back in by popular demand.
* pan/articlelist.c: same.
* pan/grouplist.c: same.
2002-11-20 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/pan.c (restore_tasks_dialog): fix race condition that could
cause Pan to crash on startup when the ``restore tasks'' dialog popped up.
(99095)
* pan/flagset.c: fixed memory leak when clearing flag list. (Valgrind)
(Tweaks)
* pan/flagset.c: remove the flagged/unflagged callback,
since articlelist's dirty-messages messageidset can handle
the refresh with a lot less work.
* pan/base/pan-callback.h: Remove an unnecessary level of
indirection from PanCallback's opaque data type.
* pan/gui.c: clean up the log message callback handlers.
* pan/gui.c: use g_alloca instead of g_malloc when appropriate.
* pan/task-manager.c: same.
* pan/base/util-mime.c: same.
* pan/util.c (pan_info_dialog): make gui-threadsafe.
* pan/util.c (pan_error_dialog): same.
* pan/util.c (pan_error_dialog_parented): same.
* pan/grouplist.c: removed some cruft from remove & refresh routines.
2002-11-19 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/util.c (pan_hig_frame_new): fix minor memory leak. (Valgrind)
* pan/task-save.c (get_unique_fname): same.
* pan/articlelist.c (articlelist_reset_style_nolock): same.
* pan/dialogs/dialog-group-props.c (group_properties_response_cb): same.
* pan/articlelist.c (articlelist_button_press): fix minor type error.
* pan/util.c (pan_gtk_entry_set_text): fix minor gtk warning.
(I18N Improvements)
* pan/message-window.c: remove i18n strings by reusing similar strings.
* pan/gui-headers.c: same.
* pan/thread-watch.c: same.
* pan/task-grouplist.c: same.
* pan/base/file-headers.c: same.
* pan/base/util-file.c: same.
* pan/base/decode.c: same.
* pan/base/newsrc-port.c: same.
* pan/dialogs/dialog-newuser.c: same.
* pan/identities/identity-edit-ui.c: same.
(Tweaks)
* pan/grouplist.c (group_popup_entries): reordered the popup menu
items so that the delete-all and mark-all-read buttons are at the
bottom next to `delete group', less likely to get clicked by accident.
(93713, Gollum)
* pan/base/pan-glib-extentions.c (pan_g_ptr_array_has_sorted): new func.
* pan/messageidset.c: reimplement with a sorted ptr array set rather
than the more heavyweight hashtable.
* pan/base/acache.[ch]: changed the semantics of the cached/uncached
callbacks to allow multiple message-ids to be batched into a single
callback.
* pan/articlelist.c: reuse `refresh_articles_from_message_id_array_cb'
for acache callback handling; remove the old acache callback handler.
* pan/base/pan-glib-extensions.c (pan_utfize): add GError logging.
2002-11-18 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/text.c (text_read_more_impl): if there is more of the current
article to read, then the space key should scroll to the next page,
even if the header or group pane's selection has changed. Jump to
the new selection only after we've reached the bottom of the current
article.
(91365, Arcterex)
* pan/articlelist.c (articlelist_selection_changed_cb):
Hmm, today's tweaks overlooked the idea that it's _good_ to have the
last article body hang around a bit in the text pane until the next
article's done downloading. That way you can look at the last picture,
rather than a blank window, until the next one's been downloaded.
2002-11-18 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/server-menu-ui.c (server_activated_cb): fix small memory leak.
(Valgrind)
* pan/status-item-view.c: added a mutex for accessing the last_status
string. This was being read in one thread and changed in another.
(Valgrind)
2002-11-18 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/articlelist.c (articlelist_selection_changed_cb): modify
the selection behavior a little bit when deciding whether or
not to activate an article on selection. There are fewer states
to track in the new code and IMO it's more pleasant to use.
* pan/text.c (text_set_from_identifiers): if 0 identifiers are
passesd in, then clear the display.
* pan/articlelist.c (articlelist_selection_changed_cb): modify
the selection behavior somewhat to clear the text pane when
the selected article hasn't been activated.
(89959, Bas Mevissen)
2002-11-18 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/nntp.c (nntp_article_download): set the `STATE_ERROR' flag
on articles which can't be downloaded. This added the red x
back into the header pane when trying to read expired articles.
(93169, Leonard Nutley)
2002-11-18 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/article-actions.c (article_supersede): Fixed domain-mangling bug
that broke the Supersede function.
(Chill)
* pan/text.c (text_read_more_impl): Fixed bug that broke space reading
when the subject contained 8bit data.
(89281, Christian Lohmaier)
2002-11-18 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/article-thread.c (thread_articles): Fixed a bug in
determining the multipart state of articles (SOME, ALL, NONE).
The loop zeroed out the states of some children after they'd
already been calculated earlier in the loop.
(93894, Gollum)
* pan/dialogs/dialog-newuser.c (dialog_newuser): fixed format error
in the "Thank you for trying Pan!" welcome message. :)
2002-11-16 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/article-filter-ui.c (article_filter_dialog_new): don't convert
author & subject to UTF-8, since they're already in UTF-8. This broke
bozo & spam filters on 8bit data.
(Tweaks)
* pan/dialogs/dialog-newuser.c (dialog_newuser): changed the welcome
string to be more i18n-friendly.
(98334, Christian Rose)
* pan/message-window.c (append_signature): if the signature file is
not an absolute path, assume it's in the user's home directory.
2002-11-14 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-content-type.c
(g_mime_content_type_new_from_string): #include
"gmime-table-private.h" and use is_ttoken() to correctly parse
type/subtype. Fixes bug #98463.
2002-11-14 Charles Kerr <charles@rebelbase.com>
* pan/text.c: instead of looking for text/plain and text/html,
just match on text/* and treat it as plaintext. This should
handle more gracefully messages whose text subtype is corrupt.
(98463, Martin Schrode)
* pan/messageidset.c: for most uses there are only a few message-ids
in the set, so g_strdup/g_free has less overhead than a GStringChunk.
* pan/articlelist.c: tidy up & comment the node refresh changes.
2002-11-14 Charles Kerr <charles@rebelbase.com>
(Speedups)
* pan/articlelist.c: throw away about 400 of the most tricky and
complex lines of code in favor of the periodic timer function
"refesh_dirty_messages". This is called a few times per second
to refresh in the header pane any changed articles.
These changes are batched up due to the high overhead involved in
refreshing the GUI for each individual article state change.
* pan/messageidset.c: new helper class for articlelist.c.
2002-11-13 Charles Kerr <charles@rebelbase.com>
(Bug Fix)
* pan/nntp.c (nntp_download_headers): strip the subject, author,
date, message-id, and references headers before using them.
This fixes a wart when a message-id came in with a leading or
trailing space -- GMime strips them, so the Article* and
GMimeMessage message-ids differed, which broke a few things
including space reading. (#98424)
(Speed Tweaks)
* pan/articlelist.c: add _article_ctree and _article_clist to avoid
excessive downcasting of Pan.article_ctree.
* pan/articlelist.c (articlelist_get_next_article_not_in_list):
since the article array we're being passed in is sorted by message-id,
we can bsearch that array instead of creating a local lookup table.
* pan/articlelist.c (find_prev_article): only look up the `top' node
if we actually need it.
2002-11-11 Christophe Lambin <clambin@easynet.be>
* pan/gui.c (gui_construct/gui_shutdown): Pan now retains custom
accelerator keys (shortcuts) between sessions.
(Duncan)
* pan/dialogs/dialog-newuser.c (dialog_newuser): fixed obsolete link.
(Tom F)
2002-11-07 Christophe Lambin <clambin@easynet.be>
Pan 0.13.2 Released!
2002-11-05 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c: sync w/ pan-0-13-fix (97772)
2002-11-04 Charles Kerr <charles@rebelbase.com>
* pan/task-manager.c: Sync with 0-13-fix task manager bugfixes.
(97527, Don Horsman)
* pan/filter-mediator.c (rebuild_custom_filter_menu_with_filters):
Properly handle custom filters whose names include underscores.
(#97602, Carl Soderstrom)
2002-11-02 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c (articlelist_expand_selected_threads):
add freeze/thaw calls to make expanding selected threads
less slow. Fixes (#97536).
* pan/text.c: add some comments; rearrange some code blocks
for readability. Add call to gui_page_set _before_ rebuilding
the textbuffer's contents to fix #97535.
2002-10-27 Christophe Lambin <clambin@easynet.be>
* pan/prefs.c: sync w/ pan-0-13-fix (95343)
2002-10-25 Charles Kerr <charles@rebelbase.com>
* pan/base/pan-config.c: write bools out as "true" or "false"
rather than 1's and 0's.
* pan/base/pan-config.c: write ulongs out as unsigned longs.
2002-10-21 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-stream-filter.c: Backported a 64bit cleanliness
patch from GMime HEAD.
2002-10-21 Christophe Lambin <clambin@easynet.be>
* pan/articlelist.: sync w/ pan-0-13-fix (96258)
2002-10-17 Christophe Lambin <clambin@easynet.be>
* pan/text.c: sync w/ pan-0-13-fix (cursor key scrolling)
2002-10-16 Charles Kerr <charles@rebelbase.com>
* pan/text.c: sync w/ pan-0-13-fix (95893)
* gmime/gmime-filter-html.[ch]: same.
* pan.desktop.in: sync w/ pan-0-13-fix (95934)
2002-10-15 Christophe Lambin <clambin@easynet.be>
* pan/save-ui.c: sync w/ pan-0-13-fix (94540)
* pan/message-window.c: sync w/ pan-0-13-fix (95478)
2002-10-14 Charles Kerr <charles@rebelbase.com>
g_type casting seems to have more overhead than in
gtk 1.2, so articlelist now holds GtkCTree* and GtkCList*
pointers to the tree widget to avoid unnecessary casting.
2002-10-13 Christophe Lambin <clambin@easynet.be>
Pan 0.13.1 Released!
2002-10-08 Christophe Lambin <clambin@easynet.be>
* pan/base/gnksa.c (tzoffset_sec): fixed incorrect timezone for
New Zealand Daylight Time. (95159, Adam Warner)
2002-10-06 Christophe Lambin <clambin@easynet.be>
* pan/util.c (pan_gtk_entry_set_text): use pan_header_to_utf8() to
convert to UTF-8, so that quote-encoded headers are properly displayed
and posted in follow-ups.
2002-10-06 Christophe Lambin <clambin@easynet.be>
Pan 0.13.0.92 Released!
2002-10-04 Jacob Ilsø Christensen <firelake@stofanet.dk>
* pan/task-manager.c: restored column width restore/save
* pan/gui.c (gui_save_column_widths_tree_view): new function
that saves column widths for GtkTreeViews
(gui_restore_column_widths_tree_view): new function that
restores column widths for GtkTreeViews
* pan/gui.h: Added gui_restore_column_widths_tree_view and
gui_save_column_widths_tree_view
2002-10-03 Christophe Lambin <clambin@easynet.be>
* pan/task-manager.c (task_manager_build_ui): merged back the changes
for #79270, after Jacob accidently removed them. Welcome to the team,
Jacob. :)
2002-10-03 Jacob Ilsø Christensen <firelake@stofanet.dk>
* pan/task-manager.c: converted the task-manager to use GtkTreeView.
This also fixes (85442, Gabi Davar) and (80276, bloch@verdurin.com)
* pan/queue.c (real_queue_move_tasks): fixes problem occuring when
moving all tasks.
2002-10-02 Christophe Lambin <clambin@easynet.be>
* pan/prefs.c (cache_page): increased maximum cache size to 20GB.
(94684, Duncan)
2002-09-29 Christophe Lambin <clambin@easynet.be>
* pan/articlelist.c (set_group_worker): prevent multiple groups from
loading at the same time. This fixes at least one crash due to race
conditions in article-toolbar.c
2002-09-28 Christophe Lambin <clambin@easynet.be>
* pan/base/gnksa.c (gnksa_check_address): fixed bug which would convert
email addresses for all incoming headers to lower case. As a result,
filters on email addresses would not work as expected.
2002-09-27 Christophe Lambin <clambin@easynet.be>
* pan/base/acache.c (acache_init): create the internal server (folders)
before starting the cache indexing thread. This fixes a race condition
between that thread and update_menu_idle(), which produced a burst of
'server_is_valid' assertion failures on startup.
2002-09-27 Charles Kerr <charles@rebelbase.com>
* pan/text.c (set_text_from_message_nolock): Pan now
tries to show headers `as-is' when `show all headers'
is toggled on. (91532, Christian Lohmaier)
* pan/gui.c: change the latency time between gui
refreshes from 220 msec to 100 msec.
* pan/task-manager.c: In the toolbar, move the
button text to tooltips. In some locales the text
made the task manager too wide for small screens.
(79270, Kang Jeong-Hee)
* pan/gui.c (gui_add_network_button_to_toolbar):
Determine the icon size from the toolbar's size prefs.
Previously we used ICON_SIZE_TOOLBAR_SMALL,
which was wrong for the task manager's toolbar.
* pan/pan/xpm (icon_online.png, icon_offline.png):
tweaks to make them look a little better when stretched
in the task manager and main window's toolbars.
2002-09-26 Jacob Ilsø Christensen <firelake@stofanet.dk>
* pan/server-ui.c: added column sorting.
Only respond to double-clicks when clicking on a row.
2002-09-23 Charles Kerr <charles@rebelbase.com>
* pan/base/util-file.h: clean up API and documentation.
* pan/base/util-wrap.h: clean up API and documentation.
* pan/filter-mediator.c: added custom filters back into
the gui -- in the Filter menu -- so that they can be
applied to the header pane.
* pan/gui.c: moved the `select servers' to the main Server
menu, rather than a cascading menu.
2002-09-21 Christophe Lambin <clambin@easynet.be>
Pan 0.13.0.91 Released!
2002-09-20 Charles Kerr <charles@rebelbase.com>
* pan/base/decode.c: more GMime refcount fixes.
Thanks to James Hawtin for reporting these.
* pan/text.c: more GMime refcount fixes.
* pan/message-window.c: more GMime refcount fixes.
2002-09-19 Charles Kerr <charles@rebelbase.com>
* pan/server-ui.c: Applied patch from Jacob Ilsø Christensen
which replaces the GtkCList with a GtkTreeView.
* pan/base/util-mime.c: fix major refcount bugs of GMime objects.
This caused both memory and file dscriptors to be leaked.
(91916, John Portnoy)
(93538, oolon)
2002-09-18 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: add support, turned on by default, to not use
custom fonts for the group/header/article panes.
* pan/grouplist.c: sync.
* pan/articlelist.c: sync.
* pan/text.c: sync.
2002-09-17 Charles Kerr <charles@rebelbase.com>
* pan/queue.c: fix minor g_warning() that was tickled by going offline.
2002-09-17 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c: wrap the attribution line if required.
Thanks to Steve Fox for suggesting this. (#89539)
* pan/articlelist.c: fixed problem where ctrl-end would retrieve
the last message in the articlelist. Thanks to Jacob Ilsø Christensen
for reporting this and sending in a patch.
2002-09-17 Charles Kerr <charles@rebelbase.com>
* pan/server-menu-ui.c: key the menu selection off of menu name,
rather than index in the Server array. This fixes a 0.13.0 server
selection bug.
(Johann Glaser, 92645)
(Alen Williams, 91348)
(Stephen Beahm, 91212)
* applied patch from Panagiotis Issaris that sets the policies
of all scrollbars to automatic.
2002-09-17 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-charset.c (g_mime_charset_name): Sync with cvs
GMime. Fixes bug #92646.
2002-09-16 Christophe Lambin <clambin@easynet.be>
* pan/group-action.c: fixed crash when a user would try to get new
headers in a folder. Thanks to Gollum for reporting this. (#93449)
2002-09-15 Christophe Lambin <clambin@easynet.be>
Pan 0.13.0.90 Released!
2002-09-14 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: patch from Jacob Ilsø Christensen to disable the
"smooth scrolling" spinbutton if the user has unset the
smooth scrolling checkbox.
* pan/articlelist.c: added code for flagging articles more like Agent:
if the selected article is closed, then the flag/unflag operation
recurses down to the hidden child articles.
Thanks to o.t for suggesting this. (#90388)
* pan/base/util-mime.c (pan_g_mime_message_get_group): try harder
to extract a valid group from the Newsgroups: header. This should
help the `default_charset' variable get found correctly even for
crossposts.
* pan/prefs.c: fixed a small leak. Thanks Valgrind.
* pan/base/server.c: ditto.
2002-09-13 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: implemented the reverse-read-more function (read less? :)
Thanks to o.t for suggesting this. (#90087)
* pan/text.c: sync.
* pan/prefs.c: minor layout tweak.
* pan/base/serverlist.c: fix compiler warning I introduced earlier.
* pan/base/serverlist.h: remove dup #define of INTERNAL_SERVER_NAME
2002-09-13 Christophe Lambin <clambin@easynet.be>
* pan/gui.c: fixed 'Newsgroups / Get New Headers and Bodies'.
Thanks to Devilkin for reporting this. (#92833)
2002-09-13 Charles Kerr <charles@rebelbase.com>
* pan/base/serverlist.c: when a server is activated for the first
time, import its .newsrc if newsrc files are turned on.
* pan/base/server.c (server_destructor): if .newsrc files are
turned on for this server, export the grouplist there.
2002-09-12 Christophe Lambin <clambin@easynet.be>
* pan/gui.c: Pan now remembers its window position. Thanks to
Marc Deslauriers for suggesting this and sending in a patch. (#88260)
* pan/save-ui.c: don't save the attachment when the user presses
the escape key. Thanks to Nicolas Girard for reporting fix. (#93092)
2002-09-12 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: Hack on prefs dialog a bit in a misguided
attempt to make all the mnemonics unique
2002-09-10 Charles Kerr <charles@rebelbase.com>
* pan/article-find.c: Add hig spacing, alignment, mnemonics
* pan/dialogs/dialog-headers.c: same.
* pan/dialogs/dialog-group-props.c: same.
* pan/prefs.c: The draft prefs dialog is done & ready for feedback
2002-09-10 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c: add the encoding to the GMimeMessage.
Thanks to Christian Lohmaier for reporting this. (#90760)
2002-09-09 Christophe Lambin <clambin@easynet.be>
* pan/message-window.c: merged back pan-0.12.1 fix for (#85502).
This fixes message corruption in the composer when a signature
contains 8bit characters.
2002-09-09 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: more hig work.
* pan/identities/identity-edit-ui.c: same.
2002-09-06 Charles Kerr <charles@rebelbase.com>
* gmime: resync with GMime cvs head
2002-09-05 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: sync some of the menu icons with the toolbar icons.
* pan/gui.c: added `get new in subscribed groups' back to the menu.
* pan/server-ui.c: obscure the server password.
Thanks to Jacob Ilsø Christensen for suggesting this.
2002-09-04 Charles Kerr <charles@rebelbase.com>
* pan/base/server.h: remove the gen_msgid flag; this seems to
be a feature that leaves people scratching their heads.
Instead let's just always generate the Message-ID and see if
anyone complains. Most NNTP servers overwrite it with their
own anyway...
2002-09-04 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c: make the default fg/bg theme-friendly
by having the unread color be the widget's fg color, and the
read color be partway between the widget's fg and bg colors.
* pan/articlelist.c: keep the normal and new-replies font in
sync by deriving one from the other: the new-replies font is
now the normal font + boldface.
* pan/prefs.c: sync.
2002-09-04 Charles Kerr <charles@rebelbase.com>
* pan/identities/identity-edit-ui.c: HiG improvements:
follow new dialog layout and keyboard navigation guidelines
* pan/gui.c: remove `...' from a couple of menu items that
don't need them.
* pan/xpm/icon_server.png: updated to use one of jimmac's
icons which looks better and is the right size.
* pan/server-ui.c: fixed a section title typo; update the
server list in the main menu when closing the dialog;
make we default to port 119 for new news servers.
2002-09-01 Charles Kerr <charles@rebelbase.com>
* pan/smtp.c: Fix memory trashing caused by forwarding mail.
Thanks to Frederic Crozat for reporting this bug & sending in a
patch.
2002-08-26 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: removed `article body date format' crack
* pan/prefs.c: removed `set wrap column' crack
* pan/newsrc-ui.[ch]: removed these functions.
* po/POTFILES.in: sync.
* pan/gui.c: sync.
* pan/server-ui.c: minor layout improvements.
2002-08-26 Charles Kerr <charles@rebelbase.com>
* pan/server-ui.[ch]: added max connections, reserve socket for reading.
* prefs.c: removed Online Settings tab.
* gui.c: sync.
* task-manager.c: sync.
2002-08-26 Charles Kerr <charles@rebelbase.com>
* pan/base/serverlist.c: save/restore newsrc flag & filename
* pan/prefs.c: removed news server and .newsrc tabs
* pan/server-menu-ui.[ch]: new module holding old serverlist menu code
* pan/server-ui.[ch]: landed the new `edit news servers' dialog
* pan/filter-ui.c: sync sidebar buttons with server dialog
* pan/rules/rule-ui.c: sync sidebar buttons with server dialog
2002-08-25 Christophe Lambin <clambin@easynet.be>
* pan/text.c (text_create): hide the cursor in the text window.
Thanks to Joe Drew for suggesting this. (#89002).
* configure.in, pan.spec.in: bumped gtkspell version to 2.0.2.
2002-08-23 Christophe Lambin <clambin@easynet.be>
* pan/text.c (get_url_from_location): translate the coordinates
from a (scrolled) window to the text buffer. This fixes the problem
where URLs were not clickable when the reader had scrolled down the
article. (#89290)
* gmime/gmime-message-part.c: build fix for Alpha. Thanks to
Kaj-Michael Lang for reporting this. (#91523)
2002-08-21 Charles Kerr <charles@rebelbase.com>
* pan/save-ui.c: committed the new `save article as...' dialog
2002-08-18 Charles Kerr <charles@rebelbase.com>
Pan 0.13.0 Released!
2002-08-18 Christophe Lambin <clambin@easynet.be>
* pan.spec.in: sync. w/ configure.in's requirement for gtkspell 2.0.0
2002-08-16 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: fix some quoting problems with the "xterm -e"
commands for external editors and web browsers.
* pan/flagset.c (flagset_remove_articles): Fixed 0.12.90 bug
that broke article unflagging. Thanks to Johan Ovlinger
for reporting this bug. (#90966)
2002-08-15 Charles Kerr <charles@rebelbase.com>
* pan/base/util-file.c (mbox_format_message): remove unused func.
* pan/base/util-file.c (mbox_get_next_message): same.
* pan/base/article.c (article_get_header_run_hash_from_text): same.
* pan/base/run.[ch]: remove unused module.
* replaced `g_string_sprintfa' with `g_string_append_printf'
* replaced `g_string_sprintf' with `g_string_printf'
* pan/base/newsrc.c (newsrc_get_read_str): made a little safer
by using a GString instead of a `this should be big enough' buf.
* pan/dialogs/dialog-newusr.c: made a little safer by using
g_snrpintf instead of sprintf
* pan/smtp.c (smtp_send_message): fix 0.12.90 bugs that
prevented mail from being sent properly.
Thanks to Mark Derricutt for reporting these bugs
and submitting patches.
2002-08-13 Charles Kerr <charles@rebelbase.com>
* pan/base/acache.c: added the `walk through the cache'
code into a background thread so that startup time isn't
killed when the cache is large.
Thanks to Bas Mevissen for suggesting this. (#89455)
2002-08-12 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c: replace "usleep" with "g_usleep"
for (a) Win32 portability and (b) to fix a SIGALRM
condition on Solaris 2.6 machines.
* pan/articlelist.c: fix 0.12.9x bug that caused the
"get new headers" tasks to be added to the end of the
Task Manager queue, rather than the beginning.
Thanks to Sam Solon for reporting this bug.
* pan/dialogs/dialog-newuser.c: Fix glib warning.
Thanks to Lars Bamberger for reporting this bug.
* pan/filters/filter_manager: Fix bug that caused bozo/spam
filters to not be created for new users.
Thanks to Bas Mevissen for reporting this bug. (#90491)
* pan/text.c: run the `all headers' in `show all headers'
through pan_header_to_utf8() just in case they have illegal
encodings. (Forte Agent 1.91/32.564)
2002-08-11 Charles Kerr <charles@rebelbase.com>
* pan/gmime/gmime-iconv.c: update to newer snapshot of this code.
This should help fix #90261.
* pan/group-ui.c (new_folder_response_cb): fixed minor memory leak.
Thanks to valgrind for finding this.
* pan/rules/rule-edit-ui.c (move_selected_newsgroups): same.
* pan/text.c (motion_notify_event): same.
* pan/filter-ui.c: replaced the "ok" button with a "close" button.
* pan/util.c (pan_dialog): same.
2002-08-11 Charles Kerr <charles@rebelbase.com>
Pan 0.12.94 Released!
2002-08-10 Charles Kerr <charles@rebelbase.com>
* replaced the 'ok' stock button in some of the dialogs with
a more descriptive button (save, new, open, execute, etc...)
2002-08-09 Charles Kerr <charles@rebelbase.com>
* configure.in: gtkspell 2.0.1 has problems, so force the user
to have 2.0.0 installed if they want to use spellchecking.
* pan/articlelist.c (articlelist_menu_poopup_nolock): fix bug
that caused new folders to not appear in the popup menu.
* pan/message-window.c: use gtk's builtin accelerators for the
stock menuitems.
* pan/util.h: remove unused prototypes.
* pan/base/pan-glib-extension.c (pan_stristr): remove unused function.
* pan/base/pan-glib-extension.c (commatize_ulong): same.
* pan/base/pan-glib-extension.c (pan_g_convert_to_utf8): same.
* pan/base/pan-glib-extension.c (get_lang_from_locale): same.
* pan/base/pan-glib-extension.c: remove unused strings.
* pan/group-store.[ch]: removed unused files.
2002-08-08 Charles Kerr <charles@rebelbase.com>
* pan/base/pan-glib-extensions.c (pan_body_to_utf8): use the
group's default charset if the one specified in the message's
Content-Type header turns out to be a lie.
Shame on you KNode/0.7.1! :)
* pan/base/pan-glib-extensions.c (pan_body_to_utf8): silence
false "some parts may not be displayed" warnings by using it
only when g_utf8_validate() fails.
2002-08-08 Christophe Lambin <clambin@easynet.be>
* pan/articlelist.c: utf8ize the date string.
* pan/base/pan-glib-extensions.c: fallback is locale to utf-8, not
the other way around. :)
2002-08-07 Charles Kerr <charles@rebelbase.com>
* pan/articlelist.c: more hacking on 90068; Chris said that
the patch earlier today actually hurt things on his end.
On investigation I found why I was getting truncations on
my Solaris box: g_convert() fails on strings like
"juergen.beigang@epost.de (Jürgen Beigang)" to UTF-8,
but gmime's iconv utils work. Maybe one is using Solaris'
iconv and the other is using GNU's?
2002-08-07 Charles Kerr <charles@rebelbase.com>
* pan/prefs.c: added "galeon --new-tab" to the dropdown list
of browsers in the preferences dialog.
Thanks to Martin Tomasek for suggesting this. (#89510)
* pan/articlelist.c: fix bug that wasn't converting text to
UTF-8 before populating the header pane, causing some strings
to be truncated or lost.
Thanks to Christian Lohmaier for reporting this bug. (#90068)
* pan/rules/rule-edit-ui.c: A couple of strings needing
translation weren't marked for translation.
Thanks to Pablo del Campo for reporting this bug. (#90115)
* pan/gui.c (main_menu_entries): fix accelerator typo.
Thanks to Duarte "HappyGuy" Loreto for reporting this bug.
* pan/base/pan-glib-extensions.c (pan_body_to_utf8): new
function that tries a little harder to convert text into
UTF-8, even if OE posted it in a broken form.
Thanks to Christian Lohmaier for reporting this bug. (#90067)
2002-08-06 Charles Kerr <charles@rebelbase.com>
--> BREAKING THE STRING FREEZE <--
* pan/gui.c: change "Read" to "Reading" to avoid symantic
collision. Thanks to Benjamin Greiner for reporting this
bug. (#90036)
* pan/prefs.c:
* pan/gui.c:
* pan/gui-headers.c:
* pan/message-window.c: Don't do things like
#define HEADER_SUBJECT "Subject"
char * foo = _(HEADER_SUBJECT);
Because they don't translate properly.
Thanks to Benjamin Greiner for reporting this bug. (#90041)
* pan/dialogs/dialog-about.c: fix UTF-8izing credit strings.
Thanks to Benjamin Greiner for reporting this bug. (#90045)
2002-08-04 Charles Kerr <charles@rebelbase.com>
Updated all the copyrights to restrict to GPL version 2.
Who knows what will be in future versions?
If it's good, _then_ we'll update our license.
2002-08-04 Charles Kerr <charles@rebelbase.com>
* pan/message-window.c: Fixed keyboard accelerator bug.
Thanks to Philippe Gramoull for reporting this bug.
* pan/task-xml.c: fixed a couple of minor memory leaks.
* pan/task-xml.c:
* pan/filters/filter-xml.c:
* pan/rules/rule-xml.c:
* pan/identities/identity-xml.c: const-ifying appropriate functions.
2002-08-04 Charles Kerr <charles@rebelbase.com>
Pan 0.12.93 Released!
2002-08-03 Charles Kerr <charles@rebelbase.com>
* pan/base/message-identifier.c (message_identifiers_mark_read):
new function that handles all the cross-references with a
minimum amount of events fired.
* pan/base/decode.c: call message_identifiers_mark_read(). Fixes
a 0.12.90 bug that decoding articles didn't mark them as read.
Thanks to Aaron Digulla for reporting this bug. (#88729)
2002-08-03 Charles Kerr <charles@rebelbase.com>
More waffling on spellchecking: rather than disabling by
default, Pan enables automatically if gtkspell is installed,
and disables if not. Also better handle error codes from
gtkspell_init(). Thanks to Evan Martin for reporting this.
2002-08-02 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* configure.in: disable gtkspell by default. gtkspell is cool
but I'm getting too many bug reports from aspell crashing
when it can't find config files, etc.
* pan/message-window.c (populate_post_info_pane): Fixed crash that
occurred when composing messages. Thanks to DevilKin for reporting
this bug. (#89603)
* pan/task-post.c (build_nntp_message): make sure the message-id
header doesn't get folded, because this annoys some NNTP servers.
Chris reported this bug. (#88100)
* pan/task-post.c (build_nntp_message): apply a gmime charset filter
to each part that has a charset defined, because the files are read
in from disk in UTF-8. Thanks to Martin Tomasek for being the first
of many to report htis bug. (#88670)
2002-08-01 Christophe Lambin <clambin@easynet.be>
(Bug Fixes)
* pan/text.c (append_text_buffer_nolock): added Charles' hunch for
fixing the crashes when mousing over URLs. (#89584)
2002-08-01 Charles Kerr <charles@rebelbase.com>
(Removing Crackpipe Features)
* removed the group `nickname' feature. Only one person has
ever commented to me about using it, and it was just a stopgap
measure until "View|Abbreviate Group Name" was implemented.
* removed automatic generation of the X-Comment-To header,
to see if any fidonet users complain.
2002-07-30 Charles Kerr <charles@rebelbase.com>
(https)
* pan/text.c: handle https:// urls.
* pan/util.c: same.
Thanks to Adam Huffman for suggesting this. (#89293)
2002-07-30 Charles Kerr <charles@rebelbase.com>
Pan 0.12.92 Released!
2002-07-30 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/gui-headers.c: Headers above the body pane now use the right
charset. Thanks to Toivo Leedjarv for reporting this bug. (#87065)
* pan/base/article-thread.c: round 2 of the 'save-as' dialog bug.
Now the problem is making sure that small followups to a multipart
aren't themselves flagged as multiparts because of the (01/256)
in their subject.
* pan/articlelist.c: check the multipart state before popping up
the "save as" dialog as a default action; that doesn't make sense
as the default action of an incomplete multipart.
2002-07-30 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/task-post.c:
* pan/message-window.c: Fix the bug that cut out the "Newsgroups:"
header of posted messages before pushing them to pan.sent.
* gmime/gmime-message.c: Sync with gmime head to fix minor bug.
(Tweaks)
* pan/message-window.c: set the focus in the correct widget, whether
it's a new message or a followup.
* pan/message-window.c: set the insert point to the correct place
(before a sig, after the quotes) in the compose window.
2002-07-29 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/base/article-thread.c: fixed bug that caused some articles
to incorrectly be marked as incomplete binaries. Thanks
to Adam Huffman for reporting this bug.
* pan/articlelist.c: same.
2002-07-29 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's add'l charsets. (#88669)
2002-07-29 Charles Kerr <charles@rebelbase.com>
(Keeping up with Fejj)
* gmime: resync with GMime CVS HEAD. Looks like it's about
time to cut out GMime and rely on it as an outside library.
* pan/base/decode.c: fix extra yenc info to work with GMime2
* pan/base/util-mime.c: same.
* pan/text.c: same.
(Strings)
* merged similar strings to reduce the total number of strings
that translators have to slog through.
* for consistency, always use "quotes" instead of
`quotes' or ``quotes''.
* pan/filter-edit-ui.c: fixed string typo -- missing ")"
* pan/pan-config.c: remove extra linefeed from a log message
* pan/gui.c: Use "Followup" instead of "Follow-Up"
2002-07-29 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-parser.c (parser_step_headers): When refilling, make
sure that the refilled buffer is larger than the buffer was before
refilling, otherwise break out of the loop and parse whatever is
left. Fixes bug #89260 on bugzilla.gnome.org
2002-07-28 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/article-actions.c (article_cancel_dtor): fixed bug that
crashed Pan after the user cancelled an article. Thanks to
Martin Tomasek for reporting this bug. (#88671)
* pan/gui.c: the 'followup-to' toolbar button actually invoked
the reply window instead of followup-to. Thanks to Brian Morrison
for reporting this bug. (#88257)
(Bug Fixes - More Valgrind)
* pan/base/util-mime.c (separate_encoded_parts): fixed ugly UMR
that occurred in obscure circumstances.
* pan/base/pan-config.c (pan_config_load): fix another minor leak.
* pan/message-window.c (post): Fixed a leaked GMimeMessage.
2002-07-27 Charles Kerr <charles@rebelbase.com>
(Bug Fixes - Valgrind Found all these Leaks!)
* pan/save-ui.c: fixed a memleak.
* pan/message-window.c (remove_custom_headers): same.
* pan/message-window.c (populate_message_from_mw): same.
* pan/identities/identity-edit-ui.c (identity_from_headers_tab): same.
* pan/base/message-check.c (check_mail_addresses): fixed _two_ leaks...
* pan/identities/identity-edit-ui.c (identity_close_cb): and two more!
* pan/base/gnksa.c: removed unused variable.
2002-07-26 Christophe Lambin <clambin@easynet.be>
* fixed a memleak I introduced yesterday. Charles found this one.
2002-07-26 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/text.c (text_read_more): if the current article is queued,
jump to the next article instead of requeueing the first article.
This was apparently used in 0.11.x to the space key across
a handful of articles to download them in a quick burst.
Thanks to Alan for reporting this bug. (#88969)
(Portability)
* configure.in: add a check for ssize_t, and if we don't have it,
typedef it to a long. Check one item of the mingw port
checklist... :)
2002-07-25 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix changes for external editors and charsets.
(#85289)
2002-07-25 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/articlelist.c (articlelist_read_article): Don't crap out
if article==NULL. Thanks to Kevin for reporting this bug. (#88921)
* pan/base/article-thread.c (normalize_subject): Handle subjects
like "some text (1of2).part01.P01 (1/45)". We were incorrectly
stripping out the "(1of2)" substring, which messed up threading.
Thanks to Roman Moller for reporting this bug. (#82751)
(Tweaks)
* pan/base/pan-glib-extensions.c (pan_header_to_utf8): small tweaks
to try to avoid extra malloc/free calls and get rid of an unused
helper functions.
* pan/base/article.c: sync.
* pan/base/nntp.c: sync.
2002-07-24 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's charset changes for the articlelist.
2002-07-24 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/gui.c: remove the "tasks running; are you sure you want to quit?"
dialog -- the tasks will just be reinstated when they restart Pan.
(Bug Fixes)
* pan/task-post.c: if the server has the "don't generate Message-ID"
togglbutton checked, don't send a Message-ID header in new posts.
Thanks to Markus Schorpp for reporting this bug. (#88092)
* pan/base/decode.c: If we run out of disk space while saving
an attachments, log an error and fail the task. Previously
Pan didn't check for write errors and marked the article as
saved. Thanks to Wolfgang Karall for reporting this bug. (#79993)
* pan/base/file-headers.c: same, for headers
* pan/base/file-grouplist.c: same, for grouplist
* pan/base/util-file.c: same, for copying files
2002-07-23 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/group-ui.c: allow new folders to have capital letters.
Thanks to Himanshu Gohel for reporting this bug. (#74892)
2002-07-22 Charles Kerr <charles@rebelbase.com>
Pan 0.12.91 Released!
2002-07-22 Charles Kerr <charles@rebelbase.com>
(Signatures)
* If the user-specified signature file is executable, run it and
use its output as the signature.
(Bug Fixes)
* pan/text.c (text_refresh): call set_current_message() instead of
set_current_message_impl(). This fixes a problem with "show all
headers" not refreshing the text pane. Thanks to DevilKin for
reporting this bug. (#88790)
* pan/message-window.c (rot13_cb): fix memory leak.
* pan/group-actions.c (group_action_selected_update_count): same.
(Tweaks)
* pan/group-actions.c (start_task_headers): add all the header
tasks to the queue in a batch, rather than one at a time, so
that tasks.xml only gets written once.
2002-07-21 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* tweaked a lot of places calling g_string_free (gstr, FALSE)
to use glib2's new retval for this func.
* pan/message-window.c: moved some information out of public
header into private implementation.
2002-07-20 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/message-window.c (make_reply_window): fix dangling pointer
error. Thanks to ccmalloc for finding this bug.
* pan/base/article-thread.c (thread_articles): fix possible
malloc(0). Thanks to ccmalloc for finding this bug.
* pan/base/acache.c: fixed a couple of g_warnings.
* pan/base/pan-config.c:
* pan/base/serverlist.c: added debug_enter/debug_exit calls.
2002-07-19 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-iconv-utils.c (g_mime_iconv_strndup): Fix a logic
mistake in the calculation of the number of bytes converted.
2002-07-19 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/acache.c: fix crash that occurred when trying to read expired
articles. Thanks to Alex Jaques for reporting this bug. (#88665)
* pan/text.c:
* pan/gui.c:
* pan/message-window.c: Fix refcount bug with get_current_message().
I think this is what's been causing the crash-on-followup bug.
Also left in some odebug scaffolding in these files to help testing
by CVS users for the next few days.
(Tweaks)
* pan/nntp.c:
* pan/task-xml.c: small tweaks to make log messages more useful.
2002-07-18 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/message-window.c: added ctrl-return back in as the shortcut for
"send now". Thanks to Laurent Duperval for reminding me. (#88386)
* sync: with pan-0-12-fix's fix for not checking the user's setting of
get-new-headers-in-subscribed-on-startup. (#88255)
* pan/base/acache.c: silence a harmless g_warning.
(Tweaks)
* pan/pan.c: make the "restore tasks from last session?" dialog a
little prettier by using the GtkMessageDialog.
2002-07-18 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's fix for crashing when editing filters from
a rule. (#86215)
2002-07-16 Charles Kerr <charles@rebelbase.com>
(Tweaks)
* pan/base/pan-config.c: reduce the number of memory
allocations/frees required to query pan-config.
2002-07-15 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's 'one "get headers" dialog for all selected
groups' update.
2002-07-15 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* pan/gui.c: Fixed 0.12.0 bug the prevented the toggle "Show Group Pane",
"Show Header Pane", and "Show Body Pane" buttons from working right.
Thanks to Mike Robinson for reporting this bug. (#86881)
* pan/filter-edit-ui.c: Fixed minor 0.11.90 bug. When the user clicks
on a line, such as the text entry field in the subject/message-id line,
then the radiobutton on that line is supposed to select itself
automatically, but in the upgrade to gtk2 I flubbed that code.
2002-07-14 Charles Kerr <charles@rebelbase.com>
(Usability)
* pan/text.c: change the mouse pointer from GDK_XTERM to GDK_HAND2
whenever the user the user mouses over a link in the text pane.
(Bug Fixes)
* pan/message-window.c: Fix 0.12.90 bug that made replie bodies
quoted-printable. sheesh. Thanks to DevilKin for reporting
this bug. (#88010)
* pan/message-window.c: Fix 0.12.90 bug that caused replies
to pick up the same Message-Id as the messages they were replying to.
Yuck. Thanks to Laurent Duperval for reporting this bug. (#87854)
* pan/base/file-headers.c: Fix 0.12.90 log message that confused the
log window. Thanks for DevilKin for reporting this bug. (#88008)
* pan/save-ui.c: Fix 0.12.90 problem with "%g" and "%G" not being
substituted correctly when saving articles/attachments.
Thanks to quimvy72 for reporting this bug. (#88027)
* pan/save-ui.c: Fix 0.12.0 bug that caused "add to front of queue"
to not work. Thanks to Alen Williams for reporting this bug. (#88106)
* pan/gui.c: Fix 0.12.0 wart: remove "..." from "Find Next..."
because it doesn't open a dialog box. Also fixed .po files accordingly.'
Thanks to Mike Robinson for reporting this bug. (#86876)
2002-07-12 Charles Kerr <charles@rebelbase.com>
(Bug Fix)
* pan/newsrc.c (mark_range_read): fixed a bug that I found
while inspecting the code.
2002-07-11 Charles Kerr <charles@rebelbase.com>
Pan 0.12.90 Released!
2002-07-08 Charles Kerr <charles@rebelbase.com>
(Spellchecking)
* pan/pan.c:
* pan/message-window.c: added in gtkspell support.
Thanks to Michael Alger for contributing this patch.
(Fonts)
* pan/prefs.c:
* pan/grouplist.c:
* pan/articlelist.c: use the system default for these fonts.
2002-07-08 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's queue retry fix. (#86795)
* sync: with pan-0-12-fix's 'get all headers&bodies' fix. (#72555)
2002-07-06 Charles Kerr <charles@rebelbase.com>
(XMLization)
* pan/task-xml.c: implement the task reading. Restoring tasks
on startup seems to work now!
* pan/queue.c: added "dirty" flag to tell queue when tasks.xml
should be written to disk.
2002-07-06 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's 'are you sure' dialog fix. (#87518)
2002-07-04 Charles Kerr <charles@rebelbase.com>
(XMLization)
* pan/pan.c: on startup, if the tasks.xml is present, ask the
user if they'd like to restore those tasks.
* pan/queue.c: fix bug that erased tasks.xml at startup.
2002-07-04 Jeffrey Stedfast <fejj@ximian.com>
* gmime/gmime-iconv-utils.c (g_mime_iconv_utils_strndup):
Multibyte charsets need to be nul-terminated by more than just a
single nul byte (duh!).
2002-07-03 Charles Kerr <charles@rebelbase.com>
(Cleanup)
* removed about 20 translation strings that were unnecessary,
identical except for case, or otherwise redundant.
* spelling corrections: "newsereaders" "Followoup-To"
* replaced ``string'' and `string' lines with "string" for
consistency.
(Decode)
* pan/base/decode.c: fix MessageIdentifier problem that didn't
set the "article saved" flag for Articles that are in memory.
(Flagged)
* pan/flagset.c: added a container that holds MessageIdentifiers
to all articles that are flagged for download. This way articles
can be flagged across groups. Previously only the current group
could have its articles flagged.
(Filters)
* pan/filter-mediator.c: bug fixes.
* pan/article-toolbar.c: bug fixes.
2002-07-02 Charles Kerr <charles@rebelbase.com>
(Filters)
* pan/gui.c: plugged in the filter menu buttons.
* pan/filter-mediator.c: mediates between filter menu & toolbar
* pan/filter-current-ui.c: removed.
* pan/article-toolbar.c: sync.
2002-07-01 Charles Kerr <charles@rebelbase.com>
(Toolbar)
* pan/gui.c: plugged in the toolbar
* pan/pan/xpm: reverted to the old attachment icons, copped
balsa's "send now" icon, some icon naming cleanup
* pan/article-actions.c: port supersede/cancel to GMimeMessage
* pan/articlelist.c: sync.
* pan/task-post.c: remove the X-Pan-Internal headers when posting.
* pan/task-post.c: fix bug that kept post from moving to pan.sent.
* pan/base/acache.c: fix free-memory-twice bug.
2002-06-30 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's changes for charsets in follow-ups.
2002-06-29 Charles Kerr <charles@rebelbase.com>
* More work on the folder/acache integration. It all seems
to be working again. Fixed copy-to-folder. I need to do
some more testing and memprof it, but now all the pieces are
in place and things should be usable.
2002-06-28 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's auto wrap changes. (#85508)
2002-06-26 Charles Kerr <charles@rebelbase.com>
* More work to integrating acache and folders.
2002-06-26 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's new windows-1251 charset.
* sync: with pan-0-12-fix's articlelist changes. (#86409)
* sync: with pan-0-12-fix's smtp changes. (#85503)
2002-06-25 Charles Kerr <charles@rebelbase.com>
* Toolbar, second draft.
* pan/gui.c: wired in the net connection button s.t. it shows
the connection status.
* pan/pan/xpm: removed old network connection icon and added
in Evolution's online/offline icons.
2002-06-25 Charles Kerr <charles@rebelbase.com>
* pan/gui.c: committed non-functional toolbar.
* pan/pan/xpm: threw away a lot of unused icons, added new ones
for the toolbar, and changed a few by stealing liberally from
evo and others ... er ... make that "changed a few for better
consistency with the Gnome desktop" :)
2002-06-24 Charles Kerr <charles@rebelbase.com>
* pan/message-window.c: Fix all the #warnings that got littered
around when upgrading to GMimeMessage.
* pan/nntp.c: Fix the progressbar while downloading articles.
* pan/pan/xpm: updated the folder/newsgroup icons based on some
user feedback on the toolbar's first draft.
2002-06-24 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's rule on renamed group fix. (#85725)
2002-06-23 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix's new charset picker and using the locale
to determine the default charset. (#84995)
* sync: with pan-0-12-fix's article state fix. (#85445)
2002-06-22 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix build fixes. (#85968, #86203)
2002-06-20 Charles Kerr <charles@rebelbase.com>
Part one of moving text, tasks, and compose to GMimeMessage.
Folders are broken, posting is probably broken.
2002-06-20 Charles Kerr <charles@rebelbase.com>
(Bug Fixes)
* fix spelling mistakes: "Cancelled", "Cancelling",
"Portugese", "totalling", "Aricle", "likey".
(Gnome HIG)
* try to adhere better to the Gnome HIG suggestions:
align labels in tables to the left, follow capitalization
suggestions, consistent use of email, user name, put colons
at the ends left-laying labels, etc.
(I18N)
* remove unnecessary translation strings.
* use a consistent quote characters: "a", not ``a'' or `a'
2002-06-19 Christophe Lambin <clambin@easynet.be>
* sync: with pan-0-12-fix gmime build fix (#85968)
|