1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498
|
import io
import textwrap
import pytest
from scripts import validate_docstrings
class BadDocstrings:
"""Everything here has a bad docstring"""
def private_classes(self) -> None:
"""
This mentions NDFrame, which is not correct.
"""
def prefix_pandas(self) -> None:
"""
Have `pandas` prefix in See Also section.
See Also
--------
pandas.Series.rename : Alter Series index labels or name.
DataFrame.head : The first `n` rows of the caller object.
"""
def redundant_import(self, paramx=None, paramy=None) -> None:
"""
A sample DataFrame method.
Should not import numpy and pandas.
Examples
--------
>>> import numpy as np
>>> import pandas as pd
>>> df = pd.DataFrame(np.ones((3, 3)),
... columns=('a', 'b', 'c'))
>>> df.all(1)
0 True
1 True
2 True
dtype: bool
>>> df.all(bool_only=True)
Series([], dtype: bool)
"""
def unused_import(self) -> None:
"""
Examples
--------
>>> import pandas as pdf
>>> df = pd.DataFrame(np.ones((3, 3)), columns=('a', 'b', 'c'))
"""
def missing_whitespace_around_arithmetic_operator(self) -> None:
"""
Examples
--------
>>> 2+5
7
"""
def indentation_is_not_a_multiple_of_four(self) -> None:
"""
Examples
--------
>>> if 2 + 5:
... pass
"""
def missing_whitespace_after_comma(self) -> None:
"""
Examples
--------
>>> df = pd.DataFrame(np.ones((3,3)),columns=('a','b', 'c'))
"""
def write_array_like_with_hyphen_not_underscore(self) -> None:
"""
In docstrings, use array-like over array_like
"""
def leftover_files(self) -> None:
"""
Examples
--------
>>> import pathlib
>>> pathlib.Path("foo.txt").touch()
"""
class TestValidator:
def _import_path(self, klass=None, func=None):
"""
Build the required import path for tests in this module.
Parameters
----------
klass : str
Class name of object in module.
func : str
Function name of object in module.
Returns
-------
str
Import path of specified object in this module
"""
base_path = "scripts.tests.test_validate_docstrings"
if klass:
base_path = f"{base_path}.{klass}"
if func:
base_path = f"{base_path}.{func}"
return base_path
def test_bad_class(self, capsys) -> None:
errors = validate_docstrings.pandas_validate(
self._import_path(klass="BadDocstrings")
)["errors"]
assert isinstance(errors, list)
assert errors
@pytest.mark.parametrize(
"klass,func,msgs",
[
(
"BadDocstrings",
"private_classes",
(
"Private classes (NDFrame) should not be mentioned in public "
"docstrings",
),
),
(
"BadDocstrings",
"prefix_pandas",
(
"pandas.Series.rename in `See Also` section "
"does not need `pandas` prefix",
),
),
# Examples tests
(
"BadDocstrings",
"redundant_import",
("Do not import numpy, as it is imported automatically",),
),
(
"BadDocstrings",
"redundant_import",
("Do not import pandas, as it is imported automatically",),
),
(
"BadDocstrings",
"unused_import",
(
"flake8 error: line 1, col 1: F401 'pandas as pdf' "
"imported but unused",
),
),
(
"BadDocstrings",
"missing_whitespace_around_arithmetic_operator",
(
"flake8 error: line 1, col 2: "
"E226 missing whitespace around arithmetic operator",
),
),
(
"BadDocstrings",
"indentation_is_not_a_multiple_of_four",
# with flake8 3.9.0, the message ends with four spaces,
# whereas in earlier versions, it ended with "four"
(
"flake8 error: line 2, col 3: E111 indentation is not a "
"multiple of 4",
),
),
(
"BadDocstrings",
"missing_whitespace_after_comma",
("flake8 error: line 1, col 33: E231 missing whitespace after ','",),
),
(
"BadDocstrings",
"write_array_like_with_hyphen_not_underscore",
("Use 'array-like' rather than 'array_like' in docstrings",),
),
],
)
def test_bad_docstrings(self, capsys, klass, func, msgs) -> None:
result = validate_docstrings.pandas_validate(
self._import_path(klass=klass, func=func)
)
for msg in msgs:
assert msg in " ".join([err[1] for err in result["errors"]])
def test_leftover_files_raises(self) -> None:
with pytest.raises(Exception, match="The following files"):
validate_docstrings.pandas_validate(
self._import_path(klass="BadDocstrings", func="leftover_files")
)
def test_validate_all_ignore_functions(self, monkeypatch) -> None:
monkeypatch.setattr(
validate_docstrings,
"get_all_api_items",
lambda: [
(
"pandas.DataFrame.align",
"func",
"current_section",
"current_subsection",
),
(
"pandas.Index.all",
"func",
"current_section",
"current_subsection",
),
],
)
result = validate_docstrings.validate_all(
prefix=None,
ignore_functions=["pandas.DataFrame.align"],
)
assert len(result) == 1
assert "pandas.Index.all" in result
def test_validate_all_ignore_deprecated(self, monkeypatch) -> None:
monkeypatch.setattr(
validate_docstrings,
"pandas_validate",
lambda func_name: {
"docstring": "docstring1",
"errors": [
("ER01", "err desc"),
("ER02", "err desc"),
("ER03", "err desc"),
],
"warnings": [],
"examples_errors": "",
"deprecated": True,
},
)
result = validate_docstrings.validate_all(prefix=None, ignore_deprecated=True)
assert len(result) == 0
class TestApiItems:
@property
def api_doc(self):
return io.StringIO(
textwrap.dedent(
"""
.. currentmodule:: itertools
Itertools
---------
Infinite
~~~~~~~~
.. autosummary::
cycle
count
Finite
~~~~~~
.. autosummary::
chain
.. currentmodule:: random
Random
------
All
~~~
.. autosummary::
seed
randint
"""
)
)
@pytest.mark.parametrize(
"idx,name",
[
(0, "itertools.cycle"),
(1, "itertools.count"),
(2, "itertools.chain"),
(3, "random.seed"),
(4, "random.randint"),
],
)
def test_item_name(self, idx, name) -> None:
result = list(validate_docstrings.get_api_items(self.api_doc))
assert result[idx][0] == name
@pytest.mark.parametrize(
"idx,func",
[(0, "cycle"), (1, "count"), (2, "chain"), (3, "seed"), (4, "randint")],
)
def test_item_function(self, idx, func) -> None:
result = list(validate_docstrings.get_api_items(self.api_doc))
assert callable(result[idx][1])
assert result[idx][1].__name__ == func
@pytest.mark.parametrize(
"idx,section",
[
(0, "Itertools"),
(1, "Itertools"),
(2, "Itertools"),
(3, "Random"),
(4, "Random"),
],
)
def test_item_section(self, idx, section) -> None:
result = list(validate_docstrings.get_api_items(self.api_doc))
assert result[idx][2] == section
@pytest.mark.parametrize(
"idx,subsection",
[(0, "Infinite"), (1, "Infinite"), (2, "Finite"), (3, "All"), (4, "All")],
)
def test_item_subsection(self, idx, subsection) -> None:
result = list(validate_docstrings.get_api_items(self.api_doc))
assert result[idx][3] == subsection
class TestPandasDocstringClass:
@pytest.mark.parametrize(
"name", ["pandas.Series.str.isdecimal", "pandas.Series.str.islower"]
)
def test_encode_content_write_to_file(self, name) -> None:
# GH25466
docstr = validate_docstrings.PandasDocstring(name).validate_pep8()
# the list of pep8 errors should be empty
assert not list(docstr)
class TestMainFunction:
def test_exit_status_for_main(self, monkeypatch) -> None:
monkeypatch.setattr(
validate_docstrings,
"pandas_validate",
lambda func_name: {
"docstring": "docstring1",
"errors": [
("ER01", "err desc"),
("ER02", "err desc"),
("ER03", "err desc"),
],
"examples_errs": "",
},
)
exit_status = validate_docstrings.main(
func_name="docstring1",
prefix=None,
errors=[],
output_format="default",
ignore_deprecated=False,
ignore_functions=None,
)
assert exit_status == 0
def test_exit_status_errors_for_validate_all(self, monkeypatch) -> None:
monkeypatch.setattr(
validate_docstrings,
"validate_all",
lambda prefix, ignore_deprecated=False, ignore_functions=None: {
"docstring1": {
"errors": [
("ER01", "err desc"),
("ER02", "err desc"),
("ER03", "err desc"),
],
"file": "module1.py",
"file_line": 23,
},
"docstring2": {
"errors": [("ER04", "err desc"), ("ER05", "err desc")],
"file": "module2.py",
"file_line": 925,
},
},
)
exit_status = validate_docstrings.main(
func_name=None,
prefix=None,
errors=[],
output_format="default",
ignore_deprecated=False,
ignore_functions=None,
)
assert exit_status == 5
def test_no_exit_status_noerrors_for_validate_all(self, monkeypatch) -> None:
monkeypatch.setattr(
validate_docstrings,
"validate_all",
lambda prefix, ignore_deprecated=False, ignore_functions=None: {
"docstring1": {"errors": [], "warnings": [("WN01", "warn desc")]},
"docstring2": {"errors": []},
},
)
exit_status = validate_docstrings.main(
func_name=None,
prefix=None,
errors=[],
output_format="default",
ignore_deprecated=False,
ignore_functions=None,
)
assert exit_status == 0
def test_exit_status_for_validate_all_json(self, monkeypatch) -> None:
print("EXECUTED")
monkeypatch.setattr(
validate_docstrings,
"validate_all",
lambda prefix, ignore_deprecated=False, ignore_functions=None: {
"docstring1": {
"errors": [
("ER01", "err desc"),
("ER02", "err desc"),
("ER03", "err desc"),
]
},
"docstring2": {"errors": [("ER04", "err desc"), ("ER05", "err desc")]},
},
)
exit_status = validate_docstrings.main(
func_name=None,
prefix=None,
errors=[],
output_format="json",
ignore_deprecated=False,
ignore_functions=None,
)
assert exit_status == 0
def test_errors_param_filters_errors(self, monkeypatch) -> None:
monkeypatch.setattr(
validate_docstrings,
"validate_all",
lambda prefix, ignore_deprecated=False, ignore_functions=None: {
"Series.foo": {
"errors": [
("ER01", "err desc"),
("ER02", "err desc"),
("ER03", "err desc"),
],
"file": "series.py",
"file_line": 142,
},
"DataFrame.bar": {
"errors": [("ER01", "err desc"), ("ER02", "err desc")],
"file": "frame.py",
"file_line": 598,
},
"Series.foobar": {
"errors": [("ER01", "err desc")],
"file": "series.py",
"file_line": 279,
},
},
)
exit_status = validate_docstrings.main(
func_name=None,
prefix=None,
errors=["ER01"],
output_format="default",
ignore_deprecated=False,
ignore_functions=None,
)
assert exit_status == 3
exit_status = validate_docstrings.main(
func_name=None,
prefix=None,
errors=["ER03"],
output_format="default",
ignore_deprecated=False,
ignore_functions=None,
)
assert exit_status == 1
|