1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
#!/usr/bin/perl
BEGIN {
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
};
use strict;
use warnings FATAL => 'all';
use English qw(-no_match_vars);
use Test::More tests => 5;
use PerconaTest;
use VariableAdvisorRules;
use Advisor;
use PodParser;
# This module's purpose is to run rules and return a list of the IDs of the
# triggered rules. It should be very simple. (But we don't want to put the two
# modules together. Their purposes are distinct.)
my $p = new PodParser();
my $qar = new VariableAdvisorRules(PodParser => $p);
my $adv = new Advisor(match_type=>"pos");
# This should make $qa internally call get_rules() on $qar and save the rules
# into its own list. If the user plugs in his own module, we'd call
# load_rules() on that too, and just append the rules (with checks that they
# don't redefine any rule IDs).
$adv->load_rules($qar);
# To test the above, we ask it to load the same rules twice. It should die with
# an error like "Rule LIT.001 already exists, and cannot be redefined"
throws_ok (
sub { $adv->load_rules($qar) },
qr/Rule \S+ already exists and cannot be redefined/,
'Duplicate rules are caught',
);
# We'll also load the rule info, so we can test $adv->get_rule_info() after the
# POD is loaded.
$qar->load_rule_info(
rules => [ $qar->get_rules() ],
file => "$trunk/bin/pt-variable-advisor",
section => 'RULES',
);
# This should make $qa call $qar->get_rule_info('....') for every rule ID it
# has, and store the info, and make sure that nothing is redefined. A user
# shouldn't be able to load a plugin that redefines the severity/desc of a
# built-in rule. Maybe we'll provide a way to override that, though by default
# we want to warn and be strict.
$adv->load_rule_info($qar);
# TODO: write a test that the rules are described as defined in the POD of the
# tool. Testing one rule should be enough.
# Test that it can't be redefined...
throws_ok (
sub { $adv->load_rule_info($qar) },
qr/Info for rule \S+ already exists and cannot be redefined/,
'Duplicate rule info is caught',
);
is_deeply(
$adv->get_rule_info('max_binlog_size'),
{
description => 'The max_binlog_size is smaller than the default of 1GB.',
id => 'max_binlog_size',
severity => 'note',
},
'get_rule_info()'
);
# #############################################################################
# Ignore rules.
# #############################################################################
$adv = new Advisor(
match_type => "pos",
ignore_rules => { 'max_binlog_size' => 1 },
);
$adv->load_rules($qar);
$adv->load_rule_info($qar);
is(
$adv->get_rule_info('max_binlog_size'),
undef,
"Didn't load ignored rule"
);
# #############################################################################
# Done.
# #############################################################################
my $output = '';
{
local *STDERR;
open STDERR, '>', \$output;
$p->_d('Complete test coverage');
}
like(
$output,
qr/Complete test coverage/,
'_d() works'
);
exit;
|
