1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425
|
#!/usr/bin/perl
BEGIN {
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
};
use strict;
use warnings FATAL => 'all';
use English qw(-no_match_vars);
use Test::More;
use PodParser;
use AdvisorRules;
use VersionParser;
use VariableAdvisorRules;
use Advisor;
use PerconaTest;
my $p = new PodParser();
my $var = new VariableAdvisorRules(PodParser => $p);
isa_ok($var, 'VariableAdvisorRules');
my @rules = $var->get_rules();
ok(
scalar @rules,
'Returns array of rules'
);
my $rules_ok = 1;
foreach my $rule ( @rules ) {
if ( !$rule->{id}
|| !$rule->{code}
|| (ref $rule->{code} ne 'CODE') )
{
$rules_ok = 0;
last;
}
}
ok(
$rules_ok,
'All rules are proper'
);
# #############################################################################
# Test the rules.
# #############################################################################
my @cases = (
{ name => "auto inc 1",
vars => [qw(auto_increment_increment 1 auto_increment_offset 1)],
advice => [],
},
{ name => "auto inc 2",
vars => [qw(auto_increment_increment 2 auto_increment_offset 1)],
advice => [qw(auto_increment)],
},
{ name => "auto inc 3",
vars => [qw(auto_increment_increment 1 auto_increment_offset 3)],
advice => [qw(auto_increment)],
},
{ name => "concurrent insert",
vars => [qw(concurrent_insert 2)],
advice => [qw(concurrent_insert)],
},
{ name => "concurrent insert",
vars => [qw(concurrent_insert NEVER)],
advice => [qw()],
},
{ name => "concurrent insert",
vars => [qw(concurrent_insert AUTO)],
advice => [qw()],
},
{ name => "concurrent insert",
vars => [qw(concurrent_insert ALWAYS)],
advice => [qw(concurrent_insert)],
},
{ name => "connect timeout",
vars => [qw(connect_timeout 11)],
advice => [qw(connect_timeout)],
},
{ name => "debug",
vars => [qw(debug ON)],
advice => [qw(debug)],
},
{ name => "delay_key_write",
vars => [qw(delay_key_write ON)],
advice => [qw(delay_key_write)],
},
{ name => "flush",
vars => [qw(flush ON)],
advice => [qw(flush)],
},
{ name => "flush time",
vars => [qw(flush_time 1)],
advice => [qw(flush_time)],
},
{ name => "have bdb",
vars => [qw(have_bdb YES)],
advice => [qw(have_bdb)],
},
{ name => "init connect",
vars => [qw(init_connect foo)],
advice => [qw(init_connect)],
},
{ name => "init_file",
vars => [qw(init_file bar)],
advice => [qw(init_file)],
},
{ name => "init slave",
vars => [qw(init_slave 12346)],
advice => [qw(init_slave)],
},
{ name => "innodb_additional_mem_pool_size",
vars => [qw(innodb_additional_mem_pool_size 21000000)],
advice => [qw(innodb_additional_mem_pool_size)],
},
{ name => "innodb_buffer_pool_size",
vars => [qw(innodb_buffer_pool_size 10485760)],
advice => [qw(innodb_buffer_pool_size)],
},
{ name => "innodb checksums",
vars => [qw(innodb_checksums OFF)],
advice => [qw(innodb_checksums)],
},
{ name => "innodb_doublewrite",
vars => [qw(innodb_doublewrite OFF)],
advice => [qw(innodb_doublewrite)],
},
{ name => "innodb_fast_shutdown",
vars => [qw(innodb_fast_shutdown 0)],
advice => [qw(innodb_fast_shutdown)],
},
{ name => "innodb_flush_log_at_trx_commit-1",
vars => [qw(innodb_flush_log_at_trx_commit 2)],
advice => [qw(innodb_flush_log_at_trx_commit-1)],
},
{ name => "innodb_flush_log_at_trx_commit-2",
vars => [qw(innodb_flush_log_at_trx_commit 0)],
advice => [qw(innodb_flush_log_at_trx_commit-1 innodb_flush_log_at_trx_commit-2)],
},
{ name => "innodb_force_recovery",
vars => [qw(innodb_force_recovery 1)],
advice => [qw(innodb_force_recovery)],
},
{ name => "innodb_lock_wait_timeout",
vars => [qw(innodb_lock_wait_timeout 51)],
advice => [qw(innodb_lock_wait_timeout)],
},
{ name => "innodb_log_buffer_size",
vars => [qw(innodb_log_buffer_size 17000000)],
advice => [qw(innodb_log_buffer_size)],
},
{ name => "innodb_log_file_size",
vars => [qw(innodb_log_file_size 5242880)],
advice => [qw(innodb_log_file_size)],
},
{ name => "innodb_max_dirty_pages_pct",
vars => [qw(innodb_max_dirty_pages_pct 89)],
mysql_version => VersionParser->new('5.1.59'),
advice => [qw(innodb_max_dirty_pages_pct)],
},
{ name => "key_buffer_size",
vars => [qw(key_buffer_size 8388608)],
advice => [qw(key_buffer_size)],
},
{ name => "large_pages",
vars => [qw(large_pages ON)],
advice => [qw(large_pages)],
},
{ name => "locked in memory",
vars => [qw(locked_in_memory ON)],
advice => [qw(locked_in_memory)],
},
{ name => "log_warnings-1",
vars => [qw(log_warnings 0)],
advice => [qw(log_warnings-1)],
},
{ name => "log_warnings-2",
vars => [qw(log_warnings 1)],
advice => [qw(log_warnings-2)],
},
{ name => "low_priority_updates",
vars => [qw(low_priority_updates ON)],
advice => [qw(low_priority_updates)],
},
{ name => "max_binlog_size",
vars => [qw(max_binlog_size 999999999)],
advice => [qw(max_binlog_size)],
},
{ name => "max_connect_errors",
vars => [qw(max_connect_errors 10)],
advice => [qw(max_connect_errors)],
},
{ name => "max_connections",
vars => [qw(max_connections 1001)],
advice => [qw(max_connections)],
},
{ name => "myisam_repair_threads",
vars => [qw(myisam_repair_threads 2)],
advice => [qw(myisam_repair_threads)],
},
{ name => "old passwords",
vars => [qw(old_passwords ON)],
advice => [qw(old_passwords)],
},
{ name => "optimizer_prune_level",
vars => [qw(optimizer_prune_level 0)],
advice => [qw(optimizer_prune_level)],
},
{ name => "port",
vars => [qw(port 12345)],
advice => [qw(port)],
},
{ name => "query_cache_size-1",
vars => [qw(query_cache_size 134217729)],
advice => [qw(query_cache_size-1)],
},
{ name => "query_cache_size-2",
vars => [qw(query_cache_size 536870913)],
advice => [qw(query_cache_size-1 query_cache_size-2)],
},
{ name => "read_buffer_size-1",
vars => [qw(read_buffer_size 130000)],
advice => [qw(read_buffer_size-1)],
},
{ name => "read_buffer_size-2",
vars => [qw(read_buffer_size 8500000)],
advice => [qw(read_buffer_size-1 read_buffer_size-2)],
},
{ name => "read_rnd_buffer_size-1",
vars => [qw(read_rnd_buffer_size 262000)],
advice => [qw(read_rnd_buffer_size-1)],
},
{ name => "read_rnd_buffer_size-2",
vars => [qw(read_rnd_buffer_size 7000000)],
advice => [qw(read_rnd_buffer_size-1 read_rnd_buffer_size-2)],
},
{ name => "relay_log_space_limit",
vars => [qw(relay_log_space_limit 1)],
advice => [qw(relay_log_space_limit)],
},
{ name => "slave net timeout",
vars => [qw(slave_net_timeout 61)],
advice => [qw(slave_net_timeout)],
},
{ name => "slave skip errors",
vars => [qw(slave_skip_errors 1024)],
advice => [qw(slave_skip_errors)],
},
{ name => "slave skip errors",
vars => [qw(slave_skip_errors OFF)],
advice => [],
},
{ name => "sort_buffer_size-1",
vars => [qw(sort_buffer_size 2097140)],
advice => [qw(sort_buffer_size-1)],
},
{ name => "sort_buffer_size-2",
vars => [qw(sort_buffer_size 5000000)],
advice => [qw(sort_buffer_size-1 sort_buffer_size-2)],
},
{ name => "sql notes",
vars => [qw(sql_notes OFF)],
advice => [qw(sql_notes)],
},
{ name => "sync_frm",
vars => [qw(sync_frm OFF)],
advice => [qw(sync_frm)],
},
{ name => "tx_isolation-1",
vars => [qw(tx_isolation foo)],
advice => [qw(tx_isolation-1 tx_isolation-2)],
},
{ name => "expire_logs_days",
vars => [qw(expire_logs_days 0 log_bin ON)],
advice => [qw(expire_logs_days)],
},
{ name => "expire_logs_days, log_bin OFF, only warns about log_bin",
vars => [qw(expire_logs_days 0 log_bin OFF)],
advice => [qw(log_bin)],
},
{ name => "innodb_file_io_threads",
vars => [qw(innodb_file_io_threads 16)],
advice => [qw(innodb_file_io_threads)],
},
{ name => "innodb_data_file_path",
vars => [qw(innodb_data_file_path ibdata1:10M:autoextend)],
advice => [qw(innodb_data_file_path)],
},
{ name => "innodb_flush_method",
vars => [qw(innodb_flush_method O_DSYNC)],
advice => [qw(innodb_flush_method)],
},
{ name => "innodb_locks_unsafe_for_binlog",
vars => [qw(innodb_locks_unsafe_for_binlog ON log_bin ON)],
advice => [qw(innodb_locks_unsafe_for_binlog)],
},
{ name => "innodb_locks_unsafe_for_binlog, log_bin off, only warns about log_bin",
vars => [qw(innodb_locks_unsafe_for_binlog ON log_bin OFF)],
advice => [qw(log_bin)],
},
{ name => "innodb_support_xa",
vars => [qw(innodb_support_xa OFF log_bin ON)],
advice => [qw(innodb_support_xa)],
},
{ name => "innodb_support_xa, log_bin OFF, only warns about log_bin",
vars => [qw(innodb_support_xa OFF log_bin OFF)],
advice => [qw(log_bin)],
},
{ name => "log_bin ON",
vars => [qw(log_bin ON)],
advice => [qw()],
},
{ name => "log_bin OFF",
vars => [qw(log_bin OFF)],
advice => [qw(log_bin)],
},
{ name => "log_output",
vars => ['log_output', 'FILE,TABLE'],
advice => [qw(log_output)],
},
{ name => "max_relay_log_size",
vars => [qw(max_relay_log_size 500000000)],
advice => [qw(max_relay_log_size)],
},
{ name => "myisam_recover_options OFF",
vars => [qw(myisam_recover_options OFF)],
advice => [qw(myisam_recover_options)],
},
{ name => "myisam_recover_options DEFAULT",
vars => [qw(myisam_recover_options DEFAULT)],
advice => [qw(myisam_recover_options)],
},
{ name => "storage_engine MyISAM",
vars => [qw(storage_engine MyISAM)],
advice => [qw()],
},
{ name => "storage_engine",
vars => ['storage_engine', 'foo,bar'],
advice => [qw(storage_engine)],
},
{ name => "sync_binlog 0",
vars => [qw(sync_binlog 0 log_bin ON)],
advice => [qw(sync_binlog)],
},
{ name => "sync_binlog 2",
vars => [qw(sync_binlog 2 log_bin ON)],
advice => [qw(sync_binlog)],
},
{ name => "log_bin OFF, sync_binlog 0, doesn't warn about sync_binlog",
vars => [qw(sync_binlog 0 log_bin OFF)],
advice => [qw(log_bin)],
},
{ name => "tmp_table_size",
vars => [qw(tmp_table_size 1024 max_heap_table_size 512)],
advice => [qw(tmp_table_size)],
},
{ name => "end-of-life mysql version",
mysql_version => VersionParser->new('5.0.87'),
advice => ['end-of-life mysql version'],
},
{ name => "old mysql version 3.22.00",
mysql_version => VersionParser->new('3.22.00'),
advice => ['old mysql version', 'end-of-life mysql version'],
},
{ name => "old mysql version 4.1.1",
mysql_version => VersionParser->new('4.1.1'),
advice => ['old mysql version', 'end-of-life mysql version'],
},
{ name => "old mysql version 5.0.36",
mysql_version => VersionParser->new('5.0.36'),
advice => ['old mysql version', 'end-of-life mysql version'],
},
{ name => "old mysql version 5.1.29",
mysql_version => VersionParser->new('5.1.29'),
advice => ['old mysql version'],
},
{ name => "old mysql version 5.5.0",
mysql_version => VersionParser->new('5.5.0'),
advice => [],
},
);
my $adv = new Advisor(match_type => "bool");
$adv->load_rules($var);
foreach my $test ( @cases ) {
my %vars = $test->{vars} ? @{$test->{vars}} : ();
my ($ids) = $adv->run_rules(
variables => \%vars,
%$test,
);
is_deeply(
$ids,
$test->{advice},
$test->{name},
);
# To help me debug.
die if $test->{stop};
}
# #############################################################################
# Done.
# #############################################################################
my $output = '';
{
local *STDERR;
open STDERR, '>', \$output;
$p->_d('Complete test coverage');
}
like(
$output,
qr/Complete test coverage/,
'_d() works'
);
done_testing;
|