1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373
|
#!./perl -T
#
# Taint tests by Tom Phoenix <rootbeer@teleport.com>.
#
# I don't claim to know all about tainting. If anyone sees
# tests that I've missed here, please add them. But this is
# better than having no tests at all, right?
#
BEGIN {
chdir 't' if -d 't';
@INC = '../lib';
}
use strict;
use Config;
use File::Spec::Functions;
BEGIN { require './test.pl'; }
plan tests => 306;
$| = 1;
use vars qw($ipcsysv); # did we manage to load IPC::SysV?
my ($old_env_path, $old_env_dcl_path, $old_env_term);
BEGIN {
$old_env_path = $ENV{'PATH'};
$old_env_dcl_path = $ENV{'DCL$PATH'};
$old_env_term = $ENV{'TERM'};
if ($^O eq 'VMS' && !defined($Config{d_setenv})) {
$ENV{PATH} = $ENV{PATH};
$ENV{TERM} = $ENV{TERM} ne ''? $ENV{TERM} : 'dummy';
}
if ($Config{'extensions'} =~ /\bIPC\/SysV\b/
&& ($Config{d_shm} || $Config{d_msg})) {
eval { require IPC::SysV };
unless ($@) {
$ipcsysv++;
IPC::SysV->import(qw(IPC_PRIVATE IPC_RMID IPC_CREAT S_IRWXU IPC_NOWAIT));
}
}
}
my $Is_MacOS = $^O eq 'MacOS';
my $Is_VMS = $^O eq 'VMS';
my $Is_MSWin32 = $^O eq 'MSWin32';
my $Is_NetWare = $^O eq 'NetWare';
my $Is_Dos = $^O eq 'dos';
my $Is_Cygwin = $^O eq 'cygwin';
my $Is_OpenBSD = $^O eq 'openbsd';
my $Invoke_Perl = $Is_VMS ? 'MCR Sys$Disk:[]Perl.exe' :
$Is_MSWin32 ? '.\perl' :
$Is_MacOS ? ':perl' :
$Is_NetWare ? 'perl' :
'./perl' ;
my @MoreEnv = qw/IFS CDPATH ENV BASH_ENV/;
if ($Is_VMS) {
my (%old, $x);
for $x ('DCL$PATH', @MoreEnv) {
($old{$x}) = $ENV{$x} =~ /^(.*)$/ if exists $ENV{$x};
}
# VMS note: PATH and TERM are automatically created by the C
# library in VMS on reference to the their keys in %ENV.
# There is currently no way to determine if they did not exist
# before this test was run.
eval <<EndOfCleanup;
END {
\$ENV{PATH} = \$old_env_path;
warn "# Note: logical name 'PATH' may have been created\n";
\$ENV{'TERM'} = \$old_env_term;
warn "# Note: logical name 'TERM' may have been created\n";
\@ENV{keys %old} = values %old;
if (defined \$old_env_dcl_path) {
\$ENV{'DCL\$PATH'} = \$old_env_dcl_path;
} else {
delete \$ENV{'DCL\$PATH'};
}
}
EndOfCleanup
}
# Sources of taint:
# The empty tainted value, for tainting strings
my $TAINT = substr($^X, 0, 0);
# A tainted zero, useful for tainting numbers
my $TAINT0;
{
no warnings;
$TAINT0 = 0 + $TAINT;
}
# This taints each argument passed. All must be lvalues.
# Side effect: It also stringifies them. :-(
sub taint_these (@) {
for (@_) { $_ .= $TAINT }
}
# How to identify taint when you see it
sub any_tainted (@) {
not eval { join("",@_), kill 0; 1 };
}
sub tainted ($) {
any_tainted @_;
}
sub all_tainted (@) {
for (@_) { return 0 unless tainted $_ }
1;
}
sub test ($;$) {
my($ok, $diag) = @_;
my $curr_test = curr_test();
if ($ok) {
print "ok $curr_test\n";
} else {
print "not ok $curr_test\n";
printf "# Failed test at line %d\n", (caller)[2];
for (split m/^/m, $diag) {
print "# $_";
}
print "\n" unless
$diag eq ''
or substr($diag, -1) eq "\n";
}
next_test();
return $ok;
}
# We need an external program to call.
my $ECHO = ($Is_MSWin32 ? ".\\echo$$" : $Is_MacOS ? ":echo$$" : ($Is_NetWare ? "echo$$" : "./echo$$"));
END { unlink $ECHO }
open PROG, "> $ECHO" or die "Can't create $ECHO: $!";
print PROG 'print "@ARGV\n"', "\n";
close PROG;
my $echo = "$Invoke_Perl $ECHO";
my $TEST = catfile(curdir(), 'TEST');
# First, let's make sure that Perl is checking the dangerous
# environment variables. Maybe they aren't set yet, so we'll
# taint them ourselves.
{
$ENV{'DCL$PATH'} = '' if $Is_VMS;
if ($Is_MSWin32 && $Config{ccname} =~ /bcc32/ && ! -f 'cc3250mt.dll') {
my $bcc_dir;
foreach my $dir (split /$Config{path_sep}/, $ENV{PATH}) {
if (-f "$dir/cc3250mt.dll") {
$bcc_dir = $dir and last;
}
}
if (defined $bcc_dir) {
require File::Copy;
File::Copy::copy("$bcc_dir/cc3250mt.dll", '.') or
die "$0: failed to copy cc3250mt.dll: $!\n";
eval q{
END { unlink "cc3250mt.dll" }
};
}
}
$ENV{PATH} = ($Is_Cygwin) ? '/usr/bin' : '';
delete @ENV{@MoreEnv};
$ENV{TERM} = 'dumb';
test eval { `$echo 1` } eq "1\n";
SKIP: {
skip "Environment tainting tests skipped", 4
if $Is_MSWin32 || $Is_NetWare || $Is_VMS || $Is_Dos || $Is_MacOS;
my @vars = ('PATH', @MoreEnv);
while (my $v = $vars[0]) {
local $ENV{$v} = $TAINT;
last if eval { `$echo 1` };
last unless $@ =~ /^Insecure \$ENV{$v}/;
shift @vars;
}
test !@vars, "@vars";
# tainted $TERM is unsafe only if it contains metachars
local $ENV{TERM};
$ENV{TERM} = 'e=mc2';
test eval { `$echo 1` } eq "1\n";
$ENV{TERM} = 'e=mc2' . $TAINT;
test !eval { `$echo 1` };
test $@ =~ /^Insecure \$ENV{TERM}/, $@;
}
my $tmp;
if ($^O eq 'os2' || $^O eq 'amigaos' || $Is_MSWin32 || $Is_NetWare || $Is_Dos) {
print "# all directories are writeable\n";
}
else {
$tmp = (grep { defined and -d and (stat _)[2] & 2 }
qw(sys$scratch /tmp /var/tmp /usr/tmp),
@ENV{qw(TMP TEMP)})[0]
or print "# can't find world-writeable directory to test PATH\n";
}
SKIP: {
skip "all directories are writeable", 2 unless $tmp;
local $ENV{PATH} = $tmp;
test !eval { `$echo 1` };
test $@ =~ /^Insecure directory in \$ENV{PATH}/, $@;
}
SKIP: {
skip "This is not VMS", 4 unless $Is_VMS;
$ENV{'DCL$PATH'} = $TAINT;
test eval { `$echo 1` } eq '';
test $@ =~ /^Insecure \$ENV{DCL\$PATH}/, $@;
SKIP: {
skip q[can't find world-writeable directory to test DCL$PATH], 2
unless $tmp;
$ENV{'DCL$PATH'} = $tmp;
test eval { `$echo 1` } eq '';
test $@ =~ /^Insecure directory in \$ENV{DCL\$PATH}/, $@;
}
$ENV{'DCL$PATH'} = '';
}
}
# Let's see that we can taint and untaint as needed.
{
my $foo = $TAINT;
test tainted $foo;
# That was a sanity check. If it failed, stop the insanity!
die "Taint checks don't seem to be enabled" unless tainted $foo;
$foo = "foo";
test not tainted $foo;
taint_these($foo);
test tainted $foo;
my @list = 1..10;
test not any_tainted @list;
taint_these @list[1,3,5,7,9];
test any_tainted @list;
test all_tainted @list[1,3,5,7,9];
test not any_tainted @list[0,2,4,6,8];
($foo) = $foo =~ /(.+)/;
test not tainted $foo;
$foo = $1 if ('bar' . $TAINT) =~ /(.+)/;
test not tainted $foo;
test $foo eq 'bar';
{
use re 'taint';
($foo) = ('bar' . $TAINT) =~ /(.+)/;
test tainted $foo;
test $foo eq 'bar';
$foo = $1 if ('bar' . $TAINT) =~ /(.+)/;
test tainted $foo;
test $foo eq 'bar';
}
$foo = $1 if 'bar' =~ /(.+)$TAINT/;
test tainted $foo;
test $foo eq 'bar';
my $pi = 4 * atan2(1,1) + $TAINT0;
test tainted $pi;
($pi) = $pi =~ /(\d+\.\d+)/;
test not tainted $pi;
test sprintf("%.5f", $pi) eq '3.14159';
}
# How about command-line arguments? The problem is that we don't
# always get some, so we'll run another process with some.
SKIP: {
my $arg = tempfile();
open PROG, "> $arg" or die "Can't create $arg: $!";
print PROG q{
eval { join('', @ARGV), kill 0 };
exit 0 if $@ =~ /^Insecure dependency/;
print "# Oops: \$@ was [$@]\n";
exit 1;
};
close PROG;
print `$Invoke_Perl "-T" $arg and some suspect arguments`;
test !$?, "Exited with status $?";
unlink $arg;
}
# Reading from a file should be tainted
{
test open(FILE, $TEST), "Couldn't open '$TEST': $!";
my $block;
sysread(FILE, $block, 100);
my $line = <FILE>;
close FILE;
test tainted $block;
test tainted $line;
}
# Globs should be forbidden, except under VMS,
# which doesn't spawn an external program.
SKIP: {
skip "globs should be forbidden", 2 if 1 or $Is_VMS;
my @globs = eval { <*> };
test @globs == 0 && $@ =~ /^Insecure dependency/;
@globs = eval { glob '*' };
test @globs == 0 && $@ =~ /^Insecure dependency/;
}
# Output of commands should be tainted
{
my $foo = `$echo abc`;
test tainted $foo;
}
# Certain system variables should be tainted
{
test all_tainted $^X, $0;
}
# Results of matching should all be untainted
{
my $foo = "abcdefghi" . $TAINT;
test tainted $foo;
$foo =~ /def/;
test not any_tainted $`, $&, $';
$foo =~ /(...)(...)(...)/;
test not any_tainted $1, $2, $3, $+;
my @bar = $foo =~ /(...)(...)(...)/;
test not any_tainted @bar;
test tainted $foo; # $foo should still be tainted!
test $foo eq "abcdefghi";
}
# Operations which affect files can't use tainted data.
{
test !eval { chmod 0, $TAINT }, 'chmod';
test $@ =~ /^Insecure dependency/, $@;
# There is no feature test in $Config{} for truncate,
# so we allow for the possibility that it's missing.
test !eval { truncate 'NoSuChFiLe', $TAINT0 }, 'truncate';
test $@ =~ /^(?:Insecure dependency|truncate not implemented)/, $@;
test !eval { rename '', $TAINT }, 'rename';
test $@ =~ /^Insecure dependency/, $@;
test !eval { unlink $TAINT }, 'unlink';
test $@ =~ /^Insecure dependency/, $@;
test !eval { utime $TAINT }, 'utime';
test $@ =~ /^Insecure dependency/, $@;
SKIP: {
skip "chown() is not available", 2 unless $Config{d_chown};
test !eval { chown -1, -1, $TAINT }, 'chown';
test $@ =~ /^Insecure dependency/, $@;
}
SKIP: {
skip "link() is not available", 2 unless $Config{d_link};
test !eval { link $TAINT, '' }, 'link';
test $@ =~ /^Insecure dependency/, $@;
}
SKIP: {
skip "symlink() is not available", 2 unless $Config{d_symlink};
test !eval { symlink $TAINT, '' }, 'symlink';
test $@ =~ /^Insecure dependency/, $@;
}
}
# Operations which affect directories can't use tainted data.
{
test !eval { mkdir "foo".$TAINT, 0755.$TAINT0 }, 'mkdir';
test $@ =~ /^Insecure dependency/, $@;
test !eval { rmdir $TAINT }, 'rmdir';
test $@ =~ /^Insecure dependency/, $@;
test !eval { chdir "foo".$TAINT }, 'chdir';
test $@ =~ /^Insecure dependency/, $@;
SKIP: {
skip "chroot() is not available", 2 unless $Config{d_chroot};
test !eval { chroot $TAINT }, 'chroot';
test $@ =~ /^Insecure dependency/, $@;
}
}
# Some operations using files can't use tainted data.
{
my $foo = "imaginary library" . $TAINT;
test !eval { require $foo }, 'require';
test $@ =~ /^Insecure dependency/, $@;
my $filename = tempfile(); # NB: $filename isn't tainted!
$foo = $filename . $TAINT;
unlink $filename; # in any case
test !eval { open FOO, $foo }, 'open for read';
test $@ eq '', $@; # NB: This should be allowed
# Try first new style but allow also old style.
# We do not want the whole taint.t to fail
# just because Errno possibly failing.
test eval('$!{ENOENT}') ||
$! == 2 || # File not found
($Is_Dos && $! == 22) ||
($^O eq 'mint' && $! == 33);
test !eval { open FOO, "> $foo" }, 'open for write';
test $@ =~ /^Insecure dependency/, $@;
}
# Commands to the system can't use tainted data
{
my $foo = $TAINT;
SKIP: {
skip "open('|') is not available", 4 if $^O eq 'amigaos';
test !eval { open FOO, "| x$foo" }, 'popen to';
test $@ =~ /^Insecure dependency/, $@;
test !eval { open FOO, "x$foo |" }, 'popen from';
test $@ =~ /^Insecure dependency/, $@;
}
test !eval { exec $TAINT }, 'exec';
test $@ =~ /^Insecure dependency/, $@;
test !eval { system $TAINT }, 'system';
test $@ =~ /^Insecure dependency/, $@;
$foo = "*";
taint_these $foo;
test !eval { `$echo 1$foo` }, 'backticks';
test $@ =~ /^Insecure dependency/, $@;
SKIP: {
# wildcard expansion doesn't invoke shell on VMS, so is safe
skip "This is not VMS", 2 unless $Is_VMS;
test join('', eval { glob $foo } ) ne '', 'globbing';
test $@ eq '', $@;
}
}
# Operations which affect processes can't use tainted data.
{
test !eval { kill 0, $TAINT }, 'kill';
test $@ =~ /^Insecure dependency/, $@;
SKIP: {
skip "setpgrp() is not available", 2 unless $Config{d_setpgrp};
test !eval { setpgrp 0, $TAINT0 }, 'setpgrp';
test $@ =~ /^Insecure dependency/, $@;
}
SKIP: {
skip "setpriority() is not available", 2 unless $Config{d_setprior};
test !eval { setpriority 0, $TAINT0, $TAINT0 }, 'setpriority';
test $@ =~ /^Insecure dependency/, $@;
}
}
# Some miscellaneous operations can't use tainted data.
{
SKIP: {
skip "syscall() is not available", 2 unless $Config{d_syscall};
test !eval { syscall $TAINT }, 'syscall';
test $@ =~ /^Insecure dependency/, $@;
}
{
my $foo = "x" x 979;
taint_these $foo;
local *FOO;
my $temp = tempfile();
test open(FOO, "> $temp"), "Couldn't open $temp for write: $!";
test !eval { ioctl FOO, $TAINT0, $foo }, 'ioctl';
test $@ =~ /^Insecure dependency/, $@;
SKIP: {
skip "fcntl() is not available", 2 unless $Config{d_fcntl};
test !eval { fcntl FOO, $TAINT0, $foo }, 'fcntl';
test $@ =~ /^Insecure dependency/, $@;
}
close FOO;
}
}
# Some tests involving references
{
my $foo = 'abc' . $TAINT;
my $fooref = \$foo;
test not tainted $fooref;
test tainted $$fooref;
test tainted $foo;
}
# Some tests involving assignment
{
my $foo = $TAINT0;
my $bar = $foo;
test all_tainted $foo, $bar;
test tainted($foo = $bar);
test tainted($bar = $bar);
test tainted($bar += $bar);
test tainted($bar -= $bar);
test tainted($bar *= $bar);
test tainted($bar++);
test tainted($bar /= $bar);
test tainted($bar += 0);
test tainted($bar -= 2);
test tainted($bar *= -1);
test tainted($bar /= 1);
test tainted($bar--);
test $bar == 0;
}
# Test assignment and return of lists
{
my @foo = ("A", "tainted" . $TAINT, "B");
test not tainted $foo[0];
test tainted $foo[1];
test not tainted $foo[2];
my @bar = @foo;
test not tainted $bar[0];
test tainted $bar[1];
test not tainted $bar[2];
my @baz = eval { "A", "tainted" . $TAINT, "B" };
test not tainted $baz[0];
test tainted $baz[1];
test not tainted $baz[2];
my @plugh = eval q[ "A", "tainted" . $TAINT, "B" ];
test not tainted $plugh[0];
test tainted $plugh[1];
test not tainted $plugh[2];
my $nautilus = sub { "A", "tainted" . $TAINT, "B" };
test not tainted ((&$nautilus)[0]);
test tainted ((&$nautilus)[1]);
test not tainted ((&$nautilus)[2]);
my @xyzzy = &$nautilus;
test not tainted $xyzzy[0];
test tainted $xyzzy[1];
test not tainted $xyzzy[2];
my $red_october = sub { return "A", "tainted" . $TAINT, "B" };
test not tainted ((&$red_october)[0]);
test tainted ((&$red_october)[1]);
test not tainted ((&$red_october)[2]);
my @corge = &$red_october;
test not tainted $corge[0];
test tainted $corge[1];
test not tainted $corge[2];
}
# Test for system/library calls returning string data of dubious origin.
{
# No reliable %Config check for getpw*
SKIP: {
skip "getpwent() is not available", 1 unless
eval { setpwent(); getpwent() };
setpwent();
my @getpwent = getpwent();
die "getpwent: $!\n" unless (@getpwent);
test ( not tainted $getpwent[0]
and tainted $getpwent[1]
and not tainted $getpwent[2]
and not tainted $getpwent[3]
and not tainted $getpwent[4]
and not tainted $getpwent[5]
and tainted $getpwent[6] # ge?cos
and not tainted $getpwent[7]
and tainted $getpwent[8]); # shell
endpwent();
}
SKIP: {
# pretty hard to imagine not
skip "readdir() is not available", 1 unless $Config{d_readdir};
local(*D);
opendir(D, "op") or die "opendir: $!\n";
my $readdir = readdir(D);
test tainted $readdir;
closedir(D);
}
SKIP: {
skip "readlink() or symlink() is not available" unless
$Config{d_readlink} && $Config{d_symlink};
my $symlink = "sl$$";
unlink($symlink);
my $sl = "/something/naughty";
# it has to be a real path on Mac OS
$sl = MacPerl::MakePath((MacPerl::Volumes())[0]) if $Is_MacOS;
symlink($sl, $symlink) or die "symlink: $!\n";
my $readlink = readlink($symlink);
test tainted $readlink;
unlink($symlink);
}
}
# test bitwise ops (regression bug)
{
my $why = "y";
my $j = "x" | $why;
test not tainted $j;
$why = $TAINT."y";
$j = "x" | $why;
test tainted $j;
}
# test target of substitution (regression bug)
{
my $why = $TAINT."y";
$why =~ s/y/z/;
test tainted $why;
my $z = "[z]";
$why =~ s/$z/zee/;
test tainted $why;
$why =~ s/e/'-'.$$/ge;
test tainted $why;
}
SKIP: {
skip "no IPC::SysV", 2 unless $ipcsysv;
# test shmread
SKIP: {
skip "shm*() not available", 1 unless $Config{d_shm};
no strict 'subs';
my $sent = "foobar";
my $rcvd;
my $size = 2000;
my $id = shmget(IPC_PRIVATE, $size, S_IRWXU);
if (defined $id) {
if (shmwrite($id, $sent, 0, 60)) {
if (shmread($id, $rcvd, 0, 60)) {
substr($rcvd, index($rcvd, "\0")) = '';
} else {
warn "# shmread failed: $!\n";
}
} else {
warn "# shmwrite failed: $!\n";
}
shmctl($id, IPC_RMID, 0) or warn "# shmctl failed: $!\n";
} else {
warn "# shmget failed: $!\n";
}
skip "SysV shared memory operation failed", 1 unless
$rcvd eq $sent;
test tainted $rcvd;
}
# test msgrcv
SKIP: {
skip "msg*() not available", 1 unless $Config{d_msg};
no strict 'subs';
my $id = msgget(IPC_PRIVATE, IPC_CREAT | S_IRWXU);
my $sent = "message";
my $type_sent = 1234;
my $rcvd;
my $type_rcvd;
if (defined $id) {
if (msgsnd($id, pack("l! a*", $type_sent, $sent), IPC_NOWAIT)) {
if (msgrcv($id, $rcvd, 60, 0, IPC_NOWAIT)) {
($type_rcvd, $rcvd) = unpack("l! a*", $rcvd);
} else {
warn "# msgrcv failed: $!\n";
}
} else {
warn "# msgsnd failed: $!\n";
}
msgctl($id, IPC_RMID, 0) or warn "# msgctl failed: $!\n";
} else {
warn "# msgget failed\n";
}
SKIP: {
skip "SysV message queue operation failed", 1
unless $rcvd eq $sent && $type_sent == $type_rcvd;
test tainted $rcvd;
}
}
}
{
# bug id 20001004.006
open IN, $TEST or warn "$0: cannot read $TEST: $!" ;
local $/;
my $a = <IN>;
my $b = <IN>;
ok tainted($a) && tainted($b) && !defined($b);
close IN;
}
{
# bug id 20001004.007
open IN, $TEST or warn "$0: cannot read $TEST: $!" ;
my $a = <IN>;
my $c = { a => 42,
b => $a };
ok !tainted($c->{a}) && tainted($c->{b});
my $d = { a => $a,
b => 42 };
ok tainted($d->{a}) && !tainted($d->{b});
my $e = { a => 42,
b => { c => $a, d => 42 } };
ok !tainted($e->{a}) &&
!tainted($e->{b}) &&
tainted($e->{b}->{c}) &&
!tainted($e->{b}->{d});
close IN;
}
{
# bug id 20010519.003
BEGIN {
use vars qw($has_fcntl);
eval { require Fcntl; import Fcntl; };
unless ($@) {
$has_fcntl = 1;
}
}
SKIP: {
skip "no Fcntl", 18 unless $has_fcntl;
my $evil = "foo" . $TAINT;
eval { sysopen(my $ro, $evil, &O_RDONLY) };
test $@ !~ /^Insecure dependency/, $@;
eval { sysopen(my $wo, $evil, &O_WRONLY) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $rw, $evil, &O_RDWR) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $ap, $evil, &O_APPEND) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $cr, $evil, &O_CREAT) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $tr, $evil, &O_TRUNC) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $ro, "foo", &O_RDONLY | $TAINT0) };
test $@ !~ /^Insecure dependency/, $@;
eval { sysopen(my $wo, "foo", &O_WRONLY | $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $rw, "foo", &O_RDWR | $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $ap, "foo", &O_APPEND | $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $cr, "foo", &O_CREAT | $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $tr, "foo", &O_TRUNC | $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $ro, "foo", &O_RDONLY, $TAINT0) };
test $@ !~ /^Insecure dependency/, $@;
eval { sysopen(my $wo, "foo", &O_WRONLY, $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $rw, "foo", &O_RDWR, $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $ap, "foo", &O_APPEND, $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $cr, "foo", &O_CREAT, $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
eval { sysopen(my $tr, "foo", &O_TRUNC, $TAINT0) };
test $@ =~ /^Insecure dependency/, $@;
unlink("foo"); # not unlink($evil), because that would fail...
}
}
{
# bug 20010526.004
use warnings;
my $saw_warning = 0;
local $SIG{__WARN__} = sub { $saw_warning = 1 };
sub fmi {
my $divnum = shift()/1;
sprintf("%1.1f\n", $divnum);
}
fmi(21 . $TAINT);
fmi(37);
fmi(248);
test !$saw_warning;
}
{
# Bug ID 20010730.010
my $i = 0;
sub Tie::TIESCALAR {
my $class = shift;
my $arg = shift;
bless \$arg => $class;
}
sub Tie::FETCH {
$i ++;
${$_ [0]}
}
package main;
my $bar = "The Big Bright Green Pleasure Machine";
taint_these $bar;
tie my ($foo), Tie => $bar;
my $baz = $foo;
ok $i == 1;
}
{
# Check that all environment variables are tainted.
my @untainted;
while (my ($k, $v) = each %ENV) {
if (!tainted($v) &&
# These we have explicitly untainted or set earlier.
$k !~ /^(BASH_ENV|CDPATH|ENV|IFS|PATH|PERL_CORE|TEMP|TERM|TMP)$/) {
push @untainted, "# '$k' = '$v'\n";
}
}
test @untainted == 0, "untainted:\n @untainted";
}
ok( ${^TAINT} == 1, '$^TAINT is on' );
eval { ${^TAINT} = 0 };
ok( ${^TAINT}, '$^TAINT is not assignable' );
ok( $@ =~ /^Modification of a read-only value attempted/,
'Assigning to ${^TAINT} fails' );
{
# bug 20011111.105
my $re1 = qr/x$TAINT/;
test tainted $re1;
my $re2 = qr/^$re1\z/;
test tainted $re2;
my $re3 = "$re2";
test tainted $re3;
}
SKIP: {
skip "system {} has different semantics on Win32", 1 if $Is_MSWin32;
# bug 20010221.005
local $ENV{PATH} .= $TAINT;
eval { system { "echo" } "/arg0", "arg1" };
test $@ =~ /^Insecure \$ENV/;
}
TODO: {
todo_skip 'tainted %ENV warning occludes tainted arguments warning', 22
if $Is_VMS;
# bug 20020208.005 plus some single arg exec/system extras
my $err = qr/^Insecure dependency/ ;
test !eval { exec $TAINT, $TAINT }, 'exec';
test $@ =~ $err, $@;
test !eval { exec $TAINT $TAINT }, 'exec';
test $@ =~ $err, $@;
test !eval { exec $TAINT $TAINT, $TAINT }, 'exec';
test $@ =~ $err, $@;
test !eval { exec $TAINT 'notaint' }, 'exec';
test $@ =~ $err, $@;
test !eval { exec {'notaint'} $TAINT }, 'exec';
test $@ =~ $err, $@;
test !eval { system $TAINT, $TAINT }, 'system';
test $@ =~ $err, $@;
test !eval { system $TAINT $TAINT }, 'system';
test $@ =~ $err, $@;
test !eval { system $TAINT $TAINT, $TAINT }, 'system';
test $@ =~ $err, $@;
test !eval { system $TAINT 'notaint' }, 'system';
test $@ =~ $err, $@;
test !eval { system {'notaint'} $TAINT }, 'system';
test $@ =~ $err, $@;
eval {
no warnings;
system("lskdfj does not exist","with","args");
};
test !$@;
SKIP: {
skip "no exec() on MacOS Classic" if $Is_MacOS;
eval {
no warnings;
exec("lskdfj does not exist","with","args");
};
test !$@;
}
# If you add tests here update also the above skip block for VMS.
}
{
# [ID 20020704.001] taint propagation failure
use re 'taint';
$TAINT =~ /(.*)/;
test tainted(my $foo = $1);
}
{
# [perl #24291] this used to dump core
our %nonmagicalenv = ( PATH => "util" );
local *ENV = \%nonmagicalenv;
eval { system("lskdfj"); };
test $@ =~ /^%ENV is aliased to another variable while running with -T switch/;
local *ENV = *nonmagicalenv;
eval { system("lskdfj"); };
test $@ =~ /^%ENV is aliased to %nonmagicalenv while running with -T switch/;
}
{
# [perl #24248]
$TAINT =~ /(.*)/;
test !tainted($1);
my $notaint = $1;
test !tainted($notaint);
my $l;
$notaint =~ /($notaint)/;
$l = $1;
test !tainted($1);
test !tainted($l);
$notaint =~ /($TAINT)/;
$l = $1;
test tainted($1);
test tainted($l);
$TAINT =~ /($notaint)/;
$l = $1;
test !tainted($1);
test !tainted($l);
$TAINT =~ /($TAINT)/;
$l = $1;
test tainted($1);
test tainted($l);
my $r;
($r = $TAINT) =~ /($notaint)/;
test !tainted($1);
($r = $TAINT) =~ /($TAINT)/;
test tainted($1);
# [perl #24674]
# accessing $^O shoudn't taint it as a side-effect;
# assigning tainted data to it is now an error
test !tainted($^O);
if (!$^X) { } elsif ($^O eq 'bar') { }
test !tainted($^O);
eval '$^O = $^X';
test $@ =~ /Insecure dependency in/;
}
EFFECTIVELY_CONSTANTS: {
my $tainted_number = 12 + $TAINT0;
test tainted( $tainted_number );
# Even though it's always 0, it's still tainted
my $tainted_product = $tainted_number * 0;
test tainted( $tainted_product );
test $tainted_product == 0;
}
TERNARY_CONDITIONALS: {
my $tainted_true = $TAINT . "blah blah blah";
my $tainted_false = $TAINT0;
test tainted( $tainted_true );
test tainted( $tainted_false );
my $result = $tainted_true ? "True" : "False";
test $result eq "True";
test !tainted( $result );
$result = $tainted_false ? "True" : "False";
test $result eq "False";
test !tainted( $result );
my $untainted_whatever = "The Fabulous Johnny Cash";
my $tainted_whatever = "Soft Cell" . $TAINT;
$result = $tainted_true ? $tainted_whatever : $untainted_whatever;
test $result eq "Soft Cell";
test tainted( $result );
$result = $tainted_false ? $tainted_whatever : $untainted_whatever;
test $result eq "The Fabulous Johnny Cash";
test !tainted( $result );
}
{
# rt.perl.org 5900 $1 remains tainted if...
# 1) The regular expression contains a scalar variable AND
# 2) The regular expression appears in an elsif clause
my $foo = "abcdefghi" . $TAINT;
my $valid_chars = 'a-z';
if ( $foo eq '' ) {
}
elsif ( $foo =~ /([$valid_chars]+)/o ) {
test not tainted $1;
}
if ( $foo eq '' ) {
}
elsif ( my @bar = $foo =~ /([$valid_chars]+)/o ) {
test not any_tainted @bar;
}
}
# at scope exit, a restored localised value should have its old
# taint status, not the taint status of the current statement
{
our $x99 = $^X;
test tainted $x99;
$x99 = '';
test not tainted $x99;
my $c = do { local $x99; $^X };
test not tainted $x99;
}
{
our $x99 = $^X;
test tainted $x99;
my $c = do { local $x99; '' };
test tainted $x99;
}
# an mg_get of a tainted value during localization shouldn't taint the
# statement
{
eval { local $0, eval '1' };
test $@ eq '';
}
# [perl #8262] //g loops infinitely on tainted data
{
my @a;
local $::TODO = 1;
$a[0] = $^X;
my $i = 0;
while($a[0]=~ m/(.)/g ) {
last if $i++ > 10000;
}
cmp_ok $i, '<', 10000, "infinite m//g";
}
SKIP:
{
my $got_dualvar;
eval 'use Scalar::Util "dualvar"; $got_dualvar++';
skip "No Scalar::Util::dualvar" unless $got_dualvar;
my $a = Scalar::Util::dualvar(3, $^X);
my $b = $a + 5;
is ($b, 8, "Arithmetic on tainted dualvars works");
}
# opening '|-' should not trigger $ENV{PATH} check
{
SKIP: {
skip "fork() is not available", 3 unless $Config{'d_fork'};
skip "opening |- is not stable on threaded OpenBSD with taint", 3
if $Config{useithreads} && $Is_OpenBSD;
$ENV{'PATH'} = $TAINT;
local $SIG{'PIPE'} = 'IGNORE';
eval {
my $pid = open my $pipe, '|-';
if (!defined $pid) {
die "open failed: $!";
}
if (!$pid) {
kill 'KILL', $$; # child suicide
}
close $pipe;
};
test $@ !~ /Insecure \$ENV/, 'fork triggers %ENV check';
test $@ eq '', 'pipe/fork/open/close failed';
eval {
open my $pipe, "|$Invoke_Perl -e 1";
close $pipe;
};
test $@ =~ /Insecure \$ENV/, 'popen neglects %ENV check';
}
}
{
package AUTOLOAD_TAINT;
sub AUTOLOAD {
our $AUTOLOAD;
return if $AUTOLOAD =~ /DESTROY/;
if ($AUTOLOAD =~ /untainted/) {
main::ok(!main::tainted($AUTOLOAD), '$AUTOLOAD can be untainted');
} else {
main::ok(main::tainted($AUTOLOAD), '$AUTOLOAD can be tainted');
}
}
package main;
my $o = bless [], 'AUTOLOAD_TAINT';
$o->$TAINT;
$o->untainted;
}
{
# tests for tainted format in s?printf
eval { printf($TAINT . "# %s\n", "foo") };
like($@, qr/^Insecure dependency in printf/, q/printf doesn't like tainted formats/);
eval { printf("# %s\n", $TAINT . "foo") };
ok(!$@, q/printf accepts other tainted args/);
eval { sprintf($TAINT . "# %s\n", "foo") };
like($@, qr/^Insecure dependency in sprintf/, q/sprintf doesn't like tainted formats/);
eval { sprintf("# %s\n", $TAINT . "foo") };
ok(!$@, q/sprintf accepts other tainted args/);
}
{
# 40708
my $n = 7e9;
8e9 - $n;
my $val = $n;
is ($val, '7000000000', 'Assignment to untainted variable');
$val = $TAINT;
$val = $n;
is ($val, '7000000000', 'Assignment to tainted variable');
}
{
my $val = 0;
my $tainted = '1' . $TAINT;
eval '$val = eval $tainted;';
is ($val, 0, "eval doesn't like tainted strings");
like ($@, qr/^Insecure dependency in eval/);
# Rather nice code to get a tainted undef by from Rick Delaney
open FH, "test.pl" or die $!;
seek FH, 0, 2 or die $!;
$tainted = <FH>;
eval 'eval $tainted';
like ($@, qr/^Insecure dependency in eval/);
}
foreach my $ord (78, 163, 256) {
# 47195
my $line = 'A1' . $TAINT . chr $ord;
chop $line;
is($line, 'A1');
$line =~ /(A\S*)/;
ok(!tainted($1), "\\S match with chr $ord");
}
{
# 59998
sub cr { my $x = crypt($_[0], $_[1]); $x }
sub co { my $x = ~$_[0]; $x }
my ($a, $b);
$a = cr('hello', 'foo' . $TAINT);
$b = cr('hello', 'foo');
ok(tainted($a), "tainted crypt");
ok(!tainted($b), "untainted crypt");
$a = co('foo' . $TAINT);
$b = co('foo');
ok(tainted($a), "tainted complement");
ok(!tainted($b), "untainted complement");
}
{
my @data = qw(bonk zam zlonk qunckkk);
# Clearly some sort of usenet bang-path
my $string = $TAINT . join "!", @data;
ok(tainted($string), "tainted data");
my @got = split /!|,/, $string;
# each @got would be useful here, but I want the test for earlier perls
for my $i (0 .. $#data) {
ok(tainted($got[$i]), "tainted result $i");
is($got[$i], $data[$i], "correct content $i");
}
ok(tainted($string), "still tainted data");
my @got = split /[!,]/, $string;
# each @got would be useful here, but I want the test for earlier perls
for my $i (0 .. $#data) {
ok(tainted($got[$i]), "tainted result $i");
is($got[$i], $data[$i], "correct content $i");
}
ok(tainted($string), "still tainted data");
my @got = split /!/, $string;
# each @got would be useful here, but I want the test for earlier perls
for my $i (0 .. $#data) {
ok(tainted($got[$i]), "tainted result $i");
is($got[$i], $data[$i], "correct content $i");
}
}
# Bug RT #52552 - broken by change at git commit id f337b08
{
my $x = $TAINT. q{print "Hello world\n"};
my $y = pack "a*", $x;
ok(tainted($y), "pack a* preserves tainting");
my $z = pack "A*", q{print "Hello world\n"}.$TAINT;
ok(tainted($z), "pack A* preserves tainting");
my $zz = pack "a*a*", q{print "Hello world\n"}, $TAINT;
ok(tainted($zz), "pack a*a* preserves tainting");
}
# Bug RT #61976 tainted $! would show numeric rather than string value
{
my $tainted_path = substr($^X,0,0) . "/no/such/file";
my $err;
# $! is used in a tainted expression, so gets tainted
open my $fh, $tainted_path or $err= "$!";
unlike($err, qr/^\d+$/, 'tainted $!');
}
{
# [perl #87336] lc/uc(first) failing to taint the returned string
my $source = "foo$TAINT";
my $dest = lc $source;
test tainted $dest, "lc(tainted) taints its return value";
$dest = lcfirst $source;
test tainted $dest, "lcfirst(tainted) taints its return value";
$dest = uc $source;
test tainted $dest, "uc(tainted) taints its return value";
$dest = ucfirst $source;
test tainted $dest, "ucfirst(tainted) taints its return value";
}
# This may bomb out with the alarm signal so keep it last
SKIP: {
skip "No alarm()" unless $Config{d_alarm};
# Test from RT #41831]
# [PATCH] Bug & fix: hang when using study + taint mode (perl 5.6.1, 5.8.x)
my $DATA = <<'END' . $TAINT;
line1 is here
line2 is here
line3 is here
line4 is here
END
#study $DATA;
## don't set $SIG{ALRM}, since we'd never get to a user-level handler as
## perl is stuck in a regexp infinite loop!
alarm(10);
if ($DATA =~ /^line2.*line4/m) {
fail("Should not be a match")
} else {
pass("Match on tainted multiline data should fail promptly");
}
alarm(0);
}
__END__
# Keep the previous test last
|