1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
|
#!./perl
BEGIN {
chdir 't' if -d 't';
@INC = qw(. ../lib);
require 'test.pl';
}
use warnings;
plan( tests => 183 );
# these shouldn't hang
{
no warnings;
sort { for ($_ = 0;; $_++) {} } @a;
sort { while(1) {} } @a;
sort { while(1) { last; } } @a;
sort { while(0) { last; } } @a;
# Change 26011: Re: A surprising segfault
map scalar(sort(+())), ('')x68;
}
sub Backwards { $a lt $b ? 1 : $a gt $b ? -1 : 0 }
sub Backwards_stacked($$) { my($a,$b) = @_; $a lt $b ? 1 : $a gt $b ? -1 : 0 }
sub Backwards_other { $a lt $b ? 1 : $a gt $b ? -1 : 0 }
my $upperfirst = 'A' lt 'a';
# Beware: in future this may become hairier because of possible
# collation complications: qw(A a B b) can be sorted at least as
# any of the following
#
# A a B b
# A B a b
# a b A B
# a A b B
#
# All the above orders make sense.
#
# That said, EBCDIC sorts all small letters first, as opposed
# to ASCII which sorts all big letters first.
@harry = ('dog','cat','x','Cain','Abel');
@george = ('gone','chased','yz','punished','Axed');
$x = join('', sort @harry);
$expected = $upperfirst ? 'AbelCaincatdogx' : 'catdogxAbelCain';
cmp_ok($x,'eq',$expected,'upper first 1');
$x = join('', sort( Backwards @harry));
$expected = $upperfirst ? 'xdogcatCainAbel' : 'CainAbelxdogcat';
cmp_ok($x,'eq',$expected,'upper first 2');
$x = join('', sort( Backwards_stacked @harry));
$expected = $upperfirst ? 'xdogcatCainAbel' : 'CainAbelxdogcat';
cmp_ok($x,'eq',$expected,'upper first 3');
$x = join('', sort @george, 'to', @harry);
$expected = $upperfirst ?
'AbelAxedCaincatchaseddoggonepunishedtoxyz' :
'catchaseddoggonepunishedtoxyzAbelAxedCain' ;
cmp_ok($x,'eq',$expected,'upper first 4');
$" = ' ';
@a = ();
@b = reverse @a;
cmp_ok("@b",'eq',"",'reverse 1');
@a = (1);
@b = reverse @a;
cmp_ok("@b",'eq',"1",'reverse 2');
@a = (1,2);
@b = reverse @a;
cmp_ok("@b",'eq',"2 1",'reverse 3');
@a = (1,2,3);
@b = reverse @a;
cmp_ok("@b",'eq',"3 2 1",'reverse 4');
@a = (1,2,3,4);
@b = reverse @a;
cmp_ok("@b",'eq',"4 3 2 1",'reverse 5');
@a = (10,2,3,4);
@b = sort {$a <=> $b;} @a;
cmp_ok("@b",'eq',"2 3 4 10",'sort numeric');
$sub = 'Backwards';
$x = join('', sort $sub @harry);
$expected = $upperfirst ? 'xdogcatCainAbel' : 'CainAbelxdogcat';
cmp_ok($x,'eq',$expected,'sorter sub name in var 1');
$sub = 'Backwards_stacked';
$x = join('', sort $sub @harry);
$expected = $upperfirst ? 'xdogcatCainAbel' : 'CainAbelxdogcat';
cmp_ok($x,'eq',$expected,'sorter sub name in var 2');
# literals, combinations
@b = sort (4,1,3,2);
cmp_ok("@b",'eq','1 2 3 4','just sort');
@b = sort grep { $_ } (4,1,3,2);
cmp_ok("@b",'eq','1 2 3 4','grep then sort');
@b = sort map { $_ } (4,1,3,2);
cmp_ok("@b",'eq','1 2 3 4','map then sort');
@b = sort reverse (4,1,3,2);
cmp_ok("@b",'eq','1 2 3 4','reverse then sort');
@b = sort CORE::reverse (4,1,3,2);
cmp_ok("@b",'eq','1 2 3 4','CORE::reverse then sort');
eval { @b = sort CORE::revers (4,1,3,2); };
like($@, qr/^Undefined sort subroutine "CORE::revers" called at /);
sub twoface { no warnings 'redefine'; *twoface = sub { $a <=> $b }; &twoface }
eval { @b = sort twoface 4,1,3,2 };
cmp_ok("@b",'eq','1 2 3 4','redefine sort sub inside the sort sub');
eval { no warnings 'redefine'; *twoface = sub { &Backwards } };
ok(!$@,"redefining sort subs outside the sort \$@=[$@]");
eval { @b = sort twoface 4,1,3,2 };
cmp_ok("@b",'eq','4 3 2 1','twoface redefinition');
{
no warnings 'redefine';
*twoface = sub { *twoface = *Backwards_other; $a <=> $b };
}
eval { @b = sort twoface 4,1,9,5 };
ok(($@ eq "" && "@b" eq "1 4 5 9"),'redefinition should not take effect during the sort');
{
no warnings 'redefine';
*twoface = sub {
eval 'sub twoface { $a <=> $b }';
die($@ eq "" ? "good\n" : "bad\n");
$a <=> $b;
};
}
eval { @b = sort twoface 4,1 };
cmp_ok(substr($@,0,4), 'eq', 'good', 'twoface eval');
eval <<'CODE';
my @result = sort main'Backwards 'one', 'two';
CODE
cmp_ok($@,'eq','',q(old skool package));
eval <<'CODE';
# "sort 'one', 'two'" should not try to parse "'one" as a sort sub
my @result = sort 'one', 'two';
CODE
cmp_ok($@,'eq','',q(one is not a sub));
{
my $sortsub = \&Backwards;
my $sortglob = *Backwards;
my $sortglobr = \*Backwards;
my $sortname = 'Backwards';
@b = sort $sortsub 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 1');
@b = sort $sortglob 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 2');
@b = sort $sortname 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 3');
@b = sort $sortglobr 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 4');
}
{
my $sortsub = \&Backwards_stacked;
my $sortglob = *Backwards_stacked;
my $sortglobr = \*Backwards_stacked;
my $sortname = 'Backwards_stacked';
@b = sort $sortsub 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 5');
@b = sort $sortglob 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 6');
@b = sort $sortname 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 7');
@b = sort $sortglobr 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname 8');
}
{
local $sortsub = \&Backwards;
local $sortglob = *Backwards;
local $sortglobr = \*Backwards;
local $sortname = 'Backwards';
@b = sort $sortsub 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 1');
@b = sort $sortglob 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 2');
@b = sort $sortname 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 3');
@b = sort $sortglobr 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 4');
}
{
local $sortsub = \&Backwards_stacked;
local $sortglob = *Backwards_stacked;
local $sortglobr = \*Backwards_stacked;
local $sortname = 'Backwards_stacked';
@b = sort $sortsub 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 5');
@b = sort $sortglob 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 6');
@b = sort $sortname 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 7');
@b = sort $sortglobr 4,1,3,2;
cmp_ok("@b",'eq','4 3 2 1','sortname local 8');
}
## exercise sort builtins... ($a <=> $b already tested)
@a = ( 5, 19, 1996, 255, 90 );
@b = sort {
my $dummy; # force blockness
return $b <=> $a
} @a;
cmp_ok("@b",'eq','1996 255 90 19 5','force blockness');
$x = join('', sort { $a cmp $b } @harry);
$expected = $upperfirst ? 'AbelCaincatdogx' : 'catdogxAbelCain';
cmp_ok($x,'eq',$expected,'a cmp b');
$x = join('', sort { $b cmp $a } @harry);
$expected = $upperfirst ? 'xdogcatCainAbel' : 'CainAbelxdogcat';
cmp_ok($x,'eq',$expected,'b cmp a');
{
use integer;
@b = sort { $a <=> $b } @a;
cmp_ok("@b",'eq','5 19 90 255 1996','integer a <=> b');
@b = sort { $b <=> $a } @a;
cmp_ok("@b",'eq','1996 255 90 19 5','integer b <=> a');
$x = join('', sort { $a cmp $b } @harry);
$expected = $upperfirst ? 'AbelCaincatdogx' : 'catdogxAbelCain';
cmp_ok($x,'eq',$expected,'integer a cmp b');
$x = join('', sort { $b cmp $a } @harry);
$expected = $upperfirst ? 'xdogcatCainAbel' : 'CainAbelxdogcat';
cmp_ok($x,'eq',$expected,'integer b cmp a');
}
$x = join('', sort { $a <=> $b } 3, 1, 2);
cmp_ok($x,'eq','123',q(optimized-away comparison block doesn't take any other arguments away with it));
# test sorting in non-main package
{
package Foo;
@a = ( 5, 19, 1996, 255, 90 );
@b = sort { $b <=> $a } @a;
::cmp_ok("@b",'eq','1996 255 90 19 5','not in main:: 1');
@b = sort ::Backwards_stacked @a;
::cmp_ok("@b",'eq','90 5 255 1996 19','not in main:: 2');
# check if context for sort arguments is handled right
sub test_if_list {
my $gimme = wantarray;
::is($gimme,1,'wantarray 1');
}
my $m = sub { $a <=> $b };
sub cxt_one { sort $m test_if_list() }
cxt_one();
sub cxt_two { sort { $a <=> $b } test_if_list() }
cxt_two();
sub cxt_three { sort &test_if_list() }
cxt_three();
sub cxt_three_anna_half { sort 0, test_if_list() }
cxt_three_anna_half();
sub test_if_scalar {
my $gimme = wantarray;
::is(!($gimme or !defined($gimme)),1,'wantarray 2');
}
$m = \&test_if_scalar;
sub cxt_four { sort $m 1,2 }
@x = cxt_four();
sub cxt_five { sort { test_if_scalar($a,$b); } 1,2 }
@x = cxt_five();
sub cxt_six { sort test_if_scalar 1,2 }
@x = cxt_six();
}
# test against a reentrancy bug
{
package Bar;
sub compare { $a cmp $b }
sub reenter { my @force = sort compare qw/a b/ }
}
{
my($def, $init) = (0, 0);
@b = sort {
$def = 1 if defined $Bar::a;
Bar::reenter() unless $init++;
$a <=> $b
} qw/4 3 1 2/;
cmp_ok("@b",'eq','1 2 3 4','reenter 1');
ok(!$def,'reenter 2');
}
{
sub routine { "one", "two" };
@a = sort(routine(1));
cmp_ok("@a",'eq',"one two",'bug id 19991001.003');
}
# check for in-place optimisation of @a = sort @a
{
my ($r1,$r2,@a);
our @g;
@g = (3,2,1); $r1 = \$g[2]; @g = sort @g; $r2 = \$g[0];
is "$r1-@g", "$r2-1 2 3", "inplace sort of global";
@a = qw(b a c); $r1 = \$a[1]; @a = sort @a; $r2 = \$a[0];
is "$r1-@a", "$r2-a b c", "inplace sort of lexical";
@g = (2,3,1); $r1 = \$g[1]; @g = sort { $b <=> $a } @g; $r2 = \$g[0];
is "$r1-@g", "$r2-3 2 1", "inplace reversed sort of global";
@g = (2,3,1);
$r1 = \$g[1]; @g = sort { $a<$b?1:$a>$b?-1:0 } @g; $r2 = \$g[0];
is "$r1-@g", "$r2-3 2 1", "inplace custom sort of global";
sub mysort { $b cmp $a };
@a = qw(b c a); $r1 = \$a[1]; @a = sort mysort @a; $r2 = \$a[0];
is "$r1-@a", "$r2-c b a", "inplace sort with function of lexical";
use Tie::Array;
my @t;
tie @t, 'Tie::StdArray';
@t = qw(b c a); @t = sort @t;
is "@t", "a b c", "inplace sort of tied array";
@t = qw(b c a); @t = sort mysort @t;
is "@t", "c b a", "inplace sort of tied array with function";
# [perl #29790] don't optimise @a = ('a', sort @a) !
@g = (3,2,1); @g = ('0', sort @g);
is "@g", "0 1 2 3", "un-inplace sort of global";
@g = (3,2,1); @g = (sort(@g),'4');
is "@g", "1 2 3 4", "un-inplace sort of global 2";
@a = qw(b a c); @a = ('x', sort @a);
is "@a", "x a b c", "un-inplace sort of lexical";
@a = qw(b a c); @a = ((sort @a), 'x');
is "@a", "a b c x", "un-inplace sort of lexical 2";
@g = (2,3,1); @g = ('0', sort { $b <=> $a } @g);
is "@g", "0 3 2 1", "un-inplace reversed sort of global";
@g = (2,3,1); @g = ((sort { $b <=> $a } @g),'4');
is "@g", "3 2 1 4", "un-inplace reversed sort of global 2";
@g = (2,3,1); @g = ('0', sort { $a<$b?1:$a>$b?-1:0 } @g);
is "@g", "0 3 2 1", "un-inplace custom sort of global";
@g = (2,3,1); @g = ((sort { $a<$b?1:$a>$b?-1:0 } @g),'4');
is "@g", "3 2 1 4", "un-inplace custom sort of global 2";
@a = qw(b c a); @a = ('x', sort mysort @a);
is "@a", "x c b a", "un-inplace sort with function of lexical";
@a = qw(b c a); @a = ((sort mysort @a),'x');
is "@a", "c b a x", "un-inplace sort with function of lexical 2";
# RT#54758. Git 62b40d2474e7487e6909e1872b6bccdf812c6818
no warnings 'void';
my @m; push @m, 0 for 1 .. 1024; $#m; @m = sort @m;
::pass("in-place sorting segfault");
}
# Test optimisations of reversed sorts. As we now guarantee stability by
# default, # optimisations which do not provide this are bogus.
{
package Oscalar;
use overload (qw("" stringify 0+ numify fallback 1));
sub new {
bless [$_[1], $_[2]], $_[0];
}
sub stringify { $_[0]->[0] }
sub numify { $_[0]->[1] }
}
sub generate {
my $count = 0;
map {new Oscalar $_, $count++} qw(A A A B B B C C C);
}
my @input = &generate;
my @output = sort @input;
is join(" ", map {0+$_} @output), "0 1 2 3 4 5 6 7 8", "Simple stable sort";
@input = &generate;
@input = sort @input;
is join(" ", map {0+$_} @input), "0 1 2 3 4 5 6 7 8",
"Simple stable in place sort";
# This won't be very interesting
@input = &generate;
@output = sort {$a <=> $b} @input;
is "@output", "A A A B B B C C C", 'stable $a <=> $b sort';
@input = &generate;
@output = sort {$a cmp $b} @input;
is join(" ", map {0+$_} @output), "0 1 2 3 4 5 6 7 8", 'stable $a cmp $b sort';
@input = &generate;
@input = sort {$a cmp $b} @input;
is join(" ", map {0+$_} @input), "0 1 2 3 4 5 6 7 8",
'stable $a cmp $b in place sort';
@input = &generate;
@output = sort {$b cmp $a} @input;
is join(" ", map {0+$_} @output), "6 7 8 3 4 5 0 1 2", 'stable $b cmp $a sort';
@input = &generate;
@input = sort {$b cmp $a} @input;
is join(" ", map {0+$_} @input), "6 7 8 3 4 5 0 1 2",
'stable $b cmp $a in place sort';
@input = &generate;
@output = reverse sort @input;
is join(" ", map {0+$_} @output), "8 7 6 5 4 3 2 1 0", "Reversed stable sort";
@input = &generate;
@input = reverse sort @input;
is join(" ", map {0+$_} @input), "8 7 6 5 4 3 2 1 0",
"Reversed stable in place sort";
@input = &generate;
my $output = reverse sort @input;
is $output, "CCCBBBAAA", "Reversed stable sort in scalar context";
@input = &generate;
@output = reverse sort {$a cmp $b} @input;
is join(" ", map {0+$_} @output), "8 7 6 5 4 3 2 1 0",
'reversed stable $a cmp $b sort';
@input = &generate;
@input = reverse sort {$a cmp $b} @input;
is join(" ", map {0+$_} @input), "8 7 6 5 4 3 2 1 0",
'revesed stable $a cmp $b in place sort';
@input = &generate;
$output = reverse sort {$a cmp $b} @input;
is $output, "CCCBBBAAA", 'Reversed stable $a cmp $b sort in scalar context';
@input = &generate;
@output = reverse sort {$b cmp $a} @input;
is join(" ", map {0+$_} @output), "2 1 0 5 4 3 8 7 6",
'reversed stable $b cmp $a sort';
@input = &generate;
@input = reverse sort {$b cmp $a} @input;
is join(" ", map {0+$_} @input), "2 1 0 5 4 3 8 7 6",
'revesed stable $b cmp $a in place sort';
@input = &generate;
$output = reverse sort {$b cmp $a} @input;
is $output, "AAABBBCCC", 'Reversed stable $b cmp $a sort in scalar context';
sub stuff {
# Something complex enough to defeat any constant folding optimiser
$$ - $$;
}
@input = &generate;
@output = reverse sort {stuff || $a cmp $b} @input;
is join(" ", map {0+$_} @output), "8 7 6 5 4 3 2 1 0",
'reversed stable complex sort';
@input = &generate;
@input = reverse sort {stuff || $a cmp $b} @input;
is join(" ", map {0+$_} @input), "8 7 6 5 4 3 2 1 0",
'revesed stable complex in place sort';
@input = &generate;
$output = reverse sort {stuff || $a cmp $b } @input;
is $output, "CCCBBBAAA", 'Reversed stable complex sort in scalar context';
sub sortr {
reverse sort @_;
}
@output = sortr &generate;
is join(" ", map {0+$_} @output), "8 7 6 5 4 3 2 1 0",
'reversed stable sort return list context';
$output = sortr &generate;
is $output, "CCCBBBAAA",
'reversed stable sort return scalar context';
sub sortcmpr {
reverse sort {$a cmp $b} @_;
}
@output = sortcmpr &generate;
is join(" ", map {0+$_} @output), "8 7 6 5 4 3 2 1 0",
'reversed stable $a cmp $b sort return list context';
$output = sortcmpr &generate;
is $output, "CCCBBBAAA",
'reversed stable $a cmp $b sort return scalar context';
sub sortcmprba {
reverse sort {$b cmp $a} @_;
}
@output = sortcmprba &generate;
is join(" ", map {0+$_} @output), "2 1 0 5 4 3 8 7 6",
'reversed stable $b cmp $a sort return list context';
$output = sortcmprba &generate;
is $output, "AAABBBCCC",
'reversed stable $b cmp $a sort return scalar context';
sub sortcmprq {
reverse sort {stuff || $a cmp $b} @_;
}
@output = sortcmpr &generate;
is join(" ", map {0+$_} @output), "8 7 6 5 4 3 2 1 0",
'reversed stable complex sort return list context';
$output = sortcmpr &generate;
is $output, "CCCBBBAAA",
'reversed stable complex sort return scalar context';
# And now with numbers
sub generate1 {
my $count = 'A';
map {new Oscalar $count++, $_} 0, 0, 0, 1, 1, 1, 2, 2, 2;
}
# This won't be very interesting
@input = &generate1;
@output = sort {$a cmp $b} @input;
is "@output", "A B C D E F G H I", 'stable $a cmp $b sort';
@input = &generate1;
@output = sort {$a <=> $b} @input;
is "@output", "A B C D E F G H I", 'stable $a <=> $b sort';
@input = &generate1;
@input = sort {$a <=> $b} @input;
is "@input", "A B C D E F G H I", 'stable $a <=> $b in place sort';
@input = &generate1;
@output = sort {$b <=> $a} @input;
is "@output", "G H I D E F A B C", 'stable $b <=> $a sort';
@input = &generate1;
@input = sort {$b <=> $a} @input;
is "@input", "G H I D E F A B C", 'stable $b <=> $a in place sort';
# test that optimized {$b cmp $a} and {$b <=> $a} remain stable
# (new in 5.9) without overloading
{ no warnings;
@b = sort { $b <=> $a } @input = qw/5first 6first 5second 6second/;
is "@b" , "6first 6second 5first 5second", "optimized {$b <=> $a} without overloading" ;
@input = sort {$b <=> $a} @input;
is "@input" , "6first 6second 5first 5second","inline optimized {$b <=> $a} without overloading" ;
};
# These two are actually doing string cmp on 0 1 and 2
@input = &generate1;
@output = reverse sort @input;
is "@output", "I H G F E D C B A", "Reversed stable sort";
@input = &generate1;
@input = reverse sort @input;
is "@input", "I H G F E D C B A", "Reversed stable in place sort";
@input = &generate1;
$output = reverse sort @input;
is $output, "IHGFEDCBA", "Reversed stable sort in scalar context";
@input = &generate1;
@output = reverse sort {$a <=> $b} @input;
is "@output", "I H G F E D C B A", 'reversed stable $a <=> $b sort';
@input = &generate1;
@input = reverse sort {$a <=> $b} @input;
is "@input", "I H G F E D C B A", 'revesed stable $a <=> $b in place sort';
@input = &generate1;
$output = reverse sort {$a <=> $b} @input;
is $output, "IHGFEDCBA", 'reversed stable $a <=> $b sort in scalar context';
@input = &generate1;
@output = reverse sort {$b <=> $a} @input;
is "@output", "C B A F E D I H G", 'reversed stable $b <=> $a sort';
@input = &generate1;
@input = reverse sort {$b <=> $a} @input;
is "@input", "C B A F E D I H G", 'revesed stable $b <=> $a in place sort';
@input = &generate1;
$output = reverse sort {$b <=> $a} @input;
is $output, "CBAFEDIHG", 'reversed stable $b <=> $a sort in scalar context';
@input = &generate1;
@output = reverse sort {stuff || $a <=> $b} @input;
is "@output", "I H G F E D C B A", 'reversed stable complex sort';
@input = &generate1;
@input = reverse sort {stuff || $a <=> $b} @input;
is "@input", "I H G F E D C B A", 'revesed stable complex in place sort';
@input = &generate1;
$output = reverse sort {stuff || $a <=> $b} @input;
is $output, "IHGFEDCBA", 'reversed stable complex sort in scalar context';
sub sortnumr {
reverse sort {$a <=> $b} @_;
}
@output = sortnumr &generate1;
is "@output", "I H G F E D C B A",
'reversed stable $a <=> $b sort return list context';
$output = sortnumr &generate1;
is $output, "IHGFEDCBA", 'reversed stable $a <=> $b sort return scalar context';
sub sortnumrba {
reverse sort {$b <=> $a} @_;
}
@output = sortnumrba &generate1;
is "@output", "C B A F E D I H G",
'reversed stable $b <=> $a sort return list context';
$output = sortnumrba &generate1;
is $output, "CBAFEDIHG", 'reversed stable $b <=> $a sort return scalar context';
sub sortnumrq {
reverse sort {stuff || $a <=> $b} @_;
}
@output = sortnumrq &generate1;
is "@output", "I H G F E D C B A",
'reversed stable complex sort return list context';
$output = sortnumrq &generate1;
is $output, "IHGFEDCBA", 'reversed stable complex sort return scalar context';
@output = reverse (sort(qw(C A B)), 0);
is "@output", "0 C B A", 'reversed sort with trailing argument';
@output = reverse (0, sort(qw(C A B)));
is "@output", "C B A 0", 'reversed sort with leading argument';
eval { @output = sort {goto sub {}} 1,2; };
$fail_msg = q(Can't goto subroutine outside a subroutine);
cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'goto subr outside subr');
sub goto_sub {goto sub{}}
eval { @output = sort goto_sub 1,2; };
$fail_msg = q(Can't goto subroutine from a sort sub);
cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'goto subr from a sort sub');
eval { @output = sort {goto label} 1,2; };
$fail_msg = q(Can't "goto" out of a pseudo block);
cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'goto out of a pseudo block 1');
sub goto_label {goto label}
label: eval { @output = sort goto_label 1,2; };
$fail_msg = q(Can't "goto" out of a pseudo block);
cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'goto out of a pseudo block 2');
sub self_immolate {undef &self_immolate; $a<=>$b}
eval { @output = sort self_immolate 1,2,3 };
$fail_msg = q(Can't undef active subroutine);
cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'undef active subr');
for(1,2) # We run this twice, to make sure sort does not lower the ref
{ # count. See bug 71076.
my $failed = 0;
sub rec {
my $n = shift;
if (!defined($n)) { # No arg means we're being called by sort()
return 1;
}
if ($n<5) { rec($n+1); }
else { () = sort rec 1,2; }
$failed = 1 if !defined $n;
}
rec(1);
ok(!$failed, "sort from active sub");
}
# $a and $b are set in the package the sort() is called from,
# *not* the package the sort sub is in. This is longstanding
# de facto behaviour that shouldn't be broken.
my $answer = "good";
() = sort OtherPack::foo 1,2,3,4;
{
package OtherPack;
no warnings 'once';
sub foo {
$answer = "something was unexpectedly defined or undefined" if
defined($a) || defined($b) || !defined($main::a) || !defined($main::b);
$main::a <=> $main::b;
}
}
cmp_ok($answer,'eq','good','sort subr called from other package');
# Bug 36430 - sort called in package2 while a
# sort in package1 is active should set $package2::a/b.
{
my $answer = "good";
my @list = sort { A::min(@$a) <=> A::min(@$b) }
[3, 1, 5], [2, 4], [0];
cmp_ok($answer,'eq','good','bug 36430');
package A;
sub min {
my @list = sort {
$answer = '$a and/or $b are not defined ' if !defined($a) || !defined($b);
$a <=> $b;
} @_;
$list[0];
}
}
# Bug 7567 - an array shouldn't be modifiable while it's being
# sorted in-place.
{
eval { @a=(1..8); @a = sort { @a = (0) } @a; };
$fail_msg = q(Modification of a read-only value attempted);
cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'bug 7567');
eval { @a=1..3 };
is $@, "", 'abrupt scope exit turns off readonliness';
}
{
local $TODO = "sort should make sure elements are not freed in the sort block";
eval { @nomodify_x=(1..8);
our @copy = sort { undef @nomodify_x; 1 } (@nomodify_x, 3); };
is($@, "");
}
# Sorting shouldn't increase the refcount of a sub
{
sub sportello {(1+$a) <=> (1+$b)}
my $refcnt = &Internals::SvREFCNT(\&sportello);
@output = sort sportello 3,7,9;
{
package Doc;
::is($refcnt, &Internals::SvREFCNT(\&::sportello), "sort sub refcnt");
$fail_msg = q(Modification of a read-only value attempted);
# Sorting a read-only array in-place shouldn't be allowed
my @readonly = (1..10);
Internals::SvREADONLY(@readonly, 1);
eval { @readonly = sort @readonly; };
::cmp_ok(substr($@,0,length($fail_msg)),'eq',$fail_msg,'in-place sort of read-only array');
}
}
# Using return() should be okay even in a deeper context
@b = sort {while (1) {return ($a <=> $b)} } 1..10;
is("@b", "1 2 3 4 5 6 7 8 9 10", "return within loop");
# Using return() should be okay even if there are other items
# on the stack at the time.
@b = sort {$_ = ($a<=>$b) + do{return $b<=> $a}} 1..10;
is("@b", "10 9 8 7 6 5 4 3 2 1", "return with SVs on stack");
# As above, but with a sort sub rather than a sort block.
sub ret_with_stacked { $_ = ($a<=>$b) + do {return $b <=> $a} }
@b = sort ret_with_stacked 1..10;
is("@b", "10 9 8 7 6 5 4 3 2 1", "return with SVs on stack");
# Comparison code should be able to give result in non-integer representation.
sub cmp_as_string($$) { $_[0] < $_[1] ? "-1" : $_[0] == $_[1] ? "0" : "+1" }
@b = sort { cmp_as_string($a, $b) } (1,5,4,7,3,2,3);
is("@b", "1 2 3 3 4 5 7", "comparison result as string");
@b = sort cmp_as_string (1,5,4,7,3,2,3);
is("@b", "1 2 3 3 4 5 7", "comparison result as string");
# RT #34604: sort didn't honour overloading if the overloaded elements
# were retrieved via tie
{
package RT34604;
sub TIEHASH { bless {
p => bless({ val => 2 }),
q => bless({ val => 1 }),
}
}
sub FETCH { $_[0]{$_[1] } }
my $cc = 0;
sub compare { $cc++; $_[0]{val} cmp $_[1]{val} }
my $cs = 0;
sub str { $cs++; $_[0]{val} }
use overload 'cmp' => \&compare, '""' => \&str;
package main;
tie my %h, 'RT34604';
my @sorted = sort @h{qw(p q)};
is($cc, 1, 'overload compare called once');
is("@sorted","1 2", 'overload sort result');
is($cs, 2, 'overload string called twice');
}
fresh_perl_is('sub w ($$) {my ($l, my $r) = @_; my $v = \@_; undef @_; $l <=> $r}; print join q{ }, sort w 3, 1, 2, 0',
'0 1 2 3',
{stderr => 1, switches => ['-w']},
'RT #72334');
fresh_perl_is('sub w ($$) {my ($l, my $r) = @_; my $v = \@_; undef @_; @_ = 0..2; $l <=> $r}; print join q{ }, sort w 3, 1, 2, 0',
'0 1 2 3',
{stderr => 1, switches => ['-w']},
'RT #72334');
{
my $count = 0;
{
package Counter;
sub new {
++$count;
bless [];
}
sub DESTROY {
--$count;
}
}
sub sorter ($$) {
my ($l, $r) = @_;
my $q = \@_;
$l <=> $r;
}
is($count, 0, 'None before we start');
my @a = map { Counter->new() } 0..1;
is($count, 2, '2 here');
my @b = sort sorter @a;
is(scalar @b, 2);
cmp_ok($b[0], '<', $b[1], 'sorted!');
is($count, 2, 'still the same 2 here');
@a = (); @b = ();
is($count, 0, 'all gone');
}
# [perl #77930] The context stack may be reallocated during a sort, as a
# result of deeply-nested (or not-so-deeply-nested) calls
# from a custom sort subroutine.
fresh_perl_is
'
$sub = sub {
local $count = $count+1;
()->$sub if $count < 1000;
$a cmp $b
};
() = sort $sub qw<a b c d e f g>;
print "ok"
',
'ok',
{},
'[perl #77930] cx_stack reallocation during sort'
;
# [perl #76026]
# Match vars should not leak from one sort sub call to the next
{
my $output = '';
sub soarter {
$output .= $1;
"Leakage" =~ /(.*)/;
1
}
sub soarterdd($$) {
$output .= $1;
"Leakage" =~ /(.*)/;
1
}
"Win" =~ /(.*)/;
my @b = sort soarter 0..2;
like $output, qr/^(?:Win)+\z/,
"Match vars do not leak from one plain sort sub to the next";
$output = '';
"Win" =~ /(.*)/;
@b = sort soarterdd 0..2;
like $output, qr/^(?:Win)+\z/,
'Match vars do not leak from one $$ sort sub to the next';
}
# [perl #30661] autoloading
AUTOLOAD { $b <=> $a }
sub stubbedsub;
is join("", sort stubbedsub split//, '04381091'), '98431100',
'stubborn AUTOLOAD';
is join("", sort hopefullynonexistent split//, '04381091'), '98431100',
'AUTOLOAD without stub';
my $stubref = \&givemeastub;
is join("", sort $stubref split//, '04381091'), '98431100',
'AUTOLOAD with stubref';
# [perl #90030] sort without arguments
eval '@x = (sort); 1';
is $@, '', '(sort) does not die';
is @x, 0, '(sort) returns empty list';
eval '@x = sort; 1';
is $@, '', 'sort; does not die';
is @x, 0, 'sort; returns empty list';
eval '{@x = sort} 1';
is $@, '', '{sort} does not die';
is @x, 0, '{sort} returns empty list';
# this happened while the padrange op was being added. Sort blocks
# are executed in void context, and the padrange op was skipping pushing
# the item in void cx. The net result was that the return value was
# whatever was on the stack last.
{
my @a = sort {
my $r = $a <=> $b;
if ($r) {
undef; # this got returned by mistake
return $r
}
return 0;
} 5,1,3,6,0;
is "@a", "0 1 3 5 6", "padrange and void context";
}
# Fatal warnings an sort sub returning a non-number
# We need two evals, because the panic used to happen on scope exit.
eval { eval { use warnings FATAL => 'all'; () = sort { undef } 1,2 } };
is $@, "",
'no panic/crash with fatal warnings when sort sub returns undef';
eval { eval { use warnings FATAL => 'all'; () = sort { "no thin" } 1,2 } };
is $@, "",
'no panic/crash with fatal warnings when sort sub returns string';
sub notdef($$) { undef }
eval { eval { use warnings FATAL => 'all'; () = sort notdef 1,2 } };
is $@, "",
'no panic/crash with fatal warnings when sort sub($$) returns undef';
sub yarn($$) { "no thinking aloud" }
eval { eval { use warnings FATAL => 'all'; () = sort yarn 1,2 } };
is $@, "",
'no panic/crash with fatal warnings when sort sub($$) returns string';
$#a = -1;
() = [sort { $a = 10; $b = 10; 0 } $#a, $#a];
is $#a, 10, 'sort block modifying $a and $b';
() = sort {
is \$a, \$a, '[perl #78194] op return values passed to sort'; 0
} "${\''}", "${\''}";
package deletions {
@_=sort { delete $deletions::{a}; delete $deletions::{b}; 3 } 1..3;
}
pass "no crash when sort block deletes *a and *b";
|