1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
|
<?php
/**
* Squiz_Sniffs_Operators_IncrementDecrementUsageSniff.
*
* PHP version 5
*
* @category PHP
* @package PHP_CodeSniffer
* @author Greg Sherwood <gsherwood@squiz.net>
* @author Marc McIntyre <mmcintyre@squiz.net>
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
* @link http://pear.php.net/package/PHP_CodeSniffer
*/
/**
* Squiz_Sniffs_Operators_IncrementDecrementUsageSniff.
*
* Tests that the ++ operators are used when possible and not
* used when it makes the code confusing.
*
* @category PHP
* @package PHP_CodeSniffer
* @author Greg Sherwood <gsherwood@squiz.net>
* @author Marc McIntyre <mmcintyre@squiz.net>
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
* @version Release: 1.3.4
* @link http://pear.php.net/package/PHP_CodeSniffer
*/
class Squiz_Sniffs_Operators_IncrementDecrementUsageSniff implements PHP_CodeSniffer_Sniff
{
/**
* Returns an array of tokens this test wants to listen for.
*
* @return array
*/
public function register()
{
return array(
T_EQUAL,
T_PLUS_EQUAL,
T_MINUS_EQUAL,
T_INC,
T_DEC,
);
}//end register()
/**
* Processes this test, when one of its tokens is encountered.
*
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token
* in the stack passed in $tokens.
*
* @return void
*/
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
$tokens = $phpcsFile->getTokens();
if ($tokens[$stackPtr]['code'] === T_INC || $tokens[$stackPtr]['code'] === T_DEC) {
$this->processIncDec($phpcsFile, $stackPtr);
} else {
$this->processAssignment($phpcsFile, $stackPtr);
}
}//end process()
/**
* Checks to ensure increment and decrement operators are not confusing.
*
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token
* in the stack passed in $tokens.
*
* @return void
*/
protected function processIncDec(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
$tokens = $phpcsFile->getTokens();
// Work out where the variable is so we know where to
// start looking for other operators.
if ($tokens[($stackPtr - 1)]['code'] === T_VARIABLE) {
$start = ($stackPtr + 1);
} else {
$start = ($stackPtr + 2);
}
$next = $phpcsFile->findNext(PHP_CodeSniffer_Tokens::$emptyTokens, $start, null, true);
if ($next === false) {
return;
}
if (in_array($tokens[$next]['code'], PHP_CodeSniffer_Tokens::$arithmeticTokens) === true) {
$error = 'Increment and decrement operators cannot be used in an arithmetic operation';
$phpcsFile->addError($error, $stackPtr, 'NotAllowed');
return;
}
$prev = $phpcsFile->findPrevious(PHP_CodeSniffer_Tokens::$emptyTokens, ($start - 3), null, true);
if ($prev === false) {
return;
}
// Check if this is in a string concat.
if ($tokens[$next]['code'] === T_STRING_CONCAT || $tokens[$prev]['code'] === T_STRING_CONCAT) {
$error = 'Increment and decrement operators must be bracketed when used in string concatenation';
$phpcsFile->addError($error, $stackPtr, 'NoBrackets');
}
}//end processIncDec()
/**
* Checks to ensure increment and decrement operators are used.
*
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token
* in the stack passed in $tokens.
*
* @return void
*/
protected function processAssignment(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
{
$tokens = $phpcsFile->getTokens();
$assignedVar = $phpcsFile->findPrevious(T_WHITESPACE, ($stackPtr - 1), null, true);
// Not an assignment, return.
if ($tokens[$assignedVar]['code'] !== T_VARIABLE) {
return;
}
$statementEnd = $phpcsFile->findNext(array(T_SEMICOLON, T_CLOSE_PARENTHESIS, T_CLOSE_SQUARE_BRACKET, T_CLOSE_CURLY_BRACKET), $stackPtr);
// If there is anything other than variables, numbers, spaces or operators we need to return.
$noiseTokens = $phpcsFile->findNext(array(T_LNUMBER, T_VARIABLE, T_WHITESPACE, T_PLUS, T_MINUS, T_OPEN_PARENTHESIS), ($stackPtr + 1), $statementEnd, true);
if ($noiseTokens !== false) {
return;
}
// If we are already using += or -=, we need to ignore
// the statement if a variable is being used.
if ($tokens[$stackPtr]['code'] !== T_EQUAL) {
$nextVar = $phpcsFile->findNext(T_VARIABLE, ($stackPtr + 1), $statementEnd);
if ($nextVar !== false) {
return;
}
}
if ($tokens[$stackPtr]['code'] === T_EQUAL) {
$nextVar = ($stackPtr + 1);
$previousVariable = ($stackPtr + 1);
$variableCount = 0;
while (($nextVar = $phpcsFile->findNext(T_VARIABLE, ($nextVar + 1), $statementEnd)) !== false) {
$previousVariable = $nextVar;
$variableCount++;
}
if ($variableCount !== 1) {
return;
}
$nextVar = $previousVariable;
if ($tokens[$nextVar]['content'] !== $tokens[$assignedVar]['content']) {
return;
}
}
// We have only one variable, and it's the same as what is being assigned,
// so we need to check what is being added or subtracted.
$nextNumber = ($stackPtr + 1);
$previousNumber = ($stackPtr + 1);
$numberCount = 0;
while (($nextNumber = $phpcsFile->findNext(array(T_LNUMBER), ($nextNumber + 1), $statementEnd, false)) !== false) {
$previousNumber = $nextNumber;
$numberCount++;
}
if ($numberCount !== 1) {
return;
}
$nextNumber = $previousNumber;
if ($tokens[$nextNumber]['content'] === '1') {
if ($tokens[$stackPtr]['code'] === T_EQUAL) {
$opToken = $phpcsFile->findNext(array(T_PLUS, T_MINUS), ($nextVar + 1), $statementEnd);
if ($opToken === false) {
// Operator was before the variable, like:
// $var = 1 + $var;
// So we ignore it.
return;
}
$operator = $tokens[$opToken]['content'];
} else {
$operator = substr($tokens[$stackPtr]['content'], 0, 1);
}
// If we are adding or subtracting negative value, the operator
// needs to be reversed.
if ($tokens[$stackPtr]['code'] !== T_EQUAL) {
$negative = $phpcsFile->findPrevious(T_MINUS, ($nextNumber - 1), $stackPtr);
if ($negative !== false) {
$operator = ($operator === '+') ? '-' : '+';
}
}
$expected = $tokens[$assignedVar]['content'].$operator.$operator;
$found = $phpcsFile->getTokensAsString($assignedVar, ($statementEnd - $assignedVar + 1));
if ($operator === '+') {
$error = 'Increment';
} else {
$error = 'Decrement';
}
$error .= " operators should be used where possible; found \"$found\" but expected \"$expected\"";
$phpcsFile->addError($error, $stackPtr);
}//end if
}//end processAssignment()
}//end class
?>
|