1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247
|
<?php
/**
* Tests for PHP_CodeSniffer error suppression tags.
*
* @author Greg Sherwood <gsherwood@squiz.net>
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
* @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
*/
namespace PHP_CodeSniffer\Tests\Core;
use PHP_CodeSniffer\Config;
use PHP_CodeSniffer\Ruleset;
use PHP_CodeSniffer\Files\DummyFile;
use PHPUnit\Framework\TestCase;
class ErrorSuppressionTest extends TestCase
{
/**
* Test suppressing a single error.
*
* @param string $before Annotation to place before the code.
* @param string $after Annotation to place after the code.
* @param int $expectedErrors Optional. Number of errors expected.
* Defaults to 0.
*
* @dataProvider dataSuppressError
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressError($before, $after, $expectedErrors=0)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.PHP.LowerCaseConstant'];
$ruleset = new Ruleset($config);
}
$content = '<?php '.PHP_EOL.$before.'$var = FALSE;'.PHP_EOL.$after;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
}//end testSuppressError()
/**
* Data provider.
*
* @see testSuppressError()
*
* @return array
*/
public function dataSuppressError()
{
return [
'no suppression' => [
'before' => '',
'after' => '',
'expectedErrors' => 1,
],
// Inline slash comments.
'disable/enable: slash comment' => [
'before' => '// phpcs:disable'.PHP_EOL,
'after' => '// phpcs:enable',
],
'disable/enable: multi-line slash comment, tab indented' => [
'before' => "\t".'// For reasons'.PHP_EOL."\t".'// phpcs:disable'.PHP_EOL."\t",
'after' => "\t".'// phpcs:enable',
],
'disable/enable: slash comment, with @' => [
'before' => '// @phpcs:disable'.PHP_EOL,
'after' => '// @phpcs:enable',
],
'disable/enable: slash comment, mixed case' => [
'before' => '// PHPCS:Disable'.PHP_EOL,
'after' => '// pHPcs:enabLE',
],
// Inline hash comments.
'disable/enable: hash comment' => [
'before' => '# phpcs:disable'.PHP_EOL,
'after' => '# phpcs:enable',
],
'disable/enable: multi-line hash comment, tab indented' => [
'before' => "\t".'# For reasons'.PHP_EOL."\t".'# phpcs:disable'.PHP_EOL."\t",
'after' => "\t".'# phpcs:enable',
],
'disable/enable: hash comment, with @' => [
'before' => '# @phpcs:disable'.PHP_EOL,
'after' => '# @phpcs:enable',
],
'disable/enable: hash comment, mixed case' => [
'before' => '# PHPCS:Disable'.PHP_EOL,
'after' => '# pHPcs:enabLE',
],
// Inline star (block) comments.
'disable/enable: star comment' => [
'before' => '/* phpcs:disable */'.PHP_EOL,
'after' => '/* phpcs:enable */',
],
'disable/enable: multi-line star comment' => [
'before' => '/*'.PHP_EOL.' phpcs:disable'.PHP_EOL.' */'.PHP_EOL,
'after' => '/*'.PHP_EOL.' phpcs:enable'.PHP_EOL.' */',
],
'disable/enable: multi-line star comment, each line starred' => [
'before' => '/*'.PHP_EOL.' * phpcs:disable'.PHP_EOL.' */'.PHP_EOL,
'after' => '/*'.PHP_EOL.' * phpcs:enable'.PHP_EOL.' */',
],
'disable/enable: multi-line star comment, each line starred, tab indented' => [
'before' => "\t".'/*'.PHP_EOL."\t".' * phpcs:disable'.PHP_EOL."\t".' */'.PHP_EOL."\t",
'after' => "\t".'/*'.PHP_EOL.' * phpcs:enable'.PHP_EOL.' */',
],
// Docblock comments.
'disable/enable: single line docblock comment' => [
'before' => '/** phpcs:disable */'.PHP_EOL,
'after' => '/** phpcs:enable */',
],
// Deprecated syntax.
'old style: slash comment' => [
'before' => '// @codingStandardsIgnoreStart'.PHP_EOL,
'after' => '// @codingStandardsIgnoreEnd',
],
'old style: star comment' => [
'before' => '/* @codingStandardsIgnoreStart */'.PHP_EOL,
'after' => '/* @codingStandardsIgnoreEnd */',
],
'old style: multi-line star comment' => [
'before' => '/*'.PHP_EOL.' @codingStandardsIgnoreStart'.PHP_EOL.' */'.PHP_EOL,
'after' => '/*'.PHP_EOL.' @codingStandardsIgnoreEnd'.PHP_EOL.' */',
],
'old style: single line docblock comment' => [
'before' => '/** @codingStandardsIgnoreStart */'.PHP_EOL,
'after' => '/** @codingStandardsIgnoreEnd */',
],
];
}//end dataSuppressError()
/**
* Test suppressing 1 out of 2 errors.
*
* @param string $before Annotation to place before the code.
* @param string $between Annotation to place between the code.
* @param int $expectedErrors Optional. Number of errors expected.
* Defaults to 1.
*
* @dataProvider dataSuppressSomeErrors
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressSomeErrors($before, $between, $expectedErrors=1)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.PHP.LowerCaseConstant'];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
\$var = FALSE;
$between
\$var = TRUE;
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
}//end testSuppressSomeErrors()
/**
* Data provider.
*
* @see testSuppressSomeErrors()
*
* @return array
*/
public function dataSuppressSomeErrors()
{
return [
'no suppression' => [
'before' => '',
'between' => '',
'expectedErrors' => 2,
],
// With suppression.
'disable/enable: slash comment' => [
'before' => '// phpcs:disable',
'between' => '// phpcs:enable',
],
'disable/enable: slash comment, with @' => [
'before' => '// @phpcs:disable',
'between' => '// @phpcs:enable',
],
'disable/enable: hash comment' => [
'before' => '# phpcs:disable',
'between' => '# phpcs:enable',
],
'disable/enable: hash comment, with @' => [
'before' => '# @phpcs:disable',
'between' => '# @phpcs:enable',
],
'disable/enable: single line docblock comment' => [
'before' => '/** phpcs:disable */',
'between' => '/** phpcs:enable */',
],
// Deprecated syntax.
'old style: slash comment' => [
'before' => '// @codingStandardsIgnoreStart',
'between' => '// @codingStandardsIgnoreEnd',
],
'old style: single line docblock comment' => [
'before' => '/** @codingStandardsIgnoreStart */',
'between' => '/** @codingStandardsIgnoreEnd */',
],
];
}//end dataSuppressSomeErrors()
/**
* Test suppressing a single warning.
*
* @param string $before Annotation to place before the code.
* @param string $after Annotation to place after the code.
* @param int $expectedWarnings Optional. Number of warnings expected.
* Defaults to 0.
*
* @dataProvider dataSuppressWarning
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressWarning($before, $after, $expectedWarnings=0)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.Commenting.Todo'];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
//TODO: write some code.
$after
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedWarnings, $file->getWarningCount());
$this->assertCount($expectedWarnings, $file->getWarnings());
}//end testSuppressWarning()
/**
* Data provider.
*
* @see testSuppressWarning()
*
* @return array
*/
public function dataSuppressWarning()
{
return [
'no suppression' => [
'before' => '',
'after' => '',
'expectedWarnings' => 1,
],
// With suppression.
'disable/enable: slash comment' => [
'before' => '// phpcs:disable',
'after' => '// phpcs:enable',
],
'disable/enable: slash comment, with @' => [
'before' => '// @phpcs:disable',
'after' => '// @phpcs:enable',
],
'disable/enable: single line docblock comment' => [
'before' => '/** phpcs:disable */',
'after' => '/** phpcs:enable */',
],
// Deprecated syntax.
'old style: slash comment' => [
'before' => '// @codingStandardsIgnoreStart',
'after' => '// @codingStandardsIgnoreEnd',
],
'old style: single line docblock comment' => [
'before' => '/** @codingStandardsIgnoreStart */',
'after' => '/** @codingStandardsIgnoreEnd */',
],
];
}//end dataSuppressWarning()
/**
* Test suppressing a single error using a single line ignore.
*
* @param string $before Annotation to place before the code.
* @param string $after Optional. Annotation to place after the code.
* Defaults to an empty string.
* @param int $expectedErrors Optional. Number of errors expected.
* Defaults to 1.
*
* @dataProvider dataSuppressLine
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressLine($before, $after='', $expectedErrors=1)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.PHP.LowerCaseConstant'];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
\$var = FALSE;$after
\$var = FALSE;
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
}//end testSuppressLine()
/**
* Data provider.
*
* @see testSuppressLine()
*
* @return array
*/
public function dataSuppressLine()
{
return [
'no suppression' => [
'before' => '',
'after' => '',
'expectedErrors' => 2,
],
// With suppression on line before.
'ignore: line before, slash comment' => ['before' => '// phpcs:ignore'],
'ignore: line before, slash comment, with @' => ['before' => '// @phpcs:ignore'],
'ignore: line before, hash comment' => ['before' => '# phpcs:ignore'],
'ignore: line before, hash comment, with @' => ['before' => '# @phpcs:ignore'],
'ignore: line before, star comment' => ['before' => '/* phpcs:ignore */'],
'ignore: line before, star comment, with @' => ['before' => '/* @phpcs:ignore */'],
// With suppression as trailing comment on code line.
'ignore: end of line, slash comment' => [
'before' => '',
'after' => ' // phpcs:ignore',
],
'ignore: end of line, slash comment, with @' => [
'before' => '',
'after' => ' // @phpcs:ignore',
],
'ignore: end of line, hash comment' => [
'before' => '',
'after' => ' # phpcs:ignore',
],
'ignore: end of line, hash comment, with @' => [
'before' => '',
'after' => ' # @phpcs:ignore',
],
// Deprecated syntax.
'old style: line before, slash comment' => ['before' => '// @codingStandardsIgnoreLine'],
'old style: end of line, slash comment' => [
'before' => '',
'after' => ' // @codingStandardsIgnoreLine',
],
];
}//end dataSuppressLine()
/**
* Test suppressing a single error using a single line ignore in the middle of a line.
*
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressLineMidLine()
{
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.PHP.LowerCaseConstant'];
$ruleset = new Ruleset($config);
$content = '<?php '.PHP_EOL.'$var = FALSE; /* @phpcs:ignore */ $var = FALSE;';
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame(0, $file->getErrorCount());
$this->assertCount(0, $file->getErrors());
}//end testSuppressLineMidLine()
/**
* Test suppressing a single error using a single line ignore within a docblock.
*
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressLineWithinDocblock()
{
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.Files.LineLength'];
$ruleset = new Ruleset($config);
// Process with @ suppression on line before inside docblock.
$comment = str_repeat('a ', 50);
$content = <<<EOD
<?php
/**
* Comment here
* @phpcs:ignore
* $comment
*/
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame(0, $file->getErrorCount());
$this->assertCount(0, $file->getErrors());
}//end testSuppressLineWithinDocblock()
/**
* Test that using a single line ignore does not interfere with other suppressions.
*
* @param string $before Annotation to place before the code.
* @param string $after Annotation to place after the code.
*
* @dataProvider dataNestedSuppressLine
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testNestedSuppressLine($before, $after)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.PHP.LowerCaseConstant'];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
\$var = FALSE;
\$var = TRUE;
$after
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame(0, $file->getErrorCount());
$this->assertCount(0, $file->getErrors());
}//end testNestedSuppressLine()
/**
* Data provider.
*
* @see testNestedSuppressLine()
*
* @return array
*/
public function dataNestedSuppressLine()
{
return [
// Process with disable/enable suppression and no single line suppression.
'disable/enable: slash comment, no single line suppression' => [
'before' => '// phpcs:disable',
'after' => '// phpcs:enable',
],
'disable/enable: slash comment, with @, no single line suppression' => [
'before' => '// @phpcs:disable',
'after' => '// @phpcs:enable',
],
'disable/enable: hash comment, no single line suppression' => [
'before' => '# phpcs:disable',
'after' => '# phpcs:enable',
],
'old style: slash comment, no single line suppression' => [
'before' => '// @codingStandardsIgnoreStart',
'after' => '// @codingStandardsIgnoreEnd',
],
// Process with line suppression nested within disable/enable suppression.
'disable/enable: slash comment, next line nested single line suppression' => [
'before' => '// phpcs:disable'.PHP_EOL.'// phpcs:ignore',
'after' => '// phpcs:enable',
],
'disable/enable: slash comment, with @, next line nested single line suppression' => [
'before' => '// @phpcs:disable'.PHP_EOL.'// @phpcs:ignore',
'after' => '// @phpcs:enable',
],
'disable/enable: hash comment, next line nested single line suppression' => [
'before' => '# @phpcs:disable'.PHP_EOL.'# @phpcs:ignore',
'after' => '# @phpcs:enable',
],
'old style: slash comment, next line nested single line suppression' => [
'before' => '// @codingStandardsIgnoreStart'.PHP_EOL.'// @codingStandardsIgnoreLine',
'after' => '// @codingStandardsIgnoreEnd',
],
];
}//end dataNestedSuppressLine()
/**
* Test suppressing a scope opener.
*
* @param string $before Annotation to place before the scope opener.
* @param string $after Annotation to place after the scope opener.
* @param int $expectedErrors Optional. Number of errors expected.
* Defaults to 0.
*
* @dataProvider dataSuppressScope
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressScope($before, $after, $expectedErrors=0)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['PEAR'];
$config->sniffs = ['PEAR.Functions.FunctionDeclaration'];
$ruleset = new Ruleset($config);
}
$content = '<?php '.PHP_EOL.$before.'$var = FALSE;'.$after.PHP_EOL.'$var = FALSE;';
$content = <<<EOD
<?php
class MyClass() {
$before
function myFunction() {
$after
\$this->foo();
}
}
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
}//end testSuppressScope()
/**
* Data provider.
*
* @see testSuppressScope()
*
* @return array
*/
public function dataSuppressScope()
{
return [
'no suppression' => [
'before' => '',
'after' => '',
'expectedErrors' => 1,
],
// Process with suppression.
'disable/enable: slash comment' => [
'before' => '//phpcs:disable',
'after' => '//phpcs:enable',
],
'disable/enable: slash comment, with @' => [
'before' => '//@phpcs:disable',
'after' => '//@phpcs:enable',
],
'disable/enable: hash comment' => [
'before' => '#phpcs:disable',
'after' => '#phpcs:enable',
],
'disable/enable: single line docblock comment' => [
'before' => '/** phpcs:disable */',
'after' => '/** phpcs:enable */',
],
'disable/enable: single line docblock comment, with @' => [
'before' => '/** @phpcs:disable */',
'after' => '/** @phpcs:enable */',
],
// Deprecated syntax.
'old style: start/end, slash comment' => [
'before' => '//@codingStandardsIgnoreStart',
'after' => '//@codingStandardsIgnoreEnd',
],
'old style: start/end, single line docblock comment' => [
'before' => '/** @codingStandardsIgnoreStart */',
'after' => '/** @codingStandardsIgnoreEnd */',
],
];
}//end dataSuppressScope()
/**
* Test suppressing a whole file.
*
* @param string $before Annotation to place before the code.
* @param string $after Optional. Annotation to place after the code.
* Defaults to an empty string.
* @param int $expectedWarnings Optional. Number of warnings expected.
* Defaults to 0.
*
* @dataProvider dataSuppressFile
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testSuppressFile($before, $after='', $expectedWarnings=0)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = ['Generic.Commenting.Todo'];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
class MyClass {}
\$foo = new MyClass();
//TODO: write some code
$after
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedWarnings, $file->getWarningCount());
$this->assertCount($expectedWarnings, $file->getWarnings());
}//end testSuppressFile()
/**
* Data provider.
*
* @see testSuppressFile()
*
* @return array
*/
public function dataSuppressFile()
{
return [
'no suppression' => [
'before' => '',
'after' => '',
'expectedErrors' => 1,
],
// Process with suppression.
'ignoreFile: start of file, slash comment' => ['before' => '// phpcs:ignoreFile'],
'ignoreFile: start of file, slash comment, with @' => ['before' => '// @phpcs:ignoreFile'],
'ignoreFile: start of file, slash comment, mixed case' => ['before' => '// PHPCS:Ignorefile'],
'ignoreFile: start of file, hash comment' => ['before' => '# phpcs:ignoreFile'],
'ignoreFile: start of file, hash comment, with @' => ['before' => '# @phpcs:ignoreFile'],
'ignoreFile: start of file, single-line star comment' => ['before' => '/* phpcs:ignoreFile */'],
'ignoreFile: start of file, multi-line star comment' => [
'before' => '/*'.PHP_EOL.' phpcs:ignoreFile'.PHP_EOL.' */',
],
'ignoreFile: start of file, single-line docblock comment' => ['before' => '/** phpcs:ignoreFile */'],
// Process late comment.
'ignoreFile: late comment, slash comment' => [
'before' => '',
'after' => '// phpcs:ignoreFile',
],
// Deprecated syntax.
'old style: start of file, slash comment' => ['before' => '// @codingStandardsIgnoreFile'],
'old style: start of file, single-line star comment' => ['before' => '/* @codingStandardsIgnoreFile */'],
'old style: start of file, multi-line star comment' => [
'before' => '/*'.PHP_EOL.' @codingStandardsIgnoreFile'.PHP_EOL.' */',
],
'old style: start of file, single-line docblock comment' => ['before' => '/** @codingStandardsIgnoreFile */'],
// Deprecated syntax, late comment.
'old style: late comment, slash comment' => [
'before' => '',
'after' => '// @codingStandardsIgnoreFile',
],
];
}//end dataSuppressFile()
/**
* Test disabling specific sniffs.
*
* @param string $before Annotation to place before the code.
* @param int $expectedErrors Optional. Number of errors expected.
* Defaults to 0.
* @param int $expectedWarnings Optional. Number of warnings expected.
* Defaults to 0.
*
* @dataProvider dataDisableSelected
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testDisableSelected($before, $expectedErrors=0, $expectedWarnings=0)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = [
'Generic.PHP.LowerCaseConstant',
'Generic.Commenting.Todo',
];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
\$var = FALSE;
//TODO: write some code
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
$this->assertSame($expectedWarnings, $file->getWarningCount());
$this->assertCount($expectedWarnings, $file->getWarnings());
}//end testDisableSelected()
/**
* Data provider.
*
* @see testDisableSelected()
*
* @return array
*/
public function dataDisableSelected()
{
return [
// Single sniff.
'disable: single sniff' => [
'before' => '// phpcs:disable Generic.Commenting.Todo',
'expectedErrors' => 1,
],
'disable: single sniff with reason' => [
'before' => '# phpcs:disable Generic.Commenting.Todo -- for reasons',
'expectedErrors' => 1,
],
'disable: single sniff, docblock' => [
'before' => '/**'.PHP_EOL.' * phpcs:disable Generic.Commenting.Todo'.PHP_EOL.' */ ',
'expectedErrors' => 1,
],
'disable: single sniff, docblock, with @' => [
'before' => '/**'.PHP_EOL.' * @phpcs:disable Generic.Commenting.Todo'.PHP_EOL.' */ ',
'expectedErrors' => 1,
],
// Multiple sniffs.
'disable: multiple sniffs in one comment' => ['before' => '// phpcs:disable Generic.Commenting.Todo,Generic.PHP.LowerCaseConstant'],
'disable: multiple sniff in multiple comments' => [
'before' => '// phpcs:disable Generic.Commenting.Todo'.PHP_EOL.'// phpcs:disable Generic.PHP.LowerCaseConstant',
],
// Selectiveness variations.
'disable: complete category' => [
'before' => '// phpcs:disable Generic.Commenting',
'expectedErrors' => 1,
],
'disable: whole standard' => ['before' => '// phpcs:disable Generic'],
'disable: single errorcode' => [
'before' => '# @phpcs:disable Generic.Commenting.Todo.TaskFound',
'expectedErrors' => 1,
],
'disable: single errorcode and a category' => ['before' => '// phpcs:disable Generic.PHP.LowerCaseConstant.Found,Generic.Commenting'],
// Wrong category/sniff/code.
'disable: wrong error code and category' => [
'before' => '/**'.PHP_EOL.' * phpcs:disable Generic.PHP.LowerCaseConstant.Upper,Generic.Comments'.PHP_EOL.' */ ',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: wrong category, docblock' => [
'before' => '/**'.PHP_EOL.' * phpcs:disable Generic.Files'.PHP_EOL.' */ ',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: wrong category, docblock, with @' => [
'before' => '/**'.PHP_EOL.' * @phpcs:disable Generic.Files'.PHP_EOL.' */ ',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
];
}//end dataDisableSelected()
/**
* Test re-enabling specific sniffs that have been disabled.
*
* @param string $code Code pattern to check.
* @param int $expectedErrors Number of errors expected.
* @param int $expectedWarnings Number of warnings expected.
*
* @dataProvider dataEnableSelected
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testEnableSelected($code, $expectedErrors, $expectedWarnings)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = [
'Generic.PHP.LowerCaseConstant',
'Generic.Commenting.Todo',
];
$ruleset = new Ruleset($config);
}
$content = '<?php '.$code;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
$this->assertSame($expectedWarnings, $file->getWarningCount());
$this->assertCount($expectedWarnings, $file->getWarnings());
}//end testEnableSelected()
/**
* Data provider.
*
* @see testEnableSelected()
*
* @return array
*/
public function dataEnableSelected()
{
return [
'disable/enable: a single sniff' => [
'code' => '
// phpcs:disable Generic.Commenting.Todo
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting.Todo
//TODO: write some code',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable/enable: multiple sniffs' => [
'code' => '
// phpcs:disable Generic.Commenting.Todo,Generic.PHP.LowerCaseConstant
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting.Todo,Generic.PHP.LowerCaseConstant
//TODO: write some code
$var = FALSE;',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: multiple sniffs; enable: one' => [
'code' => '
# phpcs:disable Generic.Commenting.Todo,Generic.PHP.LowerCaseConstant
$var = FALSE;
//TODO: write some code
# phpcs:enable Generic.Commenting.Todo
//TODO: write some code
$var = FALSE;',
'expectedErrors' => 0,
'expectedWarnings' => 1,
],
'disable/enable: complete category' => [
'code' => '
// phpcs:disable Generic.Commenting
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting
//TODO: write some code',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable/enable: whole standard' => [
'code' => '
// phpcs:disable Generic
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic
//TODO: write some code',
'expectedErrors' => 0,
'expectedWarnings' => 1,
],
'disable: whole standard; enable: category from the standard' => [
'code' => '
// phpcs:disable Generic
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting
//TODO: write some code',
'expectedErrors' => 0,
'expectedWarnings' => 1,
],
'disable: a category; enable: the whole standard containing the category' => [
'code' => '
# phpcs:disable Generic.Commenting
$var = FALSE;
//TODO: write some code
# phpcs:enable Generic
//TODO: write some code',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: single sniff; enable: the category containing the sniff' => [
'code' => '
// phpcs:disable Generic.Commenting.Todo
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting
//TODO: write some code',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: whole standard; enable: single sniff from the standard' => [
'code' => '
// phpcs:disable Generic
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting.Todo
//TODO: write some code',
'expectedErrors' => 0,
'expectedWarnings' => 1,
],
'disable: whole standard; enable: single sniff from the standard; disable: that same sniff; enable: everything' => [
'code' => '
// phpcs:disable Generic
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting.Todo
//TODO: write some code
// phpcs:disable Generic.Commenting.Todo
//TODO: write some code
// phpcs:enable
//TODO: write some code',
'expectedErrors' => 0,
'expectedWarnings' => 2,
],
'disable: whole standard; enable: single sniff from the standard; enable: other sniff from the standard' => [
'code' => '
// phpcs:disable Generic
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting.Todo
//TODO: write some code
$var = FALSE;
// phpcs:enable Generic.PHP.LowerCaseConstant
//TODO: write some code
$var = FALSE;',
'expectedErrors' => 1,
'expectedWarnings' => 2,
],
];
}//end dataEnableSelected()
/**
* Test ignoring specific sniffs.
*
* @param string $before Annotation to place before the code.
* @param int $expectedErrors Number of errors expected.
* @param int $expectedWarnings Number of warnings expected.
*
* @dataProvider dataIgnoreSelected
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testIgnoreSelected($before, $expectedErrors, $expectedWarnings)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = [
'Generic.PHP.LowerCaseConstant',
'Generic.Commenting.Todo',
];
$ruleset = new Ruleset($config);
}
$content = <<<EOD
<?php
$before
\$var = FALSE; //TODO: write some code
\$var = FALSE; //TODO: write some code
EOD;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
$this->assertSame($expectedWarnings, $file->getWarningCount());
$this->assertCount($expectedWarnings, $file->getWarnings());
}//end testIgnoreSelected()
/**
* Data provider.
*
* @see testIgnoreSelected()
*
* @return array
*/
public function dataIgnoreSelected()
{
return [
'no suppression' => [
'before' => '',
'expectedErrors' => 2,
'expectedWarnings' => 2,
],
// With suppression.
'ignore: single sniff' => [
'before' => '// phpcs:ignore Generic.Commenting.Todo',
'expectedErrors' => 2,
'expectedWarnings' => 1,
],
'ignore: multiple sniffs' => [
'before' => '// phpcs:ignore Generic.Commenting.Todo,Generic.PHP.LowerCaseConstant',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: single sniff; ignore: single sniff' => [
'before' => '// phpcs:disable Generic.Commenting.Todo'.PHP_EOL.'// phpcs:ignore Generic.PHP.LowerCaseConstant',
'expectedErrors' => 1,
'expectedWarnings' => 0,
],
'ignore: category of sniffs' => [
'before' => '# phpcs:ignore Generic.Commenting',
'expectedErrors' => 2,
'expectedWarnings' => 1,
],
'ignore: whole standard' => [
'before' => '// phpcs:ignore Generic',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
];
}//end dataIgnoreSelected()
/**
* Test ignoring specific sniffs.
*
* @param string $code Code pattern to check.
* @param int $expectedErrors Number of errors expected.
* @param int $expectedWarnings Number of warnings expected.
*
* @dataProvider dataCommenting
* @covers PHP_CodeSniffer\Tokenizers\Tokenizer::createPositionMap
*
* @return void
*/
public function testCommenting($code, $expectedErrors, $expectedWarnings)
{
static $config, $ruleset;
if (isset($config, $ruleset) === false) {
$config = new Config();
$config->standards = ['Generic'];
$config->sniffs = [
'Generic.PHP.LowerCaseConstant',
'Generic.Commenting.Todo',
];
$ruleset = new Ruleset($config);
}
$content = '<?php '.$code;
$file = new DummyFile($content, $ruleset, $config);
$file->process();
$this->assertSame($expectedErrors, $file->getErrorCount());
$this->assertCount($expectedErrors, $file->getErrors());
$this->assertSame($expectedWarnings, $file->getWarningCount());
$this->assertCount($expectedWarnings, $file->getWarnings());
}//end testCommenting()
/**
* Data provider.
*
* @see testCommenting()
*
* @return array
*/
public function dataCommenting()
{
return [
'ignore: single sniff' => [
'code' => '
// phpcs:ignore Generic.Commenting.Todo -- Because reasons
$var = FALSE; //TODO: write some code
$var = FALSE; //TODO: write some code',
'expectedErrors' => 2,
'expectedWarnings' => 1,
],
'disable: single sniff; enable: same sniff - test whitespace handling around reason delimiter' => [
'code' => '
// phpcs:disable Generic.Commenting.Todo --Because reasons
$var = FALSE;
//TODO: write some code
// phpcs:enable Generic.Commenting.Todo -- Because reasons
//TODO: write some code',
'expectedErrors' => 1,
'expectedWarnings' => 1,
],
'disable: single sniff, multi-line comment' => [
'code' => '
/*
Disable some checks
phpcs:disable Generic.Commenting.Todo
*/
$var = FALSE;
//TODO: write some code',
'expectedErrors' => 1,
'expectedWarnings' => 0,
],
'ignore: single sniff, multi-line slash comment' => [
'code' => '
// Turn off a check for the next line of code.
// phpcs:ignore Generic.Commenting.Todo
$var = FALSE; //TODO: write some code
$var = FALSE; //TODO: write some code',
'expectedErrors' => 2,
'expectedWarnings' => 1,
],
'enable before disable, sniff not in standard' => [
'code' => '
// phpcs:enable Generic.PHP.NoSilencedErrors -- Because reasons
$var = @delete( $filename );
',
'expectedErrors' => 0,
'expectedWarnings' => 0,
],
];
}//end dataCommenting()
}//end class
|