1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
|
<?php
declare(strict_types=1);
namespace Doctrine\DBAL\Tests\Functional;
use Doctrine\DBAL\Platforms\DB2Platform;
use Doctrine\DBAL\Platforms\OraclePlatform;
use Doctrine\DBAL\Platforms\SQLServerPlatform;
use Doctrine\DBAL\Schema\Column;
use Doctrine\DBAL\Schema\PrimaryKeyConstraint;
use Doctrine\DBAL\Schema\Table;
use Doctrine\DBAL\Tests\FunctionalTestCase;
use Doctrine\DBAL\Types\Types;
use function array_change_key_case;
use function count;
use const CASE_LOWER;
class ModifyLimitQueryTest extends FunctionalTestCase
{
protected function setUp(): void
{
$table = Table::editor()
->setUnquotedName('modify_limit_table')
->setColumns(
Column::editor()
->setUnquotedName('test_int')
->setTypeName(Types::INTEGER)
->create(),
)
->setPrimaryKeyConstraint(
PrimaryKeyConstraint::editor()
->setUnquotedColumnNames('test_int')
->create(),
)
->create();
$table2 = Table::editor()
->setUnquotedName('modify_limit_table2')
->setColumns(
Column::editor()
->setUnquotedName('id')
->setTypeName(Types::INTEGER)
->setAutoincrement(true)
->create(),
Column::editor()
->setUnquotedName('test_int')
->setTypeName(Types::INTEGER)
->create(),
)
->setPrimaryKeyConstraint(
PrimaryKeyConstraint::editor()
->setUnquotedColumnNames('id')
->create(),
)
->create();
$this->dropAndCreateTable($table);
$this->dropAndCreateTable($table2);
}
public function testModifyLimitQuerySimpleQuery(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table', ['test_int' => 3]);
$this->connection->insert('modify_limit_table', ['test_int' => 4]);
$sql = 'SELECT * FROM modify_limit_table ORDER BY test_int ASC';
$this->assertLimitResult([1, 2, 3, 4], $sql, 10, 0);
$this->assertLimitResult([1, 2], $sql, 2, 0);
$this->assertLimitResult([3, 4], $sql, 2, 2);
$this->assertLimitResult([2, 3, 4], $sql, null, 1);
}
public function testModifyLimitQueryJoinQuery(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 2]);
$this->connection->insert('modify_limit_table2', ['test_int' => 2]);
$sql = 'SELECT modify_limit_table.test_int'
. ' FROM modify_limit_table'
. ' INNER JOIN modify_limit_table2'
. ' ON modify_limit_table.test_int = modify_limit_table2.test_int'
. ' ORDER BY modify_limit_table.test_int DESC';
$this->assertLimitResult([2, 2, 1, 1, 1], $sql, 10, 0);
$this->assertLimitResult([1, 1, 1], $sql, 3, 2);
$this->assertLimitResult([2, 2], $sql, 2, 0);
}
public function testModifyLimitQueryNonDeterministic(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table', ['test_int' => 3]);
$this->connection->insert('modify_limit_table', ['test_int' => 4]);
$sql = 'SELECT * FROM modify_limit_table';
$this->assertLimitResult([4, 3, 2, 1], $sql, 10, 0, false);
$this->assertLimitResult([4, 3], $sql, 2, 0, false);
$this->assertLimitResult([2, 1], $sql, 2, 2, false);
}
public function testModifyLimitQueryGroupBy(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 2]);
$this->connection->insert('modify_limit_table2', ['test_int' => 2]);
$sql = 'SELECT modify_limit_table.test_int FROM modify_limit_table ' .
'INNER JOIN modify_limit_table2 ON modify_limit_table.test_int = modify_limit_table2.test_int ' .
'GROUP BY modify_limit_table.test_int ' .
'ORDER BY modify_limit_table.test_int ASC';
$this->assertLimitResult([1, 2], $sql, 10, 0);
$this->assertLimitResult([1], $sql, 1, 0);
$this->assertLimitResult([2], $sql, 1, 1);
}
public function testModifyLimitQuerySubSelect(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table', ['test_int' => 3]);
$this->connection->insert('modify_limit_table', ['test_int' => 4]);
$sql = 'SELECT modify_limit_table.*, (SELECT COUNT(*) FROM modify_limit_table) AS cnt'
. ' FROM modify_limit_table ORDER BY test_int DESC';
$this->assertLimitResult([4, 3, 2, 1], $sql, 10, 0);
$this->assertLimitResult([4, 3], $sql, 2, 0);
$this->assertLimitResult([2, 1], $sql, 2, 2);
}
public function testModifyLimitQueryFromSubSelect(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table', ['test_int' => 3]);
$this->connection->insert('modify_limit_table', ['test_int' => 4]);
$sql = 'SELECT * FROM (SELECT * FROM modify_limit_table) sub ORDER BY test_int DESC';
$this->assertLimitResult([4, 3, 2, 1], $sql, 10, 0);
$this->assertLimitResult([4, 3], $sql, 2, 0);
$this->assertLimitResult([2, 1], $sql, 2, 2);
}
public function testModifyLimitQueryLineBreaks(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$this->connection->insert('modify_limit_table', ['test_int' => 3]);
$sql = <<<'SQL'
SELECT
*
FROM
modify_limit_table
ORDER
BY
test_int
ASC
SQL;
$this->assertLimitResult([2], $sql, 1, 1);
}
public function testModifyLimitQueryZeroOffsetNoLimit(): void
{
$this->connection->insert('modify_limit_table', ['test_int' => 1]);
$this->connection->insert('modify_limit_table', ['test_int' => 2]);
$sql = 'SELECT test_int FROM modify_limit_table ORDER BY test_int ASC';
$this->assertLimitResult([1, 2], $sql, null, 0);
}
/** @param array<int, int> $expectedResults */
private function assertLimitResult(
array $expectedResults,
string $sql,
?int $limit,
int $offset,
bool $deterministic = true,
): void {
$p = $this->connection->getDatabasePlatform();
$data = [];
foreach ($this->connection->fetchAllAssociative($p->modifyLimitQuery($sql, $limit, $offset)) as $row) {
$row = array_change_key_case($row, CASE_LOWER);
$data[] = $row['test_int'];
}
/**
* Do not assert the order of results when results are non-deterministic
*/
if ($deterministic) {
self::assertEquals($expectedResults, $data);
} else {
self::assertCount(count($expectedResults), $data);
}
}
public function testLimitWhenOrderByWithSubqueryWithOrderBy(): void
{
$platform = $this->connection->getDatabasePlatform();
if ($platform instanceof DB2Platform) {
self::markTestSkipped('DB2 cannot handle ORDER BY in subquery');
}
if ($platform instanceof OraclePlatform) {
self::markTestSkipped('Oracle cannot handle ORDER BY in subquery');
}
$this->connection->insert('modify_limit_table2', ['test_int' => 3]);
$this->connection->insert('modify_limit_table2', ['test_int' => 1]);
$this->connection->insert('modify_limit_table2', ['test_int' => 2]);
$subquery = 'SELECT test_int FROM modify_limit_table2 T2 WHERE T1.id=T2.id ORDER BY test_int';
if ($platform instanceof SQLServerPlatform) {
$subquery .= ' OFFSET 0 ROWS';
}
$sql = 'SELECT test_int FROM modify_limit_table2 T1 ORDER BY (' . $subquery . ') ASC';
$this->assertLimitResult([1, 2, 3], $sql, 10, 0);
}
}
|
