1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599
|
# -*- coding: utf-8 -*-
#
# Picard, the next-generation MusicBrainz tagger
#
# Copyright (C) 2017 Sambhav Kothari
# Copyright (C) 2017-2018 Wieland Hoffmann
# Copyright (C) 2018, 2020-2021 Laurent Monin
# Copyright (C) 2019-2022 Philipp Wolfer
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
import sys
from unittest.mock import (
MagicMock,
patch,
)
from PyQt5.QtCore import QUrl
from PyQt5.QtNetwork import (
QNetworkProxy,
QNetworkRequest,
)
from test.picardtestcase import PicardTestCase
from picard import config
from picard.webservice import (
TEMP_ERRORS_RETRIES,
RequestPriorityQueue,
RequestTask,
UnknownResponseParserError,
WebService,
WSRequest,
ratecontrol,
)
from picard.webservice.utils import (
host_port_to_url,
hostkey_from_url,
port_from_qurl,
)
PROXY_SETTINGS = {
"use_proxy": True,
"proxy_type": 'http',
"proxy_server_host": '127.0.0.1',
"proxy_server_port": 3128,
"proxy_username": 'user',
"proxy_password": 'password',
"network_transfer_timeout_seconds": 30,
}
def dummy_handler(*args, **kwargs):
"""Dummy handler method for tests"""
class WebServiceTest(PicardTestCase):
def setUp(self):
super().setUp()
self.set_config_values({
'use_proxy': False,
'server_host': '',
'network_transfer_timeout_seconds': 30,
})
self.ws = WebService()
@patch.object(WebService, 'add_task')
def test_webservice_method_calls(self, mock_add_task):
host = "abc.xyz"
port = 80
path = ""
handler = dummy_handler
data = None
def get_wsreq(mock_add_task):
return mock_add_task.call_args[0][1]
self.ws.get(host, port, path, handler)
self.assertEqual(1, mock_add_task.call_count)
self.assertEqual(host, get_wsreq(mock_add_task).host)
self.assertEqual(port, get_wsreq(mock_add_task).port)
self.assertIn("GET", get_wsreq(mock_add_task).method)
self.ws.post(host, port, path, data, handler)
self.assertIn("POST", get_wsreq(mock_add_task).method)
self.ws.put(host, port, path, data, handler)
self.assertIn("PUT", get_wsreq(mock_add_task).method)
self.ws.delete(host, port, path, handler)
self.assertIn("DELETE", get_wsreq(mock_add_task).method)
self.ws.download(host, port, path, handler)
self.assertIn("GET", get_wsreq(mock_add_task).method)
self.assertEqual(5, mock_add_task.call_count)
@patch.object(WebService, 'add_task')
def test_webservice_url_method_calls(self, mock_add_task):
url = "http://abc.xyz"
handler = dummy_handler
data = None
def get_wsreq(mock_add_task):
return mock_add_task.call_args[0][1]
self.ws.get_url(url=url, handler=handler)
self.assertEqual(1, mock_add_task.call_count)
self.assertEqual('abc.xyz', get_wsreq(mock_add_task).host)
self.assertEqual(80, get_wsreq(mock_add_task).port)
self.assertIn("GET", get_wsreq(mock_add_task).method)
self.ws.post_url(url=url, data=data, handler=handler)
self.assertIn("POST", get_wsreq(mock_add_task).method)
self.ws.put_url(url=url, data=data, handler=handler)
self.assertIn("PUT", get_wsreq(mock_add_task).method)
self.ws.delete_url(url=url, handler=handler)
self.assertIn("DELETE", get_wsreq(mock_add_task).method)
self.ws.download_url(url=url, handler=handler)
self.assertIn("GET", get_wsreq(mock_add_task).method)
self.assertEqual(5, mock_add_task.call_count)
class WebServiceTaskTest(PicardTestCase):
def setUp(self):
super().setUp()
self.set_config_values({
'use_proxy': False,
'network_transfer_timeout_seconds': 30,
})
self.ws = WebService()
self.queue = self.ws._queue = MagicMock()
# Patching the QTimers since they can only be started in a QThread
self.ws._timer_run_next_task = MagicMock()
self.ws._timer_count_pending_requests = MagicMock()
def test_add_task(self):
request = WSRequest(
method='GET',
url='http://abc.xyz',
handler=dummy_handler,
)
func = 1
task = self.ws.add_task(func, request)
self.assertEqual((request.get_host_key(), func, 0), task)
self.ws._queue.add_task.assert_called_with(task, False)
request.important = True
task = self.ws.add_task(func, request)
self.ws._queue.add_task.assert_called_with(task, True)
def test_add_task_calls_timers(self):
mock_timer1 = self.ws._timer_run_next_task
mock_timer2 = self.ws._timer_count_pending_requests
request = WSRequest(
method='GET',
url='http://abc.xyz',
handler=dummy_handler,
)
self.ws.add_task(0, request)
mock_timer1.start.assert_not_called()
mock_timer2.start.assert_not_called()
# Test if timer start was called in case it was inactive
mock_timer1.isActive.return_value = False
mock_timer2.isActive.return_value = False
self.ws.add_task(0, request)
mock_timer1.start.assert_called_with(0)
mock_timer2.start.assert_called_with(0)
def test_remove_task(self):
task = RequestTask(('example.com', 80), dummy_handler, priority=0)
self.ws.remove_task(task)
self.ws._queue.remove_task.assert_called_with(task)
def test_remove_task_calls_timers(self):
mock_timer = self.ws._timer_count_pending_requests
task = RequestTask(('example.com', 80), dummy_handler, priority=0)
self.ws.remove_task(task)
mock_timer.start.assert_not_called()
mock_timer.isActive.return_value = False
self.ws.remove_task(task)
mock_timer.start.assert_called_with(0)
def test_run_next_task(self):
mock_timer = self.ws._timer_run_next_task
self.ws._queue.run_ready_tasks.return_value = sys.maxsize
self.ws._run_next_task()
self.ws._queue.run_ready_tasks.assert_called()
mock_timer.start.assert_not_called()
def test_run_next_task_starts_next(self):
mock_timer = self.ws._timer_run_next_task
delay = 42
self.ws._queue.run_ready_tasks.return_value = delay
self.ws._run_next_task()
self.ws._queue.run_ready_tasks.assert_called()
mock_timer.start.assert_called_with(42)
class RequestTaskTest(PicardTestCase):
def test_from_request(self):
request = WSRequest(
method='GET',
url='https://example.com',
handler=dummy_handler,
priority=True,
)
func = 1
task = RequestTask.from_request(request, func)
self.assertEqual(request.get_host_key(), task.hostkey)
self.assertEqual(func, task.func)
self.assertEqual(1, task.priority)
self.assertEqual((request.get_host_key(), func, 1), task)
class RequestPriorityQueueTest(PicardTestCase):
def test_add_task(self):
queue = RequestPriorityQueue(ratecontrol)
key = ("abc.xyz", 80)
task1 = RequestTask(key, dummy_handler, priority=0)
queue.add_task(task1)
task2 = RequestTask(key, dummy_handler, priority=1)
queue.add_task(task2)
task3 = RequestTask(key, dummy_handler, priority=0)
queue.add_task(task3, important=True)
task4 = RequestTask(key, dummy_handler, priority=1)
queue.add_task(task4, important=True)
# Test if 2 requests were added in each queue
self.assertEqual(len(queue._queues[0][key]), 2)
self.assertEqual(len(queue._queues[1][key]), 2)
# Test if important request was added ahead in the queue
self.assertEqual(queue._queues[0][key][0], task3.func)
self.assertEqual(queue._queues[0][key][1], task1.func)
self.assertEqual(queue._queues[1][key][0], task4.func)
self.assertEqual(queue._queues[1][key][1], task2.func)
def test_remove_task(self):
queue = RequestPriorityQueue(ratecontrol)
key = ("abc.xyz", 80)
# Add a task and check for its existence
task = RequestTask(key, dummy_handler, priority=0)
task = queue.add_task(task)
self.assertIn(key, queue._queues[0])
self.assertEqual(len(queue._queues[0][key]), 1)
# Remove the task and check
queue.remove_task(task)
self.assertIn(key, queue._queues[0])
self.assertEqual(len(queue._queues[0][key]), 0)
# Try to remove a non existing task and check for errors
non_existing_task = (1, "a", "b")
queue.remove_task(non_existing_task)
def test_run_task(self):
mock_ratecontrol = MagicMock()
delay_func = mock_ratecontrol.get_delay_to_next_request = MagicMock()
queue = RequestPriorityQueue(mock_ratecontrol)
key = ("abc.xyz", 80)
# Patching the get delay function to delay the 2nd task on queue to the next call
delay_func.side_effect = [(False, 0), (True, 0), (False, 0), (False, 0), (False, 0), (False, 0)]
func1 = MagicMock()
task1 = RequestTask(key, func1, priority=0)
queue.add_task(task1)
func2 = MagicMock()
task2 = RequestTask(key, func2, priority=1)
queue.add_task(task2)
task3 = RequestTask(key, func1, priority=0)
queue.add_task(task3)
task4 = RequestTask(key, func1, priority=0)
queue.add_task(task4)
# Ensure no tasks are run before run_next_task is called
self.assertEqual(func1.call_count, 0)
queue.run_ready_tasks()
# Ensure priority task is run first
self.assertEqual(func2.call_count, 1)
self.assertEqual(func1.call_count, 0)
self.assertIn(key, queue._queues[1])
# Ensure that the calls are run as expected
queue.run_ready_tasks()
self.assertEqual(func1.call_count, 1)
# Checking if the cleanup occurred on the prio queue
self.assertNotIn(key, queue._queues[1])
# Check the call counts on proper execution of tasks
queue.run_ready_tasks()
self.assertEqual(func1.call_count, 2)
queue.run_ready_tasks()
self.assertEqual(func1.call_count, 3)
# Ensure that the clean up happened on the normal queue
queue.run_ready_tasks()
self.assertEqual(func1.call_count, 3)
self.assertNotIn(key, queue._queues[0])
def test_count(self):
queue = RequestPriorityQueue(ratecontrol)
key = ("abc.xyz", 80)
self.assertEqual(0, queue.count())
task1 = RequestTask(key, dummy_handler, priority=0)
queue.add_task(task1)
self.assertEqual(1, queue.count())
task2 = RequestTask(key, dummy_handler, priority=1)
queue.add_task(task2)
self.assertEqual(2, queue.count())
task3 = RequestTask(key, dummy_handler, priority=0)
queue.add_task(task3, important=True)
self.assertEqual(3, queue.count())
task4 = RequestTask(key, dummy_handler, priority=1)
queue.add_task(task4, important=True)
self.assertEqual(4, queue.count())
queue.remove_task(task1)
self.assertEqual(3, queue.count())
queue.remove_task(task2)
self.assertEqual(2, queue.count())
queue.remove_task(task3)
self.assertEqual(1, queue.count())
queue.remove_task(task4)
self.assertEqual(0, queue.count())
class WebServiceProxyTest(PicardTestCase):
def setUp(self):
super().setUp()
self.set_config_values(PROXY_SETTINGS)
def test_proxy_setup(self):
proxy_types = [
('http', QNetworkProxy.ProxyType.HttpProxy),
('socks', QNetworkProxy.ProxyType.Socks5Proxy),
]
for proxy_type, expected_qt_type in proxy_types:
config.setting['proxy_type'] = proxy_type
ws = WebService()
proxy = ws.manager.proxy()
self.assertEqual(proxy.type(), expected_qt_type)
self.assertEqual(proxy.user(), PROXY_SETTINGS['proxy_username'])
self.assertEqual(proxy.password(), PROXY_SETTINGS['proxy_password'])
self.assertEqual(proxy.hostName(), PROXY_SETTINGS['proxy_server_host'])
self.assertEqual(proxy.port(), PROXY_SETTINGS['proxy_server_port'])
class ParserHookTest(PicardTestCase):
def test_parser_hook(self):
WebService.add_parser('A', 'mime', 'parser')
self.assertIn('A', WebService.PARSERS)
self.assertEqual(WebService.PARSERS['A'].mimetype, 'mime')
self.assertEqual(WebService.PARSERS['A'].mimetype, WebService.get_response_mimetype('A'))
self.assertEqual(WebService.PARSERS['A'].parser, 'parser')
self.assertEqual(WebService.PARSERS['A'].parser, WebService.get_response_parser('A'))
with self.assertRaises(UnknownResponseParserError):
WebService.get_response_parser('B')
with self.assertRaises(UnknownResponseParserError):
WebService.get_response_mimetype('B')
class WSRequestTest(PicardTestCase):
def test_init_minimal(self):
request = WSRequest(url='https://example.org/path', method='GET', handler=dummy_handler)
self.assertEqual(request.host, 'example.org')
self.assertEqual(request.port, 443)
self.assertEqual(request.path, '/path')
self.assertEqual(request.handler, dummy_handler)
self.assertEqual(request.method, 'GET')
self.assertEqual(request.get_host_key(), ('example.org', 443))
self.assertIsNone(request.parse_response_type)
self.assertIsNone(request.data)
self.assertIsNone(request.cacheloadcontrol)
self.assertIsNone(request.request_mimetype)
self.assertFalse(request.mblogin)
self.assertFalse(request.refresh)
self.assertFalse(request.priority)
self.assertFalse(request.important)
self.assertFalse(request.has_auth)
def test_init_minimal_extra(self):
request = WSRequest(
url='https://example.org/path',
method='GET',
handler=dummy_handler,
priority=True,
important=True,
refresh=True,
)
self.assertTrue(request.priority)
self.assertTrue(request.important)
self.assertTrue(request.refresh)
def test_init_minimal_qurl(self):
url = 'https://example.org/path?q=1'
request = WSRequest(url=QUrl(url), method='GET', handler=dummy_handler)
self.assertEqual(request.url().toString(), url)
def test_init_port_80(self):
request = WSRequest(url='http://example.org/path', method='GET', handler=dummy_handler)
self.assertEqual(request.port, 80)
def test_init_port_other(self):
request = WSRequest(url='http://example.org:666/path', method='GET', handler=dummy_handler)
self.assertEqual(request.port, 666)
def test_missing_url(self):
with self.assertRaises(AssertionError):
WSRequest(method='GET', handler=dummy_handler)
def test_missing_method(self):
with self.assertRaises(AssertionError):
WSRequest(url='http://x', handler=dummy_handler)
def test_missing_handler(self):
with self.assertRaises(AssertionError):
WSRequest(url='http://x', method='GET')
def test_invalid_method(self):
with self.assertRaises(AssertionError):
WSRequest(url='http://x', method='XXX', handler=dummy_handler)
def test_set_cacheloadcontrol(self):
request = WSRequest(
url='http://example.org/path',
method='GET',
handler=dummy_handler,
cacheloadcontrol=QNetworkRequest.CacheLoadControl.AlwaysNetwork,
)
self.assertEqual(request.cacheloadcontrol, QNetworkRequest.CacheLoadControl.AlwaysNetwork)
def test_set_parse_response_type(self):
WebService.add_parser('A', 'mime', 'parser')
request = WSRequest(
url='http://example.org/path',
method='GET',
handler=dummy_handler,
parse_response_type='A',
)
self.assertEqual(request.response_mimetype, 'mime')
self.assertEqual(request.response_parser, 'parser')
def test_set_invalid_parse_response_type(self):
WebService.add_parser('A', 'mime', 'parser')
request = WSRequest(
url='http://example.org/path',
method='GET',
handler=dummy_handler,
parse_response_type='invalid',
)
self.assertEqual(request.response_mimetype, None)
self.assertEqual(request.response_parser, None)
def test_set_mblogin_access_token(self):
request = WSRequest(
url='http://example.org/path',
method='POST',
handler=dummy_handler,
)
# setter
request.mblogin = 'test'
# getter
self.assertEqual(request.mblogin, 'test')
# auth needs a token too
self.assertFalse(request.has_auth)
# setter
request.access_token = 'token' # nosec
# getter
self.assertEqual(request.access_token, 'token')
# auth is now possible
self.assertTrue(request.has_auth)
def test_set_data(self):
request = WSRequest(
url='http://example.org/path',
method='POST',
handler=dummy_handler,
data='data',
)
self.assertEqual(request.data, 'data')
def test_set_retries_reached(self):
request = WSRequest(
url='http://example.org/path',
method='GET',
handler=dummy_handler,
)
for i in range(0, TEMP_ERRORS_RETRIES):
self.assertEqual(request.mark_for_retry(), i+1)
self.assertTrue(request.max_retries_reached())
def test_set_retries_not_reached(self):
request = WSRequest(
url='http://example.org/path',
method='GET',
handler=dummy_handler,
)
self.assertTrue(TEMP_ERRORS_RETRIES > 1)
self.assertEqual(request.mark_for_retry(), 1)
self.assertFalse(request.max_retries_reached())
def test_queryargs(self):
request = WSRequest(
url='http://example.org/path?a=1',
method='GET',
handler=dummy_handler,
queryargs={'a': 2, 'b': 'x%20x', 'c': '1+2', 'd': '&', 'e': '?'},
)
expected = 'http://example.org/path?a=1&a=2&b=x x&c=1+2&d=%26&e=?'
self.assertEqual(request.url().toString(), expected)
def test_unencoded_queryargs(self):
request = WSRequest(
url='http://example.org/path?a=1',
method='GET',
handler=dummy_handler,
unencoded_queryargs={'a': 2, 'b': 'x%20x', 'c': '1+2', 'd': '&', 'e': '?'},
)
expected = 'http://example.org/path?a=1&a=2&b=x%2520x&c=1%2B2&d=%26&e=%3F'
self.assertEqual(request.url().toString(), expected)
def test_mixed_queryargs(self):
request = WSRequest(
url='http://example.org/path?a=1',
method='GET',
handler=dummy_handler,
queryargs={'a': '2&', 'b': '1&', 'c': '&'},
unencoded_queryargs={'a': '1&', 'b': '2&', 'd': '&'},
)
expected = 'http://example.org/path?a=1&a=1%26&b=2%26&c=%26&d=%26'
self.assertEqual(request.url().toString(), expected)
class WebServiceUtilsTest(PicardTestCase):
def test_port_from_qurl_http(self):
self.assertEqual(port_from_qurl(QUrl('http://example.org')), 80)
def test_port_from_qurl_http_other(self):
self.assertEqual(port_from_qurl(QUrl('http://example.org:666')), 666)
def test_port_from_qurl_https(self):
self.assertEqual(port_from_qurl(QUrl('https://example.org')), 443)
def test_port_from_qurl_https_other(self):
self.assertEqual(port_from_qurl(QUrl('https://example.org:666')), 666)
def test_port_from_qurl_exception(self):
with self.assertRaises(AttributeError):
port_from_qurl('xxx')
def test_hostkey_from_qurl_http(self):
self.assertEqual(hostkey_from_url(QUrl('http://example.org')), ('example.org', 80))
def test_hostkey_from_url_https_other(self):
self.assertEqual(hostkey_from_url('https://example.org:666'), ('example.org', 666))
def test_host_port_to_url_http_80(self):
self.assertEqual(host_port_to_url('example.org', 80, as_string=True), 'http://example.org')
def test_host_port_to_url_http_80_qurl(self):
self.assertEqual(host_port_to_url('example.org', 80).toString(), 'http://example.org')
def test_host_port_to_url_https_443(self):
self.assertEqual(host_port_to_url('example.org', 443, as_string=True), 'https://example.org')
def test_host_port_to_url_https_scheme_80(self):
self.assertEqual(host_port_to_url('example.org', 80, scheme='https', as_string=True), 'https://example.org:80')
def test_host_port_to_url_http_666_with_path(self):
self.assertEqual(host_port_to_url('example.org', 666, path='/abc', as_string=True), 'http://example.org:666/abc')
|