File: upstream_a5573c43_applets-kicker-reset-custom-icon-when-cleared.patch

package info (click to toggle)
plasma-desktop 4%3A6.3.6-1
  • links: PTS, VCS
  • area: main
  • in suites: forky, sid, trixie
  • size: 61,044 kB
  • sloc: cpp: 37,691; ansic: 2,617; python: 1,386; javascript: 1,163; xml: 1,082; sh: 128; makefile: 16
file content (36 lines) | stat: -rw-r--r-- 1,626 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
From a5573c43aa71f2cd6939074212f91399443f366e Mon Sep 17 00:00:00 2001
From: Christoph Wolk <cwo.kde@posteo.net>
Date: Sun, 6 Apr 2025 18:30:29 +0200
Subject: [PATCH] applets/kicker: reset custom icon when cleared

Kicker's configuration page has a somewhat complex handling of the
custom icon, which is spread across three properties. When the custom
icon is cleared, the property that governs which of the other properties
is used is set. but the actual icon is not cleared. This means that
setting and resetting the icon will still prompt the user to save the
changes to the (now unused) property. This would be meaningful if the
custom icon could be reactivated, but the only way to enable it again is
to set it again, at which point the stored value would be overwritten
anyway.

Instead, remove the value of the custom property as well if the icon is
cleared.
---
 applets/kicker/package/contents/ui/ConfigGeneral.qml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/applets/kicker/package/contents/ui/ConfigGeneral.qml b/applets/kicker/package/contents/ui/ConfigGeneral.qml
index 6692001eaf..574252275b 100644
--- a/applets/kicker/package/contents/ui/ConfigGeneral.qml
+++ b/applets/kicker/package/contents/ui/ConfigGeneral.qml
@@ -135,6 +135,7 @@ KCMUtils.SimpleKCM {
                     icon.name: "edit-clear"
                     onClicked: {
                         configGeneral.cfg_icon = "start-here-kde-symbolic"
+                        configGeneral.cfg_customButtonImage = ""
                         configGeneral.cfg_useCustomButtonImage = false
                     }
                 }
-- 
GitLab